x11/bhotkeys-screenshot: New port
ClosedPublic
Actions

Authored by dteske on Sat, Oct 10, 3:04 PM.

Details

Reviewers

fuz
jrm
adrian
emaste

Commits

R11:d0dcfed47a6c: x11/bhotkeys-screenshot: New port

Summary

Screenshot hotkeys for bhotkeys.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77971
Build 74854: arc lint + arc unit

Event Timeline

dteske requested review of this revision.Sat, Oct 10, 3:04 PM

dteske created this revision.

Harbormaster completed remote builds in B77962: Diff 189363.Sat, Oct 10, 3:04 PM

dteske added a parent revision: D60456: x11/bhotkeys: New port.Sat, Oct 10, 3:04 PM

jrm added inline comments.Sat, Oct 10, 4:04 PM

x11/bhotkeys-screenshot/Makefile
12	Maybe `x11/xprop` and/or `x11/xdotool` too, based on https://github.com/FrauBSD/bhotkeys-screenshot/blob/main/bin/window-screenshot#L66-L67.
12	Perhaps also `x11/xrandr` and `x11/xdpyinfo` too based on: https://github.com/FrauBSD/bhotkeys-screenshot/blob/main/bin/desktop-screenshot#L71 https://github.com/FrauBSD/bhotkeys-screenshot/blob/main/bin/desktop-screenshot#L197-L198.

dteske added inline comments.Sat, Oct 10, 6:25 PM

x11/bhotkeys-screenshot/Makefile

Good catches. All worthy adds. Only one minor note: xdotool is optional. window-screenshot can function without it.

Using make all-depends-list we can determine what other dependencies xdotool would add:

dteske@FreeBSD bhotkeys-screenshot $ make all-depends-list > a
dteske@FreeBSD bhotkeys-screenshot $ vi Makefile
# adds xdotool:x11/xdotool to RUN_DEPENDS
dteske@FreeBSD bhotkeys-screenshot $ make all-depends-list > b
dteske@FreeBSD bhotkeys-screenshot $ diff -pu a b | grep ^+/
+/usr/ports/x11/xdotool
+/usr/ports/x11/libXinerama
+/usr/ports/x11/libxkbcommon
+/usr/ports/x11/xkeyboard-config
+/usr/ports/x11/xkbcomp
+/usr/ports/x11/libxkbfile
+/usr/ports/graphics/wayland-protocols

It's that last one that gives me serious pause in adding xdotool as a hard RUN_DEPENDS entry.

I will absolutely add the others.