Page MenuHomeFreeBSD

kfv (Faraz Vahedi)
User

Projects (3)

User Details

User Since
Jun 14 2019, 6:43 AM (387 w, 3 d)

Recent Activity

Yesterday

kfv added a comment to D61584: sysrc: Add -r raw and fixup -c assignment check.

These are the only two things that've caught my eye so far. I'll have a closer look tomorrow, though.

Sun, Nov 15, 10:06 PM
kfv added a comment to D42106: Bug 235946 - column(1): Fill order (with/without -x) is incorrectly documented.

The manpage isn't actually wrong, just ambiguous, and I think that stems from the "fill" wording. By "filling columns" it means stepping through the column positions, which matches the code, but I agree hardly anyone will read it that way. The current wording misleads the end user, where the proposed wording misleads anyone reading the source, so IMHO it doesn't remove the ambiguity, it just moves it elsewhere. I'd rather we drop "fill" altogether and borrow something similar to ls(1); e.g. "Entries are arranged down the columns" for the default behaviour and "Arrange entries across, rather than down, the columns" for -x, or something like that.

Sun, Nov 15, 3:31 PM
kfv committed rG6871285f194d: sysconf: Add ucl and pkg targets.
Sun, Nov 15, 11:03 AM
kfv closed D61064: sysconf: Add ucl and pkg targets.
Sun, Nov 15, 11:03 AM
kfv retitled D61064: sysconf: Add ucl and pkg targets from sysconf: add ucl and pkg targets
Sun, Nov 15, 10:51 AM

Sat, Nov 14

kfv added a comment to D60642: libm: Implement iseqsig().

I've had some positive feedback from kargl@. Would it be alright to go ahead and land it?

Sat, Nov 14, 8:46 PM
kfv committed rG7940130c2e87: libc: Export timespec_getres(3) and add tests.
Sat, Nov 14, 9:42 AM
kfv committed rG96da6719c04e: libc: Fix stack buffer overflow in cgetnext().
Sat, Nov 14, 9:42 AM

Tue, Nov 10

kfv accepted D61344: devd: define _PATH_DEVD_SOCKET in <paths.h>.
Tue, Nov 10, 11:36 AM
kfv accepted D61345: unistd.h: sort sysconf(3) arguments.
Tue, Nov 10, 7:46 AM

Sat, Nov 7

kfv updated the diff for D61064: sysconf: Add ucl and pkg targets.

Address @dteske's feedback and add corresponding tests

Sat, Nov 7, 4:24 PM
kfv added a comment to D56673: libc/yp: fix memory issues and compiler warnings in xdryp.c.

(take @kfv's comments over mine - they know more about this area than I do)

Sat, Nov 7, 4:13 PM
kfv requested changes to D56673: libc/yp: fix memory issues and compiler warnings in xdryp.c.

Besides my inline comments:

Sat, Nov 7, 2:22 PM
kfv added a comment to D23880: libc/strptime(3): Handle ISO 8601 time zone formats in %z.

Thanks, the %z change looks good to me. Could you just rebase it onto main, please? Let me know if you're tied up and could use a hand.

Sat, Nov 7, 1:38 PM
kfv added a comment to D56673: libc/yp: fix memory issues and compiler warnings in xdryp.c.
Sat, Nov 7, 1:37 PM

Thu, Nov 5

kfv closed D60799: libc: Export timespec_getres(3) and add tests.
Thu, Nov 5, 8:12 PM
kfv committed rG3ac9299ee90c: libc: Export timespec_getres(3) and add tests.
Thu, Nov 5, 8:12 PM
kfv added a comment to D60799: libc: Export timespec_getres(3) and add tests.

Makes sense. Alright, I'll go ahead, then. Thanks!

Thu, Nov 5, 8:06 PM
kfv accepted D61228: virtio_random: defer first enqueue until after DRIVER_OK.
Thu, Nov 5, 6:54 PM
kfv added a comment to D60799: libc: Export timespec_getres(3) and add tests.

One question: code slush has been in effect since 23 October, and the releng/15.2 branch is due to be created tomorrow. Should I MFC after one day so that I can get it into stable/15 before the branch is created, or is it fine to proceed as proposed and MFC after a week?

Thu, Nov 5, 12:45 PM
kfv added a comment to D60799: libc: Export timespec_getres(3) and add tests.

No worries, mate. Cheers!

Thu, Nov 5, 12:32 PM

Wed, Nov 4

kfv added a comment to D61050: virtio_random: avoid using vtrnd_detach in the failure path.

Should we move the random instance inside the softc and make it work instead? Also means only paying for the space if you need it, not that it’s big.

Wed, Nov 4, 4:54 PM
kfv accepted D61052: virtio_pci_modern: enable virtqueues before completing attach.

LGTM. Thanks!

Wed, Nov 4, 8:19 AM
kfv accepted D61051: virtio_random: stop on detach, don't poll.

LGTM. Thanks!

Wed, Nov 4, 8:15 AM
kfv added a member for virtio: kfv.
Wed, Nov 4, 8:15 AM
kfv accepted D61050: virtio_random: avoid using vtrnd_detach in the failure path.

LGTM. Thanks!

Wed, Nov 4, 8:14 AM

Tue, Nov 3

kfv accepted D61047: tunefs(8): Add unit in the description of the -f parameter.

Thanks! Could you do the same for -g avgfilesize in newfs.8 while you’re here?

Tue, Nov 3, 6:45 PM
kfv added a comment to D60799: libc: Export timespec_getres(3) and add tests.

@ziaee: I would very much appreciate your review.

Tue, Nov 3, 6:00 PM

Mon, Nov 2

kfv committed rG8a08808fe07e: vtnet: Accept VIRTIO_NET_F_CTRL_RX_EXTRA.
Mon, Nov 2, 8:45 PM
kfv committed rG94e19d4178e6: vtnet: Implement VIRTIO_NET_F_GUEST_ANNOUNCE.
Mon, Nov 2, 8:45 PM

Sat, Oct 31

kfv updated the diff for D61064: sysconf: Add ucl and pkg targets.

Fix and harden the ucl and pkg write paths

Sat, Oct 31, 2:15 PM
kfv commandeered D61064: sysconf: Add ucl and pkg targets.

/me commandeers revision with Devin's blessing

Sat, Oct 31, 2:03 PM
kfv committed rG1a86e51f70e3: libc: Fix C23 version macro visibility (authored by des).
Sat, Oct 31, 10:07 AM
kfv committed rG908fae661a7f: libc: Add <inttypes.h> C23 feature test macro.
Sat, Oct 31, 10:07 AM
kfv committed rG1026dd139386: libm: Implement femode_t, fegetmode(), and fesetmode() as per C23.
Sat, Oct 31, 10:07 AM
kfv committed rG92bb927c768d: libc: Fix ATOMIC_VAR_INIT visibility (authored by des).
Sat, Oct 31, 10:07 AM
kfv committed rGe6cab850f131: libc: Add <setjmp.h> C23 feature test macro.
Sat, Oct 31, 10:07 AM
kfv committed rG71649bb9f522: libc: Add <time.h> C23 feature test macro.
Sat, Oct 31, 10:07 AM
kfv committed rG068271f0331d: libc: Restore prior C23 include guards.
Sat, Oct 31, 10:07 AM
kfv committed rG47f45c2cf2b9: libc: Add <stdio.h> C23 feature test macro.
Sat, Oct 31, 10:07 AM
kfv committed rGa76700665f67: libc/tests: Add assertions for BOOL_WIDTH, BOOL_MAX, and BITINT_MAXWIDTH.
Sat, Oct 31, 10:07 AM
kfv committed rG39dbfae2ca68: sys/limits.h: Fix typo.
Sat, Oct 31, 10:07 AM
kfv committed rG20ff5aa02534: sys/limits.h: Add BOOL_MAX, BITINT_MAXWIDTH, and C23 feature test macro.
Sat, Oct 31, 10:07 AM
kfv committed rG123200496e24: libc: Fix GCC pointer semantics for atomic_fetch_add/sub.
Sat, Oct 31, 10:07 AM
kfv committed rGaf116659c071: libc: Fix atomic_init for GCC atomic objects.
Sat, Oct 31, 10:07 AM
kfv committed rG53ba20bad789: libc: Enforce lock-free atomic_flag and C23-safe initialisation.
Sat, Oct 31, 10:07 AM
kfv committed rG650fea6abff7: libc: Reorder atomic operations to match ISO C standard.
Sat, Oct 31, 10:07 AM
kfv committed rGdb50099480e7: libc: Reorganise memory_order enumeration constants.
Sat, Oct 31, 10:07 AM
kfv committed rG127109e75d06: libc: Add missing kill_dependency macro.
Sat, Oct 31, 10:06 AM
kfv committed rG54916e236992: libc: Restrict ATOMIC_VAR_INIT for C23 conformance.
Sat, Oct 31, 10:06 AM
kfv committed rG7407dd9f47f2: libc: Add atomics C23 feature test macro.
Sat, Oct 31, 10:06 AM

Thu, Oct 29

kfv accepted D60980: vtnet: honor the advertised MTU limit on attach.

Thanks, that’s a very good catch!

Thu, Oct 29, 7:52 PM
kfv committed rG13bcc9a88260: libc: Fix stack buffer overflow in cgetnext().
Thu, Oct 29, 6:46 PM

Wed, Oct 21

kfv added a comment to D60799: libc: Export timespec_getres(3) and add tests.
In D60799#1397658, @fuz wrote:

Added man pages to reviewers (this means @ziaee). Not sure if the phrasing you used is what we would usually write. Code looks fine from what I can say.

Wed, Oct 21, 10:32 PM
kfv added a comment to D60897: virtio_console: Honour tty input flow control.
In D60897#1397156, @fuz wrote:

I wonder if this has deadlock potential if due to error the terminal never asserts that it is ready to receive more.

Wed, Oct 21, 9:12 PM
kfv updated the diff for D60895: virtio_console: Add system console support.

Address @ziaee's notes

Wed, Oct 21, 8:24 PM
kfv updated the diff for D60799: libc: Export timespec_getres(3) and add tests.
  • Update man page
  • Remove TIME_MONOTONIC + 1 from bad bases
Wed, Oct 21, 8:01 PM
kfv added a comment to D60799: libc: Export timespec_getres(3) and add tests.
In D60799#1397160, @fuz wrote:

@kfv Note that you can add multiple commits at once. I recommend only pushing an update once things are ready to be reviewed again (or marking intermediate states as WIP) so that reviewers don't waste time reviewing a WIP patch set.

Wed, Oct 21, 7:56 PM

Tue, Oct 20

kfv requested review of D60900: ttys: Add the VirtIO console.
Tue, Oct 20, 1:45 PM
kfv requested review of D60897: virtio_console: Honour tty input flow control.
Tue, Oct 20, 1:36 PM
kfv added a reviewer for D60895: virtio_console: Add system console support: avg.

This revisits D8680, abandoned in 2016, which predated the transmit path rework it needed.

Tue, Oct 20, 1:02 PM
kfv requested review of D60895: virtio_console: Add system console support.
Tue, Oct 20, 12:54 PM
kfv added inline comments to D60799: libc: Export timespec_getres(3) and add tests.
Tue, Oct 20, 10:22 AM
kfv updated the diff for D60799: libc: Export timespec_getres(3) and add tests.

Update manpage

Tue, Oct 20, 10:10 AM
kfv updated the diff for D60799: libc: Export timespec_getres(3) and add tests.

Move the symbol to FBSD_1.9

Tue, Oct 20, 9:54 AM
kfv updated the diff for D60799: libc: Export timespec_getres(3) and add tests.

Add tests

Tue, Oct 20, 9:45 AM
kfv retitled D60799: libc: Export timespec_getres(3) and add tests from libc: Export timespec_getres(3)
Tue, Oct 20, 9:45 AM
kfv committed rGb82b744b4ed3: libc: Preserve const qualifier on strchr(3), strrchr(3), and memchr(3) results.
Tue, Oct 20, 8:12 AM
kfv committed rGdca59708a0f2: libc: Remove incorrectly defined __STDC_VERSION_STDBOOL_H__.
Tue, Oct 20, 8:12 AM
kfv committed rG6ab9d003a0ad: libc: Add PRIb*, PRIB*, and SCNb* macros as per C23.
Tue, Oct 20, 8:12 AM
kfv committed rG13d25dc29879: libc: Add WCHAR_WIDTH in <wchar.h> as well.
Tue, Oct 20, 8:12 AM
kfv committed rG8f766130607e: libc: Add _PRINTF_NAN_LEN_MAX per C23.
Tue, Oct 20, 8:12 AM
kfv closed D60836: textproc/libgrapheme: Hook up the test suite.
Tue, Oct 20, 7:39 AM
kfv committed R11:d1de7051feea: textproc/libgrapheme: Hook up the test suite.
Tue, Oct 20, 7:39 AM
kfv added a comment to D60799: libc: Export timespec_getres(3) and add tests.
In D60799#1395151, @fuz wrote:

Might be a good opportunity to add a companion unit test.

Tue, Oct 20, 7:10 AM
kfv added inline comments to D60799: libc: Export timespec_getres(3) and add tests.
Tue, Oct 20, 7:09 AM
kfv added a comment to D60799: libc: Export timespec_getres(3) and add tests.
In D60799#1395747, @des wrote:

Please add an appropriate Fixes: line

Tue, Oct 20, 7:07 AM
kfv updated the summary of D60799: libc: Export timespec_getres(3) and add tests.
Tue, Oct 20, 7:02 AM

Sun, Oct 18

kfv added a comment to D60836: textproc/libgrapheme: Hook up the test suite.

BTW, I haven't bumped PORTREVISION as the package remains unchanged. Please let me know if I should, and I'll do it promptly.

Sun, Oct 18, 10:21 AM
kfv requested review of D60836: textproc/libgrapheme: Hook up the test suite.
Sun, Oct 18, 10:06 AM

Sat, Oct 17

kfv added a comment to D60773: textproc/libgrapheme: New port.

Make sure to either mention this DR on the new, or double-back here to mention the new DR (either way, it will successfully cross-link the two for others -- present and future -- to follow along)

Sat, Oct 17, 4:45 PM
kfv added a comment to D60773: textproc/libgrapheme: New port.
In D60773#1394406, @fuz wrote:
In D60773#1394388, @kfv wrote:

It's strange that you have to pass in CC and so on in MAKE_ARGS. Conventionally they are passed in through MAKE_ENV and it works.

That's true, it was just out of habit. I've been away from ports for quite a few years now, so apologies for the slip. I'll leave it as is for now but I'll keep this in mind going forward. I need to refresh my knowledge of the framework; I'll do shortly.

Please remove these variables if they aren't needed. Check make -VMAKE_ENV. If it's in there, you most likely don't have to pass it explicitly.
If you leave in the explicit assignment, this'll be very confusing to people wishing to make changes on your port, and it's best not to do stuff that is not needed.

Sat, Oct 17, 12:01 PM
kfv requested review of D60799: libc: Export timespec_getres(3) and add tests.
Sat, Oct 17, 9:17 AM

Oct 17 2026

kfv added a comment to D60773: textproc/libgrapheme: New port.

Can we please try to add unit test when possible to at least attempt to ensure that basic functionality works as intended?

Oct 17 2026, 7:05 AM
kfv closed D60773: textproc/libgrapheme: New port.
Oct 17 2026, 6:45 AM
kfv committed R11:77ef5ddf8a56: textproc/libgrapheme: New port.
Oct 17 2026, 6:45 AM
kfv added a comment to D60773: textproc/libgrapheme: New port.

It's strange that you have to pass in CC and so on in MAKE_ARGS. Conventionally they are passed in through MAKE_ENV and it works.

Oct 17 2026, 6:38 AM

Oct 16 2026

kfv updated the diff for D60773: textproc/libgrapheme: New port.

Remove unnecessary blank lines

Oct 16 2026, 6:46 PM
kfv requested review of D60773: textproc/libgrapheme: New port.
Oct 16 2026, 12:52 PM

Oct 12 2026

kfv requested review of D60642: libm: Implement iseqsig().
Oct 12 2026, 11:14 AM
kfv updated the diff for D60617: virtio_console: Add a second transmit buffer.

Define VTCON_TX_NBUFS to replace the magic number

Oct 12 2026, 7:35 AM
kfv added a comment to D60617: virtio_console: Add a second transmit buffer.
In D60617#1390001, @fuz wrote:

Please seek additional code review as I am not familiar with this subsystem.

Oct 12 2026, 6:56 AM

Oct 11 2026

kfv requested review of D60617: virtio_console: Add a second transmit buffer.
Oct 11 2026, 3:19 PM
kfv updated the diff for D60538: virtio_console: Make the transmit path usable without the tty lock.

Reclaim transmit buffers and stop TX before disabling interrupts

Oct 11 2026, 11:18 AM

Oct 10 2026

kfv requested review of D60582: virtio_console: Defer device notifications until DRIVER_OK.
Oct 10 2026, 12:31 PM
kfv updated the diff for D60538: virtio_console: Make the transmit path usable without the tty lock.

Drop redundant reference to prior behaviour

Oct 10 2026, 9:32 AM
kfv added a comment to D60538: virtio_console: Make the transmit path usable without the tty lock.

No, not really. It's for the console patch following in the series. That registers via cnadd()​ once the device is up (and the device doesn't exist at cninit()​ yet, so CONSOLE_DRIVER​ won't do), and its cn_putc()​/cn_getc()​ run under cnputs_mtx​ and in ddb/panic, so they cannot take the tty mutex. The deadlock fix alone doesn't strictly need the spin mutex, though; I just didn't want to rework the tx path twice. Happy to move it into the console patch if you’d rather keep this one minimal.

Oct 10 2026, 9:23 AM

Oct 9 2026

kfv requested review of D60538: virtio_console: Make the transmit path usable without the tty lock.
Oct 9 2026, 4:56 PM

Oct 3 2026

kfv committed rG40f4174d62aa: jail(8): Preserve const qualifier on strchr(3) results.
Oct 3 2026, 3:24 PM
kfv committed rGad60cb1085bc: pkg(7): Preserve const qualifier on strrchr(3) results.
Oct 3 2026, 3:24 PM