User Details
- User Since
- Jun 14 2019, 6:43 AM (387 w, 3 d)
Yesterday
These are the only two things that've caught my eye so far. I'll have a closer look tomorrow, though.
The manpage isn't actually wrong, just ambiguous, and I think that stems from the "fill" wording. By "filling columns" it means stepping through the column positions, which matches the code, but I agree hardly anyone will read it that way. The current wording misleads the end user, where the proposed wording misleads anyone reading the source, so IMHO it doesn't remove the ambiguity, it just moves it elsewhere. I'd rather we drop "fill" altogether and borrow something similar to ls(1); e.g. "Entries are arranged down the columns" for the default behaviour and "Arrange entries across, rather than down, the columns" for -x, or something like that.
Sat, Nov 14
I've had some positive feedback from kargl@. Would it be alright to go ahead and land it?
Tue, Nov 10
Sat, Nov 7
Address @dteske's feedback and add corresponding tests
Besides my inline comments:
Thanks, the %z change looks good to me. Could you just rebase it onto main, please? Let me know if you're tied up and could use a hand.
Thu, Nov 5
Makes sense. Alright, I'll go ahead, then. Thanks!
One question: code slush has been in effect since 23 October, and the releng/15.2 branch is due to be created tomorrow. Should I MFC after one day so that I can get it into stable/15 before the branch is created, or is it fine to proceed as proposed and MFC after a week?
No worries, mate. Cheers!
Wed, Nov 4
LGTM. Thanks!
LGTM. Thanks!
Tue, Nov 3
Thanks! Could you do the same for -g avgfilesize in newfs.8 while you’re here?
@ziaee: I would very much appreciate your review.
Mon, Nov 2
Sat, Oct 31
Fix and harden the ucl and pkg write paths
/me commandeers revision with Devin's blessing
Thu, Oct 29
Thanks, that’s a very good catch!
Wed, Oct 21
Address @ziaee's notes
- Update man page
- Remove TIME_MONOTONIC + 1 from bad bases
Tue, Oct 20
This revisits D8680, abandoned in 2016, which predated the transmit path rework it needed.
Update manpage
Move the symbol to FBSD_1.9
Add tests
Sun, Oct 18
BTW, I haven't bumped PORTREVISION as the package remains unchanged. Please let me know if I should, and I'll do it promptly.
Sat, Oct 17
Oct 17 2026
It's strange that you have to pass in CC and so on in MAKE_ARGS. Conventionally they are passed in through MAKE_ENV and it works.
Oct 16 2026
Remove unnecessary blank lines
Oct 12 2026
Define VTCON_TX_NBUFS to replace the magic number
Oct 11 2026
Reclaim transmit buffers and stop TX before disabling interrupts
Oct 10 2026
Drop redundant reference to prior behaviour
No, not really. It's for the console patch following in the series. That registers via cnadd() once the device is up (and the device doesn't exist at cninit() yet, so CONSOLE_DRIVER won't do), and its cn_putc()/cn_getc() run under cnputs_mtx and in ddb/panic, so they cannot take the tty mutex. The deadlock fix alone doesn't strictly need the spin mutex, though; I just didn't want to rework the tx path twice. Happy to move it into the console patch if you’d rather keep this one minimal.