Page MenuHomeFreeBSD
Differential D42106

Bug 235946 - column(1): Fill order (with/without -x) is incorrectly documented
Needs ReviewPublic
Actions

Authored by bcr on Oct 6 2023, 1:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 27, 7:08 PM
Unknown Object (File)
Fri, Apr 26, 1:58 AM
Unknown Object (File)
Mon, Apr 22, 12:50 AM
Unknown Object (File)
Fri, Apr 12, 9:01 AM
Unknown Object (File)
Sun, Apr 7, 12:28 PM
Unknown Object (File)
Jan 12 2024, 6:37 AM
Unknown Object (File)
Dec 28 2023, 2:27 PM
Unknown Object (File)
Dec 20 2023, 7:01 AM
View All 11 Files
Subscribers
imp
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Taken from the PR PR 235946, a comment in column.c says:

+/*
+ * Note that c_columnate() and r_columnate() are misleadingly named: the former
+ * fills *rows* first and the latter fills *columns* first. The original names
+ * are kept here only for historical reasons.
+ */

The patch fixes this.

Note: I'm not sure whether we need the CAVEATS section addition, but maybe because of the historic reasons mentioned above, it would make sense.

Test Plan
  1. Apply the patch to usr.sbin/column/column.1
  2. Check the output
  3. Comment or approve

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Revision Contents
Changeset List

PathSize
usr.bin/
column/
16 lines

Diff 128357

View Options

usr.bin/column/column.1

Loading...