Page MenuHomeFreeBSD

Bug 235946 - column(1): Fill order (with/without -x) is incorrectly documented
Needs ReviewPublic

Authored by bcr on Oct 6 2023, 1:56 PM.
Tags
None
Referenced Files
F103313140: D42106.id128357.diff
Sat, Nov 23, 10:27 AM
Unknown Object (File)
Sep 26 2024, 5:52 AM
Unknown Object (File)
Sep 26 2024, 12:00 AM
Unknown Object (File)
Sep 25 2024, 7:23 AM
Unknown Object (File)
Sep 24 2024, 6:33 PM
Unknown Object (File)
Sep 24 2024, 5:56 AM
Unknown Object (File)
Sep 24 2024, 4:57 AM
Unknown Object (File)
Sep 8 2024, 3:21 PM
Subscribers
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Taken from the PR PR 235946, a comment in column.c says:

+/*
+ * Note that c_columnate() and r_columnate() are misleadingly named: the former
+ * fills *rows* first and the latter fills *columns* first. The original names
+ * are kept here only for historical reasons.
+ */

The patch fixes this.

Note: I'm not sure whether we need the CAVEATS section addition, but maybe because of the historic reasons mentioned above, it would make sense.

Test Plan
  1. Apply the patch to usr.sbin/column/column.1
  2. Check the output
  3. Comment or approve

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped