- User Since
- May 18 2014, 4:40 AM (274 w, 1 d)
Looks good to me. Thanks for taking care of it.
Mon, Aug 12
OK from manpages.
Nice feature, BTW.
Minor man page fix.
OK from manpages. Interesting feature, I look forward to having it in the system. Thanks!
Sat, Aug 10
A small issue. The textproc/igor port can tell you about those and "mandoc -Tlint".
OK from manpages.
Two small things in the man page, easy to fix. Let textproc/igor run over it and maybe "mandoc -Tlint" to be one the safe side.
Look good, thanks for the update!
Thu, Aug 1
OK from manpages. Don't forget to bump the .Dd to the date of the commit. Thanks!
Wed, Jul 31
Great, approved for the man page changes.
Thanks for working on fuse2.
Some feedback on the man pages. Have you given it to textproc/igor and "mandoc -Tlint" to see if they spot something?
Tue, Jul 30
A few suggestions, nothing major.
Sat, Jul 27
You can check the man page using the textproc/igor port/package. Additionally, "mandoc -Tlint" also checks for certain issues.
Wed, Jul 24
OK from manpages!
Two easy fixes for the man page. Looks like a nice feature to have.
Thanks for implementing it.
Jul 14 2019
@crees: I just returned from my holiday. I can take care of it, thanks!
Jul 4 2019
Sure, I'll do so soon.
Thanks for the patch!
Jul 3 2019
Looks good. I'll get it committed.
Jul 2 2019
@wblock was working on converting the docs to UTF-8, but efforts have stalled at the moment.
Ideally, if you want to make changes to the Russian translation, you'd find someone (other than me) who can mentor you for that language as a doc committer (or ask him/her to review and commit it).
I can only review the change for DocBook itself, but I can't comment on the language-specific parts. You could ask on the freebsd-doc mailing list if anyone is willing to help for that language. Thanks.
I can't view this file, neither download it as it seems to be a binary file.
Jul 1 2019
Let me do it then and I'll do some final indentation fixes.
I'll credit you for work, of course. Thanks!
OK, thanks. Do you want me to take care of the commit or are you doing it yourself?
Very minor things, easy to fix. use textproc/igor if you need more help.
Thanks for these additions!
Jun 28 2019
Suggested rewording of a sentence.
Jun 25 2019
Any update on this one or are we waiting for upstream here?
No objection from me. If it impacts the translation efforts, we should fix it. I'm not a ports committer, but the change looks simple enough.
Fine with me, also from the docs side.
Jun 24 2019
OK for the manpage changes.
Jun 21 2019
Can you bump .Dd on the man page for this content change when you commit it? Thanks!
Jun 20 2019
Looks good, thank you!
Jun 17 2019
OK from manpages. Thanks!
Jun 16 2019
Update diff to address Kristof's comments.
Looks good to me. I'll add the extra space between the OSSNA and vBSDcon entries. Thank you for the updates!
Jun 15 2019
I agree about the second pass for the macros. Good to go then!
Can you bump the .Dd when you commit it for this content change? Do an extra "mandoc -Tlint" and textproc/igor run over the man page just to be sure there is nothing that I missed in my pass. Thank you!
Looks good, thanks for adding the event. I'll get it committed soon!
Jun 11 2019
Jun 10 2019
Update patch with more information about capabilities and what package people can use on prior FreeBSD versions. Thanks @pfg.
While in the neighborhood, fix an issue that textproc/igor reported in that <note> section.
I copied the header from existing man pages for consistency. If we want to switch the module loading to the beginning (which I think is a good idea), we would have to (in that order):
a) change it in this man page
b) add it to all the other geom modules man pages for consistency and
c) do the same for the rest of the man pages we have that support loading it as a module.
Jun 9 2019
Excellent, now it looks good to go. Thank you, I'll commit it soon.
Some indentaiton fixes needed. Can you post a followup patch?
A few corrections and typo fixes.
Looks good, I'll get it committed. Thanks!
Looks good to me, I'll get it committed.
Thank you for your contribution.
Jun 8 2019
Excellent, I will commit it now. Thank you!
Looks good now, thanks! I will get this committed soon.
Looks good. I'll get it committed!
A few minor nits. I like the use of <replaceable>s to be future proof.
Jun 5 2019
Jun 4 2019
One minor nit that I've found. The rest is fine.
Jun 3 2019
Ready for publishing. Thanks for doing the work!
@allanjude: No more mentoring required for Edward, we released him a while ago. Time to find a new vict^Wmentee.
May 31 2019
AE vs. BE comment. The man page looks fine to me in general, though.
Really accept as manpages. Sorry for the noise.
OK from manpages. When committing, bump the .Dd on math.3 for this content change (link to the new man page). Thanks!
OK from manpages. Don't forget to bump the .Dd when committing.
May 28 2019
A few things I've found. Not sure if we shouldn't keep the original sources and skip DocBook for the quarterly reports.
I think blanket approval is OK and the damage is quite low versus the gains being high.
Better late than never. ;-)