User Details
- User Since
- May 18 2014, 4:40 AM (471 w, 3 d)
Mon, May 29
Amazing work, this will definitely be helpful to have in the Primer instead of the wiki. Thanks for your work.
I've added a few minor fixes and suggestions.
Sun, May 28
Tue, May 23
What is the status of this? Is anyone still working on it?
A lot of people comment on this table still needing improvements.
Overcome by events, less critical these days.
Looks good, both the German and English versions. Much appreciated!
Looks good. I'm also OK with removing the sentence you mentioned.
Mon, May 22
OK from manpages. Bump the .Dd for this content change when you commit it.
Thank you!
Sat, May 20
Can we get an update on the status of this review?
Resign from this change. We would have to re-implement it in AsciiDoctor anyway these days.
Overcome by events (DocBook XML migration, mentee timeout).
OK from manpages. Please bump the .Dd when committing.
Any updates here? I'd be happy to approve the man page change.
There is now a port committed as sysutils/hammer2, based on work done in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267982 .
I think we can safely close this review.
Any update on this?
Remove core-team, as we do not seem to get involved in this.
Remove core-team, as we do not need to get involved.
Would still like to see someone commit this...
Fri, May 19
@carlavilla: Does that look correct to you?
Thu, May 18
Wed, May 17
OK from manpages.
Any update on this?
OK for the manpage part of the change.
Looks good, thanks for making the changes.
Tue, May 16
OK from docs (that's a separate group for doc reviews like this).
@0mp: Can you commit this?
Phew, big change to go through. I did not see anything that needs changing, so go ahead with the commit.
Thank you!
Thu, May 11
Alright, makes sense to me. Make a note of the decision in the commit message so that we have a track record of the decision.
It's documented in this review description, but a few words of explanation in the message itself should suffice.
Wed, May 10
Mon, May 8
Looks good to me. Definitely good to have, thanks!
Apr 25 2023
A couple of minor corrections and additions. It's good to have this documented in the FDP, thanks!
Apr 24 2023
@woodsb02: Are you working on a newer patch for dhcpcd-10 for inclusion into FreeBSD14?
Would really be great to have. If this needs any shepherding from core, I'll see what I can do.
Apr 19 2023
Looks good and would be good to have. Approved!
Mar 30 2023
Looks good to me.
Mar 29 2023
Excellent, more eyes catch more bugs.
Good work, approved also by me!
Good idea, giving this file an update.
Looking looking at the output, I only have two changes (one is purely cosmetical).
Mar 26 2023
Mar 24 2023
Looks good, approved!
Mar 12 2023
Mar 11 2023
Any updates on this?
Looks good to me, definitely useful to have.
Mar 10 2023
Looks good for the doc side of things.
Mar 9 2023
Sure, go ahead!
Excellent, nothing to complain about. Good work, ready to commit!
A few minor language fixes, the rest looks good to me.
Good to have these instructions, thanks for writing them down.
OK for the documentation side of things.
Thanks for your help with the release notes!
Feb 17 2023
Looks good. Don't forget the .Dd bump.
Feb 6 2023
Jan 20 2023
Found a few minor nits.
We should definitely recommend people to use GPT over MBR.
Jan 12 2023
OK for the man page part of the change.
Dec 30 2022
A few small corrections, the rest looks OK to me.
Good to have a TEX section in the porters handbook with this change!
Dec 29 2022
Dec 18 2022
Can someone commit this? Thanks!
Dec 15 2022
Dec 13 2022
Good catch, I'll take care of it.
Thank you!
Dec 10 2022
A few minor edits to the text: one missing word the others are suggestions only.
Looks good. Thank you for your continued work on all things NFS.
Dec 6 2022
OK from manpages for these latest changes. Thanks for your patience working on this patch!
Nov 15 2022
About the use of "you".
Nov 14 2022
Quick question: some of the if-statements here are wrapping the check into [], while others do not.
Do we have some kind of style-guide for shell scripts like this for consistency?
Nothing against the change per se, just wondering.
Nov 13 2022
Looks good, ready to commit!
Looks good now!
Looks good to me now. I'm approving this one and https://reviews.freebsd.org/D36769. Thanks!
Nov 12 2022
Looks good as a first introduction to vale. A few fixes and then you can commit it to the FDP primer.
I like these additions, thanks!
A few fixes provided in the comments.
Oct 29 2022
The term "Committer" was used way before SVN times.
Oct 28 2022
Found a line break after a sentence stop. You can run textproc/igor over your man page to find these.
Also, "mandoc -T lint" may also be helpful.
Very minor issue with the core-email in one place.
Thanks for working on this!
Oct 27 2022
Found a typo. You can fix it when committing. Thanks for this work!
Oct 23 2022
Oct 18 2022
Who's going to commit this?
Oct 13 2022
I would love to see this in the man page. Any updates?
Will someone commit this? It's been approved for a while...
Any updates on this one?
I like this initiative. It does make the page much better than before and with the update script, we'll keep it up-to-date.
I'd say we commit the base bits now and refine it in a follow-up commit (i.e. when the script is running with help from Sergio).
Any updates on this (from either side)?
Any updates on this one?
OK from manpages.
Oct 12 2022
Oct 11 2022
Looks good. Would be amazing if this would be updated automatically by a script of some kind.
Oct 8 2022
Oct 7 2022
OK from manpages.
Overcome by events, someone else removed the section by now.
Manpage looks good, we can do the filename markup in a followup commit.
The changes were already committed to the porters-handbook. You can close this review.
Thanks for submitting it anyway.
Manpage looks good. Thanks!
Confirm man page looks good.
OK from manpages.