- User Since
- May 18 2014, 4:40 AM (217 w, 3 d)
Mon, Jul 16
There are a bunch of style issues with crypt.3. Can you run "mandoc -Tlint" and textproc/igor (from ports/packages) on it? It should give you some feedback where the problems are. For example, man pages need a line break after a sentence stop.
Fri, Jul 13
Ah, you're right. Well then, time to commit this change.
Comments on the flickr link...
Thu, Jul 12
Good inititative, I was thinking about the same thing, but you beat me to it. Approved!
Mon, Jul 9
Sun, Jul 8
You need to bump the .Dd since this is a content change in a man page.
Sat, Jul 7
Looks good to me. Thank you for updating that section.
A small textual correction.
Thu, Jul 5
Thank you for working on updating the man page.
Can you run "mandoc -Tlint" over the man page with your changes and fix the warnings ("new sentence, new line" and such)?
Running textproc/igor over the man page can also find and report issues.
The FDP primer's man page section on Markup Guidelines has some additional info that can help.
Wed, Jul 4
Ready to land, thanks!
Minor wording nit in the man page.
OK from me as well. Thanks for doing the work!
Sun, Jul 1
Hehe, yeah. It's good now, ready to commit!
Ah, now even *I* understand it. ;-)
A few fixes to the new text, then it is fine.
A few suggestions...
A few suggestions on fixes (a missing word, typo, and line breaks).
Thu, Jun 28
Thanks indeed for the work. OK from manpages.
Wed, Jun 27
Cool, thanks for the quick reply.
Approved from manpages. Don't forget to bump the .Dd to the date of the commit.
Two textual suggestions for the man page.
Tue, Jun 26
OK from manpages. Don't forget to bump the .Dd at the beginning of the man page with the date of the commit.
Sat, Jun 23
Sorry for the wait. Looks good to me now.
Fri, Jun 22
Would it make sense to add an EXAMPLES section that shows how to define a proper TOPCOLOR?
Thu, Jun 21
So, you're saying the we need testers for this configuration before we put it in the handbook as official instructions?
Tue, Jun 19
Sorry, it must have slipped through the cracks. It's fine. Can you bump the .Dd before you commit? Thanks!
Just a formatting thing that I found, the rest looks fine.
Mon, Jun 18
A few suggestions, mostly about line breaks with a few textual corrections.
Jun 17 2018
Suggestion to split a sentence in two to avoid a colloquial "so".
Jun 16 2018
Jun 15 2018
Suggestion to use tags. Other than that, it's fine.
Good to go!
Jun 14 2018
Jun 13 2018
Jun 12 2018
Thanks for the screenshot comparing the two man page renderings. I'm good with both ways.
A few man page corrections. textproc/igor is your friend (besides me, of course. ;-))
Jun 11 2018
Man page nit.
Jun 10 2018
A few corrections and sentence rephrasing.
Jun 6 2018
OK from manpages, if you bump the .Dd upon commit.
Jun 2 2018
May 29 2018
Looks good to me now, approved!
May 22 2018
Thank you for updating the handbook chapter with your work on USB device mode. I added some things I've found. Mostly minor things, easy to fix.
Looks good, approved!
From what I can tell, the indentation of "family" should start below the 'e' of <description>.
May 21 2018
OK from manpages.
May 20 2018
A tip on formatting.
I suggest running textproc/igor on the man pages. It will give you a few tips on how to correct some errors.
Thanks for writing the man page.
Two comments, minor things, easy to fix.
May 19 2018
OK from manpages. Thanks for working on it!
May 13 2018
Can you bump the .Dd on zpool-features.7 (content change)?
May 3 2018
Apr 28 2018
Apr 23 2018
Good catch! Thanks.
Apr 21 2018
OK from manpages.
Apr 12 2018
You need to bump the .Dd of the man page to the day of the commit, since these are content changes. Thank you for working on this.
Apr 6 2018
I think we're still good on the man page!
Excellent, I think this can go in now.
Thank you for working on it.
Only two small nits that I found.
When I read the title of the review, I thought it was some kind of medical advice for sysadmins or something. ;-)
Sorry, this does not help the review, just wanted to let you know.
Apr 5 2018
OK from manpages. Bump the .Dd when you do the actual commit (once network has approved, too). Thanks for working on this!
Mar 31 2018
OK from manpages. Thanks for working on this!
Mar 30 2018
Typo fix in comment.
Mar 20 2018
Hehe, no worries, we all have to from time to time. Approved!
Hmm, strange. Check out the FDP primer on man pages, section 13.3.3.:
Check it with textproc/igor, but I think these are the only things that need to be changed.
Mar 16 2018
Mar 15 2018
Mar 10 2018
@dteske: Can you take a final look on the updated patch? Would be good to have this in the man page. Thank you!
Most, if not all of these have been fixed by now. So, I'm closing this review.
Thank you for submitting these changes, anyway. Keep it up!
Mar 9 2018
Approved for commit. Thank you for taking the time to write the man page.
Mar 7 2018
It's good, thanks for writing it.
A few language fixes, but nothing major.
Found a small whitespace nit in the man page. Also, you need to bump the .Dd to the date of the commit (when it is ready).