Looks good, OK to commit.

Just the normal <a href=...>blah</a> magic. See events2015.xml for an example.

Looks good from manpages. I guess bumping the .Dd to the date of the commit does not hurt.
I look forward to that feature. Thanks!

Link suggestion.

Just a small typo.

OK as well. Thanks for doing the work. Let me know if I should commit it (giving proper attribution, of course).

Looks good. Can you commit that directly or should I take care of it?

OK, jsmith it is.

Use jsmith instead of foo as gsmith was deleted in the example prior to this one.

Where are we on this? I know it's a bit dated, but maybe there are updates or a newer way to do things worth including in the handbook.

It seems like a lot, but most of these are easy to fix. Let textproc/igor run over it a couple of times and you'll get the exact spots where you need to fix things.
Thank you for the work writing these. I'd be happy to review an updated diff.

Two suggestions, nothing major.

Ich habs durchgelesen und ein paar Kleinigkeiten gefunden, nichts grosses. Danke für die Arbeit!

I'd be OK with the manual page changes. At least I'm not seeing anything wrong with them. I guess we'll have to wait until a src committer has had a closer look at it.

Ok for the man page part of the change.

Update diff to distinguish hw.realmem versus hw.physmem output.

Any updates on this one or is there a new review now?

Approved for commit. Can you do that yourself? Thanks for the work!

One comment on the service start command.

That's an easy one. ;-)

Yes, that's fine. Approved!

A small suggestion...

Update the diff based on Allan's comments. I've decided to remove the newsyslog compression example. This might be something better suited for the handbook. In it's place, I've added Allan's zfs snapshot range deletion examples. I've also changed the date in the custom property example to a more prominent date. ;-)

Thanks for your feedback, @allanjude. I'll work on an updated patch that incorporates it.

Can you run textproc/igor on your change and fix the errors that are reported? The indentation of the following line seems way off:
<para>To enable logging through a dedicated interface named ...

OK from manpages.

Who's going to commit this?

Thanks for working on this update of the handbook chapter.
Can you run textproc/igor over your changes and fix the issues that are reported (alignment of sections, tabs vs. spaces, etc.)?

I think it fulfills the criteria for integration into the document. Approved!

@mat: Ah, those are good additions to have. I should have noticed. I'm un-approving... ;-)

OK to be added to the committers guide. Thanks!

First of all: big thanks for creating this man page. I think it is good to have for non-developers and eventually moving the info out of the wiki into a man page.

OK, thanks for checking.

Did you check the man page with "mandoc -Tlint" and textproc/igor?

Right, examples should have been "variables". I agree with Mark on this one. We need to be careful with licenses even if it is just for docs.
So if I would ask you to describe the types of DTrace variables (for example), could you come up with a description that's complete enough for the man page without being too close to the original?
Otherwise, Mark's suggestion for converting the Guide would work for you. Question is, whether this is just your requirement or is it common enough that it warrants a general inclusion in the man page?

Can we rewrite these examples somewhat so that they are not identical but provide the same general concepts/ideas?

OK from manpages, too.

OK from manpages. Thank you!

Thanks for your work! I found one issue with the man page.
Can you run "mandoc -Tlint" and the textproc/igor package over the man page and see if additional things are reported?

Manpages is OK with it.

OK from the manpage side, a src comitter should check the implementation part for correctness.

Approved!

OK from manpages.

Good to have these in the examples, so approved. Thanks for the work!

Igor feels certainly petted enough, so I approve. ;-)

Ah, got it. Fine then. Thanks for the clarification.

OK from manpages.

Fine with me.

Question about the "No"...

OK for the man page changes, .Dd bump upon commit. ;-)

Don't forget to bump the .Dd at the beginning of the man page to today's date as this is a content change. Thanks!

Oops, selected the wrong option. I was meant to select the "Approve" option, so go ahead with the commit.

Can you bump the .Dd at the beginning of the man page when you commit it (since it's a content change)?
Thanks for explaining it a bit better!

OK from manpages.

OK from manpages.

Good catch!

Good to go! Thanks again for all the work you put into this.

Good changes, so they're approved.

OK to commit. Best to publish it as soon as possible given that we're already in the next submission deadline period.

Looks good to me, so approved by manpages, too.. Thanks for the work!

I think it is ready enough to be published. Thanks again!

Adding more reviewers for more pairs of eyes for eventual approval.

I've just finished reading through the whole thing.
First, a big thanks for working on resurrecting the status reports and bringing it to this state!

OK from manpages.

OK from the docs side.

Looks good, approved!

In D10600#397152, @rockyhotas_post.com wrote:

In D10600#397149, @bcr wrote:

Yes, I've changed those.

Ok!

Now that the server part is about to be committed, do you also plan to do a section about the client? We have an article mentioning pam_ldap, but that article should either be reworked or put into the handbook altogether.

Yes, maybe you are referring to this section.

Yes, I've changed those.
Now that the server part is about to be committed, do you also plan to do a section about the client? We have an article mentioning pam_ldap, but that article should either be reworked or put into the handbook altogether.

I think the patch is fine now. I'll see to it that it gets committed.
Thanks for your patience, Rocky Hotas.