This is in /contrib, so is bmake coming from another project or are we maintaining bmake these days? When the former is true, it would be good to send the patch upstream, so that we can get it from there without having to maintain it locally.

Mon, Feb 3, 3:07 PM

bcr accepted D23474: Limit memory usage in xz(1)..

OK from manpages.

Mon, Feb 3, 10:19 AM

Sun, Feb 2

bcr accepted D23457: [Handbook] Update packages in dtrace section and remove FreeBSD 10 warning.

OK, you can commit this change!

Sun, Feb 2, 11:24 AM

bcr accepted D23458: [Handbook] bsdinstall update part 1.

Excellent, nice bite-sized changes. Go ahead with committing it, thanks!

Sun, Feb 2, 11:24 AM

bcr accepted D23455: Add MFV explanation in freebsd glossary.

Good to go!

Sun, Feb 2, 11:20 AM

bcr accepted D23456: Handbook missing "#" in front of the "make deinstall".

Approved, thanks for taking care of it.

Sun, Feb 2, 11:19 AM

Fri, Jan 31

bcr added a comment to D23426: Simplify IPFW in-kernel NAT section (handbook).

I only found one typo.

Fri, Jan 31, 4:49 PM

Wed, Jan 29

bcr accepted D23384: Remove pxe article from da_DK.

Yes, it can go, since the original one was deleted a while ago.

Wed, Jan 29, 7:07 PM

bcr accepted D23410: Update cmake package example in Porter's Handbook.

Also good from my side.

Wed, Jan 29, 7:03 PM

Tue, Jan 28

bcr accepted D23198: Bring our pam_login_access to support the same features as Linux's pam_access.

Great, OK for the man page side of things.

Tue, Jan 28, 10:34 AM

Sun, Jan 26

bcr accepted D23369: Remove BSD Success Stories from the Marketing section. The link is incorrect..

OK, it can go.

Sun, Jan 26, 3:44 PM

bcr added a comment to D23198: Bring our pam_login_access to support the same features as Linux's pam_access.

In D23198#512364, @cy wrote:

This fixes the man page errors introduced by my first cut of this diff.

Sun, Jan 26, 10:35 AM

bcr accepted D23358: [Handbook] Remove stale link on ZFS additional resources.

Good, thank you!

Sun, Jan 26, 10:32 AM

Sat, Jan 25

bcr accepted D23361: Minor Style Guide Corrections.

Hehe, someone has been doing some style-guide reading. ;-)
Good catch, hereby approved!

Sat, Jan 25, 10:42 AM

bcr accepted D23360: Add FreeNAS and XigmaNAS to the myths section.

Ready to go! Thanks.

Sat, Jan 25, 10:41 AM

bcr accepted D23359: [Handbook] Remove the advice to load VESA_LOAD.

Good point, approved!

Sat, Jan 25, 10:40 AM

bcr added a comment to D23358: [Handbook] Remove stale link on ZFS additional resources.

Can you change the links to point to open-zfs.org, at least for the wiki (second link)?

Sat, Jan 25, 10:39 AM

bcr accepted D23354: truncate(2): extending the file is required by POSIX 2008.

Good to go!

Sat, Jan 25, 10:34 AM

bcr accepted D23356: natd: Add support for RFC 6598/Carrier Grade NAT subnets via libalias.

Manpage looks good, don't forget to bump the .Dd when you commit.
Thanks for adding this support!

Sat, Jan 25, 10:34 AM

Fri, Jan 24

bcr added a comment to D23342: bhyve: move virtio-net header processing to pci_virtio_net.

Minor man page fix.

Fri, Jan 24, 7:05 AM

Thu, Jan 23

bcr accepted D23307: Fixing fallout..

Looks good to me, I think I understand what you mean.

Thu, Jan 23, 12:58 PM

bcr accepted D23010: usr.sbin/bhyve: Implement a generic block store backend interf..

OK from manpages.

Thu, Jan 23, 11:30 AM

Wed, Jan 22

bcr accepted D23262: Add clarification to ezjail section in the handbook.

Ready to go into the tree. Thank you!

Wed, Jan 22, 7:30 PM

bcr accepted D23263: [Handbook] Clarify when the user needs to reboot the system.

Good to go.

Wed, Jan 22, 7:03 PM

bcr accepted D23264: [Handbook] Update Who Uses FreeBSD?.

OK, you can commit it then.

Wed, Jan 22, 7:02 PM

Tue, Jan 21

bcr added a comment to D23264: [Handbook] Update Who Uses FreeBSD?.

Yes, it is true that they switched, so we can remove WhatsApp from this here.

Tue, Jan 21, 9:17 PM

bcr added a comment to D23263: [Handbook] Clarify when the user needs to reboot the system.

Two more things, we're getting there.

Tue, Jan 21, 9:15 PM

bcr accepted D23298: Fix 3 typos/missing words in the English FAQ.

Looks good, commit approved!

Tue, Jan 21, 2:59 PM

Jan 20 2020

bcr added a comment to D23264: [Handbook] Update Who Uses FreeBSD?.

Just one missing word and we're good to go.
Thanks for working on keeping this updated.

Jan 20 2020, 8:00 AM

bcr added a comment to D23263: [Handbook] Clarify when the user needs to reboot the system.

A few things that I've found. In general, I like the note and what it conveys.

Jan 20 2020, 7:58 AM

bcr added a comment to D23262: Add clarification to ezjail section in the handbook.

Ah, now it's better. The german patch is nice, but the translation team will take care of it as there might be patches that need to be applied before that one.

Jan 20 2020, 7:53 AM

Jan 19 2020

bcr added a comment to D23262: Add clarification to ezjail section in the handbook.

Is that the proper patch? It seems to delete more than it would add...

Jan 19 2020, 2:54 PM

bcr accepted D21481: Make a start at supporting login.conf environment settings.

OK for the man page changes.

Jan 19 2020, 10:44 AM

Jan 18 2020

bcr accepted D23250: Add vstack to the ISP commercial page.

Looks good, ready to commit!

Jan 18 2020, 3:24 PM

Jan 16 2020

bcr accepted D23110: Introduce CTLFLAG_NEEDGIANT.

OK for the man page change.

Jan 16 2020, 2:45 PM

bcr closed D23175: Disable automatic sorting for new quarterly status reports.

Jan 16 2020, 7:42 AM

bcr committed rD53785: Disable automatic sorting for new quarterly status reports..

Disable automatic sorting for new quarterly status reports.

Jan 16 2020, 7:42 AM

bcr added a comment to D23198: Bring our pam_login_access to support the same features as Linux's pam_access.

I checked the man pages. You can install textproc/igor and run it over your man page to get some useful hints. Another check for syntax and such can be done by running "mandoc -Tlint".
Thanks for these PAM changes.

Jan 16 2020, 7:35 AM

Jan 15 2020

bcr accepted D23175: Disable automatic sorting for new quarterly status reports.

Looks good. There is plenty of stuff you can do in the doc tree with some XSLT knowledge, so I welcome changes like this.
Thank you!

Jan 15 2020, 12:22 PM

Jan 14 2020

bcr accepted D23179: Update the hardware donation form..

Just a small nit. You can go ahead with committing it once it's done.

Jan 14 2020, 9:21 PM

bcr accepted D23177: Remove obsolete information in the docs section.

Approved, thank you!

Jan 14 2020, 8:31 PM

bcr added a comment to D22706: Add per-FIB gateway support to rc.d/routing.

@allanjude Can you commit these changes? For the src part, I would require that bit, so I think it would be better if you did that.

Jan 14 2020, 7:52 AM

Jan 11 2020

bcr accepted D23130: getrandom(2): Add Linux GRND_INSECURE API flag.

OK from manpages.

Jan 11 2020, 7:43 PM

Jan 8 2020

bcr accepted D23093: fdt_pinctrl: Add new methods for gpios.

OK from manpages (can't say much about the actual code).

Jan 8 2020, 9:19 PM

bcr added a comment to D23085: DRM: Add DRM core files and DRMKPI.

In D23085#505979, @manu wrote:

In D23085#505975, @bcr wrote:

Do you need any specific actions from the core team or was core only added as reviewer because Phabricator tried to be smart (too much mention of the word "core" in a different context)?
Let us know if we need to discuss/decide something.

core was added because some files are dual licenced GPL/MIT and there is an herald rule that adds core for anything that matches GPL.
We will first fix the technical details and if core is needed we'll ping you :)

Jan 8 2020, 4:48 PM

bcr added a comment to D23085: DRM: Add DRM core files and DRMKPI.

Do you need any specific actions from the core team or was core only added as reviewer because Phabricator tried to be smart (too much mention of the word "core" in a different context)?
Let us know if we need to discuss/decide something.

Jan 8 2020, 4:20 PM