- User Since
- May 18 2014, 4:40 AM (265 w, 1 d)
OK from manpages. Thanks!
Update diff to address Kristof's comments.
Looks good to me. I'll add the extra space between the OSSNA and vBSDcon entries. Thank you for the updates!
Sat, Jun 15
I agree about the second pass for the macros. Good to go then!
Can you bump the .Dd when you commit it for this content change? Do an extra "mandoc -Tlint" and textproc/igor run over the man page just to be sure there is nothing that I missed in my pass. Thank you!
Looks good, thanks for adding the event. I'll get it committed soon!
Tue, Jun 11
Mon, Jun 10
Update patch with more information about capabilities and what package people can use on prior FreeBSD versions. Thanks @pfg.
While in the neighborhood, fix an issue that textproc/igor reported in that <note> section.
I copied the header from existing man pages for consistency. If we want to switch the module loading to the beginning (which I think is a good idea), we would have to (in that order):
a) change it in this man page
b) add it to all the other geom modules man pages for consistency and
c) do the same for the rest of the man pages we have that support loading it as a module.
Sun, Jun 9
Excellent, now it looks good to go. Thank you, I'll commit it soon.
Some indentaiton fixes needed. Can you post a followup patch?
A few corrections and typo fixes.
Looks good, I'll get it committed. Thanks!
Looks good to me, I'll get it committed.
Thank you for your contribution.
Sat, Jun 8
Excellent, I will commit it now. Thank you!
Looks good now, thanks! I will get this committed soon.
Looks good. I'll get it committed!
A few minor nits. I like the use of <replaceable>s to be future proof.
Wed, Jun 5
Tue, Jun 4
One minor nit that I've found. The rest is fine.
Mon, Jun 3
Ready for publishing. Thanks for doing the work!
@allanjude: No more mentoring required for Edward, we released him a while ago. Time to find a new vict^Wmentee.
Fri, May 31
AE vs. BE comment. The man page looks fine to me in general, though.
Really accept as manpages. Sorry for the noise.
OK from manpages. When committing, bump the .Dd on math.3 for this content change (link to the new man page). Thanks!
OK from manpages. Don't forget to bump the .Dd when committing.
Tue, May 28
A few things I've found. Not sure if we shouldn't keep the original sources and skip DocBook for the quarterly reports.
I think blanket approval is OK and the damage is quite low versus the gains being high.
Better late than never. ;-)
Mon, May 27
Sat, May 18
Adding Konstantin and Rod for review. I could not find Bruce Evans as a reviewer account...
May 18 2019
May 17 2019
Good to go.
May 16 2019
May 15 2019
I don't think so. I'll get this committed soon. Thank you for adding this example!
May 13 2019
May 12 2019
May 9 2019
Looks good, thanks for working on these changes.
May 7 2019
May 6 2019
Phew, what a big review. A lot of good changes in there. I made a couple of suggestions.
Thanks for working on it!
Apr 28 2019
Apr 27 2019
Thanks John for your feedback. In light of this, I think it is best to abandon this revision.
Apr 26 2019
OK, thanks. Approved for the manpages part.
Can you run "mandoc -Tlint" and textproc/igor over the man page? Thanks!
Looks good to me. Maybe add an .Sh AUTHORS section? If not, that's OK.
Apr 24 2019
Checked for the proper writing style of the company. Will commit as it is.
Apr 21 2019
Apr 19 2019
Thank you for the quick edits. Approved by manpages for that part.
Can you run textproc/igor and "mandoc -Tlint" over the man page and see what warnings/errors they give you? Thanks!
OK from manpages.
Apr 18 2019
Update with Kristof's comments.
Some comments. I'm more inclined on putting it into section 8 of the man pages. Going from the description of sections in man(1), it's more geared towards sysadmins rather than being a general FreeBSD command to run.
Have you run textproc/igor over it and "mandoc -Tlint" for any errors/warnings it might find?