- User Since
- May 18 2014, 4:40 AM (205 w, 4 d)
Mon, Apr 23
Good catch! Thanks.
Sat, Apr 21
OK from manpages.
Thu, Apr 12
You need to bump the .Dd of the man page to the day of the commit, since these are content changes. Thank you for working on this.
Fri, Apr 6
I think we're still good on the man page!
Excellent, I think this can go in now.
Thank you for working on it.
Only two small nits that I found.
When I read the title of the review, I thought it was some kind of medical advice for sysadmins or something. ;-)
Sorry, this does not help the review, just wanted to let you know.
Thu, Apr 5
OK from manpages. Bump the .Dd when you do the actual commit (once network has approved, too). Thanks for working on this!
Sat, Mar 31
OK from manpages. Thanks for working on this!
Fri, Mar 30
Typo fix in comment.
Mar 20 2018
Hehe, no worries, we all have to from time to time. Approved!
Hmm, strange. Check out the FDP primer on man pages, section 13.3.3.:
Check it with textproc/igor, but I think these are the only things that need to be changed.
Mar 16 2018
Mar 15 2018
Mar 10 2018
@dteske: Can you take a final look on the updated patch? Would be good to have this in the man page. Thank you!
Most, if not all of these have been fixed by now. So, I'm closing this review.
Thank you for submitting these changes, anyway. Keep it up!
Mar 9 2018
Approved for commit. Thank you for taking the time to write the man page.
Mar 7 2018
It's good, thanks for writing it.
A few language fixes, but nothing major.
Found a small whitespace nit in the man page. Also, you need to bump the .Dd to the date of the commit (when it is ready).
Mar 6 2018
You need to bump the .Dd at the beginning since this is a content change.
OK from manpages, but don't forget to bump the .Dd once you commit it since this is a content change.
Mar 5 2018
Good catch. Can you commit this yourself or should I do it (with proper credits, of course)?
I agree with the needed rewrites, but for this specific change, it is enough. Approved!
Feb 27 2018
Feb 25 2018
Feb 22 2018
Sorry to keep you waiting, @oshogbo.Looks good to me. Make sure to bump the .Dd to the date when you commit it.
Feb 21 2018
Feb 19 2018
I found a typo...
Feb 17 2018
I have no time this weekend. I'd appreciate it if someone else could take this on.
Feb 16 2018
Feb 15 2018
I found a superfluous space (in addition to what @adridg has found.
Try checking it with textproc/igor, there might be additional output/suggestions.
Feb 12 2018
Feb 10 2018
Looks good now. OK from the manpages part of the module.
OK, the man page looks better now.
You should also add an AUTHORS, HISTORY, and maybe SEE ALSO section at the bottom. See the examples here:
A few comments on the man page. You can use textproc/igor to check the man page for various common errors.
Thank you very much for working on this kernel module!
Feb 8 2018
Looks OK to me, thanks for working on that. Who's going to commit those?
Feb 6 2018
Feb 5 2018
Argh, I missed that. Good that we both can count on @brueffer. ;-)
Thanks for your continued work on documenting capsicum functionality, @oshogbo!
Two typos, but the rest looks good.
Jan 28 2018
Just a small thing, the rest looks good to me.
Jan 27 2018
Thanks for writing yet another man page, @oshogbo. Approved!
Jan 25 2018
Approved, thanks for working on it!
Jan 22 2018
OK from manpages.
Small man page nit.
I found one more typo.
One small nit.
Just one more fix to the indentation level...
Jan 20 2018
You can check with textproc/igor. I believe it should check for overlong lines in man pages, too.
Jan 18 2018
The indentation seems a bit off, so I refer you to Dr. igor. ;-)
A few more suggestions.
Don't forget to bump the .Dd for this content change. Thanks!
A few comments. Don't be discouraged, you're on the right track.
One more thing though: next time when you create the diff, do it from the top level of your doc directory. That will include the full path to the file in the diff/review header and not just book.xml. We have many book.xml files, so having the path in there helps determining what file the patch is for.
Jan 17 2018
More info on proper link indentation. You're getting there...
Jan 14 2018
A few suggestions for improvement.
Looks good to me.
Jan 10 2018
New suggestion on how to word it better, based on your explanation, @oshogbo.
I found something else while there, but it's easy to fix. ;-)
A few suggestions and corrections.
Jan 9 2018
Minor wording fixes.
Jan 8 2018
OK from manpages.
Jan 4 2018
Haha, yeah. But only because you have a certain Goat looking over your shoulder when writing it. :-)
A few suggestions and corrections. Thanks for writing the man page!
Jan 2 2018
A small sentence rephrasing proposal.
Jan 1 2018
One small correction for the man page.
Dec 31 2017
Dec 29 2017
Dec 26 2017
Approved from manpages. Thanks for doing these changes.
OK from manpages.
A few corrections.
Dec 25 2017
Ok from manpages. Thanks for working on it.
Dec 22 2017
A small man page fix.
Dec 20 2017
OK from manpages. Make sure to bump the .Dd when you commit.
Dec 19 2017
Dec 10 2017
Dec 4 2017
At the top of fstyp.8, you need to bump the .Dd to the date of the commit, since this is a content change.
Dec 1 2017
You need to bump the .Dd in the man page to the date of the commit, since this is a content change.
Nov 30 2017
Nov 28 2017
I'd wait until the other two reviewers had time to review. I myself don't have anything else. Thanks for the work on this!
Nov 25 2017
OK from manpages, you just need to bump the .Dd to the date of the actual commit.
Nov 24 2017
Approved, but you need to bump the .Dd at the top of the document to the date of your commit.
Nov 21 2017