Page MenuHomeFreeBSD

bcr (Benedict Reuschling)
User

Projects (6)

User Details

User Since
May 18 2014, 4:40 AM (471 w, 3 d)

Recent Activity

Mon, May 29

bcr added a comment to D40313: fdp-primer: Add Weblate chapter.

Amazing work, this will definitely be helpful to have in the Primer instead of the wiki. Thanks for your work.
I've added a few minor fixes and suggestions.

Mon, May 29, 8:17 AM

Sun, May 28

bcr accepted D40285: libtacplus: Allow additional AV pairs to be configured..
Sun, May 28, 6:07 PM

Tue, May 23

bcr added a comment to D34004: website: Rework the downloads table.

What is the status of this? Is anyone still working on it?
A lot of people comment on this table still needing improvements.

Tue, May 23, 7:54 AM
bcr abandoned D19934: Add an "Event: " line to the commit messages to not abuse the "Sponsored by:" line.

Overcome by events, less critical these days.

Tue, May 23, 7:53 AM
bcr accepted D40217: Update handbook/pkg-files#pkg-message to use sysrc and service .

Looks good, both the German and English versions. Much appreciated!

Tue, May 23, 7:51 AM
bcr accepted D40214: FAQ: switch Subversion references to Git.

Looks good. I'm also OK with removing the sentence you mentioned.

Tue, May 23, 5:49 AM

Mon, May 22

bcr accepted D40203: hier.7: update /home.

OK from manpages. Bump the .Dd for this content change when you commit it.
Thank you!

Mon, May 22, 3:35 PM

Sat, May 20

bcr added a comment to D33168: gpart: add options to move the primary and secondary GPT partition tables.

Can we get an update on the status of this review?

Sat, May 20, 2:13 PM
bcr resigned from D23398: Add USES=mono:build notes to PHB.

Resign from this change. We would have to re-implement it in AsciiDoctor anyway these days.

Sat, May 20, 2:12 PM
bcr resigned from D25367: Add Nginx section to the Network Servers chapter in addition to Apache..

Overcome by events (DocBook XML migration, mentee timeout).

Sat, May 20, 2:07 PM
bcr accepted D32132: kern/param: implement generalized enum sysctl reporting function.

OK from manpages. Please bump the .Dd when committing.

Sat, May 20, 2:02 PM
bcr added a comment to D38490: ping: Accept ToS keywords with -z.

Any updates here? I'd be happy to approve the man page change.

Sat, May 20, 2:01 PM
bcr resigned from D37354: Port HAMMER2 from DragonFly (read-only support).

There is now a port committed as sysutils/hammer2, based on work done in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267982 .
I think we can safely close this review.

Sat, May 20, 1:57 PM
bcr added a comment to D31126: vget(9): update after r364271.

Any update on this?

Sat, May 20, 1:52 PM
bcr removed a reviewer for D34748: riscv: add Allwinner D1 device tree: Core Team.

Remove core-team, as we do not seem to get involved in this.

Sat, May 20, 1:50 PM
bcr removed a reviewer for D26552: Revert DTS for omap family for stable/12 and releng 12.2: Core Team.

Remove core-team, as we do not need to get involved.
Would still like to see someone commit this...

Sat, May 20, 1:47 PM · ARM

Fri, May 19

bcr updated subscribers of D40164: Show that 13.2 is the preferred release and 12.4/13.1 are legacy.

@carlavilla: Does that look correct to you?

Fri, May 19, 5:29 PM
bcr accepted D40159: date: add -z output_zone option.

OK for the man page part.

Fri, May 19, 1:20 PM

Thu, May 18

bcr committed R9:b2f883f5a2d9: Remove instances of "in order to" to ease readability (authored by bcr).
Remove instances of "in order to" to ease readability
Thu, May 18, 3:54 PM

Wed, May 17

bcr accepted D40135: pam_tacplus: Mention nss_tacplus in the manual page..

OK from manpages.

Wed, May 17, 3:52 PM
bcr added a comment to D32700: nvmecontrol: Implement Get/Set Feature for nvmecontrol.

Any update on this?

Wed, May 17, 3:51 PM
bcr accepted D40133: Add nss_tacplus, a TACACS+ NSS module..

OK for the manpage part of the change.

Wed, May 17, 1:09 PM
bcr accepted D40134: phb/testing: Pet vale.

Looks good, thanks for making the changes.

Wed, May 17, 1:08 PM · portmgr

Tue, May 16

bcr accepted D40003: ix(4): correct max MTU.

OK from docs (that's a separate group for doc reviews like this).

Tue, May 16, 8:14 PM
bcr added a comment to D33233: sync.8: Document that the "sync dance" is not a thing.

@0mp: Can you commit this?

Tue, May 16, 6:36 PM
bcr accepted D40080: porters-handbook/versions: Pet vale.

Phew, big change to go through. I did not see anything that needs changing, so go ahead with the commit.
Thank you!

Tue, May 16, 6:28 PM

Thu, May 11

bcr accepted D40063: vale/styles: Remove Weasel rule.

Alright, makes sense to me. Make a note of the decision in the commit message so that we have a track record of the decision.
It's documented in this review description, but a few words of explanation in the message itself should suffice.

Thu, May 11, 1:49 PM

Wed, May 10

bcr accepted D40029: vale: Add new rule to reduce usage of pronouns.
Wed, May 10, 7:41 AM

Mon, May 8

bcr accepted D39997: vt(4): document enable_altgr.

Looks good to me. Definitely good to have, thanks!

Mon, May 8, 1:42 PM

Apr 25 2023

bcr added a comment to D39800: fdp-primer/writing-style: Refactor after adding new Vale rules.

A couple of minor corrections and additions. It's good to have this documented in the FDP, thanks!

Apr 25 2023, 2:07 PM
bcr added a comment to D39798: .vale.ini: Refactor.

Looks reasonable, approved!

Apr 25 2023, 2:02 PM

Apr 24 2023

bcr added a comment to D22012: Import dhcpcd(8) into FreeBSD base..

@woodsb02: Are you working on a newer patch for dhcpcd-10 for inclusion into FreeBSD14?
Would really be great to have. If this needs any shepherding from core, I'll see what I can do.

Apr 24 2023, 9:41 AM

Apr 19 2023

bcr accepted D39685: vale: Refactor Weasel rule.

Looks good and would be good to have. Approved!

Apr 19 2023, 9:15 AM

Mar 30 2023

bcr accepted D39340: committers-ports.dot: Bring file up to date..

Looks good to me.

Mar 30 2023, 11:23 AM

Mar 29 2023

bcr accepted D39309: committers-doc.dot: bring file up to date.

Excellent, more eyes catch more bugs.
Good work, approved also by me!

Mar 29 2023, 5:55 PM
bcr added a comment to D39309: committers-doc.dot: bring file up to date.

Good idea, giving this file an update.
Looking looking at the output, I only have two changes (one is purely cosmetical).

Mar 29 2023, 3:48 PM

Mar 26 2023

bcr accepted D39276: Core Team quarterly report.
Mar 26 2023, 2:34 PM

Mar 24 2023

bcr accepted D39252: Document __FreeBSD_version value 1400084 for arm64 ABI/KBI changes..

Looks good, approved!

Mar 24 2023, 10:43 AM

Mar 12 2023

bcr accepted D39016: 13.2 relnotes: additions/changes suggested by emaste.
Mar 12 2023, 9:19 AM

Mar 11 2023

bcr added a comment to D31612: Handbook/Introduction: Update the Developmen Model description.

Any updates on this?

Mar 11 2023, 2:12 PM
bcr accepted D31273: Strengthen warnings about ext4.

Looks good to me now.

Mar 11 2023, 2:09 PM
bcr accepted D37240: First batch of alt text to images in articles and books.

Looks good to me, definitely useful to have.

Mar 11 2023, 2:07 PM

Mar 10 2023

bcr accepted D39016: 13.2 relnotes: additions/changes suggested by emaste.

Looks good for the doc side of things.

Mar 10 2023, 3:32 PM

Mar 9 2023

bcr added a comment to D38998: 13.2 relnotes: updates on wifi and boot loader.

Sure, go ahead!

Mar 9 2023, 1:27 PM
bcr accepted D38919: freebsd-status-report-process: Add article.

Excellent, nothing to complain about. Good work, ready to commit!

Mar 9 2023, 1:20 PM
bcr added a comment to D38919: freebsd-status-report-process: Add article.

A few minor language fixes, the rest looks good to me.
Good to have these instructions, thanks for writing them down.

Mar 9 2023, 12:35 PM
bcr accepted D38998: 13.2 relnotes: updates on wifi and boot loader.

OK for the documentation side of things.
Thanks for your help with the release notes!

Mar 9 2023, 9:00 AM

Feb 17 2023

bcr accepted D38627: rc.conf.5: clarify source directories.

Looks good. Don't forget the .Dd bump.

Feb 17 2023, 12:43 PM

Feb 6 2023

bcr accepted D38399: tarfs: Fix typo in man page..

OK from manpages.

Feb 6 2023, 3:29 PM
bcr accepted D38373: libmd / md5: Add SHA-512/224..

OK from manpages.

Feb 6 2023, 2:06 PM

Jan 20 2023

bcr added a comment to D38137: handbook basics: add information about GPT partitions.

Found a few minor nits.
We should definitely recommend people to use GPT over MBR.

Jan 20 2023, 5:25 PM

Jan 12 2023

bcr accepted D37435: Allow netcat to be a tun tunnel broker.

OK for the man page part of the change.

Jan 12 2023, 3:07 PM

Dec 30 2022

bcr added a comment to D37745: Add USES=tex.

A few small corrections, the rest looks OK to me.
Good to have a TEX section in the porters handbook with this change!

Dec 30 2022, 8:54 AM

Dec 29 2022

bcr accepted D37749: Fix INSTALL_DATA.

Looks good, approved for commit!

Dec 29 2022, 7:01 PM

Dec 18 2022

bcr added a comment to D37203: xlocale(3): Link man pages.

Can someone commit this? Thanks!

Dec 18 2022, 12:18 PM
bcr added inline comments to D37722: Add new rc: machine_id to generate /etc/machine-id.
Dec 18 2022, 12:14 PM

Dec 15 2022

bcr accepted D37710: spkrtest.8: Add module info.

Looks good to me.

Dec 15 2022, 3:12 PM

Dec 13 2022

bcr closed D37686: rcorder(8): Fix the EXAMPLES section.
Dec 13 2022, 7:58 PM
bcr committed rG47972d6dc4cb: Fix rcorder example to match the keyword in the description (authored by jlduran_gmail.com).
Fix rcorder example to match the keyword in the description
Dec 13 2022, 7:57 PM
bcr accepted D37686: rcorder(8): Fix the EXAMPLES section.

Good catch, I'll take care of it.
Thank you!

Dec 13 2022, 7:40 PM

Dec 10 2022

bcr added a comment to D37616: Handbook WG - Part I - Introduction - bsdinstall.

A few minor edits to the text: one missing word the others are suggestions only.

Dec 10 2022, 5:20 PM
bcr accepted D37665: patch jail.8 man page to add info on allow.nfsd.

Looks good. Thank you for your continued work on all things NFS.

Dec 10 2022, 10:10 AM

Dec 6 2022

bcr accepted D27318: freebsd-version(1): present -v option, to print verbose output.

OK from manpages for these latest changes. Thanks for your patience working on this patch!

Dec 6 2022, 4:29 PM

Nov 15 2022

bcr added a comment to D37381: Vale introduction in FDP.

About the use of "you".

Nov 15 2022, 2:14 PM · doceng

Nov 14 2022

bcr accepted D37381: Vale introduction in FDP.

Looks good!

Nov 14 2022, 8:37 AM · doceng
bcr added a comment to D37383: service(8): add -s for showing status.

Quick question: some of the if-statements here are wrapping the check into [], while others do not.
Do we have some kind of style-guide for shell scripts like this for consistency?
Nothing against the change per se, just wondering.

Nov 14 2022, 8:22 AM · rc

Nov 13 2022

bcr accepted D37377: vim configuration for vale.

Looks good, ready to commit!

Nov 13 2022, 9:22 AM · doceng
bcr accepted D36769: Add documentation of pkg-{pre,post}-[de]install[.lua].

Looks good now!

Nov 13 2022, 9:19 AM
bcr accepted D36770: Copyedit zirias' pre*/post* update..

Looks good to me now. I'm approving this one and https://reviews.freebsd.org/D36769. Thanks!

Nov 13 2022, 9:19 AM

Nov 12 2022

bcr added a comment to D37362: vale integration with editors.

Looks good as a first introduction to vale. A few fixes and then you can commit it to the FDP primer.

Nov 12 2022, 6:20 PM
bcr added a comment to D36769: Add documentation of pkg-{pre,post}-[de]install[.lua].

I like these additions, thanks!
A few fixes provided in the comments.

Nov 12 2022, 2:28 PM

Oct 29 2022

bcr added a comment to D37207: Fixing the definition of the term "committer".

The term "Committer" was used way before SVN times.

Oct 29 2022, 4:47 PM · docs

Oct 28 2022

bcr added a comment to D32700: nvmecontrol: Implement Get/Set Feature for nvmecontrol.

Found a line break after a sentence stop. You can run textproc/igor over your man page to find these.
Also, "mandoc -T lint" may also be helpful.

Oct 28 2022, 6:46 AM
bcr added a comment to D29543: license: Create a license guideline document.

Very minor issue with the core-email in one place.
Thanks for working on this!

Oct 28 2022, 6:14 AM

Oct 27 2022

bcr added a comment to D37135: hier(7): remove text describing /usr/src layout.

Found a typo. You can fix it when committing. Thanks for this work!

Oct 27 2022, 7:00 AM

Oct 23 2022

bcr requested review of D37096: Add missing resolv.conf(5) options documentation .
Oct 23 2022, 10:23 AM

Oct 18 2022

bcr added a comment to D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases.

Who's going to commit this?

Oct 18 2022, 8:30 AM

Oct 13 2022

bcr added a comment to D33233: sync.8: Document that the "sync dance" is not a thing.

I would love to see this in the man page. Any updates?

Oct 13 2022, 6:30 PM
bcr added a comment to D26552: Revert DTS for omap family for stable/12 and releng 12.2.

Will someone commit this? It's been approved for a while...

Oct 13 2022, 6:25 PM · ARM
bcr added a comment to D32979: ps(1): let J flag list all jailed processes.

Any updates on this one?

Oct 13 2022, 4:44 PM
bcr accepted D36972: books: Updating ports count statistics in dev-model.

I like this initiative. It does make the page much better than before and with the update script, we'll keep it up-to-date.
I'd say we commit the base bits now and refine it in a follow-up commit (i.e. when the script is running with help from Sergio).

Oct 13 2022, 4:42 PM · docs
bcr added a comment to D18832: NTB Perf: Tool to measure performance of NTB hw drivers.

Any updates on this (from either side)?

Oct 13 2022, 4:37 PM
bcr added a comment to D32985: New manual page for vmrun.sh.

Any updates on this one?

Oct 13 2022, 4:34 PM · bhyve
bcr accepted D35401: pmcannotate: Add a '-m' mode option to control per-line annotations..

OK from manpages.

Oct 13 2022, 4:32 PM

Oct 12 2022

bcr accepted D36407: ls: `-v` flag.

Manpage looks good now. Thank you!

Oct 12 2022, 4:00 PM

Oct 11 2022

bcr accepted D36931: Update committer numbers.

Looks good. Would be amazing if this would be updated automatically by a script of some kind.

Oct 11 2022, 1:30 PM

Oct 8 2022

bcr added a reverting change for rG1c2be25f6080: Add extra EINVAL information about wrong block size to read(2)/write(2): rG44b0b943b8f3: Revert "Add extra EINVAL information about wrong block size to read(2)/write(2)".
Oct 8 2022, 10:29 AM
bcr added a reverting change for D24617: Add additional EINVAL information about wrong block size to read(2)/write(2): rG44b0b943b8f3: Revert "Add extra EINVAL information about wrong block size to read(2)/write(2)".
Oct 8 2022, 10:29 AM
bcr committed rG44b0b943b8f3: Revert "Add extra EINVAL information about wrong block size to read(2)/write(2)" (authored by bcr).
Revert "Add extra EINVAL information about wrong block size to read(2)/write(2)"
Oct 8 2022, 10:28 AM

Oct 7 2022

bcr accepted D30351: ptrace: add an option to not kill debuggees on debugger exit.

OK from manpages.

Oct 7 2022, 6:11 PM
bcr committed R9:94f8098e1999: Remove whitespaces at end of line (authored by bcr).
Remove whitespaces at end of line
Oct 7 2022, 5:27 PM
bcr committed R9:a4c01d577a7e: Typo fix: stictly -> strictly (authored by bcr).
Typo fix: stictly -> strictly
Oct 7 2022, 4:37 PM
bcr committed R9:5acdd01ea951: Fix a typo: thouroughly -> thoroughly (authored by bcr).
Fix a typo: thouroughly -> thoroughly
Oct 7 2022, 4:32 PM
bcr abandoned D19954: Remove reference to nonexistent npfctl from blacklistd man page.

Overcome by events, someone else removed the section by now.

Oct 7 2022, 2:22 PM
bcr accepted D28450: lualoader: add support for .lua configuration files.

Manpage looks good, we can do the filename markup in a followup commit.

Oct 7 2022, 2:19 PM
bcr added a comment to D32556: Add __FreeBSD_versions 1400037 and 1400038 to handbook.

The changes were already committed to the porters-handbook. You can close this review.
Thanks for submitting it anyway.

Oct 7 2022, 2:10 PM
bcr accepted D33477: ithread(9): update top-level description.

OK from manpages.

Oct 7 2022, 2:05 PM
bcr accepted D34502: libmd: export and document *Fd/*FdChunk interfaces.

Manpage looks good. Thanks!

Oct 7 2022, 2:02 PM
bcr accepted D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases.

Confirm man page looks good.

Oct 7 2022, 1:53 PM
bcr accepted D35980: Add support for _CR3 critical standby (S3) threshold..

OK from manpages.

Oct 7 2022, 1:49 PM