User Details
- User Since
- May 18 2014, 4:40 AM (653 w, 2 h)
Fri, Nov 20
Looks good to me. Thanks!
Mon, Nov 16
Sun, Nov 15
Update patch, fixing line breaks after the sentence stop and bumping .Dd.
Cool, thanks for adding it, Alexander.
Minor suggestion to add the -U999999 option to the git format-patch line.
Sat, Nov 14
Some fixes for the man page. You may also try out mandoc -Tlint and see if it gives you additional things to fix.
Other than that, I'm a ... well... fan. ;-)
Now it reads great. Thanks a lot!
Fri, Nov 13
Mostly typo fixes.
Do a separate sweep for sentences containing "you" in them. They need to be rephrased in a neutral tone and ideally in active voice. You can find some tipps here: https://docs.freebsd.org/en/books/fdp-primer/writing-style/ . I'd be happy to review the update.
Some typo fixes, nothing major.
Sun, Nov 8
Do we need to update this patch further or can it be committed as it is?
Looks good to me. Man page date bump may seem in order.
Fri, Nov 6
Great, something to look forward to!
Looks good to me.
Wed, Nov 4
@kfv Good catch. I'll add it there as well and commit them both. Thank you!
Mon, Nov 2
Sun, Nov 1
Coming back to this patch after a while, I did the following:
a) factored out the two files that @ngie was OK with into this update
b) open a new review soon for the patches that concerns @pho's area
c) left out those parts that won't apply cleanly anymore. They may be obsolete or require further investigation.
Fri, Oct 30
Looks good to me. Thanks for writing it!
Small fix, the rest looks fine to me.
Thu, Oct 29
Oct 17 2026
Man page changes look good now.
Someone still working on this?
Man page changes loo good to me now.
OK from manpages for these latest changes.
Oct 11 2026
Good to go from manpages.
Oct 3 2026
OK for the man page part of the change.
Sep 27 2026
Man page looks good to me. Excited to see the tool in action.
Sep 26 2026
The changes to the manpage look good to me. Thanks!
Looks good to me for this man page change.
Fine from manpages.
OK from manpages. Bumping .Dd seems appropriate.
Sep 25 2026
OK from manpages. Thank you for adding these manpages!
Sep 24 2026
OK from manpages. Good work!
Sep 13 2026
Looks good to me. Thank you!
Great, keep it up!
Sep 11 2026
Sep 10 2026
OK from manpages.
Ok from manpages.
Sep 9 2026
OK for the manpage, looks good!
Any updates here? Anyone still working on it?
The original bug has been closed in the meantime, due to the rewrite of the OpenZFS chapter.
There is only mention of ada in that chapter. At one point, there is mention that older disks use different names, but the rest of the chapter uses ada0, dada1, ... in the examples consistently.
Sep 5 2026
OK for the man page part.
Aug 16 2026
Sorry to keep you waiting. I only saw this now.
Approved (maybe check if something has changed in the meantime).
Aug 15 2026
Looks good to me, thank you!
Looks good to me. Thanks!
I think this is fine to add.
I found a missing word. Other than that, the rest looks OK.
OK for the manpage part.
OK for the doc/man page change.
OK from manpages.
OK for the doc part (UPDATING node) of the change.
Jul 12 2026
Excellent, then let's have this in the handbook. Approved!
Amazing to read through this rewrite. It is a much needed and substantial rewrite/update of most of the chapter. I only found this small nit.
Make sure to reference Bug 287148, Bug 261212, and maybe even Bug 263321. Thank you very much!
Jul 11 2026
Wow, this is an amazing writeup and a great update to the ZFS chapter. Thanks so much for working on it.
Nice man pages you have there. Shame if no-one would approve them. ;-)
