Sorry to keep you waiting. I only saw this now.
Approved (maybe check if something has changed in the meantime).

Looks good to me, thank you!

Looks good to me. Thanks!

I think this is fine to add.

I found a missing word. Other than that, the rest looks OK.

OK for the manpage part.

A small man page nit.

OK for the doc/man page change.

OK from manpages.

OK for the doc part (UPDATING node) of the change.

Excellent, then let's have this in the handbook. Approved!

Amazing to read through this rewrite. It is a much needed and substantial rewrite/update of most of the chapter. I only found this small nit.
Make sure to reference Bug 287148, Bug 261212, and maybe even Bug 263321. Thank you very much!

Wow, this is an amazing writeup and a great update to the ZFS chapter. Thanks so much for working on it.

Nice man pages you have there. Shame if no-one would approve them. ;-)

Mention that the loader boots from encrypted datasets, not pools.

Update patch which includes comments and corrections.

I'm taking over due to feedback timeout.

We can't make changes to past release notes once they are published. They become part of the release hash and would change in a number of places that reference them (even if they contain typos).

Update patch to address comments.

Thanks for the comments, @michaelo . I'll update the patch to reflect your suggested changes.

Is there more work on this to come @felix.the.red_gmail.com ? We would really like to see this man page in FreeBSD.
If you're to busy, we can probably finish the rest ourselves. Just wanting to make sure this is still actively being worked on. Thanks!

Add some ZFS experts for their opinion. Thanks in advance!

OK from manpages.

Good for the doc side of things.

Good to go!

Small issue found. Maybe mandoc -Tlint finds others?

Accidentally closed, please still review.

... and now with context (sorry for the churn).

And now in git-format-patch(1) style.

Update the diff with the proper full path within the doc repo.

The manpage looks good now, thanks!

Better solution, thanks for the exchange about it!

The whitespace change after the fi was unintentional, but while I was there, I fixed it, too.

OK from manpages. Make sure to bump the .Dd to the date when you commit it.

OK from manpages. Don't forget to bump the .Dd when committing. Thanks for the update!

Approved for commit. Thanks for these changes!

This should have been committed long ago. Let's go ahead with it! Thanks for the work, @carlavilla !

A few suggestions. The rest looks good!

Can you update the patch to use ada instead of ad, which is the more canonical naming used these days?

I'm committing it now.

Small textual corrections, nothing major.

@carlavilla : Can you commit this? It would also close PR 293519. Thank you!

ping?

Good suggestion! I've added a link to the uefi(8) man page.

Some grammatical corrections.

Any updates here?

OK from manpages.

OK from manpages. Thanks!

OK for the man page part of the change.

A small manpage fix, the rest looks OK.

Looks good to me.