In D32436#791966, @pauamma_gundo.com wrote:

In D32436#791757, @bcr wrote:

Any update on this?

Are you and I waiting for each other to do something, or are you asking someone else?

Any update on this? Would love to show the world that FreeBSD supports Wayland to the degree that is described here.
We can then add stuff later once we already have a basic handbook chapter.

OK for the manpages part of the change.

Typo in man page.

Looks good, thanks for the update.

Same here, can't find any grammar or other nits.

Small suggestion, I know that it is still a draft. But good to eventually have such a man page!

Sounds good to have in there as these old misconceptions are still around. Approved from my side.

Alright, I incorporated these last feedback items. I'm going to commit this shortly.
Thanks to all reviewers, your feedback and suggestions helped a lot in improving the text!

Looks like a reasonable change to me, having these shared over more languages.

Looks good to me.

Checked up and good to go!

Man page part of the change looks good. It needs a .Dd date bump when the commit happens.
Thanks for keeping up the good work on pf!

Change an instance of "alone" to "only" in the L2ARC description to not confuse people about adding multiple devices there.

Reply with confirmation about the L2ARC vdevs question.

Two minor fixes.

Minor comma nit, the rest looks good.

Looks good. Make sure to bump the .Dd for these content changes.

Update with some of my own replies.

Yet another update addressing some of @pauamma_gundo.com's comments.

Sounds better now, so the man page looks good to me now.
Thanks for implementing that feature!

I found two things worth "exploring".

Just a minor nit, the rest looks good, doc-wise.

OK from manpages.

OK from manpages.

Update including the lastest suggestions to the lower last part of the chapter.

Another big update, including both @ygy's and @pauamma_gundo.com's comments.
I should have kept the diff much smaller in retrospect, sorry about that. We're getting close to the final piece now, thanks to your efforts!
The line breaks were caused by my editor trying to be smarter than it should be.

New version that includes suggestions by @pauamma_gundo.com

Phew, a lot of changes, most of which I concur with and changed. Thanks!
Updated patch follows.

OK from manpages.

Minor typo, the rest looks good.

OK from manpages.

A few comments, mostly agreeing with the suggestion.

Another fine set of changes, including most (if not all) suggestions by @pauamma_gundo.com

In D31707#715615, @debdrup wrote:

In D31707#715576, @bcr wrote:

Maybe one more reason to use dataset more to avoid this ambiguity? ;-)

Calling them datasets introduces new ambiguities, because a dataset can both be a filesystem and a volume, and it's possible that it's definition will be expanded in future versions too.

Update diff to incorporate changes from @debdrup and @pauamma_gundo.com . Looking forward to the second half of changes. I know it's tedious and I should have kept it shorter. Will consider than for future changes like this on other chapters.

Thanks for your suggestions, @debdrup and @pauamma_gundo.com . I incorporated a lot of them into the next set of changes.
I looked at our current docs for the word list on how to write "file system" versus "filesystem". It seems like it does not exist in the FDP primer anymore. It used to be there in the old one: https://www-legacy.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/writing-style-word-list.html . Maybe one more reason to use dataset more to avoid this ambiguity? ;-)

Updated diff incorporating suggestions by @ceri

In D31707#715385, @ceri wrote:

Running out of battery so submitting what I have reviewed. Generally speaking I think the shorter text works against the intent of this being a guide, I'm afraid.

This one uses git diff --no-prefix -U1000

OK for the manpage part of the change.

Yes, this makes sense. Approved!

OK from manpages.

OK from manpages.

Approved!

Separate issue found about the use of you.
The actual change looks fine to me. Thanks!

Wow, good work. Nothing to complain about.

OK from manpages.

Minor question about which keys are valid to press.

@imp: No more work done since then. If you want to take over, I'd appreciate it.
You can keep me in the list of reviewers for any textual changes you're making. Thanks!

OK from manpages. Looks like a nice feature.

OK from manpages, too. Thanks for addition this feature.

Looks good to me.

Manpage looks good.

Minor nit, thanks for the update.

OK for the manpage part of the change. You need to bump the .Dd for this content change when you commit.

Cool, I like this addition of language servers. I added some language improvements.

OK from manpages as well.

Go for it! Thanks.

OK from manpages.

Cool, I like this.

Manpage looks good. Thanks for yet another driver!

OK from manpages,

OK for the manpage part of the change.

Minor nit in the man page.

Good to go, thanks!

OK from manpages.

Ok from manpages.

A textual suggestion, the rest looks fine.

Manpage looking good, pending .Dd bump once approved.

Manpages is also fine with the change. Thanks!

OK from manpages. Thanks for the update!

In D27668#680170, @ygy wrote:

In D27668#680060, @bcr wrote:

I get the following exception from Phabricator upon loading this review:
Found unknown intradiff source line, expected a line beginning with "+", "-", or " " (space): \ No newline at end of file

@bcr Interesting... It is fine on my end, no errors. Where did you see this message?

OK from manpages.

I get the following exception from Phabricator upon loading this review:
Found unknown intradiff source line, expected a line beginning with "+", "-", or " " (space): \ No newline at end of file

A few minor nits, the rest looks fine.

Looks good!

OK from me as well. Thanks!

Manpage looks good now.

OK from manpages.

Looks good to me. Thanks for the update.

Only found these now. Looking good otherwise.

A few suggestions for wording improvements in the man page.

Adding Sergio, as I think this might interest him.
Having a way to build our docs on other platforms is nice and might bring in some new contributions.

OK for the man page update.

Other than this small nit, I'm fine with the change.

OK for the manpage change.