bcr (Benedict Reuschling)
User

Projects

User Details

User Since
May 18 2014, 4:40 AM (217 w, 3 d)

Recent Activity

Mon, Jul 16

bcr added a comment to D15713: Bug 182518 - [login.conf] Better Password Hashes .

There are a bunch of style issues with crypt.3. Can you run "mandoc -Tlint" and textproc/igor (from ports/packages) on it? It should give you some feedback where the problems are. For example, man pages need a line break after a sentence stop.

Mon, Jul 16, 7:54 PM · security

Fri, Jul 13

bcr accepted D16252: Update some URLs ( from http to https ).

Ah, you're right. Well then, time to commit this change.

Fri, Jul 13, 2:06 PM
bcr added a comment to D16252: Update some URLs ( from http to https ).

Comments on the flickr link...

Fri, Jul 13, 6:38 AM

Thu, Jul 12

bcr accepted D16235: Add the link to Continuous Integration Server.

Good inititative, I was thinking about the same thing, but you beat me to it. Approved!

Thu, Jul 12, 2:28 PM

Mon, Jul 9

bcr accepted D16166: More Core alumni document cleanup.

Fine by me, too.

Mon, Jul 9, 1:28 PM

Sun, Jul 8

bcr added a comment to D16149: Tweak ports(7).

You need to bump the .Dd since this is a content change in a man page.

Sun, Jul 8, 4:28 PM

Sat, Jul 7

bcr accepted D16167: Improve the introduction.

Looks good to me. Thank you for updating that section.

Sat, Jul 7, 11:09 AM
bcr added a comment to D16167: Improve the introduction.

A small textual correction.

Sat, Jul 7, 6:55 AM

Thu, Jul 5

bcr accepted D16152: More core.x updates.

Good catches, approved for commit!

Thu, Jul 5, 8:32 PM
bcr added a comment to D12507: Dummynet AQM usage documentation for ipfw man page.

Thank you for working on updating the man page.
Can you run "mandoc -Tlint" over the man page with your changes and fix the warnings ("new sentence, new line" and such)?
Running textproc/igor over the man page can also find and report issues.
The FDP primer's man page section on Markup Guidelines has some additional info that can help.

Thu, Jul 5, 5:46 PM

Wed, Jul 4

bcr accepted D16129: Update new core team liaison for CI team.

Ready to land, thanks!

Wed, Jul 4, 5:24 PM
bcr accepted D16128: Add news item for core.x.

Good to go!

Wed, Jul 4, 5:01 PM
bcr accepted D16123: Add description to debug.ncores..

Looks good, approved!

Wed, Jul 4, 11:14 AM
bcr accepted D16122: Update authors.ent and pgpkeys-core.xml for Core.X.

Approved!

Wed, Jul 4, 10:03 AM
bcr added a comment to D16115: geli init multiple providers.

Minor wording nit in the man page.

Wed, Jul 4, 6:52 AM
bcr accepted D16096: Update administration.xml and contrib.corealumni.xml for core.x.

OK from me as well. Thanks for doing the work!

Wed, Jul 4, 6:30 AM

Sun, Jul 1

bcr accepted D16084: Update the UPDATING file for 'overwrite the oldest coredump'..

Hehe, yeah. It's good now, ready to commit!

Sun, Jul 1, 1:43 PM
bcr added a comment to D16084: Update the UPDATING file for 'overwrite the oldest coredump'..

Ah, now even *I* understand it. ;-)
A few fixes to the new text, then it is fine.

Sun, Jul 1, 1:16 PM
bcr added a comment to D16084: Update the UPDATING file for 'overwrite the oldest coredump'..

A few suggestions...

Sun, Jul 1, 10:46 AM
bcr added a comment to D16080: Multiple updates for the committer guide.

A few suggestions on fixes (a missing word, typo, and line breaks).

Sun, Jul 1, 10:10 AM

Thu, Jun 28

bcr accepted D16050: Automatically run ntpd as non-root when possible..

Thanks indeed for the work. OK from manpages.

Thu, Jun 28, 8:01 PM

Wed, Jun 27

bcr accepted D14022: NVMe emulation for bhyve (improved).

Cool, thanks for the quick reply.
Approved from manpages. Don't forget to bump the .Dd to the date of the commit.

Wed, Jun 27, 1:58 PM
bcr added a comment to D14022: NVMe emulation for bhyve (improved).
Wed, Jun 27, 1:53 PM
bcr added a comment to D14022: NVMe emulation for bhyve (improved).

Two textual suggestions for the man page.

Wed, Jun 27, 1:53 PM

Tue, Jun 26

bcr accepted D12644: geli attach multiple providers (no kernel changes).

OK from manpages. Don't forget to bump the .Dd at the beginning of the man page with the date of the commit.
Thanks!

Tue, Jun 26, 4:32 PM

Sat, Jun 23

bcr committed rD51905: Add the Linuxhotel hackathon and BSDCam as two new events..
Add the Linuxhotel hackathon and BSDCam as two new events.
Sat, Jun 23, 3:31 PM
bcr committed rD51904: Style cleanup, purely cosmetical, no visual content changes:.
Style cleanup, purely cosmetical, no visual content changes:
Sat, Jun 23, 2:56 PM
bcr accepted D15766: Document libcasper_service.

Sorry for the wait. Looks good to me now.

Sat, Jun 23, 12:59 PM

Fri, Jun 22

bcr added a comment to D15960: top(1): Start parsing colors.

Would it make sense to add an EXAMPLES section that shows how to define a proper TOPCOLOR?

Fri, Jun 22, 9:19 PM

Thu, Jun 21

bcr removed a reviewer for D10600: Revision of LDAP section of the FreeBSD Handbook: manpages.
Thu, Jun 21, 4:59 PM · Doc Committers, network
bcr added a comment to D10600: Revision of LDAP section of the FreeBSD Handbook.

So, you're saying the we need testers for this configuration before we put it in the handbook as official instructions?

Thu, Jun 21, 4:58 PM · Doc Committers, network

Tue, Jun 19

bcr accepted D15578: Document ${name}_env_file in the rc.subr manual.

Sorry, it must have slipped through the cracks. It's fine. Can you bump the .Dd before you commit? Thanks!

Tue, Jun 19, 5:19 PM · manpages
bcr added a comment to D10993: Start updating the Subversion primer..

Just a formatting thing that I found, the rest looks fine.

Tue, Jun 19, 2:24 PM
bcr committed rD51883: Announce National FreeBSD Day, with FreeBSD turning 25 years old today..
Announce National FreeBSD Day, with FreeBSD turning 25 years old today.
Tue, Jun 19, 10:18 AM

Mon, Jun 18

bcr added a comment to D10600: Revision of LDAP section of the FreeBSD Handbook.

A few suggestions, mostly about line breaks with a few textual corrections.

Mon, Jun 18, 5:37 PM · Doc Committers, network

Jun 17 2018

bcr added a comment to D15868: Update features list..

A few small suggestions.

Jun 17 2018, 6:21 PM
bcr committed rD51864: Style cleanup:.
Style cleanup:
Jun 17 2018, 4:58 PM
bcr committed rD51862: Wrap two overly long lines. No content changes..
Wrap two overly long lines. No content changes.
Jun 17 2018, 4:40 PM
bcr added a comment to D15866: Update the GELI description to be more accurate.

Suggestion to split a sentence in two to avoid a colloquial "so".

Jun 17 2018, 4:06 PM

Jun 16 2018

bcr accepted D15849: pt_BR.ISO8859-1/share/xml/header.l10n.ent: Merge from English version r51827 -> r51840.
Jun 16 2018, 7:10 PM

Jun 15 2018

bcr accepted D15794: Add pt_BR header and navibar entities.
Jun 15 2018, 6:10 PM
bcr accepted D15811: Two small tweaks to USB device mode chapter.

Suggestion to use tags. Other than that, it's fine.

Jun 15 2018, 7:09 AM
bcr accepted D9311: vfs.zfs.arc_max and arc_min are now adjustable at runtime.

Good to go!

Jun 15 2018, 6:55 AM

Jun 14 2018

bcr committed rD51831: Properly break some overflowing lines that textproc/igor was reporting..
Properly break some overflowing lines that textproc/igor was reporting.
Jun 14 2018, 5:14 PM

Jun 13 2018

bcr accepted D15781: Update the list of supported architectures.
Jun 13 2018, 11:55 AM

Jun 12 2018

bcr added a comment to D15748: Support destroy of multiple bookmarks on a single dataset..

Thanks for the screenshot comparing the two man page renderings. I'm good with both ways.

Jun 12 2018, 7:31 PM · ZFS
bcr committed rD51824: Re-commit my cleanup changes..
Re-commit my cleanup changes.
Jun 12 2018, 6:54 PM
bcr committed rD51823: Revert until I figure out the build breakage..
Revert until I figure out the build breakage.
Jun 12 2018, 6:19 PM
bcr committed rD51822: Make igor happier about the releng article source..
Make igor happier about the releng article source.
Jun 12 2018, 6:07 PM
bcr added a comment to D15766: Document libcasper_service.

A few man page corrections. textproc/igor is your friend (besides me, of course. ;-))

Jun 12 2018, 11:14 AM

Jun 11 2018

bcr added a comment to D15748: Support destroy of multiple bookmarks on a single dataset..

Man page nit.

Jun 11 2018, 5:27 PM · ZFS

Jun 10 2018

bcr accepted D15742: nits in FAQ.

Looks good, approved!

Jun 10 2018, 8:12 PM
bcr accepted D15741: Update DVD+RW urls.

Approved

Jun 10 2018, 7:04 PM
bcr committed rD51814: Replace mentions of obsolete sysinstall with bsdinstall in the whole releng.
Replace mentions of obsolete sysinstall with bsdinstall in the whole releng
Jun 10 2018, 6:55 PM
bcr added a comment to D15586: Cover using symbolic names for interfaces in VLAN article of handbook..

A few corrections and sentence rephrasing.

Jun 10 2018, 3:49 PM

Jun 6 2018

bcr accepted D15676: Add automated (non interactive) mode to etcupdate.

OK from manpages, if you bump the .Dd upon commit.

Jun 6 2018, 3:35 PM

Jun 2 2018

bcr added a comment to D15652: pty.3: Add a HISTORY section.

Small nit.

Jun 2 2018, 9:42 PM
bcr committed rD51767: Fix links to the dogs of FreeBSD and IRC nicks links on the wiki..
Fix links to the dogs of FreeBSD and IRC nicks links on the wiki.
Jun 2 2018, 8:31 PM
bcr committed rD51766: Replace vim-lite with vim console, as the port was renamed..
Replace vim-lite with vim console, as the port was renamed.
Jun 2 2018, 8:13 PM

May 29 2018

bcr accepted D15513: Rewrite USB device mode chapter.

Looks good to me now, approved!

May 29 2018, 2:02 PM

May 22 2018

bcr added a comment to D15513: Rewrite USB device mode chapter.

Thank you for updating the handbook chapter with your work on USB device mode. I added some things I've found. Mostly minor things, easy to fix.

May 22 2018, 5:02 PM
bcr accepted D15519: CARP preemption explanation is misleading.

Looks good, approved!

May 22 2018, 2:30 PM
bcr accepted D15500: Add Warsaw user group..

From what I can tell, the indentation of "family" should start below the 'e' of <description>.

May 22 2018, 7:20 AM

May 21 2018

bcr accepted D15229: Allow run-time delayed attachment of devices.

OK from manpages.

May 21 2018, 10:38 AM
bcr accepted D9251: add xref to Subversion information to FDP primer.
May 21 2018, 10:37 AM

May 20 2018

bcr added a comment to D9251: add xref to Subversion information to FDP primer.

A tip on formatting.

May 20 2018, 8:49 PM
bcr added a comment to D15229: Allow run-time delayed attachment of devices.

I suggest running textproc/igor on the man pages. It will give you a few tips on how to correct some errors.
Thanks for writing the man page.

May 20 2018, 8:24 PM
bcr added a comment to D15500: Add Warsaw user group..

Two comments, minor things, easy to fix.

May 20 2018, 1:17 PM
bcr accepted D15499: Remove Lublin user group..

OK, you can commit that. Thanks!

May 20 2018, 1:12 PM

May 19 2018

bcr accepted D15473: Add on bhyverun a new option '-B' that gives the capability to change the smbios table type1 using an ucl based configuration file..

OK from manpages. Thanks for working on it!

May 19 2018, 2:59 PM

May 13 2018

bcr committed rD51649: My old key is about to expire in a couple of days..
My old key is about to expire in a couple of days.
May 13 2018, 7:29 PM
bcr added a comment to D11124: ZSTD compression for ZFS.

Can you bump the .Dd on zpool-features.7 (content change)?

May 13 2018, 10:51 AM

May 3 2018

bcr added a comment to D15276: Add virtio-scsi block storage backend support.

s/scsi/SCSI/ suggestion.

May 3 2018, 3:35 PM

Apr 28 2018

bcr committed rD51593: Add an entry for EuroBSDcon 2018 in Romania..
Add an entry for EuroBSDcon 2018 in Romania.
Apr 28 2018, 11:06 AM

Apr 23 2018

bcr accepted D15163: Catch up to Bugzilla product name change....

Good catch! Thanks.

Apr 23 2018, 7:45 AM

Apr 21 2018

bcr accepted D15135: gpart.8: list all options in table form for each command.

OK from manpages.

Apr 21 2018, 10:58 AM

Apr 12 2018

bcr added a comment to D15029: new utility usr.sbin/spi.

You need to bump the .Dd of the man page to the day of the commit, since these are content changes. Thank you for working on this.

Apr 12 2018, 6:49 AM

Apr 6 2018

bcr accepted D9930: Bhyve cpu topology control.

*smash*

Apr 6 2018, 9:13 PM
bcr added a comment to D9930: Bhyve cpu topology control.

I think we're still good on the man page!

Apr 6 2018, 8:55 PM
bcr accepted D14067: Update FreeBSD versions referenced in Poudriere docs....

Excellent, I think this can go in now.
Thank you for working on it.

Apr 6 2018, 3:58 PM · Doc Committers
bcr added a comment to D14067: Update FreeBSD versions referenced in Poudriere docs....

Only two small nits that I found.

Apr 6 2018, 3:12 PM · Doc Committers
bcr added a comment to D14984: Sleep rather than spin in e1000 when doing long running config operations.

When I read the title of the review, I thought it was some kind of medical advice for sysadmins or something. ;-)
Sorry, this does not help the review, just wanted to let you know.

Apr 6 2018, 7:05 AM

Apr 5 2018

bcr accepted D14966: rsu(4) does not require legal.realtek.license_ack=1.

OK from manpages. Bump the .Dd when you do the actual commit (once network has approved, too). Thanks for working on this!

Apr 5 2018, 10:35 AM · manpages

Mar 31 2018

bcr accepted D14914: isoboot - boot an ISO image that happens to be on something that isn't a CDROM under BIOS.

OK from manpages. Thanks for working on this!

Mar 31 2018, 10:48 AM

Mar 30 2018

bcr added a comment to D14887: Improve error messages for vipw.

Typo fix in comment.

Mar 30 2018, 12:25 PM

Mar 20 2018

bcr accepted D14774: Extend HISTORY section in altq(4) & altq(9).

Hehe, no worries, we all have to from time to time. Approved!

Mar 20 2018, 7:55 PM
bcr added a comment to D14774: Extend HISTORY section in altq(4) & altq(9).

Hmm, strange. Check out the FDP primer on man pages, section 13.3.3.:

Mar 20 2018, 7:16 PM
bcr added a comment to D14774: Extend HISTORY section in altq(4) & altq(9).

Check it with textproc/igor, but I think these are the only things that need to be changed.

Mar 20 2018, 6:58 PM

Mar 16 2018

bcr accepted D12075: Improve wording in Contributing article.

Great, thanks!

Mar 16 2018, 7:46 PM

Mar 15 2018

bcr added a comment to D12075: Improve wording in Contributing article.

ping?

Mar 15 2018, 9:55 AM

Mar 10 2018

bcr added a comment to D14169: Extending the bsdinstall(8) documentation to include ZFS scripted installation.

@dteske: Can you take a final look on the updated patch? Would be good to have this in the man page. Thank you!

Mar 10 2018, 8:35 AM
bcr closed D13335: clean man lint warnings in sbin/.

Most, if not all of these have been fixed by now. So, I'm closing this review.
Thank you for submitting these changes, anyway. Keep it up!

Mar 10 2018, 8:26 AM

Mar 9 2018

bcr accepted D14606: Add man page for sysctl service..

Approved for commit. Thank you for taking the time to write the man page.

Mar 9 2018, 12:57 AM

Mar 7 2018

bcr accepted D9930: Bhyve cpu topology control.

OK from manpages.

Mar 7 2018, 10:42 PM
bcr accepted D14605: Add man page for pwd service..

It's good, thanks for writing it.

Mar 7 2018, 2:59 PM
bcr added a comment to D14606: Add man page for sysctl service..

A few language fixes, but nothing major.

Mar 7 2018, 2:55 PM
bcr accepted D14607: Cleanup libcasper man page..
Mar 7 2018, 2:41 PM
bcr added a comment to D9930: Bhyve cpu topology control.

Found a small whitespace nit in the man page. Also, you need to bump the .Dd to the date of the commit (when it is ready).

Mar 7 2018, 2:17 PM

Mar 6 2018

bcr accepted D14592: Update the diskless manpage.

Good, thanks!

Mar 6 2018, 1:55 PM
bcr added a comment to D14592: Update the diskless manpage.

You need to bump the .Dd at the beginning since this is a content change.

Mar 6 2018, 1:22 PM