- User Since
- May 18 2014, 4:40 AM (257 w, 1 h)
Fri, Apr 19
Thank you for the quick edits. Approved by manpages for that part.
Can you run textproc/igor and "mandoc -Tlint" over the man page and see what warnings/errors they give you? Thanks!
OK from manpages.
Thu, Apr 18
Update with Kristof's comments.
Some comments. I'm more inclined on putting it into section 8 of the man pages. Going from the description of sections in man(1), it's more geared towards sysadmins rather than being a general FreeBSD command to run.
Have you run textproc/igor over it and "mandoc -Tlint" for any errors/warnings it might find?
Wed, Apr 17
Sat, Apr 13
Approved. Don't forget to bump the .Dd to today. Thank you!
A small typo fix, the rest looks good.
Thu, Apr 11
I will polish it a bit more and commit it.
Wed, Apr 10
A bit more description about the shared folders would be useful here. For example, describe that users need to create the folder (shared_folder_name) in their VM first and where the mount_vboxfs command should be run (host or VM). Thanks!
Tue, Apr 9
Mon, Apr 8
Thu, Apr 4
Not a bug, closed.
This typo has been fixed in HEAD r342579 already. Thanks for letting us know anyway.
OK for the man page.
Regarding @0mp's comment about the reference from openssl(1): we can do that later after this change has been committed. It's not critical to do that with this change.
Wed, Apr 3
Who's gonna commit this?
Tue, Apr 2
Looks good to me, thanks for doing the work!
Mon, Apr 1
Looks good to me. Thanks, @jhb, for taking over the mentorship!
Fri, Mar 29
Can you run textproc/igor and "mandoc -Tlint" over your man page change? I found one issue, maybe those tools have more. Thanks!
Thu, Mar 28
Looks good, approved!
Thanks for the quick writeup. I've only a few minor corrections.
Wed, Mar 27
Provide a link to the (small) word list in the FDP.
Sun, Mar 24
A few minor suggestions to be more precise.
Sat, Mar 23
OK from manpages. Thanks for doing the work.
Mar 22 2019
Mar 21 2019
Mar 20 2019
Mar 18 2019
OK, sounds good. We can try that in the next quarter.
I've reviewed the report and found a few minor issues.
Overall, it takes a lot of time to read the whole piece. I could have found some of the bugs earlier when they were still individual reports that are easier to go over.
Other than that, thanks for your efforts putting it together!
Mar 14 2019
Definitely worth having those examples in that man page. Thanks for the work!
Mar 12 2019
Good work, approved!
Mar 11 2019
Mar 10 2019
Update pf.conf.5 with suggestions from @0mp.
Small nit, the rest is fine. Thanks for adding the example, I think it is really useful to have.
Mar 9 2019
Mar 8 2019
Looks good to me. Thanks!
Mar 7 2019
Clarify some more.
This newer version is better as it gives an alternative for people who need that Monday-starts-the-week functionality. Approved!
Some countries start their week on Sunday, so I guess cal originated there and does not take other countries into account.
That being said, the change itself looks fine. Bumping the .Dd for this content change not withstanding. ;-)
Mar 6 2019
Feb 27 2019
Good catch, approved!
Feb 26 2019
OK from my point of view.
can you run textproc/igor and "mandoc -Tlint" over your man page change? It will give you a few suggestions (not many). Thanks!
I agree this is a historical leftover and does not apply anymore.
Feb 25 2019
Feb 22 2019
Sorry for the wait. Looks good to me. I can get it committed.
Nice, thanks for those changes. I can commit them later today.
Feb 21 2019
OK from manpages. Can't say much about the content itself, but syntax looks good.
Feb 15 2019
Looks good, OK to commit.
Feb 14 2019
Just the normal <a href=...>blah</a> magic. See events2015.xml for an example.
Looks good from manpages. I guess bumping the .Dd to the date of the commit does not hurt.
I look forward to that feature. Thanks!
Feb 13 2019
Feb 12 2019
Just a small typo.