bcr (Benedict Reuschling)
User

Projects

User Details

User Since
May 18 2014, 4:40 AM (205 w, 4 d)

Recent Activity

Mon, Apr 23

bcr accepted D15163: Catch up to Bugzilla product name change....

Good catch! Thanks.

Mon, Apr 23, 7:45 AM

Sat, Apr 21

bcr accepted D15135: gpart.8: list all options in table form for each command.

OK from manpages.

Sat, Apr 21, 10:58 AM

Thu, Apr 12

bcr added a comment to D15029: new utility usr.sbin/spi.

You need to bump the .Dd of the man page to the day of the commit, since these are content changes. Thank you for working on this.

Thu, Apr 12, 6:49 AM

Fri, Apr 6

bcr accepted D9930: Bhyve cpu topology control.

*smash*

Fri, Apr 6, 9:13 PM
bcr added a comment to D9930: Bhyve cpu topology control.

I think we're still good on the man page!

Fri, Apr 6, 8:55 PM
bcr accepted D14067: Update FreeBSD versions referenced in Poudriere docs....

Excellent, I think this can go in now.
Thank you for working on it.

Fri, Apr 6, 3:58 PM · Doc Committers
bcr added a comment to D14067: Update FreeBSD versions referenced in Poudriere docs....

Only two small nits that I found.

Fri, Apr 6, 3:12 PM · Doc Committers
bcr added a comment to D14984: Sleep rather than spin in e1000 when doing long running config operations.

When I read the title of the review, I thought it was some kind of medical advice for sysadmins or something. ;-)
Sorry, this does not help the review, just wanted to let you know.

Fri, Apr 6, 7:05 AM

Thu, Apr 5

bcr accepted D14966: rsu(4) does not require legal.realtek.license_ack=1.

OK from manpages. Bump the .Dd when you do the actual commit (once network has approved, too). Thanks for working on this!

Thu, Apr 5, 10:35 AM · manpages

Sat, Mar 31

bcr accepted D14914: isoboot - boot an ISO image that happens to be on something that isn't a CDROM under BIOS.

OK from manpages. Thanks for working on this!

Sat, Mar 31, 10:48 AM

Fri, Mar 30

bcr added a comment to D14887: Improve error messages for vipw.

Typo fix in comment.

Fri, Mar 30, 12:25 PM

Mar 20 2018

bcr accepted D14774: Extend HISTORY section in altq(4) & altq(9).

Hehe, no worries, we all have to from time to time. Approved!

Mar 20 2018, 7:55 PM
bcr added a comment to D14774: Extend HISTORY section in altq(4) & altq(9).

Hmm, strange. Check out the FDP primer on man pages, section 13.3.3.:

Mar 20 2018, 7:16 PM
bcr added a comment to D14774: Extend HISTORY section in altq(4) & altq(9).

Check it with textproc/igor, but I think these are the only things that need to be changed.

Mar 20 2018, 6:58 PM

Mar 16 2018

bcr accepted D12075: Improve wording in Contributing article.

Great, thanks!

Mar 16 2018, 7:46 PM

Mar 15 2018

bcr added a comment to D12075: Improve wording in Contributing article.

ping?

Mar 15 2018, 9:55 AM

Mar 10 2018

bcr added a comment to D14169: Extending the bsdinstall(8) documentation to include ZFS scripted installation.

@dteske: Can you take a final look on the updated patch? Would be good to have this in the man page. Thank you!

Mar 10 2018, 8:35 AM
bcr closed D13335: clean man lint warnings in sbin/.

Most, if not all of these have been fixed by now. So, I'm closing this review.
Thank you for submitting these changes, anyway. Keep it up!

Mar 10 2018, 8:26 AM

Mar 9 2018

bcr accepted D14606: Add man page for sysctl service..

Approved for commit. Thank you for taking the time to write the man page.

Mar 9 2018, 12:57 AM

Mar 7 2018

bcr accepted D9930: Bhyve cpu topology control.

OK from manpages.

Mar 7 2018, 10:42 PM
bcr accepted D14605: Add man page for pwd service..

It's good, thanks for writing it.

Mar 7 2018, 2:59 PM
bcr added a comment to D14606: Add man page for sysctl service..

A few language fixes, but nothing major.

Mar 7 2018, 2:55 PM
bcr accepted D14607: Cleanup libcasper man page..
Mar 7 2018, 2:41 PM
bcr added a comment to D9930: Bhyve cpu topology control.

Found a small whitespace nit in the man page. Also, you need to bump the .Dd to the date of the commit (when it is ready).

Mar 7 2018, 2:17 PM

Mar 6 2018

bcr accepted D14592: Update the diskless manpage.

Good, thanks!

Mar 6 2018, 1:55 PM
bcr added a comment to D14592: Update the diskless manpage.

You need to bump the .Dd at the beginning since this is a content change.

Mar 6 2018, 1:22 PM
bcr accepted D14022: NVMe emulation for bhyve (improved).

OK from manpages, but don't forget to bump the .Dd once you commit it since this is a content change.

Mar 6 2018, 12:00 AM

Mar 5 2018

bcr accepted D14034: Chapter 17.9 of the Handbook: put -t cd9660 option for the ISO formats.

Good catch. Can you commit this yourself or should I do it (with proper credits, of course)?

Mar 5 2018, 11:58 PM
bcr accepted D14524: Document jail.conf(5) method of configuring jails.

I agree with the needed rewrites, but for this specific change, it is enough. Approved!

Mar 5 2018, 11:42 PM

Feb 27 2018

bcr added a comment to D14524: Document jail.conf(5) method of configuring jails.

Two comments...

Feb 27 2018, 7:50 PM

Feb 25 2018

bcr accepted D14502: Improve the disk growing instructions.
Feb 25 2018, 6:47 PM
bcr added a comment to D14502: Improve the disk growing instructions.

Missing word?

Feb 25 2018, 11:25 AM

Feb 22 2018

bcr accepted D14410: Fix reference to nvlist..

Sorry to keep you waiting, @oshogbo.Looks good to me. Make sure to bump the .Dd to the date when you commit it.
Thanks!

Feb 22 2018, 7:43 AM

Feb 21 2018

bcr committed rD51437: Fix the path to the XDM configuration file. It now resides in.
Fix the path to the XDM configuration file. It now resides in
Feb 21 2018, 6:23 PM

Feb 19 2018

bcr added a comment to D14336: Precisions/caveat for 30.8 Diskless Operation.

I found a typo...

Feb 19 2018, 9:37 AM

Feb 17 2018

bcr added a comment to D13335: clean man lint warnings in sbin/.

I have no time this weekend. I'd appreciate it if someone else could take this on.

Feb 17 2018, 12:38 PM

Feb 16 2018

bcr committed rD51426: Remove the fortune file commit policy. Fortune files were mostly deleted from.
Remove the fortune file commit policy. Fortune files were mostly deleted from
Feb 16 2018, 7:10 PM

Feb 15 2018

bcr committed rD51425: Add an extra paragraph to separate the law enforcement notification from the.
Add an extra paragraph to separate the law enforcement notification from the
Feb 15 2018, 6:04 PM
bcr added a comment to D14336: Precisions/caveat for 30.8 Diskless Operation.

I found a superfluous space (in addition to what @adridg has found.
Try checking it with textproc/igor, there might be additional output/suggestions.

Feb 15 2018, 12:28 PM

Feb 12 2018

bcr committed rD51417: Announce the new Code of Conduct for the Project..
Announce the new Code of Conduct for the Project.
Feb 12 2018, 8:43 PM

Feb 10 2018

bcr accepted D14289: VMware Virtual Machine Communication Interface (VMCI) kernel module.

Looks good now. OK from the manpages part of the module.

Feb 10 2018, 4:07 PM
bcr added a comment to D14289: VMware Virtual Machine Communication Interface (VMCI) kernel module.

OK, the man page looks better now.
You should also add an AUTHORS, HISTORY, and maybe SEE ALSO section at the bottom. See the examples here:
https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/manpages-sample-structures.html

Feb 10 2018, 2:02 PM
bcr added a comment to D14289: VMware Virtual Machine Communication Interface (VMCI) kernel module.

A few comments on the man page. You can use textproc/igor to check the man page for various common errors.
Thank you very much for working on this kernel module!

Feb 10 2018, 11:44 AM

Feb 8 2018

bcr accepted D13335: clean man lint warnings in sbin/.

Looks OK to me, thanks for working on that. Who's going to commit those?

Feb 8 2018, 10:45 AM

Feb 6 2018

bcr added a comment to D14224: More details in ld.lld manpage.

Two comments.

Feb 6 2018, 5:38 PM

Feb 5 2018

bcr added a comment to D14196: [man page] Introduce channel flags..

Argh, I missed that. Good that we both can count on @brueffer. ;-)

Feb 5 2018, 11:04 AM
bcr accepted D14196: [man page] Introduce channel flags..

Thanks for your continued work on documenting capsicum functionality, @oshogbo!

Feb 5 2018, 11:04 AM
bcr added a comment to D14196: [man page] Introduce channel flags..

Two typos, but the rest looks good.

Feb 5 2018, 10:47 AM

Jan 28 2018

bcr accepted D14084: Document cap_syslog service..

Approved!

Jan 28 2018, 5:54 PM
bcr added a comment to D14084: Document cap_syslog service..

Just a small thing, the rest looks good to me.

Jan 28 2018, 11:13 AM

Jan 27 2018

bcr accepted D14072: Document cap_random service..

Thanks for writing yet another man page, @oshogbo. Approved!

Jan 27 2018, 10:19 PM
bcr added a comment to D14072: Document cap_random service..

Two suggestions.

Jan 27 2018, 3:44 PM

Jan 25 2018

bcr accepted D13961: Updated the FAQ book's Chapter 15 about serial communicators.

Approved, thanks for working on it!

Jan 25 2018, 7:33 AM

Jan 22 2018

bcr accepted D13826: mlock(2): correct documentation for error conditions..

OK from manpages.

Jan 22 2018, 8:53 PM
bcr added a comment to D13826: mlock(2): correct documentation for error conditions..

Small man page nit.

Jan 22 2018, 8:39 PM
bcr added a comment to D13961: Updated the FAQ book's Chapter 15 about serial communicators.

I found one more typo.

Jan 22 2018, 6:59 PM
bcr added a comment to D13966: Added a new tutorial for connecting to a serial port through a usb-to-uart converter, as is the cases with most SoC's.

One small nit.

Jan 22 2018, 6:57 PM
bcr added a comment to D13961: Updated the FAQ book's Chapter 15 about serial communicators.

Just one more fix to the indentation level...

Jan 22 2018, 5:53 PM

Jan 20 2018

bcr added a comment to D13867: dtc(1) manpage review.

You can check with textproc/igor. I believe it should check for overlong lines in man pages, too.

Jan 20 2018, 9:09 PM

Jan 18 2018

bcr added a comment to D13961: Updated the FAQ book's Chapter 15 about serial communicators.

The indentation seems a bit off, so I refer you to Dr. igor. ;-)

Jan 18 2018, 6:28 PM
bcr added a comment to D13966: Added a new tutorial for connecting to a serial port through a usb-to-uart converter, as is the cases with most SoC's.

A few more suggestions.

Jan 18 2018, 6:24 PM
bcr accepted D13905: Update various statements in vmstat(8) to match reality..

Don't forget to bump the .Dd for this content change. Thanks!

Jan 18 2018, 6:12 PM
bcr added a comment to D13961: Updated the FAQ book's Chapter 15 about serial communicators.

A few comments. Don't be discouraged, you're on the right track.
One more thing though: next time when you create the diff, do it from the top level of your doc directory. That will include the full path to the file in the diff/review header and not just book.xml. We have many book.xml files, so having the path in there helps determining what file the patch is for.

Jan 18 2018, 8:38 AM

Jan 17 2018

bcr added a comment to D12075: Improve wording in Contributing article.

More info on proper link indentation. You're getting there...

Jan 17 2018, 5:47 PM

Jan 14 2018

bcr added a comment to D13867: dtc(1) manpage review.

A few suggestions for improvement.

Jan 14 2018, 5:10 PM
bcr accepted D13904: Sort the list of flags in newsyslog.conf entries..

Looks good to me.

Jan 14 2018, 4:39 PM

Jan 10 2018

bcr added a comment to D13821: Document cap_grp service..

New suggestion on how to word it better, based on your explanation, @oshogbo.
I found something else while there, but it's easy to fix. ;-)

Jan 10 2018, 9:54 AM
bcr added a comment to D13821: Document cap_grp service..

A few suggestions and corrections.

Jan 10 2018, 8:02 AM

Jan 9 2018

bcr added a comment to D13801: Reject the absurd user and group names "." and ".."..

Minor wording fixes.

Jan 9 2018, 7:59 AM

Jan 8 2018

bcr accepted D13793: Introduce aw_syscon(4) for earlier attachment.

OK from manpages.

Jan 8 2018, 8:38 AM

Jan 4 2018

bcr committed rD51363: Replace another instance of 2017 with 2018, which prevented the BSDCan entry.
Replace another instance of 2017 with 2018, which prevented the BSDCan entry
Jan 4 2018, 4:44 PM
bcr accepted D13762: Document cap_dns service..

Haha, yeah. But only because you have a certain Goat looking over your shoulder when writing it. :-)

Jan 4 2018, 8:43 AM
bcr added a comment to D13762: Document cap_dns service..

A few suggestions and corrections. Thanks for writing the man page!

Jan 4 2018, 8:25 AM

Jan 2 2018

bcr accepted D13734: Document supported services in the Casper man page..
Jan 2 2018, 9:09 PM · manpages
bcr added a comment to D13734: Document supported services in the Casper man page..

A small sentence rephrasing proposal.

Jan 2 2018, 10:31 AM · manpages

Jan 1 2018

bcr added a comment to D13620: aw_usbphy: Add manual page for this driver..

One small correction for the man page.

Jan 1 2018, 3:23 PM
bcr added a comment to D13720: aw_sid: Add man page for this driver.

Small corrections.

Jan 1 2018, 11:18 AM

Dec 31 2017

bcr committed rD51354: Fix event-id for FOSDEM to the actual year it will be in (2018)..
Fix event-id for FOSDEM to the actual year it will be in (2018).
Dec 31 2017, 6:40 PM
bcr committed rD51353: Bump copyright years for the doc tree to 2018 as listed in.
Bump copyright years for the doc tree to 2018 as listed in
Dec 31 2017, 6:38 PM
bcr committed rD51352: Bump the STARTYEAR to 2018, which was forgotten as part of r51351..
Bump the STARTYEAR to 2018, which was forgotten as part of r51351.
Dec 31 2017, 6:19 PM
bcr committed rD51351: Create a new events page for 2018 by copying the 2017 events page.
Create a new events page for 2018 by copying the 2017 events page
Dec 31 2017, 6:14 PM

Dec 29 2017

bcr added a comment to D13645: Make vt(4) palette configurable.

Typo fix.

Dec 29 2017, 1:22 PM

Dec 26 2017

bcr accepted D13617: Allwinner: gpio rename driver to aw_gpio and add man page for it.

Approved from manpages. Thanks for doing these changes.

Dec 26 2017, 11:33 AM
bcr accepted D13616: Allwinner: mmc: rename driver to aw_mmc and add man page for it.

OK from manpages.

Dec 26 2017, 11:32 AM
bcr added a comment to D13619: axp209: move driver to sys/dev/pmic.

A few corrections.

Dec 26 2017, 11:31 AM

Dec 25 2017

bcr accepted D13621: aw_rtc: Add man page for this driver.

Ok from manpages. Thanks for working on it.

Dec 25 2017, 7:09 PM
bcr added a comment to D13621: aw_rtc: Add man page for this driver.

Small typo.

Dec 25 2017, 6:37 PM

Dec 22 2017

bcr added a comment to D13456: bthidd: Add evdev protocol support.

A small man page fix.

Dec 22 2017, 8:53 AM

Dec 20 2017

bcr accepted D13433: Introduce daemonfd..

OK from manpages. Make sure to bump the .Dd when you commit.

Dec 20 2017, 6:44 PM

Dec 19 2017

bcr accepted D13511: Drop NetBSD rcs tag.
Dec 19 2017, 8:23 AM

Dec 10 2017

bcr added a comment to D13433: Introduce daemonfd..

Typo fix.

Dec 10 2017, 9:31 PM

Dec 4 2017

bcr added a comment to D13369: Add hammer support for fstyp(8)..

At the top of fstyp.8, you need to bump the .Dd to the date of the commit, since this is a content change.

Dec 4 2017, 9:12 PM

Dec 1 2017

bcr added a comment to D13309: have numactl tell subprocesses that they are locked to a domain.

You need to bump the .Dd in the man page to the date of the commit, since this is a content change.

Dec 1 2017, 10:17 AM

Nov 30 2017

bcr added a comment to D13295: arm: add generic syscon driver.

Typo

Nov 30 2017, 9:47 AM

Nov 28 2017

bcr added a comment to D13271: Add a Flavors chapter..

I'd wait until the other two reviewers had time to review. I myself don't have anything else. Thanks for the work on this!

Nov 28 2017, 4:01 PM
bcr added a comment to D13271: Add a Flavors chapter..

Two suggestions...

Nov 28 2017, 8:50 AM

Nov 25 2017

bcr accepted D13239: Add support for ABORT action in ipfw.

OK from manpages, you just need to bump the .Dd to the date of the actual commit.

Nov 25 2017, 3:12 PM

Nov 24 2017

bcr accepted D13196: Update intro(6).

Approved, but you need to bump the .Dd at the top of the document to the date of your commit.

Nov 24 2017, 8:22 AM

Nov 21 2017

bcr added a comment to D13183: Kill all descendants of the reaper, even if they are descendants of a subordinate reaper..

Typo

Nov 21 2017, 3:07 PM

Nov 19 2017

bcr committed rD51205: Correct the site-name by using http:// in front of it so that clicks will.
Correct the site-name by using http:// in front of it so that clicks will
Nov 19 2017, 7:15 PM