Good catch! Thanks.

OK from manpages.

You need to bump the .Dd of the man page to the day of the commit, since these are content changes. Thank you for working on this.

*smash*

I think we're still good on the man page!

Excellent, I think this can go in now.
Thank you for working on it.

Only two small nits that I found.

When I read the title of the review, I thought it was some kind of medical advice for sysadmins or something. ;-)
Sorry, this does not help the review, just wanted to let you know.

OK from manpages. Bump the .Dd when you do the actual commit (once network has approved, too). Thanks for working on this!

OK from manpages. Thanks for working on this!

Typo fix in comment.

Hehe, no worries, we all have to from time to time. Approved!

Hmm, strange. Check out the FDP primer on man pages, section 13.3.3.:

Check it with textproc/igor, but I think these are the only things that need to be changed.

Great, thanks!

ping?

@dteske: Can you take a final look on the updated patch? Would be good to have this in the man page. Thank you!

Most, if not all of these have been fixed by now. So, I'm closing this review.
Thank you for submitting these changes, anyway. Keep it up!

Approved for commit. Thank you for taking the time to write the man page.

OK from manpages.

It's good, thanks for writing it.

A few language fixes, but nothing major.

Found a small whitespace nit in the man page. Also, you need to bump the .Dd to the date of the commit (when it is ready).

Good, thanks!

You need to bump the .Dd at the beginning since this is a content change.

OK from manpages, but don't forget to bump the .Dd once you commit it since this is a content change.

Good catch. Can you commit this yourself or should I do it (with proper credits, of course)?

I agree with the needed rewrites, but for this specific change, it is enough. Approved!

Two comments...

Missing word?

Sorry to keep you waiting, @oshogbo.Looks good to me. Make sure to bump the .Dd to the date when you commit it.
Thanks!

I found a typo...

I have no time this weekend. I'd appreciate it if someone else could take this on.

I found a superfluous space (in addition to what @adridg has found.
Try checking it with textproc/igor, there might be additional output/suggestions.

Looks good now. OK from the manpages part of the module.

OK, the man page looks better now.
You should also add an AUTHORS, HISTORY, and maybe SEE ALSO section at the bottom. See the examples here:
https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/manpages-sample-structures.html

A few comments on the man page. You can use textproc/igor to check the man page for various common errors.
Thank you very much for working on this kernel module!

Looks OK to me, thanks for working on that. Who's going to commit those?

Two comments.

Argh, I missed that. Good that we both can count on @brueffer. ;-)

Thanks for your continued work on documenting capsicum functionality, @oshogbo!

Two typos, but the rest looks good.

Approved!

Just a small thing, the rest looks good to me.

Thanks for writing yet another man page, @oshogbo. Approved!

Two suggestions.

Approved, thanks for working on it!

OK from manpages.

Small man page nit.

I found one more typo.

One small nit.

Just one more fix to the indentation level...

You can check with textproc/igor. I believe it should check for overlong lines in man pages, too.

The indentation seems a bit off, so I refer you to Dr. igor. ;-)

A few more suggestions.

Don't forget to bump the .Dd for this content change. Thanks!

A few comments. Don't be discouraged, you're on the right track.
One more thing though: next time when you create the diff, do it from the top level of your doc directory. That will include the full path to the file in the diff/review header and not just book.xml. We have many book.xml files, so having the path in there helps determining what file the patch is for.

More info on proper link indentation. You're getting there...

A few suggestions for improvement.

Looks good to me.

New suggestion on how to word it better, based on your explanation, @oshogbo.
I found something else while there, but it's easy to fix. ;-)

A few suggestions and corrections.

Minor wording fixes.

OK from manpages.

Haha, yeah. But only because you have a certain Goat looking over your shoulder when writing it. :-)

A few suggestions and corrections. Thanks for writing the man page!

A small sentence rephrasing proposal.

One small correction for the man page.

Small corrections.

Typo fix.

Approved from manpages. Thanks for doing these changes.

OK from manpages.

A few corrections.

Ok from manpages. Thanks for working on it.

Small typo.

A small man page fix.

OK from manpages. Make sure to bump the .Dd when you commit.

Typo fix.

At the top of fstyp.8, you need to bump the .Dd to the date of the commit, since this is a content change.

You need to bump the .Dd in the man page to the date of the commit, since this is a content change.

Typo

I'd wait until the other two reviewers had time to review. I myself don't have anything else. Thanks for the work on this!

Two suggestions...

OK from manpages, you just need to bump the .Dd to the date of the actual commit.

Approved, but you need to bump the .Dd at the top of the document to the date of your commit.

Typo