Page MenuHomeFreeBSD

bcr (Benedict Reuschling)
User

Projects

User Details

User Since
May 18 2014, 4:40 AM (376 w, 3 d)

Recent Activity

Yesterday

bcr accepted D31392: arp: add -D flag to display cache statistics.

OK from manpages.

Tue, Aug 3, 9:27 AM

Thu, Jul 22

bcr accepted D31263: bpf: Add an ioctl to set the VLAN Priority on packets sent by bpf.

OK from manpages.

Thu, Jul 22, 6:49 AM

Sun, Jul 11

bcr accepted D31144: libcasper(3): Correct some warnings found by mandoc.

Approved!

Sun, Jul 11, 1:13 PM
bcr accepted D31145: nfsd: Fix some issues found by mandoc.

Separate issue found about the use of you.
The actual change looks fine to me. Thanks!

Sun, Jul 11, 1:13 PM
bcr accepted D31143: pmc(3): mandoc clean ups.

Wow, good work. Nothing to complain about.

Sun, Jul 11, 12:09 PM

Fri, Jul 9

bcr accepted D31117: pf.conf.5: Document new 'match' keyword.

OK from manpages.

Fri, Jul 9, 2:47 PM
bcr added a comment to D11887: loader: update autoboot description and move to loader.conf.5.

Minor question about which keys are valid to press.

Fri, Jul 9, 7:23 AM
bcr added a comment to D11887: loader: update autoboot description and move to loader.conf.5.

@imp: No more work done since then. If you want to take over, I'd appreciate it.
You can keep me in the list of reviewers for any textual changes you're making. Thanks!

Fri, Jul 9, 5:46 AM

Jul 2 2021

bcr accepted D30984: man(1): Add full search (-K) flag.

OK from manpages. Looks like a nice feature.

Jul 2 2021, 6:49 AM

Jun 24 2021

bcr accepted D30881: dumpfs(8): add option to only print superblock information.

OK from manpages, too. Thanks for addition this feature.

Jun 24 2021, 7:33 AM

Jun 17 2021

bcr accepted D30794: committers-guide: Strongly suggest careful review of all pull requests.

Looks good to me.

Jun 17 2021, 9:47 AM
bcr accepted D30791: pf: fallback if $pf_rules fails to load.

Manpage looks good.

Jun 17 2021, 7:17 AM

Jun 16 2021

bcr added a comment to D30789: style(9): Add advice about $FreeBSD$.

Minor nit, thanks for the update.

Jun 16 2021, 4:39 PM

Jun 14 2021

bcr accepted D30751: linux(4): Get rid of Linuxulator's kernel build options..

OK for the manpage part of the change. You need to bump the .Dd for this content change when you commit.

Jun 14 2021, 6:59 AM

Jun 11 2021

bcr added a comment to D30735: articles: Add language server in the FreeBSD src tree guide.

Cool, I like this addition of language servers. I added some language improvements.

Jun 11 2021, 8:16 PM
bcr accepted D30737: Remove svnlite..

OK from manpages as well.

Jun 11 2021, 8:06 PM
bcr accepted D30738: src.conf.5: Regen for svnlite removal..

Go for it! Thanks.

Jun 11 2021, 8:05 PM
bcr accepted D30736: Remove 'make update'..

OK from manpages.

Jun 11 2021, 8:05 PM

Jun 9 2021

bcr added a comment to D30388: Add freebsd-tips fortune about sysctl kern.tty_info_kstacks.

Cool, I like this.

Jun 9 2021, 1:10 PM

Jun 7 2021

bcr accepted D30668: Intel I225 Driver.

Manpage looks good. Thanks for yet another driver!

Jun 7 2021, 10:21 AM

Jun 1 2021

bcr accepted D30149: Example of basic OSS audio application.

OK from manpages,

Jun 1 2021, 12:35 PM

May 28 2021

bcr accepted D30499: Call taskqueue sooner, adjust some DELAY(), add inversion heuristic.

OK for the manpage part of the change.

May 28 2021, 7:05 AM
bcr added a comment to D30499: Call taskqueue sooner, adjust some DELAY(), add inversion heuristic.

Minor nit in the man page.

May 28 2021, 6:25 AM

May 27 2021

bcr accepted D30491: Add June 2021 FreeBSD Developer Summit event.

Good to go, thanks!

May 27 2021, 9:33 AM
bcr accepted D30480: kevent: Prohibit negative change and event list lengths.

OK from manpages.

May 27 2021, 6:33 AM

May 25 2021

bcr accepted D30445: crypto: Add crypto_cursor_segment() to fetch both base and length..

Ok from manpages.

May 25 2021, 7:31 AM

May 24 2021

bcr added a comment to D30422: porters-handbook: Fix the Git process in Chapter 11.1.

A textual suggestion, the rest looks fine.

May 24 2021, 7:49 PM

May 18 2021

bcr accepted D30324: Netmap: fix documentation for NR_REG_NIC_SW mode.

Manpage looking good, pending .Dd bump once approved.

May 18 2021, 6:20 AM

May 17 2021

bcr accepted D30309: md5: Create md5sum, etc compatible programs.

Manpages is also fine with the change. Thanks!

May 17 2021, 1:36 PM

May 15 2021

bcr accepted D27668: kerberos(8): Replace dead link to FAQ.

OK from manpages. Thanks for the update!

May 15 2021, 6:52 PM
bcr added a comment to D27668: kerberos(8): Replace dead link to FAQ.
In D27668#680170, @ygy wrote:
In D27668#680060, @bcr wrote:

I get the following exception from Phabricator upon loading this review:
Found unknown intradiff source line, expected a line beginning with "+", "-", or " " (space): \ No newline at end of file

@bcr Interesting... It is fine on my end, no errors. Where did you see this message?

May 15 2021, 6:52 PM
bcr accepted D30275: libalias: Remove unused function LibAliasCheckNewLink.

OK from manpages.

May 15 2021, 6:50 PM
bcr added a comment to D27668: kerberos(8): Replace dead link to FAQ.

I get the following exception from Phabricator upon loading this review:
Found unknown intradiff source line, expected a line beginning with "+", "-", or " " (space): \ No newline at end of file

May 15 2021, 9:37 AM
bcr added a comment to D30272: ldconfig(8): update manpage to reality.

A few minor nits, the rest looks fine.

May 15 2021, 9:35 AM · manpages
bcr accepted D30261: build(7): use a more relevant example for PORTS_MODULES.

Looks good!

May 15 2021, 8:49 AM

May 13 2021

bcr accepted D30240: Reference CC modules consistently.

OK from me as well. Thanks!

May 13 2021, 9:42 AM

May 12 2021

bcr accepted D29901: ctlstat: add prometheus output.

Manpage looks good now.

May 12 2021, 2:07 PM
bcr accepted D30218: VFS_QUOTACTL(9): allow implementation to indicate busy state changes.

OK from manpages.

May 12 2021, 2:05 PM
bcr accepted D30215: find(1): Document the -f option.

Looks good to me. Thanks for the update.

May 12 2021, 7:42 AM
bcr added a comment to D30145: Updating Virtualization chapter.

Only found these now. Looking good otherwise.

May 12 2021, 7:41 AM · docs

May 9 2021

bcr added a comment to D29754: Augment systat(1) -swap to display large swap space processes.

A few suggestions for wording improvements in the man page.

May 9 2021, 7:07 PM

May 8 2021

bcr added a reviewer for D30176: Freebsd doc cross-platform build: carlavilla.

Adding Sergio, as I think this might interest him.
Having a way to build our docs on other platforms is nice and might bring in some new contributions.

May 8 2021, 7:02 PM · docs

May 6 2021

bcr accepted D30136: crypto: Add a new type of crypto buffer for a single mbuf..

OK for the man page update.

May 6 2021, 7:28 AM

May 4 2021

bcr added a comment to D30027: Improve sndstat man page.

Other than this small nit, I'm fine with the change.

May 4 2021, 6:52 PM
bcr accepted D30107: src.conf.5: Regen..

OK for the manpage change.

May 4 2021, 6:50 PM
bcr added a comment to D30092: pf: Support killing 'matching' states.

Right, I thought it was the other way around, but this makes more sense. :-)

May 4 2021, 12:12 PM

May 3 2021

bcr accepted D30092: pf: Support killing 'matching' states.

Manpage looks good now.
I guess upstream will incorporate it, too.

May 3 2021, 8:00 PM
bcr added a comment to D30092: pf: Support killing 'matching' states.

Minor man page nit.

May 3 2021, 3:10 PM
bcr added a comment to D25338: Do not recommend sleeping when using vipw(8) non-interactively.

Is this one still active?

May 3 2021, 7:32 AM
bcr added a comment to D25358: Sync vis(1) with recent NetBSD sources.

Has this change been committed yet?

May 3 2021, 7:31 AM
bcr added a comment to D26305: search does not work with multiple sites listed.

Is it OK to abandon this revision now that we have a new website structure or do you think the new site needs this as well?

May 3 2021, 7:29 AM
bcr accepted D26542: [ggated/ggatec] Simplify Gate Handshake..

OK from manpages.

May 3 2021, 7:28 AM
bcr accepted D29473: Append Keyboard Layout specified option for using VNC. Part two: Append bhyve -K option for specified keyboard layout with layout setting files every languages. Since the cmd option '-k' was used in the meantime I changed it to '-K'.

OK for the man page part of the change.

May 3 2021, 7:24 AM
bcr accepted D29493: sh: implement persistent history storage.

OK from manpages.

May 3 2021, 7:23 AM

Apr 30 2021

bcr added a comment to D30058: pf: Allow states to by killed per 'gateway'.

Minor man page fixes.

Apr 30 2021, 6:52 PM
bcr accepted D30056: pf: Remove DIOCCLRSTATES and DIOCKILLSTATES.

OK for the man page part of the change.

Apr 30 2021, 6:50 PM
bcr accepted D30050: Adds uuid validation to bhyve(8) arg parsing.

OK from manpages.

Apr 30 2021, 6:48 PM
bcr accepted D30044: ports(7): Add install-missing-packages to target list.

Looks good, thanks for the addition. Can you bump the .Dd when you commit as well for this content change.
Thanks!

Apr 30 2021, 11:28 AM
bcr accepted D26538: Add SIOCGIFDATA.

OK from manpages.

Apr 30 2021, 10:37 AM
bcr accepted D29937: newbus: Move from bus_child_{pnpinfo,location}_src to bus_child_{pnpinfo,location} with sbuf.

The manpages look good to me.

Apr 30 2021, 10:35 AM

Apr 27 2021

bcr accepted D29996: Add committer entries for myself, OH.
Apr 27 2021, 7:46 AM
bcr added a comment to D30004: Add sections to the handbook on cpu frequency control.

The text looks good to me as a first version. I think the change to the relnotes is unrelated?

Apr 27 2021, 7:38 AM

Apr 23 2021

bcr accepted D28609: textproc/docproj: Add required dependencies of the new documentation tree.

Looks good to me, with my doceng hat on (but ENOPORTSCOMMITTER).

Apr 23 2021, 9:24 AM

Apr 20 2021

bcr accepted D29846: etcupdate: Add a revert mode to restore one or more stock files..

OK from manpages.

Apr 20 2021, 6:31 AM

Apr 18 2021

bcr added a comment to D28441: c(7): update and improve.

Ah, no. I thought the submitter could do that/had a commit bit.
You can do it if you want, @0mp. Thanks!

Apr 18 2021, 9:35 AM

Apr 17 2021

bcr added a comment to D29788: kern: ether_gen_addr: randomize on default hostuuid, too.
In D29788#668512, @bz wrote:

Don't forget to bump .Dd on the man page when committing.

Apr 17 2021, 9:29 AM

Apr 16 2021

bcr accepted D29787: man: document ether_gen_addr(9).

Also fine by manpages.

Apr 16 2021, 6:02 AM
bcr accepted D29786: books/fdp-primer: Fix pdf build command.

Good catch, approved!

Apr 16 2021, 6:00 AM

Apr 15 2021

bcr accepted D29777: Add vlan issue to the 13.0 errata doc 'late breaking' section.

OK, great! Good to know this EN, btw.

Apr 15 2021, 5:04 PM
bcr added a comment to D29777: Add vlan issue to the 13.0 errata doc 'late breaking' section.

Minor nit.

Apr 15 2021, 3:51 PM
bcr accepted D29770: sndstat: nvlist schema and API definition changes.

Great, manpage part of the change is fine now.

Apr 15 2021, 9:30 AM
bcr added a comment to D29770: sndstat: nvlist schema and API definition changes.

Found 3 typos, one of which was not yours. :-)

Apr 15 2021, 9:23 AM
bcr added a comment to D25367: Add Nginx section to the Network Servers chapter in addition to Apache..

Any updates?

Apr 15 2021, 7:13 AM
bcr accepted D27228: strlcpy/strlcat: Remove references to snprintf.

OK from manpages.

Apr 15 2021, 7:11 AM
bcr accepted D27803: Add a code example to cpuset(2) showing how to modify the affinity of the current process. Improve cross referencing..

OK from manpages.

Apr 15 2021, 7:10 AM
bcr accepted D28199: bhyve(8): decouple unix domain socket from save/restore code.

OK for the manpage bits.

Apr 15 2021, 7:08 AM

Apr 13 2021

bcr closed D27845: Fix broken link for Stormshield..
Apr 13 2021, 3:27 PM
bcr committed R9:6b0ae8b1ffb0: Fix broken link to the Stormshield entry. (authored by bcr).
Fix broken link to the Stormshield entry.
Apr 13 2021, 3:27 PM
bcr added a comment to D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..

Some comments on the man pages.

Apr 13 2021, 9:23 AM
bcr accepted D28441: c(7): update and improve.

Good to go. Thank you!

Apr 13 2021, 9:11 AM
bcr added a comment to D28450: lualoader: add support for .lua configuration files.

A question on the man page. I did not find anything else.

Apr 13 2021, 9:11 AM
bcr accepted D28516: netgraph/ng_bridge: learn MACs via control message.

OK from manpages.

Apr 13 2021, 9:08 AM
bcr added a comment to D29695: systat: Implemented per-process swap display on -swap.

A few small corrections to the man page.

Apr 13 2021, 9:03 AM
bcr accepted D29738: bhyve: Be explicit that setting config.dump will not start a VM..

OK from manpages. Sprinkle some .Dd on it before committing for this content change. Thanks!

Apr 13 2021, 7:21 AM

Apr 12 2021

bcr accepted D29722: Add a way to map arm64 non-posted device memory.

OK from manpages.

Apr 12 2021, 11:20 AM

Apr 8 2021

bcr accepted D29637: vnode_pager_setsize.9: Some clarifications on the manpage.

OK for this newer version of the manpage.

Apr 8 2021, 8:00 PM
bcr added a comment to D29436: Prune consultants list.

I think we can take the removals from Allan as a general spring cleaning measure. Companies that were falsely removed and wish to remain on that list can open a PR to be re-added again.
Mz guess is that some will not notice (or care) and for the ones that do, it's proof that they do use FreeBSD in some degree.

Apr 8 2021, 2:06 PM
bcr accepted D29637: vnode_pager_setsize.9: Some clarifications on the manpage.

Ah, even better now. Good to go!

Apr 8 2021, 7:56 AM
bcr accepted D29637: vnode_pager_setsize.9: Some clarifications on the manpage.

OK from manpages. For this content change, you need to bump the .Dd to the date of the commit.
Thanks!

Apr 8 2021, 7:41 AM

Apr 7 2021

bcr accepted D29607: byhve: add option to specify IP address for gdb.

OK from manpages.

Apr 7 2021, 7:51 AM
bcr accepted D29619: efivar: Add --quiet to not report errors.

OK from manpages.

Apr 7 2021, 7:50 AM

Apr 6 2021

bcr accepted D29408: Document vnode_pager_setsize(9).

Nice, thanks for the quick fixes.

Apr 6 2021, 12:33 PM
bcr added a comment to D28622: handbook/config: Add section on configuring IPv6.

Avoid the use of you, with some suggestions on how to fix it.
I generally like the update, though. Thanks for writing it.

Apr 6 2021, 12:18 PM
bcr accepted D29185: Pass the syscall number to capsicum permission-denied signals.

OK from manpages.

Apr 6 2021, 12:03 PM
bcr added a comment to D29408: Document vnode_pager_setsize(9).

OK, I only have one textual suggestion. Did you check the man page with "mandoc -Tlint" and textproc/igor?

Apr 6 2021, 12:00 PM
bcr added a comment to D29473: Append Keyboard Layout specified option for using VNC. Part two: Append bhyve -K option for specified keyboard layout with layout setting files every languages. Since the cmd option '-k' was used in the meantime I changed it to '-K'.

I only checked the doc portion of the change. I generally like this feature and look forward to using it myself.
A few suggestions on the text. Did you check the manpage with "mandoc -Tlint" and textproc/igor? They usually give some good recommendations.

Apr 6 2021, 11:57 AM
bcr accepted D29569: Add helper scripts for translations.

Looks good to me.
If noone else from doceng raises any objections, this can go in as a first version.

Apr 6 2021, 11:50 AM
bcr accepted D29573: books/fdp-primer: Fix outdated information.

Looks good to me as well. If no one else from doceng has any objections, this can be committed.
Thanks for the work!

Apr 6 2021, 11:47 AM
bcr added a comment to D28441: c(7): update and improve.

Thanks for these updates. Two minor fixes regarding the use of "you", the rest seems fine.

Apr 6 2021, 9:45 AM

Dec 28 2020

bcr committed R9:a496aac425a0: Fix two remaining igor warnings by making content appear right after <para> (authored by bcr).
Fix two remaining igor warnings by making content appear right after <para>
Dec 28 2020, 6:46 PM