- User Since
- May 18 2014, 4:40 AM (290 w, 1 d)
Thanks for fixing it. OK from manpages.
Can you commit it yourself or should I do that (giving proper credit, of course)?
Looks good, approved!
Bump the .Dd for this content change when you commit it.
Looks good to me.
I think the indentation is still wrong. If you compare https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/writing-style-guide.html, the indentation in the <para> tags starts right below the first "a" of "para". If there is an open link (or whatever other tag that does not fit on one line), you indent by two more until that tag closes again.
In this case, you just un-indent your change by two to align below the first "a" of <para> (unless it is a link) and then you should be good.
Sat, Dec 7
Whitespace fix recommendation.
Oh wow, thanks for the extensive testing. Change approved!
Good catches, approved!
Approved for commit! Thanks for working on the PR.
Good to go! Thanks for making that change.
Thanks for this change. Is there a sentence stop missing in the man page change?
Fri, Dec 6
Excellent, approved for commit!
Tue, Dec 3
The <description> tag needs to be right after the sentence stop. And if that should overflow the line, then break it into the next line:
Mon, Dec 2
I found two instances of superfluous spaces. I think once they are fixed, we can go ahead and commit the man page.
Sat, Nov 30
Fri, Nov 29
A minor change is needed, but then you can commit it and close the PR.
A few instances where there are extra spaces, but those are easy to fix.
OK, that looks good now. Thank you!
Another round of edits needed, but we're getting there. Thanks!
Wed, Nov 27
Sounds like a cool feature to have. Thanks for working on it.
The man page looks good!
Tue, Nov 26
Thank you for writing the man page!
I've found a typo. Can you run textproc/igor and "mandoc -Tlint" over the man page and see if they turn up any warnings?
Mon, Nov 25
Sat, Nov 23
Thank you for rearranging those. Maybe textproc/igor can help you a bit with the proper alignment or check the FDP primer for examples.
Let me know if you need help.
You can commit this one, too.
You can commit this one. Thanks!
Good to go. Thanks!
Ah, can you un-indent the lines below the description tag to align like the other entries? Thanks!
Fri, Nov 22
Thu, Nov 21
Wed, Nov 20
Good to (literally) go!
Tue, Nov 19
I'm OK with the new text.
Mon, Nov 18
OK, thanks for fixing the indentation. Ready to go!
Sun, Nov 17
Thu, Nov 14
Thanks for fixing. A package message seems good to me.
Other than that, users are required to look into that file or run "pkg updating".
Thinking about this a bit more, we could merge the "Press" and "News" columns on freebsd.org into one. That would give us free space for ports announcements from that file. Just a thought...
Wed, Nov 13
Tue, Nov 12
OK, go ahead. We'll figure out a more elegant solution separately.
Mon, Nov 11
Minor correction to the man page and (this is new to me) the code.
Nov 9 2019
Also accepted, thanks for the cleanup work, researching those entries!
Ah, good work. It's appreciated. We do a bad job of cleaning these up (and companies usually don't tell us when they go out of business).
A periodic link checker might help with that, but for now, I agree that removing these invalid entries is better. Approved!
Adding Glen for clarification: Does it make sense to add the 13-CURRENT entity in the file or will that change other references that are using it already?
I think using 13-CURRENT is the right thing to do here and as @mat pointed out, it is easier to just reference it rather than changing it every time the version of CURRENT changes.
Nov 7 2019
Bump the .Dd when you commit. Thanks!
Nov 6 2019
OK, if we don't have an entity for 13 in there at the moment, I guess we have to either add it there or use your original proposed patch.
Looks good, approved!
Grammar suggestion for the man page.
I'm fine with the latest changes to the man page.
Nov 5 2019
I think we have a variable for the current release: &rel.current;
Can you try that and see if the has the desired effect? That way, we don't have to touch that fine each time when there is a new CURRENT release branch.
I'd start the text right after the opening <description> tags and the closing tag right after the sentence stop after "Freenode".
Nov 4 2019
Looks god to me, go ahead with the commit.
Nov 3 2019
OK from manpages. Don't forget to bump the .Dd of the man page when you commit this content change.
Looks good, you can commit that with my approval!
Approved, go ahead!
Nov 2 2019
Approved. Can you commit that change yourself or should I?
Thanks for picking this up.
Oct 31 2019
Looks good. You can commit it with my approval!
Oct 26 2019
Oct 25 2019
Oct 18 2019
OK from manpages. Thanks for working on this.
Oct 17 2019
Thank you for the man page.
Oct 11 2019
Sorry to keep you waiting. I'll commit this soon. Thank you!
Oct 10 2019
The man pages look fine to me, thanks for writing them.
Oct 9 2019
Looks good, although I'd add a note after it that some shells (like zsh) need to invalidate the ^ using \^.
Oct 7 2019
OK, thanks for the man page fixes. It can be committed with the source change now.
Oct 6 2019
Oct 2 2019
Looks good to me, thanks. Do you want to commit that yourself or should a docs person do it (with the proper attributions, of course)?
Sep 30 2019
Gut, kann committed werden.
Sep 29 2019
Sep 26 2019
Nur zwei Fehler gefunden, gut! :)
OK from manpages.
Thanks for the update to the handbook. I've found a couple of things that are fairly easy to correct.
Sep 25 2019
Sep 23 2019
Sep 21 2019
OK from manpages. Thank you!