Ok from manpages. Good to modernize this a bit.

OK from manpages as well.

I'm good with that change.

Sure, I'm fine with a follow-up commit to fix those.

Minor writing style nit.

Cool, so approved then.

Just a question about whitespace, the rest looks good.

Can you provide the image file as well?
It's a good starting text. A sweep through it for the use of "you" would be good.

Good to go.

Good to go, thanks for your work on the report!

I think it is OK, since vim is popular enough, even though it is not in the base system. If we can't find an example that uses a base system utility, that is.

Reads well, thanks for this addition!

I think we won't progress here if we don't get someone else to review the src parts.
@cperciva: Can you take a look at it?

Nur ein paar Kleinigkeiten, der Rest ist in Ordnung. Danke!

OK from manpages.

OK from manpages.

Looks good. Thanks for taking care of it.

Man page is fine now, thanks!

OK from manpages.

Minor line break needed in the man page.

Thanks for implementing that feature.
There is a minor mandoc issue, easy to fix. Running "mandoc -Tlint" and textproc/igor will usually tell you about them.

It's fine for me to commit it with at .Dd bump.
Thanks for the reminder.

Good to go!

OK from manpages. Remember to bump the .Dd when you commit this content change.

OK from manpages.

Yes, I would remove it. We're using mandoc and people can install as many things from ports as they like, but we can't reflect that in our man pages.

Approved!

Looks good, sorry for the wait.

That's a good list of examples. Approved!

Looks good to me, thanks for adding these.

Useful to know about these, so approved. ;-)

Great, I like these. Approved!

Looks good, thanks for these examples.

Man page changes look good to me.

Minor man page nit.

Good to go now! Thanks.

OK for the man page part of the patch.

Two minor corrections...

Nice, thanks for the changes.

Minor thing remaining, the rest looks good.

Looks good to me.

Ah, that's a good change. Approved1

Looks good, thanks for adding these.

Minor typo only. Did you run textproc/igor and "mandoc -Tlint" over them? I don't think they'll give any extra warning besides .Dd, but it does not hurt to check.
Thanks for writing these man pages.

Manpage is good now. Thanks.

Also good from manpages (again).

Approved, thanks!

Good to go!

A fine addition to the chapter, well structured.
I've added a few comments and a suggestion inline.

Looks good to me from the man page side of things.

Great, thanks for the followup fixes.

Minor nit, the rest looks good.

In D26184#585678, @asomers wrote:

@bcr unfortunately, mandoc has much to complain about with this man page. But none of its complaints were introduced by my change. Would you approve this PR as is, and then I can submit a separate one to fix the issues?

OK from manpages.

Ready to land.

Small correction. I like how thorough you've covered all the options.
Thanks for that!

Also fine from manpages.

Grammo

Thank you for your constant supply of useful EXAMPLES.

A few suggestions...

Looks good, thanks for the update.

OK, thanks for the manpage checks. Good to go from our side of things.

Can you check the man page with textproc/igor and "mandoc -Tlint" for any warnings?

In D26074#581749, @zec wrote:

rgrimes: me being essentially a manpage rookie as well, unfortunately I can't provide an advice to Denis on how proceed from here. None of the lines fill entirely or extend past 80 columns, and all sentences are terminated by line breaks. What else should we improve re. formatting? As non-native English speakers, we can also try to improve text composition and flow a bit, but I guess this is not what you had in mind?

Thanks, it looks good to me now.

Typo and grammar fixes. In general, I like the examples.

Looks good, thanks for adding these.

Can you run textproc/igor and "mandoc -Tlint" on the man page changes to see if they spit out any warnings?

OK from manpages.

Approved, thanks for these additions.

Some minor style comments...

Good to go. Thanks for checking and updating the man page.

Looks good to me from the man page side of things. I can't say much about the actual change though.

OK, fine with me (a bit of a load on that machine, right?). ;-)

OK from manpages (with .Dd bump needed).

OK from manpages. Don't forget to bump the .Dd of the man page for this content change when you commit.
Thanks!

Can we move ahead with this change or should the FAQ be fixed first?

All good, thanks for taking care of it.

Looks good to me, approved!

Approved and will be committed in a short while... Thank you!

Looks good, I'll commit this. Thank you!

Any updates on the src part of the change?

The man page looks good. Can you check it with "mandoc -Tlint" and textproc/igor and see if they give you any warnings?
Thanks for writing that man page.

Minor textual suggestion for the man page (outside of your change).

I approve as well.

Looks good to me. A fine addition to have in the man page. Thanks!

The addition sounds to me like that only HEX files have that comment (and hence is set in that case).
If that is not the case, I think writing: "... for BDF and HEX files ..." would make it clear that it applies to both.