Page MenuHomeFreeBSD

bcr (Benedict Reuschling)
User

Projects

User Details

User Since
May 18 2014, 4:40 AM (418 w, 1 d)

Recent Activity

Apr 19 2022

bcr added a comment to D32436: Add section for Wayland in the x11 chapter.
In D32436#791757, @bcr wrote:

Any update on this?

Are you and I waiting for each other to do something, or are you asking someone else?

Apr 19 2022, 1:37 PM · desktop

Apr 15 2022

bcr added a comment to D32436: Add section for Wayland in the x11 chapter.

Any update on this? Would love to show the world that FreeBSD supports Wayland to the degree that is described here.
We can then add stuff later once we already have a basic handbook chapter.

Apr 15 2022, 6:29 PM · desktop

Feb 13 2022

bcr added inline comments to D34259: Report I/O stats from the CAM_IOSCHED_DYNAMIC extension.
Feb 13 2022, 12:28 PM

Feb 1 2022

bcr accepted D23230: Implement ECN++ (draft-generalized-ecn).

OK for the manpages part of the change.

Feb 1 2022, 2:55 PM

Jan 31 2022

bcr added a comment to D23230: Implement ECN++ (draft-generalized-ecn).

Typo in man page.

Jan 31 2022, 2:36 PM

Jan 29 2022

bcr committed R9:f267164260fc: Remove trailing whitespaces from lines in various chapters. (authored by bcr).
Remove trailing whitespaces from lines in various chapters.
Jan 29 2022, 2:27 PM
bcr committed R9:1f9b2d813030: Fix some typos in the Wine chapter and remove trailing whitespaces. (authored by bcr).
Fix some typos in the Wine chapter and remove trailing whitespaces.
Jan 29 2022, 2:22 PM
bcr committed R9:1ae23eb218c2: Spell 'availability' correctly. (authored by bcr).
Spell 'availability' correctly.
Jan 29 2022, 2:11 PM
bcr committed R9:4d19b8b2fa26: Typo fix: Adressses -> Addresses (authored by bcr).
Typo fix: Adressses -> Addresses
Jan 29 2022, 1:32 PM
bcr committed R9:1bf534723265: Remove extra whitespace characters from the end of a few lines. (authored by bcr).
Remove extra whitespace characters from the end of a few lines.
Jan 29 2022, 1:22 PM
bcr committed R9:3945abc7cee2: Divide up two words that should be separate. (authored by bcr).
Divide up two words that should be separate.
Jan 29 2022, 1:19 PM
bcr committed R9:63271dc2b94c: Remove trailing whitespace from the end of some lines. (authored by bcr).
Remove trailing whitespace from the end of some lines.
Jan 29 2022, 12:43 PM
bcr committed R9:64002069dd51: Typo fix: configuraton -> configuration (authored by bcr).
Typo fix: configuraton -> configuration
Jan 29 2022, 12:42 PM

Jan 17 2022

bcr accepted D33916: handbook: Fix local documentation instructions.

Looks good, thanks for the update.

Jan 17 2022, 10:38 AM

Dec 9 2021

bcr added a comment to D33360: Add genet.4 for RPi 4 Ethernet.

Same here, can't find any grammar or other nits.

Dec 9 2021, 4:48 PM

Dec 5 2021

bcr added a comment to D33275: Add a manual page for boottrace.

Small suggestion, I know that it is still a draft. But good to eventually have such a man page!

Dec 5 2021, 5:48 PM

Dec 2 2021

bcr accepted D33233: sync.8: Document that the "sync dance" is not a thing.

Sounds good to have in there as these old misconceptions are still around. Approved from my side.

Dec 2 2021, 12:15 PM

Nov 14 2021

bcr committed R9:c4708d675088: Fix build by reapplying 05b8bc3182dc4cfcf0a8a0964b4303903a4abf56 (authored by bcr).
Fix build by reapplying 05b8bc3182dc4cfcf0a8a0964b4303903a4abf56
Nov 14 2021, 3:01 PM
bcr closed D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.
Nov 14 2021, 2:06 PM · ZFS
bcr committed R9:71f8b70ba8bc: Convert ZFS chapter to active voice and remove weasel/unnecessary words (authored by bcr).
Convert ZFS chapter to active voice and remove weasel/unnecessary words
Nov 14 2021, 2:06 PM
bcr added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Alright, I incorporated these last feedback items. I'm going to commit this shortly.
Thanks to all reviewers, your feedback and suggestions helped a lot in improving the text!

Nov 14 2021, 1:25 PM · ZFS

Nov 4 2021

bcr accepted D32830: Move articles/contributors/contrib-* to the shared directory.

Looks like a reasonable change to me, having these shared over more languages.

Nov 4 2021, 8:34 AM

Nov 3 2021

bcr accepted D32825: scsi.4: Document serial numbers.

Looks good to me.

Nov 3 2021, 5:22 PM
bcr accepted D32824: scsi.4: Remove untrue paragraph.

Checked up and good to go!

Nov 3 2021, 5:21 PM

Oct 30 2021

bcr accepted D32750: pf: Introduce ridentifier.

Man page part of the change looks good. It needs a .Dd date bump when the commit happens.
Thanks for keeping up the good work on pf!

Oct 30 2021, 10:06 AM

Oct 29 2021

bcr updated the diff for D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Change an instance of "alone" to "only" in the L2ARC description to not confuse people about adding multiple devices there.

Oct 29 2021, 6:58 PM · ZFS
bcr added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Reply with confirmation about the L2ARC vdevs question.

Oct 29 2021, 6:54 PM · ZFS
bcr added a comment to D32552: porters-handbook: Document FLAVORS_SUB.

Two minor fixes.

Oct 29 2021, 8:13 AM

Oct 28 2021

bcr added a comment to D32713: mountd: deprecate exports to a network without mask.

Minor comma nit, the rest looks good.

Oct 28 2021, 6:24 PM
bcr accepted D32711: man pages: deprecate Internet Class A/B/C.

Looks good. Make sure to bump the .Dd for these content changes.

Oct 28 2021, 6:23 PM

Oct 27 2021

bcr added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Update with some of my own replies.

Oct 27 2021, 7:31 PM · ZFS
bcr updated the diff for D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Yet another update addressing some of @pauamma_gundo.com's comments.

Oct 27 2021, 7:30 PM · ZFS

Sep 25 2021

bcr accepted D32137: pf.conf: document syncookies.

Sounds better now, so the man page looks good to me now.
Thanks for implementing that feature!

Sep 25 2021, 7:02 PM
bcr added a comment to D32137: pf.conf: document syncookies.

I found two things worth "exploring".

Sep 25 2021, 2:09 PM

Sep 21 2021

bcr added a comment to D32035: Rewrite the vm_page_alloc manual page.

Just a minor nit, the rest looks good, doc-wise.

Sep 21 2021, 7:29 AM

Sep 16 2021

bcr accepted D31983: bhyve: Support setting the disk serial number for VirtIO block devices..

OK from manpages.

Sep 16 2021, 3:00 PM

Sep 6 2021

bcr accepted D31864: kqueue.2: Document the fact that EVFILT_READ can be used on kqueues.

OK from manpages.

Sep 6 2021, 5:32 PM

Sep 5 2021

bcr updated the diff for D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Update including the lastest suggestions to the lower last part of the chapter.

Sep 5 2021, 5:34 PM · ZFS
bcr added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Another big update, including both @ygy's and @pauamma_gundo.com's comments.
I should have kept the diff much smaller in retrospect, sorry about that. We're getting close to the final piece now, thanks to your efforts!
The line breaks were caused by my editor trying to be smarter than it should be.

Sep 5 2021, 5:33 PM · ZFS

Sep 3 2021

bcr updated the diff for D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

New version that includes suggestions by @pauamma_gundo.com

Sep 3 2021, 11:29 AM · ZFS
bcr added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Phew, a lot of changes, most of which I concur with and changed. Thanks!
Updated patch follows.

Sep 3 2021, 11:28 AM · ZFS

Aug 31 2021

bcr accepted D31751: pfctl: Document ethernet rule configuration.

OK from manpages.

Aug 31 2021, 3:30 PM
bcr added a comment to D31751: pfctl: Document ethernet rule configuration.

Minor typo, the rest looks good.

Aug 31 2021, 9:46 AM
bcr accepted D31750: pfctl: Document displaying Ethernet rules.

OK from manpages.

Aug 31 2021, 9:43 AM

Aug 30 2021

bcr added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

A few comments, mostly agreeing with the suggestion.

Aug 30 2021, 10:59 AM · ZFS
bcr updated the diff for D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Another fine set of changes, including most (if not all) suggestions by @pauamma_gundo.com

Aug 30 2021, 10:58 AM · ZFS
bcr added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.
In D31707#715576, @bcr wrote:

Maybe one more reason to use dataset more to avoid this ambiguity? ;-)

Calling them datasets introduces new ambiguities, because a dataset can both be a filesystem and a volume, and it's possible that it's definition will be expanded in future versions too.

Aug 30 2021, 9:32 AM · ZFS

Aug 29 2021

bcr updated the diff for D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Update diff to incorporate changes from @debdrup and @pauamma_gundo.com . Looking forward to the second half of changes. I know it's tedious and I should have kept it shorter. Will consider than for future changes like this on other chapters.

Aug 29 2021, 1:56 PM · ZFS
bcr added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Thanks for your suggestions, @debdrup and @pauamma_gundo.com . I incorporated a lot of them into the next set of changes.
I looked at our current docs for the word list on how to write "file system" versus "filesystem". It seems like it does not exist in the FDP primer anymore. It used to be there in the old one: https://www-legacy.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/writing-style-word-list.html . Maybe one more reason to use dataset more to avoid this ambiguity? ;-)

Aug 29 2021, 1:53 PM · ZFS

Aug 28 2021

bcr updated the diff for D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Updated diff incorporating suggestions by @ceri

Aug 28 2021, 7:43 PM · ZFS
bcr added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.
In D31707#715385, @ceri wrote:

Running out of battery so submitting what I have reviewed. Generally speaking I think the shorter text works against the intent of this being a guide, I'm afraid.

Aug 28 2021, 7:43 PM · ZFS
bcr updated the diff for D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

This one uses git diff --no-prefix -U1000

Aug 28 2021, 5:11 PM · ZFS
bcr requested review of D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.
Aug 28 2021, 3:21 PM · ZFS

Aug 11 2021

bcr accepted D31505: vfs: Rename ioflg to ioflag in vn_deallocate.

OK for the manpage part of the change.

Aug 11 2021, 8:53 AM

Aug 5 2021

bcr accepted D31421: Disable translation of press release items.

Yes, this makes sense. Approved!

Aug 5 2021, 9:23 AM

Aug 3 2021

bcr accepted D31392: arp: add -D flag to display cache statistics.

OK from manpages.

Aug 3 2021, 9:27 AM

Jul 22 2021

bcr accepted D31263: bpf: Add an ioctl to set the VLAN Priority on packets sent by bpf.

OK from manpages.

Jul 22 2021, 6:49 AM

Jul 11 2021

bcr accepted D31144: libcasper(3): Correct some warnings found by mandoc.

Approved!

Jul 11 2021, 1:13 PM
bcr accepted D31145: nfsd: Fix some issues found by mandoc.

Separate issue found about the use of you.
The actual change looks fine to me. Thanks!

Jul 11 2021, 1:13 PM
bcr accepted D31143: pmc(3): mandoc clean ups.

Wow, good work. Nothing to complain about.

Jul 11 2021, 12:09 PM

Jul 9 2021

bcr accepted D31117: pf.conf.5: Document new 'match' keyword.

OK from manpages.

Jul 9 2021, 2:47 PM
bcr added a comment to D11887: loader: update autoboot description and move to loader.conf.5.

Minor question about which keys are valid to press.

Jul 9 2021, 7:23 AM
bcr added a comment to D11887: loader: update autoboot description and move to loader.conf.5.

@imp: No more work done since then. If you want to take over, I'd appreciate it.
You can keep me in the list of reviewers for any textual changes you're making. Thanks!

Jul 9 2021, 5:46 AM

Jul 2 2021

bcr accepted D30984: man(1): Add full search (-K) flag.

OK from manpages. Looks like a nice feature.

Jul 2 2021, 6:49 AM

Jun 24 2021

bcr accepted D30881: dumpfs(8): add option to only print superblock information.

OK from manpages, too. Thanks for addition this feature.

Jun 24 2021, 7:33 AM

Jun 17 2021

bcr accepted D30794: committers-guide: Strongly suggest careful review of all pull requests.

Looks good to me.

Jun 17 2021, 9:47 AM
bcr accepted D30791: pf: fallback if $pf_rules fails to load.

Manpage looks good.

Jun 17 2021, 7:17 AM

Jun 16 2021

bcr added a comment to D30789: style(9): Add advice about $FreeBSD$.

Minor nit, thanks for the update.

Jun 16 2021, 4:39 PM

Jun 14 2021

bcr accepted D30751: linux(4): Get rid of Linuxulator's kernel build options..

OK for the manpage part of the change. You need to bump the .Dd for this content change when you commit.

Jun 14 2021, 6:59 AM

Jun 11 2021

bcr added a comment to D30735: articles: Add language server in the FreeBSD src tree guide.

Cool, I like this addition of language servers. I added some language improvements.

Jun 11 2021, 8:16 PM
bcr accepted D30737: Remove svnlite..

OK from manpages as well.

Jun 11 2021, 8:06 PM
bcr accepted D30738: src.conf.5: Regen for svnlite removal..

Go for it! Thanks.

Jun 11 2021, 8:05 PM
bcr accepted D30736: Remove 'make update'..

OK from manpages.

Jun 11 2021, 8:05 PM

Jun 9 2021

bcr added a comment to D30388: Add freebsd-tips fortune about sysctl kern.tty_info_kstacks.

Cool, I like this.

Jun 9 2021, 1:10 PM

Jun 7 2021

bcr accepted D30668: Intel I225 Driver.

Manpage looks good. Thanks for yet another driver!

Jun 7 2021, 10:21 AM

Jun 1 2021

bcr accepted D30149: Example of basic OSS audio application.

OK from manpages,

Jun 1 2021, 12:35 PM

May 28 2021

bcr accepted D30499: Call taskqueue sooner, adjust some DELAY(), add inversion heuristic.

OK for the manpage part of the change.

May 28 2021, 7:05 AM
bcr added a comment to D30499: Call taskqueue sooner, adjust some DELAY(), add inversion heuristic.

Minor nit in the man page.

May 28 2021, 6:25 AM

May 27 2021

bcr accepted D30491: Add June 2021 FreeBSD Developer Summit event.

Good to go, thanks!

May 27 2021, 9:33 AM
bcr accepted D30480: kevent: Prohibit negative change and event list lengths.

OK from manpages.

May 27 2021, 6:33 AM

May 25 2021

bcr accepted D30445: crypto: Add crypto_cursor_segment() to fetch both base and length..

Ok from manpages.

May 25 2021, 7:31 AM

May 24 2021

bcr added a comment to D30422: porters-handbook: Fix the Git process in Chapter 11.1.

A textual suggestion, the rest looks fine.

May 24 2021, 7:49 PM

May 18 2021

bcr accepted D30324: Netmap: fix documentation for NR_REG_NIC_SW mode.

Manpage looking good, pending .Dd bump once approved.

May 18 2021, 6:20 AM

May 17 2021

bcr accepted D30309: md5: Create md5sum, etc compatible programs.

Manpages is also fine with the change. Thanks!

May 17 2021, 1:36 PM

May 15 2021

bcr accepted D27668: kerberos(8): Replace dead link to FAQ.

OK from manpages. Thanks for the update!

May 15 2021, 6:52 PM
bcr added a comment to D27668: kerberos(8): Replace dead link to FAQ.
In D27668#680170, @ygy wrote:
In D27668#680060, @bcr wrote:

I get the following exception from Phabricator upon loading this review:
Found unknown intradiff source line, expected a line beginning with "+", "-", or " " (space): \ No newline at end of file

@bcr Interesting... It is fine on my end, no errors. Where did you see this message?

May 15 2021, 6:52 PM
bcr accepted D30275: libalias: Remove unused function LibAliasCheckNewLink.

OK from manpages.

May 15 2021, 6:50 PM
bcr added a comment to D27668: kerberos(8): Replace dead link to FAQ.

I get the following exception from Phabricator upon loading this review:
Found unknown intradiff source line, expected a line beginning with "+", "-", or " " (space): \ No newline at end of file

May 15 2021, 9:37 AM
bcr added a comment to D30272: ldconfig(8): update manpage to reality.

A few minor nits, the rest looks fine.

May 15 2021, 9:35 AM · manpages
bcr accepted D30261: build(7): use a more relevant example for PORTS_MODULES.

Looks good!

May 15 2021, 8:49 AM

May 13 2021

bcr accepted D30240: Reference CC modules consistently.

OK from me as well. Thanks!

May 13 2021, 9:42 AM

May 12 2021

bcr accepted D29901: ctlstat: add prometheus output.

Manpage looks good now.

May 12 2021, 2:07 PM
bcr accepted D30218: VFS_QUOTACTL(9): allow implementation to indicate busy state changes.

OK from manpages.

May 12 2021, 2:05 PM
bcr accepted D30215: find(1): Document the -f option.

Looks good to me. Thanks for the update.

May 12 2021, 7:42 AM
bcr added a comment to D30145: Updating Virtualization chapter.

Only found these now. Looking good otherwise.

May 12 2021, 7:41 AM · docs

May 9 2021

bcr added a comment to D29754: Augment systat(1) -swap to display large swap space processes.

A few suggestions for wording improvements in the man page.

May 9 2021, 7:07 PM

May 8 2021

bcr added a reviewer for D30176: Freebsd doc cross-platform build: carlavilla.

Adding Sergio, as I think this might interest him.
Having a way to build our docs on other platforms is nice and might bring in some new contributions.

May 8 2021, 7:02 PM · docs

May 6 2021

bcr accepted D30136: crypto: Add a new type of crypto buffer for a single mbuf..

OK for the man page update.

May 6 2021, 7:28 AM

May 4 2021

bcr added a comment to D30027: Improve sndstat man page.

Other than this small nit, I'm fine with the change.

May 4 2021, 6:52 PM
bcr accepted D30107: src.conf.5: Regen..

OK for the manpage change.

May 4 2021, 6:50 PM