bcr (Benedict Reuschling)
User

Projects

User Details

User Since
May 18 2014, 4:40 AM (191 w, 5 d)

Recent Activity

Yesterday

bcr added a comment to D13961: Updated the FAQ book's Chapter 15 about serial communicators.

The indentation seems a bit off, so I refer you to Dr. igor. ;-)

Thu, Jan 18, 6:28 PM
bcr added a comment to D13966: Added a new tutorial for connecting to a serial port through a usb-to-uart converter, as is the cases with most SoC's.

A few more suggestions.

Thu, Jan 18, 6:24 PM
bcr accepted D13905: Update various statements in vmstat(8) to match reality..

Don't forget to bump the .Dd for this content change. Thanks!

Thu, Jan 18, 6:12 PM
bcr added a comment to D13961: Updated the FAQ book's Chapter 15 about serial communicators.

A few comments. Don't be discouraged, you're on the right track.
One more thing though: next time when you create the diff, do it from the top level of your doc directory. That will include the full path to the file in the diff/review header and not just book.xml. We have many book.xml files, so having the path in there helps determining what file the patch is for.

Thu, Jan 18, 8:38 AM

Wed, Jan 17

bcr added a comment to D12075: Improve wording in Contributing article.

More info on proper link indentation. You're getting there...

Wed, Jan 17, 5:47 PM

Sun, Jan 14

bcr added a comment to D13867: dtc(1) manpage review.

A few suggestions for improvement.

Sun, Jan 14, 5:10 PM
bcr accepted D13904: Sort the list of flags in newsyslog.conf entries..

Looks good to me.

Sun, Jan 14, 4:39 PM

Wed, Jan 10

bcr added a comment to D13821: Document cap_grp service..

New suggestion on how to word it better, based on your explanation, @oshogbo.
I found something else while there, but it's easy to fix. ;-)

Wed, Jan 10, 9:54 AM
bcr added a comment to D13821: Document cap_grp service..

A few suggestions and corrections.

Wed, Jan 10, 8:02 AM

Tue, Jan 9

bcr added a comment to D13801: Reject the absurd user and group names "." and ".."..

Minor wording fixes.

Tue, Jan 9, 7:59 AM

Mon, Jan 8

bcr accepted D13793: Introduce aw_syscon(4) for earlier attachment.

OK from manpages.

Mon, Jan 8, 8:38 AM

Thu, Jan 4

bcr committed rD51363: Replace another instance of 2017 with 2018, which prevented the BSDCan entry.
Replace another instance of 2017 with 2018, which prevented the BSDCan entry
Thu, Jan 4, 4:44 PM
bcr accepted D13762: Document cap_dns service..

Haha, yeah. But only because you have a certain Goat looking over your shoulder when writing it. :-)

Thu, Jan 4, 8:43 AM
bcr added a comment to D13762: Document cap_dns service..

A few suggestions and corrections. Thanks for writing the man page!

Thu, Jan 4, 8:25 AM

Tue, Jan 2

bcr accepted D13734: Document supported services in the Casper man page..
Tue, Jan 2, 9:09 PM · manpages
bcr added a comment to D13734: Document supported services in the Casper man page..

A small sentence rephrasing proposal.

Tue, Jan 2, 10:31 AM · manpages

Mon, Jan 1

bcr added a comment to D13620: aw_usbphy: Add manual page for this driver..

One small correction for the man page.

Mon, Jan 1, 3:23 PM
bcr added a comment to D13720: aw_sid: Add man page for this driver.

Small corrections.

Mon, Jan 1, 11:18 AM

Sun, Dec 31

bcr committed rD51354: Fix event-id for FOSDEM to the actual year it will be in (2018)..
Fix event-id for FOSDEM to the actual year it will be in (2018).
Sun, Dec 31, 6:40 PM
bcr committed rD51353: Bump copyright years for the doc tree to 2018 as listed in.
Bump copyright years for the doc tree to 2018 as listed in
Sun, Dec 31, 6:38 PM
bcr committed rD51352: Bump the STARTYEAR to 2018, which was forgotten as part of r51351..
Bump the STARTYEAR to 2018, which was forgotten as part of r51351.
Sun, Dec 31, 6:19 PM
bcr committed rD51351: Create a new events page for 2018 by copying the 2017 events page.
Create a new events page for 2018 by copying the 2017 events page
Sun, Dec 31, 6:14 PM

Fri, Dec 29

bcr added a comment to D13645: Make vt(4) palette configurable.

Typo fix.

Fri, Dec 29, 1:22 PM

Tue, Dec 26

bcr accepted D13617: Allwinner: gpio rename driver to aw_gpio and add man page for it.

Approved from manpages. Thanks for doing these changes.

Tue, Dec 26, 11:33 AM
bcr accepted D13616: Allwinner: mmc: rename driver to aw_mmc and add man page for it.

OK from manpages.

Tue, Dec 26, 11:32 AM
bcr added a comment to D13619: axp209: move driver to sys/dev/pmic.

A few corrections.

Tue, Dec 26, 11:31 AM

Mon, Dec 25

bcr accepted D13621: aw_rtc: Add man page for this driver.

Ok from manpages. Thanks for working on it.

Mon, Dec 25, 7:09 PM
bcr added a comment to D13621: aw_rtc: Add man page for this driver.

Small typo.

Mon, Dec 25, 6:37 PM

Fri, Dec 22

bcr added a comment to D13456: bthidd: Add evdev protocol support.

A small man page fix.

Fri, Dec 22, 8:53 AM

Wed, Dec 20

bcr accepted D13433: Introduce daemonfd..

OK from manpages. Make sure to bump the .Dd when you commit.

Wed, Dec 20, 6:44 PM

Dec 19 2017

bcr accepted D13511: Drop NetBSD rcs tag.
Dec 19 2017, 8:23 AM

Dec 10 2017

bcr added a comment to D13433: Introduce daemonfd..

Typo fix.

Dec 10 2017, 9:31 PM

Dec 4 2017

bcr added a comment to D13369: Add hammer support for fstyp(8)..

At the top of fstyp.8, you need to bump the .Dd to the date of the commit, since this is a content change.

Dec 4 2017, 9:12 PM

Dec 1 2017

bcr added a comment to D13309: have numactl tell subprocesses that they are locked to a domain.

You need to bump the .Dd in the man page to the date of the commit, since this is a content change.

Dec 1 2017, 10:17 AM

Nov 30 2017

bcr added a comment to D13295: arm: add generic syscon driver.

Typo

Nov 30 2017, 9:47 AM

Nov 28 2017

bcr added a comment to D13271: Add a Flavors chapter..

I'd wait until the other two reviewers had time to review. I myself don't have anything else. Thanks for the work on this!

Nov 28 2017, 4:01 PM
bcr added a comment to D13271: Add a Flavors chapter..

Two suggestions...

Nov 28 2017, 8:50 AM

Nov 25 2017

bcr accepted D13239: Add support for ABORT action in ipfw.

OK from manpages, you just need to bump the .Dd to the date of the actual commit.

Nov 25 2017, 3:12 PM

Nov 24 2017

bcr accepted D13196: Update intro(6).

Approved, but you need to bump the .Dd at the top of the document to the date of your commit.

Nov 24 2017, 8:22 AM

Nov 21 2017

bcr added a comment to D13183: Kill all descendants of the reaper, even if they are descendants of a subordinate reaper..

Typo

Nov 21 2017, 3:07 PM

Nov 19 2017

bcr committed rD51205: Correct the site-name by using http:// in front of it so that clicks will.
Correct the site-name by using http:// in front of it so that clicks will
Nov 19 2017, 7:15 PM
bcr committed rD51204: Add a press section entry about Synergy Sky and their experiences migrating.
Add a press section entry about Synergy Sky and their experiences migrating
Nov 19 2017, 11:52 AM
bcr committed rS325996: MFC r325441:.
MFC r325441:
Nov 19 2017, 11:24 AM

Nov 17 2017

bcr added a comment to D13130: gifconfig_gif0 no longer works, document replacement.

This is a content change, so you need to bump the .Dd to the date of the commit.

Nov 17 2017, 8:33 AM

Nov 16 2017

bcr committed rD51202: Extend the example in the committers guide with the SPDX license identifier..
Extend the example in the committers guide with the SPDX license identifier.
Nov 16 2017, 5:50 PM

Nov 15 2017

bcr accepted D13101: Add support for Zstd-compressed kernel and userspace dumps.

OK from manpages (implicit). ;-)

Nov 15 2017, 12:25 PM

Nov 12 2017

bcr added a comment to D13061: Remove leftover in lagg(4) manpage.

Make sure to bump the .Dd to the date of the commit.

Nov 12 2017, 7:01 PM

Nov 7 2017

bcr added a comment to D12981: Document MACHINE, MACHINE_ARCH, TARGET and TARGET_ARCH historical use and general philosphy..

Two textual suggestions. Thanks for documenting this.

Nov 7 2017, 7:45 PM

Nov 5 2017

bcr committed rS325441: Extend the synopsis section of md(4) to look more like other manpages.
Extend the synopsis section of md(4) to look more like other manpages
Nov 5 2017, 6:46 PM
bcr closed D12271: Bug 218610 - md(4) manpage misses geom_md.ko .
Nov 5 2017, 6:46 PM
bcr abandoned D12283: Bug 221945 - Update tuning(7) man page with kern.ipc.soacceptqueue.

Bug has been fixed in HEAD, not need to work on this further.

Nov 5 2017, 6:37 PM
bcr closed D11824: syslog(3): example error log message should use LOG_ERR level (PR 216756).
Nov 5 2017, 6:24 PM
bcr committed rS325440: The last example used LOG_INFO, but the message itself said error..
The last example used LOG_INFO, but the message itself said error.
Nov 5 2017, 6:24 PM

Nov 4 2017

bcr added a comment to D12945: Introduce phys2disk..

In addition to the man page changes I listed, you also need to bump the .Dd to the date of the commit. Thanks!

Nov 4 2017, 7:43 PM

Nov 3 2017

bcr added a comment to D12922: Remove reference to boot floppy from crash(8).

I agree with dexter@ here, switching to the memstick image gives the user at least an idea about how to solve this. Thanks for working on this, both of you!

Nov 3 2017, 7:55 AM
bcr added a comment to D12923: Please welcome Gordon Tetlow as the new Security Officer..

I think we need to update the core liaison, too.

Nov 3 2017, 7:29 AM

Nov 2 2017

bcr added a comment to D12900: Add sponge(1).

Hi Eitan,

Nov 2 2017, 8:09 AM

Oct 31 2017

bcr added a comment to D12873: Move cpuset's parselist function into libutil.

Fixes for the man page.

Oct 31 2017, 5:07 PM

Oct 30 2017

bcr accepted D12836: ctl: Make max_luns and max_ports tunable variables instead of hardcoded defines..

OK from manpages.

Oct 30 2017, 8:31 PM

Oct 15 2017

bcr added a comment to D12679: Document missing libgeom functions.

Not sure about this, a native speaker can probably clear this up.

Oct 15 2017, 3:33 PM
bcr added a comment to D12678: Improve svn copy documentation.

Typo fix.

Oct 15 2017, 2:26 PM
bcr added a comment to D12679: Document missing libgeom functions.

A few line breaks are needed after sentence stops. You can use textproc/igor to check for this and other common man page errors.
Additionally, you need to bump the .Dd to the current date as this is a content change.
Thanks for adding these descriptions.

Oct 15 2017, 2:25 PM

Oct 6 2017

bcr added a comment to D12612: Remove invalid rwho(1)/ruptime(1)/rwhod(8) deprecation notice..

This is a content change, so you need to bump the document dates of these man pages (although it is just a revert).

Oct 6 2017, 7:48 PM
bcr accepted D12573: Remove rcmds from the base system..

OK from manpages.

Oct 6 2017, 4:57 PM

Oct 2 2017

bcr added a comment to D12569: Updates to Tiers..

Typo fix

Oct 2 2017, 6:42 PM

Sep 25 2017

bcr committed rD50922: Update Samba version to 4.6..
Update Samba version to 4.6.
Sep 25 2017, 7:35 PM

Sep 24 2017

bcr added a comment to D12473: Allow mergemaster to ignore type mismatches for specified files.

You should add a few more src people to the review than just the manpages group, because there are also some changes in the shell script.

Sep 24 2017, 11:22 AM

Sep 9 2017

bcr committed rD50812: Fix an instance of "firefox" not being capitalized within.
Fix an instance of "firefox" not being capitalized within
Sep 9 2017, 1:12 AM
bcr created D12283: Bug 221945 - Update tuning(7) man page with kern.ipc.soacceptqueue.
Sep 9 2017, 12:21 AM

Sep 7 2017

bcr created D12271: Bug 218610 - md(4) manpage misses geom_md.ko .
Sep 7 2017, 7:24 PM

Sep 2 2017

bcr accepted D12213: Update german handbook zfs chapter to r50688.

Sieht gut aus, danke fürs Übersetzen. :-)

Sep 2 2017, 1:53 PM

Aug 27 2017

bcr accepted D12127: handbook: fix various formatting issues in ZFS chapter.

Approved, thanks for working on it.

Aug 27 2017, 3:04 PM

Aug 26 2017

bcr added a comment to D12127: handbook: fix various formatting issues in ZFS chapter.

A few things I've found.

Aug 26 2017, 11:49 AM

Aug 20 2017

bcr added a comment to D12075: Improve wording in Contributing article.

A style nit.

Aug 20 2017, 7:26 AM

Aug 19 2017

bcr accepted D11807: Subversion is not installed by textproc/docproj by default..

Looks good now, thanks for working on it!

Aug 19 2017, 7:06 AM
bcr added a comment to D12075: Improve wording in Contributing article.

Can you check the change with textproc/igor? I'm not sure about the tabs at the beginning of some of the lines that were changed.

Aug 19 2017, 7:05 AM

Aug 18 2017

bcr added a comment to D11807: Subversion is not installed by textproc/docproj by default..

Two more things...

Aug 18 2017, 9:02 PM
bcr added a comment to D11807: Subversion is not installed by textproc/docproj by default..

Can you put the changes to the Quickstart section 1.1, item 1, adding Subversion up as well?

Aug 18 2017, 8:19 PM
bcr accepted D11771: Add the Thunderbolt Apple interfaces to the bge(4) supported list.

Good to go.

Aug 18 2017, 8:13 PM
bcr added a comment to D11771: Add the Thunderbolt Apple interfaces to the bge(4) supported list.

One sentence needs some work, the rest is fine and I like how you solved your "dilemma". ;-)

Aug 18 2017, 7:06 PM
bcr added a comment to D12009: Add get/set share properties subsection to handbook's ZFS chapter.

I missed something in my earlier pass. When you've fixed that (which should be quick), you can commit it.

Aug 18 2017, 7:03 PM
bcr accepted D12004: Add caveat to kinfo_getvmmap(3) explaining high CPU utilisation.

Excellent, now it's ready to go.

Aug 18 2017, 4:38 PM
bcr added a comment to D11771: Add the Thunderbolt Apple interfaces to the bge(4) supported list.

If you can't find a fitting section, then just put it into the normal text.

Aug 18 2017, 6:51 AM

Aug 17 2017

bcr added a comment to D12047: Add a USE_GITHUB example on how to use git describe..

Ah, OK then. I did not know that splited was an irregular verb. Go ahead!

Aug 17 2017, 3:11 PM

Aug 16 2017

bcr added a comment to D12047: Add a USE_GITHUB example on how to use git describe..

A few fixes.

Aug 16 2017, 5:03 PM

Aug 15 2017

bcr added a member for committers: editor_callfortesting.org.
Aug 15 2017, 5:20 PM

Aug 14 2017

bcr accepted D12024: Add a question about what the blanket approvals on the quarterly branch are..

A few comments for improvement.

Aug 14 2017, 2:42 PM
bcr accepted D12017: wmt: Driver for generic MS Windows 7/8/10 - compatible USB HID multi-touch devices.

OK from manpages, but you need to bump the .Dd to the date when you commit this. Thanks!

Aug 14 2017, 7:03 AM

Aug 12 2017

bcr accepted D12006: Update sigaction(2) to reflect the implemention in src/sys/sys/signal.h.
Aug 12 2017, 9:35 PM
bcr added a comment to D12006: Update sigaction(2) to reflect the implemention in src/sys/sys/signal.h.

Right, I sometimes hesitate because I can't grasp the extend of the change and whether what the man page change does reflects the src tree and what is done there.

Aug 12 2017, 9:35 PM
bcr accepted D12011: Correct multicast address used in pfsync(4).

OK, thanks Kristof.

Aug 12 2017, 8:57 PM
bcr requested changes to D12004: Add caveat to kinfo_getvmmap(3) explaining high CPU utilisation.

Found a simple thing to fix first.

Aug 12 2017, 7:43 PM
bcr updated subscribers of D12011: Correct multicast address used in pfsync(4).

Adding Kristof for confirming that this is the actual address in the code.

Aug 12 2017, 7:41 PM
bcr added a comment to D12009: Add get/set share properties subsection to handbook's ZFS chapter.

A few comments.

Aug 12 2017, 7:40 PM
bcr accepted D12008: Typo in linux-emulation article.
Aug 12 2017, 5:19 PM
bcr accepted D12007: Add missing header to shmget(2).

OK, go ahead with this.

Aug 12 2017, 4:39 PM
bcr added a comment to D12006: Update sigaction(2) to reflect the implemention in src/sys/sys/signal.h.

Gee, You really make me wish I had a src bit to approve this. :-\
I can't help here, sorry.

Aug 12 2017, 4:38 PM
bcr accepted D12004: Add caveat to kinfo_getvmmap(3) explaining high CPU utilisation.
Aug 12 2017, 3:14 PM
bcr accepted D11317: expr(1): Add -E flag to interpret regular expressions as EREs.

OK from manpages. Bump the document date (.Dd) when you're committing the file.

Aug 12 2017, 10:35 AM
bcr accepted D11963: Add config_intrhook_oneshot(): schedule an intrhook function and automatically unregister it after it runs..

OK from manpages. Don't forget to bump the .Dd when committing.

Aug 12 2017, 10:33 AM