OK from manpages. Can you bump the .Dd to the date of the commit for this content change? Thanks.

BTW, have you run textproc/igor and mandoc -Tlint on your changes? Could provide some valuable help and suggestions for fixes.

Can you bump the .Dd at the beginning of share/man/man7/hier.7 for this content change? Thanks!

OK from manpages.

Hi Rodrigo,

You need to bump the .Dd at the beginning of the document to the date of the commit since this is a content change.

I think it's fine for a first entry. We can always make changes to the wording. Approved!

Veni, vidi, approvi (I came, I saw, I approved). ;-)

Cool, thanks for working on it.
OK from manpages.

Good to go! Thanks.

Great, then I shall approve it. ;-)

Can you test also with textproc/igor and "mandoc -Tlint" ? Thanks!

Fine for me.

Found a typo.

Good catch!

Looks good, thanks for doing the work!

Two fixes for the man page.

A suggestion on grouping related things together. I like the overall format for the example template.

Looks good to me (in case you need approval).

@tuexen: Sounds good to me. Marie-Helene did all the work on this.
Once you have a review post 12.0, I'd be happy to help out.

@tuexen: Ideally you'd do both review and commit, since I don't have a src commit bit. It might fall under the blanket commit rule of "comment change only" for doc committers in src. Having the SCTP maintainer commit it would give it more credibility I think. I can't really comment on whether these are correct, aside from grammar and typos.

Adding Tuexen for review and (hopefully) commit.

I'm OK with the suggestion.

Shuffle some words around, nothing major.

Looks good to me.

Also approved.

Approved, thanks for working on it.

Yes, manpage update approved by mentor, although this is not needed with a src bit. ;-)

OK from the docs side.

Two nits that I found, the rest is fine from the doc side (can't say much about the actual content).

Can you bump the .Dd for this content change, too? Thanks!

OK from manpages.

The man page called, it wants it's document date (.Dd) bumped since this is a content change.
It also said that the rest looks fine and then hung up. ;-)

Fine with me.

I think that's fine in this case. Thanks for the updates.

Fine from manpages. Thanks for the work!

Can you run textproc/igor for the line breaks in the man page and possibly other errors? mandoc -Tlint would also be great.

Found a single nit in the man page.

@sevan: Haha, excellent. ;-) I shall proceed to commit.

@raichoo_googlemail.com That's fine then. A bump is typically necessary for any kind of content changes. But if those changes belong to the same commit or were written around the same time, it's fine to bump it just once. In this case, markj will take care of it when he commits it.

OK from manpages, but .Dd on lib/libdevctl/devctl.3 should be bumped.

Add manpages for lib/libdevctl/devctl.3

Looks good to me from manpages.

OK from manpages.

Small textual suggestion.

Bump the .Dd at the top of the file, then it's fine.
@markj , can you commit it? Thanks!

Fine by me.

Adding Brad to at least know about it (CC). The WITH/WITHOUT options determine in a large part how many packages pkgbase will have and perhaps we can determine (with the help of this script) which of these options are obsolete or do not make a big difference. It's a bit tangential to this work, but maybe there is something useful in there that can be considered for pkgbase.

Looks good, thanks for working on it!

OK from manpages.

OK from manpages.

Looks good, approved for commit.

You need to bump the .Dd at the top of the man page as this is a content change.
Cross referencing bsdconfig would indeed be helpful.

Adding doceng for review.