User Details
- User Since
- May 18 2014, 4:40 AM (546 w, 5 d)
Tue, Oct 15
Checked up and good to go!
Sun, Oct 13
I'll take care of it. Thanks for the work!
Oct 8 2024
OK for the man page change.
Oct 7 2024
Man page looks good to me. The actual code has to be reviewed/accepted by someone else.
Sep 7 2024
Looks good to me. I think we should try to use some automated link checker that reports when there is a broken link in our docs. But that's beside this review, so go ahead. Thank you for the work!
Sep 5 2024
OK for the man page part of the change.
Some language and typo fixes.
Aug 18 2024
Looks good to me.
Aug 12 2024
Aug 9 2024
Here's how you can "make" the doc tree:
https://docs.freebsd.org/en/books/fdp-primer/doc-build/
Aug 3 2024
Small fixes, easy to implement..
Aug 1 2024
Jul 1 2024
Looks good to me.
Jun 30 2024
Jun 27 2024
Looks good to me, thanks!
Jun 10 2024
Jun 1 2024
yes, no more need for DocBook tools/validations since we moved to Asciidoc.
May 31 2024
Ideally, this would list the browser used when testing. This is a quickly moving target as both browsers and meeting software evolve, we would need a couple more "works here" reports from users before we can make that claim in the handbook.
If you don't know any (or want to add) individual reviewers, you can use the reviewer groups you used.
Looks good, thanks for the submission.
May 30 2024
May 29 2024
We moved to Asciidoc a couple of years ago. It is doubtful that this patch will ever be committed. The content changes are good, but would need a new patch against our new doc tolchain.
Committed in https://cgit.freebsd.org/doc/commit/?id=cbe1572983c139a36fb0357e16df0dd01e1318ad
Forgot to reference this review and the PR. Will close the latter separately.
Thanks to everyone who provided input here.
I'll take care of committing this change soon.
May 21 2024
net/cloud-init would be useful for cloud-y environments.
May 13 2024
Looks good to me, thanks!
May 10 2024
Apr 1 2024
OK from manpages.
Mar 22 2024
Mar 10 2024
Jan 31 2024
A few suggestions for improvements.
Jan 18 2024
Looks good. When you commit, do a bump of the .Dd for this content change. Thank you!
Jan 11 2024
OK for the man page change. Make sure to bump the .Dd when you commit it for this content change.
Thanks for working on this, it's appreciated!
Jan 9 2024
Only a minor nit, the rest looks fine. Thanks for the update!
Jan 6 2024
Jan 2 2024
Dec 29 2023
Dec 28 2023
Nov 30 2023
Nov 27 2023
You can also run vale on your doc to get some helpful output.
Nov 16 2023
OK from manpages.
Looks alright, I think these are good additions.
Nov 15 2023
Nov 12 2023
Resolve the XXX instance. The rest looks good to me and I find it good to have such a document to detail the changes between major release versions.
Nov 11 2023
Nov 10 2023
OK from manpages
Typo
Nov 6 2023
Oct 25 2023
Oct 14 2023
Why do you need a docs review for this?