Diff Detail
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 24124 Build 22981: arc lint + arc unit
Event Timeline
Phew, what a big review. A lot of good changes in there. I made a couple of suggestions.
Thanks for working on it!
en_US.ISO8859-1/books/porters-handbook/flavors/chapter.xml | ||
---|---|---|
68 | I would rephrase this to: The first flavor is the default one and is called <literal>default</literal> here. Less commas to worry about in such a simple sentence. | |
286 | s/a packages/packages/ if multiple packages are the result, otherwise it is | |
295 | Same as above. | |
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml | ||
8153 | I would not put a comma here, so the original sentence seems fine to me. | |
en_US.ISO8859-1/books/porters-handbook/plist/chapter.xml | ||
33 | I think it is just "ports" here. | |
121 | Why the extra space here? | |
en_US.ISO8859-1/books/porters-handbook/special/chapter.xml | ||
3950 | s/libraires/libraries/ ;-) | |
4285 | s/libraires/libraries/ | |
4296 | s/libraires/libraries/ | |
4399 | s/libraires/libraries/ | |
6903 | There must be a comma between "library" and "add". | |
6916 | same here. | |
en_US.ISO8859-1/books/porters-handbook/testing/chapter.xml | ||
420 | We should use <replaceables> around the version numbers in this section here. Could be in a separate commit. | |
en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml | ||
1150 | No comma here, it refers to "default values" and not "default, values". | |
1173 | I would use a sentence stop after </varname> here to make the sentence not too long: If not set explicitly and <varname>GH_SUBDIR</varname> is present <varname>GO_PKGNAME</varname> value will be inferred from <varname>${GH_SUBDIR}</varname>. Otherwise, ... |
We moved to Asciidoc a couple of years ago. It is doubtful that this patch will ever be committed. The content changes are good, but would need a new patch against our new doc tolchain.