wblock (Warren Block)
User

Projects

User Details

User Since
May 24 2014, 9:34 PM (190 w, 5 d)

Recent Activity

Fri, Dec 29

wblock added inline comments to D13628: aw_rsb: Add man page for this driver.
Fri, Dec 29, 12:24 PM

Dec 8 2017

wblock added inline comments to D13271: Add a Flavors chapter..
Dec 8 2017, 8:24 PM
wblock added inline comments to D13356: New ufdformat(1) utility.
Dec 8 2017, 7:47 PM
wblock added inline comments to D11804: Add ability to capture packets on if_enc(4) interface after PFIL processing .
Dec 8 2017, 6:10 PM
wblock added inline comments to D12678: Improve svn copy documentation.
Dec 8 2017, 6:07 PM
wblock added a comment to D12336: Give example of deleting partitions and partitioning scheme.

Oh, and as far as the use of "you", we do have specific guidelines to avoid it: https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/writing-style.html

Dec 8 2017, 5:54 PM
wblock added inline comments to D12336: Give example of deleting partitions and partitioning scheme.
Dec 8 2017, 5:52 PM
wblock added inline comments to D11887: Bug 85128: loader.conf(5) autoboot_delay incompletly described.
Dec 8 2017, 5:42 PM
wblock added a comment to D13355: Remove fdc support from FreeBSD 12.

Is there a separate review to edit the Handbook and other documents that refer to floppies? In the Handbook alone, there are mentions in the Basics, Disks, and kernelconfig chapters. In the FAQ, too.

Dec 8 2017, 5:34 PM
wblock added a comment to D13392: Documentation EoL for 11.0-RELEASE..

We really need a better way to handle this. Perhaps a list of entities for supported releases, then during a build, concatenate them into an entity that can be used directly in the DocBook source. Then we can get away from this FIFO, or, more accurately, "it is really hard to change these" changes.

Dec 8 2017, 5:26 PM

Dec 2 2017

wblock committed rD51250: Add missing word..
Add missing word.
Dec 2 2017, 1:30 PM

Nov 18 2017

wblock added a comment to D12836: ctl: Make max_luns and max_ports tunable variables instead of hardcoded defines..

Please remember to update .Dd on commit. Thanks!

Nov 18 2017, 5:09 PM
wblock added inline comments to D13021: bhnd: add/update inline documentation comments and man pages.
Nov 18 2017, 5:04 PM
wblock added inline comments to D13130: gifconfig_gif0 no longer works, document replacement.
Nov 18 2017, 4:37 PM

Nov 17 2017

wblock added inline comments to D12900: Add sponge(1).
Nov 17 2017, 8:18 PM
wblock added inline comments to D13086: Add chvgpio driver for gpio present of Intel z8000 series (Cherry View) SOC.
Nov 17 2017, 7:50 PM
wblock added inline comments to D12945: Introduce phys2disk..
Nov 17 2017, 7:10 PM
wblock added a comment to D13015: Axe xlint..

Please remember to update .Dd in hier.7 and style.9.

Nov 17 2017, 6:47 PM
wblock added a comment to D13021: bhnd: add/update inline documentation comments and man pages.

In the future, please use full context in review diffs: https://wiki.freebsd.org/action/show/Phabricator?action=show&redirect=CodeReview#Create_a_Revision_via_Web_Interface

Nov 17 2017, 6:42 PM
wblock added a comment to D8911: basic infrastructure for simple sensors.

Remember that .Dd needs to updated on commit.

Nov 17 2017, 5:34 PM
wblock added inline comments to D13062: Add vmm(4) man page.
Nov 17 2017, 5:00 PM
wblock added inline comments to D11423: Fiber channel driver for Broadcom/Emulex FC host bus adapters..
Nov 17 2017, 4:55 PM
wblock added inline comments to D13086: Add chvgpio driver for gpio present of Intel z8000 series (Cherry View) SOC.
Nov 17 2017, 4:26 PM
wblock added inline comments to D13130: gifconfig_gif0 no longer works, document replacement.
Nov 17 2017, 4:16 PM

Oct 2 2017

wblock committed rD51025: Fix typo..
Fix typo.
Oct 2 2017, 12:46 PM

Sep 29 2017

wblock committed rD51000: Whitespace-only fixes, translators please ignore..
Whitespace-only fixes, translators please ignore.
Sep 29 2017, 9:03 PM
wblock committed rD50999: First set of patches, from me..
First set of patches, from me.
Sep 29 2017, 9:01 PM
wblock committed rD50998: Add an initial chapter about creating man pages. Much remains to be.
Add an initial chapter about creating man pages. Much remains to be
Sep 29 2017, 8:48 PM

Sep 9 2017

wblock committed rD50814: Exclude all files in htdocs/releases, and better check and sanitize the.
Exclude all files in htdocs/releases, and better check and sanitize the
Sep 9 2017, 1:35 PM
wblock committed rD50811: Add a utility to convert documentation language subdirectories to UTF-8..
Add a utility to convert documentation language subdirectories to UTF-8.
Sep 9 2017, 12:07 AM

Sep 8 2017

wblock committed rD50809: Remove the temporary assembled document after generating a PO file to.
Remove the temporary assembled document after generating a PO file to
Sep 8 2017, 2:29 PM
wblock committed rD50808: Reduce the impact of example $FreeBSD$ version strings by enclosing them.
Reduce the impact of example $FreeBSD$ version strings by enclosing them
Sep 8 2017, 2:22 PM

Sep 1 2017

wblock added inline comments to D12127: handbook: fix various formatting issues in ZFS chapter.
Sep 1 2017, 8:48 PM
wblock added a comment to D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE.

Man page changes look good to me. Please remember to bump .Dd. Thanks!

Sep 1 2017, 8:41 PM
wblock added inline comments to D12165: Add a bit about EXTRA_PATCHES..
Sep 1 2017, 8:31 PM
wblock accepted D11427: Add Lumina instructions to x11 chapter.
Sep 1 2017, 8:16 PM
wblock added inline comments to D11771: Add the Thunderbolt Apple interfaces to the bge(4) supported list.
Sep 1 2017, 8:15 PM
wblock added inline comments to D11751: Add option to geli allowing to hide passphrase darning boot..
Sep 1 2017, 7:56 PM
wblock added a comment to D3778: user friendly script as a frontend to bluetooth daemons.

Suggestions for improvements:

Sep 1 2017, 4:23 PM
wblock accepted rS320989: Language improvements..

One comment, but looks good otherwise. Thanks!

Sep 1 2017, 3:50 PM

Aug 31 2017

wblock committed rD50781: Fix missing #..
Fix missing #.
Aug 31 2017, 3:58 PM
wblock committed rD50779: Add its:translate="no" properties to elements containing $FreeBSD$.
Add its:translate="no" properties to elements containing $FreeBSD$
Aug 31 2017, 2:36 AM
wblock committed rD50778: Disguise another expandable $FreeBSD$ version string into an.
Disguise another expandable $FreeBSD$ version string into an
Aug 31 2017, 2:25 AM
wblock committed rD50777: Subversion has been told to expand $FreeBSD$ version strings in source.
Subversion has been told to expand $FreeBSD$ version strings in source
Aug 31 2017, 2:21 AM
wblock committed rD50776: Restore a missing linefeed..
Restore a missing linefeed.
Aug 31 2017, 2:08 AM

Aug 29 2017

wblock committed rD50769: Fix build by removing unrecognized autocapitalize attributes..
Fix build by removing unrecognized autocapitalize attributes.
Aug 29 2017, 1:21 PM

Aug 25 2017

wblock added a reviewer for D11525: Allow distinct setting and querying of interrupt and ithread affinities: brueffer.

Added my probably-weak mdoc suggestions, and added brueffer as a reviewer.

Aug 25 2017, 4:44 PM
wblock added inline comments to D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.
Aug 25 2017, 4:28 PM
wblock accepted D12108: Add getty/gettytab capability to generate an initial message dynamically..

Man page changes look fine to me.

Aug 25 2017, 2:36 PM
wblock accepted D11606: security.xml: minor wordsmithing.
Aug 25 2017, 1:46 PM
wblock added inline comments to D10213: Adding virtualization support for ARMv7 platforms.
Aug 25 2017, 1:38 PM · ARM
wblock added a comment to D11685: Update USB passthrough using VirtualBox section..

Did you test VirtualBox USB pass-through? I was under the impression that it did not work at all any more.

Aug 25 2017, 1:25 PM

Aug 24 2017

wblock added a comment to D11525: Allow distinct setting and querying of interrupt and ithread affinities.

This is a bit confusing. The new -I and -X options take the same irq argument as the old -x?

Aug 24 2017, 12:03 AM

Aug 18 2017

wblock committed rD50690: Remove experimental processing instructions that, in theory, caused no.
Remove experimental processing instructions that, in theory, caused no
Aug 18 2017, 8:31 PM
wblock committed rD50687: Add ITS rules to prevent translation of PGP keys..
Add ITS rules to prevent translation of PGP keys.
Aug 18 2017, 5:58 PM
wblock committed rD50686: Add the ability to set a translate="no" property on any element that.
Add the ability to set a translate="no" property on any element that
Aug 18 2017, 5:20 PM

Aug 14 2017

wblock committed rD50677: Trim obsolete translations from PO files. These are translations for.
Trim obsolete translations from PO files. These are translations for
Aug 14 2017, 9:08 PM

Jul 27 2017

wblock committed rD50590: Add translated leap-seconds article to build..
Add translated leap-seconds article to build.
Jul 27 2017, 4:46 PM

Jul 25 2017

wblock added inline comments to D11606: security.xml: minor wordsmithing.
Jul 25 2017, 1:25 AM

Jul 24 2017

wblock added a comment to D11606: security.xml: minor wordsmithing.

The href looks wrong (please see https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/docbook-markup-links.html), but the idea is good. Making the "supported releases" into a link also would be nice, if possible.

Jul 24 2017, 3:07 PM

Jul 14 2017

wblock added inline comments to D11427: Add Lumina instructions to x11 chapter.
Jul 14 2017, 7:50 PM
wblock added inline comments to D4964: Protect calls to explicit_bzero() via by explicitly disabling the link-time and other optimizations that can cause code elimination..
Jul 14 2017, 4:16 PM
wblock added inline comments to D11588: Correct -P description in boot.config(5).
Jul 14 2017, 4:01 PM
wblock accepted D11053: Add a complete example to tsearch(3).

Thank you. Please check with igor and mandoc -Tlint before commit.

Jul 14 2017, 4:00 PM
wblock added inline comments to D11523: Sort sample Makefile to be more inline with chapter guidelines.
Jul 14 2017, 3:51 PM
wblock accepted D10457: Add ability to label md(4) devices.

Man page changes LGTM.

Jul 14 2017, 3:39 PM
wblock added inline comments to D10480: Add option to limit output image to a certain size.
Jul 14 2017, 3:32 PM
wblock added inline comments to D10826: Document direct execution mode for ld.so..
Jul 14 2017, 3:25 PM
wblock added inline comments to D10170: Capsicumize cpuset_*.
Jul 14 2017, 3:17 PM
wblock added inline comments to D10388: ICMP6 rate-limit enhancements.
Jul 14 2017, 3:12 PM

Jul 7 2017

wblock added inline comments to D11477: Add deprecation notices for gdb and kgdb..
Jul 7 2017, 9:07 PM
wblock added inline comments to D10427: Add support for Amazon Elastic Network Adapter (ENA) NIC.
Jul 7 2017, 6:54 PM
wblock added inline comments to D10439: ino64.
Jul 7 2017, 6:40 PM
wblock added inline comments to D11156: uep(4): add evdev support.
Jul 7 2017, 6:32 PM
wblock added inline comments to D11306: Document MAP_GUARD..
Jul 7 2017, 5:48 PM
wblock added inline comments to D9935: Add the capability to refresh the gpart label without need a reboot..
Jul 7 2017, 5:43 PM
wblock accepted D11510: Minor fixes to VPN section Pt2.
Jul 7 2017, 5:09 PM
wblock added inline comments to D10087: route(8): clarify -prefixlen description.
Jul 7 2017, 4:29 PM
wblock added inline comments to D9577: Add the possibility to use another DTC.
Jul 7 2017, 4:18 PM · ARM
wblock added inline comments to D11510: Minor fixes to VPN section Pt2.
Jul 7 2017, 4:09 PM
wblock added inline comments to D11433: Add Format NVM support to nvmecontrol.
Jul 7 2017, 4:05 PM
wblock added inline comments to D11427: Add Lumina instructions to x11 chapter.
Jul 7 2017, 3:49 PM
wblock added inline comments to D11378: iWARP driver for Intel X722 Adapter - initial commit.
Jul 7 2017, 3:39 PM
wblock added inline comments to D11477: Add deprecation notices for gdb and kgdb..
Jul 7 2017, 3:20 PM
wblock accepted D11319: update Porter's Handbook versions to catch up with missing entries.

Looks good to me. Please build-test before commit.

Jul 7 2017, 2:30 PM

Jun 23 2017

wblock committed rS320287: Remove redundant wording, minor edits for clarity..
Remove redundant wording, minor edits for clarity.
Jun 23 2017, 6:38 PM

Jun 16 2017

wblock added inline comments to D11053: Add a complete example to tsearch(3).
Jun 16 2017, 4:20 PM
wblock added inline comments to D11143: Minor fixes to VPN section.
Jun 16 2017, 3:42 PM
wblock added a comment to D11108: Fixed small typo in security chapter..

I think this was in program output text, but that cannot be seen from the diff. Please update the diff with context as shown in https://wiki.freebsd.org/action/show/Phabricator?action=show&redirect=CodeReview

Jun 16 2017, 3:33 PM
wblock added inline comments to D11128: New manual page for the DTrace lockstat provider.
Jun 16 2017, 3:32 PM
wblock closed D11107: Small change to fdp-primer, editor config chapter, nano section.

Committed in r50349.

Jun 16 2017, 2:59 PM

Jun 10 2017

wblock committed rD50349: Clarify nano customization..
Clarify nano customization.
Jun 10 2017, 12:37 AM
wblock accepted D11107: Small change to fdp-primer, editor config chapter, nano section.
Jun 10 2017, 12:32 AM

Jun 9 2017

wblock added inline comments to D11108: Fixed small typo in security chapter..
Jun 9 2017, 5:28 PM
wblock added inline comments to D11107: Small change to fdp-primer, editor config chapter, nano section.
Jun 9 2017, 5:25 PM
wblock committed rD50341: Correctly show version information..
Correctly show version information.
Jun 9 2017, 12:23 AM

Jun 8 2017

wblock committed rD50339: Make it more clear that the "kernel" target equates to "buildkernel.
Make it more clear that the "kernel" target equates to "buildkernel
Jun 8 2017, 9:26 PM

Jun 7 2017

wblock committed rD50331: This experimental commit removes all $FreeBSD$ strings from the FDP.
This experimental commit removes all $FreeBSD$ strings from the FDP
Jun 7 2017, 7:50 PM
wblock committed rD50327: Add a target for other documents referring to STABLE..
Add a target for other documents referring to STABLE.
Jun 7 2017, 7:07 PM

May 26 2017

wblock committed rD50288: Edit link IDs so old links will work. Incidentally, split-HTML.
Edit link IDs so old links will work. Incidentally, split-HTML
May 26 2017, 5:29 PM