- User Since
- May 24 2014, 9:34 PM (190 w, 5 d)
Fri, Dec 29
Dec 8 2017
Oh, and as far as the use of "you", we do have specific guidelines to avoid it: https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/writing-style.html
Is there a separate review to edit the Handbook and other documents that refer to floppies? In the Handbook alone, there are mentions in the Basics, Disks, and kernelconfig chapters. In the FAQ, too.
We really need a better way to handle this. Perhaps a list of entities for supported releases, then during a build, concatenate them into an entity that can be used directly in the DocBook source. Then we can get away from this FIFO, or, more accurately, "it is really hard to change these" changes.
Dec 2 2017
Nov 18 2017
Please remember to update .Dd on commit. Thanks!
Nov 17 2017
Please remember to update .Dd in hier.7 and style.9.
In the future, please use full context in review diffs: https://wiki.freebsd.org/action/show/Phabricator?action=show&redirect=CodeReview#Create_a_Revision_via_Web_Interface
Remember that .Dd needs to updated on commit.
Oct 2 2017
Sep 29 2017
Sep 9 2017
Sep 8 2017
Sep 1 2017
Man page changes look good to me. Please remember to bump .Dd. Thanks!
Suggestions for improvements:
One comment, but looks good otherwise. Thanks!
Aug 31 2017
Aug 29 2017
Aug 25 2017
Added my probably-weak mdoc suggestions, and added brueffer as a reviewer.
Man page changes look fine to me.
Did you test VirtualBox USB pass-through? I was under the impression that it did not work at all any more.
Aug 24 2017
This is a bit confusing. The new -I and -X options take the same irq argument as the old -x?
Aug 18 2017
Aug 14 2017
Jul 27 2017
Jul 25 2017
Jul 24 2017
The href looks wrong (please see https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/docbook-markup-links.html), but the idea is good. Making the "supported releases" into a link also would be nice, if possible.
Jul 14 2017
Thank you. Please check with igor and mandoc -Tlint before commit.
Man page changes LGTM.
Jul 7 2017
Looks good to me. Please build-test before commit.
Jun 23 2017
Jun 16 2017
I think this was in program output text, but that cannot be seen from the diff. Please update the diff with context as shown in https://wiki.freebsd.org/action/show/Phabricator?action=show&redirect=CodeReview
Committed in r50349.