- User Since
- May 24 2014, 9:34 PM (324 w, 2 d)
Sep 2 2019
Jul 2 2019
Aug 26 2018
@dbaio, please commit this with an "Approved-by: wblock" line in the commit message. I apologize for the delay.
Jul 22 2018
I see no problems, but understand that I don't speak the language.
Jun 18 2018
Jun 1 2018
Apr 24 2018
Apr 12 2018
Mar 7 2018
Mar 3 2018
There is a lot of redundancy in the "The function returns" sentences, which could be shortened by saying just "Returns" or rearranging some in a different order, like "Zero is returned..."
Mar 2 2018
Feb 11 2018
Feb 9 2018
Feb 2 2018
Dec 29 2017
Dec 8 2017
Oh, and as far as the use of "you", we do have specific guidelines to avoid it: https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/writing-style.html
Is there a separate review to edit the Handbook and other documents that refer to floppies? In the Handbook alone, there are mentions in the Basics, Disks, and kernelconfig chapters. In the FAQ, too.
We really need a better way to handle this. Perhaps a list of entities for supported releases, then during a build, concatenate them into an entity that can be used directly in the DocBook source. Then we can get away from this FIFO, or, more accurately, "it is really hard to change these" changes.
Dec 2 2017
Nov 18 2017
Please remember to update .Dd on commit. Thanks!
Nov 17 2017
Please remember to update .Dd in hier.7 and style.9.
In the future, please use full context in review diffs: https://wiki.freebsd.org/action/show/Phabricator?action=show&redirect=CodeReview#Create_a_Revision_via_Web_Interface
Remember that .Dd needs to updated on commit.
Oct 2 2017
Sep 29 2017
Sep 9 2017
Sep 8 2017
Sep 1 2017
Man page changes look good to me. Please remember to bump .Dd. Thanks!
Suggestions for improvements:
One comment, but looks good otherwise. Thanks!
Aug 31 2017
Aug 29 2017
Aug 25 2017
Added my probably-weak mdoc suggestions, and added brueffer as a reviewer.
Man page changes look fine to me.
Did you test VirtualBox USB pass-through? I was under the impression that it did not work at all any more.
Aug 24 2017
This is a bit confusing. The new -I and -X options take the same irq argument as the old -x?
Aug 18 2017
Aug 14 2017
Jul 27 2017
Jul 25 2017
Jul 24 2017
The href looks wrong (please see https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/docbook-markup-links.html), but the idea is good. Making the "supported releases" into a link also would be nice, if possible.
Jul 14 2017
Thank you. Please check with igor and mandoc -Tlint before commit.
Man page changes LGTM.