- Give cpuset 2 new arguments, one for hard interrupts (X) and one for ithreads (I)
- Allow CPU_WHICH_(INTRHANDLER|ITHREAD) in cpuset_which()
- Fix a bug in intr_getaffinity() where we'll panic on a null pointer passed to cpuset_which.
Code wise it is fine with me, might be good to get some doc review for the mapage / usage.
Oof at both of these bugs.
Might want to ask a doc person like @wblock if this is the right way to format this (same for usage())
Maybe tweak the descriptions like so:
-x: Specifies all resources associated with an interrupt as the target of an operation.
(I would maybe say "uses" instead of "specifies" here, but the rest of the manpage uses "specifies")
Yes. The gist is that currently cpuset -x $IRQ will bind $IRQs interrupt thread and low-level hardware interrupt. I've added a mechanism to bind just the ithread or just the interrupt vector using the new -I or -X flags.
I suck at man pages, so any sanity you can add to this would be very much appreciated. Thanks!
Added my probably-weak mdoc suggestions, and added brueffer as a reviewer.
The best I've done with this is like so:
.Op .Fl j Ar jailid | .Fl p Ar pid | .Fl t Ar tid | .Fl s Ar setid | .Fl x Ar irq | .Fl I Ar irq | .Fl X Ar irq .Oc
This puts the additional options on the same line as [-l cpu-list]. Maybe not a big deal.
.Oo .Fl d Ar domain | .Fl j Ar jailid | .Fl p Ar pid | .Fl t Ar tid | .Fl s Ar setid | .Fl x Ar irq | .Fl I Ar irq | .Fl X Ar irq .Oc