Page MenuHomeFreeBSD

vangyzen (Eric van Gyzen)
User

Projects

User Details

User Since
Jun 2 2015, 9:23 PM (294 w, 2 d)

Recent Activity

Fri, Jan 1

vangyzen committed R10:670d2ad820c7: efi loader: fix typos in a comment (authored by vangyzen).
efi loader: fix typos in a comment
Fri, Jan 1, 5:39 PM

Dec 17 2020

vangyzen accepted D27620: acpi: Ensure that the affinity table is maximally coalesced.
Dec 17 2020, 7:01 PM
vangyzen added inline comments to D27620: acpi: Ensure that the affinity table is maximally coalesced.
Dec 17 2020, 5:30 PM

Dec 11 2020

vangyzen committed rS368553: decryptcore: preload OpenSSL error strings; seed PRNG.
decryptcore: preload OpenSSL error strings; seed PRNG
Dec 11 2020, 2:33 PM

Dec 10 2020

vangyzen accepted D27546: Avoid vm_free_count() for physmem available before VM ACPI walk..
Dec 10 2020, 5:24 PM

Nov 30 2020

vangyzen accepted D27184: fts_read: Handle error from a NULL return better..
Nov 30 2020, 9:42 PM

Nov 20 2020

vangyzen added a comment to D26973: Switch C.UTF-8 as the default locales.

After this change, perl freaks out like this:

perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LC_ALL = (unset),
LANG = "C.UTF-8"

are supported and installed on your system.

perl: warning: Falling back to the standard locale ("C").
panic: locale.c: 4560: Could not change LC_CTYPE locale to C.UTF-8, errno=22

Is this expected? This is perl5-5.32.0

Thanks

My issue appears to have been caused by building with WITHOUT_LOCALES=YES. Removing that makes perl happy again. Sort of odd that nothing else cared.

Nov 20 2020, 6:20 PM

Nov 15 2020

vangyzen accepted D27160: _umtx_op: document UMTX_OP_SEM2_WAIT copyout behavior.
Nov 15 2020, 9:38 PM

Oct 27 2020

vangyzen added inline comments to D26981: Note that sys/systm.h is special too.
Oct 27 2020, 9:47 PM
vangyzen accepted D26981: Note that sys/systm.h is special too.
Oct 27 2020, 9:45 PM
vangyzen accepted D26981: Note that sys/systm.h is special too.
Oct 27 2020, 9:31 PM
vangyzen accepted D26973: Switch C.UTF-8 as the default locales.
Oct 27 2020, 9:29 PM

Oct 26 2020

vangyzen closed D26895: db_search_symbol: prevent pollution from bogus symbols.
Oct 26 2020, 4:43 PM
vangyzen committed rS367059: db_search_symbol: prevent pollution from bogus symbols.
db_search_symbol: prevent pollution from bogus symbols
Oct 26 2020, 4:43 PM

Oct 25 2020

vangyzen added a comment to D26817: cdefs.h: remove intel_compiler support.
In D26817#601100, @imp wrote:
In D26817#601097, @pfg wrote:

First of all: thanks!

I should mention this was actually for a hacked linux binary-based intel compiler.

There exists a native FreeBSD [[ https://software.intel.com/content/www/us/en/develop/tools/system-studio/freebsd.html | Intel System Studio ]]compiler that claims to be GCC compatible which may just work (I tihnk it may be based on clang, but I am not sure).

I keep hearing rumors of this item, but never have been able to get a copy through my friends at Intel. I'll have to send a few emails out to see if I can see if I can get access to one, though it's a fairly low propriety. I suspect, based on a lot of things, that this doesn't actually exist, but I'll poke and prod anyway.

Oct 25 2020, 7:36 PM

Oct 23 2020

vangyzen added a comment to D26895: db_search_symbol: prevent pollution from bogus symbols.

So the comparison with PAGE_SIZE is arbitrary, right? There's no reason the aforementioned code could emit symbols with a value between, say, PAGE_SIZE and PAGE_SIZE * 2?

Oct 23 2020, 3:08 PM

Oct 22 2020

vangyzen updated the diff for D26895: db_search_symbol: prevent pollution from bogus symbols.
  • borrow Anton's comment
Oct 22 2020, 7:51 PM

Oct 21 2020

vangyzen updated the summary of D26895: db_search_symbol: prevent pollution from bogus symbols.
Oct 21 2020, 8:10 PM
vangyzen added reviewers for D26895: db_search_symbol: prevent pollution from bogus symbols: rang_acm.org, bdrewery, markj.
Oct 21 2020, 8:10 PM
vangyzen requested review of D26895: db_search_symbol: prevent pollution from bogus symbols.
Oct 21 2020, 8:09 PM
vangyzen closed D26893: ubuf is too small to hold a human readable 64 bit value.
Oct 21 2020, 5:12 PM
vangyzen committed rS366914: ntb_tool: ubuf is too small to hold a human readable 64 bit value.
ntb_tool: ubuf is too small to hold a human readable 64 bit value
Oct 21 2020, 5:12 PM
vangyzen accepted D26893: ubuf is too small to hold a human readable 64 bit value.
Oct 21 2020, 5:08 PM

Oct 18 2020

vangyzen accepted D26683: ntb: Add Xeon Gen3 support.
Oct 18 2020, 10:18 PM

Oct 16 2020

vangyzen accepted D26683: ntb: Add Xeon Gen3 support.

I'm not an NTB expert, but LGTM.

Oct 16 2020, 7:04 PM
vangyzen accepted D26819: cdefs: require gcc 4.2 or later.
Oct 16 2020, 6:29 PM
vangyzen accepted D26818: cdefs: Assume __GNUC__ defined.
Oct 16 2020, 6:25 PM
vangyzen accepted D26817: cdefs.h: remove intel_compiler support.
Oct 16 2020, 6:24 PM

Oct 1 2020

vangyzen committed rS366346: fix setitimer test for returned it_value.
fix setitimer test for returned it_value
Oct 1 2020, 9:53 PM
vangyzen closed D26445: fix setitimer test for returned it_value.
Oct 1 2020, 9:53 PM
vangyzen committed rS366345: zgrep: fix exit status with multiple files.
zgrep: fix exit status with multiple files
Oct 1 2020, 9:48 PM
vangyzen closed D26616: zgrep: fix exit status with multiple files.
Oct 1 2020, 9:48 PM
vangyzen added inline comments to D26616: zgrep: fix exit status with multiple files.
Oct 1 2020, 9:44 PM

Sep 30 2020

vangyzen updated the test plan for D26616: zgrep: fix exit status with multiple files.
Sep 30 2020, 9:28 PM
vangyzen updated the test plan for D26616: zgrep: fix exit status with multiple files.
Sep 30 2020, 9:24 PM
vangyzen requested review of D26616: zgrep: fix exit status with multiple files.
Sep 30 2020, 9:24 PM
vangyzen accepted D21788: Document the convention of adding a blank line before comments..
Sep 30 2020, 3:11 PM

Sep 18 2020

vangyzen committed rS365890: amd64 pmap_pkru_same: prev_ppr was always NULL.
amd64 pmap_pkru_same: prev_ppr was always NULL
Sep 18 2020, 8:53 PM
vangyzen added a comment to D26211: amd64 pmap_pkru_same: prev_ppr was always NULL.
In D26211#589162, @kib wrote:

I do not see why did not you committed the pmap.c change already. Please do, regardless of tests.

Sep 18 2020, 8:48 PM
vangyzen added inline comments to D26445: fix setitimer test for returned it_value.
Sep 18 2020, 5:15 PM
vangyzen committed rS365886: vm_ooffset_t is now unsigned.
vm_ooffset_t is now unsigned
Sep 18 2020, 4:48 PM
vangyzen closed D26214: vm_ooffset_t is now unsigned.
Sep 18 2020, 4:48 PM
vangyzen added a comment to D26211: amd64 pmap_pkru_same: prev_ppr was always NULL.

@kib Thank you for the detailed description. You practically wrote the test for me.

Sep 18 2020, 4:39 PM
vangyzen updated the diff for D26211: amd64 pmap_pkru_same: prev_ppr was always NULL.
  • add pkru_test for the fix in pmap_pkru_same()
Sep 18 2020, 4:36 PM

Sep 17 2020

vangyzen committed rS365845: Fix additional memory leak in process_mapfile.
Fix additional memory leak in process_mapfile
Sep 17 2020, 6:25 PM
vangyzen closed D26462: Fix additional memory leak in process_mapfile.
Sep 17 2020, 6:25 PM
vangyzen accepted D26462: Fix additional memory leak in process_mapfile.
Sep 17 2020, 6:02 PM

Sep 15 2020

vangyzen added a reviewer for D26445: fix setitimer test for returned it_value: tests.
Sep 15 2020, 7:55 PM
vangyzen requested review of D26445: fix setitimer test for returned it_value.
Sep 15 2020, 7:55 PM

Sep 1 2020

vangyzen committed rS365051: pmc: Fix freed internal location read.
pmc: Fix freed internal location read
Sep 1 2020, 3:52 PM
vangyzen closed D26227: Fix freed internal location read.
Sep 1 2020, 3:52 PM
vangyzen accepted D26227: Fix freed internal location read.
Sep 1 2020, 3:50 PM

Aug 31 2020

vangyzen updated the diff for D26214: vm_ooffset_t is now unsigned.
  • fix TOCTOU bug using tmpfs_pages_reserved
Aug 31 2020, 8:09 PM
vangyzen closed D26228: Fix memory leak in dump_multicast_tables.
Aug 31 2020, 4:19 PM
vangyzen committed rS364998: infiniband-diags: Fix memory leak in dump_multicast_tables.
infiniband-diags: Fix memory leak in dump_multicast_tables
Aug 31 2020, 4:19 PM
vangyzen closed D26229: Appease Coverty.
Aug 31 2020, 4:17 PM
vangyzen committed rS364997: infiniband: Appease Coverty.
infiniband: Appease Coverty
Aug 31 2020, 4:17 PM
vangyzen closed D26230: Fix memory leak in process_mapfile.
Aug 31 2020, 4:07 PM
vangyzen committed rS364996: libpmc: Fix memory leak in process_mapfile.
libpmc: Fix memory leak in process_mapfile
Aug 31 2020, 4:07 PM
vangyzen closed D26231: Fix nfsrvd_locku memory leak.
Aug 31 2020, 3:31 PM
vangyzen committed rS364992: Fix nfsrvd_locku memory leak.
Fix nfsrvd_locku memory leak
Aug 31 2020, 3:31 PM
vangyzen closed D26233: Fix a possible dereference of a NULL pointer.
Aug 31 2020, 3:26 PM
vangyzen committed rS364991: opensm: Fix a possible dereference of a NULL pointer.
opensm: Fix a possible dereference of a NULL pointer
Aug 31 2020, 3:26 PM
vangyzen closed D26145: Overrunning array fix.
Aug 31 2020, 3:03 PM
vangyzen committed rS364989: jedec_dimm: fix array overrun.
jedec_dimm: fix array overrun
Aug 31 2020, 3:03 PM

Aug 28 2020

vangyzen added inline comments to D26214: vm_ooffset_t is now unsigned.
Aug 28 2020, 8:26 PM
vangyzen updated the diff for D26214: vm_ooffset_t is now unsigned.
  • CR feedback
Aug 28 2020, 8:25 PM
vangyzen committed rS364935: vm_pageout_scan_active: ensure ps_delta is initialized.
vm_pageout_scan_active: ensure ps_delta is initialized
Aug 28 2020, 7:59 PM
vangyzen closed D26212: vm_pageout_scan_active: ensure ps_delta is initialized.
Aug 28 2020, 7:59 PM
vangyzen closed D26213: memstat_kvm_uma: fix reading of uma_zone_domain structures.
Aug 28 2020, 7:50 PM
vangyzen committed rS364933: memstat_kvm_uma: fix reading of uma_zone_domain structures.
memstat_kvm_uma: fix reading of uma_zone_domain structures
Aug 28 2020, 7:50 PM

Aug 27 2020

vangyzen added inline comments to D26212: vm_pageout_scan_active: ensure ps_delta is initialized.
Aug 27 2020, 4:15 PM
vangyzen updated the diff for D26212: vm_pageout_scan_active: ensure ps_delta is initialized.
  • move init to the right place
Aug 27 2020, 4:15 PM
vangyzen added inline comments to D26214: vm_ooffset_t is now unsigned.
Aug 27 2020, 3:30 PM
vangyzen requested review of D26214: vm_ooffset_t is now unsigned.
Aug 27 2020, 3:28 PM
vangyzen requested review of D26213: memstat_kvm_uma: fix reading of uma_zone_domain structures.
Aug 27 2020, 3:14 PM
vangyzen requested review of D26212: vm_pageout_scan_active: ensure ps_delta is initialized.
Aug 27 2020, 3:08 PM
vangyzen requested review of D26211: amd64 pmap_pkru_same: prev_ppr was always NULL.
Aug 27 2020, 3:05 PM

Aug 24 2020

vangyzen accepted D26145: Overrunning array fix.
Aug 24 2020, 2:32 PM

Aug 21 2020

vangyzen closed D26144: The condition can never be true.
Aug 21 2020, 7:35 PM
vangyzen committed rS364462: ixgbe: fix impossible condition.
ixgbe: fix impossible condition
Aug 21 2020, 7:34 PM
vangyzen accepted D26144: The condition can never be true.
Aug 21 2020, 7:29 PM
vangyzen closed D26141: Potential integer overflowing expression.
Aug 21 2020, 2:22 PM
vangyzen committed rS364457: amd64 pmap: potential integer overflowing expression.
amd64 pmap: potential integer overflowing expression
Aug 21 2020, 2:22 PM

Aug 18 2020

vangyzen accepted D26115: gdb(4): Support empty qSupported queries.
Aug 18 2020, 8:03 PM

Aug 4 2020

vangyzen committed rS363867: devinfo: add man page links.
devinfo: add man page links
Aug 4 2020, 9:09 PM
vangyzen committed rS363866: devinfo: fix memory leak on error paths.
devinfo: fix memory leak on error paths
Aug 4 2020, 9:06 PM

Jul 28 2020

vangyzen added a comment to D25530: Fix LOR with bpf detach.

I see the same LOR before and after the patch:

Jul 28 2020, 8:51 PM
vangyzen accepted D25859: vm_page_xbusy_claim(): Use atomics to update busy lock state..
Jul 28 2020, 4:22 PM

Jul 15 2020

vangyzen committed rS363221: Fix style in r363220.
Fix style in r363220
Jul 15 2020, 1:26 PM
vangyzen committed rS363220: Fix Coverity issues in OFED.
Fix Coverity issues in OFED
Jul 15 2020, 1:17 PM
vangyzen closed D25676: Fix Coverity issues in OFED.
Jul 15 2020, 1:17 PM
vangyzen updated the summary of D25676: Fix Coverity issues in OFED.
Jul 15 2020, 2:02 AM
vangyzen updated subscribers of D25676: Fix Coverity issues in OFED.
Jul 15 2020, 1:59 AM
vangyzen requested review of D25676: Fix Coverity issues in OFED.
Jul 15 2020, 1:56 AM

Jun 18 2020

vangyzen added a comment to D25312: Relax the rule against declaring variables in nested scopes..

One look at the beginning of a function definition and you have a good idea what the stack will look like. As opposed to when variables are declared somewhere later in the function.

Jun 18 2020, 4:09 PM
vangyzen added a comment to D25312: Relax the rule against declaring variables in nested scopes..
In D25312#558466, @dab wrote:
In D25312#558449, @jhb wrote:

BTW, one thing this leaves ambiguous is [whether] you can declare variables in the middle of blocks vs at the beginning. That is:

[...]

Place declarations at the start of blocks.

I could live with this. Although I don’t have an objection to _allowing_ declarations in line when it makes sense, I do think one can get carried away and overdo it.

Jun 18 2020, 3:55 PM
vangyzen accepted D25312: Relax the rule against declaring variables in nested scopes..

Long overdue. Thank you, Warner.

Jun 18 2020, 9:18 AM

Jun 12 2020

vangyzen committed rS362126: Honor db_pager_quit in some vm_object ddb commands.
Honor db_pager_quit in some vm_object ddb commands
Jun 12 2020, 9:53 PM
vangyzen committed rS362121: FPU init: allocate initial state from UMA to ensure alignment.
FPU init: allocate initial state from UMA to ensure alignment
Jun 12 2020, 9:18 PM