Page MenuHomeFreeBSD

vangyzen (Eric van Gyzen)
User

Projects

User Details

User Since
Jun 2 2015, 9:23 PM (392 w, 13 h)

Recent Activity

Thu, Nov 17

vangyzen committed rGa134a12b14e2: Mark the debug.vnlru_nowhere sysctl as CTLFLAG_STATS (authored by vangyzen).
Mark the debug.vnlru_nowhere sysctl as CTLFLAG_STATS
Thu, Nov 17, 4:46 PM

Fri, Nov 11

vangyzen closed D37257: zfs tests: stop writing to arbitrary devices.
Fri, Nov 11, 8:45 PM
vangyzen committed rG11ed0a95bfa7: zfs tests: stop writing to arbitrary devices (authored by vangyzen).
zfs tests: stop writing to arbitrary devices
Fri, Nov 11, 8:45 PM
vangyzen added a comment to D37257: zfs tests: stop writing to arbitrary devices.

Well, it isn't ideal. But it's certainly much better than it used to be, and the ZFS tests are much too big to shoot for "ideal".

Fri, Nov 11, 8:34 PM
vangyzen added a comment to D37257: zfs tests: stop writing to arbitrary devices.

@asomers What do you think?

Fri, Nov 11, 2:45 PM

Wed, Nov 9

vangyzen closed D37320: vm_page_unswappable: remove wrong assertion.
Wed, Nov 9, 8:31 PM
vangyzen committed rGcfbf1da0deed: vm_page_unswappable: remove wrong assertion (authored by rang_acm.org).
vm_page_unswappable: remove wrong assertion
Wed, Nov 9, 8:31 PM
vangyzen added a reviewer for D37320: vm_page_unswappable: remove wrong assertion: rang_acm.org.
Wed, Nov 9, 8:20 PM
vangyzen requested review of D37320: vm_page_unswappable: remove wrong assertion.
Wed, Nov 9, 8:19 PM

Nov 4 2022

vangyzen updated the diff for D37257: zfs tests: stop writing to arbitrary devices.
  • Fix the tests so they actually pass
Nov 4 2022, 2:45 PM
vangyzen updated the diff for D37257: zfs tests: stop writing to arbitrary devices.

Upload the whole diff.

Nov 4 2022, 1:53 PM
vangyzen updated the diff for D37257: zfs tests: stop writing to arbitrary devices.
  • Don't use log_must in cleanup.
  • Invert the test for dump devices in lieu of atf_expect_fail.
Nov 4 2022, 1:49 PM
vangyzen added inline comments to D37257: zfs tests: stop writing to arbitrary devices.
Nov 4 2022, 1:17 PM

Nov 3 2022

vangyzen requested review of D37257: zfs tests: stop writing to arbitrary devices.
Nov 3 2022, 8:10 PM

Sep 8 2022

vangyzen added reviewers for D36486: rtld: fix reference tracking with common symbols: markj, kib.
Sep 8 2022, 2:31 PM
vangyzen updated the summary of D36486: rtld: fix reference tracking with common symbols.
Sep 8 2022, 12:44 PM

Sep 7 2022

vangyzen updated subscribers of D36486: rtld: fix reference tracking with common symbols.
Sep 7 2022, 9:41 PM
vangyzen updated the summary of D36486: rtld: fix reference tracking with common symbols.
Sep 7 2022, 9:33 PM
vangyzen requested review of D36486: rtld: fix reference tracking with common symbols.
Sep 7 2022, 9:29 PM

Aug 24 2022

vangyzen committed rG3b0f105ce38e: shared_shadow_inval_test: fix copy-pasto in error message (authored by vangyzen).
shared_shadow_inval_test: fix copy-pasto in error message
Aug 24 2022, 6:06 PM

Aug 23 2022

vangyzen committed rG3d268c19efb8: Fix shared_shadow_inval_test when superpages are disabled (authored by vangyzen).
Fix shared_shadow_inval_test when superpages are disabled
Aug 23 2022, 2:14 PM
vangyzen closed D36265: Fix shared_shadow_inval_test when superpages are disabled.
Aug 23 2022, 2:14 PM

Aug 22 2022

vangyzen added a comment to D36265: Fix shared_shadow_inval_test when superpages are disabled.

Would someone kindly make D35635 and D35636 public, now that they're committed?

Aug 22 2022, 6:30 PM
vangyzen added reviewers for D36265: Fix shared_shadow_inval_test when superpages are disabled: alc, kib.
Aug 22 2022, 6:28 PM

Aug 19 2022

vangyzen added a comment to D36265: Fix shared_shadow_inval_test when superpages are disabled.

@markj Do the tests with largepagesize even make sense when superpages are disabled? I suppose not, but they're also harmless.

Aug 19 2022, 8:08 PM
vangyzen requested review of D36265: Fix shared_shadow_inval_test when superpages are disabled.
Aug 19 2022, 8:06 PM

Jul 18 2022

vangyzen added a comment to D35845: bge: tell debugnet there are 2 rx rings, not 1,024.

define a way to limit mbuf cluster allocations to n in a code section

Why is this necessary? Why can't we let the driver allocate all available mbufs?

Because we want to avoid a situation where we exhaust all of our preallocated mbufs to fill populate a single ring. That's the reason we preallocate as much as we do today.

How do multi-queue NICs behave when some rx rings are empty? If a packet arrives on an empty rx ring, does the packet get dropped, or does it get queued to a different rx ring?

I've always assumed that the packet would get dropped if the ring to which it's steered doesn't have any available buffer space. That might not be true for all devices, but I wouldn't want to rely on that.

Jul 18 2022, 9:28 PM
vangyzen committed rG3ca4a3390356: bge: tell debugnet there are 2 rx rings, not 1,024 (authored by vangyzen).
bge: tell debugnet there are 2 rx rings, not 1,024
Jul 18 2022, 9:08 PM
vangyzen closed D35845: bge: tell debugnet there are 2 rx rings, not 1,024.
Jul 18 2022, 9:08 PM
vangyzen added a comment to D35845: bge: tell debugnet there are 2 rx rings, not 1,024.

I like your plan overall. I'm not intimately familiar with the network drivers, so I can't comment on that aspect.

Jul 18 2022, 8:59 PM
vangyzen requested review of D35845: bge: tell debugnet there are 2 rx rings, not 1,024.
Jul 18 2022, 6:13 PM

Jul 7 2022

vangyzen added inline comments to D35605: ipmi: handle ipmb requests.
Jul 7 2022, 10:58 PM

Jun 14 2022

vangyzen added a comment to D35473: kernel GDB: do not reboot the target.

I don't get why we don't send PC and the watch stop reason in the '?' case

Jun 14 2022, 7:14 PM

Jun 13 2022

vangyzen committed rG9f48eea36607: rpcbind: get contact addr from xprt members (authored by Dmitry.Ovsyannikov_dell.com).
rpcbind: get contact addr from xprt members
Jun 13 2022, 6:55 PM
vangyzen retitled D35473: kernel GDB: do not reboot the target from kernel GDB: do not reboot the node to kernel GDB: do not reboot the target.
Jun 13 2022, 4:11 PM
vangyzen added reviewers for D35473: kernel GDB: do not reboot the target: rlibby, rang_acm.org.
Jun 13 2022, 4:04 PM
vangyzen requested review of D35473: kernel GDB: do not reboot the target.
Jun 13 2022, 4:03 PM

May 31 2022

vangyzen added a comment to D35245: mandoc: workaround lack of macro parsing in list -width.

Ingo will commit something similar in the near future, and Baptiste will import a new release of mandoc. For now, Bapt approved this commit.

May 31 2022, 3:09 PM
vangyzen closed D35245: mandoc: workaround lack of macro parsing in list -width.
May 31 2022, 3:09 PM
vangyzen committed rG9f6a619a7d7a: mandoc: workaround lack of macro parsing in list -width (authored by vangyzen).
mandoc: workaround lack of macro parsing in list -width
May 31 2022, 3:09 PM

May 18 2022

vangyzen added a comment to D35245: mandoc: workaround lack of macro parsing in list -width.

Have you proposed this patch to upstream? ingo@openbsd.org is very responsive and should reply back quickly, before adding any custom patch I prefer it to be discussed with upstream first. (don't hesitate to CC me)

May 18 2022, 3:03 PM
vangyzen added a comment to D35245: mandoc: workaround lack of macro parsing in list -width.

Phabricator did not quite do what I wanted. There are two diffs here: formatted pages, and code. See the History tab.

May 18 2022, 2:43 PM
vangyzen updated the diff for D35245: mandoc: workaround lack of macro parsing in list -width.

Pages formatted with the old and new code.

May 18 2022, 2:41 PM
vangyzen added a reviewer for D35245: mandoc: workaround lack of macro parsing in list -width: manpages.
May 18 2022, 2:40 PM
vangyzen updated the summary of D35245: mandoc: workaround lack of macro parsing in list -width.
May 18 2022, 2:40 PM
vangyzen requested review of D35245: mandoc: workaround lack of macro parsing in list -width.
May 18 2022, 2:39 PM

May 13 2022

vangyzen committed rG20917cac7bcf: sysv test: properly wait for children (authored by vangyzen).
sysv test: properly wait for children
May 13 2022, 9:40 PM
vangyzen closed D35187: sysv test: properly wait for children.
May 13 2022, 9:40 PM
vangyzen added a comment to D35187: sysv test: properly wait for children.

Seems rather bizarre not to use wait() to begin with. I can't see a reason why it was done this way. :/

May 13 2022, 5:58 PM
vangyzen updated the diff for D35187: sysv test: properly wait for children.
  • Review feedback, and more
May 13 2022, 5:55 PM

May 12 2022

vangyzen requested review of D35187: sysv test: properly wait for children.
May 12 2022, 10:44 PM

Apr 12 2022

vangyzen accepted D34885: Extending the length of dirpath to fix the failure in kyua test sys/audit/inter-process:shm_unlink_success.
Apr 12 2022, 4:04 PM

Mar 26 2022

vangyzen committed rG490b09f24006: uma_zalloc_domain: call uma_zalloc_debug in multi-domain path (authored by vangyzen).
uma_zalloc_domain: call uma_zalloc_debug in multi-domain path
Mar 26 2022, 1:14 AM
vangyzen committed rGaca2a7facabb: stack_zero is not needed before stack_save (authored by vangyzen).
stack_zero is not needed before stack_save
Mar 26 2022, 1:14 AM
vangyzen committed rGa65bee6705ac: stack(9): dynamic allocation is not necessary (authored by vangyzen).
stack(9): dynamic allocation is not necessary
Mar 26 2022, 1:14 AM
vangyzen closed D34472: uma_zalloc_domain: call uma_zalloc_debug in multi-domain path.
Mar 26 2022, 1:14 AM
vangyzen closed D34461: stack(9): dynamic allocation is not necessary.
Mar 26 2022, 1:14 AM
vangyzen closed D34452: uma_zalloc: assert M_NOWAIT ^ M_WAITOK.
Mar 26 2022, 1:14 AM
vangyzen committed rGa8cbb835bfdf: uma_zalloc: assert M_NOWAIT ^ M_WAITOK (authored by vangyzen).
uma_zalloc: assert M_NOWAIT ^ M_WAITOK
Mar 26 2022, 1:14 AM
vangyzen closed D34451: ksiginfo_alloc: pass M_WAITOK or M_NOWAIT to uma_zalloc.
Mar 26 2022, 1:13 AM
vangyzen committed rG863070bbf602: ksiginfo_alloc: pass M_WAITOK or M_NOWAIT to uma_zalloc (authored by vangyzen).
ksiginfo_alloc: pass M_WAITOK or M_NOWAIT to uma_zalloc
Mar 26 2022, 1:13 AM
vangyzen closed D34450: vm_ksubmap_init: pass M_WAITOK to vmem_init -> uma_zalloc_arg.
Mar 26 2022, 1:13 AM
vangyzen committed rGcfbb5f8ce0f6: vm_ksubmap_init: pass M_WAITOK to vmem_init -> uma_zalloc_arg (authored by vangyzen).
vm_ksubmap_init: pass M_WAITOK to vmem_init -> uma_zalloc_arg
Mar 26 2022, 1:13 AM

Mar 12 2022

vangyzen accepted D34528: module_test: Fix some assignments to errno intended to be tests..
Mar 12 2022, 1:48 PM

Mar 11 2022

vangyzen committed rG86b12bbc715f: ratecheck: mininterval is const (authored by vangyzen).
ratecheck: mininterval is const
Mar 11 2022, 5:37 PM

Mar 10 2022

vangyzen updated the test plan for D34472: uma_zalloc_domain: call uma_zalloc_debug in multi-domain path.
Mar 10 2022, 7:03 PM

Mar 7 2022

vangyzen added a comment to D34452: uma_zalloc: assert M_NOWAIT ^ M_WAITOK.

D34450 and D34451 fix the WAIT flags in two callers.

Mar 7 2022, 7:01 PM
vangyzen added a comment to D34452: uma_zalloc: assert M_NOWAIT ^ M_WAITOK.

I also noticed that uma_zalloc_domain() does not call uma_zalloc_debug() in the multi-domain path.

Mar 7 2022, 6:59 PM
vangyzen requested review of D34472: uma_zalloc_domain: call uma_zalloc_debug in multi-domain path.
Mar 7 2022, 6:59 PM
vangyzen updated the diff for D34452: uma_zalloc: assert M_NOWAIT ^ M_WAITOK.
  • move to uma_zalloc_debug()
Mar 7 2022, 6:55 PM
vangyzen added a comment to D34452: uma_zalloc: assert M_NOWAIT ^ M_WAITOK.

This should go in uma_zalloc_debug() instead. Otherwise uma_zalloc_smr() isn't checked.

Mar 7 2022, 4:22 PM
vangyzen added a comment to D34452: uma_zalloc: assert M_NOWAIT ^ M_WAITOK.

Thanks for the review, Ryan.

Mar 7 2022, 3:53 PM
vangyzen added a reviewer for D34452: uma_zalloc: assert M_NOWAIT ^ M_WAITOK: markj.
Mar 7 2022, 3:53 PM
vangyzen updated the diff for D34461: stack(9): dynamic allocation is not necessary.
  • reword with markj
Mar 7 2022, 3:46 PM
vangyzen added inline comments to D34461: stack(9): dynamic allocation is not necessary.
Mar 7 2022, 3:46 PM
vangyzen added inline comments to D34452: uma_zalloc: assert M_NOWAIT ^ M_WAITOK.
Mar 7 2022, 1:29 AM
vangyzen requested review of D34461: stack(9): dynamic allocation is not necessary.
Mar 7 2022, 1:27 AM
vangyzen updated the diff for D34452: uma_zalloc: assert M_NOWAIT ^ M_WAITOK.
  • auto alloc the struct
Mar 7 2022, 1:20 AM

Mar 5 2022

vangyzen added inline comments to D34452: uma_zalloc: assert M_NOWAIT ^ M_WAITOK.
Mar 5 2022, 1:02 AM
vangyzen updated the test plan for D34451: ksiginfo_alloc: pass M_WAITOK or M_NOWAIT to uma_zalloc.
Mar 5 2022, 12:59 AM
vangyzen updated the test plan for D34450: vm_ksubmap_init: pass M_WAITOK to vmem_init -> uma_zalloc_arg.
Mar 5 2022, 12:58 AM
vangyzen requested review of D34452: uma_zalloc: assert M_NOWAIT ^ M_WAITOK.
Mar 5 2022, 12:56 AM
vangyzen requested review of D34451: ksiginfo_alloc: pass M_WAITOK or M_NOWAIT to uma_zalloc.
Mar 5 2022, 12:55 AM
vangyzen requested review of D34450: vm_ksubmap_init: pass M_WAITOK to vmem_init -> uma_zalloc_arg.
Mar 5 2022, 12:54 AM

Mar 4 2022

vangyzen added inline comments to D34417: Add simple kyua tests for the mod* system calls..
Mar 4 2022, 4:14 AM

Mar 3 2022

vangyzen accepted D34163: Improve timeout precision of pthread_cond_timedwait().
Mar 3 2022, 11:59 PM
vangyzen committed rGb8319d9f78f7: atrtc: reads Century field from FADT table (authored by austin.zhang_dell.com).
atrtc: reads Century field from FADT table
Mar 3 2022, 2:23 PM
vangyzen committed rG6a73d96ac4de: mmap map_at_zero test: handle W^X (authored by Arka Sharma <arka_sharma@dell.com>).
mmap map_at_zero test: handle W^X
Mar 3 2022, 2:22 PM
vangyzen committed rG769f1e79f58b: vfs_unregister: fix error handling (authored by Marvin Ma <marvin.ma@dell.com>).
vfs_unregister: fix error handling
Mar 3 2022, 2:22 PM
vangyzen committed rG487cee4ddc7d: ddb: do not assume that ffs is mounted with softdep (authored by Keith Owens <keith.owens2@dell.com>).
ddb: do not assume that ffs is mounted with softdep
Mar 3 2022, 2:22 PM
vangyzen committed rGa7b187860cb7: ipmi: support getting address from EFI (authored by yinlong.lu_dell.com).
ipmi: support getting address from EFI
Mar 3 2022, 2:22 PM
vangyzen committed rG0ea19e39ff05: ipmi,smbios: move smbios_walk_table to smbios.h (authored by greg_unrelenting.technology).
ipmi,smbios: move smbios_walk_table to smbios.h
Mar 3 2022, 2:22 PM
vangyzen committed rG4cfd4d54822b: smbios: support getting address from EFI (authored by greg_unrelenting.technology).
smbios: support getting address from EFI
Mar 3 2022, 2:21 PM
vangyzen committed rG7abbfbda1ea7: smbios: Move smbios driver out from x86 machdep code (authored by allanjude).
smbios: Move smbios driver out from x86 machdep code
Mar 3 2022, 2:21 PM

Mar 2 2022

vangyzen committed rGe8bb416da139: time_t is pathological: use %j + cast to print it. (authored by imp).
time_t is pathological: use %j + cast to print it.
Mar 2 2022, 11:41 PM
vangyzen committed rGac69e5d47101: MFV d1b143ee9a5: libbsdxml (expat) 2.4.6 (authored by vangyzen).
MFV d1b143ee9a5: libbsdxml (expat) 2.4.6
Mar 2 2022, 10:42 PM
vangyzen committed rGd1b143ee9a5c: Vendor import of expat 2.4.6 (authored by vangyzen).
Vendor import of expat 2.4.6
Mar 2 2022, 10:37 PM
vangyzen committed rGd8d0ac7b5d73: efivar: use bool for booleans (authored by imp).
efivar: use bool for booleans
Mar 2 2022, 10:01 PM
vangyzen committed rGc2d161d30006: efivar: Attempt to fix setting/printing/deleting EFI vars with '-' in their name (authored by imp).
efivar: Attempt to fix setting/printing/deleting EFI vars with '-' in their name
Mar 2 2022, 10:01 PM
vangyzen committed rG36a9057e043b: efivar: Add --quiet to not report errors (authored by imp).
efivar: Add --quiet to not report errors
Mar 2 2022, 10:01 PM