Page MenuHomeFreeBSD

vangyzen (Eric van Gyzen)
User

Projects

User Details

User Since
Jun 2 2015, 9:23 PM (228 w, 2 d)

Recent Activity

Fri, Oct 11

vangyzen committed rS353448: coredump_phnum_test: handle full file system gracefully.
coredump_phnum_test: handle full file system gracefully
Fri, Oct 11, 9:24 PM

Wed, Oct 9

vangyzen committed rS353344: Add CTLFLAG_STATS to the dev.ioat.N.stats sysctl OIDs.
Add CTLFLAG_STATS to the dev.ioat.N.stats sysctl OIDs
Wed, Oct 9, 12:14 PM

Tue, Oct 8

vangyzen committed rS353305: Fix problems in the kern_maxfiles__increase test.
Fix problems in the kern_maxfiles__increase test
Tue, Oct 8, 1:43 PM
vangyzen closed D21900: Fix problems in the kern_maxfiles__increase test.
Tue, Oct 8, 1:43 PM

Sun, Oct 6

vangyzen added inline comments to D21900: Fix problems in the kern_maxfiles__increase test.
Sun, Oct 6, 12:34 AM
vangyzen updated the diff for D21900: Fix problems in the kern_maxfiles__increase test.
  • wait() for children instead of a sleep race
Sun, Oct 6, 12:28 AM

Sat, Oct 5

vangyzen removed a reviewer for D21900: Fix problems in the kern_maxfiles__increase test: pho.
Sat, Oct 5, 1:47 PM
vangyzen added inline comments to D21900: Fix problems in the kern_maxfiles__increase test.
Sat, Oct 5, 1:27 PM
vangyzen updated the diff for D21900: Fix problems in the kern_maxfiles__increase test.
  • rebase
Sat, Oct 5, 1:20 PM
vangyzen updated the diff for D21900: Fix problems in the kern_maxfiles__increase test.
  • fixup: make test more robust by opening more files
Sat, Oct 5, 1:18 PM

Fri, Oct 4

vangyzen added a comment to D21900: Fix problems in the kern_maxfiles__increase test.

That's not much of a test plan. Perhaps try sudo?

Fri, Oct 4, 11:31 PM
vangyzen updated the test plan for D21900: Fix problems in the kern_maxfiles__increase test.
Fri, Oct 4, 9:50 PM
vangyzen committed rS353114: Make the hw.intrs sysctl OID read-only.
Make the hw.intrs sysctl OID read-only
Fri, Oct 4, 9:46 PM
vangyzen committed rS353113: Add CTLFLAG_STATS to several debug.softdep sysctl OIDs.
Add CTLFLAG_STATS to several debug.softdep sysctl OIDs
Fri, Oct 4, 9:45 PM
vangyzen committed rS353112: Add CTLFLAG_STATS to some vfs sysctl OIDs.
Add CTLFLAG_STATS to some vfs sysctl OIDs
Fri, Oct 4, 9:43 PM
vangyzen committed rS353111: Add CTLFLAG_STATS to all COUNTER_U64* sysctl OIDs.
Add CTLFLAG_STATS to all COUNTER_U64* sysctl OIDs
Fri, Oct 4, 9:39 PM
vangyzen created D21900: Fix problems in the kern_maxfiles__increase test.
Fri, Oct 4, 9:33 PM

Mon, Sep 30

vangyzen committed rS352898: Fix coredump_phnum_test when kern.compress_user_cores != 0.
Fix coredump_phnum_test when kern.compress_user_cores != 0
Mon, Sep 30, 2:06 PM
vangyzen closed D21820: Fix coredump_phnum_test when kern.compress_user_cores != 0.
Mon, Sep 30, 2:06 PM

Fri, Sep 27

vangyzen added a comment to D21776: Fix sys/kern/coredump_phnum_test in case of kern.compress_user_cores=1.

See D21820. What do you think?

That your fix is better than mine :-)
So feel free to overwrite my changes with yours.

Fri, Sep 27, 3:23 PM
vangyzen added a comment to D21776: Fix sys/kern/coredump_phnum_test in case of kern.compress_user_cores=1.

Coincidentally, I have a different fix for this in a work-in-progress tree. My change keeps the current value of kern.compress_user_cores and decompresses the core file. It has the advantage of providing test coverage for kern.compress_user_cores (if the user enables it). I can't find any existing test coverage.

Fri, Sep 27, 3:03 PM
vangyzen created D21820: Fix coredump_phnum_test when kern.compress_user_cores != 0.
Fri, Sep 27, 3:03 PM

Sep 12 2019

vangyzen accepted D21461: Add ability to fetch kernel threads from cores in kvm_getprocs in libkvm.
Sep 12 2019, 8:53 PM

Aug 21 2019

vangyzen updated subscribers of D10188: Use 256 run queues, with 1 priority per queue.

However, the kernel improved a lot since this revision was created and a repeated test has higher chances of showing the difference (if any).

Aug 21 2019, 2:45 PM

Aug 16 2019

vangyzen committed rS351118: Update pthread_cond_timedwait() test to current NetBSD.
Update pthread_cond_timedwait() test to current NetBSD
Aug 16 2019, 1:10 PM
vangyzen closed D21279: Update pthread_cond_timedwait() test to current NetBSD version.
Aug 16 2019, 1:10 PM

Aug 15 2019

vangyzen created D21279: Update pthread_cond_timedwait() test to current NetBSD version.
Aug 15 2019, 8:53 PM

Aug 5 2019

vangyzen committed rS350620: Relax time constraint in pthread_cond_timedwait unit test.
Relax time constraint in pthread_cond_timedwait unit test
Aug 5 2019, 10:59 PM
vangyzen abandoned D21161: indent: rename a test data file.
Aug 5 2019, 7:29 PM
vangyzen added a comment to D21161: indent: rename a test data file.

*facepalm* this is really happening? Oy...

Aug 5 2019, 3:20 AM

Aug 4 2019

vangyzen created D21161: indent: rename a test data file.
Aug 4 2019, 8:04 PM

Jul 22 2019

D21015: sbuf(9): Add NOWAIT dynamic buffer extension mode is now accepted and ready to land.
Jul 22 2019, 1:41 AM
vangyzen added inline comments to D21015: sbuf(9): Add NOWAIT dynamic buffer extension mode.
Jul 22 2019, 12:32 AM

Jul 21 2019

vangyzen added inline comments to D21015: sbuf(9): Add NOWAIT dynamic buffer extension mode.
Jul 21 2019, 8:28 PM

Jul 16 2019

vangyzen committed rS350056: MFC r349834.
MFC r349834
Jul 16 2019, 4:49 PM
vangyzen committed rS350050: MFC r349834.
MFC r349834
Jul 16 2019, 4:05 PM
vangyzen committed rS350043: Adds signal number format to kern.corefile.
Adds signal number format to kern.corefile
Jul 16 2019, 3:51 PM
Herald added a reviewer for D20970: Adds signal number format to kern.corefile: manpages.
Jul 16 2019, 3:51 PM
D20970: Adds signal number format to kern.corefile is now accepted and ready to land.
Jul 16 2019, 3:25 PM
vangyzen accepted D20970: Adds signal number format to kern.corefile.
Jul 16 2019, 3:18 PM

Jul 8 2019

vangyzen committed rS349834: Ignore kern.vt.splash_cpu without graphics.
Ignore kern.vt.splash_cpu without graphics
Jul 8 2019, 1:46 PM
vangyzen closed D20877: Ignore kern.vt.splash_cpu on bhyve.
Jul 8 2019, 1:46 PM

Jul 7 2019

vangyzen added inline comments to D20877: Ignore kern.vt.splash_cpu on bhyve.
Jul 7 2019, 10:38 PM
vangyzen added a reviewer for D20877: Ignore kern.vt.splash_cpu on bhyve: dumbbell.
Jul 7 2019, 10:37 PM
vangyzen created D20877: Ignore kern.vt.splash_cpu on bhyve.
Jul 7 2019, 10:36 PM

Jul 3 2019

vangyzen committed rS349693: MFC r349285.
MFC r349285
Jul 3 2019, 7:55 PM
vangyzen committed rS349691: MFC r349285.
MFC r349285
Jul 3 2019, 7:52 PM
vangyzen committed rS349690: MFC r349278.
MFC r349278
Jul 3 2019, 7:50 PM
vangyzen closed D20794: Save the last callout function executed on each CPU.
Jul 3 2019, 7:23 PM
vangyzen committed rS349677: Save the last callout function executed on each CPU.
Save the last callout function executed on each CPU
Jul 3 2019, 7:23 PM
D20842: Bug 238960: panic in vm_pageout_collect_batch() with QUEUE_MACRO_DEBUG_TRASH enabled is now accepted and ready to land.
Jul 3 2019, 4:28 PM

Jul 1 2019

vangyzen added a comment to D20794: Save the last callout function executed on each CPU.
  • Show the last callout on every CPU by default
Jul 1 2019, 2:25 AM
vangyzen updated the test plan for D20794: Save the last callout function executed on each CPU.
Jul 1 2019, 2:21 AM
vangyzen added a comment to D20794: Save the last callout function executed on each CPU.

The change looks ok to me.

Jul 1 2019, 1:39 AM

Jun 28 2019

vangyzen created D20794: Save the last callout function executed on each CPU.
Jun 28 2019, 4:41 PM

Jun 22 2019

vangyzen added a comment to D20603: Update net/tcptestsuite to github commit f7a1844.

I hope to commit some ATF tests to the tcptestsuite repo. I’ll send out a new review to update the port after that.

Jun 22 2019, 6:13 PM
vangyzen committed rS349285: VirtIO SCSI: validate seg_max on attach.
VirtIO SCSI: validate seg_max on attach
Jun 22 2019, 1:20 AM
vangyzen closed D20703: VirtIO SCSI: validate seg_max from hypervisor.
Jun 22 2019, 1:20 AM

Jun 21 2019

vangyzen updated the summary of D20703: VirtIO SCSI: validate seg_max from hypervisor.
Jun 21 2019, 7:30 PM
vangyzen added a comment to D20703: VirtIO SCSI: validate seg_max from hypervisor.

Sorry I wasn't clearer: use virtqueue_size() after the allocate to do the check. Do not add a new virtqueue_size bus interface.

Jun 21 2019, 7:28 PM
vangyzen added a comment to D20703: VirtIO SCSI: validate seg_max from hypervisor.
  • Clamp seg_max after allocating virtqueues.
Jun 21 2019, 7:28 PM
vangyzen closed D20529: bhyve: fix reporting of virtio scsi seg_max.
Jun 21 2019, 6:57 PM
vangyzen committed rS349278: bhyve: Fix vtscsi maximum segment config.
bhyve: Fix vtscsi maximum segment config
Jun 21 2019, 6:57 PM
vangyzen added a comment to D20703: VirtIO SCSI: validate seg_max from hypervisor.
  • revert to previous approach of clamping seg_max
  • do not artificially limit seg_max when indirect is available
Jun 21 2019, 4:52 PM
vangyzen added inline comments to D20703: VirtIO SCSI: validate seg_max from hypervisor.
Jun 21 2019, 4:47 PM
vangyzen accepted D20701: rc.d/motd: Update motd more robustly.
Jun 21 2019, 2:21 AM
vangyzen updated the test plan for D20703: VirtIO SCSI: validate seg_max from hypervisor.
Jun 21 2019, 12:03 AM
vangyzen added a comment to D20703: VirtIO SCSI: validate seg_max from hypervisor.

Mark: Sorry, I @-mentioned you by mistake.

Jun 21 2019, 12:01 AM

Jun 20 2019

vangyzen updated subscribers of D20703: VirtIO SCSI: validate seg_max from hypervisor.
  • Simply detect the case and fail to attach, as @bryanv suggests.
Jun 20 2019, 11:59 PM

Jun 19 2019

vangyzen added inline comments to D20703: VirtIO SCSI: validate seg_max from hypervisor.
Jun 19 2019, 10:18 PM
D20703: VirtIO SCSI: validate seg_max from hypervisor now requires review to proceed.
  • add declaration of vtmmio_virtqueue_size()
Jun 19 2019, 9:59 PM
vangyzen added inline comments to D20529: bhyve: fix reporting of virtio scsi seg_max.
Jun 19 2019, 9:50 PM
vangyzen retitled D20529: bhyve: fix reporting of virtio scsi seg_max from Fix calculation of vtscsi_max_nsegs to bhyve: fix reporting of virtio scsi seg_max.
Jun 19 2019, 9:42 PM
vangyzen added a comment to D20529: bhyve: fix reporting of virtio scsi seg_max.
  • add comment for foo - 2
Jun 19 2019, 9:37 PM
vangyzen added a reviewer for D20703: VirtIO SCSI: validate seg_max from hypervisor: bhyve.
Jun 19 2019, 9:30 PM
vangyzen created D20703: VirtIO SCSI: validate seg_max from hypervisor.
Jun 19 2019, 9:30 PM
D20701: rc.d/motd: Update motd more robustly is now accepted and ready to land.
Jun 19 2019, 8:09 PM

Jun 13 2019

vangyzen abandoned D20610: Integrate tcp-testsuite into kyua.

Abandoned in favor of https://github.com/freebsd-net/tcp-testsuite/pull/4#

Jun 13 2019, 8:43 PM
vangyzen added a comment to D20610: Integrate tcp-testsuite into kyua.

If you add the tests directly in GH, feel free to request a review from me.

Jun 13 2019, 1:59 PM

Jun 11 2019

vangyzen updated the summary of D20610: Integrate tcp-testsuite into kyua.
Jun 11 2019, 7:53 PM
vangyzen added a comment to D20610: Integrate tcp-testsuite into kyua.

The basic idea behind this review is fundamentally broken. We shouldn't be adding test cases to the base system that wrap a port which is itself just a bunch of test cases. Instead, the correct approach would be to add ATF test cases directly to the port, to be installed into /usr/local/tests/tcptestsuite. See devel/atf, devel/kyua, or devel/lutok for examples of ports that do that.

Jun 11 2019, 7:52 PM
vangyzen updated subscribers of D20610: Integrate tcp-testsuite into kyua.
Jun 11 2019, 5:32 PM
vangyzen created D20610: Integrate tcp-testsuite into kyua.
Jun 11 2019, 5:29 PM
vangyzen created D20603: Update net/tcptestsuite to github commit f7a1844.
Jun 11 2019, 3:44 PM

Jun 6 2019

vangyzen added a comment to D20529: bhyve: fix reporting of virtio scsi seg_max.

Does this need urgent attention to get in 11.3?

Jun 6 2019, 6:53 PM
vangyzen added a comment to D20529: bhyve: fix reporting of virtio scsi seg_max.

Wait, I think we should still have a seat belt in guests.

Jun 6 2019, 4:47 PM
vangyzen added a comment to D20529: bhyve: fix reporting of virtio scsi seg_max.

If you change the config seg_max in bhyve to be VTSCSI_MAXSEG - 2, does that fix the issue?

I'll try that now.

Jun 6 2019, 1:32 PM
vangyzen updated the diff for D20529: bhyve: fix reporting of virtio scsi seg_max.

Fix it in bhyve instead

Jun 6 2019, 1:31 PM
vangyzen added a comment to D20529: bhyve: fix reporting of virtio scsi seg_max.

I believe seg_max is the number of segments in a SCSI command while...

Jun 6 2019, 12:15 PM

Jun 5 2019

vangyzen created D20529: bhyve: fix reporting of virtio scsi seg_max.
Jun 5 2019, 9:43 PM

May 28 2019

vangyzen accepted D20448: style.9: Codify tolerance for eliding blank lines.
May 28 2019, 6:47 PM

May 24 2019

vangyzen accepted D20401: Disable intr_storm_threshold mechanism by default.
May 24 2019, 10:33 PM
vangyzen updated subscribers of D18930: Per-thread credentials.
May 24 2019, 12:00 PM

May 10 2019

vangyzen added inline comments to D20206: netdump: Ref the interface we're attached to.
May 10 2019, 7:32 PM

Apr 12 2019

vangyzen updated the diff for D19426: post-commit hooks: Accept BZ URLs in PR lines.
  • Accept short URLs, too.
Apr 12 2019, 2:57 PM

Mar 8 2019

vangyzen added a comment to D19426: post-commit hooks: Accept BZ URLs in PR lines.

I would be comfortable with simply "https://bugs.freebsd.org/12344" as that can likely work forever.

Note that https://bugs.freebsd.org/12344 does work - we should accept either https://bugs.freebsd.org/bugzilla/show_bug.cgi?id= or https://bugs.freebsd.org/[0-9]+

Mar 8 2019, 9:17 PM
vangyzen updated subscribers of D19459: subversion: update commit message template to allow URLs in PR field.
In D19459#417484, @kristof wrote:

https://bugs.freebsd.org/12345 redirects to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=12345. Wouldn't the first form be better? It's shorter and likely easier to map to whatever bug tracker we might move to after bugzilla (if we ever do change). It also looks more like the phabricator links.

Mar 8 2019, 3:52 PM

Mar 5 2019

vangyzen added inline comments to D19460: subversion: update commit message template to allow URLs in PR field.
Mar 5 2019, 7:32 PM
vangyzen updated the diff for D19459: subversion: update commit message template to allow URLs in PR field.

Just mention the URL in the comments.

Mar 5 2019, 7:09 PM
vangyzen updated the diff for D19460: subversion: update commit message template to allow URLs in PR field.

Just mention the URL in the comments.

Mar 5 2019, 7:07 PM