Page MenuHomeFreeBSD

vangyzen (Eric van Gyzen)
User

Projects

User Details

User Since
Jun 2 2015, 9:23 PM (493 w, 1 d)

Recent Activity

Tue, Nov 5

vangyzen accepted D47444: Use correct idle routine on AMD.

I share kib's curiosity, but it clearly works, so LGTM. Nice find!

Tue, Nov 5, 7:15 PM

Jan 18 2024

vangyzen accepted D43491: ofed: fix warnings during libibverbs compilation .
Jan 18 2024, 7:43 PM

Nov 9 2023

vangyzen updated subscribers of D41421: Update jemalloc to version 5.3.0.

Thank you for asking, but I didn't actually do the last update. @jasone did it, but had to revert it. I simply un-reverted his work.

Nov 9 2023, 10:26 PM · Contributor Reviews (src)

Oct 9 2023

vangyzen accepted D42129: file: Support testing multiple magic files..
Oct 9 2023, 2:54 PM

Sep 19 2023

vangyzen closed D41105: Cleanup pthread locks in ofed RDMA verbs.
Sep 19 2023, 2:13 PM
vangyzen committed rGa687910fc435: Cleanup pthread locks in ofed RDMA verbs (authored by sean.lim_dell.com).
Cleanup pthread locks in ofed RDMA verbs
Sep 19 2023, 2:13 PM

Aug 1 2023

vangyzen committed rG1112883e19aa: dtrace: remove dead code for PR_REQUESTED (authored by vangyzen).
dtrace: remove dead code for PR_REQUESTED
Aug 1 2023, 5:29 PM
vangyzen committed rGbe1dd8e65bc6: proc_detach: use ptrace(PT_KILL) to kill the tracee (authored by vangyzen).
proc_detach: use ptrace(PT_KILL) to kill the tracee
Aug 1 2023, 5:29 PM
vangyzen committed rGbcbce2a29b89: dtrace: do not overload libproc flags (authored by vangyzen).
dtrace: do not overload libproc flags
Aug 1 2023, 5:29 PM
vangyzen committed rG837f6ecd88ee: dtrace: remove illumos code from dt_proc.c (authored by vangyzen).
dtrace: remove illumos code from dt_proc.c
Aug 1 2023, 5:29 PM
vangyzen closed D41225: dtrace: remove dead code for PR_REQUESTED.
Aug 1 2023, 5:29 PM
vangyzen closed D41122: proc_detach: use ptrace(PT_KILL) to kill the tracee.
Aug 1 2023, 5:29 PM
vangyzen closed D41173: dtrace: remove illumos code from dt_proc.c.
Aug 1 2023, 5:29 PM
vangyzen closed D41121: dtrace: do not overload libproc flags.
Aug 1 2023, 5:29 PM

Jul 28 2023

vangyzen requested review of D41225: dtrace: remove dead code for PR_REQUESTED.
Jul 28 2023, 3:58 PM
vangyzen updated the diff for D41121: dtrace: do not overload libproc flags.
  • remove DT_CLOSE_HANG, which never happens on FreeBSD
Jul 28 2023, 3:53 PM
vangyzen added inline comments to D41121: dtrace: do not overload libproc flags.
Jul 28 2023, 3:35 PM

Jul 26 2023

vangyzen added inline comments to D41121: dtrace: do not overload libproc flags.
Jul 26 2023, 2:58 PM

Jul 25 2023

vangyzen retitled D41121: dtrace: do not overload libproc flags from dtrace: avoid flag collision with libproc flags to dtrace: do not overload libproc flags.
Jul 25 2023, 6:51 PM
vangyzen updated the diff for D41121: dtrace: do not overload libproc flags.
  • rebase onto D41173; store flags in dt_proc
Jul 25 2023, 4:54 PM
vangyzen added inline comments to D41121: dtrace: do not overload libproc flags.
Jul 25 2023, 4:49 PM
vangyzen requested review of D41173: dtrace: remove illumos code from dt_proc.c.
Jul 25 2023, 4:47 PM
vangyzen accepted D41105: Cleanup pthread locks in ofed RDMA verbs.

In light of @hselasky's untimely departure, would someone on network like to review this, or suggest another reviewer?

Jul 25 2023, 3:40 PM

Jul 24 2023

vangyzen added inline comments to D41121: dtrace: do not overload libproc flags.
Jul 24 2023, 9:31 PM
vangyzen updated the diff for D41121: dtrace: do not overload libproc flags.
  • fix comment style
Jul 24 2023, 6:18 PM
vangyzen added a comment to D41121: dtrace: do not overload libproc flags.

What do you think, @markj?

Jul 24 2023, 6:18 PM

Jul 21 2023

vangyzen added inline comments to D41121: dtrace: do not overload libproc flags.
Jul 21 2023, 3:51 PM

Jul 20 2023

vangyzen updated subscribers of D41122: proc_detach: use ptrace(PT_KILL) to kill the tracee.
Jul 20 2023, 8:21 PM
vangyzen updated subscribers of D41121: dtrace: do not overload libproc flags.
Jul 20 2023, 8:21 PM
vangyzen updated the test plan for D41121: dtrace: do not overload libproc flags.
Jul 20 2023, 8:14 PM
vangyzen requested review of D41122: proc_detach: use ptrace(PT_KILL) to kill the tracee.
Jul 20 2023, 8:13 PM
vangyzen requested review of D41121: dtrace: do not overload libproc flags.
Jul 20 2023, 8:10 PM

Jul 12 2023

vangyzen committed rGdad11f990e2b: dtrace: prevent forked child from running after an error condition (authored by vangyzen).
dtrace: prevent forked child from running after an error condition
Jul 12 2023, 3:36 PM
vangyzen closed D40976: dtrace: prevent forked child from running after an error condition.
Jul 12 2023, 3:36 PM
vangyzen added a comment to D40976: dtrace: prevent forked child from running after an error condition.

The DTrace test suite had fewer failures with this change. They were not fixed by this change; they're just unreliable.

Jul 12 2023, 3:32 PM

Jul 11 2023

vangyzen updated the test plan for D40976: dtrace: prevent forked child from running after an error condition.
Jul 11 2023, 6:43 PM
vangyzen updated the diff for D40976: dtrace: prevent forked child from running after an error condition.
  • wordsmith comment
Jul 11 2023, 6:42 PM
vangyzen added inline comments to D40976: dtrace: prevent forked child from running after an error condition.
Jul 11 2023, 6:41 PM
vangyzen updated subscribers of D40976: dtrace: prevent forked child from running after an error condition.
Jul 11 2023, 6:27 PM
vangyzen requested review of D40976: dtrace: prevent forked child from running after an error condition.
Jul 11 2023, 6:23 PM

Jul 10 2023

vangyzen committed rGeb8d2e123d10: dhclient: fix build on i386 (authored by vangyzen).
dhclient: fix build on i386
Jul 10 2023, 8:09 PM
vangyzen committed rGc210cac00f25: dhclient: fix time parsing for leases expiring after 2038 (authored by alexander.bahm_dell.com).
dhclient: fix time parsing for leases expiring after 2038
Jul 10 2023, 4:03 PM
vangyzen closed D40760: dhclient: fix time parsing for leases expiring after 2038.
Jul 10 2023, 4:02 PM
vangyzen accepted D40760: dhclient: fix time parsing for leases expiring after 2038.
Jul 10 2023, 3:52 PM

Jul 7 2023

vangyzen added a comment to D40414: dtrace: move kinst tests to common.

This needs a change in etc/mtree/BSD.tests.dist and perhaps ObsoleteFiles.inc.

Jul 7 2023, 11:22 AM

Jun 1 2023

vangyzen committed rGaee3ee66a182: cron: fix build without LOGIN_CAP (authored by vangyzen).
cron: fix build without LOGIN_CAP
Jun 1 2023, 9:26 PM
vangyzen added a comment to D40260: Import vixie cron 4.0.

I have no objection to this approach (but have not reviewed the diff in detail yet).

Jun 1 2023, 7:39 PM
vangyzen committed rGfe590ffe40f4: Import vixie cron 4.0 (authored by vangyzen).
Import vixie cron 4.0
Jun 1 2023, 7:15 PM
vangyzen closed D40260: Import vixie cron 4.0.
Jun 1 2023, 7:15 PM
vangyzen added a comment to D40260: Import vixie cron 4.0.

Thank you both for the feedback. I like the idea of using OpenBSD as an upstream, but that would take a lot more time than I have right now. (Most or all of my FreeBSD time is on Dell's clock.)

Jun 1 2023, 7:09 PM

May 31 2023

vangyzen accepted D40343: decryptcore: update for OpenSSL 1.1 API.
May 31 2023, 2:52 PM

May 30 2023

vangyzen added a comment to D40260: Import vixie cron 4.0.

I think the best approach would be to import through the vendor branch and put it in contrib/cron, and altering the makefiles to contrib/cron instead. The vendor branch provides a better degree of maintainability.

May 30 2023, 5:54 PM
vangyzen closed D40236: Fix NULL deref in ip_output during route change.
May 30 2023, 5:13 PM
vangyzen committed rG8fa89d8b1904: Fix NULL deref in ip_output during route change (authored by vangyzen).
Fix NULL deref in ip_output during route change
May 30 2023, 5:13 PM

May 24 2023

vangyzen requested review of D40260: Import vixie cron 4.0.
May 24 2023, 9:57 PM

May 23 2023

vangyzen updated the summary of D40236: Fix NULL deref in ip_output during route change.
May 23 2023, 4:09 PM
vangyzen requested review of D40236: Fix NULL deref in ip_output during route change.
May 23 2023, 3:27 PM

Apr 14 2023

vangyzen committed rG485f783f882e: limits_test: validate CPU time used, not real time (authored by vangyzen).
limits_test: validate CPU time used, not real time
Apr 14 2023, 8:16 PM

Apr 4 2023

vangyzen committed rGecaeac805b04: mlxfw: fix potential NULL pointer dereference (authored by vangyzen).
mlxfw: fix potential NULL pointer dereference
Apr 4 2023, 7:29 PM
vangyzen closed D39348: mlxfw: fix potential NULL pointer dereference.
Apr 4 2023, 7:29 PM
vangyzen closed D39347: cap_dns, cap_net: fix host and service buffer handling.
Apr 4 2023, 7:29 PM
vangyzen committed rG179bffddf530: cap_dns, cap_net: fix host and service buffer handling (authored by vangyzen).
cap_dns, cap_net: fix host and service buffer handling
Apr 4 2023, 7:29 PM
vangyzen added a comment to D39347: cap_dns, cap_net: fix host and service buffer handling.

please add the CID to the commit message
(unless this is not from Coverity Scan's FreeBSD report)

Apr 4 2023, 7:24 PM
vangyzen added reviewers for D39347: cap_dns, cap_net: fix host and service buffer handling: capsicum, security.
Apr 4 2023, 5:18 PM

Mar 30 2023

vangyzen added a comment to D39348: mlxfw: fix potential NULL pointer dereference.

It's not clear to me whether this is actually possible or just theoretical.

Mar 30 2023, 10:30 PM
vangyzen requested review of D39348: mlxfw: fix potential NULL pointer dereference.
Mar 30 2023, 10:28 PM
vangyzen requested review of D39347: cap_dns, cap_net: fix host and service buffer handling.
Mar 30 2023, 10:18 PM

Mar 29 2023

vangyzen committed rG3bbd1a1a0056: camcontrol powermode: fix use-after-free (authored by vangyzen).
camcontrol powermode: fix use-after-free
Mar 29 2023, 6:28 PM

Feb 21 2023

vangyzen accepted D38676: Fix Coverity issue in the NVDIMM driver.
Feb 21 2023, 1:42 PM

Feb 14 2023

vangyzen accepted D38551: hyperv: Fix Coverity issues in the Hyper-V driver.

Common practice for attributing the submitter with git is:

Feb 14 2023, 2:55 PM

Dec 26 2022

vangyzen accepted D37863: Commit message template: PR field now accepts bugs.freebsd.org URL..
Dec 26 2022, 11:15 PM

Nov 17 2022

vangyzen committed rGa134a12b14e2: Mark the debug.vnlru_nowhere sysctl as CTLFLAG_STATS (authored by vangyzen).
Mark the debug.vnlru_nowhere sysctl as CTLFLAG_STATS
Nov 17 2022, 4:46 PM

Nov 11 2022

vangyzen closed D37257: zfs tests: stop writing to arbitrary devices.
Nov 11 2022, 8:45 PM
vangyzen committed rG11ed0a95bfa7: zfs tests: stop writing to arbitrary devices (authored by vangyzen).
zfs tests: stop writing to arbitrary devices
Nov 11 2022, 8:45 PM
vangyzen added a comment to D37257: zfs tests: stop writing to arbitrary devices.

Well, it isn't ideal. But it's certainly much better than it used to be, and the ZFS tests are much too big to shoot for "ideal".

Nov 11 2022, 8:34 PM
vangyzen added a comment to D37257: zfs tests: stop writing to arbitrary devices.

@asomers What do you think?

Nov 11 2022, 2:45 PM

Nov 9 2022

vangyzen closed D37320: vm_page_unswappable: remove wrong assertion.
Nov 9 2022, 8:31 PM
vangyzen committed rGcfbf1da0deed: vm_page_unswappable: remove wrong assertion (authored by rang_acm.org).
vm_page_unswappable: remove wrong assertion
Nov 9 2022, 8:31 PM
vangyzen added a reviewer for D37320: vm_page_unswappable: remove wrong assertion: rang_acm.org.
Nov 9 2022, 8:20 PM
vangyzen requested review of D37320: vm_page_unswappable: remove wrong assertion.
Nov 9 2022, 8:19 PM

Nov 4 2022

vangyzen updated the diff for D37257: zfs tests: stop writing to arbitrary devices.
  • Fix the tests so they actually pass
Nov 4 2022, 2:45 PM
vangyzen updated the diff for D37257: zfs tests: stop writing to arbitrary devices.

Upload the whole diff.

Nov 4 2022, 1:53 PM
vangyzen updated the diff for D37257: zfs tests: stop writing to arbitrary devices.
  • Don't use log_must in cleanup.
  • Invert the test for dump devices in lieu of atf_expect_fail.
Nov 4 2022, 1:49 PM
vangyzen added inline comments to D37257: zfs tests: stop writing to arbitrary devices.
Nov 4 2022, 1:17 PM

Nov 3 2022

vangyzen requested review of D37257: zfs tests: stop writing to arbitrary devices.
Nov 3 2022, 8:10 PM

Sep 8 2022

vangyzen added reviewers for D36486: rtld: fix reference tracking with common symbols: markj, kib.
Sep 8 2022, 2:31 PM
vangyzen updated the summary of D36486: rtld: fix reference tracking with common symbols.
Sep 8 2022, 12:44 PM

Sep 7 2022

vangyzen updated subscribers of D36486: rtld: fix reference tracking with common symbols.
Sep 7 2022, 9:41 PM
vangyzen updated the summary of D36486: rtld: fix reference tracking with common symbols.
Sep 7 2022, 9:33 PM
vangyzen requested review of D36486: rtld: fix reference tracking with common symbols.
Sep 7 2022, 9:29 PM

Aug 24 2022

vangyzen committed rG3b0f105ce38e: shared_shadow_inval_test: fix copy-pasto in error message (authored by vangyzen).
shared_shadow_inval_test: fix copy-pasto in error message
Aug 24 2022, 6:06 PM

Aug 23 2022

vangyzen committed rG3d268c19efb8: Fix shared_shadow_inval_test when superpages are disabled (authored by vangyzen).
Fix shared_shadow_inval_test when superpages are disabled
Aug 23 2022, 2:14 PM
vangyzen closed D36265: Fix shared_shadow_inval_test when superpages are disabled.
Aug 23 2022, 2:14 PM

Aug 22 2022

vangyzen added a comment to D36265: Fix shared_shadow_inval_test when superpages are disabled.

Would someone kindly make D35635 and D35636 public, now that they're committed?

Aug 22 2022, 6:30 PM
vangyzen added reviewers for D36265: Fix shared_shadow_inval_test when superpages are disabled: alc, kib.
Aug 22 2022, 6:28 PM

Aug 19 2022

vangyzen added a comment to D36265: Fix shared_shadow_inval_test when superpages are disabled.

@markj Do the tests with largepagesize even make sense when superpages are disabled? I suppose not, but they're also harmless.

Aug 19 2022, 8:08 PM
vangyzen requested review of D36265: Fix shared_shadow_inval_test when superpages are disabled.
Aug 19 2022, 8:06 PM

Jul 18 2022

vangyzen added a comment to D35845: bge: tell debugnet there are 2 rx rings, not 1,024.

define a way to limit mbuf cluster allocations to n in a code section

Why is this necessary? Why can't we let the driver allocate all available mbufs?

Because we want to avoid a situation where we exhaust all of our preallocated mbufs to fill populate a single ring. That's the reason we preallocate as much as we do today.

How do multi-queue NICs behave when some rx rings are empty? If a packet arrives on an empty rx ring, does the packet get dropped, or does it get queued to a different rx ring?

I've always assumed that the packet would get dropped if the ring to which it's steered doesn't have any available buffer space. That might not be true for all devices, but I wouldn't want to rely on that.

Jul 18 2022, 9:28 PM
vangyzen committed rG3ca4a3390356: bge: tell debugnet there are 2 rx rings, not 1,024 (authored by vangyzen).
bge: tell debugnet there are 2 rx rings, not 1,024
Jul 18 2022, 9:08 PM
vangyzen closed D35845: bge: tell debugnet there are 2 rx rings, not 1,024.
Jul 18 2022, 9:08 PM