Page MenuHomeFreeBSD

vangyzen (Eric van Gyzen)
User

Projects

User Details

User Since
Jun 2 2015, 9:23 PM (339 w, 2 d)

Recent Activity

Oct 1 2021

vangyzen committed R10:35e4527e88d3: sem_clockwait_np test: fix usage of ATF API (authored by vangyzen).
sem_clockwait_np test: fix usage of ATF API
Oct 1 2021, 4:44 PM
vangyzen committed R10:31466594cd09: sem_clockwait_np test: relax time constraint on VMs (authored by vangyzen).
sem_clockwait_np test: relax time constraint on VMs
Oct 1 2021, 4:43 PM
vangyzen committed R10:2334abfd01ba: sem test: move sem_clockwait_np tests into individual cases (authored by vangyzen).
sem test: move sem_clockwait_np tests into individual cases
Oct 1 2021, 4:43 PM

Aug 31 2021

vangyzen added a comment to D31491: Rpcbind: skip ipv6 link local if a request doesn't come from link local address.

I'll review when I'm healthy. @dab , feel free to commit without waiting for my review.

Aug 31 2021, 3:43 PM

Aug 25 2021

vangyzen closed D31622: ddb: do not assume that ffs is mounted with softdep.
Aug 25 2021, 2:03 AM
vangyzen committed R10:3b29c8b4bdb0: ddb: do not assume that ffs is mounted with softdep (authored by Keith Owens <keith.owens2@dell.com>).
ddb: do not assume that ffs is mounted with softdep
Aug 25 2021, 2:02 AM

Aug 20 2021

vangyzen requested review of D31622: ddb: do not assume that ffs is mounted with softdep.
Aug 20 2021, 7:05 PM

Aug 12 2021

vangyzen committed R10:080c6fdc0ce8: dumpon: fix build on some architectures (authored by vangyzen).
dumpon: fix build on some architectures
Aug 12 2021, 2:29 AM

Aug 11 2021

vangyzen committed R10:13a58148de17: netdump: send key before dump, in case dump fails (authored by vangyzen).
netdump: send key before dump, in case dump fails
Aug 11 2021, 8:55 PM
vangyzen committed R10:96f9bd46547d: dumpon: fix encrypted dumps after commit 372557d8c3d (authored by vangyzen).
dumpon: fix encrypted dumps after commit 372557d8c3d
Aug 11 2021, 8:55 PM
vangyzen closed D31453: netdump: send key before dump, in case dump fails.
Aug 11 2021, 8:55 PM
vangyzen closed D31452: dumpon: fix encrypted dumps after commit 372557d8c3d.
Aug 11 2021, 8:55 PM
vangyzen updated the diff for D31453: netdump: send key before dump, in case dump fails.
  • CR feedback: remove unused "key" local var
Aug 11 2021, 12:09 AM

Aug 10 2021

vangyzen added inline comments to D31453: netdump: send key before dump, in case dump fails.
Aug 10 2021, 11:41 PM
vangyzen added inline comments to D31453: netdump: send key before dump, in case dump fails.
Aug 10 2021, 5:26 PM
vangyzen added inline comments to D31453: netdump: send key before dump, in case dump fails.
Aug 10 2021, 5:21 PM
vangyzen updated the diff for D31453: netdump: send key before dump, in case dump fails.
  • CR feedback: call cleanup on error paths
Aug 10 2021, 5:20 PM
vangyzen updated the diff for D31452: dumpon: fix encrypted dumps after commit 372557d8c3d.
  • CR feedback: check key size in parent
Aug 10 2021, 4:52 PM

Aug 7 2021

vangyzen requested review of D31453: netdump: send key before dump, in case dump fails.
Aug 7 2021, 2:10 PM
vangyzen requested review of D31452: dumpon: fix encrypted dumps after commit 372557d8c3d.
Aug 7 2021, 2:08 PM

Aug 2 2021

vangyzen closed D31384: Fix lockstat:::thread-spin dtrace probe with LOCK_PROFILING.
Aug 2 2021, 7:46 PM
vangyzen committed R10:428624130abf: Fix lockstat:::thread-spin dtrace probe with LOCK_PROFILING (authored by vangyzen).
Fix lockstat:::thread-spin dtrace probe with LOCK_PROFILING
Aug 2 2021, 7:46 PM
vangyzen requested review of D31384: Fix lockstat:::thread-spin dtrace probe with LOCK_PROFILING.
Aug 2 2021, 6:59 PM

Jul 28 2021

vangyzen accepted D31327: debugnet_handle_arp(): Fix false-positive assertion for dp_state.
Jul 28 2021, 1:33 PM

Jul 27 2021

vangyzen accepted D31327: debugnet_handle_arp(): Fix false-positive assertion for dp_state.
Jul 27 2021, 11:03 PM

Jul 23 2021

vangyzen accepted D30988: clock_gettime: Add Linux aliases for CLOCK_*.
Jul 23 2021, 7:19 PM
vangyzen committed R10:9666cda9764a: aio_md_test: label the md (authored by vangyzen).
aio_md_test: label the md
Jul 23 2021, 2:21 PM
vangyzen committed R10:ea0e1b19f232: aio_md_test: NUL-terminate result of readlink (authored by vangyzen).
aio_md_test: NUL-terminate result of readlink
Jul 23 2021, 2:21 PM
vangyzen committed R10:c6f92e64b614: aio_md_test: fix cleanup (authored by vangyzen).
aio_md_test: fix cleanup
Jul 23 2021, 2:20 PM

Jul 1 2021

vangyzen accepted D30988: clock_gettime: Add Linux aliases for CLOCK_*.
Jul 1 2021, 9:30 PM
vangyzen added inline comments to D30960: veriexec: handle VE_FINGERPRINT_IGNORE from vectx_open.
Jul 1 2021, 1:18 AM

Jun 30 2021

vangyzen requested review of D30962: veriexec: fix two compat issues in kernel manifest parser.
Jun 30 2021, 2:54 PM
vangyzen updated subscribers of D30960: veriexec: handle VE_FINGERPRINT_IGNORE from vectx_open.
Jun 30 2021, 2:41 PM
vangyzen requested review of D30960: veriexec: handle VE_FINGERPRINT_IGNORE from vectx_open.
Jun 30 2021, 2:39 PM

May 27 2021

vangyzen committed R10:427f12f150e8: libprocstat kstack: fix race with thread creation (authored by vangyzen).
libprocstat kstack: fix race with thread creation
May 27 2021, 4:45 PM

May 25 2021

vangyzen accepted D30414: libsa: Fix infinite loop in bzipfs & gzipfs.
May 25 2021, 10:09 PM
vangyzen accepted D30441: pciconf: Fix up pciconf -lc output.
May 25 2021, 9:42 PM
vangyzen added inline comments to D30414: libsa: Fix infinite loop in bzipfs & gzipfs.
May 25 2021, 9:40 PM

Apr 30 2021

vangyzen accepted D30060: Flag hn and storvsc statistics with CTLFLAG_STATS..
Apr 30 2021, 6:37 PM
vangyzen committed R10:2f32a971b7f9: Wait longer for a previous IPI to be sent (authored by vangyzen).
Wait longer for a previous IPI to be sent
Apr 30 2021, 6:34 PM
vangyzen closed D29942: Wait longer for a previous IPI to be sent.
Apr 30 2021, 6:34 PM
vangyzen committed R10:eda28feb2e07: EFI secure boot VECTX related changes (authored by vangyzen).
EFI secure boot VECTX related changes
Apr 30 2021, 6:13 PM
vangyzen closed D29993: EFI secure boot VECTX related changes.
Apr 30 2021, 6:13 PM
vangyzen updated the diff for D29942: Wait longer for a previous IPI to be sent.
  • __read_mostly
Apr 30 2021, 4:00 PM
vangyzen added a comment to D29942: Wait longer for a previous IPI to be sent.
In D29942#673010, @mav wrote:

It looks good to me. I am just thinking whether it worth to mark the variable as __read_mostly.

Apr 30 2021, 3:53 PM

Apr 29 2021

vangyzen added a comment to D29993: EFI secure boot VECTX related changes.

@sjg or @stevek If one of you could take a look, I'd appreciate it.

Apr 29 2021, 4:39 PM
vangyzen updated the diff for D29993: EFI secure boot VECTX related changes.
  • refactor VERIEXEC vars into new veriexec.mk
Apr 29 2021, 4:04 PM
vangyzen commandeered D29993: EFI secure boot VECTX related changes.

I'll finish this for Bret.

Apr 29 2021, 3:34 PM
vangyzen committed R10:ee8b757a949a: ipmi: support getting address from EFI (authored by yinlong.lu_dell.com).
ipmi: support getting address from EFI
Apr 29 2021, 3:26 PM
vangyzen closed D30007: ipmi: support getting address from EFI.
Apr 29 2021, 3:25 PM
vangyzen requested changes to D29993: EFI secure boot VECTX related changes.
Apr 29 2021, 2:57 PM

Apr 28 2021

vangyzen accepted D30007: ipmi: support getting address from EFI.
Apr 28 2021, 9:31 PM

Apr 27 2021

vangyzen accepted D29993: EFI secure boot VECTX related changes.
Apr 27 2021, 8:51 PM
vangyzen added inline comments to D30007: ipmi: support getting address from EFI.
Apr 27 2021, 3:33 PM

Apr 26 2021

vangyzen added a comment to D29942: Wait longer for a previous IPI to be sent.

@mav How does this look?

Apr 26 2021, 3:45 PM
vangyzen added inline comments to D29942: Wait longer for a previous IPI to be sent.
Apr 26 2021, 3:38 PM
vangyzen updated the diff for D29942: Wait longer for a previous IPI to be sent.
  • xAPIC only
Apr 26 2021, 3:36 PM
vangyzen updated the diff for D29942: Wait longer for a previous IPI to be sent.
  • naming is important
Apr 26 2021, 3:34 PM
vangyzen retitled D29942: Wait longer for a previous IPI to be sent from Wait forever for a previous IPI to be sent to Wait longer for a previous IPI to be sent.
Apr 26 2021, 3:12 PM
vangyzen updated the diff for D29942: Wait longer for a previous IPI to be sent.
  • add sysctl/tunable and wait 1s by default
Apr 26 2021, 3:09 PM

Apr 23 2021

vangyzen added a comment to D29942: Wait longer for a previous IPI to be sent.
In D29942#671819, @mav wrote:

I don't have specific objections. I can't recall I ever saw this panic and not sure how the interrupt delivery can take more that 50ms. But it reminds me that we do have spinlock timeout, which is also not required. Do you see any benefits from this comparing to just increasing the timeout back to 1s as it was before f418f79ce299 to keep ability to debug misbehaving hardware?

Apr 23 2021, 4:32 PM

Apr 22 2021

vangyzen requested review of D29942: Wait longer for a previous IPI to be sent.
Apr 22 2021, 10:46 PM

Apr 7 2021

vangyzen committed R10:f689cb23b278: ipmi,smbios: move smbios_walk_table to smbios.h (authored by greg_unrelenting.technology).
ipmi,smbios: move smbios_walk_table to smbios.h
Apr 7 2021, 8:09 PM
vangyzen closed D29270: ipmi,smbios: move smbios_walk_table to smbios.h.
Apr 7 2021, 8:09 PM
vangyzen committed R10:a29bff7a5216: smbios: support getting address from EFI (authored by greg_unrelenting.technology).
smbios: support getting address from EFI
Apr 7 2021, 7:54 PM
vangyzen closed D29276: smbios: support getting address from EFI.
Apr 7 2021, 7:53 PM
vangyzen added a comment to D29276: smbios: support getting address from EFI.

smbios still attaches on a bhyve VM running FreeBSD main plus this change, booting in Legacy BIOS mode. The device address did not change, of course.

Apr 7 2021, 7:39 PM
vangyzen committed R10:5984246f9626: Loader: support booting OS from memory disk (MD) (authored by yongbo.yao_dell.com).
Loader: support booting OS from memory disk (MD)
Apr 7 2021, 6:43 PM
vangyzen closed D29512: Loader: support booting OS from memory disk (MD).
Apr 7 2021, 6:42 PM
vangyzen accepted D29512: Loader: support booting OS from memory disk (MD).
Apr 7 2021, 6:29 PM
vangyzen committed R10:12db51d20823: uefisign: handle empty sections (authored by vangyzen).
uefisign: handle empty sections
Apr 7 2021, 4:25 PM
vangyzen closed D29606: uefisign: handle empty sections.
Apr 7 2021, 4:25 PM
vangyzen updated the test plan for D29606: uefisign: handle empty sections.
Apr 7 2021, 4:21 PM

Apr 6 2021

vangyzen closed D29605: uefisign: fix handling of errors from child proc.
Apr 6 2021, 5:14 PM
vangyzen committed R10:9e6158d27482: uefisign: fix handling of errors from child proc (authored by vangyzen).
uefisign: fix handling of errors from child proc
Apr 6 2021, 5:14 PM
vangyzen added a comment to D29606: uefisign: handle empty sections.

No objections, but please note that 'uefisign -V' doesn't actually verify the signature. It would be useful to try to actually boot the signed binary.

Apr 6 2021, 3:32 PM
vangyzen requested review of D29606: uefisign: handle empty sections.
Apr 6 2021, 2:58 PM
vangyzen requested review of D29605: uefisign: fix handling of errors from child proc.
Apr 6 2021, 2:53 PM
vangyzen added a comment to D29512: Loader: support booting OS from memory disk (MD).
In D29512#661559, @imp wrote:

I'm fine with this, but think we need to document it somewhere and also discuss any limitations relative to other boot methods there might be.

Thanks Warner. Should it be documented to loader.8? if so , can I update it in this patch?

Apr 6 2021, 2:32 PM

Apr 2 2021

vangyzen accepted D29276: smbios: support getting address from EFI.

@greg_unrelenting.technology Please look back over the comments from @ambrisko . In particular, I'd like to see testing on a non-UEFI system.

Apr 2 2021, 3:24 PM

Mar 31 2021

vangyzen accepted D29276: smbios: support getting address from EFI.
Mar 31 2021, 10:12 PM
vangyzen added a comment to D29276: smbios: support getting address from EFI.

I'm not sure what happens if efirt is loaded on a non-UEFI system?

Mar 31 2021, 3:47 PM
vangyzen accepted D29270: ipmi,smbios: move smbios_walk_table to smbios.h.
Mar 31 2021, 3:30 PM
vangyzen accepted D29512: Loader: support booting OS from memory disk (MD).

I would like a review from at least one of these fine folks: @imp @kevans @tsoome

Mar 31 2021, 3:17 PM

Mar 27 2021

vangyzen accepted D29438: bhyve: Enable virtio-scsi legacy config parsing..

This fixes it. Thanks for the quick help, John.

Mar 27 2021, 1:52 AM

Mar 7 2021

vangyzen committed R10:0424d9ebeb17: decryptcore: do not include sys/sysctl.h (authored by vangyzen).
decryptcore: do not include sys/sysctl.h
Mar 7 2021, 11:31 PM
vangyzen committed R10:576313b983dc: dumpon: do not print errno for resolver failure (authored by vangyzen).
dumpon: do not print errno for resolver failure
Mar 7 2021, 11:27 PM

Mar 5 2021

vangyzen committed R10:8b434feedfa9: Only set delayed inval for procs using PTI (authored by vangyzen).
Only set delayed inval for procs using PTI
Mar 5 2021, 7:21 PM
vangyzen closed D29094: Only set delayed inval for procs using PTI.
Mar 5 2021, 7:20 PM
vangyzen requested review of D29094: Only set delayed inval for procs using PTI.
Mar 5 2021, 4:43 PM

Mar 3 2021

vangyzen accepted D29045: Don't use sleeping allocations for ufs dirhash blocks when holding directory vnode.
Mar 3 2021, 7:51 PM

Feb 25 2021

vangyzen accepted D28926: Close races in vm object chain traversal for unlock.
Feb 25 2021, 7:26 PM

Feb 15 2021

vangyzen accepted D28550: libpmc: fix linking with C programs.
Feb 15 2021, 10:01 PM
vangyzen accepted D28659: ddb: reliably fail with ambiguous commands.
Feb 15 2021, 3:24 PM

Jan 27 2021

vangyzen accepted D28375: Fix getblk() with GB_NOCREAT returning false-negatives..
Jan 27 2021, 8:10 PM

Jan 1 2021

vangyzen committed R10:670d2ad820c7: efi loader: fix typos in a comment (authored by vangyzen).
efi loader: fix typos in a comment
Jan 1 2021, 5:39 PM

Dec 17 2020

vangyzen accepted D27620: acpi: Ensure that the affinity table is maximally coalesced.
Dec 17 2020, 7:01 PM
vangyzen added inline comments to D27620: acpi: Ensure that the affinity table is maximally coalesced.
Dec 17 2020, 5:30 PM

Dec 11 2020

vangyzen committed rS368553: decryptcore: preload OpenSSL error strings; seed PRNG.
decryptcore: preload OpenSSL error strings; seed PRNG
Dec 11 2020, 2:33 PM

Dec 10 2020

vangyzen accepted D27546: Avoid vm_free_count() for physmem available before VM ACPI walk..
Dec 10 2020, 5:24 PM