Page MenuHomeFreeBSD

vangyzen (Eric van Gyzen)
User

Projects

User Details

User Since
Jun 2 2015, 9:23 PM (315 w, 3 d)

Recent Activity

Thu, May 27

vangyzen committed R10:427f12f150e8: libprocstat kstack: fix race with thread creation (authored by vangyzen).
libprocstat kstack: fix race with thread creation
Thu, May 27, 4:45 PM

Tue, May 25

vangyzen accepted D30414: libsa: Fix infinite loop in bzipfs & gzipfs.
Tue, May 25, 10:09 PM
vangyzen accepted D30441: pciconf: Fix up pciconf -lc output.
Tue, May 25, 9:42 PM
vangyzen added inline comments to D30414: libsa: Fix infinite loop in bzipfs & gzipfs.
Tue, May 25, 9:40 PM

Apr 30 2021

vangyzen accepted D30060: Flag hn and storvsc statistics with CTLFLAG_STATS..
Apr 30 2021, 6:37 PM
vangyzen committed R10:2f32a971b7f9: Wait longer for a previous IPI to be sent (authored by vangyzen).
Wait longer for a previous IPI to be sent
Apr 30 2021, 6:34 PM
vangyzen closed D29942: Wait longer for a previous IPI to be sent.
Apr 30 2021, 6:34 PM
vangyzen committed R10:eda28feb2e07: EFI secure boot VECTX related changes (authored by vangyzen).
EFI secure boot VECTX related changes
Apr 30 2021, 6:13 PM
vangyzen closed D29993: EFI secure boot VECTX related changes.
Apr 30 2021, 6:13 PM
vangyzen updated the diff for D29942: Wait longer for a previous IPI to be sent.
  • __read_mostly
Apr 30 2021, 4:00 PM
vangyzen added a comment to D29942: Wait longer for a previous IPI to be sent.
In D29942#673010, @mav wrote:

It looks good to me. I am just thinking whether it worth to mark the variable as __read_mostly.

Apr 30 2021, 3:53 PM

Apr 29 2021

vangyzen added a comment to D29993: EFI secure boot VECTX related changes.

@sjg or @stevek If one of you could take a look, I'd appreciate it.

Apr 29 2021, 4:39 PM
vangyzen updated the diff for D29993: EFI secure boot VECTX related changes.
  • refactor VERIEXEC vars into new veriexec.mk
Apr 29 2021, 4:04 PM
vangyzen commandeered D29993: EFI secure boot VECTX related changes.

I'll finish this for Bret.

Apr 29 2021, 3:34 PM
vangyzen committed R10:ee8b757a949a: ipmi: support getting address from EFI (authored by yinlong.lu_dell.com).
ipmi: support getting address from EFI
Apr 29 2021, 3:26 PM
vangyzen closed D30007: ipmi: support getting address from EFI.
Apr 29 2021, 3:25 PM
vangyzen requested changes to D29993: EFI secure boot VECTX related changes.
Apr 29 2021, 2:57 PM

Apr 28 2021

vangyzen accepted D30007: ipmi: support getting address from EFI.
Apr 28 2021, 9:31 PM

Apr 27 2021

vangyzen accepted D29993: EFI secure boot VECTX related changes.
Apr 27 2021, 8:51 PM
vangyzen added inline comments to D30007: ipmi: support getting address from EFI.
Apr 27 2021, 3:33 PM

Apr 26 2021

vangyzen added a comment to D29942: Wait longer for a previous IPI to be sent.

@mav How does this look?

Apr 26 2021, 3:45 PM
vangyzen added inline comments to D29942: Wait longer for a previous IPI to be sent.
Apr 26 2021, 3:38 PM
vangyzen updated the diff for D29942: Wait longer for a previous IPI to be sent.
  • xAPIC only
Apr 26 2021, 3:36 PM
vangyzen updated the diff for D29942: Wait longer for a previous IPI to be sent.
  • naming is important
Apr 26 2021, 3:34 PM
vangyzen retitled D29942: Wait longer for a previous IPI to be sent from Wait forever for a previous IPI to be sent to Wait longer for a previous IPI to be sent.
Apr 26 2021, 3:12 PM
vangyzen updated the diff for D29942: Wait longer for a previous IPI to be sent.
  • add sysctl/tunable and wait 1s by default
Apr 26 2021, 3:09 PM

Apr 23 2021

vangyzen added a comment to D29942: Wait longer for a previous IPI to be sent.
In D29942#671819, @mav wrote:

I don't have specific objections. I can't recall I ever saw this panic and not sure how the interrupt delivery can take more that 50ms. But it reminds me that we do have spinlock timeout, which is also not required. Do you see any benefits from this comparing to just increasing the timeout back to 1s as it was before f418f79ce299 to keep ability to debug misbehaving hardware?

Apr 23 2021, 4:32 PM

Apr 22 2021

vangyzen requested review of D29942: Wait longer for a previous IPI to be sent.
Apr 22 2021, 10:46 PM

Apr 7 2021

vangyzen committed R10:f689cb23b278: ipmi,smbios: move smbios_walk_table to smbios.h (authored by greg_unrelenting.technology).
ipmi,smbios: move smbios_walk_table to smbios.h
Apr 7 2021, 8:09 PM
vangyzen closed D29270: ipmi,smbios: move smbios_walk_table to smbios.h.
Apr 7 2021, 8:09 PM
vangyzen committed R10:a29bff7a5216: smbios: support getting address from EFI (authored by greg_unrelenting.technology).
smbios: support getting address from EFI
Apr 7 2021, 7:54 PM
vangyzen closed D29276: smbios: support getting address from EFI.
Apr 7 2021, 7:53 PM
vangyzen added a comment to D29276: smbios: support getting address from EFI.

smbios still attaches on a bhyve VM running FreeBSD main plus this change, booting in Legacy BIOS mode. The device address did not change, of course.

Apr 7 2021, 7:39 PM
vangyzen committed R10:5984246f9626: Loader: support booting OS from memory disk (MD) (authored by yongbo.yao_dell.com).
Loader: support booting OS from memory disk (MD)
Apr 7 2021, 6:43 PM
vangyzen closed D29512: Loader: support booting OS from memory disk (MD).
Apr 7 2021, 6:42 PM
vangyzen accepted D29512: Loader: support booting OS from memory disk (MD).
Apr 7 2021, 6:29 PM
vangyzen committed R10:12db51d20823: uefisign: handle empty sections (authored by vangyzen).
uefisign: handle empty sections
Apr 7 2021, 4:25 PM
vangyzen closed D29606: uefisign: handle empty sections.
Apr 7 2021, 4:25 PM
vangyzen updated the test plan for D29606: uefisign: handle empty sections.
Apr 7 2021, 4:21 PM

Apr 6 2021

vangyzen closed D29605: uefisign: fix handling of errors from child proc.
Apr 6 2021, 5:14 PM
vangyzen committed R10:9e6158d27482: uefisign: fix handling of errors from child proc (authored by vangyzen).
uefisign: fix handling of errors from child proc
Apr 6 2021, 5:14 PM
vangyzen added a comment to D29606: uefisign: handle empty sections.

No objections, but please note that 'uefisign -V' doesn't actually verify the signature. It would be useful to try to actually boot the signed binary.

Apr 6 2021, 3:32 PM
vangyzen requested review of D29606: uefisign: handle empty sections.
Apr 6 2021, 2:58 PM
vangyzen requested review of D29605: uefisign: fix handling of errors from child proc.
Apr 6 2021, 2:53 PM
vangyzen added a comment to D29512: Loader: support booting OS from memory disk (MD).
In D29512#661559, @imp wrote:

I'm fine with this, but think we need to document it somewhere and also discuss any limitations relative to other boot methods there might be.

Thanks Warner. Should it be documented to loader.8? if so , can I update it in this patch?

Apr 6 2021, 2:32 PM

Apr 2 2021

vangyzen accepted D29276: smbios: support getting address from EFI.

@greg_unrelenting.technology Please look back over the comments from @ambrisko . In particular, I'd like to see testing on a non-UEFI system.

Apr 2 2021, 3:24 PM

Mar 31 2021

vangyzen accepted D29276: smbios: support getting address from EFI.
Mar 31 2021, 10:12 PM
vangyzen added a comment to D29276: smbios: support getting address from EFI.

I'm not sure what happens if efirt is loaded on a non-UEFI system?

Mar 31 2021, 3:47 PM
vangyzen accepted D29270: ipmi,smbios: move smbios_walk_table to smbios.h.
Mar 31 2021, 3:30 PM
vangyzen accepted D29512: Loader: support booting OS from memory disk (MD).

I would like a review from at least one of these fine folks: @imp @kevans @tsoome

Mar 31 2021, 3:17 PM

Mar 27 2021

vangyzen accepted D29438: bhyve: Enable virtio-scsi legacy config parsing..

This fixes it. Thanks for the quick help, John.

Mar 27 2021, 1:52 AM

Mar 7 2021

vangyzen committed R10:0424d9ebeb17: decryptcore: do not include sys/sysctl.h (authored by vangyzen).
decryptcore: do not include sys/sysctl.h
Mar 7 2021, 11:31 PM
vangyzen committed R10:576313b983dc: dumpon: do not print errno for resolver failure (authored by vangyzen).
dumpon: do not print errno for resolver failure
Mar 7 2021, 11:27 PM

Mar 5 2021

vangyzen committed R10:8b434feedfa9: Only set delayed inval for procs using PTI (authored by vangyzen).
Only set delayed inval for procs using PTI
Mar 5 2021, 7:21 PM
vangyzen closed D29094: Only set delayed inval for procs using PTI.
Mar 5 2021, 7:20 PM
vangyzen requested review of D29094: Only set delayed inval for procs using PTI.
Mar 5 2021, 4:43 PM

Mar 3 2021

vangyzen accepted D29045: Don't use sleeping allocations for ufs dirhash blocks when holding directory vnode.
Mar 3 2021, 7:51 PM

Feb 25 2021

vangyzen accepted D28926: Close races in vm object chain traversal for unlock.
Feb 25 2021, 7:26 PM

Feb 15 2021

vangyzen accepted D28550: libpmc: fix linking with C programs.
Feb 15 2021, 10:01 PM
vangyzen accepted D28659: ddb: reliably fail with ambiguous commands.
Feb 15 2021, 3:24 PM

Jan 27 2021

vangyzen accepted D28375: Fix getblk() with GB_NOCREAT returning false-negatives..
Jan 27 2021, 8:10 PM

Jan 1 2021

vangyzen committed R10:670d2ad820c7: efi loader: fix typos in a comment (authored by vangyzen).
efi loader: fix typos in a comment
Jan 1 2021, 5:39 PM

Dec 17 2020

vangyzen accepted D27620: acpi: Ensure that the affinity table is maximally coalesced.
Dec 17 2020, 7:01 PM
vangyzen added inline comments to D27620: acpi: Ensure that the affinity table is maximally coalesced.
Dec 17 2020, 5:30 PM

Dec 11 2020

vangyzen committed rS368553: decryptcore: preload OpenSSL error strings; seed PRNG.
decryptcore: preload OpenSSL error strings; seed PRNG
Dec 11 2020, 2:33 PM

Dec 10 2020

vangyzen accepted D27546: Avoid vm_free_count() for physmem available before VM ACPI walk..
Dec 10 2020, 5:24 PM

Nov 30 2020

vangyzen accepted D27184: fts_read: Handle error from a NULL return better..
Nov 30 2020, 9:42 PM

Nov 20 2020

vangyzen added a comment to D26973: Switch C.UTF-8 as the default locales.

After this change, perl freaks out like this:

perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LC_ALL = (unset),
LANG = "C.UTF-8"

are supported and installed on your system.

perl: warning: Falling back to the standard locale ("C").
panic: locale.c: 4560: Could not change LC_CTYPE locale to C.UTF-8, errno=22

Is this expected? This is perl5-5.32.0

Thanks

My issue appears to have been caused by building with WITHOUT_LOCALES=YES. Removing that makes perl happy again. Sort of odd that nothing else cared.

Nov 20 2020, 6:20 PM

Nov 15 2020

vangyzen accepted D27160: _umtx_op: document UMTX_OP_SEM2_WAIT copyout behavior.
Nov 15 2020, 9:38 PM

Oct 27 2020

vangyzen added inline comments to D26981: Note that sys/systm.h is special too.
Oct 27 2020, 9:47 PM
vangyzen accepted D26981: Note that sys/systm.h is special too.
Oct 27 2020, 9:45 PM
vangyzen accepted D26981: Note that sys/systm.h is special too.
Oct 27 2020, 9:31 PM
vangyzen accepted D26973: Switch C.UTF-8 as the default locales.
Oct 27 2020, 9:29 PM

Oct 26 2020

vangyzen closed D26895: db_search_symbol: prevent pollution from bogus symbols.
Oct 26 2020, 4:43 PM
vangyzen committed rS367059: db_search_symbol: prevent pollution from bogus symbols.
db_search_symbol: prevent pollution from bogus symbols
Oct 26 2020, 4:43 PM

Oct 25 2020

vangyzen added a comment to D26817: cdefs.h: remove intel_compiler support.
In D26817#601100, @imp wrote:
In D26817#601097, @pfg wrote:

First of all: thanks!

I should mention this was actually for a hacked linux binary-based intel compiler.

There exists a native FreeBSD [[ https://software.intel.com/content/www/us/en/develop/tools/system-studio/freebsd.html | Intel System Studio ]]compiler that claims to be GCC compatible which may just work (I tihnk it may be based on clang, but I am not sure).

I keep hearing rumors of this item, but never have been able to get a copy through my friends at Intel. I'll have to send a few emails out to see if I can see if I can get access to one, though it's a fairly low propriety. I suspect, based on a lot of things, that this doesn't actually exist, but I'll poke and prod anyway.

Oct 25 2020, 7:36 PM

Oct 23 2020

vangyzen added a comment to D26895: db_search_symbol: prevent pollution from bogus symbols.

So the comparison with PAGE_SIZE is arbitrary, right? There's no reason the aforementioned code could emit symbols with a value between, say, PAGE_SIZE and PAGE_SIZE * 2?

Oct 23 2020, 3:08 PM

Oct 22 2020

vangyzen updated the diff for D26895: db_search_symbol: prevent pollution from bogus symbols.
  • borrow Anton's comment
Oct 22 2020, 7:51 PM

Oct 21 2020

vangyzen updated the summary of D26895: db_search_symbol: prevent pollution from bogus symbols.
Oct 21 2020, 8:10 PM
vangyzen added reviewers for D26895: db_search_symbol: prevent pollution from bogus symbols: rang_acm.org, bdrewery, markj.
Oct 21 2020, 8:10 PM
vangyzen requested review of D26895: db_search_symbol: prevent pollution from bogus symbols.
Oct 21 2020, 8:09 PM
vangyzen closed D26893: ubuf is too small to hold a human readable 64 bit value.
Oct 21 2020, 5:12 PM
vangyzen committed rS366914: ntb_tool: ubuf is too small to hold a human readable 64 bit value.
ntb_tool: ubuf is too small to hold a human readable 64 bit value
Oct 21 2020, 5:12 PM
vangyzen accepted D26893: ubuf is too small to hold a human readable 64 bit value.
Oct 21 2020, 5:08 PM

Oct 18 2020

vangyzen accepted D26683: ntb: Add Xeon Gen3 support.
Oct 18 2020, 10:18 PM

Oct 16 2020

vangyzen accepted D26683: ntb: Add Xeon Gen3 support.

I'm not an NTB expert, but LGTM.

Oct 16 2020, 7:04 PM
vangyzen accepted D26819: cdefs: require gcc 4.2 or later.
Oct 16 2020, 6:29 PM
vangyzen accepted D26818: cdefs: Assume __GNUC__ defined.
Oct 16 2020, 6:25 PM
vangyzen accepted D26817: cdefs.h: remove intel_compiler support.
Oct 16 2020, 6:24 PM

Oct 1 2020

vangyzen committed rS366346: fix setitimer test for returned it_value.
fix setitimer test for returned it_value
Oct 1 2020, 9:53 PM
vangyzen closed D26445: fix setitimer test for returned it_value.
Oct 1 2020, 9:53 PM
vangyzen committed rS366345: zgrep: fix exit status with multiple files.
zgrep: fix exit status with multiple files
Oct 1 2020, 9:48 PM
vangyzen closed D26616: zgrep: fix exit status with multiple files.
Oct 1 2020, 9:48 PM
vangyzen added inline comments to D26616: zgrep: fix exit status with multiple files.
Oct 1 2020, 9:44 PM

Sep 30 2020

vangyzen updated the test plan for D26616: zgrep: fix exit status with multiple files.
Sep 30 2020, 9:28 PM
vangyzen updated the test plan for D26616: zgrep: fix exit status with multiple files.
Sep 30 2020, 9:24 PM
vangyzen requested review of D26616: zgrep: fix exit status with multiple files.
Sep 30 2020, 9:24 PM
vangyzen accepted D21788: Document the convention of adding a blank line before comments..
Sep 30 2020, 3:11 PM

Sep 18 2020

vangyzen committed rS365890: amd64 pmap_pkru_same: prev_ppr was always NULL.
amd64 pmap_pkru_same: prev_ppr was always NULL
Sep 18 2020, 8:53 PM
vangyzen added a comment to D26211: amd64 pmap_pkru_same: prev_ppr was always NULL.
In D26211#589162, @kib wrote:

I do not see why did not you committed the pmap.c change already. Please do, regardless of tests.

Sep 18 2020, 8:48 PM