Page MenuHomeFreeBSD

vangyzen (Eric van Gyzen)
User

Projects

User Details

User Since
Jun 2 2015, 9:23 PM (277 w, 6 d)

Recent Activity

Fri, Sep 18

vangyzen committed rS365890: amd64 pmap_pkru_same: prev_ppr was always NULL.
amd64 pmap_pkru_same: prev_ppr was always NULL
Fri, Sep 18, 8:53 PM
vangyzen added a comment to D26211: amd64 pmap_pkru_same: prev_ppr was always NULL.
In D26211#589162, @kib wrote:

I do not see why did not you committed the pmap.c change already. Please do, regardless of tests.

Fri, Sep 18, 8:48 PM
vangyzen added inline comments to D26445: fix setitimer test for returned it_value.
Fri, Sep 18, 5:15 PM
vangyzen committed rS365886: vm_ooffset_t is now unsigned.
vm_ooffset_t is now unsigned
Fri, Sep 18, 4:48 PM
vangyzen closed D26214: vm_ooffset_t is now unsigned.
Fri, Sep 18, 4:48 PM
vangyzen added a comment to D26211: amd64 pmap_pkru_same: prev_ppr was always NULL.

@kib Thank you for the detailed description. You practically wrote the test for me.

Fri, Sep 18, 4:39 PM
vangyzen updated the diff for D26211: amd64 pmap_pkru_same: prev_ppr was always NULL.
  • add pkru_test for the fix in pmap_pkru_same()
Fri, Sep 18, 4:36 PM

Thu, Sep 17

vangyzen committed rS365845: Fix additional memory leak in process_mapfile.
Fix additional memory leak in process_mapfile
Thu, Sep 17, 6:25 PM
vangyzen closed D26462: Fix additional memory leak in process_mapfile.
Thu, Sep 17, 6:25 PM
vangyzen accepted D26462: Fix additional memory leak in process_mapfile.
Thu, Sep 17, 6:02 PM

Tue, Sep 15

vangyzen added a reviewer for D26445: fix setitimer test for returned it_value: tests.
Tue, Sep 15, 7:55 PM
vangyzen requested review of D26445: fix setitimer test for returned it_value.
Tue, Sep 15, 7:55 PM

Tue, Sep 1

vangyzen committed rS365051: pmc: Fix freed internal location read.
pmc: Fix freed internal location read
Tue, Sep 1, 3:52 PM
vangyzen closed D26227: Fix freed internal location read.
Tue, Sep 1, 3:52 PM
vangyzen accepted D26227: Fix freed internal location read.
Tue, Sep 1, 3:50 PM

Mon, Aug 31

vangyzen updated the diff for D26214: vm_ooffset_t is now unsigned.
  • fix TOCTOU bug using tmpfs_pages_reserved
Mon, Aug 31, 8:09 PM
vangyzen closed D26228: Fix memory leak in dump_multicast_tables.
Mon, Aug 31, 4:19 PM
vangyzen committed rS364998: infiniband-diags: Fix memory leak in dump_multicast_tables.
infiniband-diags: Fix memory leak in dump_multicast_tables
Mon, Aug 31, 4:19 PM
vangyzen closed D26229: Appease Coverty.
Mon, Aug 31, 4:17 PM
vangyzen committed rS364997: infiniband: Appease Coverty.
infiniband: Appease Coverty
Mon, Aug 31, 4:17 PM
vangyzen closed D26230: Fix memory leak in process_mapfile.
Mon, Aug 31, 4:07 PM
vangyzen committed rS364996: libpmc: Fix memory leak in process_mapfile.
libpmc: Fix memory leak in process_mapfile
Mon, Aug 31, 4:07 PM
vangyzen closed D26231: Fix nfsrvd_locku memory leak.
Mon, Aug 31, 3:31 PM
vangyzen committed rS364992: Fix nfsrvd_locku memory leak.
Fix nfsrvd_locku memory leak
Mon, Aug 31, 3:31 PM
vangyzen closed D26233: Fix a possible dereference of a NULL pointer.
Mon, Aug 31, 3:26 PM
vangyzen committed rS364991: opensm: Fix a possible dereference of a NULL pointer.
opensm: Fix a possible dereference of a NULL pointer
Mon, Aug 31, 3:26 PM
vangyzen closed D26145: Overrunning array fix.
Mon, Aug 31, 3:03 PM
vangyzen committed rS364989: jedec_dimm: fix array overrun.
jedec_dimm: fix array overrun
Mon, Aug 31, 3:03 PM

Aug 28 2020

vangyzen added inline comments to D26214: vm_ooffset_t is now unsigned.
Aug 28 2020, 8:26 PM
vangyzen updated the diff for D26214: vm_ooffset_t is now unsigned.
  • CR feedback
Aug 28 2020, 8:25 PM
vangyzen committed rS364935: vm_pageout_scan_active: ensure ps_delta is initialized.
vm_pageout_scan_active: ensure ps_delta is initialized
Aug 28 2020, 7:59 PM
vangyzen closed D26212: vm_pageout_scan_active: ensure ps_delta is initialized.
Aug 28 2020, 7:59 PM
vangyzen closed D26213: memstat_kvm_uma: fix reading of uma_zone_domain structures.
Aug 28 2020, 7:50 PM
vangyzen committed rS364933: memstat_kvm_uma: fix reading of uma_zone_domain structures.
memstat_kvm_uma: fix reading of uma_zone_domain structures
Aug 28 2020, 7:50 PM

Aug 27 2020

vangyzen added inline comments to D26212: vm_pageout_scan_active: ensure ps_delta is initialized.
Aug 27 2020, 4:15 PM
vangyzen updated the diff for D26212: vm_pageout_scan_active: ensure ps_delta is initialized.
  • move init to the right place
Aug 27 2020, 4:15 PM
vangyzen added inline comments to D26214: vm_ooffset_t is now unsigned.
Aug 27 2020, 3:30 PM
vangyzen requested review of D26214: vm_ooffset_t is now unsigned.
Aug 27 2020, 3:28 PM
vangyzen requested review of D26213: memstat_kvm_uma: fix reading of uma_zone_domain structures.
Aug 27 2020, 3:14 PM
vangyzen requested review of D26212: vm_pageout_scan_active: ensure ps_delta is initialized.
Aug 27 2020, 3:08 PM
vangyzen requested review of D26211: amd64 pmap_pkru_same: prev_ppr was always NULL.
Aug 27 2020, 3:05 PM

Aug 24 2020

vangyzen accepted D26145: Overrunning array fix.
Aug 24 2020, 2:32 PM

Aug 21 2020

vangyzen closed D26144: The condition can never be true.
Aug 21 2020, 7:35 PM
vangyzen committed rS364462: ixgbe: fix impossible condition.
ixgbe: fix impossible condition
Aug 21 2020, 7:34 PM
vangyzen accepted D26144: The condition can never be true.
Aug 21 2020, 7:29 PM
vangyzen closed D26141: Potential integer overflowing expression.
Aug 21 2020, 2:22 PM
vangyzen committed rS364457: amd64 pmap: potential integer overflowing expression.
amd64 pmap: potential integer overflowing expression
Aug 21 2020, 2:22 PM

Aug 18 2020

vangyzen accepted D26115: gdb(4): Support empty qSupported queries.
Aug 18 2020, 8:03 PM

Aug 4 2020

vangyzen committed rS363867: devinfo: add man page links.
devinfo: add man page links
Aug 4 2020, 9:09 PM
vangyzen committed rS363866: devinfo: fix memory leak on error paths.
devinfo: fix memory leak on error paths
Aug 4 2020, 9:06 PM

Jul 28 2020

vangyzen added a comment to D25530: Fix LOR with bpf detach.

I see the same LOR before and after the patch:

Jul 28 2020, 8:51 PM
vangyzen accepted D25859: vm_page_xbusy_claim(): Use atomics to update busy lock state..
Jul 28 2020, 4:22 PM

Jul 15 2020

vangyzen committed rS363221: Fix style in r363220.
Fix style in r363220
Jul 15 2020, 1:26 PM
vangyzen committed rS363220: Fix Coverity issues in OFED.
Fix Coverity issues in OFED
Jul 15 2020, 1:17 PM
vangyzen closed D25676: Fix Coverity issues in OFED.
Jul 15 2020, 1:17 PM
vangyzen updated the summary of D25676: Fix Coverity issues in OFED.
Jul 15 2020, 2:02 AM
vangyzen updated subscribers of D25676: Fix Coverity issues in OFED.
Jul 15 2020, 1:59 AM
vangyzen requested review of D25676: Fix Coverity issues in OFED.
Jul 15 2020, 1:56 AM

Jun 18 2020

vangyzen added a comment to D25312: Relax the rule against declaring variables in nested scopes..

One look at the beginning of a function definition and you have a good idea what the stack will look like. As opposed to when variables are declared somewhere later in the function.

Jun 18 2020, 4:09 PM
vangyzen added a comment to D25312: Relax the rule against declaring variables in nested scopes..
In D25312#558466, @dab wrote:
In D25312#558449, @jhb wrote:

BTW, one thing this leaves ambiguous is [whether] you can declare variables in the middle of blocks vs at the beginning. That is:

[...]

Place declarations at the start of blocks.

I could live with this. Although I don’t have an objection to _allowing_ declarations in line when it makes sense, I do think one can get carried away and overdo it.

Jun 18 2020, 3:55 PM
vangyzen accepted D25312: Relax the rule against declaring variables in nested scopes..

Long overdue. Thank you, Warner.

Jun 18 2020, 9:18 AM

Jun 12 2020

vangyzen committed rS362126: Honor db_pager_quit in some vm_object ddb commands.
Honor db_pager_quit in some vm_object ddb commands
Jun 12 2020, 9:53 PM
vangyzen committed rS362121: FPU init: allocate initial state from UMA to ensure alignment.
FPU init: allocate initial state from UMA to ensure alignment
Jun 12 2020, 9:18 PM
vangyzen closed D25098: Ensure alignment of allocation for FPU initial state.
Jun 12 2020, 9:15 PM
vangyzen committed rS362120: FPU: make xsave_area_desc static.
FPU: make xsave_area_desc static
Jun 12 2020, 9:15 PM
vangyzen committed rS362119: FPU init: Do potentially blocking operations before disabling interrupts.
FPU init: Do potentially blocking operations before disabling interrupts
Jun 12 2020, 9:15 PM
vangyzen added a comment to D25098: Ensure alignment of allocation for FPU initial state.

I was doing some more debugging in this area (on Isilon OneFS). I ran into an issue where uma_zcreate blocked (due to sx lock contention when creating sysctl oids) and bad things happened because interrupts were disabled.

Jun 12 2020, 2:35 PM
vangyzen updated the diff for D25098: Ensure alignment of allocation for FPU initial state.
  • Do potentially blocking operations before disabling interrupts.
  • Since I'm creating the uma zone first, allocate the initial state from it.
Jun 12 2020, 2:32 PM

Jun 3 2020

vangyzen added a comment to D25098: Ensure alignment of allocation for FPU initial state.

Hm, in some sense SSE/AVX vectors are fundamental types. 64-byte alignment is surprisingly large to me; do you know if that is that a cache-line constraint, or the size of an AVX-512 vector, or just its own special constraint? I'm just curious.

Jun 3 2020, 12:59 AM

Jun 2 2020

vangyzen added a comment to D25098: Ensure alignment of allocation for FPU initial state.

Doesn't malloc(9) align to at least sizeof(allocation) already?

Jun 2 2020, 9:11 PM
vangyzen added a comment to D25098: Ensure alignment of allocation for FPU initial state.
In D25098#552799, @kib wrote:

I suggest to create the FPU save area as the first thing in the fpuinitstate(), and then allocate from the zone instead of manually realigning.

Jun 2 2020, 12:03 AM

Jun 1 2020

vangyzen requested review of D25098: Ensure alignment of allocation for FPU initial state.
Jun 1 2020, 9:09 PM

May 28 2020

vangyzen committed rS361606: Add an UPDATING entry for r360964.
Add an UPDATING entry for r360964
May 28 2020, 10:05 PM
vangyzen committed rS361605: Revert part of r360964.
Revert part of r360964
May 28 2020, 9:56 PM

May 27 2020

vangyzen committed rS361559: libifconfig: remove redundant NULL check.
libifconfig: remove redundant NULL check
May 27 2020, 6:26 PM

May 12 2020

vangyzen committed rS360964: Remove tests for obsolete compilers in the build system.
Remove tests for obsolete compilers in the build system
May 12 2020, 3:23 PM
vangyzen closed D24802: Remove tests for obsolete compilers in the build system.
May 12 2020, 3:23 PM

May 11 2020

vangyzen updated the diff for D24802: Remove tests for obsolete compilers in the build system.
  • review feedback
May 11 2020, 3:22 PM
vangyzen added inline comments to D24802: Remove tests for obsolete compilers in the build system.
May 11 2020, 3:09 PM

May 10 2020

vangyzen added inline comments to D24802: Remove tests for obsolete compilers in the build system.
May 10 2020, 10:44 PM
vangyzen updated the diff for D24802: Remove tests for obsolete compilers in the build system.
  • remove unnecessary if-clang conditions
May 10 2020, 10:18 PM
vangyzen added inline comments to D24802: Remove tests for obsolete compilers in the build system.
May 10 2020, 10:14 PM
vangyzen requested review of D24802: Remove tests for obsolete compilers in the build system.
May 10 2020, 10:09 PM

May 1 2020

vangyzen accepted D24658: Set LG_VADDR to 48 on RISC-V..
May 1 2020, 10:18 PM
vangyzen accepted D24532: Fix various Coverity-detected errors in nvme driver.
May 1 2020, 9:28 PM

Apr 30 2020

vangyzen added inline comments to D24532: Fix various Coverity-detected errors in nvme driver.
Apr 30 2020, 11:39 PM

Apr 28 2020

vangyzen accepted D24608: dtrace tests: Support globbing for excludes.
Apr 28 2020, 9:59 PM
vangyzen added inline comments to D24608: dtrace tests: Support globbing for excludes.
Apr 28 2020, 9:36 PM

Apr 26 2020

vangyzen committed rS360328: Fix handling of NMIs from unknown sources (BMC, hypervisor).
Fix handling of NMIs from unknown sources (BMC, hypervisor)
Apr 26 2020, 12:41 AM
vangyzen closed D24558: Fix handling of NMIs from unknown sources (BMC, hypervisor).
Apr 26 2020, 12:41 AM

Apr 25 2020

vangyzen added inline comments to D24558: Fix handling of NMIs from unknown sources (BMC, hypervisor).
Apr 25 2020, 6:10 PM
vangyzen updated the diff for D24558: Fix handling of NMIs from unknown sources (BMC, hypervisor).
  • follow kib, take 2
Apr 25 2020, 6:09 PM
vangyzen updated the diff for D24558: Fix handling of NMIs from unknown sources (BMC, hypervisor).
  • follow kib's suggestion
Apr 25 2020, 1:44 PM

Apr 24 2020

vangyzen added inline comments to D24558: Fix handling of NMIs from unknown sources (BMC, hypervisor).
Apr 24 2020, 6:45 PM
vangyzen created D24558: Fix handling of NMIs from unknown sources (BMC, hypervisor).
Apr 24 2020, 4:45 PM
vangyzen closed D24522: Update jemalloc to version 5.2.1.
Apr 24 2020, 4:29 AM

Apr 23 2020

vangyzen committed rS360233: Update jemalloc to version 5.2.1.
Update jemalloc to version 5.2.1
Apr 23 2020, 11:58 PM

Apr 21 2020

vangyzen updated subscribers of D24522: Update jemalloc to version 5.2.1.

@acidburn0.pt_gmail.com: Are you Jason Evans, author of jemalloc?

Apr 21 2020, 2:53 PM
vangyzen updated the test plan for D24522: Update jemalloc to version 5.2.1.
Apr 21 2020, 2:51 PM
vangyzen added inline comments to D24522: Update jemalloc to version 5.2.1.
Apr 21 2020, 2:43 PM