Page MenuHomeFreeBSD

vangyzen (Eric van Gyzen)
User

Projects

User Details

User Since
Jun 2 2015, 9:23 PM (210 w, 4 d)

Recent Activity

Thu, Jun 13

vangyzen abandoned D20610: Integrate tcp-testsuite into kyua.

Abandoned in favor of https://github.com/freebsd-net/tcp-testsuite/pull/4#

Thu, Jun 13, 8:43 PM
vangyzen added a comment to D20610: Integrate tcp-testsuite into kyua.

If you add the tests directly in GH, feel free to request a review from me.

Thu, Jun 13, 1:59 PM

Tue, Jun 11

vangyzen updated the summary of D20610: Integrate tcp-testsuite into kyua.
Tue, Jun 11, 7:53 PM
vangyzen added a comment to D20610: Integrate tcp-testsuite into kyua.

The basic idea behind this review is fundamentally broken. We shouldn't be adding test cases to the base system that wrap a port which is itself just a bunch of test cases. Instead, the correct approach would be to add ATF test cases directly to the port, to be installed into /usr/local/tests/tcptestsuite. See devel/atf, devel/kyua, or devel/lutok for examples of ports that do that.

Tue, Jun 11, 7:52 PM
vangyzen updated subscribers of D20610: Integrate tcp-testsuite into kyua.
Tue, Jun 11, 5:32 PM
vangyzen created D20610: Integrate tcp-testsuite into kyua.
Tue, Jun 11, 5:29 PM
vangyzen created D20603: Update net/tcptestsuite to github commit f7a1844.
Tue, Jun 11, 3:44 PM

Thu, Jun 6

vangyzen added a comment to D20529: Fix calculation of vtscsi_max_nsegs.

Does this need urgent attention to get in 11.3?

Thu, Jun 6, 6:53 PM
vangyzen added a comment to D20529: Fix calculation of vtscsi_max_nsegs.

Wait, I think we should still have a seat belt in guests.

Thu, Jun 6, 4:47 PM
vangyzen added a comment to D20529: Fix calculation of vtscsi_max_nsegs.

If you change the config seg_max in bhyve to be VTSCSI_MAXSEG - 2, does that fix the issue?

I'll try that now.

Thu, Jun 6, 1:32 PM
vangyzen updated the diff for D20529: Fix calculation of vtscsi_max_nsegs.

Fix it in bhyve instead

Thu, Jun 6, 1:31 PM
vangyzen added a comment to D20529: Fix calculation of vtscsi_max_nsegs.

I believe seg_max is the number of segments in a SCSI command while...

Thu, Jun 6, 12:15 PM

Wed, Jun 5

vangyzen created D20529: Fix calculation of vtscsi_max_nsegs.
Wed, Jun 5, 9:43 PM

Tue, May 28

vangyzen accepted D20448: style.9: Codify tolerance for eliding blank lines.
Tue, May 28, 6:47 PM

Fri, May 24

vangyzen accepted D20401: Disable intr_storm_threshold mechanism by default.
Fri, May 24, 10:33 PM
vangyzen updated subscribers of D18930: Per-thread credentials.
Fri, May 24, 12:00 PM

May 10 2019

vangyzen added inline comments to D20206: netdump: Ref the interface we're attached to.
May 10 2019, 7:32 PM

Apr 12 2019

vangyzen updated the diff for D19426: post-commit hooks: Accept BZ URLs in PR lines.
  • Accept short URLs, too.
Apr 12 2019, 2:57 PM

Mar 8 2019

vangyzen added a comment to D19426: post-commit hooks: Accept BZ URLs in PR lines.

I would be comfortable with simply "https://bugs.freebsd.org/12344" as that can likely work forever.

Note that https://bugs.freebsd.org/12344 does work - we should accept either https://bugs.freebsd.org/bugzilla/show_bug.cgi?id= or https://bugs.freebsd.org/[0-9]+

Mar 8 2019, 9:17 PM
vangyzen updated subscribers of D19459: subversion: update commit message template to allow URLs in PR field.

https://bugs.freebsd.org/12345 redirects to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=12345. Wouldn't the first form be better? It's shorter and likely easier to map to whatever bug tracker we might move to after bugzilla (if we ever do change). It also looks more like the phabricator links.

Mar 8 2019, 3:52 PM

Mar 5 2019

vangyzen added inline comments to D19460: subversion: update commit message template to allow URLs in PR field.
Mar 5 2019, 7:32 PM
vangyzen updated the diff for D19459: subversion: update commit message template to allow URLs in PR field.

Just mention the URL in the comments.

Mar 5 2019, 7:09 PM
vangyzen updated the diff for D19460: subversion: update commit message template to allow URLs in PR field.

Just mention the URL in the comments.

Mar 5 2019, 7:07 PM
vangyzen added inline comments to D19459: subversion: update commit message template to allow URLs in PR field.
Mar 5 2019, 6:58 PM

Mar 4 2019

vangyzen added a comment to D19426: post-commit hooks: Accept BZ URLs in PR lines.

To keep the whole record in one place, here is the CGI script I mentioned:

Mar 4 2019, 9:08 PM
vangyzen added a comment to D19426: post-commit hooks: Accept BZ URLs in PR lines.

Check out rP154065.
All of the PRs linked there were filed in GNATS but were mapped over in BUGZILLA so they had the same numbers.
Had they been GNATS urls they would be more annoying to deal with IMO as the links would all be dead now. I realize this is an objective opinion.

Mar 4 2019, 8:20 PM
vangyzen updated the diff for D19426: post-commit hooks: Accept BZ URLs in PR lines.

$Id$ -> $FreeBSD$

Mar 4 2019, 8:02 PM
vangyzen added a comment to D19426: post-commit hooks: Accept BZ URLs in PR lines.

Missing is the change to the commit message template to update it to say URL instead of PRxxxx

Mar 4 2019, 8:02 PM
vangyzen added a comment to D19460: subversion: update commit message template to allow URLs in PR field.

D19459 covers subversion in the base system.

Mar 4 2019, 7:59 PM
vangyzen created D19460: subversion: update commit message template to allow URLs in PR field.
Mar 4 2019, 7:58 PM
vangyzen created D19459: subversion: update commit message template to allow URLs in PR field.
Mar 4 2019, 7:56 PM
vangyzen updated the summary of D19446: smp topology: remove groups containing a single CPU, which serve no purpose.
Mar 4 2019, 3:48 PM
vangyzen created D19446: smp topology: remove groups containing a single CPU, which serve no purpose.
Mar 4 2019, 3:48 PM

Mar 1 2019

vangyzen created D19426: post-commit hooks: Accept BZ URLs in PR lines.
Mar 1 2019, 8:31 PM

Feb 28 2019

vangyzen added inline comments to D13595: Reuse kern_proc_vmmap_resident() for procfs_map resident count..
Feb 28 2019, 9:49 PM

Feb 27 2019

vangyzen added inline comments to D13595: Reuse kern_proc_vmmap_resident() for procfs_map resident count..
Feb 27 2019, 8:07 PM

Feb 22 2019

vangyzen accepted D19165: CID 1332000: Logically dead code in sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c.
Feb 22 2019, 5:11 PM

Feb 1 2019

vangyzen committed rS343672: rtld: pacify -Wmaybe-uninitialized from gcc6.
rtld: pacify -Wmaybe-uninitialized from gcc6
Feb 1 2019, 11:17 PM
vangyzen committed rS343671: libm: squelch -Woverflow from gcc6.
libm: squelch -Woverflow from gcc6
Feb 1 2019, 11:16 PM

Dec 4 2018

vangyzen committed rS341508: altq: manual cleanup after r341507.
altq: manual cleanup after r341507
Dec 4 2018, 11:54 PM
vangyzen committed rS341507: altq: remove ALTQ3_COMPAT code.
altq: remove ALTQ3_COMPAT code
Dec 4 2018, 11:47 PM

Nov 30 2018

vangyzen committed rS341354: Maybe make gcc happy.
Maybe make gcc happy
Nov 30 2018, 11:50 PM
vangyzen committed rS341353: Fix reporting of SS_ONSTACK.
Fix reporting of SS_ONSTACK
Nov 30 2018, 10:47 PM
vangyzen closed D18347: Fix reporting of SS_ONSTACK.
Nov 30 2018, 10:47 PM
vangyzen committed rS341282: Include path for tmpfs objects in vm.objects sysctl.
Include path for tmpfs objects in vm.objects sysctl
Nov 30 2018, 5:02 AM
vangyzen added inline comments to D18347: Fix reporting of SS_ONSTACK.
Nov 30 2018, 4:55 AM
vangyzen retitled D18347: Fix reporting of SS_ONSTACK from Fix sigaltstack flags on some architectures to Fix reporting of SS_ONSTACK.
Nov 30 2018, 4:51 AM
vangyzen updated the diff for D18347: Fix reporting of SS_ONSTACK.
  • add sigaltstack SS_ONSTACK test
  • fix more style
  • MFH
Nov 30 2018, 4:44 AM
vangyzen committed rS341281: Add assertions and comment to vm_object_vnode().
Add assertions and comment to vm_object_vnode()
Nov 30 2018, 4:20 AM
vangyzen closed D2724: Include path for tmpfs objects in vm.objects sysctl.
Nov 30 2018, 4:20 AM
vangyzen committed rS341278: Use _thr_isthreaded() and _thr_setthreaded() wrappers.
Use _thr_isthreaded() and _thr_setthreaded() wrappers
Nov 30 2018, 3:04 AM
vangyzen committed rS341277: _thr_setthreaded() cannot fail; change return type to void.
_thr_setthreaded() cannot fail; change return type to void
Nov 30 2018, 3:04 AM

Nov 28 2018

vangyzen committed rS341166: MFC r340995.
MFC r340995
Nov 28 2018, 9:21 PM
vangyzen committed rS341165: MFC r340994.
MFC r340994
Nov 28 2018, 9:20 PM
vangyzen committed rS341153: MFS r341147.
MFS r341147
Nov 28 2018, 5:01 PM
vangyzen committed rS341149: MFS r341146.
MFS r341146
Nov 28 2018, 4:21 PM
vangyzen committed rS341147: MFC r340995.
MFC r340995
Nov 28 2018, 3:35 PM
vangyzen committed rS341146: MFC r340994.
MFC r340994
Nov 28 2018, 3:32 PM

Nov 27 2018

vangyzen committed rS341100: MFC r340409.
MFC r340409
Nov 27 2018, 10:34 PM
vangyzen committed rS341099: MFC r340409.
MFC r340409
Nov 27 2018, 10:34 PM
vangyzen committed rS341092: MFC r340345.
MFC r340345
Nov 27 2018, 7:48 PM
vangyzen committed rS341090: MFC r340328.
MFC r340328
Nov 27 2018, 7:44 PM
vangyzen committed rS341087: MFC r340257.
MFC r340257
Nov 27 2018, 7:41 PM
vangyzen committed rS341086: MFC r340257.
MFC r340257
Nov 27 2018, 7:41 PM

Nov 26 2018

vangyzen created D18347: Fix reporting of SS_ONSTACK.
Nov 26 2018, 9:49 PM
vangyzen committed rS340996: Remove superfluous bzero in getcontext/swapcontext/sendsig.
Remove superfluous bzero in getcontext/swapcontext/sendsig
Nov 26 2018, 8:57 PM
vangyzen committed rS340995: Prevent kernel stack disclosure in signal delivery.
Prevent kernel stack disclosure in signal delivery
Nov 26 2018, 8:53 PM
vangyzen committed rS340994: Prevent kernel stack disclosure in getcontext/swapcontext.
Prevent kernel stack disclosure in getcontext/swapcontext
Nov 26 2018, 8:53 PM

Nov 19 2018

vangyzen added a comment to D2724: Include path for tmpfs objects in vm.objects sysctl.

Reviving a review from 3.5 years ago, thanks to a reminder from @emaste...

Nov 19 2018, 10:24 PM
vangyzen updated the diff for D2724: Include path for tmpfs objects in vm.objects sysctl.
  • Include path for tmpfs objects in vm.objects sysctl
  • add assertion suggested by kib
Nov 19 2018, 10:17 PM

Nov 14 2018

vangyzen committed rS340447: MFC r340426 (by cem).
MFC r340426 (by cem)
Nov 14 2018, 10:05 PM
vangyzen committed rS340446: MFC r340425 (by cem).
MFC r340425 (by cem)
Nov 14 2018, 9:31 PM

Nov 13 2018

vangyzen committed rS340409: Make no assertions about lock state when the scheduler is stopped..
Make no assertions about lock state when the scheduler is stopped.
Nov 13 2018, 8:48 PM

Nov 11 2018

vangyzen committed rS340345: Fix daily mailq script for Postfix and daily_show_success="NO".
Fix daily mailq script for Postfix and daily_show_success="NO"
Nov 11 2018, 12:39 AM

Nov 10 2018

vangyzen committed rS340328: Update comment about 'universe' disk usage.
Update comment about 'universe' disk usage
Nov 10 2018, 7:09 PM

Nov 8 2018

vangyzen committed rS340257: in6_ifattach_linklocal: handle immediate removal of the new LLA.
in6_ifattach_linklocal: handle immediate removal of the new LLA
Nov 8 2018, 7:50 PM
vangyzen closed D17898: in6_ifattach_linklocal: handle immediate removal of the new LLA.
Nov 8 2018, 7:50 PM
vangyzen updated the diff for D17898: in6_ifattach_linklocal: handle immediate removal of the new LLA.
  • improve comment; add nd6log
Nov 8 2018, 7:37 PM
vangyzen added inline comments to D17898: in6_ifattach_linklocal: handle immediate removal of the new LLA.
Nov 8 2018, 7:37 PM
vangyzen added a comment to D17898: in6_ifattach_linklocal: handle immediate removal of the new LLA.

@dab This is Isilon internal bug 240643.

Nov 8 2018, 3:33 PM

Nov 7 2018

vangyzen updated subscribers of D17898: in6_ifattach_linklocal: handle immediate removal of the new LLA.
Nov 7 2018, 11:11 PM
vangyzen updated the summary of D17898: in6_ifattach_linklocal: handle immediate removal of the new LLA.
Nov 7 2018, 11:09 PM
vangyzen created D17898: in6_ifattach_linklocal: handle immediate removal of the new LLA.
Nov 7 2018, 11:07 PM

Nov 4 2018

vangyzen committed rS340127: Update expat to 2.2.6.
Update expat to 2.2.6
Nov 4 2018, 4:09 PM

Nov 2 2018

vangyzen committed rS340085: Tag expat 2.2.6.
Tag expat 2.2.6
Nov 2 2018, 10:12 PM
vangyzen committed rS340084: Vendor import of expat 2.2.6.
Vendor import of expat 2.2.6
Nov 2 2018, 10:10 PM

Oct 30 2018

vangyzen committed rS339917: Always stop the scheduler when entering kdb.
Always stop the scheduler when entering kdb
Oct 30 2018, 2:54 PM
vangyzen closed D17687: Always stop the scheduler when entering kdb.
Oct 30 2018, 2:54 PM

Oct 29 2018

vangyzen added a comment to D17687: Always stop the scheduler when entering kdb.

It's an Isilon command. It uses non-DDB code that locks a mutex. In that sense, yes, it's poorly written, but I'd rather relax that notion and allow mutexes (and therefore more "normal", non-DDB) code to be used. Ideally, there would be DDB code for everything we need; in practice, of course, there isn't.

Oct 29 2018, 9:15 PM
vangyzen added a comment to D17687: Always stop the scheduler when entering kdb.

I plan to commit this soon, unless there are any objections. (I don't see any above.)

Oct 29 2018, 8:46 PM

Oct 25 2018

vangyzen added a comment to D17687: Always stop the scheduler when entering kdb.
In D17687#378257, @jhb wrote:

Well, it wouldn't panic in ddb itself as ddb catches any panics and reenters. However, it does mean that while you may fail to lock get mutex, I think you can end up unlocking the mutex (e.g. if you panicked while holding a mutex and called a DDB function that tried to recurse and the mutex was not marked as recursive). However, non-panic entries into DDB probably don't hold any locks (at least existing ones).

Oct 25 2018, 6:16 PM

Oct 24 2018

vangyzen added a comment to D17687: Always stop the scheduler when entering kdb.
In D17687#377924, @kib wrote:

Well, when you are trying to acquire an already locked mutex, you typically accessing some resource which state is inconsistent. You in fact trade the panic into undefined behavior and potentially corrupting the state, which means that the return from ddb to running system is unsafe.
I understand the motivation of your change. Typical answer is that ddb should not call any function that requires locks.
I very rarely return from ddb into the live system, so typically your change would be an improvement for my uses.

Oct 24 2018, 7:03 PM
vangyzen updated the diff for D17687: Always stop the scheduler when entering kdb.
  • make unset symmetric; academic, but good principle
Oct 24 2018, 5:01 PM
vangyzen created D17687: Always stop the scheduler when entering kdb.
Oct 24 2018, 4:57 PM

Oct 8 2018

vangyzen committed rS339225: em/igb: Do not print link state messages.
em/igb: Do not print link state messages
Oct 8 2018, 1:29 AM

Oct 5 2018

vangyzen added a comment to D17393: Attempt to fix PR231416 (UDP BPF VLAN checksum errors).

Committed as r339207.

Oct 5 2018, 8:23 PM

Oct 4 2018

vangyzen accepted D17246: Hold a write lock across udp_notify().
Oct 4 2018, 8:33 PM

Sep 21 2018

vangyzen accepted D17274: cxgb(4): Netdump: only reference allocated qsets.
Sep 21 2018, 5:50 PM
vangyzen accepted D17275: rename unused libevent to libevent1.
Sep 21 2018, 5:13 PM

Sep 14 2018

vangyzen committed rS338688: Fix "fasthalt" to halt instead of reboot.
Fix "fasthalt" to halt instead of reboot
Sep 14 2018, 6:12 PM