- User Since
- Jun 2 2015, 9:23 PM (392 w, 13 h)
Thu, Nov 17
Fri, Nov 11
@asomers What do you think?
Wed, Nov 9
Nov 4 2022
- Fix the tests so they actually pass
Upload the whole diff.
- Don't use log_must in cleanup.
- Invert the test for dump devices in lieu of atf_expect_fail.
Nov 3 2022
Sep 8 2022
Sep 7 2022
Aug 24 2022
Aug 23 2022
Aug 22 2022
Would someone kindly make D35635 and D35636 public, now that they're committed?
Aug 19 2022
@markj Do the tests with largepagesize even make sense when superpages are disabled? I suppose not, but they're also harmless.
Jul 18 2022
define a way to limit mbuf cluster allocations to n in a code section
Why is this necessary? Why can't we let the driver allocate all available mbufs?
Because we want to avoid a situation where we exhaust all of our preallocated mbufs to fill populate a single ring. That's the reason we preallocate as much as we do today.
How do multi-queue NICs behave when some rx rings are empty? If a packet arrives on an empty rx ring, does the packet get dropped, or does it get queued to a different rx ring?
I've always assumed that the packet would get dropped if the ring to which it's steered doesn't have any available buffer space. That might not be true for all devices, but I wouldn't want to rely on that.
I like your plan overall. I'm not intimately familiar with the network drivers, so I can't comment on that aspect.
Jul 7 2022
Jun 14 2022
I don't get why we don't send PC and the watch stop reason in the '?' case
Jun 13 2022
May 31 2022
Ingo will commit something similar in the near future, and Baptiste will import a new release of mandoc. For now, Bapt approved this commit.
May 18 2022
Have you proposed this patch to upstream? firstname.lastname@example.org is very responsive and should reply back quickly, before adding any custom patch I prefer it to be discussed with upstream first. (don't hesitate to CC me)
Phabricator did not quite do what I wanted. There are two diffs here: formatted pages, and code. See the History tab.
Pages formatted with the old and new code.
May 13 2022
- Review feedback, and more
May 12 2022
Apr 12 2022
Mar 26 2022
Mar 12 2022
Mar 11 2022
Mar 10 2022
Mar 7 2022
- move to uma_zalloc_debug()
This should go in uma_zalloc_debug() instead. Otherwise uma_zalloc_smr() isn't checked.
Thanks for the review, Ryan.
- reword with markj
- auto alloc the struct