Page MenuHomeFreeBSD

vangyzen (Eric van Gyzen)
User

Projects

User Details

User Since
Jun 2 2015, 9:23 PM (194 w, 3 d)

Recent Activity

Yesterday

vangyzen accepted D19165: CID 1332000: Logically dead code in sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c.
Fri, Feb 22, 5:11 PM

Fri, Feb 1

vangyzen committed rS343672: rtld: pacify -Wmaybe-uninitialized from gcc6.
rtld: pacify -Wmaybe-uninitialized from gcc6
Fri, Feb 1, 11:17 PM
vangyzen committed rS343671: libm: squelch -Woverflow from gcc6.
libm: squelch -Woverflow from gcc6
Fri, Feb 1, 11:16 PM

Dec 4 2018

vangyzen committed rS341508: altq: manual cleanup after r341507.
altq: manual cleanup after r341507
Dec 4 2018, 11:54 PM
vangyzen committed rS341507: altq: remove ALTQ3_COMPAT code.
altq: remove ALTQ3_COMPAT code
Dec 4 2018, 11:47 PM

Nov 30 2018

vangyzen committed rS341354: Maybe make gcc happy.
Maybe make gcc happy
Nov 30 2018, 11:50 PM
vangyzen committed rS341353: Fix reporting of SS_ONSTACK.
Fix reporting of SS_ONSTACK
Nov 30 2018, 10:47 PM
vangyzen closed D18347: Fix reporting of SS_ONSTACK.
Nov 30 2018, 10:47 PM
vangyzen committed rS341282: Include path for tmpfs objects in vm.objects sysctl.
Include path for tmpfs objects in vm.objects sysctl
Nov 30 2018, 5:02 AM
vangyzen added inline comments to D18347: Fix reporting of SS_ONSTACK.
Nov 30 2018, 4:55 AM
vangyzen retitled D18347: Fix reporting of SS_ONSTACK from Fix sigaltstack flags on some architectures to Fix reporting of SS_ONSTACK.
Nov 30 2018, 4:51 AM
vangyzen updated the diff for D18347: Fix reporting of SS_ONSTACK.
  • add sigaltstack SS_ONSTACK test
  • fix more style
  • MFH
Nov 30 2018, 4:44 AM
vangyzen committed rS341281: Add assertions and comment to vm_object_vnode().
Add assertions and comment to vm_object_vnode()
Nov 30 2018, 4:20 AM
vangyzen closed D2724: Include path for tmpfs objects in vm.objects sysctl.
Nov 30 2018, 4:20 AM
vangyzen committed rS341278: Use _thr_isthreaded() and _thr_setthreaded() wrappers.
Use _thr_isthreaded() and _thr_setthreaded() wrappers
Nov 30 2018, 3:04 AM
vangyzen committed rS341277: _thr_setthreaded() cannot fail; change return type to void.
_thr_setthreaded() cannot fail; change return type to void
Nov 30 2018, 3:04 AM

Nov 28 2018

vangyzen committed rS341166: MFC r340995.
MFC r340995
Nov 28 2018, 9:21 PM
vangyzen committed rS341165: MFC r340994.
MFC r340994
Nov 28 2018, 9:20 PM
vangyzen committed rS341153: MFS r341147.
MFS r341147
Nov 28 2018, 5:01 PM
vangyzen committed rS341149: MFS r341146.
MFS r341146
Nov 28 2018, 4:21 PM
vangyzen committed rS341147: MFC r340995.
MFC r340995
Nov 28 2018, 3:35 PM
vangyzen committed rS341146: MFC r340994.
MFC r340994
Nov 28 2018, 3:32 PM

Nov 27 2018

vangyzen committed rS341100: MFC r340409.
MFC r340409
Nov 27 2018, 10:34 PM
vangyzen committed rS341099: MFC r340409.
MFC r340409
Nov 27 2018, 10:34 PM
vangyzen committed rS341092: MFC r340345.
MFC r340345
Nov 27 2018, 7:48 PM
vangyzen committed rS341090: MFC r340328.
MFC r340328
Nov 27 2018, 7:44 PM
vangyzen committed rS341087: MFC r340257.
MFC r340257
Nov 27 2018, 7:41 PM
vangyzen committed rS341086: MFC r340257.
MFC r340257
Nov 27 2018, 7:41 PM

Nov 26 2018

vangyzen created D18347: Fix reporting of SS_ONSTACK.
Nov 26 2018, 9:49 PM
vangyzen committed rS340996: Remove superfluous bzero in getcontext/swapcontext/sendsig.
Remove superfluous bzero in getcontext/swapcontext/sendsig
Nov 26 2018, 8:57 PM
vangyzen committed rS340995: Prevent kernel stack disclosure in signal delivery.
Prevent kernel stack disclosure in signal delivery
Nov 26 2018, 8:53 PM
vangyzen committed rS340994: Prevent kernel stack disclosure in getcontext/swapcontext.
Prevent kernel stack disclosure in getcontext/swapcontext
Nov 26 2018, 8:53 PM

Nov 19 2018

vangyzen added a comment to D2724: Include path for tmpfs objects in vm.objects sysctl.

Reviving a review from 3.5 years ago, thanks to a reminder from @emaste...

Nov 19 2018, 10:24 PM
vangyzen updated the diff for D2724: Include path for tmpfs objects in vm.objects sysctl.
  • Include path for tmpfs objects in vm.objects sysctl
  • add assertion suggested by kib
Nov 19 2018, 10:17 PM

Nov 14 2018

vangyzen committed rS340447: MFC r340426 (by cem).
MFC r340426 (by cem)
Nov 14 2018, 10:05 PM
vangyzen committed rS340446: MFC r340425 (by cem).
MFC r340425 (by cem)
Nov 14 2018, 9:31 PM

Nov 13 2018

vangyzen committed rS340409: Make no assertions about lock state when the scheduler is stopped..
Make no assertions about lock state when the scheduler is stopped.
Nov 13 2018, 8:48 PM

Nov 11 2018

vangyzen committed rS340345: Fix daily mailq script for Postfix and daily_show_success="NO".
Fix daily mailq script for Postfix and daily_show_success="NO"
Nov 11 2018, 12:39 AM

Nov 10 2018

vangyzen committed rS340328: Update comment about 'universe' disk usage.
Update comment about 'universe' disk usage
Nov 10 2018, 7:09 PM

Nov 8 2018

vangyzen committed rS340257: in6_ifattach_linklocal: handle immediate removal of the new LLA.
in6_ifattach_linklocal: handle immediate removal of the new LLA
Nov 8 2018, 7:50 PM
vangyzen closed D17898: in6_ifattach_linklocal: handle immediate removal of the new LLA.
Nov 8 2018, 7:50 PM
vangyzen updated the diff for D17898: in6_ifattach_linklocal: handle immediate removal of the new LLA.
  • improve comment; add nd6log
Nov 8 2018, 7:37 PM
vangyzen added inline comments to D17898: in6_ifattach_linklocal: handle immediate removal of the new LLA.
Nov 8 2018, 7:37 PM
vangyzen added a comment to D17898: in6_ifattach_linklocal: handle immediate removal of the new LLA.

@dab This is Isilon internal bug 240643.

Nov 8 2018, 3:33 PM

Nov 7 2018

vangyzen updated subscribers of D17898: in6_ifattach_linklocal: handle immediate removal of the new LLA.
Nov 7 2018, 11:11 PM
vangyzen updated the summary of D17898: in6_ifattach_linklocal: handle immediate removal of the new LLA.
Nov 7 2018, 11:09 PM
vangyzen created D17898: in6_ifattach_linklocal: handle immediate removal of the new LLA.
Nov 7 2018, 11:07 PM

Nov 4 2018

vangyzen committed rS340127: Update expat to 2.2.6.
Update expat to 2.2.6
Nov 4 2018, 4:09 PM

Nov 2 2018

vangyzen committed rS340085: Tag expat 2.2.6.
Tag expat 2.2.6
Nov 2 2018, 10:12 PM
vangyzen committed rS340084: Vendor import of expat 2.2.6.
Vendor import of expat 2.2.6
Nov 2 2018, 10:10 PM

Oct 30 2018

vangyzen committed rS339917: Always stop the scheduler when entering kdb.
Always stop the scheduler when entering kdb
Oct 30 2018, 2:54 PM
vangyzen closed D17687: Always stop the scheduler when entering kdb.
Oct 30 2018, 2:54 PM

Oct 29 2018

vangyzen added a comment to D17687: Always stop the scheduler when entering kdb.

It's an Isilon command. It uses non-DDB code that locks a mutex. In that sense, yes, it's poorly written, but I'd rather relax that notion and allow mutexes (and therefore more "normal", non-DDB) code to be used. Ideally, there would be DDB code for everything we need; in practice, of course, there isn't.

Oct 29 2018, 9:15 PM
vangyzen added a comment to D17687: Always stop the scheduler when entering kdb.

I plan to commit this soon, unless there are any objections. (I don't see any above.)

Oct 29 2018, 8:46 PM

Oct 25 2018

vangyzen added a comment to D17687: Always stop the scheduler when entering kdb.
In D17687#378257, @jhb wrote:

Well, it wouldn't panic in ddb itself as ddb catches any panics and reenters. However, it does mean that while you may fail to lock get mutex, I think you can end up unlocking the mutex (e.g. if you panicked while holding a mutex and called a DDB function that tried to recurse and the mutex was not marked as recursive). However, non-panic entries into DDB probably don't hold any locks (at least existing ones).

Oct 25 2018, 6:16 PM

Oct 24 2018

vangyzen added a comment to D17687: Always stop the scheduler when entering kdb.
In D17687#377924, @kib wrote:

Well, when you are trying to acquire an already locked mutex, you typically accessing some resource which state is inconsistent. You in fact trade the panic into undefined behavior and potentially corrupting the state, which means that the return from ddb to running system is unsafe.

I understand the motivation of your change. Typical answer is that ddb should not call any function that requires locks.

I very rarely return from ddb into the live system, so typically your change would be an improvement for my uses.

Oct 24 2018, 7:03 PM
vangyzen updated the diff for D17687: Always stop the scheduler when entering kdb.
  • make unset symmetric; academic, but good principle
Oct 24 2018, 5:01 PM
vangyzen created D17687: Always stop the scheduler when entering kdb.
Oct 24 2018, 4:57 PM

Oct 8 2018

vangyzen committed rS339225: em/igb: Do not print link state messages.
em/igb: Do not print link state messages
Oct 8 2018, 1:29 AM

Oct 5 2018

vangyzen added a comment to D17393: Attempt to fix PR231416 (UDP BPF VLAN checksum errors).

Committed as r339207.

Oct 5 2018, 8:23 PM

Oct 4 2018

vangyzen accepted D17246: Hold a write lock across udp_notify().
Oct 4 2018, 8:33 PM

Sep 21 2018

vangyzen accepted D17274: cxgb(4): Netdump: only reference allocated qsets.
Sep 21 2018, 5:50 PM
vangyzen accepted D17275: rename unused libevent to libevent1.
Sep 21 2018, 5:13 PM

Sep 14 2018

vangyzen committed rS338688: Fix "fasthalt" to halt instead of reboot.
Fix "fasthalt" to halt instead of reboot
Sep 14 2018, 6:12 PM
vangyzen added a comment to D17115: Generate /etc/services from the IANA registry (plus local mods).

Would anyone else care to review? I promise it won't crash your browser this time.

Sep 14 2018, 5:41 PM

Sep 13 2018

vangyzen closed D17156: Set zfs_arc_meta_strategy to metadata only.
Sep 13 2018, 5:57 PM
vangyzen committed rS338656: Set zfs_arc_meta_strategy to metadata only.
Set zfs_arc_meta_strategy to metadata only
Sep 13 2018, 5:57 PM
vangyzen created D17156: Set zfs_arc_meta_strategy to metadata only.
Sep 13 2018, 4:58 PM
vangyzen accepted D17144: ZSTDIO: Correctly initialize zstd context with provided 'level'.
Sep 13 2018, 1:04 PM

Sep 12 2018

vangyzen accepted D17132: PR228448: `unlink -foo` , the original use of `unlink`, no longer works..
Sep 12 2018, 1:56 PM

Sep 11 2018

vangyzen updated the diff for D17115: Generate /etc/services from the IANA registry (plus local mods).
  • Collapse multiple spaces into a single space.
Sep 11 2018, 3:26 PM
vangyzen added inline comments to D17115: Generate /etc/services from the IANA registry (plus local mods).
Sep 11 2018, 3:19 PM
vangyzen added a comment to D17115: Generate /etc/services from the IANA registry (plus local mods).

I think I'm finished with all outstanding changes. I would be grateful for more reviews. (Thanks for your ongoing review, @asomers.)

Sep 11 2018, 3:01 PM
vangyzen updated the diff for D17115: Generate /etc/services from the IANA registry (plus local mods).
  • Update the documentation for local.xml.
Sep 11 2018, 2:49 PM
vangyzen updated the summary of D17115: Generate /etc/services from the IANA registry (plus local mods).
Sep 11 2018, 2:22 PM
vangyzen updated the summary of D17115: Generate /etc/services from the IANA registry (plus local mods).
Sep 11 2018, 2:22 PM
vangyzen updated the diff for D17115: Generate /etc/services from the IANA registry (plus local mods).
  • If the description is too long, wrap it to multiple lines and print it above the service
  • Let local services set the primary name
Sep 11 2018, 1:53 PM
vangyzen added a comment to D17115: Generate /etc/services from the IANA registry (plus local mods).

Two annoying questions:

  1. The Wayback machine shows me that IANA sometimes removes a port assignment. Sadly, I haven't been able to find any official historical information. What will FreeBSD's policy regarding removing assignments be?
Sep 11 2018, 1:07 AM

Sep 10 2018

vangyzen updated the diff for D17115: Generate /etc/services from the IANA registry (plus local mods).
  • Adhere to PEP8
Sep 10 2018, 10:15 PM
vangyzen updated the diff for D17115: Generate /etc/services from the IANA registry (plus local mods).
  • Elide useless comments; avoid trailing whitespace
Sep 10 2018, 10:04 PM
vangyzen added a comment to D17106: Generate /etc/services from the IANA registry (plus local mods).

This review is too massive to be practical. Please review D17115 instead.

Sep 10 2018, 9:56 PM
vangyzen added a comment to D17115: Generate /etc/services from the IANA registry (plus local mods).

This review replaces D17106. This review is more practical because it omits the service-names-port-numbers.xml file from IANA. Whether this file should be committed is an open question. This review also omits whitespace changes in the generated services file. These will be committed separately, before the other changes.

Sep 10 2018, 9:54 PM
vangyzen created D17115: Generate /etc/services from the IANA registry (plus local mods).
Sep 10 2018, 9:47 PM
vangyzen added inline comments to D17106: Generate /etc/services from the IANA registry (plus local mods).
Sep 10 2018, 6:25 PM
vangyzen added a comment to D17106: Generate /etc/services from the IANA registry (plus local mods).

I would not try to get this into 12.0, due to unpredictable runtime impact.

Sep 10 2018, 6:15 PM
vangyzen added inline comments to D17106: Generate /etc/services from the IANA registry (plus local mods).
Sep 10 2018, 6:11 PM
vangyzen updated subscribers of D17106: Generate /etc/services from the IANA registry (plus local mods).

At the suggestion of @mjg, I tested the performance of the parser in libc by calling getservent() (and envservent() after it returned NULL so I could reparse the file many times). Time increased linearly as the number of lines, and memory usage (RSS) increased less than 1%.

Sep 10 2018, 6:07 PM
vangyzen added a comment to D17106: Generate /etc/services from the IANA registry (plus local mods).

Is there anyway to NOT have the 141,000 line xml version of the file stored in SVN?

Sep 10 2018, 6:01 PM
vangyzen added inline comments to D17106: Generate /etc/services from the IANA registry (plus local mods).
Sep 10 2018, 5:32 PM
vangyzen added a comment to D17106: Generate /etc/services from the IANA registry (plus local mods).
In D17106#364690, @jhb wrote:

It's not clear to me what the role of local.xml is. I had assumed from the description that local.xml just contained additional entries (or perhaps overrides for existing entries) relative to the official IANA registry. However, local.xml seems to contain a lot of entries that duplicate the IANA registry?

Sep 10 2018, 5:21 PM
vangyzen added a comment to D17106: Generate /etc/services from the IANA registry (plus local mods).

I will address the PEP8 errors.

Sep 10 2018, 5:03 PM
vangyzen created D17106: Generate /etc/services from the IANA registry (plus local mods).
Sep 10 2018, 5:00 PM

Sep 6 2018

vangyzen accepted D17049: random(4): Squash non-error timeout codes from tsleep(9).
Sep 6 2018, 12:24 PM

Aug 22 2018

vangyzen accepted D16835: KASSERT: Make runtime optionality optional.
Aug 22 2018, 6:50 PM

Aug 21 2018

vangyzen accepted D16831: newsyslog(8): Reject configurations that specify setuid or executable logs.
Aug 21 2018, 8:18 PM
vangyzen added a comment to D16831: newsyslog(8): Reject configurations that specify setuid or executable logs.

I like it, and I like the suggestions from @delphij.

Aug 21 2018, 6:46 PM

Aug 14 2018

vangyzen accepted D16709: mergemaster: better defaults for SOURCEDIR.
Aug 14 2018, 3:37 PM
vangyzen accepted D16709: mergemaster: better defaults for SOURCEDIR.
Aug 14 2018, 3:03 PM

Jun 15 2018

vangyzen committed rS335206: Fix markup in zfs(8); no content change.
Fix markup in zfs(8); no content change
Jun 15 2018, 3:28 PM

Jun 5 2018

vangyzen committed rS334669: Make Coverity more happy with r334545.
Make Coverity more happy with r334545
Jun 5 2018, 8:34 PM