Page MenuHomeFreeBSD

vangyzen (Eric van Gyzen)
User

Projects

User Details

User Since
Jun 2 2015, 9:23 PM (252 w, 5 d)

Recent Activity

Tue, Mar 31

vangyzen accepted D24203: Fix various Coverity-detected errors in nvmecontrol.
Tue, Mar 31, 8:51 PM

Fri, Mar 27

vangyzen added inline comments to D24203: Fix various Coverity-detected errors in nvmecontrol.
Fri, Mar 27, 5:55 PM

Wed, Mar 18

vangyzen accepted D24117: Fix parameter reversal potentially causing buffer overrun..

Wow, that API is unfortunate.

Wed, Mar 18, 6:25 PM

Mar 3 2020

vangyzen closed D23923: dumpon: skip size check if using zstd.
Mar 3 2020, 10:14 PM
vangyzen committed rS358594: dumpon: skip size check if using zstd.
dumpon: skip size check if using zstd
Mar 3 2020, 10:14 PM

Mar 2 2020

vangyzen created D23923: dumpon: skip size check if using zstd.
Mar 2 2020, 3:37 PM

Feb 20 2020

vangyzen committed rS358187: clamp kernel dump compression level when using gzip.
clamp kernel dump compression level when using gzip
Feb 20 2020, 11:54 PM
vangyzen closed D23765: clamp kernel dump compression level when using gzip.
Feb 20 2020, 11:54 PM
vangyzen committed rS358186: truncate(2): extending the file is required by POSIX 2008.
truncate(2): extending the file is required by POSIX 2008
Feb 20 2020, 11:47 PM
vangyzen closed D23354: truncate(2): extending the file is required by POSIX 2008.
Feb 20 2020, 11:47 PM

Feb 19 2020

vangyzen updated the test plan for D23765: clamp kernel dump compression level when using gzip.
Feb 19 2020, 10:01 PM
vangyzen created D23765: clamp kernel dump compression level when using gzip.
Feb 19 2020, 10:00 PM

Jan 24 2020

vangyzen created D23354: truncate(2): extending the file is required by POSIX 2008.
Jan 24 2020, 9:55 PM

Jan 13 2020

vangyzen committed rS356709: fstyp hammer2: remove dead code.
fstyp hammer2: remove dead code
Jan 13 2020, 10:36 PM
vangyzen committed rS356708: fstyp hammer: use strlcpy.
fstyp hammer: use strlcpy
Jan 13 2020, 10:34 PM
vangyzen closed D23159: fstyp: fix Coverity issues in hammer support.
Jan 13 2020, 10:34 PM
vangyzen committed rS356706: savecore: include time zone in info.N file.
savecore: include time zone in info.N file
Jan 13 2020, 10:01 PM
vangyzen committed rS356705: Add missing comma in nfsv4_errstr.
Add missing comma in nfsv4_errstr
Jan 13 2020, 9:49 PM
vangyzen created D23159: fstyp: fix Coverity issues in hammer support.
Jan 13 2020, 9:21 PM

Jan 10 2020

vangyzen accepted D23081: Fix bug in TPM 2.0 TIS driver..
Jan 10 2020, 8:00 PM

Jan 8 2020

vangyzen accepted D23090: rtld: fix after r356300.
Jan 8 2020, 5:14 PM

Dec 10 2019

vangyzen committed rS355593: fsck_ffs: fix some memory leaks found by Coverity..
fsck_ffs: fix some memory leaks found by Coverity.
Dec 10 2019, 8:04 PM

Dec 3 2019

vangyzen committed rS355370: MFC r354624.
MFC r354624
Dec 3 2019, 11:00 PM
vangyzen committed rS355369: MFC r354624.
MFC r354624
Dec 3 2019, 10:57 PM

Nov 18 2019

vangyzen added a comment to D15259: Add netdump hooks for mlxen(4)..

Was this tested with an MTU of 9000?

Nov 18 2019, 4:29 PM

Nov 11 2019

vangyzen committed rS354624: tip/cu: check for EOF on input on the local side.
tip/cu: check for EOF on input on the local side
Nov 11 2019, 5:42 PM

Nov 9 2019

vangyzen accepted D22271: Create /etc/os-release file..

Thanks for the man page!

Nov 9 2019, 8:52 PM

Nov 8 2019

vangyzen accepted D22271: Create /etc/os-release file..

It would be nice to include some documentation. The systemd man page seems most useful and canonical, but it's LGPL. Maybe include a link to it in a comment in the generated file?

Nov 8 2019, 7:53 PM
vangyzen closed D22276: vmm: pass M_WAITOK to uma_zalloc when allocating FPU save area.
Nov 8 2019, 4:31 PM
vangyzen committed rS354548: vmm: pass M_WAITOK to uma_zalloc when allocating FPU save area.
vmm: pass M_WAITOK to uma_zalloc when allocating FPU save area
Nov 8 2019, 4:31 PM

Nov 7 2019

vangyzen created D22276: vmm: pass M_WAITOK to uma_zalloc when allocating FPU save area.
Nov 7 2019, 4:33 PM

Nov 5 2019

vangyzen accepted D21627: Implement a close_range(2) syscall.
Nov 5 2019, 3:54 PM

Oct 11 2019

vangyzen committed rS353448: coredump_phnum_test: handle full file system gracefully.
coredump_phnum_test: handle full file system gracefully
Oct 11 2019, 9:24 PM

Oct 9 2019

vangyzen committed rS353344: Add CTLFLAG_STATS to the dev.ioat.N.stats sysctl OIDs.
Add CTLFLAG_STATS to the dev.ioat.N.stats sysctl OIDs
Oct 9 2019, 12:14 PM

Oct 8 2019

vangyzen committed rS353305: Fix problems in the kern_maxfiles__increase test.
Fix problems in the kern_maxfiles__increase test
Oct 8 2019, 1:43 PM
vangyzen closed D21900: Fix problems in the kern_maxfiles__increase test.
Oct 8 2019, 1:43 PM

Oct 6 2019

vangyzen added inline comments to D21900: Fix problems in the kern_maxfiles__increase test.
Oct 6 2019, 12:34 AM
vangyzen updated the diff for D21900: Fix problems in the kern_maxfiles__increase test.
  • wait() for children instead of a sleep race
Oct 6 2019, 12:28 AM

Oct 5 2019

vangyzen removed a reviewer for D21900: Fix problems in the kern_maxfiles__increase test: pho.
Oct 5 2019, 1:47 PM
vangyzen added inline comments to D21900: Fix problems in the kern_maxfiles__increase test.
Oct 5 2019, 1:27 PM
vangyzen updated the diff for D21900: Fix problems in the kern_maxfiles__increase test.
  • rebase
Oct 5 2019, 1:20 PM
vangyzen updated the diff for D21900: Fix problems in the kern_maxfiles__increase test.
  • fixup: make test more robust by opening more files
Oct 5 2019, 1:18 PM

Oct 4 2019

vangyzen added a comment to D21900: Fix problems in the kern_maxfiles__increase test.

That's not much of a test plan. Perhaps try sudo?

Oct 4 2019, 11:31 PM
vangyzen updated the test plan for D21900: Fix problems in the kern_maxfiles__increase test.
Oct 4 2019, 9:50 PM
vangyzen committed rS353114: Make the hw.intrs sysctl OID read-only.
Make the hw.intrs sysctl OID read-only
Oct 4 2019, 9:46 PM
vangyzen committed rS353113: Add CTLFLAG_STATS to several debug.softdep sysctl OIDs.
Add CTLFLAG_STATS to several debug.softdep sysctl OIDs
Oct 4 2019, 9:45 PM
vangyzen committed rS353112: Add CTLFLAG_STATS to some vfs sysctl OIDs.
Add CTLFLAG_STATS to some vfs sysctl OIDs
Oct 4 2019, 9:43 PM
vangyzen committed rS353111: Add CTLFLAG_STATS to all COUNTER_U64* sysctl OIDs.
Add CTLFLAG_STATS to all COUNTER_U64* sysctl OIDs
Oct 4 2019, 9:39 PM
vangyzen created D21900: Fix problems in the kern_maxfiles__increase test.
Oct 4 2019, 9:33 PM

Sep 30 2019

vangyzen committed rS352898: Fix coredump_phnum_test when kern.compress_user_cores != 0.
Fix coredump_phnum_test when kern.compress_user_cores != 0
Sep 30 2019, 2:06 PM
vangyzen closed D21820: Fix coredump_phnum_test when kern.compress_user_cores != 0.
Sep 30 2019, 2:06 PM

Sep 27 2019

vangyzen added a comment to D21776: Fix sys/kern/coredump_phnum_test in case of kern.compress_user_cores=1.

See D21820. What do you think?

That your fix is better than mine :-)
So feel free to overwrite my changes with yours.

Sep 27 2019, 3:23 PM
vangyzen added a comment to D21776: Fix sys/kern/coredump_phnum_test in case of kern.compress_user_cores=1.

Coincidentally, I have a different fix for this in a work-in-progress tree. My change keeps the current value of kern.compress_user_cores and decompresses the core file. It has the advantage of providing test coverage for kern.compress_user_cores (if the user enables it). I can't find any existing test coverage.

Sep 27 2019, 3:03 PM
vangyzen created D21820: Fix coredump_phnum_test when kern.compress_user_cores != 0.
Sep 27 2019, 3:03 PM

Sep 12 2019

vangyzen accepted D21461: Add ability to fetch kernel threads from cores in kvm_getprocs in libkvm.
Sep 12 2019, 8:53 PM

Aug 21 2019

vangyzen updated subscribers of D10188: Use 256 run queues, with 1 priority per queue.

However, the kernel improved a lot since this revision was created and a repeated test has higher chances of showing the difference (if any).

Aug 21 2019, 2:45 PM

Aug 16 2019

vangyzen committed rS351118: Update pthread_cond_timedwait() test to current NetBSD.
Update pthread_cond_timedwait() test to current NetBSD
Aug 16 2019, 1:10 PM
vangyzen closed D21279: Update pthread_cond_timedwait() test to current NetBSD version.
Aug 16 2019, 1:10 PM

Aug 15 2019

vangyzen created D21279: Update pthread_cond_timedwait() test to current NetBSD version.
Aug 15 2019, 8:53 PM

Aug 5 2019

vangyzen committed rS350620: Relax time constraint in pthread_cond_timedwait unit test.
Relax time constraint in pthread_cond_timedwait unit test
Aug 5 2019, 10:59 PM
vangyzen abandoned D21161: indent: rename a test data file.
Aug 5 2019, 7:29 PM
vangyzen added a comment to D21161: indent: rename a test data file.

*facepalm* this is really happening? Oy...

Aug 5 2019, 3:20 AM

Aug 4 2019

vangyzen created D21161: indent: rename a test data file.
Aug 4 2019, 8:04 PM

Jul 22 2019

D21015: sbuf(9): Add NOWAIT dynamic buffer extension mode is now accepted and ready to land.
Jul 22 2019, 1:41 AM
vangyzen added inline comments to D21015: sbuf(9): Add NOWAIT dynamic buffer extension mode.
Jul 22 2019, 12:32 AM

Jul 21 2019

vangyzen added inline comments to D21015: sbuf(9): Add NOWAIT dynamic buffer extension mode.
Jul 21 2019, 8:28 PM

Jul 16 2019

vangyzen committed rS350056: MFC r349834.
MFC r349834
Jul 16 2019, 4:49 PM
vangyzen committed rS350050: MFC r349834.
MFC r349834
Jul 16 2019, 4:05 PM
vangyzen committed rS350043: Adds signal number format to kern.corefile.
Adds signal number format to kern.corefile
Jul 16 2019, 3:51 PM
Herald added a reviewer for D20970: Adds signal number format to kern.corefile: manpages.
Jul 16 2019, 3:51 PM
D20970: Adds signal number format to kern.corefile is now accepted and ready to land.
Jul 16 2019, 3:25 PM
vangyzen accepted D20970: Adds signal number format to kern.corefile.
Jul 16 2019, 3:18 PM

Jul 8 2019

vangyzen committed rS349834: Ignore kern.vt.splash_cpu without graphics.
Ignore kern.vt.splash_cpu without graphics
Jul 8 2019, 1:46 PM
vangyzen closed D20877: Ignore kern.vt.splash_cpu on bhyve.
Jul 8 2019, 1:46 PM

Jul 7 2019

vangyzen added inline comments to D20877: Ignore kern.vt.splash_cpu on bhyve.
Jul 7 2019, 10:38 PM
vangyzen added a reviewer for D20877: Ignore kern.vt.splash_cpu on bhyve: dumbbell.
Jul 7 2019, 10:37 PM
vangyzen created D20877: Ignore kern.vt.splash_cpu on bhyve.
Jul 7 2019, 10:36 PM

Jul 3 2019

vangyzen committed rS349693: MFC r349285.
MFC r349285
Jul 3 2019, 7:55 PM
vangyzen committed rS349691: MFC r349285.
MFC r349285
Jul 3 2019, 7:52 PM
vangyzen committed rS349690: MFC r349278.
MFC r349278
Jul 3 2019, 7:50 PM
vangyzen closed D20794: Save the last callout function executed on each CPU.
Jul 3 2019, 7:23 PM
vangyzen committed rS349677: Save the last callout function executed on each CPU.
Save the last callout function executed on each CPU
Jul 3 2019, 7:23 PM
D20842: Bug 238960: panic in vm_pageout_collect_batch() with QUEUE_MACRO_DEBUG_TRASH enabled is now accepted and ready to land.
Jul 3 2019, 4:28 PM

Jul 1 2019

vangyzen added a comment to D20794: Save the last callout function executed on each CPU.
  • Show the last callout on every CPU by default
Jul 1 2019, 2:25 AM
vangyzen updated the test plan for D20794: Save the last callout function executed on each CPU.
Jul 1 2019, 2:21 AM
vangyzen added a comment to D20794: Save the last callout function executed on each CPU.

The change looks ok to me.

Jul 1 2019, 1:39 AM

Jun 28 2019

vangyzen created D20794: Save the last callout function executed on each CPU.
Jun 28 2019, 4:41 PM

Jun 22 2019

vangyzen added a comment to D20603: Update net/tcptestsuite to github commit f7a1844.

I hope to commit some ATF tests to the tcptestsuite repo. I’ll send out a new review to update the port after that.

Jun 22 2019, 6:13 PM
vangyzen committed rS349285: VirtIO SCSI: validate seg_max on attach.
VirtIO SCSI: validate seg_max on attach
Jun 22 2019, 1:20 AM
vangyzen closed D20703: VirtIO SCSI: validate seg_max from hypervisor.
Jun 22 2019, 1:20 AM

Jun 21 2019

vangyzen updated the summary of D20703: VirtIO SCSI: validate seg_max from hypervisor.
Jun 21 2019, 7:30 PM
vangyzen added a comment to D20703: VirtIO SCSI: validate seg_max from hypervisor.

Sorry I wasn't clearer: use virtqueue_size() after the allocate to do the check. Do not add a new virtqueue_size bus interface.

Jun 21 2019, 7:28 PM
vangyzen added a comment to D20703: VirtIO SCSI: validate seg_max from hypervisor.
  • Clamp seg_max after allocating virtqueues.
Jun 21 2019, 7:28 PM
vangyzen closed D20529: bhyve: fix reporting of virtio scsi seg_max.
Jun 21 2019, 6:57 PM
vangyzen committed rS349278: bhyve: Fix vtscsi maximum segment config.
bhyve: Fix vtscsi maximum segment config
Jun 21 2019, 6:57 PM
vangyzen added a comment to D20703: VirtIO SCSI: validate seg_max from hypervisor.
  • revert to previous approach of clamping seg_max
  • do not artificially limit seg_max when indirect is available
Jun 21 2019, 4:52 PM
vangyzen added inline comments to D20703: VirtIO SCSI: validate seg_max from hypervisor.
Jun 21 2019, 4:47 PM
vangyzen accepted D20701: rc.d/motd: Update motd more robustly.
Jun 21 2019, 2:21 AM
vangyzen updated the test plan for D20703: VirtIO SCSI: validate seg_max from hypervisor.
Jun 21 2019, 12:03 AM
vangyzen added a comment to D20703: VirtIO SCSI: validate seg_max from hypervisor.

Mark: Sorry, I @-mentioned you by mistake.

Jun 21 2019, 12:01 AM