Page MenuHomeFreeBSD

vangyzen (Eric van Gyzen)
User

Projects

User Details

User Since
Jun 2 2015, 9:23 PM (220 w, 2 d)

Recent Activity

Wed, Aug 21

vangyzen updated subscribers of D10188: Use 256 run queues, with 1 priority per queue.

However, the kernel improved a lot since this revision was created and a repeated test has higher chances of showing the difference (if any).

Wed, Aug 21, 2:45 PM

Fri, Aug 16

vangyzen committed rS351118: Update pthread_cond_timedwait() test to current NetBSD.
Update pthread_cond_timedwait() test to current NetBSD
Fri, Aug 16, 1:10 PM
vangyzen closed D21279: Update pthread_cond_timedwait() test to current NetBSD version.
Fri, Aug 16, 1:10 PM

Thu, Aug 15

vangyzen created D21279: Update pthread_cond_timedwait() test to current NetBSD version.
Thu, Aug 15, 8:53 PM

Mon, Aug 5

vangyzen committed rS350620: Relax time constraint in pthread_cond_timedwait unit test.
Relax time constraint in pthread_cond_timedwait unit test
Mon, Aug 5, 10:59 PM
vangyzen abandoned D21161: indent: rename a test data file.
Mon, Aug 5, 7:29 PM
vangyzen added a comment to D21161: indent: rename a test data file.

*facepalm* this is really happening? Oy...

Mon, Aug 5, 3:20 AM

Sun, Aug 4

vangyzen created D21161: indent: rename a test data file.
Sun, Aug 4, 8:04 PM

Jul 22 2019

D21015: sbuf(9): Add NOWAIT dynamic buffer extension mode is now accepted and ready to land.
Jul 22 2019, 1:41 AM
vangyzen added inline comments to D21015: sbuf(9): Add NOWAIT dynamic buffer extension mode.
Jul 22 2019, 12:32 AM

Jul 21 2019

vangyzen added inline comments to D21015: sbuf(9): Add NOWAIT dynamic buffer extension mode.
Jul 21 2019, 8:28 PM

Jul 16 2019

vangyzen committed rS350056: MFC r349834.
MFC r349834
Jul 16 2019, 4:49 PM
vangyzen committed rS350050: MFC r349834.
MFC r349834
Jul 16 2019, 4:05 PM
vangyzen committed rS350043: Adds signal number format to kern.corefile.
Adds signal number format to kern.corefile
Jul 16 2019, 3:51 PM
Herald added a reviewer for D20970: Adds signal number format to kern.corefile: manpages.
Jul 16 2019, 3:51 PM
D20970: Adds signal number format to kern.corefile is now accepted and ready to land.
Jul 16 2019, 3:25 PM
vangyzen accepted D20970: Adds signal number format to kern.corefile.
Jul 16 2019, 3:18 PM

Jul 8 2019

vangyzen committed rS349834: Ignore kern.vt.splash_cpu without graphics.
Ignore kern.vt.splash_cpu without graphics
Jul 8 2019, 1:46 PM
vangyzen closed D20877: Ignore kern.vt.splash_cpu on bhyve.
Jul 8 2019, 1:46 PM

Jul 7 2019

vangyzen added inline comments to D20877: Ignore kern.vt.splash_cpu on bhyve.
Jul 7 2019, 10:38 PM
vangyzen added a reviewer for D20877: Ignore kern.vt.splash_cpu on bhyve: dumbbell.
Jul 7 2019, 10:37 PM
vangyzen created D20877: Ignore kern.vt.splash_cpu on bhyve.
Jul 7 2019, 10:36 PM

Jul 3 2019

vangyzen committed rS349693: MFC r349285.
MFC r349285
Jul 3 2019, 7:55 PM
vangyzen committed rS349691: MFC r349285.
MFC r349285
Jul 3 2019, 7:52 PM
vangyzen committed rS349690: MFC r349278.
MFC r349278
Jul 3 2019, 7:50 PM
vangyzen closed D20794: Save the last callout function executed on each CPU.
Jul 3 2019, 7:23 PM
vangyzen committed rS349677: Save the last callout function executed on each CPU.
Save the last callout function executed on each CPU
Jul 3 2019, 7:23 PM
D20842: Bug 238960: panic in vm_pageout_collect_batch() with QUEUE_MACRO_DEBUG_TRASH enabled is now accepted and ready to land.
Jul 3 2019, 4:28 PM

Jul 1 2019

vangyzen added a comment to D20794: Save the last callout function executed on each CPU.
  • Show the last callout on every CPU by default
Jul 1 2019, 2:25 AM
vangyzen updated the test plan for D20794: Save the last callout function executed on each CPU.
Jul 1 2019, 2:21 AM
vangyzen added a comment to D20794: Save the last callout function executed on each CPU.

The change looks ok to me.

Jul 1 2019, 1:39 AM

Jun 28 2019

vangyzen created D20794: Save the last callout function executed on each CPU.
Jun 28 2019, 4:41 PM

Jun 22 2019

vangyzen added a comment to D20603: Update net/tcptestsuite to github commit f7a1844.

I hope to commit some ATF tests to the tcptestsuite repo. I’ll send out a new review to update the port after that.

Jun 22 2019, 6:13 PM
vangyzen committed rS349285: VirtIO SCSI: validate seg_max on attach.
VirtIO SCSI: validate seg_max on attach
Jun 22 2019, 1:20 AM
vangyzen closed D20703: VirtIO SCSI: validate seg_max from hypervisor.
Jun 22 2019, 1:20 AM

Jun 21 2019

vangyzen updated the summary of D20703: VirtIO SCSI: validate seg_max from hypervisor.
Jun 21 2019, 7:30 PM
vangyzen added a comment to D20703: VirtIO SCSI: validate seg_max from hypervisor.

Sorry I wasn't clearer: use virtqueue_size() after the allocate to do the check. Do not add a new virtqueue_size bus interface.

Jun 21 2019, 7:28 PM
vangyzen added a comment to D20703: VirtIO SCSI: validate seg_max from hypervisor.
  • Clamp seg_max after allocating virtqueues.
Jun 21 2019, 7:28 PM
vangyzen closed D20529: bhyve: fix reporting of virtio scsi seg_max.
Jun 21 2019, 6:57 PM
vangyzen committed rS349278: bhyve: Fix vtscsi maximum segment config.
bhyve: Fix vtscsi maximum segment config
Jun 21 2019, 6:57 PM
vangyzen added a comment to D20703: VirtIO SCSI: validate seg_max from hypervisor.
  • revert to previous approach of clamping seg_max
  • do not artificially limit seg_max when indirect is available
Jun 21 2019, 4:52 PM
vangyzen added inline comments to D20703: VirtIO SCSI: validate seg_max from hypervisor.
Jun 21 2019, 4:47 PM
vangyzen accepted D20701: rc.d/motd: Update motd more robustly.
Jun 21 2019, 2:21 AM
vangyzen updated the test plan for D20703: VirtIO SCSI: validate seg_max from hypervisor.
Jun 21 2019, 12:03 AM
vangyzen added a comment to D20703: VirtIO SCSI: validate seg_max from hypervisor.

Mark: Sorry, I @-mentioned you by mistake.

Jun 21 2019, 12:01 AM

Jun 20 2019

vangyzen updated subscribers of D20703: VirtIO SCSI: validate seg_max from hypervisor.
  • Simply detect the case and fail to attach, as @bryanv suggests.
Jun 20 2019, 11:59 PM

Jun 19 2019

vangyzen added inline comments to D20703: VirtIO SCSI: validate seg_max from hypervisor.
Jun 19 2019, 10:18 PM
D20703: VirtIO SCSI: validate seg_max from hypervisor now requires review to proceed.
  • add declaration of vtmmio_virtqueue_size()
Jun 19 2019, 9:59 PM
vangyzen added inline comments to D20529: bhyve: fix reporting of virtio scsi seg_max.
Jun 19 2019, 9:50 PM
vangyzen retitled D20529: bhyve: fix reporting of virtio scsi seg_max from Fix calculation of vtscsi_max_nsegs to bhyve: fix reporting of virtio scsi seg_max.
Jun 19 2019, 9:42 PM
vangyzen added a comment to D20529: bhyve: fix reporting of virtio scsi seg_max.
  • add comment for foo - 2
Jun 19 2019, 9:37 PM
vangyzen added a reviewer for D20703: VirtIO SCSI: validate seg_max from hypervisor: bhyve.
Jun 19 2019, 9:30 PM
vangyzen created D20703: VirtIO SCSI: validate seg_max from hypervisor.
Jun 19 2019, 9:30 PM
D20701: rc.d/motd: Update motd more robustly is now accepted and ready to land.
Jun 19 2019, 8:09 PM

Jun 13 2019

vangyzen abandoned D20610: Integrate tcp-testsuite into kyua.

Abandoned in favor of https://github.com/freebsd-net/tcp-testsuite/pull/4#

Jun 13 2019, 8:43 PM
vangyzen added a comment to D20610: Integrate tcp-testsuite into kyua.

If you add the tests directly in GH, feel free to request a review from me.

Jun 13 2019, 1:59 PM

Jun 11 2019

vangyzen updated the summary of D20610: Integrate tcp-testsuite into kyua.
Jun 11 2019, 7:53 PM
vangyzen added a comment to D20610: Integrate tcp-testsuite into kyua.

The basic idea behind this review is fundamentally broken. We shouldn't be adding test cases to the base system that wrap a port which is itself just a bunch of test cases. Instead, the correct approach would be to add ATF test cases directly to the port, to be installed into /usr/local/tests/tcptestsuite. See devel/atf, devel/kyua, or devel/lutok for examples of ports that do that.

Jun 11 2019, 7:52 PM
vangyzen updated subscribers of D20610: Integrate tcp-testsuite into kyua.
Jun 11 2019, 5:32 PM
vangyzen created D20610: Integrate tcp-testsuite into kyua.
Jun 11 2019, 5:29 PM
vangyzen created D20603: Update net/tcptestsuite to github commit f7a1844.
Jun 11 2019, 3:44 PM

Jun 6 2019

vangyzen added a comment to D20529: bhyve: fix reporting of virtio scsi seg_max.

Does this need urgent attention to get in 11.3?

Jun 6 2019, 6:53 PM
vangyzen added a comment to D20529: bhyve: fix reporting of virtio scsi seg_max.

Wait, I think we should still have a seat belt in guests.

Jun 6 2019, 4:47 PM
vangyzen added a comment to D20529: bhyve: fix reporting of virtio scsi seg_max.

If you change the config seg_max in bhyve to be VTSCSI_MAXSEG - 2, does that fix the issue?

I'll try that now.

Jun 6 2019, 1:32 PM
vangyzen updated the diff for D20529: bhyve: fix reporting of virtio scsi seg_max.

Fix it in bhyve instead

Jun 6 2019, 1:31 PM
vangyzen added a comment to D20529: bhyve: fix reporting of virtio scsi seg_max.

I believe seg_max is the number of segments in a SCSI command while...

Jun 6 2019, 12:15 PM

Jun 5 2019

vangyzen created D20529: bhyve: fix reporting of virtio scsi seg_max.
Jun 5 2019, 9:43 PM

May 28 2019

vangyzen accepted D20448: style.9: Codify tolerance for eliding blank lines.
May 28 2019, 6:47 PM

May 24 2019

vangyzen accepted D20401: Disable intr_storm_threshold mechanism by default.
May 24 2019, 10:33 PM
vangyzen updated subscribers of D18930: Per-thread credentials.
May 24 2019, 12:00 PM

May 10 2019

vangyzen added inline comments to D20206: netdump: Ref the interface we're attached to.
May 10 2019, 7:32 PM

Apr 12 2019

vangyzen updated the diff for D19426: post-commit hooks: Accept BZ URLs in PR lines.
  • Accept short URLs, too.
Apr 12 2019, 2:57 PM

Mar 8 2019

vangyzen added a comment to D19426: post-commit hooks: Accept BZ URLs in PR lines.

I would be comfortable with simply "https://bugs.freebsd.org/12344" as that can likely work forever.

Note that https://bugs.freebsd.org/12344 does work - we should accept either https://bugs.freebsd.org/bugzilla/show_bug.cgi?id= or https://bugs.freebsd.org/[0-9]+

Mar 8 2019, 9:17 PM
vangyzen updated subscribers of D19459: subversion: update commit message template to allow URLs in PR field.

https://bugs.freebsd.org/12345 redirects to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=12345. Wouldn't the first form be better? It's shorter and likely easier to map to whatever bug tracker we might move to after bugzilla (if we ever do change). It also looks more like the phabricator links.

Mar 8 2019, 3:52 PM

Mar 5 2019

vangyzen added inline comments to D19460: subversion: update commit message template to allow URLs in PR field.
Mar 5 2019, 7:32 PM
vangyzen updated the diff for D19459: subversion: update commit message template to allow URLs in PR field.

Just mention the URL in the comments.

Mar 5 2019, 7:09 PM
vangyzen updated the diff for D19460: subversion: update commit message template to allow URLs in PR field.

Just mention the URL in the comments.

Mar 5 2019, 7:07 PM
vangyzen added inline comments to D19459: subversion: update commit message template to allow URLs in PR field.
Mar 5 2019, 6:58 PM

Mar 4 2019

vangyzen added a comment to D19426: post-commit hooks: Accept BZ URLs in PR lines.

To keep the whole record in one place, here is the CGI script I mentioned:

Mar 4 2019, 9:08 PM
vangyzen added a comment to D19426: post-commit hooks: Accept BZ URLs in PR lines.

Check out rP154065.
All of the PRs linked there were filed in GNATS but were mapped over in BUGZILLA so they had the same numbers.
Had they been GNATS urls they would be more annoying to deal with IMO as the links would all be dead now. I realize this is an objective opinion.

Mar 4 2019, 8:20 PM
vangyzen updated the diff for D19426: post-commit hooks: Accept BZ URLs in PR lines.

$Id$ -> $FreeBSD$

Mar 4 2019, 8:02 PM
vangyzen added a comment to D19426: post-commit hooks: Accept BZ URLs in PR lines.

Missing is the change to the commit message template to update it to say URL instead of PRxxxx

Mar 4 2019, 8:02 PM
vangyzen added a comment to D19460: subversion: update commit message template to allow URLs in PR field.

D19459 covers subversion in the base system.

Mar 4 2019, 7:59 PM
vangyzen created D19460: subversion: update commit message template to allow URLs in PR field.
Mar 4 2019, 7:58 PM
vangyzen created D19459: subversion: update commit message template to allow URLs in PR field.
Mar 4 2019, 7:56 PM
vangyzen updated the summary of D19446: smp topology: remove groups containing a single CPU, which serve no purpose.
Mar 4 2019, 3:48 PM
vangyzen created D19446: smp topology: remove groups containing a single CPU, which serve no purpose.
Mar 4 2019, 3:48 PM

Mar 1 2019

vangyzen created D19426: post-commit hooks: Accept BZ URLs in PR lines.
Mar 1 2019, 8:31 PM

Feb 28 2019

vangyzen added inline comments to D13595: Reuse kern_proc_vmmap_resident() for procfs_map resident count..
Feb 28 2019, 9:49 PM

Feb 27 2019

vangyzen added inline comments to D13595: Reuse kern_proc_vmmap_resident() for procfs_map resident count..
Feb 27 2019, 8:07 PM

Feb 22 2019

vangyzen accepted D19165: CID 1332000: Logically dead code in sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c.
Feb 22 2019, 5:11 PM

Feb 1 2019

vangyzen committed rS343672: rtld: pacify -Wmaybe-uninitialized from gcc6.
rtld: pacify -Wmaybe-uninitialized from gcc6
Feb 1 2019, 11:17 PM
vangyzen committed rS343671: libm: squelch -Woverflow from gcc6.
libm: squelch -Woverflow from gcc6
Feb 1 2019, 11:16 PM

Dec 4 2018

vangyzen committed rS341508: altq: manual cleanup after r341507.
altq: manual cleanup after r341507
Dec 4 2018, 11:54 PM
vangyzen committed rS341507: altq: remove ALTQ3_COMPAT code.
altq: remove ALTQ3_COMPAT code
Dec 4 2018, 11:47 PM

Nov 30 2018

vangyzen committed rS341354: Maybe make gcc happy.
Maybe make gcc happy
Nov 30 2018, 11:50 PM
vangyzen committed rS341353: Fix reporting of SS_ONSTACK.
Fix reporting of SS_ONSTACK
Nov 30 2018, 10:47 PM
vangyzen closed D18347: Fix reporting of SS_ONSTACK.
Nov 30 2018, 10:47 PM
vangyzen committed rS341282: Include path for tmpfs objects in vm.objects sysctl.
Include path for tmpfs objects in vm.objects sysctl
Nov 30 2018, 5:02 AM
vangyzen added inline comments to D18347: Fix reporting of SS_ONSTACK.
Nov 30 2018, 4:55 AM