Fix Coverity issue in the NVDIMM driver
ClosedPublic
Actions

Authored by dab on Feb 19 2023, 8:31 PM.

Tags

None

Referenced Files

	F166290454: D38676.id117795.diff
	Wed, Aug 12, 5:09 PM

	F166290448: D38676.id117598.diff
	Wed, Aug 12, 5:09 PM

	F166290447: D38676.id.diff
	Wed, Aug 12, 5:09 PM

	F166290432: D38676.diff
	Wed, Aug 12, 5:09 PM

	Unknown Object (File)
	Sat, Aug 8, 4:47 PM

	Unknown Object (File)
	Sat, Aug 8, 10:08 AM

	Unknown Object (File)
	Sat, Aug 1, 8:27 AM

	Unknown Object (File)
	Sat, Aug 1, 5:01 AM

Subscribers

Details

Reviewers

robert.herndon_dell.com
vangyzen
bret_ketchum_dell.com

Commits

rG3ff497061b33: Fix Coverity issue in the NVDIMM driver

Summary

Coverity reports a potential memory leak in the nvdimm
driver. Examination shows it's real; fix it.

Sponsored by: Dell Technologies
MFC after: 1w

Test Plan

Changes in use at $WORK

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dab created this revision.Feb 19 2023, 8:31 PM

Herald added subscribers: badger, imp. · View Herald TranscriptFeb 19 2023, 8:31 PM

dab requested review of this revision.Feb 19 2023, 8:31 PM

Harbormaster completed remote builds in B49893: Diff 117598.Feb 19 2023, 8:31 PM

zlei added a subscriber: zlei.Feb 20 2023, 3:27 AM

LGTM

This revision is now accepted and ready to land.Feb 20 2023, 11:13 AM

vangyzen accepted this revision.Feb 21 2023, 1:42 PM

Approved.

Closed by commit rG3ff497061b33: Fix Coverity issue in the NVDIMM driver (authored by robert.herndon_dell.com, committed by dab). · Explain WhyFeb 23 2023, 2:43 AM

This revision was automatically updated to reflect the committed changes.

dab added a commit: rG3ff497061b33: Fix Coverity issue in the NVDIMM driver.

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvdimm/

nvdimm_acpi.c

10 lines

Diff 117795

View Options

sys/dev/nvdimm/nvdimm_acpi.c

Fix Coverity issue in the NVDIMM driverClosedPublicActions