Page MenuHomeFreeBSD

dab (David A. Bright)
Software Senior Principal Engineer

Projects

User Details

User Since
Jan 19 2016, 3:49 PM (151 w, 4 d)

Recent Activity

Wed, Dec 12

dab committed rS341988: asmc: Add Support for Macbook Pro 8,1.
asmc: Add Support for Macbook Pro 8,1
Wed, Dec 12, 1:45 PM

Tue, Dec 11

dab committed rS341820: asmc: Add Support for MacBookAir 7,1 and 7,2.
asmc: Add Support for MacBookAir 7,1 and 7,2
Tue, Dec 11, 4:36 PM
dab closed D18396: asmc: Add Support for MacBookAir 7,1 and 7,2.
Tue, Dec 11, 4:36 PM · Contributor Reviews (base)
dab committed rS341806: Add uk.macbook.kbd keymap (vt).
Add uk.macbook.kbd keymap (vt)
Tue, Dec 11, 2:14 AM
dab closed D18395: Add uk.macbook.kbd keymap (vt).
Tue, Dec 11, 2:14 AM · Contributor Reviews (base)
dab updated the summary of D18395: Add uk.macbook.kbd keymap (vt).
Tue, Dec 11, 12:59 AM · Contributor Reviews (base)

Sat, Dec 1

dab updated the diff for D18395: Add uk.macbook.kbd keymap (vt).

After commandeering the revision, updating it to make sure my diff is the same as the previously submitted diff.

Sat, Dec 1, 6:56 PM · Contributor Reviews (base)
dab added reviewers for D18396: asmc: Add Support for MacBookAir 7,1 and 7,2: rpaulo, adrian.

Adding @adrian and @rpaulo as reviewers, as they have been in this code before and might have input.

Sat, Dec 1, 6:50 PM · Contributor Reviews (base)
dab updated the diff for D18396: asmc: Add Support for MacBookAir 7,1 and 7,2.

After commandeering the revision, updating it to make sure my diff is
the same as the previously submitted diff.

Sat, Dec 1, 6:47 PM · Contributor Reviews (base)
dab commandeered D18396: asmc: Add Support for MacBookAir 7,1 and 7,2.

I'll take over this diff and get it committed to -CURRENT in the next few days.

Sat, Dec 1, 6:27 PM · Contributor Reviews (base)
dab commandeered D18395: Add uk.macbook.kbd keymap (vt).

Thanks. I'll take over this diff and get it committed to -CURRENT in the next few days. On what branch or revision did you test this? Do you need it applied to the stable/11 or stable/12?

Sat, Dec 1, 2:41 AM · Contributor Reviews (base)

Fri, Nov 30

dab added a comment to D18396: asmc: Add Support for MacBookAir 7,1 and 7,2.

@james.wright_jigsawdezign.com, do you need someone to help get this committed? I could do that if so. Can you update the review with information on testing you've done?

Fri, Nov 30, 11:32 PM · Contributor Reviews (base)
dab added a comment to D18395: Add uk.macbook.kbd keymap (vt).

@james.wright_jigsawdezign.com, do you need someone to help get this committed? I could do that if so. Can you update the review with information on testing you've done?

Fri, Nov 30, 11:32 PM · Contributor Reviews (base)
dab committed rS341275: MFC r337812,r337814,r337820,r341068:.
MFC r337812,r337814,r337820,r341068:
Fri, Nov 30, 2:07 AM
dab closed D16531: Fix panic when adding netmap device to kqueue..

This fix was (accidentally) committed in rS337812 and incorporated into the upcoming 12.0-RELEASE; I just noticed that now when I went to MFC that commit to stable/11. Closing the review now, considerably after the fact.

Fri, Nov 30, 1:57 AM
dab committed rS341274: MFC r341068:.
MFC r341068:
Fri, Nov 30, 1:46 AM

Tue, Nov 27

dab committed rS341068: Make whitespace more consistent in libkqueue tests..
Make whitespace more consistent in libkqueue tests.
Tue, Nov 27, 3:14 PM

Mon, Nov 19

dab accepted D2724: Include path for tmpfs objects in vm.objects sysctl.
Mon, Nov 19, 10:31 PM

Nov 8 2018

dab accepted D17898: in6_ifattach_linklocal: handle immediate removal of the new LLA.

@vangyzen, Looks OK to me but I'm curious how you ran across this situation.

Nov 8 2018, 2:35 AM

Sep 16 2018

dab added inline comments to D17115: Generate /etc/services from the IANA registry (plus local mods).
Sep 16 2018, 3:54 AM

Sep 15 2018

dab added a reviewer for D17115: Generate /etc/services from the IANA registry (plus local mods): dab.

@vangyzen -- Did you notice this:

Sep 15 2018, 11:19 PM

Aug 21 2018

dab accepted D16831: newsyslog(8): Reject configurations that specify setuid or executable logs.

Looks good.

Aug 21 2018, 10:04 PM
dab accepted D16831: newsyslog(8): Reject configurations that specify setuid or executable logs.
Aug 21 2018, 9:35 PM
dab added inline comments to D16831: newsyslog(8): Reject configurations that specify setuid or executable logs.
Aug 21 2018, 9:35 PM
dab added a comment to D16831: newsyslog(8): Reject configurations that specify setuid or executable logs.

I would also agree with issuing a warning, masking the offending permission bits, and continuing.

Aug 21 2018, 6:51 PM
dab added a comment to D16531: Fix panic when adding netmap device to kqueue..

This change has been merged upstream (netmap PR #520).

Aug 21 2018, 6:28 PM

Aug 14 2018

dab committed rS337820: Fix a couple whitespace errors in r337814..
Fix a couple whitespace errors in r337814.
Aug 14 2018, 8:27 PM
dab committed rS337814: Fix several (more) memory leaks..
Fix several (more) memory leaks.
Aug 14 2018, 7:31 PM
dab committed rS337812: Fix several memory leaks..
Fix several memory leaks.
Aug 14 2018, 7:13 PM

Aug 7 2018

dab committed rS337418: MFC r336761 & r336781:.
MFC r336761 & r336781:
Aug 7 2018, 2:39 PM

Jul 31 2018

dab created D16531: Fix panic when adding netmap device to kqueue..
Jul 31 2018, 5:03 PM

Jul 30 2018

dab committed rS336905: Correct possible misleading error message in kqtest..
Correct possible misleading error message in kqtest.
Jul 30 2018, 2:22 PM

Jul 28 2018

dab committed rS336802: Fix compilation error on some arches after r336761 & r336781..
Fix compilation error on some arches after r336761 & r336781.
Jul 28 2018, 2:54 AM

Jul 27 2018

dab committed rS336781: Fix compilation error on some arches after r336761..
Fix compilation error on some arches after r336761.
Jul 27 2018, 8:15 PM
dab committed rS336761: Allow a EVFILT_TIMER kevent to be updated..
Allow a EVFILT_TIMER kevent to be updated.
Jul 27 2018, 1:49 PM
dab closed D15778: Allow a EVFILT_TIMER kevent to be updated.
Jul 27 2018, 1:49 PM

Jul 24 2018

dab added a comment to D16434: Actually install bsd.dirs.mk.

Looks good to me.

Jul 24 2018, 10:07 PM

Jul 23 2018

dab committed rS336647: MFC r336457:.
MFC r336457:
Jul 23 2018, 6:47 PM
dab committed rS336646: MFC r336457:.
MFC r336457:
Jul 23 2018, 6:36 PM

Jul 18 2018

dab updated the diff for D15778: Allow a EVFILT_TIMER kevent to be updated.

Fix style issue pointed out by @kib.

Jul 18 2018, 1:09 PM
dab added inline comments to D15778: Allow a EVFILT_TIMER kevent to be updated.
Jul 18 2018, 1:07 PM
dab committed rS336457: Make the definition of struct kevent in event.h match what the man page for….
Make the definition of struct kevent in event.h match what the man page for…
Jul 18 2018, 1:04 PM

Jul 17 2018

dab added inline comments to D15778: Allow a EVFILT_TIMER kevent to be updated.
Jul 17 2018, 10:52 PM
dab added a comment to D15778: Allow a EVFILT_TIMER kevent to be updated.

This review has been languishing for a bit.

Jul 17 2018, 3:50 PM

Jul 12 2018

dab updated the diff for D15778: Allow a EVFILT_TIMER kevent to be updated.

Updating to rebase off latest head revision (rS336219). No functional
change from previous diff.

Jul 12 2018, 12:56 PM

Jul 11 2018

dab committed rS336200: MFC r335765, r335776, r336186:.
MFC r335765, r335776, r336186:
Jul 11 2018, 2:56 PM
dab committed rS336198: MFC r335765, r335776, r336186:.
MFC r335765, r335776, r336186:
Jul 11 2018, 2:50 PM
dab committed rS336186: Address some (although not all) style(9) issues in event.h after r335776..
Address some (although not all) style(9) issues in event.h after r335776.
Jul 11 2018, 2:09 AM

Jun 28 2018

dab committed rS335776: Fix compilation error in r335765 under gcc 4.2.1..
Fix compilation error in r335765 under gcc 4.2.1.
Jun 28 2018, 8:37 PM
dab closed D15679: Remove potential identifier conflict in the EV_SET macro..

Fixed by rS335765

Jun 28 2018, 5:13 PM
dab added 1 commit(s) for D15679: Remove potential identifier conflict in the EV_SET macro.: rS335765: Remove potential identifier conflict in the EV_SET macro..
Jun 28 2018, 5:11 PM
dab added an edge to rS335765: Remove potential identifier conflict in the EV_SET macro.: D15679: Remove potential identifier conflict in the EV_SET macro..
Jun 28 2018, 5:11 PM
dab committed rS335765: Remove potential identifier conflict in the EV_SET macro..
Remove potential identifier conflict in the EV_SET macro.
Jun 28 2018, 5:01 PM

Jun 20 2018

dab updated the summary of D15778: Allow a EVFILT_TIMER kevent to be updated.
Jun 20 2018, 11:14 PM
dab updated the diff for D15778: Allow a EVFILT_TIMER kevent to be updated.

Update to do several things:

Jun 20 2018, 11:02 PM
dab updated subscribers of D15778: Allow a EVFILT_TIMER kevent to be updated.
Jun 20 2018, 9:56 PM
dab updated subscribers of D15679: Remove potential identifier conflict in the EV_SET macro..

@jilles, @jmg : Any further input on this change?

Jun 20 2018, 9:29 PM

Jun 14 2018

dab updated the summary of D15778: Allow a EVFILT_TIMER kevent to be updated.
Jun 14 2018, 5:40 PM
dab updated the diff for D15778: Allow a EVFILT_TIMER kevent to be updated.

Add a test for the re-add of a timer.

Jun 14 2018, 3:38 PM
dab updated the diff for D15778: Allow a EVFILT_TIMER kevent to be updated.

Fix a small panic-inducing typo.

Jun 14 2018, 3:34 PM

Jun 13 2018

dab added a watcher for HardenedBSD: dab.
Jun 13 2018, 5:49 PM

Jun 12 2018

dab created D15778: Allow a EVFILT_TIMER kevent to be updated.
Jun 12 2018, 2:19 PM

Jun 11 2018

dab updated the diff for D15679: Remove potential identifier conflict in the EV_SET macro..

Revert an unintended change to the original EV_SET macro that crept into my last revision.

Jun 11 2018, 9:18 PM

Jun 8 2018

dab added inline comments to D15689: Including rc_conf_directories to be loaded with rc(8).
Jun 8 2018, 12:42 PM

Jun 7 2018

dab updated the summary of D15689: Including rc_conf_directories to be loaded with rc(8).
Jun 7 2018, 4:52 PM
dab added inline comments to D15689: Including rc_conf_directories to be loaded with rc(8).
Jun 7 2018, 4:51 PM
dab updated the diff for D15679: Remove potential identifier conflict in the EV_SET macro..

Add check for STDC_VERSION being defined before attempting to check its value.

Jun 7 2018, 1:11 AM

Jun 6 2018

dab updated the summary of D15679: Remove potential identifier conflict in the EV_SET macro..
Jun 6 2018, 7:16 PM
dab updated the test plan for D15679: Remove potential identifier conflict in the EV_SET macro..
Jun 6 2018, 7:10 PM
dab added inline comments to D15679: Remove potential identifier conflict in the EV_SET macro..
Jun 6 2018, 7:05 PM
dab created D15679: Remove potential identifier conflict in the EV_SET macro..
Jun 6 2018, 7:01 PM

May 18 2018

dab accepted D15459: Use __SCCSID for SCCS IDs in libkvm sources..

I'd prefer the blank line be dropped, but I don't feel strongly about it.

May 18 2018, 2:53 PM

Mar 19 2018

dab committed rS331217: MFC r331015:.
MFC r331015:
Mar 19 2018, 5:38 PM
dab committed rS331216: MFC r331015:.
MFC r331015:
Mar 19 2018, 5:38 PM

Mar 15 2018

dab committed rS331015: Modify rc.d/fsck to handle new status from fsck/fsck_ffs.
Modify rc.d/fsck to handle new status from fsck/fsck_ffs
Mar 15 2018, 6:30 PM
dab closed D14679: Modify rc.d/fsck to handle new status from fsck/fsck_ffs.
Mar 15 2018, 6:30 PM

Mar 13 2018

dab updated the summary of D14679: Modify rc.d/fsck to handle new status from fsck/fsck_ffs.
Mar 13 2018, 3:11 PM
dab created D14679: Modify rc.d/fsck to handle new status from fsck/fsck_ffs.
Mar 13 2018, 3:03 PM

Mar 9 2018

dab committed rS330695: MFC r330245:.
MFC r330245:
Mar 9 2018, 2:46 PM
dab committed rS330694: MFC r330245:.
MFC r330245:
Mar 9 2018, 2:45 PM
dab committed rS330693: MFC r330085:.
MFC r330085:
Mar 9 2018, 2:39 PM
dab committed rS330692: MFC r330085:.
MFC r330085:
Mar 9 2018, 2:38 PM

Mar 8 2018

dab committed rS330664: MFC r330034.
MFC r330034
Mar 8 2018, 5:14 PM
dab committed rS330661: MFC r330034.
MFC r330034
Mar 8 2018, 4:27 PM

Mar 5 2018

dab committed rS330512: MFC r330027.
MFC r330027
Mar 5 2018, 4:00 PM
dab committed rS330505: MFC r330027.
MFC r330027
Mar 5 2018, 1:58 PM

Mar 1 2018

dab closed D14519: Allow the "@" and "!" characters in passwd file GECOS fields..
Mar 1 2018, 5:47 PM
dab committed rS330245: Allow the "@" and "!" characters in passwd file GECOS fields..
Allow the "@" and "!" characters in passwd file GECOS fields.
Mar 1 2018, 5:47 PM

Feb 28 2018

dab added a reviewer for D14519: Allow the "@" and "!" characters in passwd file GECOS fields.: secteam.

I don't think this has any particular security implications, but adding the secteam as reviewer just in case.

Feb 28 2018, 9:29 PM

Feb 27 2018

dab closed D14527: dhclient violates RFC2131 when sending early DHCPREQUEST message to re-obtain old IP.
Feb 27 2018, 9:59 PM
dab committed rS330085: dhclient violates RFC2131 when sending early DHCPREQUEST message to re-obtain….
dhclient violates RFC2131 when sending early DHCPREQUEST message to re-obtain…
Feb 27 2018, 9:59 PM
dab accepted D14530: Revert r314685 in ps.
Feb 27 2018, 3:05 AM

Feb 26 2018

dab created D14527: dhclient violates RFC2131 when sending early DHCPREQUEST message to re-obtain old IP.
Feb 26 2018, 8:07 PM
dab committed rS330034: Fix two memory leaks in syslogd.
Fix two memory leaks in syslogd
Feb 26 2018, 7:28 PM
dab closed D14510: Fix two memory leaks in syslogd.
Feb 26 2018, 7:28 PM
dab committed rS330027: iconv uses strlen directly on user supplied memory.
iconv uses strlen directly on user supplied memory
Feb 26 2018, 6:24 PM
dab closed D14521: iconv uses strlen directly on user supplied memory.
Feb 26 2018, 6:24 PM
dab created D14521: iconv uses strlen directly on user supplied memory.
Feb 26 2018, 3:55 PM
dab updated the summary of D14519: Allow the "@" and "!" characters in passwd file GECOS fields..
Feb 26 2018, 3:31 PM
dab created D14519: Allow the "@" and "!" characters in passwd file GECOS fields..
Feb 26 2018, 3:28 PM