Page MenuHomeFreeBSD

dab (David A. Bright)
Software Senior Principal Engineer

Projects

User Details

User Since
Jan 19 2016, 3:49 PM (243 w, 5 d)

Recent Activity

Fri, Sep 18

dab updated the diff for D26390: Honor the FWUG value of some drives in nvmecontrol.

Allocate the buffer based on max_xfer_size as suggested by a review comment.

Fri, Sep 18, 2:43 PM

Wed, Sep 16

dab added inline comments to D26390: Honor the FWUG value of some drives in nvmecontrol.
Wed, Sep 16, 1:30 PM
dab updated the diff for D26390: Honor the FWUG value of some drives in nvmecontrol.

Combine statements that calculate the transfer size as suggested by review comments.

Wed, Sep 16, 1:25 PM

Thu, Sep 10

dab requested review of D26390: Honor the FWUG value of some drives in nvmecontrol.
Thu, Sep 10, 1:11 PM

Jul 15 2020

dab committed rS363231: MFC r362634:.
MFC r362634:
Jul 15 2020, 5:34 PM

Jun 25 2020

dab committed rS362634: Add CAP_EVENT to pidfiles..
Add CAP_EVENT to pidfiles.
Jun 25 2020, 9:34 PM
dab closed D25363: Add CAP_EVENT to pidfiles..
Jun 25 2020, 9:34 PM

Jun 23 2020

dab added a comment to D25363: Add CAP_EVENT to pidfiles..
In D25363#559516, @cem wrote:

Do delete events actually notify on the deleted file? I would expect to receive a notification on the pid's parent directory, but am not sure about the pid file itself.

Jun 23 2020, 7:09 PM
dab requested review of D25363: Add CAP_EVENT to pidfiles..
Jun 23 2020, 3:22 AM

Jun 18 2020

dab added a comment to D25312: Relax the rule against declaring variables in nested scopes..
In D25312#558449, @jhb wrote:

BTW, one thing this leaves ambiguous is [whether] you can declare variables in the middle of blocks vs at the beginning. That is:

Jun 18 2020, 9:23 AM
dab accepted D25312: Relax the rule against declaring variables in nested scopes..
Jun 18 2020, 9:18 AM

May 14 2020

dab committed rS361030: MFC r360568:.
MFC r360568:
May 14 2020, 12:52 PM

May 2 2020

dab committed rS360568: Fix various Coverity-detected errors in nvme driver.
Fix various Coverity-detected errors in nvme driver
May 2 2020, 8:48 PM
dab closed D24532: Fix various Coverity-detected errors in nvme driver.
May 2 2020, 8:48 PM

May 1 2020

dab updated the diff for D24532: Fix various Coverity-detected errors in nvme driver.

Switch from a (uint64_t) cast to specifying ULL on a numeric constant
to widen the data type of an expression (suggested by imp@).

May 1 2020, 9:25 PM
dab added inline comments to D24532: Fix various Coverity-detected errors in nvme driver.
May 1 2020, 1:41 PM
dab updated the diff for D24532: Fix various Coverity-detected errors in nvme driver.

Changes based on some review comments.

May 1 2020, 2:39 AM
dab added inline comments to D24532: Fix various Coverity-detected errors in nvme driver.
May 1 2020, 2:37 AM

Apr 30 2020

dab updated the diff for D24532: Fix various Coverity-detected errors in nvme driver.

Changes based on some review comments.

Apr 30 2020, 11:21 PM

Apr 29 2020

dab added inline comments to D23963: netgraph/ng_bridge: Introduce "uplink" ports without MAC learning.
Apr 29 2020, 12:44 PM

Apr 23 2020

dab added inline comments to D24532: Fix various Coverity-detected errors in nvme driver.
Apr 23 2020, 8:57 PM
dab retitled D24532: Fix various Coverity-detected errors in nvme driver from Fix various Coverity-detected errors in nvmecontrol to Fix various Coverity-detected errors in nvme driver.
Apr 23 2020, 3:34 PM

Apr 22 2020

dab updated the test plan for D24532: Fix various Coverity-detected errors in nvme driver.
Apr 22 2020, 2:03 PM
dab updated the test plan for D24532: Fix various Coverity-detected errors in nvme driver.
Apr 22 2020, 2:02 PM
dab added inline comments to D24532: Fix various Coverity-detected errors in nvme driver.
Apr 22 2020, 1:56 PM
dab created D24532: Fix various Coverity-detected errors in nvme driver.
Apr 22 2020, 1:49 PM

Apr 12 2020

dab committed rS359838: MFC r359717:.
MFC r359717:
Apr 12 2020, 10:11 PM

Apr 9 2020

dab committed rS359751: MFC r359562:.
MFC r359562:
Apr 9 2020, 6:17 PM

Apr 7 2020

dab closed D24269: Add a basic test for nvmecontrol.
Apr 7 2020, 8:26 PM
dab committed rS359717: Add a basic test for nvmecontrol.
Add a basic test for nvmecontrol
Apr 7 2020, 8:26 PM

Apr 6 2020

dab updated the diff for D24269: Add a basic test for nvmecontrol.

Let's try uploading that diff again...

Apr 6 2020, 9:11 PM
dab updated the diff for D24269: Add a basic test for nvmecontrol.

Modify the test to handle the nvme drives not starting at 0. I don't
think that is likely, but it is easy enough to handle.

Apr 6 2020, 9:07 PM
dab updated subscribers of D24284: Revamp nvme recovery.
Apr 6 2020, 12:27 PM

Apr 5 2020

dab accepted D24297: Make include/malloc.h usable again..
Apr 5 2020, 11:05 PM

Apr 3 2020

dab updated the diff for D24269: Add a basic test for nvmecontrol.

Fix a problem in the devlist test when /dev/nvme0 does _not_ exist.

Apr 3 2020, 5:55 PM
dab created D24269: Add a basic test for nvmecontrol.
Apr 3 2020, 12:23 AM

Apr 2 2020

dab committed rS359562: Fix various Coverity-detected errors in nvmecontrol.
Fix various Coverity-detected errors in nvmecontrol
Apr 2 2020, 1:53 PM
dab closed D24203: Fix various Coverity-detected errors in nvmecontrol.
Apr 2 2020, 1:53 PM

Mar 31 2020

dab updated the summary of D24203: Fix various Coverity-detected errors in nvmecontrol.
Mar 31 2020, 8:47 PM
dab updated the diff for D24203: Fix various Coverity-detected errors in nvmecontrol.

Remove the shared library unloading code at imp@'s suggestion.

Mar 31 2020, 8:44 PM

Mar 30 2020

dab added inline comments to D24203: Fix various Coverity-detected errors in nvmecontrol.
Mar 30 2020, 2:55 AM
dab updated the diff for D24203: Fix various Coverity-detected errors in nvmecontrol.

Address comment about check on fd > -1 not being needed in passthru.c.

Mar 30 2020, 2:55 AM
dab updated the diff for D24203: Fix various Coverity-detected errors in nvmecontrol.

Correct diff; the previous one had some unintended files included.

Mar 30 2020, 2:43 AM

Mar 29 2020

dab added inline comments to D24203: Fix various Coverity-detected errors in nvmecontrol.
Mar 29 2020, 11:46 PM
dab updated the diff for D24203: Fix various Coverity-detected errors in nvmecontrol.

Fix a couple issues pointed out in review comments.

Mar 29 2020, 11:43 PM
dab added inline comments to D24203: Fix various Coverity-detected errors in nvmecontrol.
Mar 29 2020, 11:32 PM

Mar 27 2020

dab created D24203: Fix various Coverity-detected errors in nvmecontrol.
Mar 27 2020, 1:35 PM

Mar 23 2020

dab committed rS359237: MFC r359129:.
MFC r359129:
Mar 23 2020, 12:39 PM
dab committed rS359236: MFC r359129:.
MFC r359129:
Mar 23 2020, 12:38 PM

Mar 19 2020

dab committed rS359129: Fix parameter reversal potentially causing buffer overrun..
Fix parameter reversal potentially causing buffer overrun.
Mar 19 2020, 12:22 PM
dab closed D24117: Fix parameter reversal potentially causing buffer overrun..
Mar 19 2020, 12:22 PM

Mar 18 2020

dab added a comment to D24117: Fix parameter reversal potentially causing buffer overrun..

Wow, that API is unfortunate.

Mar 18 2020, 9:09 PM
dab created D24117: Fix parameter reversal potentially causing buffer overrun..
Mar 18 2020, 6:15 PM

Nov 19 2019

dab committed rS354854: Don't sanitize linker_set.
Don't sanitize linker_set
Nov 19 2019, 2:46 PM
dab closed D22239: Don't sanitize linker_set.
Nov 19 2019, 2:46 PM

Nov 18 2019

dab committed rS354808: Jail and capability mode for shm_rename; add audit support for shm_rename.
Jail and capability mode for shm_rename; add audit support for shm_rename
Nov 18 2019, 1:31 PM
dab closed D22083: Jail and capability mode for shm_rename; add audit support for shm_rename.
Nov 18 2019, 1:31 PM

Sep 26 2019

dab committed rS352756: Correct mistake in MLINKS introduced in r352747.
Correct mistake in MLINKS introduced in r352747
Sep 26 2019, 4:13 PM
dab committed rS352751: sysent: regenerate after r352747..
sysent: regenerate after r352747.
Sep 26 2019, 3:41 PM
dab committed rS352747: Add an shm_rename syscall.
Add an shm_rename syscall
Sep 26 2019, 3:32 PM
dab closed D21423: Add an shm_rename syscall.
Sep 26 2019, 3:32 PM

Sep 23 2019

dab updated the diff for D21423: Add an shm_rename syscall.

Made requested man page changes.

Sep 23 2019, 3:09 PM

Sep 9 2019

dab updated the diff for D21423: Add an shm_rename syscall.

Updated to account for another syscall that was recently added.

Sep 9 2019, 2:48 PM
dab updated the diff for D21423: Add an shm_rename syscall.

Updated to account for another syscall that was recently added.

Sep 9 2019, 2:40 PM

Sep 6 2019

dab commandeered D21423: Add an shm_rename syscall.

Someone snuck in another syscall. I'll update and commit this.

Sep 6 2019, 3:57 PM

Aug 30 2019

dab added a comment to D21423: Add an shm_rename syscall.

Looks good, Matthew; just a couple nits. It would be nice if you could upload a full-context diff with any further changes. When you think it is ready, I'll be happy to carry this through to commit.

Aug 30 2019, 4:46 PM

Jun 6 2019

dab accepted D20529: bhyve: fix reporting of virtio scsi seg_max.
Jun 6 2019, 1:53 AM

Apr 13 2019

dab accepted D19902: bsearc.3: Add EXAMPLES section.
Apr 13 2019, 7:59 PM

Apr 12 2019

dab accepted D19426: post-commit hooks: Accept BZ URLs in PR lines.
Apr 12 2019, 8:43 PM

Mar 25 2019

dab committed rS345508: MFC r345009:.
MFC r345009:
Mar 25 2019, 5:04 PM
dab committed rS345507: MFC r345009:.
MFC r345009:
Mar 25 2019, 5:04 PM
dab committed rS345506: MFC r345009:.
MFC r345009:
Mar 25 2019, 5:04 PM

Mar 11 2019

dab committed rS345009: Fix a scribbler in the PMS driver..
Fix a scribbler in the PMS driver.
Mar 11 2019, 2:27 PM
dab closed D19398: Fix a scribbler in the PMS driver..
Mar 11 2019, 2:27 PM

Mar 8 2019

dab added inline comments to D19495: bhyve - Snapshot Save and Restore.
Mar 8 2019, 1:17 PM · bhyve
dab added inline comments to D19495: bhyve - Snapshot Save and Restore.
Mar 8 2019, 4:57 AM · bhyve

Mar 7 2019

dab committed rS344889: MFC r344553:.
MFC r344553:
Mar 7 2019, 3:31 PM
dab committed rS344888: MFC r344553:.
MFC r344553:
Mar 7 2019, 3:31 PM
dab committed rS344882: MFC r344470:.
MFC r344470:
Mar 7 2019, 1:11 PM
dab committed rS344881: MFC r344470:.
MFC r344470:
Mar 7 2019, 1:11 PM
dab committed rS344880: MFC r344470:.
MFC r344470:
Mar 7 2019, 1:10 PM

Feb 28 2019

dab updated the diff for D19398: Fix a scribbler in the PMS driver..

Minor whitespace cleanup.

Feb 28 2019, 12:10 AM

Feb 27 2019

dab created D19398: Fix a scribbler in the PMS driver..
Feb 27 2019, 11:53 PM
dab committed rS344646: MFC r344473:.
MFC r344473:
Feb 27 2019, 10:29 PM
dab committed rS344645: MFC r344473:.
MFC r344473:
Feb 27 2019, 10:29 PM
dab committed rS344644: MFC r344473:.
MFC r344473:
Feb 27 2019, 10:29 PM

Feb 25 2019

dab committed rS344553: asmc: Add support for Mac mini 2,1.
asmc: Add support for Mac mini 2,1
Feb 25 2019, 9:59 PM

Feb 22 2019

dab committed rS344473: CID 1332000: Logically dead code in sys/dev/pms/RefTisa/tisa/sassata/sas/ini/it….
CID 1332000: Logically dead code in sys/dev/pms/RefTisa/tisa/sassata/sas/ini/it…
Feb 22 2019, 6:43 PM
dab closed D19165: CID 1332000: Logically dead code in sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c.
Feb 22 2019, 6:43 PM
dab committed rS344470: Fix several Coverity-detected issues in newsyslog..
Fix several Coverity-detected issues in newsyslog.
Feb 22 2019, 3:32 PM
dab closed D19105: CID 1008620: Logically dead code in newsyslog.c.
Feb 22 2019, 3:32 PM
dab reopened D19105: CID 1008620: Logically dead code in newsyslog.c.

Reverted the change and am re-committing without these changes:

Feb 22 2019, 3:31 PM
dab committed rS344468: Revert r344389 & r343906 - Fix Coverity errors in newsyslog.
Revert r344389 & r343906 - Fix Coverity errors in newsyslog
Feb 22 2019, 2:59 PM

Feb 20 2019

dab committed rS344394: MFC r344024:.
MFC r344024:
Feb 20 2019, 10:49 PM
dab committed rS344393: MFC r344024:.
MFC r344024:
Feb 20 2019, 10:49 PM
dab committed rS344392: MFC r344024:.
MFC r344024:
Feb 20 2019, 10:48 PM
dab committed rS344389: Complete fix for CID 1007454, CID 1007453: Resource leak in newsyslog.
Complete fix for CID 1007454, CID 1007453: Resource leak in newsyslog
Feb 20 2019, 10:05 PM

Feb 12 2019

dab added a comment to D19168: CID 1332078: Logically dead code in sys/dev/pms/freebsd/driver/ini/src/osapi.c.

Yes, I did change the logic. This turned out to be a more interesting issue than I had initially thought. At $WORK we also have bug fix in this area, but it differs from mine. I'm working on getting a good review, reconciling the changes, and adequate testing. So, this shouldn't be thought of as a finished work (yet).

Feb 12 2019, 10:35 PM
dab added a comment to D19168: CID 1332078: Logically dead code in sys/dev/pms/freebsd/driver/ini/src/osapi.c.

I can test on hardware at $WORK. As to it being vendor code, although the driver was imported from PMC-Sierra 3 years ago, it doesn't look to me like any updates have come from them since. If you know of a source of updated vendor code, can you point me to it?

Feb 12 2019, 7:33 PM
dab updated the diff for D19168: CID 1332078: Logically dead code in sys/dev/pms/freebsd/driver/ini/src/osapi.c.

Remove stray file from this review.

Feb 12 2019, 7:29 PM