Page MenuHomeFreeBSD

dab (David A. Bright)
Software Senior Principal Engineer

Projects

User Details

User Since
Jan 19 2016, 3:49 PM (282 w, 3 d)

Recent Activity

Wed, Jun 9

dab committed R10:fe58db828934: pciconf: Fix up pciconf -lc output (authored by dab).
pciconf: Fix up pciconf -lc output
Wed, Jun 9, 4:20 PM
dab committed R10:7f06d6f3fdde: pciconf: Fix up pciconf -lc output (authored by dab).
pciconf: Fix up pciconf -lc output
Wed, Jun 9, 4:19 PM
dab committed R10:80a5d786a3cd: libsa: Fix infinite loop in bzipfs & gzipfs (authored by dab).
libsa: Fix infinite loop in bzipfs & gzipfs
Wed, Jun 9, 4:17 PM
dab committed R10:3045f4aa1a2b: libsa: Fix infinite loop in bzipfs & gzipfs (authored by dab).
libsa: Fix infinite loop in bzipfs & gzipfs
Wed, Jun 9, 4:15 PM

Tue, Jun 1

dab committed R10:3df4c387d2e3: libsa: Fix infinite loop in bzipfs & gzipfs (authored by dab).
libsa: Fix infinite loop in bzipfs & gzipfs
Tue, Jun 1, 4:09 PM
dab closed D30414: libsa: Fix infinite loop in bzipfs & gzipfs.
Tue, Jun 1, 4:08 PM
dab committed R10:2f176a2b2010: pciconf: Fix up pciconf -lc output (authored by dab).
pciconf: Fix up pciconf -lc output
Tue, Jun 1, 3:56 PM
dab closed D30441: pciconf: Fix up pciconf -lc output.
Tue, Jun 1, 3:56 PM

Wed, May 26

dab added inline comments to D30414: libsa: Fix infinite loop in bzipfs & gzipfs.
Wed, May 26, 12:29 PM

Tue, May 25

dab added inline comments to D30414: libsa: Fix infinite loop in bzipfs & gzipfs.
Tue, May 25, 10:04 PM
dab updated the diff for D30414: libsa: Fix infinite loop in bzipfs & gzipfs.
  • Fix typo
Tue, May 25, 10:03 PM
dab updated the test plan for D30441: pciconf: Fix up pciconf -lc output.
Tue, May 25, 1:14 PM
dab updated the summary of D30414: libsa: Fix infinite loop in bzipfs & gzipfs.
Tue, May 25, 1:49 AM

Mon, May 24

dab updated the test plan for D30441: pciconf: Fix up pciconf -lc output.
Mon, May 24, 8:50 PM
dab retitled D30441: pciconf: Fix up pciconf -lc output from Fix up pciconf -lc output to pciconf: Fix up pciconf -lc output.
Mon, May 24, 7:20 PM
dab requested review of D30441: pciconf: Fix up pciconf -lc output.
Mon, May 24, 7:18 PM
dab updated the diff for D30414: libsa: Fix infinite loop in bzipfs & gzipfs.
  • Shorten comment
Mon, May 24, 5:30 PM
dab requested review of D30414: libsa: Fix infinite loop in bzipfs & gzipfs.
Mon, May 24, 5:27 PM

Apr 29 2021

dab accepted D29993: EFI secure boot VECTX related changes.
Apr 29 2021, 4:30 PM
dab accepted D30007: ipmi: support getting address from EFI.
Apr 29 2021, 2:44 PM

Apr 27 2021

dab requested changes to D30007: ipmi: support getting address from EFI.

Looks good; just a few style nits.

Apr 27 2021, 1:46 PM

Apr 26 2021

dab accepted D29993: EFI secure boot VECTX related changes.
Apr 26 2021, 3:33 PM

Apr 6 2021

dab accepted D29606: uefisign: handle empty sections.
Apr 6 2021, 3:48 PM

Apr 2 2021

dab accepted D29276: smbios: support getting address from EFI.
Apr 2 2021, 4:15 PM

Mar 31 2021

dab added a comment to D29276: smbios: support getting address from EFI.

Looks pretty good. I would agree that it should be tested on a LEGACY (non-UEFI) BIOS.

Mar 31 2021, 6:22 PM
dab accepted D29512: Loader: support booting OS from memory disk (MD).

LGTM

Mar 31 2021, 3:21 PM
dab accepted D29270: ipmi,smbios: move smbios_walk_table to smbios.h.

LGTM

Mar 31 2021, 1:59 PM

Oct 22 2020

dab added a reviewer for D26895: db_search_symbol: prevent pollution from bogus symbols: dab.
Oct 22 2020, 1:55 AM
dab added a comment to D26895: db_search_symbol: prevent pollution from bogus symbols.

Seems reasonable, although I think the explanation from your description of this change should really go in the code comment rather than the rather terse and enigmatic "Prevent pollution from bogus symbols".

Oct 22 2020, 1:54 AM

Oct 1 2020

dab accepted D26616: zgrep: fix exit status with multiple files.
Oct 1 2020, 1:30 AM

Sep 29 2020

dab committed rS366262: MFC r365967:.
MFC r365967:
Sep 29 2020, 5:10 PM
dab committed rS366261: MFC r365948:.
MFC r365948:
Sep 29 2020, 4:39 PM
dab committed rS366255: MFC r365946:.
MFC r365946:
Sep 29 2020, 3:00 PM

Sep 21 2020

dab committed rS365967: Whitespace fix after r365948.
Whitespace fix after r365948
Sep 21 2020, 6:34 PM
dab committed rS365948: Honor the FWUG value of some drives in nvmecontrol.
Honor the FWUG value of some drives in nvmecontrol
Sep 21 2020, 3:46 PM
dab closed D26390: Honor the FWUG value of some drives in nvmecontrol.
Sep 21 2020, 3:42 PM
dab committed rS365946: Add an ioctl to get an NVMe device's maximum transfer size.
Add an ioctl to get an NVMe device's maximum transfer size
Sep 21 2020, 3:42 PM

Sep 18 2020

dab updated the diff for D26390: Honor the FWUG value of some drives in nvmecontrol.

Allocate the buffer based on max_xfer_size as suggested by a review comment.

Sep 18 2020, 2:43 PM

Sep 16 2020

dab added inline comments to D26390: Honor the FWUG value of some drives in nvmecontrol.
Sep 16 2020, 1:30 PM
dab updated the diff for D26390: Honor the FWUG value of some drives in nvmecontrol.

Combine statements that calculate the transfer size as suggested by review comments.

Sep 16 2020, 1:25 PM

Sep 10 2020

dab requested review of D26390: Honor the FWUG value of some drives in nvmecontrol.
Sep 10 2020, 1:11 PM

Jul 15 2020

dab committed rS363231: MFC r362634:.
MFC r362634:
Jul 15 2020, 5:34 PM

Jun 25 2020

dab committed rS362634: Add CAP_EVENT to pidfiles..
Add CAP_EVENT to pidfiles.
Jun 25 2020, 9:34 PM
dab closed D25363: Add CAP_EVENT to pidfiles..
Jun 25 2020, 9:34 PM

Jun 23 2020

dab added a comment to D25363: Add CAP_EVENT to pidfiles..
In D25363#559516, @cem wrote:

Do delete events actually notify on the deleted file? I would expect to receive a notification on the pid's parent directory, but am not sure about the pid file itself.

Jun 23 2020, 7:09 PM
dab requested review of D25363: Add CAP_EVENT to pidfiles..
Jun 23 2020, 3:22 AM

Jun 18 2020

dab added a comment to D25312: Relax the rule against declaring variables in nested scopes..
In D25312#558449, @jhb wrote:

BTW, one thing this leaves ambiguous is [whether] you can declare variables in the middle of blocks vs at the beginning. That is:

Jun 18 2020, 9:23 AM
dab accepted D25312: Relax the rule against declaring variables in nested scopes..
Jun 18 2020, 9:18 AM

May 14 2020

dab committed rS361030: MFC r360568:.
MFC r360568:
May 14 2020, 12:52 PM

May 2 2020

dab committed rS360568: Fix various Coverity-detected errors in nvme driver.
Fix various Coverity-detected errors in nvme driver
May 2 2020, 8:48 PM
dab closed D24532: Fix various Coverity-detected errors in nvme driver.
May 2 2020, 8:48 PM

May 1 2020

dab updated the diff for D24532: Fix various Coverity-detected errors in nvme driver.

Switch from a (uint64_t) cast to specifying ULL on a numeric constant
to widen the data type of an expression (suggested by imp@).

May 1 2020, 9:25 PM
dab added inline comments to D24532: Fix various Coverity-detected errors in nvme driver.
May 1 2020, 1:41 PM
dab updated the diff for D24532: Fix various Coverity-detected errors in nvme driver.

Changes based on some review comments.

May 1 2020, 2:39 AM
dab added inline comments to D24532: Fix various Coverity-detected errors in nvme driver.
May 1 2020, 2:37 AM

Apr 30 2020

dab updated the diff for D24532: Fix various Coverity-detected errors in nvme driver.

Changes based on some review comments.

Apr 30 2020, 11:21 PM

Apr 29 2020

dab added inline comments to D23963: netgraph/ng_bridge: Introduce "uplink" ports without MAC learning.
Apr 29 2020, 12:44 PM

Apr 23 2020

dab added inline comments to D24532: Fix various Coverity-detected errors in nvme driver.
Apr 23 2020, 8:57 PM
dab retitled D24532: Fix various Coverity-detected errors in nvme driver from Fix various Coverity-detected errors in nvmecontrol to Fix various Coverity-detected errors in nvme driver.
Apr 23 2020, 3:34 PM

Apr 22 2020

dab updated the test plan for D24532: Fix various Coverity-detected errors in nvme driver.
Apr 22 2020, 2:03 PM
dab updated the test plan for D24532: Fix various Coverity-detected errors in nvme driver.
Apr 22 2020, 2:02 PM
dab added inline comments to D24532: Fix various Coverity-detected errors in nvme driver.
Apr 22 2020, 1:56 PM
dab created D24532: Fix various Coverity-detected errors in nvme driver.
Apr 22 2020, 1:49 PM

Apr 12 2020

dab committed rS359838: MFC r359717:.
MFC r359717:
Apr 12 2020, 10:11 PM

Apr 9 2020

dab committed rS359751: MFC r359562:.
MFC r359562:
Apr 9 2020, 6:17 PM

Apr 7 2020

dab closed D24269: Add a basic test for nvmecontrol.
Apr 7 2020, 8:26 PM
dab committed rS359717: Add a basic test for nvmecontrol.
Add a basic test for nvmecontrol
Apr 7 2020, 8:26 PM

Apr 6 2020

dab updated the diff for D24269: Add a basic test for nvmecontrol.

Let's try uploading that diff again...

Apr 6 2020, 9:11 PM
dab updated the diff for D24269: Add a basic test for nvmecontrol.

Modify the test to handle the nvme drives not starting at 0. I don't
think that is likely, but it is easy enough to handle.

Apr 6 2020, 9:07 PM
dab updated subscribers of D24284: Revamp nvme recovery.
Apr 6 2020, 12:27 PM

Apr 5 2020

dab accepted D24297: Make include/malloc.h usable again..
Apr 5 2020, 11:05 PM

Apr 3 2020

dab updated the diff for D24269: Add a basic test for nvmecontrol.

Fix a problem in the devlist test when /dev/nvme0 does _not_ exist.

Apr 3 2020, 5:55 PM
dab created D24269: Add a basic test for nvmecontrol.
Apr 3 2020, 12:23 AM

Apr 2 2020

dab committed rS359562: Fix various Coverity-detected errors in nvmecontrol.
Fix various Coverity-detected errors in nvmecontrol
Apr 2 2020, 1:53 PM
dab closed D24203: Fix various Coverity-detected errors in nvmecontrol.
Apr 2 2020, 1:53 PM

Mar 31 2020

dab updated the summary of D24203: Fix various Coverity-detected errors in nvmecontrol.
Mar 31 2020, 8:47 PM
dab updated the diff for D24203: Fix various Coverity-detected errors in nvmecontrol.

Remove the shared library unloading code at imp@'s suggestion.

Mar 31 2020, 8:44 PM

Mar 30 2020

dab added inline comments to D24203: Fix various Coverity-detected errors in nvmecontrol.
Mar 30 2020, 2:55 AM
dab updated the diff for D24203: Fix various Coverity-detected errors in nvmecontrol.

Address comment about check on fd > -1 not being needed in passthru.c.

Mar 30 2020, 2:55 AM
dab updated the diff for D24203: Fix various Coverity-detected errors in nvmecontrol.

Correct diff; the previous one had some unintended files included.

Mar 30 2020, 2:43 AM

Mar 29 2020

dab added inline comments to D24203: Fix various Coverity-detected errors in nvmecontrol.
Mar 29 2020, 11:46 PM
dab updated the diff for D24203: Fix various Coverity-detected errors in nvmecontrol.

Fix a couple issues pointed out in review comments.

Mar 29 2020, 11:43 PM
dab added inline comments to D24203: Fix various Coverity-detected errors in nvmecontrol.
Mar 29 2020, 11:32 PM

Mar 27 2020

dab created D24203: Fix various Coverity-detected errors in nvmecontrol.
Mar 27 2020, 1:35 PM

Mar 23 2020

dab committed rS359237: MFC r359129:.
MFC r359129:
Mar 23 2020, 12:39 PM
dab committed rS359236: MFC r359129:.
MFC r359129:
Mar 23 2020, 12:38 PM

Mar 19 2020

dab committed rS359129: Fix parameter reversal potentially causing buffer overrun..
Fix parameter reversal potentially causing buffer overrun.
Mar 19 2020, 12:22 PM
dab closed D24117: Fix parameter reversal potentially causing buffer overrun..
Mar 19 2020, 12:22 PM

Mar 18 2020

dab added a comment to D24117: Fix parameter reversal potentially causing buffer overrun..

Wow, that API is unfortunate.

Mar 18 2020, 9:09 PM
dab created D24117: Fix parameter reversal potentially causing buffer overrun..
Mar 18 2020, 6:15 PM

Nov 19 2019

dab committed rS354854: Don't sanitize linker_set.
Don't sanitize linker_set
Nov 19 2019, 2:46 PM
dab closed D22239: Don't sanitize linker_set.
Nov 19 2019, 2:46 PM

Nov 18 2019

dab committed rS354808: Jail and capability mode for shm_rename; add audit support for shm_rename.
Jail and capability mode for shm_rename; add audit support for shm_rename
Nov 18 2019, 1:31 PM
dab closed D22083: Jail and capability mode for shm_rename; add audit support for shm_rename.
Nov 18 2019, 1:31 PM

Sep 26 2019

dab committed rS352756: Correct mistake in MLINKS introduced in r352747.
Correct mistake in MLINKS introduced in r352747
Sep 26 2019, 4:13 PM
dab committed rS352751: sysent: regenerate after r352747..
sysent: regenerate after r352747.
Sep 26 2019, 3:41 PM
dab committed rS352747: Add an shm_rename syscall.
Add an shm_rename syscall
Sep 26 2019, 3:32 PM
dab closed D21423: Add an shm_rename syscall.
Sep 26 2019, 3:32 PM

Sep 23 2019

dab updated the diff for D21423: Add an shm_rename syscall.

Made requested man page changes.

Sep 23 2019, 3:09 PM

Sep 9 2019

dab updated the diff for D21423: Add an shm_rename syscall.

Updated to account for another syscall that was recently added.

Sep 9 2019, 2:48 PM