Page MenuHomeFreeBSD

dab (David A. Bright)
Software Senior Principal Engineer

Projects

User Details

User Since
Jan 19 2016, 3:49 PM (191 w, 18 h)

Recent Activity

Mon, Sep 9

dab updated the diff for D21423: Add an shm_rename syscall.

Updated to account for another syscall that was recently added.

Mon, Sep 9, 2:48 PM
dab updated the diff for D21423: Add an shm_rename syscall.

Updated to account for another syscall that was recently added.

Mon, Sep 9, 2:40 PM

Fri, Sep 6

dab commandeered D21423: Add an shm_rename syscall.

Someone snuck in another syscall. I'll update and commit this.

Fri, Sep 6, 3:57 PM

Fri, Aug 30

dab added a comment to D21423: Add an shm_rename syscall.

Looks good, Matthew; just a couple nits. It would be nice if you could upload a full-context diff with any further changes. When you think it is ready, I'll be happy to carry this through to commit.

Fri, Aug 30, 4:46 PM

Jun 6 2019

dab accepted D20529: bhyve: fix reporting of virtio scsi seg_max.
Jun 6 2019, 1:53 AM

Apr 13 2019

dab accepted D19902: bsearc.3: Add EXAMPLES section.
Apr 13 2019, 7:59 PM

Apr 12 2019

dab accepted D19426: post-commit hooks: Accept BZ URLs in PR lines.
Apr 12 2019, 8:43 PM

Mar 25 2019

dab committed rS345508: MFC r345009:.
MFC r345009:
Mar 25 2019, 5:04 PM
dab committed rS345507: MFC r345009:.
MFC r345009:
Mar 25 2019, 5:04 PM
dab committed rS345506: MFC r345009:.
MFC r345009:
Mar 25 2019, 5:04 PM

Mar 11 2019

dab committed rS345009: Fix a scribbler in the PMS driver..
Fix a scribbler in the PMS driver.
Mar 11 2019, 2:27 PM
dab closed D19398: Fix a scribbler in the PMS driver..
Mar 11 2019, 2:27 PM

Mar 8 2019

dab added inline comments to D19495: bhyve - Snapshot Save and Restore.
Mar 8 2019, 1:17 PM · bhyve
dab added inline comments to D19495: bhyve - Snapshot Save and Restore.
Mar 8 2019, 4:57 AM · bhyve

Mar 7 2019

dab committed rS344889: MFC r344553:.
MFC r344553:
Mar 7 2019, 3:31 PM
dab committed rS344888: MFC r344553:.
MFC r344553:
Mar 7 2019, 3:31 PM
dab committed rS344882: MFC r344470:.
MFC r344470:
Mar 7 2019, 1:11 PM
dab committed rS344881: MFC r344470:.
MFC r344470:
Mar 7 2019, 1:11 PM
dab committed rS344880: MFC r344470:.
MFC r344470:
Mar 7 2019, 1:10 PM

Feb 28 2019

dab updated the diff for D19398: Fix a scribbler in the PMS driver..

Minor whitespace cleanup.

Feb 28 2019, 12:10 AM

Feb 27 2019

dab created D19398: Fix a scribbler in the PMS driver..
Feb 27 2019, 11:53 PM
dab committed rS344646: MFC r344473:.
MFC r344473:
Feb 27 2019, 10:29 PM
dab committed rS344645: MFC r344473:.
MFC r344473:
Feb 27 2019, 10:29 PM
dab committed rS344644: MFC r344473:.
MFC r344473:
Feb 27 2019, 10:29 PM

Feb 25 2019

dab committed rS344553: asmc: Add support for Mac mini 2,1.
asmc: Add support for Mac mini 2,1
Feb 25 2019, 9:59 PM

Feb 22 2019

dab committed rS344473: CID 1332000: Logically dead code in sys/dev/pms/RefTisa/tisa/sassata/sas/ini/it….
CID 1332000: Logically dead code in sys/dev/pms/RefTisa/tisa/sassata/sas/ini/it…
Feb 22 2019, 6:43 PM
dab closed D19165: CID 1332000: Logically dead code in sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c.
Feb 22 2019, 6:43 PM
dab committed rS344470: Fix several Coverity-detected issues in newsyslog..
Fix several Coverity-detected issues in newsyslog.
Feb 22 2019, 3:32 PM
dab closed D19105: CID 1008620: Logically dead code in newsyslog.c.
Feb 22 2019, 3:32 PM
dab reopened D19105: CID 1008620: Logically dead code in newsyslog.c.

Reverted the change and am re-committing without these changes:

Feb 22 2019, 3:31 PM
dab committed rS344468: Revert r344389 & r343906 - Fix Coverity errors in newsyslog.
Revert r344389 & r343906 - Fix Coverity errors in newsyslog
Feb 22 2019, 2:59 PM

Feb 20 2019

dab committed rS344394: MFC r344024:.
MFC r344024:
Feb 20 2019, 10:49 PM
dab committed rS344393: MFC r344024:.
MFC r344024:
Feb 20 2019, 10:49 PM
dab committed rS344392: MFC r344024:.
MFC r344024:
Feb 20 2019, 10:48 PM
dab committed rS344389: Complete fix for CID 1007454, CID 1007453: Resource leak in newsyslog.
Complete fix for CID 1007454, CID 1007453: Resource leak in newsyslog
Feb 20 2019, 10:05 PM

Feb 12 2019

dab added a comment to D19168: CID 1332078: Logically dead code in sys/dev/pms/freebsd/driver/ini/src/osapi.c.

Yes, I did change the logic. This turned out to be a more interesting issue than I had initially thought. At $WORK we also have bug fix in this area, but it differs from mine. I'm working on getting a good review, reconciling the changes, and adequate testing. So, this shouldn't be thought of as a finished work (yet).

Feb 12 2019, 10:35 PM
dab added a comment to D19168: CID 1332078: Logically dead code in sys/dev/pms/freebsd/driver/ini/src/osapi.c.

I can test on hardware at $WORK. As to it being vendor code, although the driver was imported from PMC-Sierra 3 years ago, it doesn't look to me like any updates have come from them since. If you know of a source of updated vendor code, can you point me to it?

Feb 12 2019, 7:33 PM
dab updated the diff for D19168: CID 1332078: Logically dead code in sys/dev/pms/freebsd/driver/ini/src/osapi.c.

Remove stray file from this review.

Feb 12 2019, 7:29 PM
dab created D19168: CID 1332078: Logically dead code in sys/dev/pms/freebsd/driver/ini/src/osapi.c.
Feb 12 2019, 7:27 PM
dab created D19165: CID 1332000: Logically dead code in sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c.
Feb 12 2019, 6:21 PM

Feb 11 2019

dab closed D19109: CID 1009492: Logically dead code in sys/cam/scsi/scsi_xpt.c.
Feb 11 2019, 10:09 PM
dab committed rS344024: CID 1009492: Logically dead code in sys/cam/scsi/scsi_xpt.c.
CID 1009492: Logically dead code in sys/cam/scsi/scsi_xpt.c
Feb 11 2019, 10:09 PM

Feb 8 2019

dab closed D19105: CID 1008620: Logically dead code in newsyslog.c.

Fixed by rS343906

Feb 8 2019, 2:01 PM
dab committed rS343906: Fix several Coverity-detected issues in newsyslog..
Fix several Coverity-detected issues in newsyslog.
Feb 8 2019, 1:54 PM
dab added inline comments to D19105: CID 1008620: Logically dead code in newsyslog.c.
Feb 8 2019, 1:02 PM
dab added inline comments to D19105: CID 1008620: Logically dead code in newsyslog.c.
Feb 8 2019, 1:54 AM
dab updated the diff for D19105: CID 1008620: Logically dead code in newsyslog.c.

Taking @cem's suggestion for an alternative fix. While I was at it, I
expanded the scope to pick up some fixes for additional CIDs:

Feb 8 2019, 1:49 AM

Feb 7 2019

dab added a comment to D19109: CID 1009492: Logically dead code in sys/cam/scsi/scsi_xpt.c.
In D19109#408725, @cem wrote:
In D19109#408718, @mav wrote:

I think I would remove this code completely, together with above NULL assignments. One way or another, this check is at least incomplete, since just in if block before execution can go to out bypassing this check.

Hm, I guess the assertion could be moved above the if block. I am also ok with removing it completely.

Feb 7 2019, 10:19 PM
dab added a comment to D19105: CID 1008620: Logically dead code in newsyslog.c.
In D19105#408658, @cem wrote:

My guess is that the author intended for defconf input to parse_file() to be a *reference* rather than a bare pointer. If you look at parse_file(), you can see it initializes its copy of defconf_p when the special entry "<default>" is encountered in a file. However, that pointer is never stored anywhere and is leaked when parse_file() returns.

Feb 7 2019, 7:25 PM
dab updated the diff for D19109: CID 1009492: Logically dead code in sys/cam/scsi/scsi_xpt.c.

Take @cem's suggestion to use a KASSERT() to ensure that lp is indeed NULL on the affected code path.

Feb 7 2019, 7:10 PM
dab updated the summary of D19109: CID 1009492: Logically dead code in sys/cam/scsi/scsi_xpt.c.
Feb 7 2019, 5:10 PM
dab created D19109: CID 1009492: Logically dead code in sys/cam/scsi/scsi_xpt.c.
Feb 7 2019, 5:00 PM
dab updated the summary of D19105: CID 1008620: Logically dead code in newsyslog.c.
Feb 7 2019, 2:09 PM
dab updated the test plan for D19105: CID 1008620: Logically dead code in newsyslog.c.
Feb 7 2019, 2:07 PM
dab added reviewers for D19105: CID 1008620: Logically dead code in newsyslog.c: vangyzen, cem, markj.
Feb 7 2019, 2:02 PM
dab created D19105: CID 1008620: Logically dead code in newsyslog.c.
Feb 7 2019, 1:53 PM

Jan 28 2019

dab added inline comments to D18696: sysctlmibinfo(3).
Jan 28 2019, 1:16 PM

Jan 18 2019

dab committed rS343151: MFC r342822:.
MFC r342822:
Jan 18 2019, 4:04 PM
dab committed rS343150: MFC r342822:.
MFC r342822:
Jan 18 2019, 4:04 PM
dab committed rS343149: MFC r342770:.
MFC r342770:
Jan 18 2019, 4:00 PM
dab committed rS343148: MFC r342770:.
MFC r342770:
Jan 18 2019, 3:58 PM

Jan 10 2019

dab added inline comments to D18696: sysctlmibinfo(3).
Jan 10 2019, 7:51 PM

Jan 6 2019

dab committed rS342822: asmc: Add support for Mac mini 4,1 (Mid-2010).
asmc: Add support for Mac mini 4,1 (Mid-2010)
Jan 6 2019, 11:43 PM

Jan 4 2019

dab committed rS342770: asmc: Patch to add MacBook Pro 9,2 support.
asmc: Patch to add MacBook Pro 9,2 support
Jan 4 2019, 6:21 PM
dab committed rS342756: MFC r342218:.
MFC r342218:
Jan 4 2019, 2:51 AM
dab committed rS342755: MFC r342218:.
MFC r342218:
Jan 4 2019, 2:50 AM
dab committed rS342753: MFC r342171:.
MFC r342171:
Jan 4 2019, 2:21 AM
dab committed rS342752: MFC r342171:.
MFC r342171:
Jan 4 2019, 2:20 AM

Dec 20 2018

dab committed rS342269: MFC r341988.
MFC r341988
Dec 20 2018, 12:58 AM
dab committed rS342268: MFC r341988.
MFC r341988
Dec 20 2018, 12:57 AM

Dec 19 2018

dab committed rS342254: MFC r341806:.
MFC r341806:
Dec 19 2018, 10:48 PM
dab committed rS342252: MFC r341806:.
MFC r341806:
Dec 19 2018, 10:46 PM
dab committed rS342246: MFC r341820:.
MFC r341820:
Dec 19 2018, 10:17 PM
dab committed rS342241: MFC r341820:.
MFC r341820:
Dec 19 2018, 9:28 PM
dab committed rS342218: asmc: Add support for MacPro1,1.
asmc: Add support for MacPro1,1
Dec 19 2018, 4:45 PM

Dec 17 2018

dab committed rS342171: asmc: Add support for mid-2011 Macmini 5,2.
asmc: Add support for mid-2011 Macmini 5,2
Dec 17 2018, 5:22 PM

Dec 12 2018

dab committed rS341988: asmc: Add Support for Macbook Pro 8,1.
asmc: Add Support for Macbook Pro 8,1
Dec 12 2018, 1:45 PM

Dec 11 2018

dab committed rS341820: asmc: Add Support for MacBookAir 7,1 and 7,2.
asmc: Add Support for MacBookAir 7,1 and 7,2
Dec 11 2018, 4:36 PM
dab closed D18396: asmc: Add Support for MacBookAir 7,1 and 7,2.
Dec 11 2018, 4:36 PM · Contributor Reviews (base)
dab committed rS341806: Add uk.macbook.kbd keymap (vt).
Add uk.macbook.kbd keymap (vt)
Dec 11 2018, 2:14 AM
dab closed D18395: Add uk.macbook.kbd keymap (vt).
Dec 11 2018, 2:14 AM · Contributor Reviews (base)
dab updated the summary of D18395: Add uk.macbook.kbd keymap (vt).
Dec 11 2018, 12:59 AM · Contributor Reviews (base)

Dec 1 2018

dab updated the diff for D18395: Add uk.macbook.kbd keymap (vt).

After commandeering the revision, updating it to make sure my diff is the same as the previously submitted diff.

Dec 1 2018, 6:56 PM · Contributor Reviews (base)
dab added reviewers for D18396: asmc: Add Support for MacBookAir 7,1 and 7,2: rpaulo, adrian.

Adding @adrian and @rpaulo as reviewers, as they have been in this code before and might have input.

Dec 1 2018, 6:50 PM · Contributor Reviews (base)
dab updated the diff for D18396: asmc: Add Support for MacBookAir 7,1 and 7,2.

After commandeering the revision, updating it to make sure my diff is
the same as the previously submitted diff.

Dec 1 2018, 6:47 PM · Contributor Reviews (base)
dab commandeered D18396: asmc: Add Support for MacBookAir 7,1 and 7,2.

I'll take over this diff and get it committed to -CURRENT in the next few days.

Dec 1 2018, 6:27 PM · Contributor Reviews (base)
dab commandeered D18395: Add uk.macbook.kbd keymap (vt).

Thanks. I'll take over this diff and get it committed to -CURRENT in the next few days. On what branch or revision did you test this? Do you need it applied to the stable/11 or stable/12?

Dec 1 2018, 2:41 AM · Contributor Reviews (base)

Nov 30 2018

dab added a comment to D18396: asmc: Add Support for MacBookAir 7,1 and 7,2.

@james.wright_jigsawdezign.com, do you need someone to help get this committed? I could do that if so. Can you update the review with information on testing you've done?

Nov 30 2018, 11:32 PM · Contributor Reviews (base)
dab added a comment to D18395: Add uk.macbook.kbd keymap (vt).

@james.wright_jigsawdezign.com, do you need someone to help get this committed? I could do that if so. Can you update the review with information on testing you've done?

Nov 30 2018, 11:32 PM · Contributor Reviews (base)
dab committed rS341275: MFC r337812,r337814,r337820,r341068:.
MFC r337812,r337814,r337820,r341068:
Nov 30 2018, 2:07 AM
dab closed D16531: Fix panic when adding netmap device to kqueue..

This fix was (accidentally) committed in rS337812 and incorporated into the upcoming 12.0-RELEASE; I just noticed that now when I went to MFC that commit to stable/11. Closing the review now, considerably after the fact.

Nov 30 2018, 1:57 AM
dab committed rS341274: MFC r341068:.
MFC r341068:
Nov 30 2018, 1:46 AM

Nov 27 2018

dab committed rS341068: Make whitespace more consistent in libkqueue tests..
Make whitespace more consistent in libkqueue tests.
Nov 27 2018, 3:14 PM

Nov 19 2018

dab accepted D2724: Include path for tmpfs objects in vm.objects sysctl.
Nov 19 2018, 10:31 PM

Nov 8 2018

dab accepted D17898: in6_ifattach_linklocal: handle immediate removal of the new LLA.

@vangyzen, Looks OK to me but I'm curious how you ran across this situation.

Nov 8 2018, 2:35 AM

Sep 16 2018

dab added inline comments to D17115: Generate /etc/services from the IANA registry (plus local mods).
Sep 16 2018, 3:54 AM

Sep 15 2018

dab added a reviewer for D17115: Generate /etc/services from the IANA registry (plus local mods): dab.

@vangyzen -- Did you notice this:

Sep 15 2018, 11:19 PM

Aug 21 2018

dab accepted D16831: newsyslog(8): Reject configurations that specify setuid or executable logs.

Looks good.

Aug 21 2018, 10:04 PM
dab accepted D16831: newsyslog(8): Reject configurations that specify setuid or executable logs.
Aug 21 2018, 9:35 PM
dab added inline comments to D16831: newsyslog(8): Reject configurations that specify setuid or executable logs.
Aug 21 2018, 9:35 PM