Page MenuHomeFreeBSD

nvme_sim: Connect to events broadcast with nvme_if
Needs ReviewPublic

Authored by imp on Jul 17 2025, 7:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 14, 8:14 PM
Unknown Object (File)
Tue, Nov 4, 5:23 AM
Unknown Object (File)
Sun, Oct 26, 8:06 PM
Unknown Object (File)
Tue, Oct 21, 2:01 PM
Unknown Object (File)
Tue, Oct 21, 2:01 PM
Unknown Object (File)
Tue, Oct 21, 2:09 AM
Unknown Object (File)
Oct 12 2025, 5:53 PM
Unknown Object (File)
Oct 2 2025, 1:54 PM
Subscribers

Details

Summary

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68654
Build 65537: arc lint + arc unit

Event Timeline

sys/dev/nvme/nvme_sim.c
412

FWIW, in nvmf I just have a single namespace_changed callback. It parses the list of changed namespaces for the AEN and then calls nvmf_rescan_ns for each namespace. For the /dev/nvmeXnsY devices it does do some extra work to detect add vs remove vs change, but for the CAM SIM, it just always calls nvmf_sim_rescan_ns that just triggers an xpt_rescan for the namespace.

sys/dev/nvme/nvme_sim.c
412

Yea. 'new' is called at startup, while my delta is called for the AER change event. I don't have a rm event yet.

I'm happy to tweak things, especially if an xpt_rescan does the right thing.

412

Also, that's how it is with these changes, but not set in stone if we can make things simpler.

imp retitled this revision from nvme_sim: Connect to events broadcast with nvmec_if to nvme_sim: Connect to events broadcast with nvme_if.Thu, Nov 13, 11:30 PM

Update per review, add missing change