Sponsored by: Netflix
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 68654 Build 65537: arc lint + arc unit
Event Timeline
| sys/dev/nvme/nvme_sim.c | ||
|---|---|---|
| 412 | FWIW, in nvmf I just have a single namespace_changed callback. It parses the list of changed namespaces for the AEN and then calls nvmf_rescan_ns for each namespace. For the /dev/nvmeXnsY devices it does do some extra work to detect add vs remove vs change, but for the CAM SIM, it just always calls nvmf_sim_rescan_ns that just triggers an xpt_rescan for the namespace. | |
| sys/dev/nvme/nvme_sim.c | ||
|---|---|---|
| 412 | Yea. 'new' is called at startup, while my delta is called for the AER change event. I don't have a rm event yet. I'm happy to tweak things, especially if an xpt_rescan does the right thing. | |
| 412 | Also, that's how it is with these changes, but not set in stone if we can make things simpler. | |