- User Since
- Dec 7 2017, 1:03 PM (14 w, 2 d)
Thu, Mar 15
These changes look good to me.
Should the register definitions and other structures which previously used bit fields get similar changes?
Ditto for sbin/nvmecontrol/*?
Tue, Mar 13
Fri, Mar 9
Thu, Mar 1
When deciding how to export data from CAM, can you describe when using a XPT_KV_GET is preferred over XPT_DEV_ADVINFO?
Jan 25 2018
Looks good to me.
Overall, it is exciting to see this work being done. I realize the code is in its early stages and has asserts to help catch "the important" code paths, but it might be good to remove some of the asserts and have the commands set standard NVMe errors where appropriate.
Dec 11 2017
Other than the noted if check, this looks good to me.