Page MenuHomeFreeBSD

chuck (Chuck Tuffli)
User

Projects

User Details

User Since
Dec 7 2017, 1:03 PM (41 w, 1 d)

Recent Activity

Aug 22 2018

chuck created D16837: Document FreeBSD version 1200081.
Aug 22 2018, 5:19 AM
chuck added a comment to D14703: nvme: Revert to using the old API..

Alternative approach outlined in D16404 committed to svn

Aug 22 2018, 4:33 AM
chuck added a comment to D16404: nvme: Alternate approach to restoring API.

@mav thanks for the reminder. version bumped to 1200081

Aug 22 2018, 4:31 AM
chuck committed rS338182: Make NVMe compatible with the original API.
Make NVMe compatible with the original API
Aug 22 2018, 4:29 AM
chuck closed D16404: nvme: Alternate approach to restoring API.
Aug 22 2018, 4:29 AM

Aug 19 2018

chuck updated the diff for D16404: nvme: Alternate approach to restoring API.

Fixed style issues

Aug 19 2018, 2:05 PM
chuck added a comment to D16404: nvme: Alternate approach to restoring API.

I've tested basic functionality (nvmecontrol, mount, bulk data transfers) on ppc64

Aug 19 2018, 2:04 PM

Aug 16 2018

chuck updated the diff for D16404: nvme: Alternate approach to restoring API.

Add the user space changes and commit message

Aug 16 2018, 1:53 PM

Aug 12 2018

chuck added a comment to D16404: nvme: Alternate approach to restoring API.
In D16404#353695, @mav wrote:

I have no objections against this, other then it is one more API change. I don't know why those bitfields were merged into uint16_t, while uint8_t for opc is indeed more convenient.

Aug 12 2018, 2:13 PM

Jul 23 2018

chuck updated the diff for D16404: nvme: Alternate approach to restoring API.

Removed Linux stuff that crept into the patch

Jul 23 2018, 2:06 PM
chuck created D16404: nvme: Alternate approach to restoring API.
Jul 23 2018, 2:05 PM

Jul 16 2018

chuck added inline comments to D16291: NVME trim stuff..
Jul 16 2018, 10:41 PM

Jul 4 2018

chuck added inline comments to D15995: Add PNP info to PCI attachment of alc, amdsmb, bfe, bge, ce, dpt, dc, ciss, cp drivers.
Jul 4 2018, 8:31 PM

Jul 3 2018

chuck added inline comments to D15996: Add PNP info to PCI attachment of arcmsr, bt, cbb, de, ebus, emujoy, fixup_pci, hifn, hptiop, imcsmb, snd_emu10k1 (emu_pci) drivers.
Jul 3 2018, 3:42 PM

Jun 28 2018

chuck added inline comments to D15979: Add PNP info to PCI attachment of et, iir, ignore, isab, ips, ipw, ismt, iwm, ix, ixgb, ixv drivers.
Jun 28 2018, 9:42 PM
chuck added inline comments to D15999: Create PCI_MATCH and pci_match_device.
Jun 28 2018, 4:53 PM

Jun 24 2018

chuck requested changes to D15995: Add PNP info to PCI attachment of alc, amdsmb, bfe, bge, ce, dpt, dc, ciss, cp drivers.
Jun 24 2018, 1:16 PM
chuck requested changes to D15979: Add PNP info to PCI attachment of et, iir, ignore, isab, ips, ipw, ismt, iwm, ix, ixgb, ixv drivers.
Jun 24 2018, 12:36 AM

Jun 22 2018

chuck committed rS335516: Fix output of linprocfs stat entry.
Fix output of linprocfs stat entry
Jun 22 2018, 12:02 AM
chuck closed D15858: Fix output of linprocfs stat entry.
Jun 22 2018, 12:02 AM
chuck committed rS335515: Fix the Linux kernel version number calculation.
Fix the Linux kernel version number calculation
Jun 22 2018, 12:02 AM
chuck closed D15952: Fix the Linux kernel version number calculation.
Jun 22 2018, 12:02 AM

Jun 21 2018

chuck added inline comments to D15858: Fix output of linprocfs stat entry.
Jun 21 2018, 10:33 PM
chuck added a comment to D15952: Fix the Linux kernel version number calculation.

I'm only finding two copies: sys/i386/linux/linux_sysvec.c and sys/amd64/linux/linux_sysvec.c but have updated the patch to fix those copies.

One more in sys/amd64/linux32/linux32_sysvec.c. Oh, and the last one is not yet committed, it is in D15834.

Jun 21 2018, 9:54 PM
chuck added a comment to D15952: Fix the Linux kernel version number calculation.

LGTM.

We will also need to address the four copies of linux_trans_osrel (but after further investigation if desired, I have not checked exactly how the value they calculate is used).

Jun 21 2018, 7:57 PM
chuck updated the diff for D15952: Fix the Linux kernel version number calculation.

[v3] Fix the Linux kernel version number calculation

Jun 21 2018, 7:57 PM
chuck added a comment to D15952: Fix the Linux kernel version number calculation.

The updated summary is what will go into the commit message.

Jun 21 2018, 6:57 PM
chuck updated the diff for D15952: Fix the Linux kernel version number calculation.

[v2] Fix the Linux kernel version number calculation

Jun 21 2018, 6:56 PM
chuck added a comment to D15952: Fix the Linux kernel version number calculation.
In D15952#337588, @cem wrote:

Why not leave the macro alone and compute v using it instead?

v = LINUX_KERNVER(v0, v1, v2);

(As I noted in the bug, the macro matches the way Linux defines kernel version numbers for a given major, minor, and patch, so it makes the most sense to leave it that way.)

Jun 21 2018, 4:34 PM
chuck updated the diff for D15858: Fix output of linprocfs stat entry.

[v3] Fix output of linprocfs stat

Jun 21 2018, 3:00 PM
chuck added a comment to D15858: Fix output of linprocfs stat entry.

Added PR 229209 to track the osrelease issue and posted a proposed fix in https://reviews.freebsd.org/D15952

Jun 21 2018, 2:55 PM
chuck created D15952: Fix the Linux kernel version number calculation.
Jun 21 2018, 2:47 PM

Jun 19 2018

chuck accepted D15887: linuxulator: handle V3 capget/capset.

LGTM

Jun 19 2018, 9:13 PM
chuck added a comment to D15858: Fix output of linprocfs stat entry.

See linux_map_osrel

Jun 19 2018, 7:57 PM
chuck updated the diff for D15858: Fix output of linprocfs stat entry.

[v2] Fix output of linprocfs stat

Jun 19 2018, 7:27 PM

Jun 16 2018

chuck created D15858: Fix output of linprocfs stat entry.
Jun 16 2018, 10:08 PM
chuck abandoned D11433: Add Format NVM support to nvmecontrol.

Since @mav committed something similar, abandoning this review.

Jun 16 2018, 10:01 PM

Jun 15 2018

chuck closed D15563: Add linprocfs support for min_free_kbytes.
Jun 15 2018, 3:22 PM · Linux Emulation
chuck committed rS335205: Add linprocfs support for min_free_kbytes.
Add linprocfs support for min_free_kbytes
Jun 15 2018, 3:22 PM
chuck added inline comments to D15563: Add linprocfs support for min_free_kbytes.
Jun 15 2018, 3:18 PM · Linux Emulation

Jun 13 2018

chuck updated the diff for D15563: Add linprocfs support for min_free_kbytes.

Update function comment to add details recommend by @emaste

Jun 13 2018, 12:59 AM · Linux Emulation

Jun 12 2018

chuck added inline comments to D15563: Add linprocfs support for min_free_kbytes.
Jun 12 2018, 4:03 PM · Linux Emulation

May 25 2018

chuck added a project to D15563: Add linprocfs support for min_free_kbytes: Linux Emulation.
May 25 2018, 10:56 PM · Linux Emulation

May 24 2018

chuck updated the diff for D15563: Add linprocfs support for min_free_kbytes.

style(9) fix in linprocfs_dominfree()

May 24 2018, 9:01 PM · Linux Emulation
chuck created D15563: Add linprocfs support for min_free_kbytes.
May 24 2018, 8:55 PM · Linux Emulation

Mar 24 2018

chuck created D14835: Enhance support for Linux mremap system call.
Mar 24 2018, 7:29 PM

Mar 15 2018

chuck added a comment to D14703: nvme: Revert to using the old API..

These changes look good to me.
Should the register definitions and other structures which previously used bit fields get similar changes?
Ditto for sbin/nvmecontrol/*?

Mar 15 2018, 6:50 PM

Mar 13 2018

chuck commandeered D11433: Add Format NVM support to nvmecontrol.
Mar 13 2018, 2:53 PM

Mar 9 2018

chuck accepted D14022: NVMe emulation for bhyve (improved).
Mar 9 2018, 12:31 AM

Mar 1 2018

chuck added a comment to D14551: Define Key Value CCB..
In D14551#305406, @imp wrote:

When deciding how to export data from CAM, can you describe when using a XPT_KV_GET is preferred over XPT_DEV_ADVINFO?

DEV_ADVINFO is more for servicing GEOM attribute requests about the device. There seems to be a fair amount of glue at the xpt layer to know about what GEOM wants to be returned.

My stuff is more for the PERIPH asking the SIM for info, as well as set stuff. However, you ask a fair question.

Mar 1 2018, 8:50 PM
chuck added a comment to D14551: Define Key Value CCB..

When deciding how to export data from CAM, can you describe when using a XPT_KV_GET is preferred over XPT_DEV_ADVINFO?

Mar 1 2018, 8:03 PM

Jan 25 2018

chuck requested changes to D14022: NVMe emulation for bhyve (improved).
Jan 25 2018, 11:26 PM
chuck accepted D14041: Minimum changes for ctl to build on architectures with non-matching physical and virtual address sizes.

Looks good to me.

Jan 25 2018, 5:35 PM
chuck added a comment to D13995: NVMe controller emulator for bhyve..

@grehan OK. So is the thought that this review be closed and efforts should focus on D14022?

Jan 25 2018, 4:39 PM · bhyve
chuck added a comment to D13995: NVMe controller emulator for bhyve..

Overall, it is exciting to see this work being done. I realize the code is in its early stages and has asserts to help catch "the important" code paths, but it might be good to remove some of the asserts and have the commands set standard NVMe errors where appropriate.

Jan 25 2018, 3:49 PM · bhyve

Dec 11 2017

chuck accepted D13389: Wait for EN transition on disable.

Other than the noted if check, this looks good to me.

Dec 11 2017, 5:17 AM
chuck closed D13406: Add myself to committers-src.dot.
Dec 11 2017, 4:40 AM
chuck committed rS326759: Add myself to committers-src.dot.
Add myself to committers-src.dot
Dec 11 2017, 4:40 AM

Dec 8 2017

chuck added inline comments to D13389: Wait for EN transition on disable.
Dec 8 2017, 1:55 AM

Dec 7 2017

chuck added inline comments to D13389: Wait for EN transition on disable.
Dec 7 2017, 8:31 PM
chuck added inline comments to D13389: Wait for EN transition on disable.
Dec 7 2017, 7:06 PM
chuck created D13406: Add myself to committers-src.dot.
Dec 7 2017, 2:18 PM