Page MenuHomeFreeBSD

chuck (Chuck Tuffli)
User

Projects

User Details

User Since
Dec 7 2017, 1:03 PM (71 w, 3 d)

Recent Activity

Sun, Apr 14

chuck created D19905: bhyve: Add EUI64 to NVMe device.
Sun, Apr 14, 1:30 AM
chuck created D19904: bhyve: Add Integrated Endpoint to PCIe Capability.
Sun, Apr 14, 1:24 AM

Sat, Apr 13

chuck closed D19580: Fix bhyve PCIe capability emulation.
Sat, Apr 13, 11:38 PM
chuck committed rS346194: Revert r345171 pending review.
Revert r345171 pending review
Sat, Apr 13, 11:37 PM

Sun, Apr 7

chuck removed a reviewer for D19841: bhyve NVMe emulation locking: bhyve.
Sun, Apr 7, 7:14 PM
chuck created D19841: bhyve NVMe emulation locking.
Sun, Apr 7, 7:13 PM

Fri, Apr 5

chuck closed D19695: bhyve(8): Fix NVMe data structure copy to guest.
Fri, Apr 5, 4:54 PM
chuck committed rS345957: bhyve: Fix NVMe data structure copy to guest.
bhyve: Fix NVMe data structure copy to guest
Fri, Apr 5, 4:54 PM
chuck committed rS345956: bhyve: Fix NVMe BAR size calculation.
bhyve: Fix NVMe BAR size calculation
Fri, Apr 5, 4:54 PM
chuck closed D19676: bhyve: Fix NVMe BAR size calculation.
Fri, Apr 5, 4:54 PM
chuck added a comment to D19695: bhyve(8): Fix NVMe data structure copy to guest.
In D19695#423813, @imp wrote:

This looks good to me. It's the right thing to do.
Do we need to expand it more generally (in a different commit) for any time we have to copy data out, or is the I/O path good?

Fri, Apr 5, 4:00 PM

Thu, Apr 4

chuck added a comment to D19676: bhyve: Fix NVMe BAR size calculation.
In D19676#423809, @imp wrote:

one quick Q. if you know the windows versions, document it in the comment.

Thu, Apr 4, 3:30 PM

Tue, Mar 26

chuck added a comment to D19580: Fix bhyve PCIe capability emulation.
In D19580#422125, @jhb wrote:

Hmm, due to what this bit actually does, I'd probably be inclined to not set it if we don't need it. When the role based error reporting is set, it means we also support at least one other register to configure the mask of fatal vs non-fatal errors IIRC which I'm pretty sure we don't do. I had assumed Windows was failing to boot without this bit set. If Windows is actually fine then I think I'd prefer we drop it until we find a need for it. A PCIe 1.0 device can have this bit clear and still be compliant. The other thing about being a special endpoint when directly hung off the RC would be required even for 1.0 compliance.

Tue, Mar 26, 1:18 PM

Sun, Mar 24

chuck resigned from D14703: nvme: Revert to using the old API..
Sun, Mar 24, 10:02 PM
chuck created D19695: bhyve(8): Fix NVMe data structure copy to guest.
Sun, Mar 24, 5:18 PM

Sat, Mar 23

chuck added a comment to D19580: Fix bhyve PCIe capability emulation.

One of @jhb requests was a comment on why the RBER change was needed. Here is the thought process:

Sat, Mar 23, 5:38 PM
chuck reopened D19580: Fix bhyve PCIe capability emulation.
Sat, Mar 23, 5:21 PM
chuck committed rS345454: MFC r345170:.
MFC r345170:
Sat, Mar 23, 4:46 PM
chuck committed rS345453: MFC r342761:.
MFC r342761:
Sat, Mar 23, 4:42 PM
chuck committed rS345451: MFC r342762:.
MFC r342762:
Sat, Mar 23, 4:30 PM
chuck updated the diff for D19676: bhyve: Fix NVMe BAR size calculation.

Updated based on feedback

Sat, Mar 23, 2:30 AM

Mar 22 2019

chuck created D19676: bhyve: Fix NVMe BAR size calculation.
Mar 22 2019, 5:22 AM

Mar 15 2019

chuck committed rS345171: Fix bhyve PCIe capability emulation.
Fix bhyve PCIe capability emulation
Mar 15 2019, 2:12 AM
chuck closed D19580: Fix bhyve PCIe capability emulation.
Mar 15 2019, 2:12 AM
chuck committed rS345170: Fix bhyve's NVMe Identify Namespace data.
Fix bhyve's NVMe Identify Namespace data
Mar 15 2019, 2:11 AM
chuck closed D19579: Fix bhyve's NVMe Identify Namespace data.
Mar 15 2019, 2:11 AM
chuck added inline comments to D19580: Fix bhyve PCIe capability emulation.
Mar 15 2019, 12:47 AM

Mar 14 2019

chuck updated the diff for D19580: Fix bhyve PCIe capability emulation.

added wrong diff

Mar 14 2019, 10:11 AM
chuck created D19580: Fix bhyve PCIe capability emulation.
Mar 14 2019, 9:55 AM
chuck added reviewers for D19579: Fix bhyve's NVMe Identify Namespace data: imp, ken, araujo.
Mar 14 2019, 9:50 AM
chuck updated the diff for D19579: Fix bhyve's NVMe Identify Namespace data.

style(9)

Mar 14 2019, 9:49 AM
chuck created D19579: Fix bhyve's NVMe Identify Namespace data.
Mar 14 2019, 9:48 AM

Mar 3 2019

chuck accepted D19431: Don't print all the I/O we abort on a reset, unless we're out of retries..

LGTM

Mar 3 2019, 4:38 PM

Jan 8 2019

chuck added a comment to D18772: Add NVMe drive to NOIOB quirk list.
In D18772#400655, @imp wrote:

This works for me. There is a newer way to cope with this, but I don't think the 4600 implements this, so this change is appropriate.

Jan 8 2019, 3:35 PM
chuck committed rS342862: Add NVMe drive to NOIOB quirk list.
Add NVMe drive to NOIOB quirk list
Jan 8 2019, 3:31 PM
chuck closed D18772: Add NVMe drive to NOIOB quirk list.
Jan 8 2019, 3:31 PM

Jan 7 2019

chuck added a comment to D18772: Add NVMe drive to NOIOB quirk list.
In D18772#400520, @mav wrote:

I have no objections, if its true.

Jan 7 2019, 5:20 PM
chuck added reviewers for D18772: Add NVMe drive to NOIOB quirk list: imp, ken, mav.
Jan 7 2019, 3:41 PM
chuck created D18772: Add NVMe drive to NOIOB quirk list.
Jan 7 2019, 3:41 PM

Jan 4 2019

chuck committed rS342777: MFC r342046: nda(4) fix check for Dataset Management support.
MFC r342046: nda(4) fix check for Dataset Management support
Jan 4 2019, 9:06 PM
chuck closed D18746: MFC r342046: nda(4) fix check for Dataset Management support.
Jan 4 2019, 9:06 PM
chuck created D18746: MFC r342046: nda(4) fix check for Dataset Management support.
Jan 4 2019, 5:03 PM
chuck closed D18703: Fix bhyve's NVMe Completion Queue entry values.
Jan 4 2019, 3:03 PM · bhyve
chuck committed rS342761: Fix bhyve's NVMe queue bookkeeping.
Fix bhyve's NVMe queue bookkeeping
Jan 4 2019, 3:03 PM
chuck committed rS342762: Fix bhyve's NVMe Completion Queue entry values.
Fix bhyve's NVMe Completion Queue entry values
Jan 4 2019, 3:03 PM
chuck closed D18702: Fix bhyve's NVMe queue bookkeeping.
Jan 4 2019, 3:03 PM · bhyve

Jan 2 2019

chuck added a comment to D18703: Fix bhyve's NVMe Completion Queue entry values.

LGTM! Could you please set a MFC?

Jan 2 2019, 5:44 PM · bhyve

Dec 31 2018

chuck closed D15996: Add PNP info to PCI attachment of arcmsr, bt, cbb, de, ebus, emujoy, fixup_pci, hifn, hptiop, imcsmb, snd_emu10k1 (emu_pci) drivers.
Dec 31 2018, 7:14 PM
chuck accepted D15996: Add PNP info to PCI attachment of arcmsr, bt, cbb, de, ebus, emujoy, fixup_pci, hifn, hptiop, imcsmb, snd_emu10k1 (emu_pci) drivers.
Dec 31 2018, 7:13 PM
chuck closed D16233: Update BKTR, ISMT, IIR, IWM, IPS, IGNORE, IMCSMB, FIXUP, DE, DPT, GRACKLE to use PCI_MATCH.
Dec 31 2018, 7:13 PM
chuck accepted D16233: Update BKTR, ISMT, IIR, IWM, IPS, IGNORE, IMCSMB, FIXUP, DE, DPT, GRACKLE to use PCI_MATCH.
Dec 31 2018, 7:13 PM
chuck closed D16253: Update GLXSB, EBUS, EMU, EMUJOY, HIFN, BT, ARCMSR, HME, CP, CE, BFE to use PCI_MATCH.
Dec 31 2018, 7:13 PM
chuck accepted D16253: Update GLXSB, EBUS, EMU, EMUJOY, HIFN, BT, ARCMSR, HME, CP, CE, BFE to use PCI_MATCH.
Dec 31 2018, 7:13 PM
chuck closed D16324: Add PNP info to PCI attachment of IICOC, IPMI, ISP, ISCI, IXL, IXLV, IWN, IWI, IDA, IG4 drivers.
Dec 31 2018, 7:12 PM
chuck accepted D16324: Add PNP info to PCI attachment of IICOC, IPMI, ISP, ISCI, IXL, IXLV, IWN, IWI, IDA, IG4 drivers.
Dec 31 2018, 7:12 PM
chuck closed D16363: Add PNP info to PCI attachments of LE, LIO, MPR, MVS, MY drivers.
Dec 31 2018, 7:12 PM
chuck accepted D16363: Add PNP info to PCI attachments of LE, LIO, MPR, MVS, MY drivers.
Dec 31 2018, 7:12 PM
chuck closed D16540: Add PNP info to PCI attachments of MFI, MALO, MWL, NFSMB, NGE, NTB_PLX, NLMSEC, NLMRSA, NFE, NVME drivers.
Dec 31 2018, 7:12 PM
chuck accepted D16540: Add PNP info to PCI attachments of MFI, MALO, MWL, NFSMB, NGE, NTB_PLX, NLMSEC, NLMRSA, NFE, NVME drivers.
Dec 31 2018, 7:11 PM
chuck closed D16594: Add PNP info to PCI attachments of PCIBIOS, PCIB, QLA, QLA80XX, QL, PIIX, RP, OCE, RE, PPC driver.
Dec 31 2018, 7:11 PM
chuck accepted D16594: Add PNP info to PCI attachments of PCIBIOS, PCIB, QLA, QLA80XX, QL, PIIX, RP, OCE, RE, PPC driver.
Dec 31 2018, 7:11 PM
chuck closed D16612: First attempt at documenting use of PCI_PNP_INFO.
Dec 31 2018, 7:10 PM
chuck accepted D16612: First attempt at documenting use of PCI_PNP_INFO.
Dec 31 2018, 7:10 PM
chuck closed D16691: Add PNP info to PCI attachments of RAL, RE, RL, PCN, PSTPCI, SGE, SIS, STE, drivers, defining and documenting PCI_SUBVID macro.
Dec 31 2018, 7:10 PM
chuck accepted D16691: Add PNP info to PCI attachments of RAL, RE, RL, PCN, PSTPCI, SGE, SIS, STE, drivers, defining and documenting PCI_SUBVID macro.
Dec 31 2018, 7:09 PM
chuck created D18703: Fix bhyve's NVMe Completion Queue entry values.
Dec 31 2018, 6:58 PM · bhyve
chuck updated the diff for D18702: Fix bhyve's NVMe queue bookkeeping.

Use ONE_BASED() macro for CQ creation as well as SQ

Dec 31 2018, 6:54 PM · bhyve
chuck created D18702: Fix bhyve's NVMe queue bookkeeping.
Dec 31 2018, 6:53 PM · bhyve

Dec 13 2018

chuck committed rS342046: nda(4) fix check for Dataset Management support.
nda(4) fix check for Dataset Management support
Dec 13 2018, 1:26 PM
chuck closed D18493: Check if NVMe Controller supports Dataset Management in nda(4).
Dec 13 2018, 1:26 PM

Dec 11 2018

chuck added a reviewer for D18493: Check if NVMe Controller supports Dataset Management in nda(4): jimharris.
Dec 11 2018, 4:58 AM

Dec 10 2018

chuck created D18493: Check if NVMe Controller supports Dataset Management in nda(4).
Dec 10 2018, 12:26 AM

Oct 7 2018

chuck committed rD52340: Document FreeBSD version 1200081.
Document FreeBSD version 1200081
Oct 7 2018, 11:38 PM
chuck closed D16837: Document FreeBSD version 1200081.
Oct 7 2018, 11:38 PM

Oct 5 2018

chuck added a comment to D16837: Document FreeBSD version 1200081.

This is marked as blocked by @mat
Should I still wait for their review or is this OK to land?

Oct 5 2018, 1:26 PM

Aug 22 2018

chuck created D16837: Document FreeBSD version 1200081.
Aug 22 2018, 5:19 AM
chuck added a comment to D14703: nvme: Revert to using the old API..

Alternative approach outlined in D16404 committed to svn

Aug 22 2018, 4:33 AM
chuck added a comment to D16404: nvme: Alternate approach to restoring API.

@mav thanks for the reminder. version bumped to 1200081

Aug 22 2018, 4:31 AM
chuck committed rS338182: Make NVMe compatible with the original API.
Make NVMe compatible with the original API
Aug 22 2018, 4:29 AM
chuck closed D16404: nvme: Alternate approach to restoring API.
Aug 22 2018, 4:29 AM

Aug 19 2018

chuck updated the diff for D16404: nvme: Alternate approach to restoring API.

Fixed style issues

Aug 19 2018, 2:05 PM
chuck added a comment to D16404: nvme: Alternate approach to restoring API.

I've tested basic functionality (nvmecontrol, mount, bulk data transfers) on ppc64

Aug 19 2018, 2:04 PM

Aug 16 2018

chuck updated the diff for D16404: nvme: Alternate approach to restoring API.

Add the user space changes and commit message

Aug 16 2018, 1:53 PM

Aug 12 2018

chuck added a comment to D16404: nvme: Alternate approach to restoring API.
In D16404#353695, @mav wrote:

I have no objections against this, other then it is one more API change. I don't know why those bitfields were merged into uint16_t, while uint8_t for opc is indeed more convenient.

Aug 12 2018, 2:13 PM

Jul 23 2018

chuck updated the diff for D16404: nvme: Alternate approach to restoring API.

Removed Linux stuff that crept into the patch

Jul 23 2018, 2:06 PM
chuck created D16404: nvme: Alternate approach to restoring API.
Jul 23 2018, 2:05 PM

Jul 16 2018

chuck added inline comments to D16291: NVME trim stuff..
Jul 16 2018, 10:41 PM

Jul 4 2018

chuck added inline comments to D15995: Add PNP info to PCI attachment of alc, amdsmb, bfe, bge, ce, dpt, dc, ciss, cp drivers.
Jul 4 2018, 8:31 PM

Jul 3 2018

chuck added inline comments to D15996: Add PNP info to PCI attachment of arcmsr, bt, cbb, de, ebus, emujoy, fixup_pci, hifn, hptiop, imcsmb, snd_emu10k1 (emu_pci) drivers.
Jul 3 2018, 3:42 PM

Jun 28 2018

chuck added inline comments to D15979: Add PNP info to PCI attachment of et, iir, ignore, isab, ips, ipw, ismt, iwm, ix, ixgb, ixv drivers.
Jun 28 2018, 9:42 PM
chuck added inline comments to D15999: Create PCI_MATCH and pci_match_device.
Jun 28 2018, 4:53 PM

Jun 24 2018

chuck requested changes to D15995: Add PNP info to PCI attachment of alc, amdsmb, bfe, bge, ce, dpt, dc, ciss, cp drivers.
Jun 24 2018, 1:16 PM
chuck requested changes to D15979: Add PNP info to PCI attachment of et, iir, ignore, isab, ips, ipw, ismt, iwm, ix, ixgb, ixv drivers.
Jun 24 2018, 12:36 AM

Jun 22 2018

chuck committed rS335516: Fix output of linprocfs stat entry.
Fix output of linprocfs stat entry
Jun 22 2018, 12:02 AM
chuck closed D15858: Fix output of linprocfs stat entry.
Jun 22 2018, 12:02 AM
chuck committed rS335515: Fix the Linux kernel version number calculation.
Fix the Linux kernel version number calculation
Jun 22 2018, 12:02 AM
chuck closed D15952: Fix the Linux kernel version number calculation.
Jun 22 2018, 12:02 AM

Jun 21 2018

chuck added inline comments to D15858: Fix output of linprocfs stat entry.
Jun 21 2018, 10:33 PM
chuck added a comment to D15952: Fix the Linux kernel version number calculation.

I'm only finding two copies: sys/i386/linux/linux_sysvec.c and sys/amd64/linux/linux_sysvec.c but have updated the patch to fix those copies.

One more in sys/amd64/linux32/linux32_sysvec.c. Oh, and the last one is not yet committed, it is in D15834.

Jun 21 2018, 9:54 PM
chuck added a comment to D15952: Fix the Linux kernel version number calculation.

LGTM.

We will also need to address the four copies of linux_trans_osrel (but after further investigation if desired, I have not checked exactly how the value they calculate is used).

Jun 21 2018, 7:57 PM