Update based on review feedback + rebase to main

Address review feedback and rebase.

Rebase

Update change from review feedback

Remove invalid mdoc macro

Add link to man page for diskhealth

Update with jrm@ review feedback

Fix trailing whitespace

Address review feedback

Note this fixes the issue reported in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282237 and with commit 7631790422464de1aec309018e2c444defe5f629 differently, but the fix mirrors what SmartOS/illumos did to minimize diff's between the various bhyve implementations.

Remove kasserts and move memset to central location

OK. I had that in because most (all?) calls to this function do a KASSERT(cmd != NULL) immediately afterwards. Should I delete the KASSERTs in the calling functions as well?

Address review feedback

You are correct. I had (mistakenly) convinced myself that pattern occurred in more places. I'll move as suggested and delete the occurrence in amdvi_inv_domain

Other functions call amdvi_get_cmd_tail() prior to calling the functions which would then format the command entry. Putting the memset() in amdvi_get_cmd_tail() would clear the command entry twice.

This patch worked for me as well and doesn't seem to bother Windows guest, but they don't seem to need it like the Linux ones do.

Address doc feedback

@mav beat me to the fix.

Testing with an unmodified Linux nvme-cli fails without the noted change masking cmd. Fix that, and this LGTM. Thanks for all the integration!

Testing with an unmodified Linux nvme-cli looks good using this patch rebased on top of my device alias changes.

LGTM

This looks good and helps explain (with examples) a common NVMe stumbling block.

Handful of nits, but overall, LGTM!