Page MenuHomeFreeBSD

chuck (Chuck Tuffli)
User

Projects

User Details

User Since
Dec 7 2017, 1:03 PM (97 w, 1 d)

Recent Activity

Sun, Sep 29

chuck created D21839: bhyve: implement NVMe deallocate command.
Sun, Sep 29, 3:29 PM
chuck created D21838: bhyve: refactor NVMe namespace initialization.
Sun, Sep 29, 3:26 PM
chuck created D21837: bhyve: refactor NVMe PRP memcpy.
Sun, Sep 29, 3:23 PM

Sep 9 2019

chuck committed rS352061: MFC r350077.
MFC r350077
Sep 9 2019, 2:17 PM

Jul 27 2019

chuck committed rS350382: MFC r349969.
MFC r349969
Jul 27 2019, 5:59 PM
chuck committed rS350381: MFC r348781.
MFC r348781
Jul 27 2019, 5:52 PM
chuck committed rS350380: MFC r345956.
MFC r345956
Jul 27 2019, 5:48 PM
chuck committed rS350379: MFC r345957.
MFC r345957
Jul 27 2019, 5:44 PM

Jul 21 2019

chuck accepted D20999: Move to using bool instead of boolean_t.
Jul 21 2019, 6:14 PM

Jul 18 2019

D20979: Provide macros to extract the sub-fields of the CAP_LO and CAP_HI registers. is now accepted and ready to land.

LGTM

Jul 18 2019, 2:41 PM

Jul 17 2019

chuck closed D20945: bhyve: update the NVMe CQ based on the status.
Jul 17 2019, 3:19 AM
chuck committed rS350077: bhyve: update the NVMe CQ based on the status.
bhyve: update the NVMe CQ based on the status
Jul 17 2019, 3:19 AM

Jul 14 2019

chuck committed rS349981: Fix a typo in r349969.
Fix a typo in r349969
Jul 14 2019, 3:50 AM

Jul 13 2019

chuck created D20945: bhyve: update the NVMe CQ based on the status.
Jul 13 2019, 2:31 PM
chuck closed D19905: bhyve: Add EUI64 to NVMe device.
Jul 13 2019, 12:48 PM
chuck committed rS349969: bhyve: Create EUI64 for NVMe namespaces.
bhyve: Create EUI64 for NVMe namespaces
Jul 13 2019, 12:48 PM

Jul 12 2019

chuck added a comment to D19905: bhyve: Add EUI64 to NVMe device.

Updated based on jhb's feedback

Jul 12 2019, 5:42 PM

Jun 9 2019

chuck committed rS348824: Fix uninitialized variable in camdd.
Fix uninitialized variable in camdd
Jun 9 2019, 2:06 AM

Jun 8 2019

chuck closed D12141: Add NVMe support to camdd.

Committed https://svnweb.freebsd.org/changeset/base/348806

Jun 8 2019, 5:20 PM
chuck committed rS348806: Add NVMe support to camdd(8).
Add NVMe support to camdd(8)
Jun 8 2019, 5:17 PM

Jun 7 2019

chuck committed rS348786: Fix nda(4) PCIe link status output.
Fix nda(4) PCIe link status output
Jun 7 2019, 6:35 PM
chuck closed D20282: Fix nda(4) PCIe link status output.
Jun 7 2019, 6:35 PM
chuck committed rS348781: bhyve: Add PCIe Integrated Endpoint capability.
bhyve: Add PCIe Integrated Endpoint capability
Jun 7 2019, 5:12 PM
chuck closed D19904: bhyve: Add Integrated Endpoint to PCIe Capability.
Jun 7 2019, 5:12 PM

Jun 4 2019

chuck added a comment to D19746: Introduce sim_dev and cam_sim_alloc_dev()..

The change looks reasonable to me. Are there any ABI issues with changing the size of struct cam_sim?

Jun 4 2019, 5:08 PM

May 18 2019

chuck updated the diff for D20282: Fix nda(4) PCIe link status output.

Convert to using sbuf to avoid log messages from being interleaved once the discovery is done in parallel

May 18 2019, 2:47 AM
chuck updated the diff for D19905: bhyve: Add EUI64 to NVMe device.

Fixed copyright attribution

May 18 2019, 1:24 AM
chuck added a comment to D20282: Fix nda(4) PCIe link status output.
In D20282#437333, @imp wrote:

This looks good. The multiple printfs give me heart-burn, but that's for another day. This part of the code they should be safe, but they aren't safe in a future where we do device discovery in parallel.

May 18 2019, 12:31 AM

May 17 2019

chuck created D20282: Fix nda(4) PCIe link status output.
May 17 2019, 12:45 AM

May 16 2019

chuck updated the diff for D19905: bhyve: Add EUI64 to NVMe device.

Updated patch to define OUI range specifically for NVMe
Fixed typo while I was in ieee_oui.h (reviewed by kevans)
Use NVMe OUI macro when creating the EUI64 value. Feeds the vmname + the PCI BDF into crc16 to make the low 16 bits "unique"

May 16 2019, 7:07 PM

May 15 2019

chuck added a comment to D19904: bhyve: Add Integrated Endpoint to PCIe Capability.

From my reading of the virtio specification, virtio devices must conform to the bus spec they are emulating. So if our virtio devices don't say PCIe, they shouldn't need the PCIe CAP.

May 15 2019, 7:30 PM
chuck updated the diff for D19904: bhyve: Add Integrated Endpoint to PCIe Capability.

Update to incorporate feedback from Rod and John

May 15 2019, 6:23 PM

May 1 2019

chuck added a comment to D14835: Enhance support for Linux mremap system call.

Ping

May 1 2019, 1:32 PM

Apr 14 2019

chuck created D19905: bhyve: Add EUI64 to NVMe device.
Apr 14 2019, 1:30 AM
chuck created D19904: bhyve: Add Integrated Endpoint to PCIe Capability.
Apr 14 2019, 1:24 AM

Apr 13 2019

chuck closed D19580: Fix bhyve PCIe capability emulation.
Apr 13 2019, 11:38 PM
chuck committed rS346194: Revert r345171 pending review.
Revert r345171 pending review
Apr 13 2019, 11:37 PM

Apr 7 2019

chuck removed a reviewer for D19841: bhyve NVMe emulation locking: bhyve.
Apr 7 2019, 7:14 PM
chuck created D19841: bhyve NVMe emulation locking.
Apr 7 2019, 7:13 PM

Apr 5 2019

chuck closed D19695: bhyve(8): Fix NVMe data structure copy to guest.
Apr 5 2019, 4:54 PM
chuck committed rS345957: bhyve: Fix NVMe data structure copy to guest.
bhyve: Fix NVMe data structure copy to guest
Apr 5 2019, 4:54 PM
chuck committed rS345956: bhyve: Fix NVMe BAR size calculation.
bhyve: Fix NVMe BAR size calculation
Apr 5 2019, 4:54 PM
chuck closed D19676: bhyve: Fix NVMe BAR size calculation.
Apr 5 2019, 4:54 PM
chuck added a comment to D19695: bhyve(8): Fix NVMe data structure copy to guest.
In D19695#423813, @imp wrote:

This looks good to me. It's the right thing to do.
Do we need to expand it more generally (in a different commit) for any time we have to copy data out, or is the I/O path good?

Apr 5 2019, 4:00 PM

Apr 4 2019

chuck added a comment to D19676: bhyve: Fix NVMe BAR size calculation.
In D19676#423809, @imp wrote:

one quick Q. if you know the windows versions, document it in the comment.

Apr 4 2019, 3:30 PM

Mar 26 2019

chuck added a comment to D19580: Fix bhyve PCIe capability emulation.
In D19580#422125, @jhb wrote:

Hmm, due to what this bit actually does, I'd probably be inclined to not set it if we don't need it. When the role based error reporting is set, it means we also support at least one other register to configure the mask of fatal vs non-fatal errors IIRC which I'm pretty sure we don't do. I had assumed Windows was failing to boot without this bit set. If Windows is actually fine then I think I'd prefer we drop it until we find a need for it. A PCIe 1.0 device can have this bit clear and still be compliant. The other thing about being a special endpoint when directly hung off the RC would be required even for 1.0 compliance.

Mar 26 2019, 1:18 PM

Mar 24 2019

chuck resigned from D14703: nvme: Revert to using the old API..
Mar 24 2019, 10:02 PM
chuck created D19695: bhyve(8): Fix NVMe data structure copy to guest.
Mar 24 2019, 5:18 PM

Mar 23 2019

chuck added a comment to D19580: Fix bhyve PCIe capability emulation.

One of @jhb requests was a comment on why the RBER change was needed. Here is the thought process:

Mar 23 2019, 5:38 PM
chuck reopened D19580: Fix bhyve PCIe capability emulation.
Mar 23 2019, 5:21 PM
chuck committed rS345454: MFC r345170:.
MFC r345170:
Mar 23 2019, 4:46 PM
chuck committed rS345453: MFC r342761:.
MFC r342761:
Mar 23 2019, 4:42 PM
chuck committed rS345451: MFC r342762:.
MFC r342762:
Mar 23 2019, 4:30 PM
chuck updated the diff for D19676: bhyve: Fix NVMe BAR size calculation.

Updated based on feedback

Mar 23 2019, 2:30 AM

Mar 22 2019

chuck created D19676: bhyve: Fix NVMe BAR size calculation.
Mar 22 2019, 5:22 AM

Mar 15 2019

chuck committed rS345171: Fix bhyve PCIe capability emulation.
Fix bhyve PCIe capability emulation
Mar 15 2019, 2:12 AM
chuck closed D19580: Fix bhyve PCIe capability emulation.
Mar 15 2019, 2:12 AM
chuck committed rS345170: Fix bhyve's NVMe Identify Namespace data.
Fix bhyve's NVMe Identify Namespace data
Mar 15 2019, 2:11 AM
chuck closed D19579: Fix bhyve's NVMe Identify Namespace data.
Mar 15 2019, 2:11 AM
chuck added inline comments to D19580: Fix bhyve PCIe capability emulation.
Mar 15 2019, 12:47 AM

Mar 14 2019

chuck updated the diff for D19580: Fix bhyve PCIe capability emulation.

added wrong diff

Mar 14 2019, 10:11 AM
chuck created D19580: Fix bhyve PCIe capability emulation.
Mar 14 2019, 9:55 AM
chuck added reviewers for D19579: Fix bhyve's NVMe Identify Namespace data: imp, ken, araujo.
Mar 14 2019, 9:50 AM
chuck updated the diff for D19579: Fix bhyve's NVMe Identify Namespace data.

style(9)

Mar 14 2019, 9:49 AM
chuck created D19579: Fix bhyve's NVMe Identify Namespace data.
Mar 14 2019, 9:48 AM

Mar 3 2019

chuck accepted D19431: Don't print all the I/O we abort on a reset, unless we're out of retries..

LGTM

Mar 3 2019, 4:38 PM

Jan 8 2019

chuck added a comment to D18772: Add NVMe drive to NOIOB quirk list.
In D18772#400655, @imp wrote:

This works for me. There is a newer way to cope with this, but I don't think the 4600 implements this, so this change is appropriate.

Jan 8 2019, 3:35 PM
chuck committed rS342862: Add NVMe drive to NOIOB quirk list.
Add NVMe drive to NOIOB quirk list
Jan 8 2019, 3:31 PM
chuck closed D18772: Add NVMe drive to NOIOB quirk list.
Jan 8 2019, 3:31 PM

Jan 7 2019

chuck added a comment to D18772: Add NVMe drive to NOIOB quirk list.
In D18772#400520, @mav wrote:

I have no objections, if its true.

Jan 7 2019, 5:20 PM
chuck added reviewers for D18772: Add NVMe drive to NOIOB quirk list: imp, ken, mav.
Jan 7 2019, 3:41 PM
chuck created D18772: Add NVMe drive to NOIOB quirk list.
Jan 7 2019, 3:41 PM

Jan 4 2019

chuck committed rS342777: MFC r342046: nda(4) fix check for Dataset Management support.
MFC r342046: nda(4) fix check for Dataset Management support
Jan 4 2019, 9:06 PM
chuck closed D18746: MFC r342046: nda(4) fix check for Dataset Management support.
Jan 4 2019, 9:06 PM
chuck created D18746: MFC r342046: nda(4) fix check for Dataset Management support.
Jan 4 2019, 5:03 PM
chuck closed D18703: Fix bhyve's NVMe Completion Queue entry values.
Jan 4 2019, 3:03 PM · bhyve
chuck committed rS342761: Fix bhyve's NVMe queue bookkeeping.
Fix bhyve's NVMe queue bookkeeping
Jan 4 2019, 3:03 PM
chuck committed rS342762: Fix bhyve's NVMe Completion Queue entry values.
Fix bhyve's NVMe Completion Queue entry values
Jan 4 2019, 3:03 PM
chuck closed D18702: Fix bhyve's NVMe queue bookkeeping.
Jan 4 2019, 3:03 PM · bhyve

Jan 2 2019

chuck added a comment to D18703: Fix bhyve's NVMe Completion Queue entry values.

LGTM! Could you please set a MFC?

Jan 2 2019, 5:44 PM · bhyve

Dec 31 2018

chuck closed D15996: Add PNP info to PCI attachment of arcmsr, bt, cbb, de, ebus, emujoy, fixup_pci, hifn, hptiop, imcsmb, snd_emu10k1 (emu_pci) drivers.
Dec 31 2018, 7:14 PM
chuck accepted D15996: Add PNP info to PCI attachment of arcmsr, bt, cbb, de, ebus, emujoy, fixup_pci, hifn, hptiop, imcsmb, snd_emu10k1 (emu_pci) drivers.
Dec 31 2018, 7:13 PM
chuck closed D16233: Update BKTR, ISMT, IIR, IWM, IPS, IGNORE, IMCSMB, FIXUP, DE, DPT, GRACKLE to use PCI_MATCH.
Dec 31 2018, 7:13 PM
chuck accepted D16233: Update BKTR, ISMT, IIR, IWM, IPS, IGNORE, IMCSMB, FIXUP, DE, DPT, GRACKLE to use PCI_MATCH.
Dec 31 2018, 7:13 PM
chuck closed D16253: Update GLXSB, EBUS, EMU, EMUJOY, HIFN, BT, ARCMSR, HME, CP, CE, BFE to use PCI_MATCH.
Dec 31 2018, 7:13 PM
chuck accepted D16253: Update GLXSB, EBUS, EMU, EMUJOY, HIFN, BT, ARCMSR, HME, CP, CE, BFE to use PCI_MATCH.
Dec 31 2018, 7:13 PM
chuck closed D16324: Add PNP info to PCI attachment of IICOC, IPMI, ISP, ISCI, IXL, IXLV, IWN, IWI, IDA, IG4 drivers.
Dec 31 2018, 7:12 PM
chuck accepted D16324: Add PNP info to PCI attachment of IICOC, IPMI, ISP, ISCI, IXL, IXLV, IWN, IWI, IDA, IG4 drivers.
Dec 31 2018, 7:12 PM
chuck closed D16363: Add PNP info to PCI attachments of LE, LIO, MPR, MVS, MY drivers.
Dec 31 2018, 7:12 PM
chuck accepted D16363: Add PNP info to PCI attachments of LE, LIO, MPR, MVS, MY drivers.
Dec 31 2018, 7:12 PM
chuck closed D16540: Add PNP info to PCI attachments of MFI, MALO, MWL, NFSMB, NGE, NTB_PLX, NLMSEC, NLMRSA, NFE, NVME drivers.
Dec 31 2018, 7:12 PM
chuck accepted D16540: Add PNP info to PCI attachments of MFI, MALO, MWL, NFSMB, NGE, NTB_PLX, NLMSEC, NLMRSA, NFE, NVME drivers.
Dec 31 2018, 7:11 PM
chuck closed D16594: Add PNP info to PCI attachments of PCIBIOS, PCIB, QLA, QLA80XX, QL, PIIX, RP, OCE, RE, PPC driver.
Dec 31 2018, 7:11 PM
chuck accepted D16594: Add PNP info to PCI attachments of PCIBIOS, PCIB, QLA, QLA80XX, QL, PIIX, RP, OCE, RE, PPC driver.
Dec 31 2018, 7:11 PM
chuck closed D16612: First attempt at documenting use of PCI_PNP_INFO.
Dec 31 2018, 7:10 PM
chuck accepted D16612: First attempt at documenting use of PCI_PNP_INFO.
Dec 31 2018, 7:10 PM
chuck closed D16691: Add PNP info to PCI attachments of RAL, RE, RL, PCN, PSTPCI, SGE, SIS, STE, drivers, defining and documenting PCI_SUBVID macro.
Dec 31 2018, 7:10 PM
chuck accepted D16691: Add PNP info to PCI attachments of RAL, RE, RL, PCN, PSTPCI, SGE, SIS, STE, drivers, defining and documenting PCI_SUBVID macro.
Dec 31 2018, 7:09 PM
chuck created D18703: Fix bhyve's NVMe Completion Queue entry values.
Dec 31 2018, 6:58 PM · bhyve
chuck updated the diff for D18702: Fix bhyve's NVMe queue bookkeeping.

Use ONE_BASED() macro for CQ creation as well as SQ

Dec 31 2018, 6:54 PM · bhyve