- User Since
- Dec 7 2017, 1:03 PM (52 w, 6 d)
Tue, Dec 11
Mon, Dec 10
Oct 7 2018
Oct 5 2018
This is marked as blocked by @mat
Should I still wait for their review or is this OK to land?
Aug 22 2018
Alternative approach outlined in D16404 committed to svn
@mav thanks for the reminder. version bumped to 1200081
Aug 19 2018
Fixed style issues
Aug 16 2018
Add the user space changes and commit message
Aug 12 2018
Jul 23 2018
Removed Linux stuff that crept into the patch
Jul 16 2018
Jul 4 2018
Jul 3 2018
Jun 28 2018
Jun 24 2018
Jun 22 2018
Jun 21 2018
[v3] Fix the Linux kernel version number calculation
The updated summary is what will go into the commit message.
[v2] Fix the Linux kernel version number calculation
[v3] Fix output of linprocfs stat
Added PR 229209 to track the osrelease issue and posted a proposed fix in https://reviews.freebsd.org/D15952
Jun 19 2018
[v2] Fix output of linprocfs stat
Jun 16 2018
Since @mav committed something similar, abandoning this review.
Jun 15 2018
Jun 13 2018
Update function comment to add details recommend by @emaste
Jun 12 2018
May 25 2018
May 24 2018
style(9) fix in linprocfs_dominfree()
Mar 24 2018
Mar 15 2018
These changes look good to me.
Should the register definitions and other structures which previously used bit fields get similar changes?
Ditto for sbin/nvmecontrol/*?
Mar 13 2018
Mar 9 2018
Mar 1 2018
When deciding how to export data from CAM, can you describe when using a XPT_KV_GET is preferred over XPT_DEV_ADVINFO?
Jan 25 2018
Looks good to me.
Overall, it is exciting to see this work being done. I realize the code is in its early stages and has asserts to help catch "the important" code paths, but it might be good to remove some of the asserts and have the commands set standard NVMe errors where appropriate.
Dec 11 2017
Other than the noted if check, this looks good to me.