- User Since
- Dec 7 2017, 1:03 PM (28 w, 8 h)
[v3] Fix the Linux kernel version number calculation
The updated summary is what will go into the commit message.
[v2] Fix the Linux kernel version number calculation
[v3] Fix output of linprocfs stat
Added PR 229209 to track the osrelease issue and posted a proposed fix in https://reviews.freebsd.org/D15952
Tue, Jun 19
[v2] Fix output of linprocfs stat
Sat, Jun 16
Since @mav committed something similar, abandoning this review.
Fri, Jun 15
Wed, Jun 13
Update function comment to add details recommend by @emaste
Tue, Jun 12
Fri, May 25
Thu, May 24
style(9) fix in linprocfs_dominfree()
Mar 24 2018
Mar 15 2018
These changes look good to me.
Should the register definitions and other structures which previously used bit fields get similar changes?
Ditto for sbin/nvmecontrol/*?
Mar 13 2018
Mar 9 2018
Mar 1 2018
When deciding how to export data from CAM, can you describe when using a XPT_KV_GET is preferred over XPT_DEV_ADVINFO?
Jan 25 2018
Looks good to me.
Overall, it is exciting to see this work being done. I realize the code is in its early stages and has asserts to help catch "the important" code paths, but it might be good to remove some of the asserts and have the commands set standard NVMe errors where appropriate.
Dec 11 2017
Other than the noted if check, this looks good to me.