There's a number of PCIe cards today that are not, strictly speaking
storage cards. For any PCIe card, make sure that it supports the proper
PCI ProgIF before attaching to it.
Sponsored by: Netflix
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 66791 Build 63674: arc lint + arc unit
Event Timeline
| sys/cam/nvme/nvme_da.c | ||
|---|---|---|
| 678 | Would it make sense to log this? No log message for the previous "device is not NVMe" is fine, but here, the code is noticing "this is the wrong kind of NVMe device" feels different (maybe). | |
| sys/cam/nvme/nvme_da.c | ||
|---|---|---|
| 678 | I think so, so long as we can have a good error message. It will be rare to see this, so we don't need to rate limit it, and it will happen only with weird, odd-ball cards, which is fine for those users. | |