Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 14, 3:08 AM

	Unknown Object (File)
	Sun, Apr 12, 9:25 AM

	Unknown Object (File)
	Sun, Apr 12, 9:21 AM

	Unknown Object (File)
	Sat, Apr 11, 11:46 PM

	Unknown Object (File)
	Sat, Apr 11, 11:06 AM

	Unknown Object (File)
	Fri, Apr 10, 9:55 PM

	Unknown Object (File)
	Tue, Apr 7, 4:05 AM

	Unknown Object (File)
	Thu, Apr 2, 5:40 PM

Subscribers

Details

Reviewers

imp
chuck

Group Reviewers

bhyve

Commits

rG80a92f1b91ed: nvme: Rename NVMEB helper macro to NVMEM
rG1dade1f255ee: nvme: Rename NVMEB helper macro to NVMEM

Summary

The current macro always builds a full mask for a named field, so use
the M suffix for mask.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 25 2024, 10:29 PM

Herald added a reviewer: bhyve. · View Herald TranscriptJan 25 2024, 10:29 PM

Herald added subscribers: dab, bcran, rgrimes. · View Herald Transcript

jhb requested review of this revision.Jan 25 2024, 10:29 PM

jhb added a parent revision: D43600: bhyve: Use NVMEV to read the ASQS field of AQA.

Harbormaster completed remote builds in B55615: Diff 133365.Jan 25 2024, 10:29 PM

jhb added a child revision: D43602: nvme: Use the NVMEM macro instead of expanded versions.Jan 25 2024, 10:29 PM

jhb added a reviewer: chuck.Jan 25 2024, 10:30 PM

imp accepted this revision.Jan 25 2024, 10:41 PM

This revision is now accepted and ready to land.Jan 25 2024, 10:41 PM

chuck accepted this revision.Jan 28 2024, 12:54 AM

Closed by commit rG1dade1f255ee: nvme: Rename NVMEB helper macro to NVMEM (authored by jhb). · Explain WhyJan 29 2024, 7:03 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG1dade1f255ee: nvme: Rename NVMEB helper macro to NVMEM.

jhb added a commit: rG80a92f1b91ed: nvme: Rename NVMEB helper macro to NVMEM.Aug 26 2024, 6:03 PM

nvme: Rename NVMEB helper macro to NVMEM
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 133520

sys/dev/nvme/nvme.h

usr.sbin/bhyve/pci_nvme.c

nvme: Rename NVMEB helper macro to NVMEMClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 133520

sys/dev/nvme/nvme.h

usr.sbin/bhyve/pci_nvme.c

nvme: Rename NVMEB helper macro to NVMEM
ClosedPublic
Actions

Revision Contents
Changeset List