In D59997#1377731, @adrian wrote:

Does the specification actually talk about what it uses it for? And can you change it during normal operation?

eg, what if the time it got was plainly wrong (not that there's no RTC, but the RTC is very very wrong) and it takes an ntpdate/ntpd trip to get it up to date.
What should the driver / controller do in this instance?

In D59631#1377509, @ngie wrote:

@seuros : I won't be able to provide a ship-it this weekend, but could you please provide the spec link for this and other related items in the future so @adrian and I can help provide you quicker ship-its?

(to be fair I have the attention span of Doug from Up and the short-term memory of a Dory from Finding Nemo: having the info helps future me track down what I was thinking if I need to look it up later :)..)

Do we support (or have plans to support) NVMe over thunderbolt or lower bandwidth USB? If so, I can see that being a future potential problem (even for platforms that lack PCI support).

IIRC, some RPi models, though I don't know if it's the PCI-capable ones or not. Some of the rockchip boards. At least some of these don't have ToD RTC that survive reboot and/or power cycle.

In D59997#1377152, @imp wrote:

This looks good, but wondering how well we know time at mountroot(). For most platforms likely "pretty good" but there's some w/o rtc that could support nvme drives that might end up setting the wrong time. Is that acceptable here?

In D59596#1377096, @olce wrote:

Ping? If you need more info or more generally some help from me, don't hesitate to say so.

This diff implement it , the watchdog change is already here.

I tested this on real hardware, with the exception of a few -* variants, but Linux handles them the same way. (I can also get that hardware in the next days.)

refactor

In D59628#1374245, @ngie wrote:

I couldn't find the constants in the NVMe spec. Could you please help me understand where you are getting this info from?

style nit

This is awesome! I had few NVMEs wedge before this fix.

address ngie and emaste comments

rebase.

Yes! Your Alder lake should attach with this diff.

Please add it as you said. Had you done as I asked it would be a lot less work for you and cleaner, and I would not have to be here arguing with you about it.

i wrote that the driver is still not complete there are many other generations to work on like D59596. < and this is not the last one.

align/fix whitespaces

fix man pages

adress olce comments

remove prose

rebase on main

refactor/doc/split driver

refactor/split/document driver

format