In D60984#1398481, @adrian wrote:

Hm, how long has this been broken for? How'd you find it?

14 months, from 851dc7f859c2 by jamie.

@imp ping

What are you fixing with this change? This comment describes what the patch is doing, but not the punchline, e.g., "this fixes a panic", "this fixes a jail descriptor leak", "this returns the right data in <X scenario>", etc.

address ngie's remarks.

rebase

address comments

reworked

Switched to a named constant, BCL_FIRST_LEVEL, alongside the existing
BCL_FULLPOWER/BCL_ECONOMY just above it. 3 is not an array size:
it returns the full-power level at [0], the economy level at [1], and the
selectable levels from [2]

The disabled by default was because i want to land it, ask current@ and other testers to enable it.
If there are no report of boards that misfire randomly , then followup with a default enabled before 16 release.

address ngie comment

fix man page

split change

In tree ? none. we missing it.

relnotes

relnotes

rebase

rebase

In D59997#1377731, @adrian wrote:

Does the specification actually talk about what it uses it for? And can you change it during normal operation?

eg, what if the time it got was plainly wrong (not that there's no RTC, but the RTC is very very wrong) and it takes an ntpdate/ntpd trip to get it up to date.
What should the driver / controller do in this instance?

In D59631#1377509, @ngie wrote:

@seuros : I won't be able to provide a ship-it this weekend, but could you please provide the spec link for this and other related items in the future so @adrian and I can help provide you quicker ship-its?

(to be fair I have the attention span of Doug from Up and the short-term memory of a Dory from Finding Nemo: having the info helps future me track down what I was thinking if I need to look it up later :)..)

Do we support (or have plans to support) NVMe over thunderbolt or lower bandwidth USB? If so, I can see that being a future potential problem (even for platforms that lack PCI support).

IIRC, some RPi models, though I don't know if it's the PCI-capable ones or not. Some of the rockchip boards. At least some of these don't have ToD RTC that survive reboot and/or power cycle.

In D59997#1377152, @imp wrote:

This looks good, but wondering how well we know time at mountroot(). For most platforms likely "pretty good" but there's some w/o rtc that could support nvme drives that might end up setting the wrong time. Is that acceptable here?

In D59596#1377096, @olce wrote:

Ping? If you need more info or more generally some help from me, don't hesitate to say so.

This diff implement it , the watchdog change is already here.

I tested this on real hardware, with the exception of a few -* variants, but Linux handles them the same way. (I can also get that hardware in the next days.)