Address review feedback: gate raw interface behind ASMC_DEBUG, fix return parens in len/type sysctls, wrap long line in value sysctl, match retry loop style with asmc_key_read, document in asmc.4

Revert dynamic detection: Thunderbolt Display Audio (0x05ac:0x1107) has a 5-byte HID input report and caused a false positive on Mac Mini 2011 test hardware. Restore static product ID table.

Replace static product ID table with dynamic report descriptor detection: match any Apple USB HID device with a 5-byte input report

Address reviewer feedback: make_dev_s, extract map helper, header fixes, man page style

Address review: clarify licensing, rewrite HARDWARE section with USB IDs

Nobody would hunt you for opening a diff, and you do not need to ask for permissions. Another thing, would be the diff with AI-generated content accepted. Our policy is that no AI content is allowed.
OTOH, thank you for being honest there.

@kib The patch you provided is solid. worked!

@imp This initial driver is basic for now and expose activity/timing that happen since power-on. You can see the Dram training, and any delay on the EUFI/Bios

I will and report back.

The reverse engineering of the Apple IR protocol was done by James McKenzie in the Linux driver 2 decades ago.
I referenced the Linux files in the original message and in the code (see line 14).

I tested this in multiple board as each hardware expose a different set of registry.

Address review feedback and add hardware test results

duplicate of D55577 . or vice versa.

Move ppi_spkr_on/off under clock_lock

No changes, syncing branch

Factor reg32 sysctls into single handler, fix SLP_S0 description with reference

Add man page, fix SPDX header order

This driver was supposed to be a port form Linux Apple IR driver.

Remove debug DPRINTFN calls and verbose NEC code comments

Extract WLSW.SHRF call into acpi_panasonic_clear_rfkill() to avoid duplication between attach and resume

replaced with proper fix in D55413 by @ngie.

Address style(9) nits: remove space in cast, use explicit != 0 comparison

This works and has been stable in my testing for several weeks.

This is awesome, this is the similar concept i was planning on proposing,

In D55287#1264434, @imp wrote:

not sure about the other two.

This code needs refinement but i opened this diff to get guidance.

I do not have a Freebsd email for the moment.

Sure i can close this diff.

• atrtc0 (ISA) attaches first during boot gets IRQ 8
• atrtc1 (ACPI) attaches second also registers as a TOD clock

In D54954#1260711, @jhb wrote:

You still haven't answered the question of how you get multiple atrtcX devices in the first place. That should Never Happen(tm) and probably points to some other bug elsewhere that we should handle instead of applying a band-aid to atrtc(4).

Your approach is much more elegant..

• intel/intel_pmc_core: Remove unnecessary NULL check in detach

Reverting to datasheet value (100us). Linux's 104us likely quirk on untested vendors.

Addressed feedback:

• SPDX first line, split copyright/description
• Alphabetized includes and build files
• Updated counter to 104us (empirical/Linux)
• Refactored with pmc_read_safe() helper
• Documented S0ix scope
• Removed slp_s0_step member

This looks like a breaking change. Not sure if the solution is to detect the cpu (since having both types in the same motherboard is not possible).

I have the full thunderbolt 1/2/3/4 work lined up... I'm trying to split them into smaller chuncks .

Wire into build; add PL2 enabled/lock bit; align sysctl names

Add files.x86 and modules entries; align slp_s0_residency sysctl name

Only add dev.asmc.*.wol when AUPO exists; add key constant

Prefer unit 0 using devclass check; remove global sentinel. Drop RF_SHAREABLE and document IRQ 8.

Make dev.asmc.*.raw.len read-only to prevent user overrides

Fix tab alignment in usbdevs

Address review feedback: keep warn variable, invert at assignment instead of double-negative

@manu thanks for the work here, do you plan to resume this driver effort ? I ran into the same hang on boot that @saper_saper.info reported, and on top of that I see a crash at runtime after a few minutes.

@ngie i prefered to keep this diff scoped to ACPI discovery only, but the switching is important too.

Updated the diff .

Adding dump_app in another diff.

Sorry, still using arc incorrectly. Need i need to learn git-arc.

speaker, clock: Replace Giant lock with fine-grained locking

We could wrap it with a sleep mutex, but concurrent fan control from multiple threads is not a realistic scenario.
The worst case is a lost update, not a crash.

oss@seuros.com (like the previous commits)

This module load only in apple hardware. Spparently the hardware is not build to have it driver hot reloaded.

Duplicate of D54439.