nvme: enforce the Abort Command Limit
Needs ReviewPublic
Actions

Authored by seuros on Sun, Sep 13, 10:31 AM.

Details

Reviewers

imp
adrian

Summary

Each watchdog pass submitted an Abort for every timed-out command
with nothing counting them against the controller's ACL. A
controller may complete excess Aborts with Abort Command Limit
Exceeded status.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 76828
Build 73711: arc lint + arc unit

Event Timeline

seuros created this revision.Sun, Sep 13, 10:31 AM

Herald added a subscriber: dab. · View Herald TranscriptSun, Sep 13, 10:31 AM

seuros requested review of this revision.Sun, Sep 13, 10:31 AM

Harbormaster completed remote builds in B76828: Diff 186581.Sun, Sep 13, 10:31 AM

seuros added a parent revision: D59634: nvme: do not complete a command when its Abort is not performed.Sun, Sep 13, 10:36 AM

seuros added a child revision: D59637: nvme: do not touch INTMS/INTMC when configured for MSI-X.Thu, Sep 24, 5:20 PM

seuros added a child revision: D59997: nvme: set the controller Timestamp feature.Fri, Sep 25, 10:37 AM

seuros removed a child revision: D59997: nvme: set the controller Timestamp feature.

@imp ping?

reset needs to zero this, no?

sys/dev/nvme/nvme_qpair.c
988	Since this isn't the only place we reset the controller, don't we need to directly zero this in the reset path?

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

nvme_private.h

1 line

nvme_qpair.c

8 lines

Diff 186581

View Options

sys/dev/nvme/nvme_private.h