Details

Reviewers

imp
dab
adrian
ngie

Commits

rGb99595c9c7f8: nvme: derive CC.CSS from CAP.CSS instead of hardcoding the NVM set

Summary

CC.CSS was always writting zero, which is a reserved encoding on a
controller that does not support the NVM command set.
Select 111b on admin-only controllers and 110b when the
I/O command set mechanism is available.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

seuros requested review of this revision.Sep 13 2026, 8:56 AM

seuros created this revision.

Harbormaster completed remote builds in B76818: Diff 186563.Sep 13 2026, 8:56 AM

seuros added a project: drivers.Sep 13 2026, 10:05 AM

seuros added a parent revision: D59627: nvme: honor FLBAS Format Index Upper when selecting the LBA format.

seuros added a child revision: D59631: nvme: honor CRTO for the controller ready timeout.

format

Harbormaster completed remote builds in B76827: Diff 186579.Sep 13 2026, 10:27 AM

I couldn't find the constants in the NVMe spec. Could you please help me understand where you are getting this info from?

sys/dev/nvme/nvme_ctrlr.c
366	Is this indentation correct?
405–412	style(9) nit.

style nit

Harbormaster completed remote builds in B77152: Diff 187368.Sep 22 2026, 2:51 AM

In D59628#1374245, @ngie wrote:

I couldn't find the constants in the NVMe spec. Could you please help me understand where you are getting this info from?

https://nvmexpress.org/wp-content/uploads/NVM-Express-Base-Specification-Revision-2.4-Ratified-2026.07.31.pdf page 107