nvme: derive CC.CSS from CAP.CSS instead of hardcoding the NVM set
Needs ReviewPublic
Actions

Authored by seuros on Sun, Sep 13, 8:56 AM.

Details

Reviewers

imp
dab
adrian
ngie

Summary

CC.CSS was always writting zero, which is a reserved encoding on a
controller that does not support the NVM command set.
Select 111b on admin-only controllers and 110b when the
I/O command set mechanism is available.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 76827
Build 73710: arc lint + arc unit

Event Timeline

seuros requested review of this revision.Sun, Sep 13, 8:56 AM

seuros created this revision.

Harbormaster completed remote builds in B76818: Diff 186563.Sun, Sep 13, 8:56 AM

seuros added a project: drivers.Sun, Sep 13, 10:05 AM

seuros added a parent revision: D59627: nvme: honor FLBAS Format Index Upper when selecting the LBA format.

seuros added a child revision: D59631: nvme: honor CRTO for the controller ready timeout.

format

Harbormaster completed remote builds in B76827: Diff 186579.Sun, Sep 13, 10:27 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

nvme.h

9 lines

nvme_ctrlr.c

13 lines

Diff 186579

View Options

sys/dev/nvme/nvme.h