Page MenuHomeFreeBSD

ken (Ken Merry)
User

Projects

User Details

User Since
Jan 23 2015, 10:35 PM (229 w, 1 d)

Recent Activity

Fri, May 31

ken committed rS348483: MFC r348247:.
MFC r348247:
Fri, May 31, 8:36 PM
ken committed rS348480: MFC r348247:.
MFC r348247:
Fri, May 31, 8:15 PM

Fri, May 24

ken committed rS348247: Fix FC-Tape bugs caused in part by r345008..
Fix FC-Tape bugs caused in part by r345008.
Fri, May 24, 5:58 PM

Sat, May 18

ken accepted D12141: Add NVMe support to camdd.
Sat, May 18, 2:13 AM
ken accepted D19904: bhyve: Add Integrated Endpoint to PCIe Capability.
Sat, May 18, 12:54 AM
ken accepted D20282: Fix nda(4) PCIe link status output.
In D20282#437333, @imp wrote:

This looks good. The multiple printfs give me heart-burn, but that's for another day. This part of the code they should be safe, but they aren't safe in a future where we do device discovery in parallel.

It would be easy to turn this into a series of snprintfs() and then a single printf(). Would that clear the heartburn?

Sat, May 18, 12:43 AM

Fri, May 17

ken committed rS347906: MFC r345008:.
MFC r345008:
Fri, May 17, 2:30 PM

May 16 2019

ken committed rS347894: MFC r345008:.
MFC r345008:
May 16 2019, 10:03 PM
ken committed rS347885: MFC 344761:.
MFC 344761:
May 16 2019, 6:50 PM
ken committed rS347884: MFC 344761:.
MFC 344761:
May 16 2019, 6:42 PM

Mar 11 2019

ken accepted D19536: Add -l to camcontrol readcap..

Looks good to me.

Mar 11 2019, 2:24 PM
ken committed rS345008: Fix CRN resets in the isp(4) driver in certain situations..
Fix CRN resets in the isp(4) driver in certain situations.
Mar 11 2019, 2:21 PM
ken closed D19472: Fix isp(4) CRN handling in some situations..
Mar 11 2019, 2:21 PM

Mar 5 2019

ken added a comment to D19369: Make isp(4) suggest loading ispfw(4) when it fails to attach..

I think it would actually be better to add the suggestion to put in ispfw_load whenever the user isn't on a 16Gb board and hasn't loaded firmware.

Mar 5 2019, 9:53 PM
ken updated the summary of D19472: Fix isp(4) CRN handling in some situations..
Mar 5 2019, 9:50 PM
ken updated the summary of D19472: Fix isp(4) CRN handling in some situations..
Mar 5 2019, 9:49 PM
ken created D19472: Fix isp(4) CRN handling in some situations..
Mar 5 2019, 9:47 PM

Mar 4 2019

ken committed rS344761: Add IBM TS1160 density codes to libmt and the mt(1) man page..
Add IBM TS1160 density codes to libmt and the mt(1) man page.
Mar 4 2019, 2:30 PM

Feb 19 2019

ken accepted D19249: Limit the number of REPORT_ZONES entries allocated in the kernel..

I tested this out with a Seagate 8TB host aware drive:

Feb 19 2019, 8:00 PM
ken added a comment to D19249: Limit the number of REPORT_ZONES entries allocated in the kernel..

This change looks good. However, zonectl(8) currently hard-codes the entries_allocated field and doesn't check for a short return. If the kernel truncates the zone list, the user will have no obvious way of knowing. I think zonectl(8) should be modified to either loop until all zones have been reported, or at least tell the user that not all zones were reported.

Feb 19 2019, 7:37 PM

Jan 15 2019

ken added inline comments to D18841: New port: sysutils/ltfs: Reference implementation of LTFS for stand alone tape drive.
Jan 15 2019, 4:24 PM

Jan 14 2019

ken accepted D18841: New port: sysutils/ltfs: Reference implementation of LTFS for stand alone tape drive.

Looks good. I assume you've made sure this installs correctly. I put a couple of suggestions in the description file, although the comment about MAXPHYS might also go into something that the user will see when he installs the package.

Jan 14 2019, 8:06 PM

Oct 12 2018

ken committed rS339336: MFC r339076.
MFC r339076
Oct 12 2018, 7:44 PM

Oct 5 2018

ken added a comment to D16837: Document FreeBSD version 1200081.

Is the doc tree in freeze like the src tree? i.e. does he need permission from doceng?

Oct 5 2018, 2:28 PM
ken accepted D16837: Document FreeBSD version 1200081.

No idea why @mat blocked it, but I'm sure he can explain.

Oct 5 2018, 1:40 PM

Oct 1 2018

ken committed rS339076: Fix a da(4) driver memory leak for SCSI SMR devices..
Fix a da(4) driver memory leak for SCSI SMR devices.
Oct 1 2018, 7:01 PM

Jul 17 2018

ken accepted D16196: OCS_FC: Wait for a specific period of time prior to telling the OS about lost device..

Approved. Looks good, thank you!

Jul 17 2018, 2:10 PM

Jul 10 2018

ken added a comment to D16196: OCS_FC: Wait for a specific period of time prior to telling the OS about lost device..

Overall it looks ok; see the issues I highlighted inline. I assume you've done some testing on it? I compiled it on amd64 but otherwise I haven't tested it. Also, please send me and Alexander the proposed commit message.

Jul 10 2018, 7:39 PM

Jun 14 2018

ken committed rS335154: Fix da(4) locking when probing SMR drives..
Fix da(4) locking when probing SMR drives.
Jun 14 2018, 5:09 PM
ken closed D15764: Fix da(4) probe locking problems..
Jun 14 2018, 5:09 PM
ken accepted D15764: Fix da(4) probe locking problems..

No other comments after a few days...

Jun 14 2018, 5:04 PM

Jun 11 2018

ken added a comment to D15764: Fix da(4) probe locking problems..
In D15764#333114, @imp wrote:

try 'camcontrol rescan all'. That's the usual case that breaks locking :(

Jun 11 2018, 8:47 PM
ken created D15764: Fix da(4) probe locking problems..
Jun 11 2018, 7:55 PM

Jun 10 2018

ken added a reviewer for D15747: Fix build of ocs_fs with base gcc on i386: ram.vegesna_broadcom.com.
Jun 10 2018, 9:58 PM

Jun 1 2018

ken added a comment to D15592: Avoid completing non-dump I/O requests after a panic..
In D15592#330394, @imp wrote:

I like this a lot better. I can't think of any special case I/O we'd need to make an exception on. All the normal commands are what you'd want to block. The abnormal ones are things like FD_FORMAT which will screw things up, but completing the command won't screw them up worse, so that's good. The BIO_ZONE stuff is done via ioctls which won't screw up if we don't complete it. I'd like it if we could allow some clients complete and others be blocked, but that's somewhat beyond the scope.

Jun 1 2018, 3:22 AM
ken added a reviewer for D15592: Avoid completing non-dump I/O requests after a panic.: asomers.
Jun 1 2018, 3:20 AM

May 21 2018

ken committed rS333991: MFC r333492:.
MFC r333492:
May 21 2018, 6:59 PM

May 14 2018

ken accepted D15435: expand scope of da refcount to protect I/Os in flight.

Looks good. I'm glad this seems to have fixed the problem in the da(4) driver at least. I agree, ada(4) and nda(4) should probably have the same change since they'll have the same issue.

May 14 2018, 10:52 PM

May 11 2018

ken committed rS333492: Clear out the entire structure, not just the size of a pointer to it..
Clear out the entire structure, not just the size of a pointer to it.
May 11 2018, 2:50 PM

May 4 2018

ken committed rS331766: Bring in the Broadcom/Emulex Fibre Channel driver, ocs_fc(4)..
Bring in the Broadcom/Emulex Fibre Channel driver, ocs_fc(4).
May 4 2018, 11:44 PM
ken committed rS332040: MFC r331766, r331768:.
MFC r331766, r331768:
May 4 2018, 11:39 PM
ken closed D11423: Fiber channel driver for Broadcom/Emulex FC host bus adapters..
May 4 2018, 11:39 PM

Apr 24 2018

ken committed rS332933: MFC r332458:.
MFC r332458:
Apr 24 2018, 1:52 PM

Apr 23 2018

ken accepted D15166: Use calloc() instead of malloc+bzero.

Looks good, thanks!

Apr 23 2018, 12:26 PM

Apr 17 2018

ken accepted D14032: time(1): add an option to use the monotonic clock.

This looks good. I think jilles is right, implementing it with CLOCK_MONOTONIC by default may be better than making it optional. Most people won't look at the man page, and this gives it more of a "do what I mean" behavior.

Apr 17 2018, 3:41 PM
ken accepted D15076: Make `iostat -xC` print CPU information on its own line.

I agree, this looks like a better way to do it. It may break anyone who has scripts built to parse the output of iostat -xC, but I doubt there are many people doing that.

Apr 17 2018, 3:37 PM
ken committed rS332647: MFC r332458:.
MFC r332458:
Apr 17 2018, 3:34 PM

Apr 16 2018

ken accepted D15073: Invalidate reply descriptors earlier.

Looks good. Are you going to do the same thing in the mps(4) driver?

Apr 16 2018, 6:16 PM

Apr 12 2018

ken committed rS332458: Handle Programmable Early Warning for control commands in sa(4)..
Handle Programmable Early Warning for control commands in sa(4).
Apr 12 2018, 9:21 PM

Apr 10 2018

ken committed rS332360: Add Ram Kishore Vegesna (ram) as a src committer..
Add Ram Kishore Vegesna (ram) as a src committer.
Apr 10 2018, 1:17 PM

Mar 30 2018

ken accepted D11423: Fiber channel driver for Broadcom/Emulex FC host bus adapters..

Looks good. This passes make universe now. I'm working on getting it into the tree.

Mar 30 2018, 2:41 PM

Mar 27 2018

ken committed rS331646: MFC r331422:.
MFC r331422:
Mar 27 2018, 8:35 PM

Mar 23 2018

ken requested changes to D11423: Fiber channel driver for Broadcom/Emulex FC host bus adapters..

So found some problems when I did a 'make universe'. See the inline comments for more details.

Mar 23 2018, 6:56 PM
ken committed rS331422: Disable T10 Protection Information / EEDP handling for type 2 protection..
Disable T10 Protection Information / EEDP handling for type 2 protection.
Mar 23 2018, 1:52 PM

Mar 19 2018

ken committed rS331223: cam_periph_acquire() now returns an errno..
cam_periph_acquire() now returns an errno.
Mar 19 2018, 8:19 PM

Mar 12 2018

ken accepted D14654: Reject CAMIOGET and CAMIOQUEUE ioctl's on pass(4) 32-bit compat mode.

This is fine. It would be an unusual situation in any case to have a 32-bit binary attempting to use these ioctls, since they are relatively new (late 2015 when they went in the tree).

Mar 12 2018, 6:22 PM

Feb 8 2018

ken added a comment to D14261: Allocate sufficient number of chain frames in mps(4) and mpr(4)..

This is a good idea. I have been bumping this up on our builds at Spectra, and I currently have the maximum number of chain frames set to 32768.

Feb 8 2018, 4:29 PM

Feb 6 2018

ken committed rS328936: Diagnostic buffer fixes for the mps(4) and mpr(4) drivers..
Diagnostic buffer fixes for the mps(4) and mpr(4) drivers.
Feb 6 2018, 3:58 PM
ken closed D13453: mpr(4) and mps(4) diagnostic path fixes.
Feb 6 2018, 3:58 PM

Feb 1 2018

ken requested changes to D14063: Use C errno as return value for cam_periph_acquire().

The change in general is fine. It just needs fixing in the ctlferegister() case.

Feb 1 2018, 11:39 PM

Jan 25 2018

ken added a comment to D14040: Debugging for arrival / depature code..

This looks good and should catch duplicate releases or a release without an acquire. But obviously we need to figure out why Scott's machine is rebooting with it.

Jan 25 2018, 3:39 PM

Jan 24 2018

ken accepted D14030: time: use clock_gettime instead of gettimeofday.
Jan 24 2018, 4:54 PM

Dec 26 2017

ken added a comment to D13453: mpr(4) and mps(4) diagnostic path fixes.
In D13453#281205, @mav wrote:

Generally looks good to me. I suppose it may need some more bus_dmamap_sync() calls for completeness.

Dec 26 2017, 9:24 PM
ken updated the diff for D13453: mpr(4) and mps(4) diagnostic path fixes.

Added bus_dmamap_sync(..., BUS_DMASYNC_POSTREAD) before copying diagnostic buffers out to userland.

Dec 26 2017, 9:23 PM

Dec 12 2017

ken added a comment to D11423: Fiber channel driver for Broadcom/Emulex FC host bus adapters..

Hi Ken,
Please clarify,
"da44: 16000.000MB/s transfers"
should be
"da44: 16000.000Mb/s transfers" --> This seems correct to me but camcontrol utility always prints in MB/s transfers.
or
"da44: 1600.000MB/s transfers" --> Do you want me to report this speed?

Dec 12 2017, 3:00 PM

Dec 11 2017

ken added a comment to D11423: Fiber channel driver for Broadcom/Emulex FC host bus adapters..

One thing that needs to get fixed is cosmetic. The reported speeds are 10X what they should be.

Dec 11 2017, 8:44 PM
ken created D13453: mpr(4) and mps(4) diagnostic path fixes.
Dec 11 2017, 7:33 PM

Dec 7 2017

ken accepted D13406: Add myself to committers-src.dot.

Looks good!

Dec 7 2017, 7:28 PM

Dec 6 2017

ken accepted D13387: Define xpt_path_inq..

Looks good to me! Thanks for doing this!

Dec 6 2017, 9:43 PM
ken accepted D13198: Fix sign-extension error in adagetparams.

Looks good to me, thanks!

Dec 6 2017, 4:36 PM

Nov 22 2017

ken accepted D13194: Always null-terminate CAM periph_name and dev_name.

Looks good, assuming you put sizeof() in there.

Nov 22 2017, 6:33 PM
ken accepted D13185: Add a test case for cam_get_device with sa(4) devices.

Looks good, thanks!

Nov 22 2017, 6:29 PM

Nov 20 2017

ken accepted D13171: print ZBC device type in "camcontrol identify" output.

Looks good. At some point we should put Host Managed detection in. It doesn't work the same way as Device Managed and Host Aware. In SCSI it's a different device type (i.e. not Direct Access). There is an equivalent in ATA.

Nov 20 2017, 7:49 PM

Nov 18 2017

ken added a comment to D11423: Fiber channel driver for Broadcom/Emulex FC host bus adapters..

Another thing to note here is that the man page has replaced the entire set of diffs that included the code. Both need to be included in the diffs, and the man page hooked up to the build.

Nov 18 2017, 3:37 AM

Nov 9 2017

ken added a comment to D11423: Fiber channel driver for Broadcom/Emulex FC host bus adapters..

The new diffs fixed both issues: auto negotiation with tape drives and sending RECs for non-data commands. I got a trace to confirm that RECs are getting sent during a long-running SPACE command. It looks like the card sends a REC every 4 seconds, which should be fine. (QLogic seems to send them every 3 seconds. I don't think the spec mandates a specific time.)

Nov 9 2017, 3:47 PM

Nov 8 2017

ken added a comment to D11423: Fiber channel driver for Broadcom/Emulex FC host bus adapters..

I tried this out, and this breaks automatic tape drive recognition if I haven't set the topology to 2 (loop mode). If I set the topology to 2, it sees the tape drive without a problem.

Nov 8 2017, 9:02 PM

Nov 7 2017

ken committed rS325496: MFC r325371.
MFC r325371
Nov 7 2017, 3:58 PM
ken committed rS325495: MFC r325371.
MFC r325371
Nov 7 2017, 3:52 PM

Nov 3 2017

ken committed rS325371: Add the LTO-8 Type M density code (0x5d, LTO-8M) to libmt and the.
Add the LTO-8 Type M density code (0x5d, LTO-8M) to libmt and the
Nov 3 2017, 9:04 PM

Sep 28 2017

ken added inline comments to D12485: fuse.ko: Add extattrs support..
Sep 28 2017, 5:28 PM
ken added a comment to D12485: fuse.ko: Add extattrs support..
In D12485#259922, @pfg wrote:
In D12485#259905, @cem wrote:

Changes from v2 to v3 look mostly good!

In D12485#259853, @pfg wrote:

The problem I see with the sysctl is that we have too many of them; they are generally undocumented, and it's ultimately unlikely people will spend time on it. A default value ("fusefs" perhaps?) would be good to have.

I think the main problem is it configures globally a setting that is most useful per mount. But maybe I am overestimating the number of FUSE mounts people have.

I don't think currently the main consumer for ntfs driver and EAs currently don't translate very well between those. Ken's work was probably related to ceph, which like does use such attributes.

Sep 28 2017, 5:07 PM

Sep 13 2017

ken accepted D12357: New committer setup for chuck@.
Sep 13 2017, 5:08 PM

Sep 7 2017

ken accepted D12263: Remove spaces from CTL devices' default serial numbers.

Looks good to me, thanks!

Sep 7 2017, 8:23 PM

Aug 25 2017

ken accepted D12112: Overhaul debug printing for device initialization..

Looks good to me. What about a version of these changes for mpr(4) so we don't have too much divergence?

Aug 25 2017, 7:40 PM
ken accepted D12119: Fix 32-bit overflow on latency measurements.

Looks good to me.

Aug 25 2017, 7:33 PM

Aug 23 2017

ken added inline comments to D11361: Add CAM/NVMe support for CAM_DATA_SG.
Aug 23 2017, 7:29 PM
ken committed rS322819: Fix a resource leak in an error case in camdd_buf_sg_create()..
Fix a resource leak in an error case in camdd_buf_sg_create().
Aug 23 2017, 5:53 PM

Aug 22 2017

ken added inline comments to D11361: Add CAM/NVMe support for CAM_DATA_SG.
Aug 22 2017, 9:24 PM
ken added inline comments to D11361: Add CAM/NVMe support for CAM_DATA_SG.
Aug 22 2017, 9:17 PM
ken added a reviewer for D11361: Add CAM/NVMe support for CAM_DATA_SG: scottl.
Aug 22 2017, 9:12 PM
ken added inline comments to D11361: Add CAM/NVMe support for CAM_DATA_SG.
Aug 22 2017, 8:33 PM
ken added reviewers for D11361: Add CAM/NVMe support for CAM_DATA_SG: ken, imp.
Aug 22 2017, 5:19 PM
ken committed rS322790: MFC r322410:.
MFC r322410:
Aug 22 2017, 2:41 PM
ken committed rS322788: MFC r322410:.
MFC r322410:
Aug 22 2017, 2:00 PM
ken committed rS322785: Restructure camdd(8) slightly to make it easier to add support for.
Restructure camdd(8) slightly to make it easier to add support for
Aug 22 2017, 1:08 PM
ken closed D11230: Make camdd(8) protocol aware by committing rS322785: Restructure camdd(8) slightly to make it easier to add support for.
Aug 22 2017, 1:08 PM

Aug 18 2017

ken committed rS322661: MFC r321502, r321714, r321733, r321737, r321799, r322364:.
MFC r321502, r321714, r321733, r321737, r321799, r322364:
Aug 18 2017, 3:38 PM
ken committed rS322658: MFC r321502, r321714, r321733, r321737, r321799, r322364:.
MFC r321502, r321714, r321733, r321737, r321799, r322364:
Aug 18 2017, 2:25 PM

Aug 11 2017

ken committed rS322410: Add historical notes on QIC tape drives and fix a couple of issues in mt(1)..
Add historical notes on QIC tape drives and fix a couple of issues in mt(1).
Aug 11 2017, 6:44 PM

Aug 10 2017

ken committed rS322367: MFC r320991, r322016:.
MFC r320991, r322016:
Aug 10 2017, 3:35 PM