- User Since
- Jan 23 2015, 10:35 PM (221 w, 2 d)
Mar 11 2019
Mar 5 2019
I think it would actually be better to add the suggestion to put in ispfw_load whenever the user isn't on a 16Gb board and hasn't loaded firmware.
Mar 4 2019
Feb 19 2019
I tested this out with a Seagate 8TB host aware drive:
Jan 15 2019
Jan 14 2019
Looks good. I assume you've made sure this installs correctly. I put a couple of suggestions in the description file, although the comment about MAXPHYS might also go into something that the user will see when he installs the package.
Oct 12 2018
Oct 5 2018
Is the doc tree in freeze like the src tree? i.e. does he need permission from doceng?
No idea why @mat blocked it, but I'm sure he can explain.
Oct 1 2018
Jul 17 2018
Approved. Looks good, thank you!
Jul 10 2018
Overall it looks ok; see the issues I highlighted inline. I assume you've done some testing on it? I compiled it on amd64 but otherwise I haven't tested it. Also, please send me and Alexander the proposed commit message.
Jun 14 2018
No other comments after a few days...
Jun 11 2018
Jun 10 2018
Jun 1 2018
May 21 2018
May 14 2018
Looks good. I'm glad this seems to have fixed the problem in the da(4) driver at least. I agree, ada(4) and nda(4) should probably have the same change since they'll have the same issue.
May 11 2018
May 4 2018
Apr 24 2018
Apr 23 2018
Apr 17 2018
This looks good. I think jilles is right, implementing it with CLOCK_MONOTONIC by default may be better than making it optional. Most people won't look at the man page, and this gives it more of a "do what I mean" behavior.
I agree, this looks like a better way to do it. It may break anyone who has scripts built to parse the output of iostat -xC, but I doubt there are many people doing that.
Apr 16 2018
Looks good. Are you going to do the same thing in the mps(4) driver?
Apr 12 2018
Apr 10 2018
Mar 30 2018
Looks good. This passes make universe now. I'm working on getting it into the tree.
Mar 27 2018
Mar 23 2018
So found some problems when I did a 'make universe'. See the inline comments for more details.
Mar 19 2018
Mar 12 2018
This is fine. It would be an unusual situation in any case to have a 32-bit binary attempting to use these ioctls, since they are relatively new (late 2015 when they went in the tree).
Feb 8 2018
This is a good idea. I have been bumping this up on our builds at Spectra, and I currently have the maximum number of chain frames set to 32768.
Feb 6 2018
Feb 1 2018
The change in general is fine. It just needs fixing in the ctlferegister() case.
Jan 25 2018
This looks good and should catch duplicate releases or a release without an acquire. But obviously we need to figure out why Scott's machine is rebooting with it.
Jan 24 2018
Dec 26 2017
Added bus_dmamap_sync(..., BUS_DMASYNC_POSTREAD) before copying diagnostic buffers out to userland.
Dec 12 2017
Dec 11 2017
One thing that needs to get fixed is cosmetic. The reported speeds are 10X what they should be.
Dec 7 2017
Dec 6 2017
Looks good to me! Thanks for doing this!
Looks good to me, thanks!
Nov 22 2017
Looks good, assuming you put sizeof() in there.
Looks good, thanks!
Nov 20 2017
Looks good. At some point we should put Host Managed detection in. It doesn't work the same way as Device Managed and Host Aware. In SCSI it's a different device type (i.e. not Direct Access). There is an equivalent in ATA.
Nov 18 2017
Another thing to note here is that the man page has replaced the entire set of diffs that included the code. Both need to be included in the diffs, and the man page hooked up to the build.
Nov 9 2017
The new diffs fixed both issues: auto negotiation with tape drives and sending RECs for non-data commands. I got a trace to confirm that RECs are getting sent during a long-running SPACE command. It looks like the card sends a REC every 4 seconds, which should be fine. (QLogic seems to send them every 3 seconds. I don't think the spec mandates a specific time.)
Nov 8 2017
I tried this out, and this breaks automatic tape drive recognition if I haven't set the topology to 2 (loop mode). If I set the topology to 2, it sees the tape drive without a problem.
Nov 7 2017
Nov 3 2017
Sep 28 2017
Sep 13 2017
Sep 7 2017
Looks good to me, thanks!
Aug 25 2017
Looks good to me. What about a version of these changes for mpr(4) so we don't have too much divergence?
Looks good to me.