Page MenuHomeFreeBSD

ken (Ken Merry)
User

Projects

User Details

User Since
Jan 23 2015, 10:35 PM (410 w, 4 d)

Recent Activity

Thu, Dec 1

ken accepted D37589: Allow any user to read the NFS stats, for example with nfsstat(1)..

This looks good to me.

Thu, Dec 1, 9:35 PM

Oct 20 2022

ken committed rG2edc70060d1e: Fix mpr(4) panic during a firmware update. (authored by ken).
Fix mpr(4) panic during a firmware update.
Oct 20 2022, 3:03 PM
ken committed rG956f15e74d66: Fix mpr(4) panic during a firmware update. (authored by ken).
Fix mpr(4) panic during a firmware update.
Oct 20 2022, 3:00 PM

Oct 17 2022

ken committed rG11778fca4a83: Fix mpr(4) panic during a firmware update. (authored by ken).
Fix mpr(4) panic during a firmware update.
Oct 17 2022, 4:54 PM

Feb 25 2022

ken committed rG7c79905f67fd: Fix non-printable characters in NVMe model and serial numbers. (authored by ken).
Fix non-printable characters in NVMe model and serial numbers.
Feb 25 2022, 10:20 PM

Feb 18 2022

ken committed rG58df94091a3e: Fix non-printable characters in NVMe model and serial numbers. (authored by ken).
Fix non-printable characters in NVMe model and serial numbers.
Feb 18 2022, 9:34 PM
ken committed rGacbae1011ed2: Switch to using drive-supplied timeouts for the sa(4) driver. (authored by ken).
Switch to using drive-supplied timeouts for the sa(4) driver.
Feb 18 2022, 9:28 PM

Feb 10 2022

ken committed rG75900d1eb898: Switch to using drive-supplied timeouts for the sa(4) driver. (authored by ken).
Switch to using drive-supplied timeouts for the sa(4) driver.
Feb 10 2022, 1:42 PM

Feb 9 2022

ken committed rG3090d5045a1e: Fix non-printable characters in NVMe model and serial numbers. (authored by ken).
Fix non-printable characters in NVMe model and serial numbers.
Feb 9 2022, 10:13 PM
ken closed D33973: Fix non-printable characters in NVMe model and serial numbers..
Feb 9 2022, 10:13 PM

Jan 24 2022

ken updated the summary of D33973: Fix non-printable characters in NVMe model and serial numbers..
Jan 24 2022, 9:36 PM
ken updated the diff for D33973: Fix non-printable characters in NVMe model and serial numbers..

Create a cam_strvis_flag() function and use it in the NVMe code.

Jan 24 2022, 9:34 PM

Jan 20 2022

ken requested review of D33973: Fix non-printable characters in NVMe model and serial numbers..
Jan 20 2022, 8:18 PM
ken committed rG6d1a563281a9: Free UMA zones when a pass(4) instance goes away. (authored by ken).
Free UMA zones when a pass(4) instance goes away.
Jan 20 2022, 8:09 PM
ken committed rG2077f85a63f2: Free UMA zones when a pass(4) instance goes away. (authored by ken).
Free UMA zones when a pass(4) instance goes away.
Jan 20 2022, 8:07 PM

Jan 19 2022

ken added inline comments to D31809: Add tests for ses(4).
Jan 19 2022, 9:22 PM
ken accepted D31809: Add tests for ses(4).

I'm assuming this will need to run on a system with a SES device.

Jan 19 2022, 6:33 PM
ken accepted D31686: ses: minor cleanup.
Jan 19 2022, 6:29 PM

Jan 18 2022

ken committed rG6e8a2f040017: Update sa(4) comments and man page after review. (authored by ken).
Update sa(4) comments and man page after review.
Jan 18 2022, 6:59 PM
ken committed rGbcff64c54a74: Clarify loader tunable usage when tape drives arrive after boot. (authored by ken).
Clarify loader tunable usage when tape drives arrive after boot.
Jan 18 2022, 6:59 PM
ken closed D33883: Switch to using drive-supplied timeouts for the sa(4) driver..
Jan 18 2022, 6:58 PM
ken committed rG5719b5a1bb64: Switch to using drive-supplied timeouts for the sa(4) driver. (authored by ken).
Switch to using drive-supplied timeouts for the sa(4) driver.
Jan 18 2022, 6:58 PM
ken accepted D33925: mpr/mps: Remove write-only flag and callout.
Jan 18 2022, 4:09 PM
ken accepted D33925: mpr/mps: Remove write-only flag and callout.

Hmm, I guess that was removed somewhere along the way. I haven't seen discovery hangs lately, so this should be ok.

Jan 18 2022, 4:00 PM
ken updated the diff for D33883: Switch to using drive-supplied timeouts for the sa(4) driver..

Update sa(4) comments and man page after review.

Jan 18 2022, 3:50 PM

Jan 17 2022

ken added inline comments to D33883: Switch to using drive-supplied timeouts for the sa(4) driver..
Jan 17 2022, 5:53 PM

Jan 14 2022

ken added inline comments to D33883: Switch to using drive-supplied timeouts for the sa(4) driver..
Jan 14 2022, 9:52 PM
ken added inline comments to D33883: Switch to using drive-supplied timeouts for the sa(4) driver..
Jan 14 2022, 4:13 PM
ken updated the diff for D33883: Switch to using drive-supplied timeouts for the sa(4) driver..

Address documentation feedback, clarify that loader tunables will still be
used for tape drives that arrive after boot.

Jan 14 2022, 4:11 PM

Jan 13 2022

ken added inline comments to D33883: Switch to using drive-supplied timeouts for the sa(4) driver..
Jan 13 2022, 10:15 PM
ken requested review of D33883: Switch to using drive-supplied timeouts for the sa(4) driver..
Jan 13 2022, 9:17 PM
ken committed rGca2a7262df5e: Free UMA zones when a pass(4) instance goes away. (authored by ken).
Free UMA zones when a pass(4) instance goes away.
Jan 13 2022, 3:57 PM

Jan 7 2022

ken added a comment to D33783: cam: Include more statuses as errors for CAM_IO_STATS.
In D33783#764114, @imp wrote:
In D33783#764113, @rew wrote:

Does it make sense to include any of these additional errors for the CAM_IO_STATS in sys/cam/nvme/nvme_da.c and sys/cam/ata/ata_da.c?

nvme_da doesn't have these errors. ata_da already lists CAM_ATA_STATUS_ERROR. I needed to add it to SCSI because we do a lot with ATA passthrough commands that might result in this. I'm on the fence about adding CAM_SMP_STATUS_ERROR to ata_da.c, like I was in adding it here. It's more of a management thing and I've not audited all the commands both send to see if it's possible... CAM_SEL_TIMEOUT is generated by the ata SIMs, so maybe it should be on the list there (nvme_sim doesn't generate this).

Jan 7 2022, 7:23 PM
ken added a comment to D33783: cam: Include more statuses as errors for CAM_IO_STATS.

What's the difference between CAM_CMD_TIMEOUT and CAM_SEL_TIMEOUT ?

Jan 7 2022, 6:28 PM

Nov 3 2021

ken accepted D32803: scsi_cd: Improve TOC access validation.
Nov 3 2021, 6:46 PM

May 6 2021

ken added a comment to D29941: gmultipath: make physpath distinct from the underlying providers'.

Yep. That's wrong. In 14.0-CURRENT, the function that sets physpath is ses_set_physpath, in cam/scsi/scsi_enc_ses.c.

May 6 2021, 9:34 PM
ken added a comment to D29941: gmultipath: make physpath distinct from the underlying providers'.
In D29941#676901, @mav wrote:

Excuse me if I am wrong, I don't have any multipath environment now to make sure, but I remember that SES on different expanders of dual-port backplane report different IDs.

Hm. I thought that CAM used the Enclosure Logical Identifier to generate the physpath. It *should* do that. But now that I double-check; you're right. CAM is using the Addressed Logical Unit SAS ID instead. Maybe it was a Spectra-specific patch to use the ELI that never got upstreamed. @ken could you please check how SpectraBSD generates the physical path? You can use commands like

sudo diskinfo -p /dev/da0
sudo sg_ses -p1 /dev/ses0 | grep -i 'enclosure.*logical'
sudo sg_inq -p di /dev/ses0
May 6 2021, 9:04 PM

Mar 4 2021

ken added a comment to D29017: libcam: Define depop structures and introduce scsi_wrap.

One minor comment.

Mar 4 2021, 5:02 PM

Mar 2 2021

ken added a comment to D29017: libcam: Define depop structures and introduce scsi_wrap.

The CDBs and filling functions look good. We should figure out what our user interface idiom is going to be for the scsi_wrap_* functions. Do we assume we have stdout/stderr, or do we provide those strings for the user to print in a way that works for the calling application?

Mar 2 2021, 8:52 PM
ken added a comment to D29018: camcontrol: depop command.

A couple of small nits but overall this looks good.

Mar 2 2021, 8:45 PM

Dec 15 2020

ken committed rS368675: MFC r368525:.
MFC r368525:
Dec 15 2020, 8:02 PM
ken committed rS368674: MFC r368525:.
MFC r368525:
Dec 15 2020, 7:59 PM

Dec 13 2020

ken committed R9:e1f4cd6febc6: *** empty log message *** (authored by ken).
*** empty log message ***
Dec 13 2020, 8:02 PM
ken committed R9:a99230f7e176: Yeah, pass the pointy cap for my first commit. I added myself to (authored by ken).
Yeah, pass the pointy cap for my first commit. I added myself to
Dec 13 2020, 8:02 PM
ken committed R9:c3b0329b2362: Add Hans Huebner <hans@artcom.de> for his modifcations to the CAM changer (authored by ken).
Add Hans Huebner <hans@artcom.de> for his modifcations to the CAM changer
Dec 13 2020, 8:02 PM
ken committed R9:f3af8f2c5e40: Update the list of currently supported SCSI controllers to reflect reality. (authored by ken).
Update the list of currently supported SCSI controllers to reflect reality.
Dec 13 2020, 7:55 PM
ken committed R9:5d7e4ea3613d: Add my key. (authored by ken).
Add my key.
Dec 13 2020, 7:27 PM
ken committed R9:f516817614fa: Document __FreeBSD_version number 900026. (The addition of the (authored by ken).
Document __FreeBSD_version number 900026. (The addition of the
Dec 13 2020, 5:26 PM

Dec 10 2020

ken committed rS368525: Add the LTO-9 density code to libmt and the mt(1) man page..
Add the LTO-9 density code to libmt and the mt(1) man page.
Dec 10 2020, 9:06 PM

Jul 16 2020

ken committed rS363260: Hold the mutex when releasing a callout..
Hold the mutex when releasing a callout.
Jul 16 2020, 8:43 PM

Jun 26 2020

ken requested review of D25476: Fix use after free panic and state transitions in mps(4) and mpr(4).
Jun 26 2020, 8:53 PM · cam

Apr 21 2020

ken added a comment to D24489: Don't pass a user buffer pointer as the data pointer in a CCB..

The problem isn't the existence of bi-directional commands, it's that DIR_BOTH == 0, not an OR'ing of DIR_IN and DIR_OUT, as would be expected.

Apr 21 2020, 6:14 PM
ken added inline comments to D24489: Don't pass a user buffer pointer as the data pointer in a CCB..
Apr 21 2020, 6:06 PM

Mar 10 2020

ken accepted D24008: Various cleanups: remove unused / under-used stuff..

I think this is ok. Do we need to do anything for compatibility?

Mar 10 2020, 9:16 PM

Feb 28 2020

ken added a comment to D23852: scsi_scan_bus: ignore Initiator ID for SAS transport in.
In D23852#524939, @mav wrote:

I am OK with that, but I think it can be too easy to forget, same as wrong value is set without understanding now. I am thinking whether introduction of some special constant value for initiator_id equal to UINT_MAX or something could be more explicit?

Feb 28 2020, 3:50 PM
ken added a comment to D23852: scsi_scan_bus: ignore Initiator ID for SAS transport in.
In D23852#524775, @mav wrote:
In D23852#524734, @avg wrote:

I would expect that if an initiator can also be a target then its target ID -- which, if I understand correctly, you suggest to be treated as an initiator ID -- would be from a different namespace than IDs of its targets.

Why? Think about it as parallel SCSI or loop FC, where each port can be both initiator and target, and have ID from some namespace. That is how initiator_id originally appeared in CAM, as I understand. We actually had some parallel SCSI target support in base, it just died with the hardware.

That is, I think that for a SAS initiator it is impossible to see itself as a target (where a target ID is typically also some made up number derived from the actual SAS topology).

I would not call it impossible. It is just not very useful. For QLogic FC IIRC it partially even works, but I prefer it not to rather then try and fail.

Also, about your other point, it's not hard to fake an initiator ID in every SAS SIM and all of them (have to) do it already.
But I do not see a reason to keep doing that when it does not have any real use except for introducing occasional bugs.

As I have told it works reasonably for FC, it was reasonable for SPI, and I see no reason why it can not for other protocols, that would justify protocol specifics into the shared code.

@ken , you've been around the target code for longer time, what do you think?

Feb 28 2020, 3:20 PM

Dec 17 2019

ken committed rS355863: MFC r355299:.
MFC r355299:
Dec 17 2019, 8:30 PM
ken committed rS355862: MFC r355299:.
MFC r355299:
Dec 17 2019, 8:30 PM

Dec 2 2019

ken committed rS355299: Fix a hang introduced in r351599..
Fix a hang introduced in r351599.
Dec 2 2019, 7:57 PM

Nov 11 2019

ken accepted D22295: Fix panic message to indicate right action that was improper..

Good catch, thank you!

Nov 11 2019, 3:44 PM

May 31 2019

ken committed rS348483: MFC r348247:.
MFC r348247:
May 31 2019, 8:36 PM
ken committed rS348480: MFC r348247:.
MFC r348247:
May 31 2019, 8:15 PM

May 24 2019

ken committed rS348247: Fix FC-Tape bugs caused in part by r345008..
Fix FC-Tape bugs caused in part by r345008.
May 24 2019, 5:58 PM

May 18 2019

ken accepted D12141: Add NVMe support to camdd.
May 18 2019, 2:13 AM
ken accepted D19904: bhyve: Add Integrated Endpoint to PCIe Capability.
May 18 2019, 12:54 AM
ken accepted D20282: Fix nda(4) PCIe link status output.
In D20282#437333, @imp wrote:

This looks good. The multiple printfs give me heart-burn, but that's for another day. This part of the code they should be safe, but they aren't safe in a future where we do device discovery in parallel.

It would be easy to turn this into a series of snprintfs() and then a single printf(). Would that clear the heartburn?

May 18 2019, 12:43 AM

May 17 2019

ken committed rS347906: MFC r345008:.
MFC r345008:
May 17 2019, 2:30 PM

May 16 2019

ken committed rS347894: MFC r345008:.
MFC r345008:
May 16 2019, 10:03 PM
ken committed rS347885: MFC 344761:.
MFC 344761:
May 16 2019, 6:50 PM
ken committed rS347884: MFC 344761:.
MFC 344761:
May 16 2019, 6:42 PM

Mar 11 2019

ken accepted D19536: Add -l to camcontrol readcap..

Looks good to me.

Mar 11 2019, 2:24 PM
ken committed rS345008: Fix CRN resets in the isp(4) driver in certain situations..
Fix CRN resets in the isp(4) driver in certain situations.
Mar 11 2019, 2:21 PM
ken closed D19472: Fix isp(4) CRN handling in some situations..
Mar 11 2019, 2:21 PM

Mar 5 2019

ken added a comment to D19369: Make isp(4) suggest loading ispfw(4) when it fails to attach..

I think it would actually be better to add the suggestion to put in ispfw_load whenever the user isn't on a 16Gb board and hasn't loaded firmware.

Mar 5 2019, 9:53 PM
ken updated the summary of D19472: Fix isp(4) CRN handling in some situations..
Mar 5 2019, 9:50 PM
ken updated the summary of D19472: Fix isp(4) CRN handling in some situations..
Mar 5 2019, 9:49 PM
ken created D19472: Fix isp(4) CRN handling in some situations..
Mar 5 2019, 9:47 PM

Mar 4 2019

ken committed rS344761: Add IBM TS1160 density codes to libmt and the mt(1) man page..
Add IBM TS1160 density codes to libmt and the mt(1) man page.
Mar 4 2019, 2:30 PM

Feb 19 2019

ken accepted D19249: Limit the number of REPORT_ZONES entries allocated in the kernel..

I tested this out with a Seagate 8TB host aware drive:

Feb 19 2019, 8:00 PM
ken added a comment to D19249: Limit the number of REPORT_ZONES entries allocated in the kernel..

This change looks good. However, zonectl(8) currently hard-codes the entries_allocated field and doesn't check for a short return. If the kernel truncates the zone list, the user will have no obvious way of knowing. I think zonectl(8) should be modified to either loop until all zones have been reported, or at least tell the user that not all zones were reported.

Feb 19 2019, 7:37 PM

Jan 15 2019

ken added inline comments to D18841: New port: sysutils/ltfs: Reference implementation of LTFS for stand alone tape drive.
Jan 15 2019, 4:24 PM

Jan 14 2019

ken accepted D18841: New port: sysutils/ltfs: Reference implementation of LTFS for stand alone tape drive.

Looks good. I assume you've made sure this installs correctly. I put a couple of suggestions in the description file, although the comment about MAXPHYS might also go into something that the user will see when he installs the package.

Jan 14 2019, 8:06 PM

Oct 12 2018

ken committed rS339336: MFC r339076.
MFC r339076
Oct 12 2018, 7:44 PM

Oct 5 2018

ken added a comment to D16837: Document FreeBSD version 1200081.

Is the doc tree in freeze like the src tree? i.e. does he need permission from doceng?

Oct 5 2018, 2:28 PM
ken accepted D16837: Document FreeBSD version 1200081.

No idea why @mat blocked it, but I'm sure he can explain.

Oct 5 2018, 1:40 PM

Oct 1 2018

ken committed rS339076: Fix a da(4) driver memory leak for SCSI SMR devices..
Fix a da(4) driver memory leak for SCSI SMR devices.
Oct 1 2018, 7:01 PM

Jul 17 2018

ken accepted D16196: OCS_FC: Wait for a specific period of time prior to telling the OS about lost device..

Approved. Looks good, thank you!

Jul 17 2018, 2:10 PM

Jul 10 2018

ken added a comment to D16196: OCS_FC: Wait for a specific period of time prior to telling the OS about lost device..

Overall it looks ok; see the issues I highlighted inline. I assume you've done some testing on it? I compiled it on amd64 but otherwise I haven't tested it. Also, please send me and Alexander the proposed commit message.

Jul 10 2018, 7:39 PM

Jun 14 2018

ken committed rS335154: Fix da(4) locking when probing SMR drives..
Fix da(4) locking when probing SMR drives.
Jun 14 2018, 5:09 PM
ken closed D15764: Fix da(4) probe locking problems..
Jun 14 2018, 5:09 PM
ken accepted D15764: Fix da(4) probe locking problems..

No other comments after a few days...

Jun 14 2018, 5:04 PM

Jun 11 2018

ken added a comment to D15764: Fix da(4) probe locking problems..
In D15764#333114, @imp wrote:

try 'camcontrol rescan all'. That's the usual case that breaks locking :(

Jun 11 2018, 8:47 PM
ken created D15764: Fix da(4) probe locking problems..
Jun 11 2018, 7:55 PM

Jun 10 2018

ken added a reviewer for D15747: Fix build of ocs_fs with base gcc on i386: ram.
Jun 10 2018, 9:58 PM

Jun 1 2018

ken added a comment to D15592: Avoid completing non-dump I/O requests after a panic..
In D15592#330394, @imp wrote:

I like this a lot better. I can't think of any special case I/O we'd need to make an exception on. All the normal commands are what you'd want to block. The abnormal ones are things like FD_FORMAT which will screw things up, but completing the command won't screw them up worse, so that's good. The BIO_ZONE stuff is done via ioctls which won't screw up if we don't complete it. I'd like it if we could allow some clients complete and others be blocked, but that's somewhat beyond the scope.

Jun 1 2018, 3:22 AM
ken added a reviewer for D15592: Avoid completing non-dump I/O requests after a panic.: asomers.
Jun 1 2018, 3:20 AM

May 21 2018

ken committed rS333991: MFC r333492:.
MFC r333492:
May 21 2018, 6:59 PM

May 14 2018

ken accepted D15435: expand scope of da refcount to protect I/Os in flight.

Looks good. I'm glad this seems to have fixed the problem in the da(4) driver at least. I agree, ada(4) and nda(4) should probably have the same change since they'll have the same issue.

May 14 2018, 10:52 PM

May 11 2018

ken committed rS333492: Clear out the entire structure, not just the size of a pointer to it..
Clear out the entire structure, not just the size of a pointer to it.
May 11 2018, 2:50 PM

May 4 2018

ken committed rS331766: Bring in the Broadcom/Emulex Fibre Channel driver, ocs_fc(4)..
Bring in the Broadcom/Emulex Fibre Channel driver, ocs_fc(4).
May 4 2018, 11:44 PM