HomeFreeBSD

Fix the isp(4) driver with 9.x firmware.

Description

Fix the isp(4) driver with 9.x firmware.

The isp(4) driver (and ispfw(4) firmware) previously only included
firmware for Qlogic controllers up to 8Gb. It recently gained
firmware for the 27XX and 28XX series controllers along with
improved firmware loading capabilities.

The 9.x firmware available for the 27XX and 28XX controllers in
ispfw(4) adds login state for NVMe devices in the top nibble of
the login state in the port database (isp_pdb_24xx_t in ispmbox.h).

This breaks the check at the end of isp_getpdb() to make sure the
device is in the right login state. As a result, it breaks device
discovery for many (perhaps all?) FC devices. In my testing with
IBM LTO-6 drives attached to a quad port 16Gb Qlogic 2714, they
don't show up when they are directly connected (and in loop mode)
or connected via a switch (and in fabric mode).

So, mask off the top bits of of the login state before checking it.
This shouldn't break anything, because all of the existing login
states defined in ispmbox.h are in the low nibble.

sys/dev/isp/ispmbox.h:
Add a FCP login state mask define, and a NVMe login state
shift.

sys/dev/isp/isp.c:
In isp_getpdb(), make sure we're only looking at the FCP
login state bits when we try to determine whether a device
is in the right login state.

MFC after: 1 week
Sponsored by: Spectra Logic
Reviewed by: mav
Differential Revision: https://reviews.freebsd.org/D45660

(cherry picked from commit 137b004e2b7ab504abf98c4aad9d52607df47b9a)

Details

Provenance
kenAuthored on Jun 21 2024, 7:30 PM
Parents
rG4c0c82355692: isp(4): Document support for new devices
Branches
Unknown
Tags
Unknown