mpr/mps: Remove write-only flag and callout
ClosedPublic
Actions

Authored by imp on Jan 18 2022, 3:53 PM.

Details

Reviewers

slm
scottl
ken
mav

Commits

rG802f8d4afeaf: mpr/mps: Remove write-only flag and callout

Summary

The discovery callout is initialized and cancelled only, making it
write-only. Remove a state flag associated with it being pending as well
as two defines that aren't used that are associated with it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jan 18 2022, 3:53 PM

Herald added a reviewer: slm. · View Herald TranscriptJan 18 2022, 3:53 PM

imp requested review of this revision.Jan 18 2022, 3:53 PM

Harbormaster completed remote builds in B43962: Diff 101580.Jan 18 2022, 3:53 PM

imp added reviewers: scottl, ken, mav.Jan 18 2022, 3:54 PM

Hmm, I guess that was removed somewhere along the way. I haven't seen discovery hangs lately, so this should be ok.

This revision is now accepted and ready to land.Jan 18 2022, 4:00 PM

Remove MPSSAS_SHUTDOWN, unused since b01773b0f1b6 in 2013 (well, it was only set
there). It was used to shutdown a thread that was removed in that revision.

This revision now requires review to proceed.Jan 18 2022, 4:04 PM

Harbormaster completed remote builds in B43963: Diff 101581.Jan 18 2022, 4:04 PM

commit both parts before updating... remove MPRSAS_SHUTDOWN too.

Harbormaster completed remote builds in B43964: Diff 101582.Jan 18 2022, 4:07 PM

ken accepted this revision.Jan 18 2022, 4:09 PM

This revision is now accepted and ready to land.Jan 18 2022, 4:09 PM

I haven't found the moment when it was removed, but it was at least 8 years ago before mpr(4) driver addition. So I don't think I'll miss it. BTW MPRSAS_DISCOVERY_TIMEOUT and MPRSAS_MAX_DISCOVERY_TIMEOUTS defines are also unused.

scottl accepted this revision.Jan 20 2022, 10:24 AM

Closed by commit rG802f8d4afeaf: mpr/mps: Remove write-only flag and callout (authored by imp). · Explain WhyJan 24 2022, 8:21 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG802f8d4afeaf: mpr/mps: Remove write-only flag and callout.