Page MenuHomeFreeBSD

mpr/mps: Remove write-only flag and callout
ClosedPublic

Authored by imp on Jan 18 2022, 3:53 PM.

Details

Summary

The discovery callout is initialized and cancelled only, making it
write-only. Remove a state flag associated with it being pending as well
as two defines that aren't used that are associated with it.

Sponsored by: Netflix

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

imp requested review of this revision.Jan 18 2022, 3:53 PM

Hmm, I guess that was removed somewhere along the way. I haven't seen discovery hangs lately, so this should be ok.

This revision is now accepted and ready to land.Jan 18 2022, 4:00 PM

Remove MPSSAS_SHUTDOWN, unused since b01773b0f1b6 in 2013 (well, it was only set
there). It was used to shutdown a thread that was removed in that revision.

This revision now requires review to proceed.Jan 18 2022, 4:04 PM

commit both parts before updating... remove MPRSAS_SHUTDOWN too.

This revision is now accepted and ready to land.Jan 18 2022, 4:09 PM
mav accepted this revision.EditedJan 18 2022, 4:40 PM

I haven't found the moment when it was removed, but it was at least 8 years ago before mpr(4) driver addition. So I don't think I'll miss it. BTW MPRSAS_DISCOVERY_TIMEOUT and MPRSAS_MAX_DISCOVERY_TIMEOUTS defines are also unused.

This revision was automatically updated to reflect the committed changes.