scottl (Scott Long)
User

Projects

User Details

User Since
Jun 4 2014, 7:07 AM (203 w, 7 h)

Recent Activity

Sun, Apr 15

scottl created D15073: Invalidate reply descriptors earlier.
Sun, Apr 15, 2:34 PM

Mar 25 2018

scottl committed rS331528: Update a TBD string with a real model number.
Update a TBD string with a real model number
Mar 25 2018, 6:08 AM

Mar 12 2018

scottl committed rS330790: Add a new 'debug' command tree and 'dump_reqs' command to grab and parse.
Add a new 'debug' command tree and 'dump_reqs' command to grab and parse
Mar 12 2018, 5:03 AM
scottl committed rS330789: Implement a sysctl to dump in-flight I/O state for debugging. The tool to.
Implement a sysctl to dump in-flight I/O state for debugging. The tool to
Mar 12 2018, 5:02 AM

Feb 21 2018

scottl accepted D14369: Fix "cd0: Attempt".
Feb 21 2018, 7:00 AM

Feb 18 2018

scottl committed rS329522: Improve command lifecycle debugging and detection of problems..
Improve command lifecycle debugging and detection of problems.
Feb 18 2018, 4:41 PM

Feb 11 2018

scottl committed rS329137: Print out the shared memory queues during initialization.
Print out the shared memory queues during initialization
Feb 11 2018, 8:16 PM

Feb 8 2018

scottl requested changes to D14261: Allocate sufficient number of chain frames in mps(4) and mpr(4)..

Unfortunately, there are some big drawbacks to this approach. The larger you make the chain frame pool, the more pressure you put on the contigmalloc allocator. This is usually (though not always!) not a problem at boot, but would be a big problem with loading the driver as a module after boot. I agree with the desire to make the chain frame pool be self-tuning, but I think that to do it the right way, the pool must be allocated in multiple smaller segments of no more than 2MB each (i.e. 16384 frames). It should also handle potential allocation failures. Without this, I feel that your approach will be too fragile.

Feb 8 2018, 5:26 PM

Feb 6 2018

scottl committed rS328950: Cache the value of the request and reply frame size since it's used quite.
Cache the value of the request and reply frame size since it's used quite
Feb 6 2018, 9:01 PM
scottl committed rS328919: Fix a case where a request frame can be composed that requires 2 or more.
Fix a case where a request frame can be composed that requires 2 or more
Feb 6 2018, 6:56 AM
scottl added a comment to D14063: Use C errno as return value for cam_periph_acquire().
In D14063#298088, @mav wrote:

I neither have major objections aside of one inline, nor too happy. From one side I agree that there is no any/much sense to return cam_status from functions like that, which do not work with command statuses. From the other side it is a) an API change, which may lead to difficult to find errors, but b) there are many other functions suffering the same problem (but which may be more invasive to fix though).

Feb 6 2018, 6:30 AM
scottl added inline comments to D14063: Use C errno as return value for cam_periph_acquire().
Feb 6 2018, 6:28 AM

Feb 5 2018

scottl accepted D14215: LSI HBA drivers report incorrect queue depth to CAM.

Good find on this. I've seen queue-full conditions in the past but hadn't tracked down the causes; I think this is it.

Feb 5 2018, 10:45 PM
scottl added inline comments to D14063: Use C errno as return value for cam_periph_acquire().
Feb 5 2018, 9:56 PM

Feb 4 2018

scottl accepted D14042: Minimal changes for MPR to build on architectures with physical addresses larger than virtual.
Feb 4 2018, 3:07 PM

Jan 27 2018

scottl committed rS328464: Finish the incomplete move of CAM_PERIPH_PRINT()..
Finish the incomplete move of CAM_PERIPH_PRINT().
Jan 27 2018, 7:18 AM

Jan 26 2018

scottl committed rS328455: Move CAM_PERIPH_PRINT() to cam_periph.h.
Move CAM_PERIPH_PRINT() to cam_periph.h
Jan 26 2018, 11:56 PM
scottl created D14063: Use C errno as return value for cam_periph_acquire().
Jan 26 2018, 10:07 PM
scottl committed rS328445: Fix a cut-and-paste error in a panic message.
Fix a cut-and-paste error in a panic message
Jan 26 2018, 6:42 PM

Jan 25 2018

scottl accepted D14053: Use atomic load and stores to ensure that the compiler doesn't optimize away these loops..
Jan 25 2018, 10:37 PM
scottl added a comment to D14040: Debugging for arrival / depature code..

I think you forgot to add the implementation for CAM_PERIPH_PRINT(). Mine looks like this in cam_periph.h:

Jan 25 2018, 6:57 PM
scottl added a comment to D14040: Debugging for arrival / depature code..

Something in this patch is causing my system to spontaneously reboot late in the boot process. No panic, and the messages on the screen disappear too quickly (and are erased in the serial console by the BIOS splash screen).

Jan 25 2018, 3:13 PM
scottl added inline comments to D14040: Debugging for arrival / depature code..
Jan 25 2018, 3:12 PM
scottl requested changes to D14040: Debugging for arrival / depature code..
Jan 25 2018, 2:30 PM

Jan 23 2018

scottl accepted D13453: mpr(4) and mps(4) diagnostic path fixes.
Jan 23 2018, 4:54 PM

Jan 19 2018

scottl committed rS328170: Fix compile errors in r328165.
Fix compile errors in r328165
Jan 19 2018, 7:18 PM
scottl accepted D13672: Inline ccbque.h into scsi_low.h and delete from i386/isa..

Looks good to me. I'm OK with removing scsi_low and all related code for FreeBSD 12.

Jan 19 2018, 3:35 PM
scottl added a comment to D13868: Use XPT_GET_ADVINFO for retrieving MMC params.

I came across it during some other clean-up work.

Jan 19 2018, 3:33 PM
scottl committed rS328165: Revert ABI breakage to CAM that came in with MMC/SD support in r320844..
Revert ABI breakage to CAM that came in with MMC/SD support in r320844.
Jan 19 2018, 3:32 PM
scottl closed D13868: Use XPT_GET_ADVINFO for retrieving MMC params.
Jan 19 2018, 3:32 PM
scottl added a reviewer for D13868: Use XPT_GET_ADVINFO for retrieving MMC params: kibab.
Jan 19 2018, 7:05 AM

Jan 11 2018

scottl added inline comments to D13868: Use XPT_GET_ADVINFO for retrieving MMC params.
Jan 11 2018, 6:32 PM
scottl created D13868: Use XPT_GET_ADVINFO for retrieving MMC params.
Jan 11 2018, 6:07 PM

Jan 10 2018

scottl committed rS327762: Refactor code related to 'camcontrol devlist'.
Refactor code related to 'camcontrol devlist'
Jan 10 2018, 5:52 AM
scottl committed rS327761: Implement the ability to query NVME for its controller data so that it will.
Implement the ability to query NVME for its controller data so that it will
Jan 10 2018, 5:29 AM

Jan 9 2018

scottl committed rS327742: Release the held refcount on the probe periph when probing is.
Release the held refcount on the probe periph when probing is
Jan 9 2018, 9:24 PM
scottl committed rS327741: Hold a refcount on the periph while running the allocation.
Hold a refcount on the periph while running the allocation
Jan 9 2018, 9:23 PM
scottl committed rS327711: Don't hold the periph locks during dump..
Don't hold the periph locks during dump.
Jan 9 2018, 12:17 AM
scottl committed rS327710: Don't hold the periph lock when calling into cam_periph_runccb().
Don't hold the periph lock when calling into cam_periph_runccb()
Jan 9 2018, 12:11 AM
scottl committed rS327709: Protect against a possible NULL deference from an accessor.
Protect against a possible NULL deference from an accessor
Jan 9 2018, 12:01 AM

Dec 6 2017

scottl accepted D13387: Define xpt_path_inq..
Dec 6 2017, 9:44 PM

Nov 29 2017

scottl committed rS326377: It's time to retire AHC_REG_PRETTY_PRINT and AHD_REG_PRETTY_PRINT from.
It's time to retire AHC_REG_PRETTY_PRINT and AHD_REG_PRETTY_PRINT from
Nov 29 2017, 11:42 PM

Nov 20 2017

scottl committed rS326029: Update a comment in brelse() to match reality..
Update a comment in brelse() to match reality.
Nov 20 2017, 8:53 PM

Nov 17 2017

scottl committed rS325934: Rename P_OSREL_CK_CLYGRP to P_OSREL_CK_CYLGRP.
Rename P_OSREL_CK_CLYGRP to P_OSREL_CK_CYLGRP
Nov 17 2017, 1:12 PM

Nov 15 2017

scottl created D13098: Make interrupt driven config hooks configurable and predictable..
Nov 15 2017, 12:03 AM

Nov 13 2017

scottl accepted D13042: Add two new tunables / sysctls to controll reboot after panic.
Nov 13 2017, 5:21 PM

Nov 10 2017

scottl committed rS325667: Refactoring the interrupt setup code introduced a bug where the drivers.
Refactoring the interrupt setup code introduced a bug where the drivers
Nov 10 2017, 5:02 PM

Oct 26 2017

scottl accepted D12799: Always send STANDBY IMMEDIATE when shutting down.
Oct 26 2017, 6:52 PM

Oct 24 2017

scottl accepted D12777: Implenent power cycle option to reboot.
Oct 24 2017, 5:49 PM

Oct 1 2017

scottl committed rS324162: Improve the debug parsing to allow flags to be added and subtracted.
Improve the debug parsing to allow flags to be added and subtracted
Oct 1 2017, 3:35 PM

Sep 29 2017

scottl committed rS324097: Convert sysctl sbuf usage to use a fully dynaic sbuf. This is strictly.
Convert sysctl sbuf usage to use a fully dynaic sbuf. This is strictly
Sep 29 2017, 4:52 AM

Sep 24 2017

scottl committed rS323969: Add the ability to report and set debug flags as text strings instead of.
Add the ability to report and set debug flags as text strings instead of
Sep 24 2017, 1:15 PM

Sep 23 2017

scottl committed rS323946: Garbage collect usued fields.
Garbage collect usued fields
Sep 23 2017, 8:26 AM

Sep 22 2017

scottl committed rS323922: Clean up error messages related to device discovery.
Clean up error messages related to device discovery
Sep 22 2017, 12:07 PM

Sep 18 2017

scottl committed rS323712: Hide a normal probe warning message under bootverbose, similar to atkbdc.
Hide a normal probe warning message under bootverbose, similar to atkbdc
Sep 18 2017, 6:42 PM

Sep 15 2017

scottl committed rS323629: Fix line wrap issues..
Fix line wrap issues.
Sep 15 2017, 8:59 PM
scottl committed rS323614: Add support for parsing the Watchdog Descriptor Table (WDDT).
Add support for parsing the Watchdog Descriptor Table (WDDT)
Sep 15 2017, 3:41 PM

Sep 11 2017

scottl committed rS323412: Add infrastructure for allocating multiple MSI-X interrupts. Also.
Add infrastructure for allocating multiple MSI-X interrupts. Also
Sep 11 2017, 1:51 AM

Sep 10 2017

scottl committed rS323384: Fix intrhook release in MPR and MPS for EARLY_AP_STARTUP..
Fix intrhook release in MPR and MPS for EARLY_AP_STARTUP.
Sep 10 2017, 7:10 AM
scottl committed rS323383: More code refactoring in preparation for enabling multiqueue..
More code refactoring in preparation for enabling multiqueue.
Sep 10 2017, 4:09 AM

Sep 9 2017

scottl committed rS323380: Convert some in-line printing of diagnostic into tables..
Convert some in-line printing of diagnostic into tables.
Sep 9 2017, 10:02 PM
scottl committed rS323370: Remove the unnecessary use of a temporary string buffer..
Remove the unnecessary use of a temporary string buffer.
Sep 9 2017, 6:40 PM
scottl committed rS323369: Start separating the LSI drivers into per-queue structures. No.
Start separating the LSI drivers into per-queue structures. No
Sep 9 2017, 6:03 PM

Sep 8 2017

scottl committed rS323330: Refactor interrupt allocation and deallocation. Add some extra.
Refactor interrupt allocation and deallocation. Add some extra
Sep 8 2017, 8:20 PM
scottl committed rS323320: Fix intrhook release in MFI as well.
Fix intrhook release in MFI as well
Sep 8 2017, 5:51 PM
scottl committed rS323319: As with r323317, hold off on releasing the intrhook during boot until.
As with r323317, hold off on releasing the intrhook during boot until
Sep 8 2017, 5:40 PM
scottl committed rS323317: Move the intrhook release to later in the function so that GEOM knows to wait….
Move the intrhook release to later in the function so that GEOM knows to wait…
Sep 8 2017, 4:53 PM

Sep 6 2017

scottl committed rS323215: Checkpoint the next phase in debug message cleanup, this time focusing on.
Checkpoint the next phase in debug message cleanup, this time focusing on
Sep 6 2017, 9:20 AM

Aug 29 2017

scottl accepted D11361: Add CAM/NVMe support for CAM_DATA_SG.
Aug 29 2017, 6:40 AM

Aug 27 2017

scottl closed D12112: Overhaul debug printing for device initialization..

Resolved in r322943

Aug 27 2017, 6:25 AM
scottl committed rS322943: Start overhauling debug printing in the MPS and MPR drivers. The focus of this.
Start overhauling debug printing in the MPS and MPR drivers. The focus of this
Aug 27 2017, 6:24 AM

Aug 24 2017

scottl accepted D12119: Fix 32-bit overflow on latency measurements.
Aug 24 2017, 9:48 PM
scottl accepted D12112: Overhaul debug printing for device initialization..
Aug 24 2017, 9:43 PM

Aug 23 2017

scottl created D12112: Overhaul debug printing for device initialization..
Aug 23 2017, 9:15 PM

Aug 22 2017

scottl added inline comments to D11361: Add CAM/NVMe support for CAM_DATA_SG.
Aug 22 2017, 10:01 PM
scottl added inline comments to D11361: Add CAM/NVMe support for CAM_DATA_SG.
Aug 22 2017, 9:59 PM

Jul 31 2017

scottl committed rS321799: Fix a logic bug in the split PCI interrupt code that slipped through.
Fix a logic bug in the split PCI interrupt code that slipped through
Jul 31 2017, 4:56 PM
scottl committed rS321797: Add an entry to the freebsd calendar for myself..
Add an entry to the freebsd calendar for myself.
Jul 31 2017, 3:51 PM
scottl committed rS321737: Don't re-parse PCI IDs in order to set card-specific flags, use.
Don't re-parse PCI IDs in order to set card-specific flags, use
Jul 31 2017, 12:05 AM

Jul 30 2017

scottl committed rS321733: Change from using underbar function names to normal function names for.
Change from using underbar function names to normal function names for
Jul 30 2017, 10:34 PM
scottl committed rS321714: Split the interrupt setup code into two parts: allocation and configuration..
Split the interrupt setup code into two parts: allocation and configuration.
Jul 30 2017, 6:54 AM
scottl closed D9243: Refactor MPR/MPS interrupt setup code. by committing rS321714: Split the interrupt setup code into two parts: allocation and configuration..
Jul 30 2017, 6:54 AM

Jul 27 2017

scottl committed rS321604: Fix some broken logic used in obtaining the certain config pages. I'm.
Fix some broken logic used in obtaining the certain config pages. I'm
Jul 27 2017, 5:32 AM

Jul 26 2017

scottl committed rS321502: Quiet a message that sounds far more dire than it really is..
Quiet a message that sounds far more dire than it really is.
Jul 26 2017, 1:48 AM

May 16 2017

scottl accepted D10095: Add tri-mode support to mpr.
May 16 2017, 9:23 PM

May 11 2017

scottl accepted D10645: Avoid use of contiguous memory allocations in busdma.
May 11 2017, 4:21 PM
scottl committed rS318188: Improve error messages during command timeout for the mpr and mps.
Improve error messages during command timeout for the mpr and mps
May 11 2017, 3:19 PM

May 5 2017

scottl committed rS317838: Show more fields in the IOCFact message.
Show more fields in the IOCFact message
May 5 2017, 5:02 PM

May 3 2017

scottl committed rS317726: Fix an unsafe malloc usage with sbufs..
Fix an unsafe malloc usage with sbufs.
May 3 2017, 5:33 AM

Apr 20 2017

scottl created D10445: Speed up NVME crashdumps.
Apr 20 2017, 11:12 PM
scottl committed rS317213: Reorder the minimum_cmd_size code to make it a little smaller and.
Reorder the minimum_cmd_size code to make it a little smaller and
Apr 20 2017, 8:46 PM

Apr 19 2017

scottl committed rS317143: Add infrastructure to the ATA and SCSI transports that supports.
Add infrastructure to the ATA and SCSI transports that supports
Apr 19 2017, 3:05 PM

Apr 18 2017

scottl updated the diff for D10417: Use sbufs for CAM device announcements.

Rewrote the xpt_announce_periph and xpt_denounce_periph functions, the
previous work tried too hard and failed at code sharing. Also add in
seatbelts for transports that don't support sbufs yet, and add a tunable
knob to force the non-use of sbufs

Apr 18 2017, 10:42 PM
scottl added inline comments to D10417: Use sbufs for CAM device announcements.
Apr 18 2017, 1:43 PM
scottl added a comment to D5704: Add a wrapper API for static DMA allocations to bus_dma(9)..

Pending our discussion on IRC, would you mind if I took over this review and extended it?

Apr 18 2017, 4:31 AM
scottl created D10417: Use sbufs for CAM device announcements.
Apr 18 2017, 3:31 AM

Mar 22 2017

scottl added inline comments to D10095: Add tri-mode support to mpr.
Mar 22 2017, 9:18 PM
scottl added inline comments to D10095: Add tri-mode support to mpr.
Mar 22 2017, 9:13 PM

Mar 13 2017

scottl committed rS315195: Report disk flags via the sysctl tree.
Report disk flags via the sysctl tree
Mar 13 2017, 11:09 AM
scottl committed rS315190: Add constants and descriptions for some new PCI class definitions.
Add constants and descriptions for some new PCI class definitions
Mar 13 2017, 7:45 AM