User Details
- User Since
- Jun 4 2014, 7:07 AM (203 w, 7 h)
Sun, Apr 15
Mar 25 2018
Mar 12 2018
Feb 21 2018
Feb 18 2018
Feb 11 2018
Feb 8 2018
Unfortunately, there are some big drawbacks to this approach. The larger you make the chain frame pool, the more pressure you put on the contigmalloc allocator. This is usually (though not always!) not a problem at boot, but would be a big problem with loading the driver as a module after boot. I agree with the desire to make the chain frame pool be self-tuning, but I think that to do it the right way, the pool must be allocated in multiple smaller segments of no more than 2MB each (i.e. 16384 frames). It should also handle potential allocation failures. Without this, I feel that your approach will be too fragile.
Feb 6 2018
Feb 5 2018
Good find on this. I've seen queue-full conditions in the past but hadn't tracked down the causes; I think this is it.
Feb 4 2018
Jan 27 2018
Jan 26 2018
Jan 25 2018
I think you forgot to add the implementation for CAM_PERIPH_PRINT(). Mine looks like this in cam_periph.h:
Something in this patch is causing my system to spontaneously reboot late in the boot process. No panic, and the messages on the screen disappear too quickly (and are erased in the serial console by the BIOS splash screen).
Jan 23 2018
Jan 19 2018
Looks good to me. I'm OK with removing scsi_low and all related code for FreeBSD 12.
I came across it during some other clean-up work.
Jan 11 2018
Jan 10 2018
Jan 9 2018
Dec 6 2017
Nov 29 2017
Nov 20 2017
Nov 17 2017
Nov 15 2017
Nov 13 2017
Nov 10 2017
Oct 26 2017
Oct 24 2017
Oct 1 2017
Sep 29 2017
Sep 24 2017
Sep 23 2017
Sep 22 2017
Sep 18 2017
Sep 15 2017
Sep 11 2017
Sep 10 2017
Sep 9 2017
Sep 8 2017
Sep 6 2017
Aug 29 2017
Aug 27 2017
Resolved in r322943
Aug 24 2017
Aug 23 2017
Aug 22 2017
Jul 31 2017
Jul 30 2017
Jul 27 2017
Jul 26 2017
May 16 2017
May 11 2017
May 5 2017
May 3 2017
Apr 20 2017
Apr 19 2017
Apr 18 2017
Rewrote the xpt_announce_periph and xpt_denounce_periph functions, the
previous work tried too hard and failed at code sharing. Also add in
seatbelts for transports that don't support sbufs yet, and add a tunable
knob to force the non-use of sbufs
Pending our discussion on IRC, would you mind if I took over this review and extended it?