Page MenuHomeFreeBSD

scottl (Scott Long)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 4 2014, 7:07 AM (528 w, 2 d)

Recent Activity

Apr 21 2023

scottl accepted D38739: mprutil: "fix user reply buffer (64)..." warnings.
Apr 21 2023, 6:26 PM

Feb 24 2023

scottl added a comment to D38739: mprutil: "fix user reply buffer (64)..." warnings.

The MsgLength field is in terms of DWORDs, i.e. 32bit words. A value of 16 means 64 bytes.

Feb 24 2023, 5:58 PM
scottl added a comment to D38739: mprutil: "fix user reply buffer (64)..." warnings.
typedef struct _MPI2_IOC_FACTS_REPLY
{
    U16                     MsgVersion;                     /* 0x00 */
    U8                      MsgLength;                      /* 0x02 */
    U8                      Function;                       /* 0x03 */
Feb 24 2023, 5:47 PM
scottl added a comment to D38739: mprutil: "fix user reply buffer (64)..." warnings.

Ok, if the 2.5 msgver attribute is requiring 64bytes in some cases but 68bytes in other cases, that sucks, and it's a blatant violation of the 2.5 spec. Really, the motivation here was that any time a new msgver came out, investigation and review would be required to verify the sizes of the messages, instead of just blindly assuming sizes, but I forgot to put an assert into the CLI for that. I think that this would also impact the driver. I wonder if it’s possible to ask for just the first DWORD of the message and see what the firmware returns back as the residual, then ask for the rest based on that return value.

Feb 24 2023, 5:31 PM
scottl requested changes to D38739: mprutil: "fix user reply buffer (64)..." warnings.

Please don't commit this. The whole point of the sysctl is to find out if you need to adjust the size of the buffer, and to provide an easy way to update the code as new versions of the MPI spec came out over time. At the time this code was written, 2.6 was the highest version of the spec, so that's all that was implemented here. But what if 2.7 came out and required +8? Or -4? Or some other variant? The intention was to leave open the door for other adjustments that might be required for versions later than 2.6, and my error was not providing a comment in the code, though this was hinted at in the commit message history. So the real problem is likely that the msgver is something numerically higher than 2.6, and the code needs to be updated to account for it. Please don't nerf it like you're trying to do in this patch.

Feb 24 2023, 10:00 AM

Mar 25 2022

scottl removed a member for committers: scottl.
Mar 25 2022, 10:10 PM
scottl removed a member for Core Team: scottl.
Mar 25 2022, 10:10 PM
scottl removed a member for pfsense: scottl.
Mar 25 2022, 10:08 PM
scottl removed a member for cam: scottl.
Mar 25 2022, 10:08 PM

Mar 1 2022

scottl accepted D34401: ath: Suppress set but unused warnings.
Mar 1 2022, 12:56 AM

Feb 27 2022

scottl committed rG6f3c0d2764f2: Default to always accepting the PHY that's present. Linux did (authored by scottl).
Default to always accepting the PHY that's present. Linux did
Feb 27 2022, 1:31 AM

Feb 26 2022

scottl committed rG66b86c8a7604: Fix "set but not used" in the mrsas driver. Remove dead code. (authored by scottl).
Fix "set but not used" in the mrsas driver. Remove dead code.
Feb 26 2022, 7:22 PM
scottl committed rGc61dc8542865: Fix "set but not used" in the mvs driver. Remove dead code. (authored by scottl).
Fix "set but not used" in the mvs driver. Remove dead code.
Feb 26 2022, 7:19 PM
scottl committed rG0fd7b4c74d7d: Fix "set but not used" in the bfe driver. Remove dead code. (authored by scottl).
Fix "set but not used" in the bfe driver. Remove dead code.
Feb 26 2022, 7:15 PM
scottl committed rG887ae1953f07: Fix "set but not used" in the siis driver. (authored by scottl).
Fix "set but not used" in the siis driver.
Feb 26 2022, 6:47 PM
scottl committed rG4b22ce073062: The TWE driver should have been marked with gone_in for FreeBSD 13.x, (authored by scottl).
The TWE driver should have been marked with gone_in for FreeBSD 13.x,
Feb 26 2022, 6:44 PM
scottl committed rGb6ac753a881b: Fix "set but not used" in twe. (authored by scottl).
Fix "set but not used" in twe.
Feb 26 2022, 6:17 PM
scottl committed rGfa911920b1f0: Fix "set but not used" for real in the ciss driver. (authored by scottl).
Fix "set but not used" for real in the ciss driver.
Feb 26 2022, 6:08 PM
scottl committed rG55339af296ca: Expand __diagused to include the KTR kernel diagnostic option. (authored by scottl).
Expand __diagused to include the KTR kernel diagnostic option.
Feb 26 2022, 6:03 PM
scottl committed rGdec703c7e03a: Fix "set but not used" in the ips driver. Dead code. (authored by scottl).
Fix "set but not used" in the ips driver. Dead code.
Feb 26 2022, 5:36 PM
scottl committed rGf94066c8aa35: Fix "set but not used" in aic7xxx/aic79xx. The variables were dead (authored by scottl).
Fix "set but not used" in aic7xxx/aic79xx. The variables were dead
Feb 26 2022, 5:34 PM
scottl committed rGe28289ca8367: Fix "set but not used" in smartpqi. The PCI_MEM macros don't require a (authored by scottl).
Fix "set but not used" in smartpqi. The PCI_MEM macros don't require a
Feb 26 2022, 5:28 PM

Jan 25 2022

scottl accepted D34016: mps: Use 64-bit chain structures.
Jan 25 2022, 6:43 PM
scottl accepted D33973: Fix non-printable characters in NVMe model and serial numbers..
Jan 25 2022, 6:40 PM
scottl accepted D34017: mpr/mps: Fix a race in diagnostic reset.
Jan 25 2022, 6:37 PM

Jan 20 2022

scottl accepted D33925: mpr/mps: Remove write-only flag and callout.
Jan 20 2022, 10:24 AM

Jan 7 2022

scottl committed rG638e2a132e38: Fix formatting of the usage() output (authored by scottl).
Fix formatting of the usage() output
Jan 7 2022, 6:00 AM

Dec 5 2021

scottl committed rG95d35d7a0ec5: Fix "set but not used" in kern_cpu.c (authored by scottl).
Fix "set but not used" in kern_cpu.c
Dec 5 2021, 10:34 PM
scottl committed rG4d54d1b7fd06: Fix "set but not used" in opencrypto, with a correction for the previous (authored by scottl).
Fix "set but not used" in opencrypto, with a correction for the previous
Dec 5 2021, 10:32 PM
scottl committed rG5a052b6114ea: Fix "set but not used" in opencrypto (authored by scottl).
Fix "set but not used" in opencrypto
Dec 5 2021, 10:27 PM
scottl committed rG14c912c60dbd: FIx "set but not used" in the isp driver. (authored by scottl).
FIx "set but not used" in the isp driver.
Dec 5 2021, 10:20 PM
scottl committed rGcc557faf869a: Fix "set but not used" in cardbus (authored by scottl).
Fix "set but not used" in cardbus
Dec 5 2021, 10:15 PM
scottl committed rGc0ea0b498991: Fix "set but not used" in the x86 pci driver. (authored by scottl).
Fix "set but not used" in the x86 pci driver.
Dec 5 2021, 10:11 PM

Dec 4 2021

scottl committed rGf25d575762c7: Fix "set but not used" for hptmv (authored by scottl).
Fix "set but not used" for hptmv
Dec 4 2021, 6:08 PM
scottl committed rGdcf47452712d: Fix "set but not used" for hptiop (authored by scottl).
Fix "set but not used" for hptiop
Dec 4 2021, 6:07 PM
scottl committed rG98470f0e0bc7: Fix "set but not used" in mrsas. This includes removing unnecessary cdevsw (authored by scottl).
Fix "set but not used" in mrsas. This includes removing unnecessary cdevsw
Dec 4 2021, 7:09 AM
scottl committed rG2d5d242406e5: Fix "set but not used" for geom (authored by scottl).
Fix "set but not used" for geom
Dec 4 2021, 6:41 AM
scottl committed rG1c64538f584c: Fix "set but not used" for bge (authored by scottl).
Fix "set but not used" for bge
Dec 4 2021, 6:31 AM

Dec 3 2021

scottl committed rGa21f086a3316: Fix "set but not used" in the tws driver (authored by scottl).
Fix "set but not used" in the tws driver
Dec 3 2021, 10:41 PM
scottl committed rG74765431b7e9: Fix "set but not used" for the ti driver (authored by scottl).
Fix "set but not used" for the ti driver
Dec 3 2021, 10:32 PM
scottl committed rGbca8e8c00c4e: Fix "set but not used" in arcmsr (authored by scottl).
Fix "set but not used" in arcmsr
Dec 3 2021, 10:28 PM
scottl committed rGd85a58cb0c1b: Fix "set but not used" in busdma_bounce. (authored by scottl).
Fix "set but not used" in busdma_bounce.
Dec 3 2021, 10:22 PM
scottl committed rG5045cb8f18f9: Fix "set but not used" for the sym driver. (authored by scottl).
Fix "set but not used" for the sym driver.
Dec 3 2021, 10:19 PM

Nov 25 2021

scottl accepted D33113: amr: remove.
Nov 25 2021, 4:49 AM
scottl accepted D33111: mly: Remove..
Nov 25 2021, 4:47 AM
scottl accepted D33112: iir: Remove.
Nov 25 2021, 4:44 AM
scottl accepted D33114: twa: Remove.
Nov 25 2021, 4:43 AM
scottl accepted D33115: esp: Remove.
Nov 25 2021, 4:40 AM
scottl committed rG79ed7cb3df27: Fix "set but not used" warnings in the ciss driver. (authored by scottl).
Fix "set but not used" warnings in the ciss driver.
Nov 25 2021, 3:35 AM
scottl committed rG61f17c5fd6cf: Fix "set but not used" warnings in the mpr driver. This fixes a minor (authored by scottl).
Fix "set but not used" warnings in the mpr driver. This fixes a minor
Nov 25 2021, 3:30 AM
scottl committed rGbcce9c5bedfa: Fix "set but not used" warnings in the mps driver. (authored by scottl).
Fix "set but not used" warnings in the mps driver.
Nov 25 2021, 3:24 AM
scottl committed rGc154feacc4f2: Fix "set but not used" warnings in CAM. (authored by scottl).
Fix "set but not used" warnings in CAM.
Nov 25 2021, 3:21 AM
scottl committed rG6ef1ad0dcfe8: Fix "set but not used" warnings in mfi. The one in mfi.c:mfi_data_cb() (authored by scottl).
Fix "set but not used" warnings in mfi. The one in mfi.c:mfi_data_cb()
Nov 25 2021, 2:43 AM

Nov 4 2021

scottl accepted D32823: cam_periph: wired is really a bool, update it to a bool..
Nov 4 2021, 2:24 PM

Nov 3 2021

scottl added inline comments to D32823: cam_periph: wired is really a bool, update it to a bool..
Nov 3 2021, 6:08 PM

Oct 19 2021

scottl accepted D32567: ada: Fix intra-object buffer overread of identify strings.

A minor follow-up to this would be to use macros for the serial and model field lengths, and update ata.h to use the same, so that there's no reliance on sizeof.

Oct 19 2021, 11:06 PM

Oct 13 2021

scottl added a comment to D31613: mvneta: no longer panic on boot when mii cannot attach.

I know it's been almost 2 months, sorry for the delay. Luiz is about to go on vacation for a few days, hopefully he'll review this once he gets back

Oct 13 2021, 10:22 PM

Sep 30 2021

scottl added inline comments to D30799: aacraid: log DMA failures.
Sep 30 2021, 5:35 PM

Sep 2 2021

scottl accepted D31752: pf: ensure states passed to pf_free_state() are always unlinked.
Sep 2 2021, 5:33 PM
scottl accepted D31784: vmem: disable debug.vmem_check by default.
Sep 2 2021, 5:31 PM

Aug 17 2021

scottl committed rG045001075ed1: - Fix the growfs rc script to cope with diskid labels. (authored by scottl).
- Fix the growfs rc script to cope with diskid labels.
Aug 17 2021, 9:55 PM
scottl closed D31587: Improvements to growfs rc script.
Aug 17 2021, 9:54 PM
scottl added a comment to D31587: Improvements to growfs rc script.

I'm not sure what you're asking for at first that's not included in the summary

Aug 17 2021, 8:03 PM
scottl accepted D31582: ipfw: use unsigned int for dummynet bandwidth.
Aug 17 2021, 6:32 PM
scottl requested review of D31590: Increase partition limit size for boot code.
Aug 17 2021, 6:29 PM
scottl accepted D31586: lagg: don't update link layer addresses on destroy.
Aug 17 2021, 6:10 PM
scottl added a reviewer for D31587: Improvements to growfs rc script: imp.
Aug 17 2021, 5:04 PM
scottl requested review of D31587: Improvements to growfs rc script.
Aug 17 2021, 4:51 PM

Aug 10 2021

scottl committed rGbd9e461cf7f7: Address the reported mmc serialization issue. (authored by scottl).
Address the reported mmc serialization issue.
Aug 10 2021, 10:47 PM
scottl committed rG35547df5c786: Call wakeup() with the lock held to avoid missed wakeup races. (authored by scottl).
Call wakeup() with the lock held to avoid missed wakeup races.
Aug 10 2021, 10:42 PM

Aug 9 2021

scottl committed rG27b8dd594d58: Remove duplicate entry for arm/mv/armada38x/armada38x_rtc.c (authored by scottl).
Remove duplicate entry for arm/mv/armada38x/armada38x_rtc.c
Aug 9 2021, 7:04 PM

Aug 1 2021

scottl accepted D31374: udp: Fix soroverflow SOCKBUF unlocking.
Aug 1 2021, 3:05 PM

Jul 23 2021

scottl requested changes to D30799: aacraid: log DMA failures.

I've put rate limiters into other drivers and have been unhappy with the results. Whether it's once a second, 10 seconds, 100 seconds, or whatever, an unattended system will wind up with thousands of messages in its logs that obfuscate more important messages. I think a better tactic is to print a message once, and maintain a sysctl with a counter.

Jul 23 2021, 2:43 PM

Jul 13 2021

scottl added a comment to D30298: cam: clear stack-allocated CCB in the target layer.

So... Scott, are you still against the change as it is?

Jul 13 2021, 6:31 PM
scottl accepted D31153: tcpdump: decode packets on pfsync interfaces.
Jul 13 2021, 4:51 AM

Jul 11 2021

scottl requested changes to D19169: Implement a system-wide limit or da and ada devices for delete..

This is the kind of change that seems simple and obvious, but opens up semantic gray areas in the language and the runtime. Is the intent that 0 means that trim is disabled? Should this coordinate with other tunable? How would one express unlimited? I guess as 0x7ffffffffffffff since it's a signed quad? It's now possible to feed a negative value into d_delmaxsize where that wasn't possible before (even though the field is signed), so does the rest of the system know how to deal with that?

Jul 11 2021, 7:57 PM

Jul 9 2021

scottl accepted D30668: Intel I225 Driver.
Jul 9 2021, 11:55 PM

Jul 5 2021

scottl requested changes to D30298: cam: clear stack-allocated CCB in the target layer.

The scsi_ctl.c part needs a lot of work. ctlferegster() is probably allocating the ccb on the stack because it's the peripheral constructor and is being called with locks held, so the original author didn't want to do a malloc(M_WAITOK). This is a pattern in CAM that needs to be fixed but is outside of the scope of this change. I think that that's probably a better to replace the stack allocations with malloc(M_NOWAIT|M_ZERO) and not overthink an out-of-memory situation. But if that's not acceptable, then consider that the ccb is only used for XPT_FE_LUN and doesn't need a full union ccb allocation on the stack. I'm also a bit confused and concerned as to why this function uses different allocation paradigms; pick one and stick with it.

Jul 5 2021, 6:43 PM

Jun 27 2021

scottl accepted D30890: cam_sim: remove unused sim_doneq member.
Jun 27 2021, 12:01 AM
scottl accepted D30884: cam: change xpt_clone_path to return int.
Jun 27 2021, 12:00 AM

Jun 24 2021

scottl accepted D30847: cam: fix UB behavior.

Thank you. This stuff always broke my brain.

Jun 24 2021, 3:11 AM
scottl accepted D30852: cam: Group all xpt_path*() functions together in cam_xpt.h.
Jun 24 2021, 2:58 AM
scottl accepted D30854: cam mmc: Assert that the xpt_bus_register registered a device_t.
Jun 24 2021, 2:57 AM
scottl accepted D30856: mmc_sim: stop using cam_sim_alloc_dev.
Jun 24 2021, 2:48 AM
scottl accepted D30858: cam: delete cam_sim_alloc_dev.
Jun 24 2021, 2:44 AM
scottl accepted D30853: cam: add xpt_path_device to return device_t associated with a path.
Jun 24 2021, 2:03 AM
scottl accepted D30846: cam: save parent_dev in xpt_bus_register.

The model is that a sim represents the queueing and resource pool for one or more buses. If multiple buses have their own private resource and scheduling pools, then those buses need to have separate sims. If they share resources, then they need to share the same sim. AHC was weird because even though it had a split "TWIN" mode, apparently the split buses still had independent resource pools and queueing limits. The same was not true with cards that presented logical and physical drives like mpt and ciss; they still draw from the same resource pool, so they needed a single SIM and also need distinctive buses so the physical and logical target numbers don't conflict. This is really a detail of the driver and hardware, and is something that the driver writer should know and understand early in the design phase of development. Even though SAS controllers have multiple "ports", the queueing is still typically common to all ports on the device, so only a single bus is created on the sim.

Jun 24 2021, 2:02 AM
scottl accepted D30860: cam: fix xpt_bus_register and xpt_bus_deregister return errno.

Yeah, my feeling is still that C function return values should be errno's, and that cam_status should be reserved for use primarily in the status fields of CCBs and related structures. If a C function needs to return a cam_status, it should return an errno and pass the cam_status by reference.

Jun 24 2021, 1:47 AM
scottl accepted D30879: cam: Remove CAM_TRUE and CAM_FALSE, they are unused and duplicate bool.

Part of me feels that abstracted definitions for implementation semantics is good API design, but it sounds like this is a good candidate for garbage collection.

Jun 24 2021, 1:31 AM

Jun 16 2021

scottl accepted D30668: Intel I225 Driver.
Jun 16 2021, 5:38 AM

Jun 11 2021

scottl accepted D30719: pf: store L4 headers in pf_pdesc.
Jun 11 2021, 5:55 PM

Jun 7 2021

scottl added a reviewer for D30668: Intel I225 Driver: loos.
Jun 7 2021, 3:40 PM

May 28 2021

scottl accepted D30510: pf: Convenience function for optional (numeric) arguments.
May 28 2021, 7:21 PM
scottl accepted D30493: libpfctl: Improve error handling in pfctl_get_states().
May 28 2021, 7:18 PM
scottl accepted D30492: libpfctl: fix memory leak.

This looks like a deficiency in the API design, but I don't object to this change.

May 28 2021, 7:14 PM

May 26 2021

scottl added a member for pfsense: scottl.
May 26 2021, 6:27 PM

May 21 2021

scottl accepted D30383: cam: remove sim callout.
May 21 2021, 7:30 PM

Apr 21 2021

scottl requested changes to D29896: libkiconv: address memory leak in a not-found case.
Apr 21 2021, 5:59 PM

Mar 18 2021

scottl committed rG4c6c8f51fdb7: base: remove if_wg(4) and associated utilities, manpage (authored by scottl).
base: remove if_wg(4) and associated utilities, manpage
Mar 18 2021, 1:53 PM
scottl committed rGb65d2c31b1de: base: remove if_wg(4) and associated utilities, manpage (authored by scottl).
base: remove if_wg(4) and associated utilities, manpage
Mar 18 2021, 7:16 AM