scottl (Scott Long)
User

Projects

User Details

User Since
Jun 4 2014, 7:07 AM (189 w, 2 d)

Recent Activity

Today

scottl added a reviewer for D13868: Use XPT_GET_ADVINFO for retrieving MMC params: kibab.
Fri, Jan 19, 7:05 AM

Thu, Jan 11

scottl added inline comments to D13868: Use XPT_GET_ADVINFO for retrieving MMC params.
Thu, Jan 11, 6:32 PM
scottl created D13868: Use XPT_GET_ADVINFO for retrieving MMC params.
Thu, Jan 11, 6:07 PM

Wed, Jan 10

scottl committed rS327762: Refactor code related to 'camcontrol devlist'.
Refactor code related to 'camcontrol devlist'
Wed, Jan 10, 5:52 AM
scottl committed rS327761: Implement the ability to query NVME for its controller data so that it will.
Implement the ability to query NVME for its controller data so that it will
Wed, Jan 10, 5:29 AM

Tue, Jan 9

scottl committed rS327742: Release the held refcount on the probe periph when probing is.
Release the held refcount on the probe periph when probing is
Tue, Jan 9, 9:24 PM
scottl committed rS327741: Hold a refcount on the periph while running the allocation.
Hold a refcount on the periph while running the allocation
Tue, Jan 9, 9:23 PM
scottl committed rS327711: Don't hold the periph locks during dump..
Don't hold the periph locks during dump.
Tue, Jan 9, 12:17 AM
scottl committed rS327710: Don't hold the periph lock when calling into cam_periph_runccb().
Don't hold the periph lock when calling into cam_periph_runccb()
Tue, Jan 9, 12:11 AM
scottl committed rS327709: Protect against a possible NULL deference from an accessor.
Protect against a possible NULL deference from an accessor
Tue, Jan 9, 12:01 AM

Dec 6 2017

scottl accepted D13387: Define xpt_path_inq..
Dec 6 2017, 9:44 PM

Nov 29 2017

scottl committed rS326377: It's time to retire AHC_REG_PRETTY_PRINT and AHD_REG_PRETTY_PRINT from.
It's time to retire AHC_REG_PRETTY_PRINT and AHD_REG_PRETTY_PRINT from
Nov 29 2017, 11:42 PM

Nov 20 2017

scottl committed rS326029: Update a comment in brelse() to match reality..
Update a comment in brelse() to match reality.
Nov 20 2017, 8:53 PM

Nov 17 2017

scottl committed rS325934: Rename P_OSREL_CK_CLYGRP to P_OSREL_CK_CYLGRP.
Rename P_OSREL_CK_CLYGRP to P_OSREL_CK_CYLGRP
Nov 17 2017, 1:12 PM

Nov 15 2017

scottl created D13098: Make interrupt driven config hooks configurable and predictable..
Nov 15 2017, 12:03 AM

Nov 13 2017

scottl accepted D13042: Add two new tunables / sysctls to controll reboot after panic.
Nov 13 2017, 5:21 PM

Nov 10 2017

scottl committed rS325667: Refactoring the interrupt setup code introduced a bug where the drivers.
Refactoring the interrupt setup code introduced a bug where the drivers
Nov 10 2017, 5:02 PM

Oct 26 2017

scottl accepted D12799: Always send STANDBY IMMEDIATE when shutting down.
Oct 26 2017, 6:52 PM

Oct 24 2017

scottl accepted D12777: Implenent power cycle option to reboot.
Oct 24 2017, 5:49 PM

Oct 1 2017

scottl committed rS324162: Improve the debug parsing to allow flags to be added and subtracted.
Improve the debug parsing to allow flags to be added and subtracted
Oct 1 2017, 3:35 PM

Sep 29 2017

scottl committed rS324097: Convert sysctl sbuf usage to use a fully dynaic sbuf. This is strictly.
Convert sysctl sbuf usage to use a fully dynaic sbuf. This is strictly
Sep 29 2017, 4:52 AM

Sep 24 2017

scottl committed rS323969: Add the ability to report and set debug flags as text strings instead of.
Add the ability to report and set debug flags as text strings instead of
Sep 24 2017, 1:15 PM

Sep 23 2017

scottl committed rS323946: Garbage collect usued fields.
Garbage collect usued fields
Sep 23 2017, 8:26 AM

Sep 22 2017

scottl committed rS323922: Clean up error messages related to device discovery.
Clean up error messages related to device discovery
Sep 22 2017, 12:07 PM

Sep 18 2017

scottl committed rS323712: Hide a normal probe warning message under bootverbose, similar to atkbdc.
Hide a normal probe warning message under bootverbose, similar to atkbdc
Sep 18 2017, 6:42 PM

Sep 15 2017

scottl committed rS323629: Fix line wrap issues..
Fix line wrap issues.
Sep 15 2017, 8:59 PM
scottl committed rS323614: Add support for parsing the Watchdog Descriptor Table (WDDT).
Add support for parsing the Watchdog Descriptor Table (WDDT)
Sep 15 2017, 3:41 PM

Sep 11 2017

scottl committed rS323412: Add infrastructure for allocating multiple MSI-X interrupts. Also.
Add infrastructure for allocating multiple MSI-X interrupts. Also
Sep 11 2017, 1:51 AM

Sep 10 2017

scottl committed rS323384: Fix intrhook release in MPR and MPS for EARLY_AP_STARTUP..
Fix intrhook release in MPR and MPS for EARLY_AP_STARTUP.
Sep 10 2017, 7:10 AM
scottl committed rS323383: More code refactoring in preparation for enabling multiqueue..
More code refactoring in preparation for enabling multiqueue.
Sep 10 2017, 4:09 AM

Sep 9 2017

scottl committed rS323380: Convert some in-line printing of diagnostic into tables..
Convert some in-line printing of diagnostic into tables.
Sep 9 2017, 10:02 PM
scottl committed rS323370: Remove the unnecessary use of a temporary string buffer..
Remove the unnecessary use of a temporary string buffer.
Sep 9 2017, 6:40 PM
scottl committed rS323369: Start separating the LSI drivers into per-queue structures. No.
Start separating the LSI drivers into per-queue structures. No
Sep 9 2017, 6:03 PM

Sep 8 2017

scottl committed rS323330: Refactor interrupt allocation and deallocation. Add some extra.
Refactor interrupt allocation and deallocation. Add some extra
Sep 8 2017, 8:20 PM
scottl committed rS323320: Fix intrhook release in MFI as well.
Fix intrhook release in MFI as well
Sep 8 2017, 5:51 PM
scottl committed rS323319: As with r323317, hold off on releasing the intrhook during boot until.
As with r323317, hold off on releasing the intrhook during boot until
Sep 8 2017, 5:40 PM
scottl committed rS323317: Move the intrhook release to later in the function so that GEOM knows to wait….
Move the intrhook release to later in the function so that GEOM knows to wait…
Sep 8 2017, 4:53 PM

Sep 6 2017

scottl committed rS323215: Checkpoint the next phase in debug message cleanup, this time focusing on.
Checkpoint the next phase in debug message cleanup, this time focusing on
Sep 6 2017, 9:20 AM

Aug 29 2017

scottl accepted D11361: Add CAM/NVMe support for CAM_DATA_SG.
Aug 29 2017, 6:40 AM

Aug 27 2017

scottl closed D12112: Overhaul debug printing for device initialization..

Resolved in r322943

Aug 27 2017, 6:25 AM
scottl committed rS322943: Start overhauling debug printing in the MPS and MPR drivers. The focus of this.
Start overhauling debug printing in the MPS and MPR drivers. The focus of this
Aug 27 2017, 6:24 AM

Aug 24 2017

scottl accepted D12119: Fix 32-bit overflow on latency measurements.
Aug 24 2017, 9:48 PM
scottl accepted D12112: Overhaul debug printing for device initialization..
Aug 24 2017, 9:43 PM

Aug 23 2017

scottl created D12112: Overhaul debug printing for device initialization..
Aug 23 2017, 9:15 PM

Aug 22 2017

scottl added inline comments to D11361: Add CAM/NVMe support for CAM_DATA_SG.
Aug 22 2017, 10:01 PM
scottl added inline comments to D11361: Add CAM/NVMe support for CAM_DATA_SG.
Aug 22 2017, 9:59 PM

Jul 31 2017

scottl committed rS321799: Fix a logic bug in the split PCI interrupt code that slipped through.
Fix a logic bug in the split PCI interrupt code that slipped through
Jul 31 2017, 4:56 PM
scottl committed rS321797: Add an entry to the freebsd calendar for myself..
Add an entry to the freebsd calendar for myself.
Jul 31 2017, 3:51 PM
scottl committed rS321737: Don't re-parse PCI IDs in order to set card-specific flags, use.
Don't re-parse PCI IDs in order to set card-specific flags, use
Jul 31 2017, 12:05 AM

Jul 30 2017

scottl committed rS321733: Change from using underbar function names to normal function names for.
Change from using underbar function names to normal function names for
Jul 30 2017, 10:34 PM
scottl committed rS321714: Split the interrupt setup code into two parts: allocation and configuration..
Split the interrupt setup code into two parts: allocation and configuration.
Jul 30 2017, 6:54 AM
scottl closed D9243: Refactor MPR/MPS interrupt setup code. by committing rS321714: Split the interrupt setup code into two parts: allocation and configuration..
Jul 30 2017, 6:54 AM

Jul 27 2017

scottl committed rS321604: Fix some broken logic used in obtaining the certain config pages. I'm.
Fix some broken logic used in obtaining the certain config pages. I'm
Jul 27 2017, 5:32 AM

Jul 26 2017

scottl committed rS321502: Quiet a message that sounds far more dire than it really is..
Quiet a message that sounds far more dire than it really is.
Jul 26 2017, 1:48 AM

May 16 2017

scottl accepted D10095: Add tri-mode support to mpr.
May 16 2017, 9:23 PM

May 11 2017

scottl accepted D10645: Avoid use of contiguous memory allocations in busdma.
May 11 2017, 4:21 PM
scottl committed rS318188: Improve error messages during command timeout for the mpr and mps.
Improve error messages during command timeout for the mpr and mps
May 11 2017, 3:19 PM

May 5 2017

scottl committed rS317838: Show more fields in the IOCFact message.
Show more fields in the IOCFact message
May 5 2017, 5:02 PM

May 3 2017

scottl committed rS317726: Fix an unsafe malloc usage with sbufs..
Fix an unsafe malloc usage with sbufs.
May 3 2017, 5:33 AM

Apr 20 2017

scottl created D10445: Speed up NVME crashdumps.
Apr 20 2017, 11:12 PM
scottl committed rS317213: Reorder the minimum_cmd_size code to make it a little smaller and.
Reorder the minimum_cmd_size code to make it a little smaller and
Apr 20 2017, 8:46 PM

Apr 19 2017

scottl committed rS317143: Add infrastructure to the ATA and SCSI transports that supports.
Add infrastructure to the ATA and SCSI transports that supports
Apr 19 2017, 3:05 PM

Apr 18 2017

scottl updated the diff for D10417: Use sbufs for CAM device announcements.

Rewrote the xpt_announce_periph and xpt_denounce_periph functions, the
previous work tried too hard and failed at code sharing. Also add in
seatbelts for transports that don't support sbufs yet, and add a tunable
knob to force the non-use of sbufs

Apr 18 2017, 10:42 PM
scottl added inline comments to D10417: Use sbufs for CAM device announcements.
Apr 18 2017, 1:43 PM
scottl added a comment to D5704: Add a wrapper API for static DMA allocations to bus_dma(9)..

Pending our discussion on IRC, would you mind if I took over this review and extended it?

Apr 18 2017, 4:31 AM
scottl created D10417: Use sbufs for CAM device announcements.
Apr 18 2017, 3:31 AM

Mar 22 2017

scottl added inline comments to D10095: Add tri-mode support to mpr.
Mar 22 2017, 9:18 PM
scottl added inline comments to D10095: Add tri-mode support to mpr.
Mar 22 2017, 9:13 PM

Mar 13 2017

scottl committed rS315195: Report disk flags via the sysctl tree.
Report disk flags via the sysctl tree
Mar 13 2017, 11:09 AM
scottl committed rS315190: Add constants and descriptions for some new PCI class definitions.
Add constants and descriptions for some new PCI class definitions
Mar 13 2017, 7:45 AM

Mar 11 2017

scottl added inline comments to D9901: aacraid: try to fix internal locking versus bus_dma locking.
Mar 11 2017, 7:25 PM

Mar 10 2017

scottl added inline comments to D9900: aacraid: add support for older controllers with i960Rx interface.
Mar 10 2017, 11:14 PM
scottl requested changes to D9900: aacraid: add support for older controllers with i960Rx interface.

I appreciate the effort on this, but I almost wonder if it's better to let the old hardware die off. I have no way to test this, but my initial scan looks ok. Which driver will have priority at boot if both the aac and aacraid variants are present? They both will return BUS_PROBE_DEFAULT, so it'll be indeterminate.

Mar 10 2017, 10:48 PM

Mar 2 2017

scottl committed rS314533: Expose the sbuf_putbuf() symbol to libsbuf. There are a few other symbols.
Expose the sbuf_putbuf() symbol to libsbuf. There are a few other symbols
Mar 2 2017, 1:39 AM

Feb 28 2017

scottl committed rS314420: Provide a comment on why stdio.h needs to be included..
Provide a comment on why stdio.h needs to be included.
Feb 28 2017, 9:28 PM
scottl committed rS314399: Add prototype for sbuf_putbuf().
Add prototype for sbuf_putbuf()
Feb 28 2017, 7:02 PM
scottl committed rS314397: Implement sbuf_prf(), which takes an sbuf and outputs it.
Implement sbuf_prf(), which takes an sbuf and outputs it
Feb 28 2017, 6:25 PM

Feb 27 2017

scottl added a comment to D9601: Expand sbufs to be able to output directly to the log+console interface.

Need input on naming. sbuf_putbuf() was named since it wraps putbuf(). Is this the best name, though? Also, should it be kernel only, and the userland be something else that suggests printing to stdout vs stderr vs some other file descriptor?

Feb 27 2017, 10:25 PM
scottl updated the diff for D9601: Expand sbufs to be able to output directly to the log+console interface.

Update patch to provide a kernel version and userland version
of sbuf_putbuf()

Feb 27 2017, 10:23 PM

Feb 22 2017

scottl added inline comments to D9502: Introduce geom_slow to simulate slow disks.
Feb 22 2017, 11:09 PM

Feb 20 2017

scottl added inline comments to D9602: Convert CAM to use sbufs for 'da' arrival announcements.
Feb 20 2017, 6:05 PM
scottl added inline comments to D9602: Convert CAM to use sbufs for 'da' arrival announcements.
Feb 20 2017, 6:02 PM

Feb 19 2017

scottl accepted D9653: Move inclusion of opt_printf.h around so that we can compile all the SCSI modules outside of a sub-build from the kernel..
Feb 19 2017, 7:54 PM

Feb 14 2017

scottl retitled D9602: Convert CAM to use sbufs for 'da' arrival announcements from to Convert CAM to use sbufs for 'da' arrival announcements.
Feb 14 2017, 10:51 PM
scottl retitled D9601: Expand sbufs to be able to output directly to the log+console interface from to Expand sbufs to be able to output directly to the log+console interface.
Feb 14 2017, 10:45 PM

Jan 27 2017

scottl committed rS312900: Squash a couple of uses of xpt_print_path().
Squash a couple of uses of xpt_print_path()
Jan 27 2017, 9:56 PM

Jan 26 2017

scottl committed rS312830: Fix a development mis-merge from r312827.
Fix a development mis-merge from r312827
Jan 26 2017, 8:18 PM
scottl committed rS312827: Refactor xpt_print_path, xpt_print, and xpt_path_string. Implement.
Refactor xpt_print_path, xpt_print, and xpt_path_string. Implement
Jan 26 2017, 8:09 PM
scottl updated the diff for D9344: Refactor xpt_print_path() and friends.

Expose _xpt_path_string() as xpt_path_sbuf()

Jan 26 2017, 4:40 AM
scottl retitled D9344: Refactor xpt_print_path() and friends from to Refactor xpt_print_path() and friends.
Jan 26 2017, 1:05 AM

Jan 19 2017

scottl committed rS312437: Rework the debug print API. Event printing no longer gets special handling..
Rework the debug print API. Event printing no longer gets special handling.
Jan 19 2017, 9:48 PM
scottl closed D9238: Rework the MPR/MPS debug print API. by committing rS312437: Rework the debug print API. Event printing no longer gets special handling..
Jan 19 2017, 9:48 PM
scottl updated the diff for D9243: Refactor MPR/MPS interrupt setup code..

Fix an uninitialized use of msi_msgs.

Jan 19 2017, 9:23 PM
scottl retitled D9243: Refactor MPR/MPS interrupt setup code. from to Refactor MPR/MPS interrupt setup code..
Jan 19 2017, 10:57 AM

Jan 18 2017

scottl retitled D9238: Rework the MPR/MPS debug print API. from Rework the debug print API. Event printing no longer gets special handling. All of the printing from the tables file now has wrappers so that the handling is cleaner and it's possible to print something out (say, during development) without... to Rework the MPR/MPS debug print API..
Jan 18 2017, 10:55 PM
scottl retitled D9238: Rework the MPR/MPS debug print API. from to Rework the debug print API. Event printing no longer gets special handling. All of the printing from the tables file now has wrappers so that the handling is cleaner and it's possible to print something out (say, during development) without....
Jan 18 2017, 10:53 PM

Jan 16 2017

scottl added a comment to D3687: Implement kernel support for hardware rate limited sockets.

Fixing things post-commit is much better than forcing the work to languish. This review has been plagued by poor participation for far too long, and it's reflecting poorly on the FreeBSD community. I'm ok with giving people until Wednesday, but after that it goes in, love it or hate it.

Jan 16 2017, 7:53 PM
scottl accepted D3687: Implement kernel support for hardware rate limited sockets.

There has been no dissension on this review since early November, and HPS has done a lot to update the code to address the comments from then. Given the lack of new input, I recommend that this code be committed.

Jan 16 2017, 7:37 PM

Jan 12 2017

scottl committed rS311958: Print out the number of queues/MSIx vectors..
Print out the number of queues/MSIx vectors.
Jan 12 2017, 1:13 AM

Nov 26 2016

scottl committed rS309201: Add a missing header.
Add a missing header
Nov 26 2016, 11:15 PM