Page MenuHomeFreeBSD

scottl (Scott Long)
User

Projects

User Details

User Since
Jun 4 2014, 7:07 AM (298 w, 9 h)

Recent Activity

Mon, Feb 17

scottl committed rS358041: Fix syntax error from r357647. Adjust a variable name to make the use more.
Fix syntax error from r357647. Adjust a variable name to make the use more
Mon, Feb 17, 8:12 PM

Sun, Feb 16

scottl committed rS358009: Add rudamentary support for UFS to probe whether a block device supports the.
Add rudamentary support for UFS to probe whether a block device supports the
Sun, Feb 16, 11:11 PM

Mon, Feb 10

scottl added a reverting change for rS357711: Missed a file in r357710, add it here.: rS357730: Revert r357710 and 357711 until they can be debugged.
Mon, Feb 10, 2:27 PM
scottl committed rS357730: Revert r357710 and 357711 until they can be debugged.
Revert r357710 and 357711 until they can be debugged
Mon, Feb 10, 2:27 PM
scottl committed rS357711: Missed a file in r357710, add it here..
Missed a file in r357710, add it here.
Mon, Feb 10, 12:26 AM
scottl committed rS357710: Add rudamentary support for UFS to probe whether a block device supports the.
Add rudamentary support for UFS to probe whether a block device supports the
Mon, Feb 10, 12:23 AM

Fri, Feb 7

scottl committed rS357651: Advertise the MPI Message Version that's contained in the IOCFacts message.
Advertise the MPI Message Version that's contained in the IOCFacts message
Fri, Feb 7, 12:16 PM
scottl committed rS357650: Touch up some of the iocfacts fields.
Touch up some of the iocfacts fields
Fri, Feb 7, 11:48 AM
scottl committed rS357647: Ever since the block layer expanded its command syntax beyond just.
Ever since the block layer expanded its command syntax beyond just
Fri, Feb 7, 9:22 AM
scottl added a comment to D23541: Make BIO_SPEEDUP opt-in.
In D23541#516975, @mjg wrote:

In that case what about the console spam? I presume messages of this sort:

g_vfs_done():md10a[UNKNOWN()]error = 45

stem precisely from this. This happens to really spam the console for me when e.g., running stress2 when at least for this case it should never print anything. iow it looks like a design error that that devices which don't support something can get a request AND fail resulting in an error message.
Here is an example from pho's log: https://people.freebsd.org/~pho/stress/log/mark125.txt

Fri, Feb 7, 8:07 AM
scottl added a comment to D23541: Make BIO_SPEEDUP opt-in.
In D23541#516964, @imp wrote:

I agree with Alexander, I really don't like that this perpetuates bad design.

So the proper fix is to fix all the disk drivers to just return op not supported?

Fri, Feb 7, 7:13 AM
scottl requested changes to D23541: Make BIO_SPEEDUP opt-in.

I agree with Alexander, I really don't like that this perpetuates bad design.

Fri, Feb 7, 5:33 AM

Thu, Jan 30

scottl added a comment to D23417: Export the current da flags as bitfield.

Also, this should be MFC'd to 12 and even 11. With that, you can remove in 13 instead of waiting for 14

Thu, Jan 30, 2:26 AM
scottl requested changes to D23417: Export the current da flags as bitfield.

My recommendation is to change the rotating and unmapped sysctls to be SYSCTL_PROC, and have them read the flag. That way you can retire the fields out of the softc now.

Thu, Jan 30, 1:54 AM

Jan 15 2020

scottl committed rS356762: Fix a spacing error from the previous commit for -ll mode. Add a little.
Fix a spacing error from the previous commit for -ll mode. Add a little
Jan 15 2020, 4:47 PM

Jan 2 2020

scottl committed rS356267: Add a compact columnar output format, available by specifying a second '-l'.
Add a compact columnar output format, available by specifying a second '-l'
Jan 2 2020, 6:56 AM

Dec 26 2019

scottl committed rS356098: Abstract the locking for PCIe hotplug. It still uses Giant so there's.
Abstract the locking for PCIe hotplug. It still uses Giant so there's
Dec 26 2019, 9:00 PM

Dec 24 2019

scottl committed rS356052: Convert the mpr driver to use busdma templates..
Convert the mpr driver to use busdma templates.
Dec 24 2019, 2:50 PM
scottl closed D22906: Simplify busdma tag creation.
Dec 24 2019, 2:50 PM
scottl committed rS356050: Introduce the concept of busdma tag templates. A template can be allocated.
Introduce the concept of busdma tag templates. A template can be allocated
Dec 24 2019, 2:50 PM
scottl committed rS356051: Bump __FreeBSD_version for the addition of busdma templates..
Bump __FreeBSD_version for the addition of busdma templates.
Dec 24 2019, 2:50 PM

Dec 23 2019

scottl updated the diff for D22906: Simplify busdma tag creation.

Change function names for better consistency. Add bus_dma_template_clone().
Update the man page.

Dec 23 2019, 7:54 PM
scottl added a comment to D22906: Simplify busdma tag creation.

I also have an large update to bus_dma.9 that I'll add to the review.

Dec 23 2019, 7:26 PM
scottl added a comment to D22906: Simplify busdma tag creation.

I already changed the names in an upcoming revision; I agree that simple wasn't a good name. For the purposes of cloning an existing tag, what I'd propose is to have a function, bus_dma_template_clone(*template, *dmat) that serializes the opaque fields of the tag back into a template, then lets you optionally modify the template, and then turn it into a new tag with bus_dma_template_tag(*template, *tag). I'll code that up and submit it in the next patch.

Dec 23 2019, 7:25 PM
scottl updated the diff for D22906: Simplify busdma tag creation.

Switch to a typedef for the template. Be type-correct with
NULL field assignments.

Dec 23 2019, 1:53 AM
scottl added a reviewer for D22906: Simplify busdma tag creation: mmacy.
Dec 23 2019, 1:16 AM

Dec 22 2019

scottl created D22906: Simplify busdma tag creation.
Dec 22 2019, 9:56 PM

Dec 14 2019

scottl accepted D22809: Implement a system-wide limit or da and ada devices for delete..
Dec 14 2019, 12:14 AM

Dec 13 2019

scottl committed rS355741: Add accessors for the Vendor Specific Extended Capability (VSEC).
Add accessors for the Vendor Specific Extended Capability (VSEC)
Dec 13 2019, 11:47 PM
scottl closed D22808: Expand handling of the PCI Vendor ecap.
Dec 13 2019, 11:47 PM
scottl added inline comments to D22808: Expand handling of the PCI Vendor ecap.
Dec 13 2019, 11:41 PM
scottl created D22808: Expand handling of the PCI Vendor ecap.
Dec 13 2019, 10:59 PM
scottl committed rS355701: Merge r355134,355375,355589.
Merge r355134,355375,355589
Dec 13 2019, 6:54 AM
scottl committed rS355698: Merge r355134,355375,355589.
Merge r355134,355375,355589
Dec 13 2019, 5:29 AM

Dec 10 2019

scottl committed rS355589: Fix the TAA state machine to do the right thing when the TAA.
Fix the TAA state machine to do the right thing when the TAA
Dec 10 2019, 6:57 PM

Dec 6 2019

scottl committed rS355440: MFC r349184. This fixing PCI passthrough via VT-d on modern chipsets with.
MFC r349184. This fixing PCI passthrough via VT-d on modern chipsets with
Dec 6 2019, 9:50 AM
scottl committed rS355436: Move the mds, irbs, and ssb mitigation knobs into machdep.mitigations..
Move the mds, irbs, and ssb mitigation knobs into machdep.mitigations.
Dec 6 2019, 2:43 AM
scottl closed D22590: Place IBRS, SSB, and MDS into the machdep.mitigations tree.
Dec 6 2019, 2:43 AM

Dec 5 2019

scottl committed rS355429: Add support for new sound HDA hardware.
Add support for new sound HDA hardware
Dec 5 2019, 7:40 PM

Dec 2 2019

scottl committed rS355310: I took over mentorship of Scott Philips a while ago, update the mentors.
I took over mentorship of Scott Philips a while ago, update the mentors
Dec 2 2019, 10:15 PM

Nov 28 2019

scottl created D22590: Place IBRS, SSB, and MDS into the machdep.mitigations tree.
Nov 28 2019, 6:37 AM
scottl committed rS355164: Remove the trm(4) driver.
Remove the trm(4) driver
Nov 28 2019, 2:32 AM
scottl updated the diff for D22575: Remove the trm driver.

Add ObsoleteFiles

Nov 28 2019, 12:12 AM

Nov 27 2019

scottl created D22575: Remove the trm driver.
Nov 27 2019, 7:15 PM
scottl committed rS355134: Clean up and clarify meta commentary on TAA. Add a state to denote.
Clean up and clarify meta commentary on TAA. Add a state to denote
Nov 27 2019, 7:12 PM

Nov 26 2019

scottl committed rS355118: Partially revert r355028. hpt27xx is not Giant-locked in FreeBSD 12.x,.
Partially revert r355028. hpt27xx is not Giant-locked in FreeBSD 12.x,
Nov 26 2019, 7:04 PM
scottl committed rS355114: Revert r355021. In my haste to grep for Giant, I missed that it was in.
Revert r355021. In my haste to grep for Giant, I missed that it was in
Nov 26 2019, 5:26 PM

Nov 25 2019

scottl accepted D22539: Remove ifdefs for FreeBSD 6, 7, 8 and 9. Assume we're past that..
Nov 25 2019, 5:11 AM

Nov 24 2019

scottl accepted D22529: bsd-family-tree: add several new entries.
Nov 24 2019, 7:52 AM
scottl added a reviewer for D22529: bsd-family-tree: add several new entries: scottl.
Nov 24 2019, 7:47 AM

Nov 23 2019

scottl committed rS355028: MFC 355012 and 355021. Mark trm and hpt27xx for removal in 13.0.
MFC 355012 and 355021. Mark trm and hpt27xx for removal in 13.0
Nov 23 2019, 7:06 AM

Nov 22 2019

scottl committed rS355021: Mark hpt27xx for removal in 13.0; all CAM drivers will be Giant-free by then..
Mark hpt27xx for removal in 13.0; all CAM drivers will be Giant-free by then.
Nov 22 2019, 8:23 PM
scottl committed rS355012: Schedule the trm(4) driver for removal. It relies on Giant and thus has.
Schedule the trm(4) driver for removal. It relies on Giant and thus has
Nov 22 2019, 6:51 PM
scottl committed rS355009: Remove NEEDGIANT from the scsi_sg /dev node. It likely has not been.
Remove NEEDGIANT from the scsi_sg /dev node. It likely has not been
Nov 22 2019, 6:18 PM

Nov 18 2019

scottl accepted D22431: Add x86 msr tweak KPI..
Nov 18 2019, 7:59 PM
scottl added a comment to D22431: Add x86 msr tweak KPI..

Minor request, if the MSR_OP_LOCAL/SCHED/RENDEVOUS opcodes are mutually exclusive from each other then don't make them be bitfield definitions, just have them be sequential numbers.

Nov 18 2019, 4:33 PM
scottl added a comment to D22431: Add x86 msr tweak KPI..

This looks great. My only complaint is using the name "tweak", I think it's too casual and poorly descriptive. Maybe x86_program_msr_smp()?

Nov 18 2019, 6:25 AM

Nov 16 2019

scottl committed rS354764: MFC r354759:.
MFC r354759:
Nov 16 2019, 12:52 AM
scottl committed rS354763: MFC r354759:.
MFC r354759:
Nov 16 2019, 12:36 AM
scottl committed rS354762: MFC r354756:.
MFC r354756:
Nov 16 2019, 12:33 AM
scottl committed rS354761: Partially revert r354760, it included a patch that wasn't ready yet..
Partially revert r354760, it included a patch that wasn't ready yet.
Nov 16 2019, 12:32 AM
scottl committed rS354760: MFC r354756:.
MFC r354756:
Nov 16 2019, 12:29 AM
scottl committed rS354759: TSX Asynchronous Abort mitigation for Intel CVE-2019-11135..
TSX Asynchronous Abort mitigation for Intel CVE-2019-11135.
Nov 16 2019, 12:26 AM

Nov 15 2019

scottl updated the diff for D22374: TSX Asynchronous Abort Mitigation.

Move taa into its own sysctl node, machdep.mitigations.taa.(enable|state)

Nov 15 2019, 11:45 PM
scottl committed rS354756: Create a new sysctl subtree, machdep.mitigations. Its purpose is to organize.
Create a new sysctl subtree, machdep.mitigations. Its purpose is to organize
Nov 15 2019, 11:27 PM
scottl added inline comments to D22374: TSX Asynchronous Abort Mitigation.
Nov 15 2019, 11:12 PM
scottl updated the diff for D22374: TSX Asynchronous Abort Mitigation.

Move the sysctls and tunables to the new machdep.mitigations
tree. Rename the code in accordance, and rename the sysctls
themselves to have neutral wording.

Nov 15 2019, 11:10 PM
scottl added inline comments to D22374: TSX Asynchronous Abort Mitigation.
Nov 15 2019, 9:13 PM
scottl added inline comments to D22374: TSX Asynchronous Abort Mitigation.
Nov 15 2019, 8:41 PM
scottl added inline comments to D22374: TSX Asynchronous Abort Mitigation.
Nov 15 2019, 8:39 PM
scottl updated the diff for D22374: TSX Asynchronous Abort Mitigation.

Address several comments

Nov 15 2019, 8:37 PM
scottl added inline comments to D22374: TSX Asynchronous Abort Mitigation.
Nov 15 2019, 8:28 PM
scottl added a comment to D22374: TSX Asynchronous Abort Mitigation.

My suggestion is to move ssb, mds, tsx, and probably others from _hw to something like _hw.x86.mitigations. Then rename each with a name that's not enable or disable. We would still have compat OIDs, and I think that the values could remain the same. That's work for a future time, though.

Nov 15 2019, 8:09 PM
scottl added inline comments to D22374: TSX Asynchronous Abort Mitigation.
Nov 15 2019, 7:50 PM
scottl updated the diff for D22374: TSX Asynchronous Abort Mitigation.

Add some bootverbose messages for when things don't behave.
Track MDS state and synchronize more closely with it.

Nov 15 2019, 7:23 PM
scottl updated the diff for D22374: TSX Asynchronous Abort Mitigation.

Remove an unncessary XXX comment

Nov 15 2019, 5:47 PM
scottl added inline comments to D22374: TSX Asynchronous Abort Mitigation.
Nov 15 2019, 5:32 PM
scottl updated the diff for D22374: TSX Asynchronous Abort Mitigation.

Forgot to set the TSX MSR on all CPUs, not just the one that's currently
running. Fixed.

Nov 15 2019, 12:40 PM
scottl updated the diff for D22374: TSX Asynchronous Abort Mitigation.

Complete the TAA mitigation. Code is tested with and without the
microcode update. Has not been tested to see if it actually stops
the POC attacks.

Nov 15 2019, 12:12 PM
scottl committed rS354730: Revert a patch that accidentally was committed with r354729.
Revert a patch that accidentally was committed with r354729
Nov 15 2019, 11:55 AM
scottl committed rS354729: Fix a typo in how the AVX512DQ feature bit is checked..
Fix a typo in how the AVX512DQ feature bit is checked.
Nov 15 2019, 11:53 AM

Nov 14 2019

scottl accepted D18613: Add driver for the VMware Paravirtual SCSI (pvscsi) controller.
Nov 14 2019, 11:17 PM
scottl added reviewers for D22374: TSX Asynchronous Abort Mitigation: emaste, kib, scottph.
Nov 14 2019, 5:45 PM
scottl updated the diff for D22374: TSX Asynchronous Abort Mitigation.

Small updates

Nov 14 2019, 5:22 PM
scottl created D22374: TSX Asynchronous Abort Mitigation.
Nov 14 2019, 5:04 PM

Nov 13 2019

scottl committed rP517393: Update to opcm as of e1f3a51. This provides better support for CascadeLake.
Update to opcm as of e1f3a51. This provides better support for CascadeLake
Nov 13 2019, 10:03 PM
scottl closed D22172: Update sysutils/intel-pcm as of 28-Oct-2019.
Nov 13 2019, 10:03 PM
scottl committed rS354683: Stop the VESA driver from whining loudly in the dmesg during boot on.
Stop the VESA driver from whining loudly in the dmesg during boot on
Nov 13 2019, 3:31 PM

Nov 12 2019

scottl committed rS354658: MFC: Add new bit definitions for TSX, related to the TAA issue. The actual.
MFC: Add new bit definitions for TSX, related to the TAA issue. The actual
Nov 12 2019, 7:35 PM
scottl committed rS354657: MFC: Add new bit definitions for TSX, related to the TAA issue. The actual.
MFC: Add new bit definitions for TSX, related to the TAA issue. The actual
Nov 12 2019, 7:29 PM
scottl committed rS354655: Add new bit definitions for TSX, related to the TAA issue. The actual.
Add new bit definitions for TSX, related to the TAA issue. The actual
Nov 12 2019, 7:15 PM
scottl accepted D21987: nvdimm(4): Only expose namespaces for accessible data SPAs.
Nov 12 2019, 1:05 AM
scottl accepted D22253: nvdimm(4): Fix various problems when the using the second label index block.
Nov 12 2019, 1:01 AM

Nov 11 2019

scottl committed rS354631: Add the text attribute for MDS_NO in the IA32_ARCH_CAP MSR..
Add the text attribute for MDS_NO in the IA32_ARCH_CAP MSR.
Nov 11 2019, 10:18 PM
scottl accepted D22295: Fix panic message to indicate right action that was improper..
Nov 11 2019, 3:52 AM

Oct 28 2019

scottl committed rS354143: Add device IDs for the next generation of Intel HDA audio..
Add device IDs for the next generation of Intel HDA audio.
Oct 28 2019, 11:31 PM
scottl added a reviewer for D22172: Update sysutils/intel-pcm as of 28-Oct-2019: gallatin.
Oct 28 2019, 6:48 PM
scottl created D22172: Update sysutils/intel-pcm as of 28-Oct-2019.
Oct 28 2019, 6:46 PM

Oct 23 2019

scottl accepted D21818: snd_hda: Add Intel Comet Lake and Ice Lake support.
Oct 23 2019, 4:39 PM

Oct 13 2019

scottl committed rS353462: Fix the botched field ordering in the last commit. While here, fix.
Fix the botched field ordering in the last commit. While here, fix
Oct 13 2019, 5:12 AM