- User Since
- Jun 4 2014, 7:07 AM (298 w, 9 h)
Mon, Feb 17
Sun, Feb 16
Mon, Feb 10
Fri, Feb 7
I agree with Alexander, I really don't like that this perpetuates bad design.
Thu, Jan 30
Also, this should be MFC'd to 12 and even 11. With that, you can remove in 13 instead of waiting for 14
My recommendation is to change the rotating and unmapped sysctls to be SYSCTL_PROC, and have them read the flag. That way you can retire the fields out of the softc now.
Jan 15 2020
Jan 2 2020
Dec 26 2019
Dec 24 2019
Dec 23 2019
Change function names for better consistency. Add bus_dma_template_clone().
Update the man page.
I also have an large update to bus_dma.9 that I'll add to the review.
I already changed the names in an upcoming revision; I agree that simple wasn't a good name. For the purposes of cloning an existing tag, what I'd propose is to have a function, bus_dma_template_clone(*template, *dmat) that serializes the opaque fields of the tag back into a template, then lets you optionally modify the template, and then turn it into a new tag with bus_dma_template_tag(*template, *tag). I'll code that up and submit it in the next patch.
Switch to a typedef for the template. Be type-correct with
NULL field assignments.
Dec 22 2019
Dec 14 2019
Dec 13 2019
Dec 10 2019
Dec 6 2019
Dec 5 2019
Dec 2 2019
Nov 28 2019
Nov 27 2019
Nov 26 2019
Nov 25 2019
Nov 24 2019
Nov 23 2019
Nov 22 2019
Nov 18 2019
Minor request, if the MSR_OP_LOCAL/SCHED/RENDEVOUS opcodes are mutually exclusive from each other then don't make them be bitfield definitions, just have them be sequential numbers.
This looks great. My only complaint is using the name "tweak", I think it's too casual and poorly descriptive. Maybe x86_program_msr_smp()?
Nov 16 2019
Nov 15 2019
Move taa into its own sysctl node, machdep.mitigations.taa.(enable|state)
Move the sysctls and tunables to the new machdep.mitigations
tree. Rename the code in accordance, and rename the sysctls
themselves to have neutral wording.
Address several comments
My suggestion is to move ssb, mds, tsx, and probably others from _hw to something like _hw.x86.mitigations. Then rename each with a name that's not enable or disable. We would still have compat OIDs, and I think that the values could remain the same. That's work for a future time, though.
Add some bootverbose messages for when things don't behave.
Track MDS state and synchronize more closely with it.
Remove an unncessary XXX comment
Forgot to set the TSX MSR on all CPUs, not just the one that's currently
Complete the TAA mitigation. Code is tested with and without the
microcode update. Has not been tested to see if it actually stops
the POC attacks.
Nov 14 2019