Page MenuHomeFreeBSD

scottl (Scott Long)
User

Projects

User Details

User Since
Jun 4 2014, 7:07 AM (313 w, 5 h)

Recent Activity

Apr 22 2020

scottl added a comment to D24406: Don't allocate a stack buffer with a user-controlled size for CAMIOCOMMAND..

In a pinch, I'd take it back to being a page size. I can see an argument that oversized CDBs and CAM_CDB_POINTER are underused to the point of creating unnecessary complication and risk to the code (as is evident from Alexander breaking it in r307205). No API was ever developed to make the feature easier to use, so it's been hit-and-miss on whether SIMs even support it. Maybe we eliminate it and deal with oversized CDBs via a new CCB type. We should also look into whether the embedded layout is creating unnecessary cache pollution in the CCB; maybe it makes sense to always have the CDB be a pointer to a scratch area at the end of the CCB that can grow as needed. Either way, we could bring everything into a conforming pattern that's easier and less risky.

Apr 22 2020, 12:03 AM

Apr 21 2020

scottl added a comment to D24489: Don't pass a user buffer pointer as the data pointer in a CCB..

Blah, but thanks for the history on it, I guess I never noticed before. I would be surprised if this hasn't caused bugs. There's no longer an active standards group, and even if there was I'd advocate that this is wrong. Let's follow up with a change on it.

Apr 21 2020, 10:11 PM
scottl requested changes to D24406: Don't allocate a stack buffer with a user-controlled size for CAMIOCOMMAND..

The point of all of this is that CDB's were predicted to grow larger than 16 bytes, and CAM was trying to optimize the common case of 6/10/12/16 byte CDB's without creating an API incompatibility for handling future growth. If a device came along that needed 32 byte CDB's, you could still use the stock CCB fields, but tack on the CDB as a separate allocation rather than have it be embedded in the CCB. So, while I agree with the original problem statement that the use of alloca() was unsafe, I disagree with the resolution.

Apr 21 2020, 10:05 PM
scottl added a comment to D24489: Don't pass a user buffer pointer as the data pointer in a CCB..

The problem isn't the existence of bi-directional commands, it's that DIR_BOTH == 0, not an OR'ing of DIR_IN and DIR_OUT, as would be expected.

Apr 21 2020, 6:10 PM
scottl accepted D24489: Don't pass a user buffer pointer as the data pointer in a CCB..

Yep, can tackle the CAM_DIR problem separately.

Apr 21 2020, 6:03 PM
scottl added inline comments to D24489: Don't pass a user buffer pointer as the data pointer in a CCB..
Apr 21 2020, 3:12 PM

Apr 19 2020

scottl accepted D24480: Avoid panicing for commands that poll-out..
Apr 19 2020, 5:42 AM

Apr 16 2020

scottl committed rS360004: Fix ps_strings type change for i386.
Fix ps_strings type change for i386
Apr 16 2020, 5:27 AM
scottl committed rS360003: Add support for some IOCFacts fields that are available with mpr (12Gb).
Add support for some IOCFacts fields that are available with mpr (12Gb)
Apr 16 2020, 4:17 AM
scottl committed rS360002: Don't keep a private copy of mpr_ioctl.h and mps_ioctl.h, since they.
Don't keep a private copy of mpr_ioctl.h and mps_ioctl.h, since they
Apr 16 2020, 3:33 AM
scottl committed rS360001: Add a small hack to the ioctl header files so that both mpr and mps can.
Add a small hack to the ioctl header files so that both mpr and mps can
Apr 16 2020, 3:28 AM

Apr 15 2020

scottl accepted D24426: Improve TSC calibration logic..

Works on my Icelake system

Apr 15 2020, 9:35 PM

Mar 31 2020

scottl accepted D24247: x86 tsc: fall back to CPUID if calibration results looks unbelievable..

Works for my Icelake laptop Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz

Mar 31 2020, 11:00 PM

Mar 28 2020

scottl accepted D24204: KTLS: Coalesce adjacent TLS trailers & headers to improve PCIe bus efficiency.

Looks really good.

Mar 28 2020, 6:39 PM

Mar 20 2020

scottl committed rS359187: When printing out the contents of the VSEC, include the contents of the.
When printing out the contents of the VSEC, include the contents of the
Mar 20 2020, 11:26 PM

Mar 10 2020

scottl added inline comments to D24008: Various cleanups: remove unused / under-used stuff..
Mar 10 2020, 10:56 PM
scottl added inline comments to D24008: Various cleanups: remove unused / under-used stuff..
Mar 10 2020, 7:34 PM
scottl added inline comments to D24008: Various cleanups: remove unused / under-used stuff..
Mar 10 2020, 4:55 PM

Mar 9 2020

scottl accepted D23859: [aacraid] Handle both AIF and SYNC interrupts.
Mar 9 2020, 6:24 PM

Mar 1 2020

scottl committed rS358490: Add a quirk for the WDC Green series of SSDs to disable NCQ TRIM, as this.
Add a quirk for the WDC Green series of SSDs to disable NCQ TRIM, as this
Mar 1 2020, 6:03 PM
scottl committed rS358489: Add a quirk for the WDC Green series of SSDs to disable NCQ TRIM, as this.
Add a quirk for the WDC Green series of SSDs to disable NCQ TRIM, as this
Mar 1 2020, 6:02 PM

Feb 28 2020

scottl added a comment to D23852: scsi_scan_bus: ignore Initiator ID for SAS transport in.

FC isn't part of the problem here, so I ask that we stop reverting to it in the discussion.

Feb 28 2020, 6:59 PM

Feb 27 2020

scottl added a comment to D23852: scsi_scan_bus: ignore Initiator ID for SAS transport in.

I think it's much less likely that a SIM will internally map UINT_MAX to a valid target than what has already been demonstrated where it'll map an errant initiator_id to a valid target.

Feb 27 2020, 8:45 PM
scottl added a comment to D23852: scsi_scan_bus: ignore Initiator ID for SAS transport in.

Initiator ID has no meaning for SAS initiators, your comment about this function scanning targets that it should not within the domain of XPORT_SAS doesn't make sense to me. Numerical bus ID's don't even make sense within SAS topology, and at some point we need to fix all of this to use port UUIDs as the definitive identifier. We also need to fix the entire SIM API and model so that the buses are truly self-announcing and self-identifying, not this crummy hybrid we have of still pretending that the SAS transport is sequentially scanned like parallel SCSI is. But until that happens, what Andriy is proposing is a seat belt for XPORT_SAS initiator SIMs so that they don't shoot themselves in the foot due to the poor API that we've provided.

Feb 27 2020, 7:33 PM
scottl added a comment to D23852: scsi_scan_bus: ignore Initiator ID for SAS transport in.

The patch only impacts XPT_SCAN_TGT/XPT_SCAN_BUS operations that don't apply to target SIMs. Again, I see no reason not to proceed.

Feb 27 2020, 6:43 PM
scottl added a comment to D23852: scsi_scan_bus: ignore Initiator ID for SAS transport in.

This commit only affects the behavior of XPT_SCAN_TGT/XPT_SCAN_BUS and has no bearing on the behavior of target SIMs. It also is specific to XPORT_SAS, and has no effect on XPORT_FC. I see no reason for it not to proceed.

Feb 27 2020, 5:20 PM
scottl accepted D23852: scsi_scan_bus: ignore Initiator ID for SAS transport in.

This is good enough for now. Long term the transport needs to move to auto discovery instead of active scanning.

Feb 27 2020, 3:48 PM
scottl committed rS358366: Add a quirk for the WDC Green series of SSDs to disable NCQ TRIM, as this.
Add a quirk for the WDC Green series of SSDs to disable NCQ TRIM, as this
Feb 27 2020, 5:00 AM

Feb 17 2020

scottl committed rS358041: Fix syntax error from r357647. Adjust a variable name to make the use more.
Fix syntax error from r357647. Adjust a variable name to make the use more
Feb 17 2020, 8:12 PM

Feb 16 2020

scottl committed rS358009: Add rudamentary support for UFS to probe whether a block device supports the.
Add rudamentary support for UFS to probe whether a block device supports the
Feb 16 2020, 11:11 PM

Feb 10 2020

scottl added a reverting change for rS357711: Missed a file in r357710, add it here.: rS357730: Revert r357710 and 357711 until they can be debugged.
Feb 10 2020, 2:27 PM
scottl committed rS357730: Revert r357710 and 357711 until they can be debugged.
Revert r357710 and 357711 until they can be debugged
Feb 10 2020, 2:27 PM
scottl committed rS357711: Missed a file in r357710, add it here..
Missed a file in r357710, add it here.
Feb 10 2020, 12:26 AM
scottl committed rS357710: Add rudamentary support for UFS to probe whether a block device supports the.
Add rudamentary support for UFS to probe whether a block device supports the
Feb 10 2020, 12:23 AM

Feb 7 2020

scottl committed rS357651: Advertise the MPI Message Version that's contained in the IOCFacts message.
Advertise the MPI Message Version that's contained in the IOCFacts message
Feb 7 2020, 12:16 PM
scottl committed rS357650: Touch up some of the iocfacts fields.
Touch up some of the iocfacts fields
Feb 7 2020, 11:48 AM
scottl committed rS357647: Ever since the block layer expanded its command syntax beyond just.
Ever since the block layer expanded its command syntax beyond just
Feb 7 2020, 9:22 AM
scottl added a comment to D23541: Make BIO_SPEEDUP opt-in.
In D23541#516975, @mjg wrote:

In that case what about the console spam? I presume messages of this sort:

g_vfs_done():md10a[UNKNOWN()]error = 45

stem precisely from this. This happens to really spam the console for me when e.g., running stress2 when at least for this case it should never print anything. iow it looks like a design error that that devices which don't support something can get a request AND fail resulting in an error message.

Here is an example from pho's log: https://people.freebsd.org/~pho/stress/log/mark125.txt

Feb 7 2020, 8:07 AM
scottl added a comment to D23541: Make BIO_SPEEDUP opt-in.
In D23541#516964, @imp wrote:

I agree with Alexander, I really don't like that this perpetuates bad design.

So the proper fix is to fix all the disk drivers to just return op not supported?

Feb 7 2020, 7:13 AM
scottl requested changes to D23541: Make BIO_SPEEDUP opt-in.

I agree with Alexander, I really don't like that this perpetuates bad design.

Feb 7 2020, 5:33 AM

Jan 30 2020

scottl added a comment to D23417: Export the current da flags as bitfield.

Also, this should be MFC'd to 12 and even 11. With that, you can remove in 13 instead of waiting for 14

Jan 30 2020, 2:26 AM
scottl requested changes to D23417: Export the current da flags as bitfield.

My recommendation is to change the rotating and unmapped sysctls to be SYSCTL_PROC, and have them read the flag. That way you can retire the fields out of the softc now.

Jan 30 2020, 1:54 AM

Jan 15 2020

scottl committed rS356762: Fix a spacing error from the previous commit for -ll mode. Add a little.
Fix a spacing error from the previous commit for -ll mode. Add a little
Jan 15 2020, 4:47 PM

Jan 2 2020

scottl committed rS356267: Add a compact columnar output format, available by specifying a second '-l'.
Add a compact columnar output format, available by specifying a second '-l'
Jan 2 2020, 6:56 AM

Dec 26 2019

scottl committed rS356098: Abstract the locking for PCIe hotplug. It still uses Giant so there's.
Abstract the locking for PCIe hotplug. It still uses Giant so there's
Dec 26 2019, 9:00 PM

Dec 24 2019

scottl committed rS356052: Convert the mpr driver to use busdma templates..
Convert the mpr driver to use busdma templates.
Dec 24 2019, 2:50 PM
scottl closed D22906: Simplify busdma tag creation.
Dec 24 2019, 2:50 PM
scottl committed rS356050: Introduce the concept of busdma tag templates. A template can be allocated.
Introduce the concept of busdma tag templates. A template can be allocated
Dec 24 2019, 2:50 PM
scottl committed rS356051: Bump __FreeBSD_version for the addition of busdma templates..
Bump __FreeBSD_version for the addition of busdma templates.
Dec 24 2019, 2:50 PM

Dec 23 2019

scottl updated the diff for D22906: Simplify busdma tag creation.

Change function names for better consistency. Add bus_dma_template_clone().
Update the man page.

Dec 23 2019, 7:54 PM
scottl added a comment to D22906: Simplify busdma tag creation.

I also have an large update to bus_dma.9 that I'll add to the review.

Dec 23 2019, 7:26 PM
scottl added a comment to D22906: Simplify busdma tag creation.

I already changed the names in an upcoming revision; I agree that simple wasn't a good name. For the purposes of cloning an existing tag, what I'd propose is to have a function, bus_dma_template_clone(*template, *dmat) that serializes the opaque fields of the tag back into a template, then lets you optionally modify the template, and then turn it into a new tag with bus_dma_template_tag(*template, *tag). I'll code that up and submit it in the next patch.

Dec 23 2019, 7:25 PM
scottl updated the diff for D22906: Simplify busdma tag creation.

Switch to a typedef for the template. Be type-correct with
NULL field assignments.

Dec 23 2019, 1:53 AM
scottl added a reviewer for D22906: Simplify busdma tag creation: mmacy.
Dec 23 2019, 1:16 AM

Dec 22 2019

scottl created D22906: Simplify busdma tag creation.
Dec 22 2019, 9:56 PM

Dec 14 2019

scottl accepted D22809: Implement a system-wide limit or da and ada devices for delete..
Dec 14 2019, 12:14 AM

Dec 13 2019

scottl committed rS355741: Add accessors for the Vendor Specific Extended Capability (VSEC).
Add accessors for the Vendor Specific Extended Capability (VSEC)
Dec 13 2019, 11:47 PM
scottl closed D22808: Expand handling of the PCI Vendor ecap.
Dec 13 2019, 11:47 PM
scottl added inline comments to D22808: Expand handling of the PCI Vendor ecap.
Dec 13 2019, 11:41 PM
scottl created D22808: Expand handling of the PCI Vendor ecap.
Dec 13 2019, 10:59 PM
scottl committed rS355701: Merge r355134,355375,355589.
Merge r355134,355375,355589
Dec 13 2019, 6:54 AM
scottl committed rS355698: Merge r355134,355375,355589.
Merge r355134,355375,355589
Dec 13 2019, 5:29 AM

Dec 10 2019

scottl committed rS355589: Fix the TAA state machine to do the right thing when the TAA.
Fix the TAA state machine to do the right thing when the TAA
Dec 10 2019, 6:57 PM

Dec 6 2019

scottl committed rS355440: MFC r349184. This fixing PCI passthrough via VT-d on modern chipsets with.
MFC r349184. This fixing PCI passthrough via VT-d on modern chipsets with
Dec 6 2019, 9:50 AM
scottl committed rS355436: Move the mds, irbs, and ssb mitigation knobs into machdep.mitigations..
Move the mds, irbs, and ssb mitigation knobs into machdep.mitigations.
Dec 6 2019, 2:43 AM
scottl closed D22590: Place IBRS, SSB, and MDS into the machdep.mitigations tree.
Dec 6 2019, 2:43 AM

Dec 5 2019

scottl committed rS355429: Add support for new sound HDA hardware.
Add support for new sound HDA hardware
Dec 5 2019, 7:40 PM

Dec 2 2019

scottl committed rS355310: I took over mentorship of Scott Philips a while ago, update the mentors.
I took over mentorship of Scott Philips a while ago, update the mentors
Dec 2 2019, 10:15 PM

Nov 28 2019

scottl created D22590: Place IBRS, SSB, and MDS into the machdep.mitigations tree.
Nov 28 2019, 6:37 AM
scottl committed rS355164: Remove the trm(4) driver.
Remove the trm(4) driver
Nov 28 2019, 2:32 AM
scottl updated the diff for D22575: Remove the trm driver.

Add ObsoleteFiles

Nov 28 2019, 12:12 AM

Nov 27 2019

scottl created D22575: Remove the trm driver.
Nov 27 2019, 7:15 PM
scottl committed rS355134: Clean up and clarify meta commentary on TAA. Add a state to denote.
Clean up and clarify meta commentary on TAA. Add a state to denote
Nov 27 2019, 7:12 PM

Nov 26 2019

scottl committed rS355118: Partially revert r355028. hpt27xx is not Giant-locked in FreeBSD 12.x,.
Partially revert r355028. hpt27xx is not Giant-locked in FreeBSD 12.x,
Nov 26 2019, 7:04 PM
scottl committed rS355114: Revert r355021. In my haste to grep for Giant, I missed that it was in.
Revert r355021. In my haste to grep for Giant, I missed that it was in
Nov 26 2019, 5:26 PM

Nov 25 2019

scottl accepted D22539: Remove ifdefs for FreeBSD 6, 7, 8 and 9. Assume we're past that..
Nov 25 2019, 5:11 AM

Nov 24 2019

scottl accepted D22529: bsd-family-tree: add several new entries.
Nov 24 2019, 7:52 AM
scottl added a reviewer for D22529: bsd-family-tree: add several new entries: scottl.
Nov 24 2019, 7:47 AM

Nov 23 2019

scottl committed rS355028: MFC 355012 and 355021. Mark trm and hpt27xx for removal in 13.0.
MFC 355012 and 355021. Mark trm and hpt27xx for removal in 13.0
Nov 23 2019, 7:06 AM

Nov 22 2019

scottl committed rS355021: Mark hpt27xx for removal in 13.0; all CAM drivers will be Giant-free by then..
Mark hpt27xx for removal in 13.0; all CAM drivers will be Giant-free by then.
Nov 22 2019, 8:23 PM
scottl committed rS355012: Schedule the trm(4) driver for removal. It relies on Giant and thus has.
Schedule the trm(4) driver for removal. It relies on Giant and thus has
Nov 22 2019, 6:51 PM
scottl committed rS355009: Remove NEEDGIANT from the scsi_sg /dev node. It likely has not been.
Remove NEEDGIANT from the scsi_sg /dev node. It likely has not been
Nov 22 2019, 6:18 PM

Nov 18 2019

scottl accepted D22431: Add x86 msr tweak KPI..
Nov 18 2019, 7:59 PM
scottl added a comment to D22431: Add x86 msr tweak KPI..

Minor request, if the MSR_OP_LOCAL/SCHED/RENDEVOUS opcodes are mutually exclusive from each other then don't make them be bitfield definitions, just have them be sequential numbers.

Nov 18 2019, 4:33 PM
scottl added a comment to D22431: Add x86 msr tweak KPI..

This looks great. My only complaint is using the name "tweak", I think it's too casual and poorly descriptive. Maybe x86_program_msr_smp()?

Nov 18 2019, 6:25 AM

Nov 16 2019

scottl committed rS354764: MFC r354759:.
MFC r354759:
Nov 16 2019, 12:52 AM
scottl committed rS354763: MFC r354759:.
MFC r354759:
Nov 16 2019, 12:36 AM
scottl committed rS354762: MFC r354756:.
MFC r354756:
Nov 16 2019, 12:33 AM
scottl committed rS354761: Partially revert r354760, it included a patch that wasn't ready yet..
Partially revert r354760, it included a patch that wasn't ready yet.
Nov 16 2019, 12:32 AM
scottl committed rS354760: MFC r354756:.
MFC r354756:
Nov 16 2019, 12:29 AM
scottl committed rS354759: TSX Asynchronous Abort mitigation for Intel CVE-2019-11135..
TSX Asynchronous Abort mitigation for Intel CVE-2019-11135.
Nov 16 2019, 12:26 AM

Nov 15 2019

scottl updated the diff for D22374: TSX Asynchronous Abort Mitigation.

Move taa into its own sysctl node, machdep.mitigations.taa.(enable|state)

Nov 15 2019, 11:45 PM
scottl committed rS354756: Create a new sysctl subtree, machdep.mitigations. Its purpose is to organize.
Create a new sysctl subtree, machdep.mitigations. Its purpose is to organize
Nov 15 2019, 11:27 PM
scottl added inline comments to D22374: TSX Asynchronous Abort Mitigation.
Nov 15 2019, 11:12 PM
scottl updated the diff for D22374: TSX Asynchronous Abort Mitigation.

Move the sysctls and tunables to the new machdep.mitigations
tree. Rename the code in accordance, and rename the sysctls
themselves to have neutral wording.

Nov 15 2019, 11:10 PM
scottl added inline comments to D22374: TSX Asynchronous Abort Mitigation.
Nov 15 2019, 9:13 PM
scottl added inline comments to D22374: TSX Asynchronous Abort Mitigation.
Nov 15 2019, 8:41 PM
scottl added inline comments to D22374: TSX Asynchronous Abort Mitigation.
Nov 15 2019, 8:39 PM
scottl updated the diff for D22374: TSX Asynchronous Abort Mitigation.

Address several comments

Nov 15 2019, 8:37 PM
scottl added inline comments to D22374: TSX Asynchronous Abort Mitigation.
Nov 15 2019, 8:28 PM