- User Since
- Jun 4 2014, 7:07 AM (351 w, 3 d)
Wed, Feb 24
Tue, Feb 23
I won't be able to go back and test this for at least a few more days. However, when I tested the atomic_load_int() suggestion over the weekend, I got a really weird panic instead. I didn't dig into it because of other time pressures, but it does make me worry about compiler bugs and other weirdness, whereas the membar is proven to work for now.
Sat, Feb 20
Tue, Feb 9
Thank you for doing this. My main suggestion is to fix mps_read_extended_config_page so it returns IOCStatus already byte-swapped, which will eliminate a lot of the other diffs. I also recommend looking at mps_cmd.c and fixing code that is under #ifdef USE_MPT_IOCTLS as well as not
Tue, Feb 2
Dec 31 2020
I'm good with this, actually thought that Alexander had already done it. This should go into a release not in case there are people maintaining out-of-tree drivers.
Dec 24 2020
ACK, I'll look at it over the weekend.