Page MenuHomeFreeBSD

pf: store L4 headers in pf_pdesc
ClosedPublic

Authored by kp on Thu, Jun 10, 6:14 PM.

Details

Summary

Rather than pointers to the headers store full copies. This brings us
slightly closer to what OpenBSD does, and also makes more sense than
storing pointers to stack variable copies of the headers.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kp requested review of this revision.Thu, Jun 10, 6:14 PM
donner added inline comments.
sys/net/pfvar.h
924

Seems to be used as a pointer to a variable length data space. The common idiom is char any[0]. This also avoids to use &complex_entry.any instead of complex_entry.any.

This revision is now accepted and ready to land.Fri, Jun 11, 9:35 AM
This revision was automatically updated to reflect the committed changes.