User Details
User Details
- User Since
- Sep 26 2019, 9:24 AM (74 w, 5 d)
Fri, Feb 26
Fri, Feb 26
donner added a comment to D28645: Remove classful masks from interface addition code..
netgraph/ng_car: Add color marking code
netgraph/ng_car: Add color marking code
netgraph/ng_car: Add color marking code
donner added inline comments to D28933: wireguard: allow to set IPv6 endpoint.
Thu, Feb 25
Thu, Feb 25
donner committed R10:d65b86dd9325: netgraph/ng_nat: Add RFC 6598/Carrier Grade NAT support (authored by nc).
netgraph/ng_nat: Add RFC 6598/Carrier Grade NAT support
donner committed R10:b2c14db4f8fd: netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph type (authored by donner).
netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph type
donner committed R10:ea5ebe9cde3c: ether: add older ethertype definitions for QinQ (authored by philip).
ether: add older ethertype definitions for QinQ
donner committed R10:e600af01eeba: netgraph/ng_nat: Add RFC 6598/Carrier Grade NAT support (authored by nc).
netgraph/ng_nat: Add RFC 6598/Carrier Grade NAT support
donner committed R10:8790393123f1: netgraph/ng_nat: Add RFC 6598/Carrier Grade NAT support (authored by nc).
netgraph/ng_nat: Add RFC 6598/Carrier Grade NAT support
donner committed R10:d02939510276: netgraph/ng_bridge: Add counters for the first link, too (authored by donner).
netgraph/ng_bridge: Add counters for the first link, too
donner committed R10:1c0b19f9966d: netgraph/ng_bridge: Document staleness in multithreaded operation (authored by donner).
netgraph/ng_bridge: Document staleness in multithreaded operation
donner committed R10:9a972281e7f1: netgraph/ng_bridge: Merge internal structures (authored by donner).
netgraph/ng_bridge: Merge internal structures
donner committed R10:3de9c792eebe: netgraph/ng_bridge: Make simple internal functions read-only (authored by donner).
netgraph/ng_bridge: Make simple internal functions read-only
donner committed R10:bfe0d8ca0b88: netgraph/ng_bridge: switch stats to counter framework (authored by donner).
netgraph/ng_bridge: switch stats to counter framework
donner committed R10:d148e95cdfb7: netgraph/ng_bridge: Derive forwarding mode from first attached hook (authored by donner).
netgraph/ng_bridge: Derive forwarding mode from first attached hook
donner committed R10:08f47db5d580: netgraph/ng_bridge: Introduce "uplink" ports without MAC learning (authored by donner).
netgraph/ng_bridge: Introduce "uplink" ports without MAC learning
donner committed R10:522a0b7d029f: netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph type (authored by donner).
netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph type
donner committed R10:5d66edf463a0: ether: add older ethertype definitions for QinQ (authored by philip).
ether: add older ethertype definitions for QinQ
donner committed R10:a0e2fe87031a: netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph type (authored by donner).
netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph type
Tue, Feb 23
Tue, Feb 23
donner edited reviewers for D28894: tests/sys/netgraph: Tell kyua that perl is required, added: kp; removed: donner.
Mon, Feb 22
Mon, Feb 22
donner added inline comments to D28859: bridge: Remove members when assigned to a new vnet.
donner added a comment to D28860: arp/nd: Cope with late calls to iflladdr_event.
Would it not better to not setting the callback on shutdown?
donner added inline comments to D28859: bridge: Remove members when assigned to a new vnet.
Straightforward.
This will result in STP over Vlan (or PVST ala Cisco) if applied to vlan interfaces.
LTGM
donner committed R10:511690b108f8: ng_bridge.4: Use more suitable mandoc macros (authored by donner).
ng_bridge.4: Use more suitable mandoc macros
donner committed R10:dcb4190179bd: netgraph/ng_bridge: Add counters for the first link, too (authored by donner).
netgraph/ng_bridge: Add counters for the first link, too
donner committed R10:88e916bff035: netgraph/ng_bridge: Document staleness in multithreaded operation (authored by donner).
netgraph/ng_bridge: Document staleness in multithreaded operation
donner committed R10:0952f69003e8: netgraph/ng_bridge: Merge internal structures (authored by donner).
netgraph/ng_bridge: Merge internal structures
donner committed R10:1e2c1b762275: netgraph/ng_bridge: Make simple internal functions read-only (authored by donner).
netgraph/ng_bridge: Make simple internal functions read-only
donner committed R10:882cbdeb21dc: netgraph/ng_bridge: Introduce "uplink" ports without MAC learning (authored by donner).
netgraph/ng_bridge: Introduce "uplink" ports without MAC learning
donner committed R10:8135f3f2fcd1: netgraph/ng_bridge: Derive forwarding mode from first attached hook (authored by donner).
netgraph/ng_bridge: Derive forwarding mode from first attached hook
donner committed R10:d7187b4b1c70: netgraph/ng_bridge: switch stats to counter framework (authored by donner).
netgraph/ng_bridge: switch stats to counter framework
Sun, Feb 21
Sun, Feb 21
donner added a comment to D28837: Simplify ifa/ifp refcounting in the routing stack..
I like, that the ugly "reference" paramenter is gone. It was never used.
Fri, Feb 19
Fri, Feb 19
donner added a comment to D28804: Fix `arp -d` / `ndp -d`..
Is this a problem of the kernel or the laziness of the arp code?
Thu, Feb 18
Thu, Feb 18
donner added a comment to D28516: netgraph/ng_bridge: learn MACs via control message.
donner added inline comments to D28516: netgraph/ng_bridge: learn MACs via control message.
Wed, Feb 17
Wed, Feb 17
donner updated the diff for D28559: netgraph/ng_bridge: move MACs via control message.
- Document behavior in the man page.
donner updated the diff for D28516: netgraph/ng_bridge: learn MACs via control message.
- Fix man page
donner updated the diff for D28516: netgraph/ng_bridge: learn MACs via control message.
- Add documentation in man page
Tue, Feb 16
Tue, Feb 16
donner committed R10:591e21210e35: netgraph/ng_source: Allow ng_source to inject into any netgraph network (authored by donner).
netgraph/ng_source: Allow ng_source to inject into any netgraph network
Mon, Feb 15
Mon, Feb 15
donner added inline comments to D28673: Make in_localip_more() fib-aware..
donner added inline comments to D28668: Fix dst/netmask handling in routing socket code..
Sun, Feb 14
Sun, Feb 14
Sat, Feb 13
Sat, Feb 13
donner added inline comments to D28650: pf: Slightly relax pf_rule_addr validation.
donner added inline comments to D28647: Enforce net epoch in in6_selectsrc()..
donner added a comment to D28645: Remove classful masks from interface addition code..
donner added a comment to D28639: Add ifa_try_ref() to simplify ifa handling inside epoch..
Is the destroy callout guaranteed to run outside (or on the border) of epoch? Can this callout check the refcount and chase to abort itself?
Fri, Feb 12
Fri, Feb 12
donner updated the test plan for D28559: netgraph/ng_bridge: move MACs via control message.
donner committed R10:dd8f4fcd270d: netgraph/ng_source: Switch queuing framework (authored by donner).
netgraph/ng_source: Switch queuing framework
donner committed R10:752a51183695: netgraph/ng_bridge: Deactivate old table ABI (authored by donner).
netgraph/ng_bridge: Deactivate old table ABI
Thu, Feb 11
Thu, Feb 11
Inverted logic changes are hard to review.
donner retitled D28601: netgraph/ng_bridge: Avoid cache thrashing from netgraph&/ng_bridge: Avoid cache thrashing to netgraph/ng_bridge: Avoid cache thrashing.
donner requested review of D28601: netgraph/ng_bridge: Avoid cache thrashing.
donner added inline comments to D28559: netgraph/ng_bridge: move MACs via control message.
donner updated the diff for D28559: netgraph/ng_bridge: move MACs via control message.
- Reword some comments.
- Fix loopCount setting.
donner updated the diff for D28559: netgraph/ng_bridge: move MACs via control message.
- Fix move logic after rebase to modifications to the parent review.
donner updated the diff for D28516: netgraph/ng_bridge: learn MACs via control message.
- Expose error handling.
donner added inline comments to D28516: netgraph/ng_bridge: learn MACs via control message.
donner updated the diff for D28516: netgraph/ng_bridge: learn MACs via control message.
- New code uses current best practise for constants.
donner updated the diff for D28516: netgraph/ng_bridge: learn MACs via control message.
- Sanity checks on input
donner updated the diff for D28559: netgraph/ng_bridge: move MACs via control message.
- rebase after changes
donner updated the diff for D28516: netgraph/ng_bridge: learn MACs via control message.
- Rebase after some changes
Wed, Feb 10
Wed, Feb 10
donner committed R10:3c958f5fdfc0: netgraph/ng_bridge: Add counters for the first link, too (authored by donner).
netgraph/ng_bridge: Add counters for the first link, too
donner updated the diff for D28537: netgraph/ng_bridge: Add counters for the first link, too..
- Fix use after lost reference.
donner added a comment to D28537: netgraph/ng_bridge: Add counters for the first link, too..
Compiles fine (backported to stable/13), but causes kernel panic
donner updated the summary of D28537: netgraph/ng_bridge: Add counters for the first link, too..
donner updated the diff for D28537: netgraph/ng_bridge: Add counters for the first link, too..
- Factor out a send and statistic routine
Tue, Feb 9
Tue, Feb 9
Overcome by D28559
All write access to this variable will be moved to calls under the WRITER lock.
donner updated the diff for D28144: netgraph/ng_bridge: switch loopCount to counter framework.
Rebase
donner added a reviewer for D28537: netgraph/ng_bridge: Add counters for the first link, too.: network.
donner retitled D28559: netgraph/ng_bridge: move MACs via control message from netgraph/ng_bridge: move MAC via control message to netgraph/ng_bridge: move MACs via control message.
donner added a comment to D28545: netgraph/ng_bridge: Merge internal host entry structures..
donner requested review of D28559: netgraph/ng_bridge: move MACs via control message.
donner committed R10:011b7317dbb5: netgraph/ng_bridge: Document staleness in multithreaded operation (authored by donner).
netgraph/ng_bridge: Document staleness in multithreaded operation
donner committed R10:ccf4cd2e7830: netgraph/ng_bridge: Merge internal structures (authored by donner).
netgraph/ng_bridge: Merge internal structures
donner added inline comments to D28545: netgraph/ng_bridge: Merge internal host entry structures..
donner added a comment to D28545: netgraph/ng_bridge: Merge internal host entry structures..
donner added a comment to D28546: netgraph/ng_bridge: Document staleness in multithreaded operation.
OTOH it's bad, because it prevents the code from running under const constraints.
donner retitled D28546: netgraph/ng_bridge: Document staleness in multithreaded operation from netgraph/ng_bridge: Switch staleness to counter framework to netgraph/ng_bridge: Document staleness in multithreaded operation.
donner updated the diff for D28546: netgraph/ng_bridge: Document staleness in multithreaded operation.
- Revert "Switch staleness to counter framework."
- Comment why it's safe to do so.
donner added a comment to D28546: netgraph/ng_bridge: Document staleness in multithreaded operation.
donner added inline comments to D28549: Fix blackhole/reject routes..
Mon, Feb 8
Mon, Feb 8
donner added a reviewer for D28546: netgraph/ng_bridge: Document staleness in multithreaded operation: network.
donner requested review of D28546: netgraph/ng_bridge: Document staleness in multithreaded operation.
donner updated the diff for D28545: netgraph/ng_bridge: Merge internal host entry structures..
- Get rid of "hent" instead of "host".
donner added a reviewer for D28545: netgraph/ng_bridge: Merge internal host entry structures.: network.
donner requested review of D28545: netgraph/ng_bridge: Merge internal host entry structures..