Page MenuHomeFreeBSD

donner (Lutz Donnerhacke)
User

Projects

User Details

User Since
Sep 26 2019, 9:24 AM (74 w, 5 d)

Recent Activity

Fri, Feb 26

donner added a comment to D28645: Remove classful masks from interface addition code..
  1. Keep the historical behavior.
Fri, Feb 26, 5:16 PM
donner accepted D28933: wireguard: allow to set IPv6 endpoint.
Fri, Feb 26, 2:12 PM
donner committed R10:21e24a8f01f7: netgraph/ng_car: Add color marking code (authored by donner).
netgraph/ng_car: Add color marking code
Fri, Feb 26, 12:38 PM
donner committed R10:d88ac710ce58: netgraph/ng_car: Add color marking code (authored by donner).
netgraph/ng_car: Add color marking code
Fri, Feb 26, 12:35 PM
donner committed R10:26be401728dc: netgraph/ng_car: Add color marking code (authored by donner).
netgraph/ng_car: Add color marking code
Fri, Feb 26, 12:31 PM
donner added inline comments to D28933: wireguard: allow to set IPv6 endpoint.
Fri, Feb 26, 7:27 AM

Thu, Feb 25

donner committed R10:d65b86dd9325: netgraph/ng_nat: Add RFC 6598/Carrier Grade NAT support (authored by nc).
netgraph/ng_nat: Add RFC 6598/Carrier Grade NAT support
Thu, Feb 25, 10:23 AM
donner committed R10:b2c14db4f8fd: netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph type (authored by donner).
netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph type
Thu, Feb 25, 10:13 AM
donner committed R10:ea5ebe9cde3c: ether: add older ethertype definitions for QinQ (authored by philip).
ether: add older ethertype definitions for QinQ
Thu, Feb 25, 10:13 AM
donner committed R10:e600af01eeba: netgraph/ng_nat: Add RFC 6598/Carrier Grade NAT support (authored by nc).
netgraph/ng_nat: Add RFC 6598/Carrier Grade NAT support
Thu, Feb 25, 10:11 AM
donner committed R10:8790393123f1: netgraph/ng_nat: Add RFC 6598/Carrier Grade NAT support (authored by nc).
netgraph/ng_nat: Add RFC 6598/Carrier Grade NAT support
Thu, Feb 25, 10:09 AM
donner committed R10:d02939510276: netgraph/ng_bridge: Add counters for the first link, too (authored by donner).
netgraph/ng_bridge: Add counters for the first link, too
Thu, Feb 25, 10:05 AM
donner committed R10:1c0b19f9966d: netgraph/ng_bridge: Document staleness in multithreaded operation (authored by donner).
netgraph/ng_bridge: Document staleness in multithreaded operation
Thu, Feb 25, 10:02 AM
donner committed R10:9a972281e7f1: netgraph/ng_bridge: Merge internal structures (authored by donner).
netgraph/ng_bridge: Merge internal structures
Thu, Feb 25, 10:01 AM
donner committed R10:3de9c792eebe: netgraph/ng_bridge: Make simple internal functions read-only (authored by donner).
netgraph/ng_bridge: Make simple internal functions read-only
Thu, Feb 25, 8:16 AM
donner committed R10:bfe0d8ca0b88: netgraph/ng_bridge: switch stats to counter framework (authored by donner).
netgraph/ng_bridge: switch stats to counter framework
Thu, Feb 25, 8:16 AM
donner committed R10:d148e95cdfb7: netgraph/ng_bridge: Derive forwarding mode from first attached hook (authored by donner).
netgraph/ng_bridge: Derive forwarding mode from first attached hook
Thu, Feb 25, 8:16 AM
donner committed R10:08f47db5d580: netgraph/ng_bridge: Introduce "uplink" ports without MAC learning (authored by donner).
netgraph/ng_bridge: Introduce "uplink" ports without MAC learning
Thu, Feb 25, 8:15 AM
donner committed R10:522a0b7d029f: netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph type (authored by donner).
netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph type
Thu, Feb 25, 8:05 AM
donner accepted D28916: bridgestp: Ensure we send STP on VLAN interfaces.
Thu, Feb 25, 8:03 AM
donner committed R10:5d66edf463a0: ether: add older ethertype definitions for QinQ (authored by philip).
ether: add older ethertype definitions for QinQ
Thu, Feb 25, 7:54 AM
donner committed R10:a0e2fe87031a: netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph type (authored by donner).
netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph type
Thu, Feb 25, 7:53 AM

Tue, Feb 23

donner edited reviewers for D28894: tests/sys/netgraph: Tell kyua that perl is required, added: kp; removed: donner.
Tue, Feb 23, 4:50 PM

Mon, Feb 22

donner accepted D28860: arp/nd: Cope with late calls to iflladdr_event.
Mon, Feb 22, 7:21 PM
donner accepted D28859: bridge: Remove members when assigned to a new vnet.

LTGM

Mon, Feb 22, 7:20 PM
donner added inline comments to D28859: bridge: Remove members when assigned to a new vnet.
Mon, Feb 22, 7:00 PM
donner added a comment to D28860: arp/nd: Cope with late calls to iflladdr_event.

Would it not better to not setting the callback on shutdown?

Mon, Feb 22, 6:02 PM
donner added inline comments to D28859: bridge: Remove members when assigned to a new vnet.
Mon, Feb 22, 5:59 PM
donner accepted D28858: bridge/stp: Ensure we enter NET_EPOCH whenever we can send traffic.

Straightforward.

Mon, Feb 22, 5:52 PM
donner accepted D28857: bridge: Support STP on VLAN devices.

This will result in STP over Vlan (or PVST ala Cisco) if applied to vlan interfaces.
LTGM

Mon, Feb 22, 5:49 PM
donner committed R10:511690b108f8: ng_bridge.4: Use more suitable mandoc macros (authored by donner).
ng_bridge.4: Use more suitable mandoc macros
Mon, Feb 22, 8:42 AM
donner committed R10:dcb4190179bd: netgraph/ng_bridge: Add counters for the first link, too (authored by donner).
netgraph/ng_bridge: Add counters for the first link, too
Mon, Feb 22, 8:39 AM
donner committed R10:88e916bff035: netgraph/ng_bridge: Document staleness in multithreaded operation (authored by donner).
netgraph/ng_bridge: Document staleness in multithreaded operation
Mon, Feb 22, 8:39 AM
donner committed R10:0952f69003e8: netgraph/ng_bridge: Merge internal structures (authored by donner).
netgraph/ng_bridge: Merge internal structures
Mon, Feb 22, 8:38 AM
donner committed R10:1e2c1b762275: netgraph/ng_bridge: Make simple internal functions read-only (authored by donner).
netgraph/ng_bridge: Make simple internal functions read-only
Mon, Feb 22, 8:38 AM
donner committed R10:882cbdeb21dc: netgraph/ng_bridge: Introduce "uplink" ports without MAC learning (authored by donner).
netgraph/ng_bridge: Introduce "uplink" ports without MAC learning
Mon, Feb 22, 8:38 AM
donner committed R10:8135f3f2fcd1: netgraph/ng_bridge: Derive forwarding mode from first attached hook (authored by donner).
netgraph/ng_bridge: Derive forwarding mode from first attached hook
Mon, Feb 22, 8:38 AM
donner committed R10:d7187b4b1c70: netgraph/ng_bridge: switch stats to counter framework (authored by donner).
netgraph/ng_bridge: switch stats to counter framework
Mon, Feb 22, 8:38 AM

Sun, Feb 21

donner added a comment to D28837: Simplify ifa/ifp refcounting in the routing stack..

I like, that the ugly "reference" paramenter is gone. It was never used.

Sun, Feb 21, 5:40 PM

Fri, Feb 19

donner added a comment to D28804: Fix `arp -d` / `ndp -d`..

Is this a problem of the kernel or the laziness of the arp code?

Fri, Feb 19, 8:33 PM

Thu, Feb 18

donner added a comment to D28516: netgraph/ng_bridge: learn MACs via control message.

Did you mean D28559?

Thu, Feb 18, 7:41 PM
donner added inline comments to D28516: netgraph/ng_bridge: learn MACs via control message.
Thu, Feb 18, 6:20 PM

Wed, Feb 17

donner updated the diff for D28559: netgraph/ng_bridge: move MACs via control message.
  • Document behavior in the man page.
Wed, Feb 17, 8:08 PM
donner updated the diff for D28516: netgraph/ng_bridge: learn MACs via control message.
  • Fix man page
Wed, Feb 17, 8:00 PM
donner updated the diff for D28516: netgraph/ng_bridge: learn MACs via control message.
  • Add documentation in man page
Wed, Feb 17, 7:57 PM

Tue, Feb 16

donner committed R10:591e21210e35: netgraph/ng_source: Allow ng_source to inject into any netgraph network (authored by donner).
netgraph/ng_source: Allow ng_source to inject into any netgraph network
Tue, Feb 16, 8:28 AM
donner accepted D28668: Fix dst/netmask handling in routing socket code..
Tue, Feb 16, 8:12 AM
donner accepted D28673: Make in_localip_more() fib-aware..
Tue, Feb 16, 8:10 AM

Mon, Feb 15

donner added inline comments to D28673: Make in_localip_more() fib-aware..
Mon, Feb 15, 6:57 AM
donner added inline comments to D28668: Fix dst/netmask handling in routing socket code..
Mon, Feb 15, 6:54 AM

Sun, Feb 14

donner accepted D28650: pf: Slightly relax pf_rule_addr validation.
Sun, Feb 14, 11:16 AM

Sat, Feb 13

donner added inline comments to D28650: pf: Slightly relax pf_rule_addr validation.
Sat, Feb 13, 7:53 PM
donner added inline comments to D28647: Enforce net epoch in in6_selectsrc()..
Sat, Feb 13, 3:28 PM
donner added a comment to D28645: Remove classful masks from interface addition code..

Infact it is probalby safer to assume a /24 than a /32.

Sat, Feb 13, 3:20 PM
donner added a comment to D28639: Add ifa_try_ref() to simplify ifa handling inside epoch..

Is the destroy callout guaranteed to run outside (or on the border) of epoch? Can this callout check the refcount and chase to abort itself?

Sat, Feb 13, 9:18 AM

Fri, Feb 12

donner updated the test plan for D28559: netgraph/ng_bridge: move MACs via control message.
Fri, Feb 12, 5:41 PM
donner committed R10:dd8f4fcd270d: netgraph/ng_source: Switch queuing framework (authored by donner).
netgraph/ng_source: Switch queuing framework
Fri, Feb 12, 8:09 AM
donner committed R10:752a51183695: netgraph/ng_bridge: Deactivate old table ABI (authored by donner).
netgraph/ng_bridge: Deactivate old table ABI
Fri, Feb 12, 8:03 AM

Thu, Feb 11

donner accepted D28602: Fix interface route addition with net/bird..

Inverted logic changes are hard to review.

Thu, Feb 11, 11:40 PM
donner retitled D28601: netgraph/ng_bridge: Avoid cache thrashing from netgraph&/ng_bridge: Avoid cache thrashing to netgraph/ng_bridge: Avoid cache thrashing.
Thu, Feb 11, 11:13 PM
donner requested review of D28601: netgraph/ng_bridge: Avoid cache thrashing.
Thu, Feb 11, 11:13 PM
donner added inline comments to D28559: netgraph/ng_bridge: move MACs via control message.
Thu, Feb 11, 10:53 PM
donner updated the diff for D28559: netgraph/ng_bridge: move MACs via control message.
  • Reword some comments.
  • Fix loopCount setting.
Thu, Feb 11, 10:52 PM
donner updated the diff for D28559: netgraph/ng_bridge: move MACs via control message.
  • Fix move logic after rebase to modifications to the parent review.
Thu, Feb 11, 10:37 PM
donner updated the diff for D28516: netgraph/ng_bridge: learn MACs via control message.
  • Expose error handling.
Thu, Feb 11, 10:16 PM
donner added inline comments to D28516: netgraph/ng_bridge: learn MACs via control message.
Thu, Feb 11, 10:12 PM
donner updated the diff for D28516: netgraph/ng_bridge: learn MACs via control message.
  • New code uses current best practise for constants.
Thu, Feb 11, 10:11 PM
donner updated the diff for D28516: netgraph/ng_bridge: learn MACs via control message.
  • Sanity checks on input
Thu, Feb 11, 10:08 PM
donner updated the diff for D28559: netgraph/ng_bridge: move MACs via control message.
  • rebase after changes
Thu, Feb 11, 5:26 PM
donner updated the diff for D28516: netgraph/ng_bridge: learn MACs via control message.
  • Rebase after some changes
Thu, Feb 11, 5:24 PM

Wed, Feb 10

donner committed R10:3c958f5fdfc0: netgraph/ng_bridge: Add counters for the first link, too (authored by donner).
netgraph/ng_bridge: Add counters for the first link, too
Wed, Feb 10, 6:14 PM
donner closed D28537: netgraph/ng_bridge: Add counters for the first link, too..
Wed, Feb 10, 6:14 PM
donner updated the diff for D28537: netgraph/ng_bridge: Add counters for the first link, too..
  • Fix use after lost reference.
Wed, Feb 10, 11:14 AM
donner added a comment to D28537: netgraph/ng_bridge: Add counters for the first link, too..

Compiles fine (backported to stable/13), but causes kernel panic

Wed, Feb 10, 10:13 AM
donner updated the summary of D28537: netgraph/ng_bridge: Add counters for the first link, too..
Wed, Feb 10, 8:08 AM
donner updated the diff for D28537: netgraph/ng_bridge: Add counters for the first link, too..
  • Factor out a send and statistic routine
Wed, Feb 10, 8:04 AM
donner accepted D28549: Fix blackhole/reject routes..
Wed, Feb 10, 5:41 AM

Tue, Feb 9

donner abandoned D28144: netgraph/ng_bridge: switch loopCount to counter framework.

Overcome by D28559
All write access to this variable will be moved to calls under the WRITER lock.

Tue, Feb 9, 9:01 PM
donner updated the diff for D28144: netgraph/ng_bridge: switch loopCount to counter framework.

Rebase

Tue, Feb 9, 8:57 PM
donner added a reviewer for D28537: netgraph/ng_bridge: Add counters for the first link, too.: network.
Tue, Feb 9, 8:54 PM
donner retitled D28559: netgraph/ng_bridge: move MACs via control message from netgraph/ng_bridge: move MAC via control message to netgraph/ng_bridge: move MACs via control message.
Tue, Feb 9, 8:53 PM
donner added a comment to D28545: netgraph/ng_bridge: Merge internal host entry structures..
  • Get rid of "hent" instead of "host".

This types of change just cause lots of noise in this review that makes it harder to see the real change.

That's why this change is a secondary modification.
Please choose the relevant part in the revision tab "History"

I do not see what your saying, and what is committed is all of what appears here as a single commit, no seperation, and for that mater, not even a mention that you renamed hent -> host in the commit.

Tue, Feb 9, 8:16 PM
donner requested review of D28559: netgraph/ng_bridge: move MACs via control message.
Tue, Feb 9, 8:08 PM
donner committed R10:011b7317dbb5: netgraph/ng_bridge: Document staleness in multithreaded operation (authored by donner).
netgraph/ng_bridge: Document staleness in multithreaded operation
Tue, Feb 9, 7:25 PM
donner closed D28546: netgraph/ng_bridge: Document staleness in multithreaded operation.
Tue, Feb 9, 7:25 PM
donner closed D28545: netgraph/ng_bridge: Merge internal host entry structures..
Tue, Feb 9, 6:35 PM
donner committed R10:ccf4cd2e7830: netgraph/ng_bridge: Merge internal structures (authored by donner).
netgraph/ng_bridge: Merge internal structures
Tue, Feb 9, 6:35 PM
donner added inline comments to D28545: netgraph/ng_bridge: Merge internal host entry structures..
Tue, Feb 9, 3:26 PM
donner added a comment to D28545: netgraph/ng_bridge: Merge internal host entry structures..
  • Get rid of "hent" instead of "host".

This types of change just cause lots of noise in this review that makes it harder to see the real change.

Tue, Feb 9, 3:20 PM
donner added a comment to D28546: netgraph/ng_bridge: Document staleness in multithreaded operation.

OTOH it's bad, because it prevents the code from running under const constraints.

Tue, Feb 9, 11:38 AM
donner retitled D28546: netgraph/ng_bridge: Document staleness in multithreaded operation from netgraph/ng_bridge: Switch staleness to counter framework to netgraph/ng_bridge: Document staleness in multithreaded operation.
Tue, Feb 9, 11:36 AM
donner updated the diff for D28546: netgraph/ng_bridge: Document staleness in multithreaded operation.
  • Revert "Switch staleness to counter framework."
  • Comment why it's safe to do so.
Tue, Feb 9, 11:34 AM
donner added a comment to D28546: netgraph/ng_bridge: Document staleness in multithreaded operation.
In D28546#639111, @kp wrote:

I don't know if counter(9) makes sense here.

Tue, Feb 9, 8:42 AM
donner added inline comments to D28549: Fix blackhole/reject routes..
Tue, Feb 9, 7:36 AM

Mon, Feb 8

donner added a reviewer for D28546: netgraph/ng_bridge: Document staleness in multithreaded operation: network.
Mon, Feb 8, 10:13 PM
donner requested review of D28546: netgraph/ng_bridge: Document staleness in multithreaded operation.
Mon, Feb 8, 10:11 PM
donner updated the diff for D28545: netgraph/ng_bridge: Merge internal host entry structures..
  • Get rid of "hent" instead of "host".
Mon, Feb 8, 9:37 PM
donner added a reviewer for D28545: netgraph/ng_bridge: Merge internal host entry structures.: network.
Mon, Feb 8, 9:33 PM
donner requested review of D28545: netgraph/ng_bridge: Merge internal host entry structures..
Mon, Feb 8, 9:18 PM
donner closed D23840: netgraph/ng_base: Allow larger BINARY2ASCII conversions.
Mon, Feb 8, 1:36 PM