Page MenuHomeFreeBSD

donner (Lutz Donnerhacke)
User

Projects

User Details

User Since
Sep 26 2019, 9:24 AM (96 w, 5 d)

Recent Activity

Tue, Jul 27

donner accepted D31305: bridge tests: verify that we can't change MTU of bridge member interfaces.
Tue, Jul 27, 6:05 AM
donner accepted D31304: net: disallow MTU changes on bridge member interfaces.

Because this is an incompatible change to current behavior, it should be mentioned in the RELNOTES or UPDATEING

Tue, Jul 27, 6:03 AM

Sun, Jul 25

donner accepted D31302: rip: Add missing minimum length validation.

Good catch.

Sun, Jul 25, 10:29 PM

Fri, Jul 23

donner accepted D31289: bridge tests: test changing the bridge MTU.
Fri, Jul 23, 6:29 PM
donner accepted D31288: if_bridge: allow MTU changes.

LGTM

Fri, Jul 23, 6:25 PM

Thu, Jul 22

donner accepted D31275: vlan: deduplicate bpf_setpcp() and pf_ieee8021q_setpcp().

LGTM

Thu, Jul 22, 7:32 PM
donner added a comment to D31263: bpf: Add an ioctl to set the VLAN Priority on packets sent by bpf.

Do I understand correctly, that this is the first bpf-option to alter the packet in transit?
Usually I'd solve this problem by adding a simple netgraph network to the outgoing interface.

Thu, Jul 22, 6:22 AM

Wed, Jul 14

donner committed R10:5c55ab57c818: libalias: fix divide by zero causing panic (authored by se).
libalias: fix divide by zero causing panic
Wed, Jul 14, 11:55 AM
donner committed R10:791035c8da5e: libalias: fix divide by zero causing panic (authored by se).
libalias: fix divide by zero causing panic
Wed, Jul 14, 11:52 AM

Sat, Jul 10

donner requested review of D31132: libalias: Possible packet_limit underrun.
Sat, Jul 10, 12:51 PM

Thu, Jul 8

donner added a comment to D31099: pf: remove DIOCGETSTATESNV.
In D31099#699666, @kp wrote:

My plan was to push the preceding patches (i.e. adding and moving to the new call in libpfctl) first, and this one a week later. That'd give main and stable/X users some time to build a new kernel and userspace before we remove the old call. That achieves having the new kernel support old userspace, with a short transition period (so we don't end up with DIOCGETSTATESNV in a release and we have to support is forever).

Thu, Jul 8, 7:35 AM

Wed, Jul 7

donner accepted D31082: mbuf: replace all direct uma_zfree(zone_mbuf) calls with m_free_raw.

Depends on D30959

Wed, Jul 7, 7:20 AM
donner added a comment to D31077: if_epair: rework.

Good work! But hard to review.

Wed, Jul 7, 7:15 AM

Tue, Jul 6

donner committed R10:1883127de488: libalias: Switch to SPLAY trees (authored by donner).
libalias: Switch to SPLAY trees
Tue, Jul 6, 7:12 AM
donner committed R10:e0a40dc22771: libalias: Restructure (authored by donner).
libalias: Restructure
Tue, Jul 6, 7:12 AM
donner committed R10:8b7b86fa6fe0: libalias: Promote per instance global variable timeStamp (authored by donner).
libalias: Promote per instance global variable timeStamp
Tue, Jul 6, 7:12 AM
donner committed R10:e3c21cc51bec: libalias: Stats are unsigned (authored by donner).
libalias: Stats are unsigned
Tue, Jul 6, 7:12 AM
donner committed R10:c207bb80909f: libalias: tidy up housekeeping (authored by donner).
libalias: tidy up housekeeping
Tue, Jul 6, 7:12 AM
donner committed R10:3a96a25da861: libalias: Switch to SPLAY trees (authored by donner).
libalias: Switch to SPLAY trees
Tue, Jul 6, 6:57 AM
donner committed R10:390866d47eff: libalias: Promote per instance global variable timeStamp (authored by donner).
libalias: Promote per instance global variable timeStamp
Tue, Jul 6, 6:57 AM
donner committed R10:78d515b2225e: libalias: Restructure (authored by donner).
libalias: Restructure
Tue, Jul 6, 6:57 AM
donner committed R10:69965155a5c2: libalias: Stats are unsigned (authored by donner).
libalias: Stats are unsigned
Tue, Jul 6, 6:57 AM
donner committed R10:3423d44cd152: libalias: tidy up housekeeping (authored by donner).
libalias: tidy up housekeeping
Tue, Jul 6, 6:57 AM

Mon, Jul 5

donner committed R10:884da892b634: tests/libalias: Bugfix in used variables (authored by donner).
tests/libalias: Bugfix in used variables
Mon, Jul 5, 6:02 AM
donner committed R10:dc42a0503bc9: tests/libalias: Bugfix in used variables (authored by donner).
tests/libalias: Bugfix in used variables
Mon, Jul 5, 5:59 AM

Sun, Jul 4

donner committed R10:4060e77f49d1: libalias: Remove a stray directive (authored by donner).
libalias: Remove a stray directive
Sun, Jul 4, 3:58 PM
donner committed R10:2f4d91f9cb22: libalias: Rewrite HISTORY (authored by donner).
libalias: Rewrite HISTORY
Sun, Jul 4, 3:49 PM

Jul 3 2021

donner edited reviewers for D31012: tests/libalias: Portrange, added: tests; removed: Restricted Project.
Jul 3 2021, 10:32 PM
donner requested review of D31012: tests/libalias: Portrange.
Jul 3 2021, 10:32 PM
donner committed R10:f28455344483: libalias: Fix API bug on initialization (authored by donner).
libalias: Fix API bug on initialization
Jul 3 2021, 9:12 PM

Jul 2 2021

donner committed R10:b50a4dce1854: libalias: Avoid uninitialized expiration (authored by donner).
libalias: Avoid uninitialized expiration
Jul 2 2021, 11:10 PM
donner committed R10:b3dc6f137b8d: tests/libalias: Bugfix in used variables (authored by donner).
tests/libalias: Bugfix in used variables
Jul 2 2021, 10:33 PM
donner committed R10:25392fac9488: libalias: Fix splay comparsion bug (authored by donner).
libalias: Fix splay comparsion bug
Jul 2 2021, 10:33 PM

Jul 1 2021

donner accepted D30974: dummynet: fix sysctls.
Jul 1 2021, 1:02 PM
donner added inline comments to D30943: pf tests: Stress state retrieval.
Jul 1 2021, 7:58 AM
donner accepted D30957: libpfctl: memory leak fix.
Jul 1 2021, 7:54 AM

Jun 30 2021

donner added inline comments to D30946: pf: getstates: avoid taking the hashrow lock if the row is empty.
Jun 30 2021, 3:30 PM
donner added a comment to D30957: libpfctl: memory leak fix.

Why does it depend on other reviews?
If it's part of an open review, please fix it there.
If not, please fix it regardless of the other changes.

Jun 30 2021, 3:28 PM
donner added a comment to D30947: pf: support paging in the DIOCGETSTATESNV call.
In D30947#696642, @mjg wrote:

Since userspace has to alloc all the memory anyway, you can extend the count by say 20% (or even double it if not going past a threshold). Then you can call the kernel and have it fill out as much as it sees fit and return, giving you a magic token which you can use to continue the iteration (which would normally be a row number). Then it is up to the kernel to make the most of what userspace is offering all while limiting its own memory use as it sees fit. This should probably be a new ioctl.

Jun 30 2021, 3:26 PM
donner accepted D30945: libpfctl: improve DIOCGETSTATESNV size estimation.

LGTM

Jun 30 2021, 3:23 PM
donner accepted D30944: pf: Reduce the data returned in DIOCGETSTATESNV.

Please MFC this to any version containing the "old" ABI, so that no intermediate versions enter the external visible trains.

Jun 30 2021, 3:21 PM
donner accepted D30943: pf tests: Stress state retrieval.
Jun 30 2021, 3:18 PM

Jun 24 2021

donner committed R10:2e6fec416d03: tests/netgraph: Fix build error due to missing directory (authored by donner).
tests/netgraph: Fix build error due to missing directory
Jun 24 2021, 12:08 PM
donner committed R10:db7136d6b97f: tests/netgraph: Fix build error due to missing directory (authored by donner).
tests/netgraph: Fix build error due to missing directory
Jun 24 2021, 12:00 PM

Jun 23 2021

donner committed R10:f70c98a2f5d9: libalias: Fix compile time warning about unused functions (authored by donner).
libalias: Fix compile time warning about unused functions
Jun 23 2021, 8:09 AM
donner closed D30844: libalias: Fix compile time warning about unused functions.
Jun 23 2021, 8:08 AM

Jun 22 2021

donner added a comment to D30175: Add netgraph BFP rc.d script.

May you please add a paragraph to the rc man page, too?

I am not native speaker, it is a bit hard to me to write for humans.

Jun 22 2021, 10:25 PM
donner requested changes to D30175: Add netgraph BFP rc.d script.

Thank you for adding context to the diff.

Jun 22 2021, 10:21 PM

Jun 21 2021

donner requested review of D30844: libalias: Fix compile time warning about unused functions.
Jun 21 2021, 3:26 PM
donner added a comment to D30175: Add netgraph BFP rc.d script.

First I'm happy to see such a sophisticated use of netgraph in the default rc context.
Thank you for this idea.

Jun 21 2021, 1:08 PM
donner added a comment to D30811: Correct loopback route for aliases IP addresses.

Can you please share the discussion? Thanks!

Jun 21 2021, 11:02 AM · network

Jun 19 2021

donner committed R10:d261e57deacb: libalias: Switch to efficient data structure for incoming traffic (authored by donner).
libalias: Switch to efficient data structure for incoming traffic
Jun 19 2021, 8:29 PM
donner closed D30536: libalias: Switch to efficient data structure for incoming traffic.
Jun 19 2021, 8:29 PM
donner committed R10:935fc93af157: libalias: Switch to efficient data structure for outgoing traffic (authored by donner).
libalias: Switch to efficient data structure for outgoing traffic
Jun 19 2021, 8:11 PM
donner closed D30516: libalias: Switch to efficient data structure for outgoing traffic.
Jun 19 2021, 8:10 PM
donner closed D30582: libalias: Restructure - Finalize.
Jun 19 2021, 8:02 PM
donner committed R10:d989935b5bcd: libalias: Restructure - Finalize (authored by donner).
libalias: Restructure - Finalize
Jun 19 2021, 8:02 PM
donner closed D30604: libalias: Restructure - Remove temporary state deleteAllLinks from global struct.
Jun 19 2021, 7:58 PM
donner committed R10:fe83900f9fa9: libalias: Restructure - Remove temporary state deleteAllLinks from global struct (authored by donner).
libalias: Restructure - Remove temporary state deleteAllLinks from global struct
Jun 19 2021, 7:58 PM
donner committed R10:9efcad61d830: libalias: Restructure - Use AliasRange instead of PORT_BASE (authored by donner).
libalias: Restructure - Use AliasRange instead of PORT_BASE
Jun 19 2021, 7:54 PM
donner closed D30581: libalias: Restructure - Use AliasRange instead of PORT_BASE.
Jun 19 2021, 7:54 PM
donner updated the diff for D30581: libalias: Restructure - Use AliasRange instead of PORT_BASE.

Use arc4random_uniform(3) as recommended by Dimitry Luhtionov.

Jun 19 2021, 7:43 PM
donner committed R10:1178dda53d10: libalias: Restructure - Table for PPTP (authored by donner).
libalias: Restructure - Table for PPTP
Jun 19 2021, 7:29 PM
donner closed D30580: libalias: Restructure - Table for PPTP.
Jun 19 2021, 7:29 PM
donner committed R10:7b44ff4c52ce: libalias: Restructure - Group expire handling entries (authored by donner).
libalias: Restructure - Group expire handling entries
Jun 19 2021, 7:23 PM
donner closed D30575: libalias: Restructure - Group expire handling entries.
Jun 19 2021, 7:23 PM
donner committed R10:492d3b7109b4: libalias: Restructure - Group incoming links (authored by donner).
libalias: Restructure - Group incoming links
Jun 19 2021, 7:08 PM
donner closed D30574: libalias: Restructure - Group incoming links.
Jun 19 2021, 7:08 PM
donner committed R10:d4ab07d2aeb1: libalias: Restructure - Cleanup and Use for links (authored by donner).
libalias: Restructure - Cleanup and Use for links
Jun 19 2021, 6:32 PM
donner closed D30573: libalias: Restructure - Cleanup and Use for links.
Jun 19 2021, 6:32 PM
donner committed R10:d5419034381d: libalias: Restructure - Outgoing search (authored by donner).
libalias: Restructure - Outgoing search
Jun 19 2021, 6:27 PM
donner closed D30572: libalias: Restructure - Outgoing search.
Jun 19 2021, 6:26 PM
donner closed D30571: libalias: Restructure - Cleanup _FindLinkIn.
Jun 19 2021, 6:21 PM
donner committed R10:19dcc4f2250b: libalias: Restructure - Cleanup _FindLinkIn (authored by donner).
libalias: Restructure - Cleanup _FindLinkIn
Jun 19 2021, 6:21 PM
donner committed R10:cac129e60300: libalias: Restructure - Table for partially links (authored by donner).
libalias: Restructure - Table for partially links
Jun 19 2021, 6:06 PM
donner closed D30570: libalias: Restructure - Table for partial links.
Jun 19 2021, 6:06 PM
donner committed R10:32f9c2ceb3ec: libalias: Restructure - Separate fully qualified search (authored by donner).
libalias: Restructure - Separate fully qualified search
Jun 19 2021, 5:22 PM
donner closed D30569: libalias: Restructure - Separate fully qualified search.
Jun 19 2021, 5:21 PM
donner committed R10:d41044ddfdbc: libalias: Restructure - Common search terms (authored by donner).
libalias: Restructure - Common search terms
Jun 19 2021, 5:05 PM
donner closed D30568: libalias: Restructure - Common search terms.
Jun 19 2021, 5:05 PM
donner committed R10:ef828d39be8e: libalias: Promote per instance global variable timeStamp (authored by donner).
libalias: Promote per instance global variable timeStamp
Jun 19 2021, 4:38 PM
donner closed D30566: libalias: Promote per instance global variable timeStamp.
Jun 19 2021, 4:38 PM
donner committed R10:3fd20a79e7b5: libalias: Stats are unsigned (authored by donner).
libalias: Stats are unsigned
Jun 19 2021, 4:23 PM
donner closed D30587: libalias: Stats are unsigned.
Jun 19 2021, 4:22 PM

Jun 18 2021

donner accepted D30791: pf: fallback if $pf_rules fails to load.
Jun 18 2021, 7:07 PM
donner added a comment to D30811: Correct loopback route for aliases IP addresses.

I'm surprised. There was a discussion about not redirecting /32 on interfaces to loopback. So we see the consequence.

Jun 18 2021, 10:34 AM · network
donner committed R10:95f8bb6d06d9: ipfw.8: synopsis misses nat show form (authored by donner).
ipfw.8: synopsis misses nat show form
Jun 18 2021, 10:08 AM
donner committed R10:116fc1b5a07f: ipfw.8: synopsis misses nat show form (authored by donner).
ipfw.8: synopsis misses nat show form
Jun 18 2021, 10:02 AM
donner committed R10:ef84d16e68b2: ipfw.8: synopsis misses nat show form (authored by donner).
ipfw.8: synopsis misses nat show form
Jun 18 2021, 9:54 AM

Jun 17 2021

donner committed R10:9d30353cb494: Do not forward datagrams originated by link-local addresses (authored by zlei.huang_gmail.com).
Do not forward datagrams originated by link-local addresses
Jun 17 2021, 8:22 AM
donner committed R10:c0a91473f5be: Do not forward datagrams originated by link-local addresses (authored by zlei.huang_gmail.com).
Do not forward datagrams originated by link-local addresses
Jun 17 2021, 8:20 AM
donner committed R10:7da8312f7bf0: Do not forward datagrams originated by link-local addresses (authored by zlei.huang_gmail.com).
Do not forward datagrams originated by link-local addresses
Jun 17 2021, 8:17 AM

Jun 16 2021

donner committed R10:63312dd6d129: netgraph/bridge: malloc without flags (authored by donner).
netgraph/bridge: malloc without flags
Jun 16 2021, 10:00 PM
donner committed R10:ad2c95130b4b: netgraph/bridge: malloc without flags (authored by donner).
netgraph/bridge: malloc without flags
Jun 16 2021, 9:57 PM
donner added inline comments to D30791: pf: fallback if $pf_rules fails to load.
Jun 16 2021, 9:26 PM
donner committed R10:7438333663b4: tests/netgraph: Tests for ng_vlan_rotate (authored by donner).
tests/netgraph: Tests for ng_vlan_rotate
Jun 16 2021, 12:04 PM
donner committed R10:d68f32b4ac35: tests/netgraph: Tests for ng_hub (authored by donner).
tests/netgraph: Tests for ng_hub
Jun 16 2021, 11:51 AM
donner committed R10:49736a31a5c2: tests/netgraph: Tests for ng_bridge (authored by donner).
tests/netgraph: Tests for ng_bridge
Jun 16 2021, 11:51 AM
donner committed R10:4a0c1d0543af: tests/netgraph: Inital framework for testing libnetgraph (authored by donner).
tests/netgraph: Inital framework for testing libnetgraph
Jun 16 2021, 11:50 AM
donner committed R10:abeb0d0c29ba: tests/netgraph: Prebuild tests directory (authored by donner).
tests/netgraph: Prebuild tests directory
Jun 16 2021, 11:50 AM