Page MenuHomeFreeBSD

libalias unused var fix proposal
Needs ReviewPublic

Authored by devnexen_gmail.com on Dec 23 2021, 10:10 AM.
Tags
None
Referenced Files
F156493987: D33625.id.diff
Thu, May 14, 2:38 AM
Unknown Object (File)
Wed, May 13, 4:27 PM
Unknown Object (File)
Mon, May 11, 2:48 PM
Unknown Object (File)
Mon, May 11, 2:48 PM
Unknown Object (File)
Sun, May 10, 12:42 AM
Unknown Object (File)
Fri, May 8, 6:13 PM
Unknown Object (File)
Fri, May 1, 11:13 PM
Unknown Object (File)
Thu, Apr 23, 6:28 PM

Details

Reviewers
sobomax
donner
Summary

reusing find_handler return for UDP/TCP

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Only alias_nbt.c may return any negative result. Even if no handler is suitable, the returned value from alias_mod.c would be positive (2). Every other handler always returns zero.

So the question is, what's the result of passing through a packet which can't be handled by a special purpose handler? Is it better to send out the packet with the un-natted original IP addresses or should be packet be processed without any internal inspection? Is PKT_ALIAS_ERROR more appropriate?