Page MenuHomeFreeBSD

se (Stefan Eßer)
User

Projects

User Details

User Since
May 27 2014, 3:17 PM (347 w, 5 d)

Recent Activity

Tue, Jan 19

se committed R10:24f44a445c48: Remove dependency on files in /usr/bin (authored by se).
Remove dependency on files in /usr/bin
Tue, Jan 19, 11:57 AM
se closed D28209: Remove dependency of rc.d/tmp on grep.
Tue, Jan 19, 11:57 AM

Mon, Jan 18

se updated the diff for D28209: Remove dependency of rc.d/tmp on grep.

I had tried to create the temporary directory name without dependency on /dev/random (and thus suggested to use "ps | sha256", or in my temporary version "ps lauxww | grep sha256").

Mon, Jan 18, 8:44 PM

Sun, Jan 17

se added a comment to D28209: Remove dependency of rc.d/tmp on grep.

As written in the comment of the original submission, a version based on "df /tmp | while ..." can be used instead of the here-doc.
But after implementing both, I did consider the here-doc based version to be both easier to understand and more efficient and thus only proposed that version.

Sun, Jan 17, 6:26 PM
se updated the diff for D28209: Remove dependency of rc.d/tmp on grep.

Remove dependency on mktemp, too, since it also resides in /usr/bin, as noted by rgrimes.

Sun, Jan 17, 2:44 PM
se requested review of D28209: Remove dependency of rc.d/tmp on grep.
Sun, Jan 17, 12:29 PM

Fri, Jan 1

se committed R10:f1031f07fb8b: MFC: Fix calendar -a processing of files included in the user's home directory (authored by se).
MFC: Fix calendar -a processing of files included in the user's home directory
Fri, Jan 1, 12:54 AM

Thu, Dec 31

se committed R10:de924aa90ca0: MFC: Fix calendar -a processing of files included in the user's home directory (authored by se).
MFC: Fix calendar -a processing of files included in the user's home directory
Thu, Dec 31, 5:06 PM
se committed R10:a3c29cdbd495: Replace strcat, strcpy and snprintf with bounds checking versions (authored by se).
Replace strcat, strcpy and snprintf with bounds checking versions
Thu, Dec 31, 11:49 AM

Wed, Dec 30

se committed R10:e163cae76ec7: Make calendarhome buffer static (authored by se).
Make calendarhome buffer static
Wed, Dec 30, 12:47 PM

Sun, Dec 27

se committed R10:e458944cf9de: Import bc 3.2.4 (authored by se).
Import bc 3.2.4
Sun, Dec 27, 9:41 PM
se committed R10:50fcb4ee771c: Replace sscanf() by strtoul() (authored by se).
Replace sscanf() by strtoul()
Sun, Dec 27, 9:41 PM
se committed R10:3fee777ec5a2: Simplify LS_COLWIDTHS processing (authored by se).
Simplify LS_COLWIDTHS processing
Sun, Dec 27, 9:40 PM
se committed R10:dbb25cbe55cf: Adjust to display more than 999 sleeping threads (authored by se).
Adjust to display more than 999 sleeping threads
Sun, Dec 27, 9:40 PM
se committed R10:6fe8fbdc1cdd: Statistics are for threads, not processes (authored by se).
Statistics are for threads, not processes
Sun, Dec 27, 9:40 PM
se committed R10:7fe0a3f20857: Import bc 3.2.4 (authored by se).
Import bc 3.2.4
Sun, Dec 27, 8:59 PM

Sat, Dec 26

se added a comment to D27562: bc: use __has_attribute to test attribute presence.

@se Now that vendor workflows are open for git, can we get upstream's fix in? Or do you prefer I just do a direct commit of upstream's fix as discussed above?

Sat, Dec 26, 11:08 PM
se committed rP559311: Enable updating of locked ports.
Enable updating of locked ports
Sat, Dec 26, 8:47 PM

Dec 25 2020

se committed rP559240: New port nmrpflash that allows to flash Netgear network device firmware.
New port nmrpflash that allows to flash Netgear network device firmware
Dec 25 2020, 12:51 PM

Dec 17 2020

se committed rP558283: Add per dataset operations statistics provided by OpenZFS.
Add per dataset operations statistics provided by OpenZFS
Dec 17 2020, 11:09 AM

Dec 13 2020

se committed rS368610: Revert r368606.
Revert r368606
Dec 13 2020, 8:16 PM
se committed rS368611: Fix WITHOUT_ICONV build.
Fix WITHOUT_ICONV build
Dec 13 2020, 8:16 PM
se committed R9:5fe1c08b9909: Add "Danny J. Zerkel <dzerkel@feephi.phofarm.com>" because of his (authored by se).
Add "Danny J. Zerkel <dzerkel@feephi.phofarm.com>" because of his
Dec 13 2020, 8:16 PM
se committed R9:fd1d9a197b8b: Add Tekram Technologies for their contribution of three different (authored by se).
Add Tekram Technologies for their contribution of three different
Dec 13 2020, 8:10 PM
se committed R9:0b84fc89ce95: Add Gerard Roudier for the great effort he spent on improving the (authored by se).
Add Gerard Roudier for the great effort he spent on improving the
Dec 13 2020, 8:10 PM
se committed R9:76cf7042ae89: Add Larry M. Augustin for his contribution Symbios of an ULTRA-WIDE (authored by se).
Add Larry M. Augustin for his contribution Symbios of an ULTRA-WIDE
Dec 13 2020, 8:10 PM
se committed rS368606: Fix WITHOUT_ICONV build.
Fix WITHOUT_ICONV build
Dec 13 2020, 9:39 AM

Dec 12 2020

se committed rS368578: Use getlocalbase() instead of compiled in LOCALBASE to locate calendars.
Use getlocalbase() instead of compiled in LOCALBASE to locate calendars
Dec 12 2020, 11:51 AM
se closed D27370: New implementation of getlocalbase().
Dec 12 2020, 11:24 AM
se committed rS368577: Change getlocalbase() to not allocate any heap memory.
Change getlocalbase() to not allocate any heap memory
Dec 12 2020, 11:24 AM

Dec 11 2020

se accepted D27562: bc: use __has_attribute to test attribute presence.

I have updated the math/gh-bc port to version 3.2.4, which includes a slightly modified version of this change.
The author wanted to avoid problems with other compilers than gcc and clang, which might not support the __has_attribute(()) mechanism, and therefore has added further conditions to your patch.

Dec 11 2020, 8:05 PM
se committed rP557758: Upgrade to version 3.2.4.
Upgrade to version 3.2.4
Dec 11 2020, 7:26 PM
se added a comment to D27568: Install missing calendar test files.

FYI, I have commit access and could have committed this myself.

Dec 11 2020, 1:33 PM
se added a comment to D27568: Install missing calendar test files.

Thank you for the report and sorry for the breakage - is there a mail list that reports new test failures?

Dec 11 2020, 1:29 PM
se closed D27568: Install missing calendar test files.
Dec 11 2020, 1:24 PM
se committed rS368551: Install 2 forgotten shell scripts required to run the tests.
Install 2 forgotten shell scripts required to run the tests
Dec 11 2020, 1:24 PM

Dec 10 2020

se committed rS368503: Lift scope of buf[] to make it extend to a potential access via *basename.
Lift scope of buf[] to make it extend to a potential access via *basename
Dec 10 2020, 9:31 AM
se committed rS368501: MFC: r366318, r368072, r368080, r368097, r368387.
MFC: r366318, r368072, r368080, r368097, r368387
Dec 10 2020, 8:48 AM

Dec 8 2020

se committed rP557277: Upgrade to version 3.10.1.
Upgrade to version 3.10.1
Dec 8 2020, 10:26 AM

Dec 6 2020

se committed rS368387: Upgrade to version 3.2.3.
Upgrade to version 3.2.3
Dec 6 2020, 11:49 AM
se committed rS368386: Tag version 3.2.3.
Tag version 3.2.3
Dec 6 2020, 11:44 AM
se committed rS368385: Import version 3.2.3.
Import version 3.2.3
Dec 6 2020, 11:39 AM

Nov 30 2020

se committed rP556650: Update to version 3.2.3.
Update to version 3.2.3
Nov 30 2020, 3:45 PM

Nov 27 2020

se committed rS368097: Make generated C files depend on this Makefile.
Make generated C files depend on this Makefile
Nov 27 2020, 9:00 AM

Nov 26 2020

se committed rS368080: Update Makefile for new version 3.2.0.
Update Makefile for new version 3.2.0
Nov 26 2020, 7:38 PM
se committed rS368072: Update to version 3.2.0.
Update to version 3.2.0
Nov 26 2020, 5:40 PM
se committed rS368069: Tag version 3.2.0.
Tag version 3.2.0
Nov 26 2020, 5:29 PM
se committed rS368068: Import version 3.2.0.
Import version 3.2.0
Nov 26 2020, 5:28 PM
se committed rS368063: Revert incomplete import of version 3.2.0.
Revert incomplete import of version 3.2.0
Nov 26 2020, 5:18 PM
se committed rS368062: Update to version 3.2.0.
Update to version 3.2.0
Nov 26 2020, 4:52 PM
se committed rP556344: Upgrade to version 3.2.0.
Upgrade to version 3.2.0
Nov 26 2020, 4:47 PM

Nov 25 2020

se added inline comments to D27370: New implementation of getlocalbase().
Nov 25 2020, 12:39 PM
se requested review of D27370: New implementation of getlocalbase().
Nov 25 2020, 10:47 AM

Nov 18 2020

se closed D27237: Use getlocalbase() in a few base system programs.
Nov 18 2020, 8:01 PM
se committed rS367816: Make use of the getlocalbase() function for run-time adjustment of the.
Make use of the getlocalbase() function for run-time adjustment of the
Nov 18 2020, 8:01 PM
se closed D27236: Retrieve LOCALBASE with getlocalbase().
Nov 18 2020, 7:44 PM
se committed rS367813: Add function getlocalbase() to libutil..
Add function getlocalbase() to libutil.
Nov 18 2020, 7:44 PM

Nov 17 2020

se updated the diff for D27236: Retrieve LOCALBASE with getlocalbase().

Since neither the statically allocated 1024 char buffer nor the version with the constructor has made the reviewers happy, I'm going back to the 2nd proposed version, which does only perform system calls when this function is actually called and allocates a minimally sized buffer only when necessary to hold the sysctl result.

Nov 17 2020, 7:28 PM
se added a comment to D27236: Retrieve LOCALBASE with getlocalbase().
In D27236#608681, @cem wrote:
In D27236#608678, @imp wrote:

If you ktrace a regular application starting up you already see a lot of system calls, so I think adding one more is fine.

Except there's many efforts to reduce this. At present, this function is called by a tiny number of binaries, so I'd rather have any overhead be limited to those programs that use it.

+1

We don't want to saddle every program that links libutil with a constructor like this. Instead, construct on demand. This could be relatively trivial: drop the ctor attribute, and instead:

Nov 17 2020, 6:47 PM
se added a comment to D27236: Retrieve LOCALBASE with getlocalbase().
In D27236#608678, @imp wrote:

If you ktrace a regular application starting up you already see a lot of system calls, so I think adding one more is fine.

Except there's many efforts to reduce this. At present, this function is called by a tiny number of binaries, so I'd rather have any overhead be limited to those programs that use it.

Nov 17 2020, 6:33 PM
se added a comment to D27236: Retrieve LOCALBASE with getlocalbase().

MIght be we also need a destructor to free the memory, if any, to make valgrind happy.

Nov 17 2020, 6:20 PM
se added a comment to D27236: Retrieve LOCALBASE with getlocalbase().

Looks good to me. I hope it does not affect the performance of any apps, that are launched frequently.

Nov 17 2020, 3:01 PM
se updated the diff for D27236: Retrieve LOCALBASE with getlocalbase().

Hans Petter Selasky suggested the use of a constructor, something that I had not thought about at all ...

Nov 17 2020, 1:28 PM
se updated the diff for D27236: Retrieve LOCALBASE with getlocalbase().

Updated diff with an alternate implementation that does not include a static buffer of length MAXPATHLEN.
(The actual memory requirements of that alternative implementation are larger than those of the version with the static buffer, though.)

Nov 17 2020, 9:27 AM

Nov 16 2020

se added a comment to D27236: Retrieve LOCALBASE with getlocalbase().
In D27236#608246, @imp wrote:
In D27236#608193, @cem wrote:

The user.localbase sysctl seems like a poor design, and doesn't exist at the moment. That needs to be resolved before this change is committed.

Nov 16 2020, 9:53 PM
se updated the diff for D27237: Use getlocalbase() in a few base system programs.

Add another invocation of getlocalbase() instead of getenv("LOCALBASE") in usr.sbin/pkg

Nov 16 2020, 12:04 PM
se retitled D27237: Use getlocalbase() in a few base system programs from Use getlocalbase() in a few base sysetm programs to Use getlocalbase() in a few base system programs.
Nov 16 2020, 11:53 AM
se requested review of D27237: Use getlocalbase() in a few base system programs.
Nov 16 2020, 11:52 AM
se requested review of D27236: Retrieve LOCALBASE with getlocalbase().
Nov 16 2020, 11:47 AM

Nov 12 2020

se added a comment to D27022: Introduce getlocalbase.3.

The problem I see is that not everything will use this or the sysctl. Ports, Poudriere, nearly everything, are doing getenv("LOCALBASE"). Other places have things like LOCALBASE?= /usr/local. So then I wonder what the usefulness of it being configured in the kernel in the first place is as a user setting it won't achieve much.

I might argue it makes more sense to make it call this getlocalbase(3) when getenv("LOCALBASE") is done but that's crazy right? LOCALBASE typically should be set once on a system down in something like /etc/login.conf and otherwise exported in build scripts.

I certainly understand the want to unify all of these LOCALBASE?= /usr/local and _PATH_LOCALBASE things but the interface really needs to be prioritizing the environment where its primary consumer is looking.

Nov 12 2020, 11:06 PM

Nov 11 2020

se committed rP554907: Correctly report package locks that prevent an upgrade.
Correctly report package locks that prevent an upgrade
Nov 11 2020, 6:55 PM

Nov 10 2020

se accepted D27022: Introduce getlocalbase.3.
Nov 10 2020, 5:11 PM
se committed rP554790: Fix type in port origin of swfdec entry.
Fix type in port origin of swfdec entry
Nov 10 2020, 2:12 AM

Nov 7 2020

se committed rP554387: Fetch from my repository to simplify port.
Fetch from my repository to simplify port
Nov 7 2020, 1:42 PM

Nov 6 2020

se committed rP554325: Update to FreeBSD base SVN revision r367364.
Update to FreeBSD base SVN revision r367364
Nov 6 2020, 10:04 PM
se committed rP554312: Bump PORTREVISION to rebuild this port for the updated security/openvpn.
Bump PORTREVISION to rebuild this port for the updated security/openvpn
Nov 6 2020, 7:40 PM

Nov 5 2020

se committed rS367364: Restrict locale settings to the file they occur in.
Restrict locale settings to the file they occur in
Nov 5 2020, 8:58 AM

Nov 4 2020

se committed rS367350: Add regression tests for conditions and comments.
Add regression tests for conditions and comments
Nov 4 2020, 10:29 PM

Nov 3 2020

se committed rS367308: Update man-page to document changes made to the calendar program..
Update man-page to document changes made to the calendar program.
Nov 3 2020, 10:13 PM
se committed rP554037: Update to -CURRENT SVN rev. r367293.
Update to -CURRENT SVN rev. r367293
Nov 3 2020, 9:11 PM
se closed D27014: Use sysctl value for localbase in rc files.
Nov 3 2020, 12:29 PM
se committed rS367294: Replace literal uses of /usr/local with a variable.
Replace literal uses of /usr/local with a variable
Nov 3 2020, 12:29 PM
se committed rS367293: Consistently print calendar dates in the locale of the user.
Consistently print calendar dates in the locale of the user
Nov 3 2020, 12:15 PM
se committed rS367292: Check that #ifdef, #ifndef, and #undef are used with a single name.
Check that #ifdef, #ifndef, and #undef are used with a single name
Nov 3 2020, 11:37 AM

Nov 2 2020

se committed rS367280: Re-arrange some of the code to separate writable user tree variables from.
Re-arrange some of the code to separate writable user tree variables from
Nov 2 2020, 6:48 PM

Nov 1 2020

se committed rP553859: Update to -CURRENT SVN rev. r367255.
Update to -CURRENT SVN rev. r367255
Nov 1 2020, 8:46 PM
se committed rS367255: Fix psoition reporting for calendar data file in system directory.
Fix psoition reporting for calendar data file in system directory
Nov 1 2020, 8:39 PM
se committed rS367254: Fix year in 2 most recent entries (2010 -> 2020).
Fix year in 2 most recent entries (2010 -> 2020)
Nov 1 2020, 7:14 PM
se committed rP553828: Pass _PATH_LOCALBASE correctly quoted to the build.
Pass _PATH_LOCALBASE correctly quoted to the build
Nov 1 2020, 9:33 AM

Oct 31 2020

se committed rS367243: Make sysctl user.local a tunable that can be written at run-time.
Make sysctl user.local a tunable that can be written at run-time
Oct 31 2020, 11:48 PM
se committed rS367221: Mention the more strict consistency checks performed by calendar(), which.
Mention the more strict consistency checks performed by calendar(), which
Oct 31 2020, 4:39 PM
se committed rP553773: Update to FreeBSD-CURRENT base SVN revision r367207.
Update to FreeBSD-CURRENT base SVN revision r367207
Oct 31 2020, 3:33 PM
se committed rS367207: Improve calendar file parsing and consistency tests.
Improve calendar file parsing and consistency tests
Oct 31 2020, 3:11 PM
se committed rS367204: Add file names and line numbers to debug messages.
Add file names and line numbers to debug messages
Oct 31 2020, 1:55 PM
se committed rS367203: Add file names and line numbers to calendar format error messages.
Add file names and line numbers to calendar format error messages
Oct 31 2020, 1:32 PM
se committed rS367199: Fix reversed condition after attempted style fix in r367196.
Fix reversed condition after attempted style fix in r367196
Oct 31 2020, 12:11 PM
se committed rS367196: Fix style, no functional change.
Fix style, no functional change
Oct 31 2020, 11:45 AM

Oct 30 2020

se committed rS367184: Update man-pages to describe the user.localbase variable added in r367179..
Update man-pages to describe the user.localbase variable added in r367179.
Oct 30 2020, 7:38 PM
se added a comment to D27022: Introduce getlocalbase.3.

I'm still in doubt about the usefulness of LOCALBASE being specified at run-time if it is not applied to all paths in the system.
And for all other cases (not changed at run-time) a compiled in _PATH_LOCALBASE works as well, while scripts can use the sysctl command.

Oct 30 2020, 7:27 PM
se closed D27009: Make LOCALBASE available as a sysctl value.
Oct 30 2020, 6:48 PM