Please commit with a relative short MFC delay (e.g. 1 week).
I had planned to MFC the (now fixed) code on March 26 (1 month after the commit to -CURRENT).
Since this fix is required to be merged with the initial commit, I plan to squash the cherry-picked commits (including your fix).

In D44472#1014219, @tuexen wrote:

In D44472#1014214, @se wrote:

Thank you for finding the logic error.

The commented out extra condition was meant to be enabled in a future update to make little-endian systems assign a constant to is_le and to let constant expression evaluation effectively remove the conditional byte swap on them.

My understanding is that is_le is true, iff the byte order of the hints file is little endian, not if the host byte order
is little endian. Is that correct?
Using le32toh(1) == 1 or better htole32(1) == 1 checks the host byte order, not the byte order of the file.

Using your condition would result in is_le being true if the host byte order is little endian or the file byte order
is little endian. So if you run this on a host with host byte order being little endian using a file with file byte order
being big endian, is_le would be true. Therefore you would use le32toh for the conversion, which wouldn't do
anything, and it would break.

Thank you for finding the logic error.

In D44319#1012663, @pho wrote:

D44319.id135654.diff doesn't seem to work for me:

root@mercat1:/usr/src/tools/test/stress2/misc # ./all.sh -onc msdos11.sh
20240318 13:16:17 all: msdos11.sh
** /dev/md10a
** Phase 1 - Read FAT and checking connectivity
** Phase 2 - Checking Directories
** Phase 3 - Checking for Lost Files
Lost cluster chain at cluster 4
1 Cluster(s) lost
Reconnect? yes
No LOST.DIR directory
Clear? yes
Lost cluster chain at cluster 5
1 Cluster(s) lost
Reconnect? yes
No LOST.DIR directory
Clear? yes

In D44319#1011511, @kib wrote:

This looks somewhat strange to me. Most of the weirdness is in that we have lblkno != blkno for devvp buffers, which I believe we did not have anywhere before.

Update diff to include the new macros breadb() and breadbn() added to sys/buf.h to allow passing of separate physical and buffer cache block number parameters.

A version based on these patches (but with slightly different command line options) has been discussed and accepted in review D44093.

While reading the FILES section I noticed that there was some outdated/wrong information:

My main question regarding this review is whether the comment regarding ignored options should be in the HISTORY section or rather moved to the end of the options section.

Fix cross-reference to the ld-elf.so.1 man-page - there was no blank between the section number and the comma.

Update diff to include changes suggested by reviewers. The is_be flag is still stored in a global variable, since this is a "global" feature of the hints file that is being processed and the global variable minimizes the required changes.

The version of elfhints.c in the sources of the pkg command has been updated to implemented byte-order independent updates of the hints file, see:

This patch has been accepted as part of review D44053 and has been committed with modified variable names as part of commit 7b77d37a561b4.

Split review in 2 parts:

Updated according to review comments.

Building in the source directory had worked, but some type casts are required to make some dbg() calls compile during make world.

I have noticed that the usage message and man-page have not been finalized for this version of the patches, see inline comments.

In D43978#1003363, @mckusick wrote:

This does fix the problem as described in the summary.

In D43978#1003362, @mckusick wrote:

If I understand your change, you are coming up with a different synthetic inode value to ensure that it will be unique. Presumably this value is externally visible as the "st_ino" in the stat structure and the "d_fileno" in the dirent structure. If so, this value will be different after this change so any program that has saved it somewhere could get confused. Not sure if this is really an issue though.

This patch is a fix for PR #268005.

Update diff to prefer the old location of the target directory.