In D56511#1295639, @des wrote:

In D56511#1295534, @se wrote:

I plan to commit these patches after some more testing

I don't think you understand how Phabricator works...

Thanks for pointing out the typo in dc_tests.sh.
I can see that this typo makes the test fail on the build cluster, when run under an account without write access to /usr/tests/usr.bin/gh-bc.
It worked on my machine when run as root, but that's no excuse ...
I plan to commit these patches after some more testing (for some reason depends_cleanup.sh is not executed during buildworld, but the tests obj directory is removed in stage 2.2, anyway).

The author of this BC / DC has asked me to not create a fork.
The typo in all.sh has been reported by me and fixed in upstream commit 3887cc1.
The author offered to tag a version 7.1.1, but since it did not affect FreeBSD (all.sh is not used on FreeBSD), I did not ask for it.
The script tests are only relevant for the port, since they depend on a previous version of BC / DC installed on the system the test is run on.
Since no previous version can be assumed to exist on the base system, there is no way to generate the expected outputs from a binary other than the one to be tested.

The tests complete in 3 seconds on my amd64 system.
I do assume that the 100 times slower execition on riscv64 is due to inefficient emulation of that platform?
Instead of patching the timeout in individual ports, I believe the parameters in the CI system should be adjusted to account for the slow execution speed of emulated systems.
Therefore, I do not want to set the timeout to such a high value for all platforms.
If there is consensus that changing individual ports is required, I'd make the timeout adjustment depend on the architecture (apparently, only riscv64 is affected).

Looks fine.

Update diff to be in standard format (had been created with "diff.mnemonicprefix=true").

In D46876#1068975, @emaste wrote:

phabricator tagged it with "does not need to be reviewed"

Phabricator recognizes it as a generated file and so doesn't need to be reviewed. The note is intended more for the assigned reviewers - the change can be included, Phab just notes that reviewers don't need to look at it.

Address review comments.

In D46876#1068925, @des wrote:

You also need to remove tools/build/options/WITH_GH_BC, move the relevant section of tools/build/mk/OptionalObsoleteFiles.inc to ObsoleteFiles.inc, and regenerate share/man/man5/src.conf.5.

In D46876#1068928, @des wrote:

In D46876#1068845, @emaste wrote:

Is there value in keeping the tests that were added to the old version?

Perhaps. More importantly, Gavin Howard's bc has its own test suite which we could adopt. Take a look at how Apple did it: https://github.com/apple-oss-distributions/bc

Update diff to include removal of dependency on MK_GH_BC from usr.bin/Makefile and from tools/build/mk/OptionalObsoleteFiles.inc.