User Details
- User Since
- May 27 2014, 3:17 PM (347 w, 5 d)
Tue, Jan 19
Mon, Jan 18
I had tried to create the temporary directory name without dependency on /dev/random (and thus suggested to use "ps | sha256", or in my temporary version "ps lauxww | grep sha256").
Sun, Jan 17
As written in the comment of the original submission, a version based on "df /tmp | while ..." can be used instead of the here-doc.
But after implementing both, I did consider the here-doc based version to be both easier to understand and more efficient and thus only proposed that version.
Remove dependency on mktemp, too, since it also resides in /usr/bin, as noted by rgrimes.
Fri, Jan 1
Thu, Dec 31
Wed, Dec 30
Sun, Dec 27
Sat, Dec 26
Dec 25 2020
Dec 17 2020
Dec 13 2020
Dec 12 2020
Dec 11 2020
I have updated the math/gh-bc port to version 3.2.4, which includes a slightly modified version of this change.
The author wanted to avoid problems with other compilers than gcc and clang, which might not support the __has_attribute(()) mechanism, and therefore has added further conditions to your patch.
Thank you for the report and sorry for the breakage - is there a mail list that reports new test failures?
Dec 10 2020
Dec 8 2020
Dec 6 2020
Nov 30 2020
Nov 27 2020
Nov 26 2020
Nov 25 2020
Nov 18 2020
Nov 17 2020
Since neither the statically allocated 1024 char buffer nor the version with the constructor has made the reviewers happy, I'm going back to the 2nd proposed version, which does only perform system calls when this function is actually called and allocates a minimally sized buffer only when necessary to hold the sysctl result.
Hans Petter Selasky suggested the use of a constructor, something that I had not thought about at all ...
Updated diff with an alternate implementation that does not include a static buffer of length MAXPATHLEN.
(The actual memory requirements of that alternative implementation are larger than those of the version with the static buffer, though.)
Nov 16 2020
Add another invocation of getlocalbase() instead of getenv("LOCALBASE") in usr.sbin/pkg
Nov 12 2020
Nov 11 2020
Nov 10 2020
Nov 7 2020
Nov 6 2020
Nov 5 2020
Nov 4 2020
Nov 3 2020
Nov 2 2020
Nov 1 2020
Oct 31 2020
Oct 30 2020
I'm still in doubt about the usefulness of LOCALBASE being specified at run-time if it is not applied to all paths in the system.
And for all other cases (not changed at run-time) a compiled in _PATH_LOCALBASE works as well, while scripts can use the sysctl command.