In D21629#576019, @cem wrote:

FWIW, since yesterday we've run this under some Isilon workloads and it does seem to (1) function correctly and (2) alleviate load on the pagedaemon thread(s) (which were previously a bottleneck on some workloads, running at 100% CPU constantly).

Aug 6 2020, 3:52 PM

pho committed rS363943: Added comment about problem found..

Added comment about problem found.

Aug 6 2020, 7:27 AM

pho committed rS363942: Added a simple ext4 test scenario..

Added a simple ext4 test scenario.

Aug 6 2020, 6:57 AM

Aug 5 2020

pho committed rS363902: Update the no-run list..

Update the no-run list.

Aug 5 2020, 11:11 AM

pho committed rS363901: Added a new syzkaller reproducer..

Added a new syzkaller reproducer.

Aug 5 2020, 11:10 AM

Aug 4 2020

pho added a comment to D25952: UMA: Avoid polling for an invalid read sequence number..

In D25952#575282, @markj wrote:

@pho can you see if the buf_vlist_add() panic is still reproducible with this patch?

Aug 4 2020, 10:17 PM

pho added a comment to D25950: buf_trie_alloc: Spin on alloc failure.

No, UMA: https://people.freebsd.org/~pho/stress/log/mjguzik036.txt

Aug 4 2020, 7:03 PM

pho committed rS363828: Updated the test exclude list..

Updated the test exclude list.

Aug 4 2020, 6:40 AM

pho committed rS363827: Added a new syzkaller reproducer..

Added a new syzkaller reproducer.

Aug 4 2020, 6:38 AM

pho committed rS363826: Added a new syzkaller reproducer..

Added a new syzkaller reproducer.

Aug 4 2020, 6:37 AM

pho committed rS363825: Tests with SUJ shows a know deadlock issue..

Tests with SUJ shows a know deadlock issue.

Aug 4 2020, 6:34 AM

Aug 2 2020

pho added a comment to D25914: Unlocked getblk: Fix new false-positive assertion.

In D25914#574158, @pho wrote:

I am running tests with the scenario that triggered the panic multiple times.

Aug 2 2020, 5:51 AM

Aug 1 2020

pho added a comment to D25914: Unlocked getblk: Fix new false-positive assertion.

I am running tests with the scenario that triggered the panic multiple times.

Aug 1 2020, 8:28 PM

Jul 23 2020

pho added a comment to D25782: Add unlocked/SMR fast path to getblk().

In D25782#571014, @cem wrote:

In D25782#570995, @markj wrote:

Quite surprisingly to me, it doesn't seem to immediately panic. So I'm probably missing something.

Perhaps @pho would be willing to try and test this together with D25781?

I'd certainly appreciate it.

Jul 23 2020, 5:17 PM

pho added a comment to D25736: Avoid overflow in blist_create, remove swap pager checks before blist_create.

In D25736#570929, @kib wrote:

Sorry I did not stated that explicitly, the large swap should be a single volume. Blists are allocatd per swap device.

Jul 23 2020, 1:42 PM

pho added a comment to D25736: Avoid overflow in blist_create, remove swap pager checks before blist_create.

In D25736#570900, @kib wrote:
In D25736#570896, @pho wrote:
In D25736#570891, @kib wrote:

In D25736#570868, @pho wrote:

I completed a full stress2 test with D25736.74719.diff on r363390.
No problems seen.

How large the configured swap size was ? And how much of it was used (approximately) ?
$ ./swapused.sh 
FreeBSD t2.osted.lan 13.0-CURRENT FreeBSD 13.0-CURRENT #0 r363443M: Thu Jul 23 13:01:56 CEST 2020     pho@t2.osted.lan:/usr/src/sys/amd64/compile/PHO  amd64
swapinfo -h
Device              Size     Used    Avail Capacity
/dev/da0p4           67G       0B      67G     0%

swap disk
  1027604514   140509184    4  freebsd-swap  (67G)
13:08:48 0%
13:10:02 1%
13:10:09 2%
:
13:18:33 32%
13:18:55 33%
I think this patch mostly needs Marius' test sort /dev/zero.

This test is included in stress2 as sort.sh
67G is on the edge of the previous max 64G. Could you try only the Marius' test with much larger swap, say 128G or even 512G ?

Jul 23 2020, 12:51 PM

pho added a comment to D25736: Avoid overflow in blist_create, remove swap pager checks before blist_create.

In D25736#570891, @kib wrote:

In D25736#570868, @pho wrote:

I completed a full stress2 test with D25736.74719.diff on r363390.
No problems seen.

How large the configured swap size was ? And how much of it was used (approximately) ?

Jul 23 2020, 11:22 AM

pho added a comment to D25736: Avoid overflow in blist_create, remove swap pager checks before blist_create.

I completed a full stress2 test with D25736.74719.diff on r363390.
No problems seen.

Jul 23 2020, 6:52 AM

Jul 21 2020

pho added a comment to D25736: Avoid overflow in blist_create, remove swap pager checks before blist_create.

I have started a full stress2 test, which will take two days to complete.

Jul 21 2020, 5:26 AM

Jul 20 2020

pho added a comment to D25736: Avoid overflow in blist_create, remove swap pager checks before blist_create.

I ran a preliminary 2 hour test with D25736.74672.diff.

Jul 20 2020, 8:39 AM

Jul 1 2020

pho added a comment to D25480: Change from red-black to wavl balancing for RB trees.

I ran tests on D25480.73926.diff for 12 hours without seeing any problems.

Jul 1 2020, 4:37 PM

Jun 30 2020

pho committed rS362793: Updated the exclude list..

Updated the exclude list.

Jun 30 2020, 7:37 AM

pho committed rS362792: Added two syzkaller reproducers..

Added two syzkaller reproducers.

Jun 30 2020, 7:37 AM

Jun 29 2020

pho added a comment to D25480: Change from red-black to wavl balancing for RB trees.

I have started a full test of D25480.73797.diff.

Jun 29 2020, 7:44 AM

pho added a comment to D23913: vfs: introduce basic smr-protected path lookup.

I ran all of the stress2 tests on r362642 with D23913.73738.diff.
No problems seen.

Jun 29 2020, 4:51 AM

Jun 27 2020

pho added a comment to D25480: Change from red-black to wavl balancing for RB trees.

Yes, this compiles nicely.

Jun 27 2020, 12:38 PM

pho added a comment to D25480: Change from red-black to wavl balancing for RB trees.

Diff 73750 seems to only contain the man changes?

Jun 27 2020, 6:29 AM

pho added a comment to D25480: Change from red-black to wavl balancing for RB trees.

A r362642 kernel with D25480.73723.diff applied does not compile.

Jun 27 2020, 5:44 AM

Jun 25 2020

pho added a comment to D25418: Replace RB color field with tag bits in the parent pointer.

I ran tests with this patch for 21 hours (633 tests out of 718) without seeing any issues.

Jun 25 2020, 5:40 PM

Jun 24 2020

pho added a comment to D25418: Replace RB color field with tag bits in the parent pointer.

I ran a preliminary two hour test followed by a buildworld. No problems seen.

Jun 24 2020, 12:57 PM

pho added a comment to D25418: Replace RB color field with tag bits in the parent pointer.

https://people.freebsd.org/~pho/stress/log/dougm072.txt

Jun 24 2020, 7:30 AM

pho added a comment to D25418: Replace RB color field with tag bits in the parent pointer.

20200624 09:12:49 all (32/724): seekdir.sh

Jun 24 2020, 7:22 AM

pho added a comment to D25418: Replace RB color field with tag bits in the parent pointer.

Unfortunately a kernel with D25418.73541.diff applied does not compile.

Jun 24 2020, 5:42 AM

Jun 22 2020

pho committed rS362486: Style fix..

Style fix.

Jun 22 2020, 7:00 AM

pho committed rS362485: Added a syzkaller reproducer..

Added a syzkaller reproducer.

Jun 22 2020, 6:58 AM

Jun 18 2020

pho committed rS362266: Added a syzkaller reproducer..

Added a syzkaller reproducer.

Jun 18 2020, 9:25 AM

pho committed rS362267: Updated the exclude list..

Updated the exclude list.

Jun 18 2020, 9:20 AM

pho committed rS362268: Fix indent..

Fix indent.

Jun 18 2020, 9:20 AM

pho committed rS362269: Added a "fixed by"..

Added a "fixed by".

Jun 18 2020, 9:20 AM

pho added a comment to D25264: Define RB parent assignment macros.

I completed a full stress2 test with D25264.73113.diff.
No problems seen.

Jun 18 2020, 9:18 AM

Jun 14 2020

pho added a comment to D25264: Define RB parent assignment macros.

https://people.freebsd.org/~pho/stress/log/dougm071.txt

Jun 14 2020, 5:26 PM

pho added a comment to D25264: Define RB parent assignment macros.

===> linuxkpi (all)
cc  -O2 -pipe -fno-common  -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -DKLD_TIED -nostdinc  -I/usr/src/sys/compat/linuxkpi/common/include -I/usr/src/sys/contrib/ck/include -DHAVE_KERNEL_OPTION_HEADERS -include /usr/src/sys/amd64/compile/PHO/opt_global.h -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common -g -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include -fdebug-prefix-map=./x86=/usr/src/sys/x86/include -I/usr/src/sys/amd64/compile/PHO     -MD  -MF.depend.linux_compat.o -MTlinux_compat.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-address-of-packed-member -Wno-format-zero-length   -mno-aes -mno-avx  -std=iso9899:1999 -c /usr/src/sys/compat/linuxkpi/common/src/linux_compat.c -o linux_compat.o
In file included from /usr/src/sys/compat/linuxkpi/common/src/linux_compat.c:103:
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:87:2: error: no member named 'rbh_root' in 'struct rb_root'
        RB_SWAP_CHILD(root, victim, new, __entry);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/src/sys/sys/tree.h:354:3: note: expanded from macro 'RB_SWAP_CHILD'
                RB_ROOT(head) = (in);                                   \
                ^~~~~~~~~~~~~
/usr/src/sys/sys/tree.h:325:33: note: expanded from macro 'RB_ROOT'
#define RB_ROOT(head)                   (head)->rbh_root
                                        ~~~~~~  ^
1 error generated.
*** Error code 1

Jun 14 2020, 8:29 AM

Jun 9 2020

pho added a comment to D25105: Replace the rb_color field in an rb_node with a tag in the parent's pointer to the rb_node.

I completed a full stress2 test with D25105.72798.diff.

Jun 9 2020, 8:05 PM

pho committed rS361961: Added a syzkaller reproducer..

Added a syzkaller reproducer.

Jun 9 2020, 6:48 AM

Jun 7 2020

pho committed rS361890: Added a syzkaller reproducer..

Added a syzkaller reproducer.

Jun 7 2020, 12:15 PM

Jun 5 2020

pho committed rS361836: Fix a copy/paste error in multiple files..

Fix a copy/paste error in multiple files.

Jun 5 2020, 3:09 PM

pho added a comment to D25105: Replace the rb_color field in an rb_node with a tag in the parent's pointer to the rb_node.

D25105.72656.diff builds without any issues.
I ran stress2 tests for 12 hours followed by a buildkernel and a buildworld.
No problems seen.

Jun 5 2020, 6:34 AM

Jun 4 2020

pho added a comment to D25105: Replace the rb_color field in an rb_node with a tag in the parent's pointer to the rb_node.

Your patch still doesn't compile:

===> linuxkpi (all)
cc  -O2 -pipe -fno-common  -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -DKLD_TIED -nostdinc  -I/usr/src/sys/compat/linuxkpi/common/include -I/usr/src/sys/contrib/ck/include -DHAVE_KERNEL_OPTION_HEADERS -include /usr/src/sys/amd64/compile/PHO/opt_global.h -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common -g -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include -fdebug-prefix-map=./x86=/usr/src/sys/x86/include -I/usr/src/sys/amd64/compile/PHO     -MD  -MF.depend.linux_compat.o -MTlinux_compat.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-address-of-packed-member -Wno-format-zero-length   -mno-aes -mno-avx  -std=iso9899:1999 -c /usr/src/sys/compat/linuxkpi/common/src/linux_compat.c -o linux_compat.o
In file included from /usr/src/sys/compat/linuxkpi/common/src/linux_compat.c:103:
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:85:21: error: expected identifier
        rb_set_color(node, RB_RED);
                           ^
/usr/src/sys/sys/tree.h:344:17: note: expanded from macro 'RB_RED'
#define RB_RED          1
                        ^
In file included from /usr/src/sys/compat/linuxkpi/common/src/linux_compat.c:103:
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:85:21: error: expected identifier
/usr/src/sys/sys/tree.h:344:17: note: expanded from macro 'RB_RED'
#define RB_RED          1
                        ^
In file included from /usr/src/sys/compat/linuxkpi/common/src/linux_compat.c:103:
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:85:21: error: expected identifier
/usr/src/sys/sys/tree.h:344:17: note: expanded from macro 'RB_RED'
#define RB_RED          1
                        ^
In file included from /usr/src/sys/compat/linuxkpi/common/src/linux_compat.c:103:
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:85:21: error: expected identifier
/usr/src/sys/sys/tree.h:344:17: note: expanded from macro 'RB_RED'
#define RB_RED          1
                        ^
In file included from /usr/src/sys/compat/linuxkpi/common/src/linux_compat.c:103:
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:85:21: error: expected identifier
/usr/src/sys/sys/tree.h:344:17: note: expanded from macro 'RB_RED'
#define RB_RED          1
                        ^
In file included from /usr/src/sys/compat/linuxkpi/common/src/linux_compat.c:103:
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:85:2: error: use of undeclared identifier '__entry'
        rb_set_color(node, RB_RED);
        ^
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:64:47: note: expanded from macro 'rb_set_color'
#define rb_set_color(r, c)      RB_SET_COLOR(r, c, __entry)
                                                   ^

I installed the kernel and ran tests for 17 hours. Looks OK, except for this (probably) unrelated panic:
https://people.freebsd.org/~pho/stress/log/mjguzik027.txt
I have not been able to reproduce this one.

Jun 4 2020, 7:05 AM

Jun 3 2020

pho added a comment to D25105: Replace the rb_color field in an rb_node with a tag in the parent's pointer to the rb_node.

===> linuxkpi (all)
cc  -O2 -pipe -fno-common  -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -DKLD_TIED -nostdinc  -I/usr/src/sys/compat/linuxkpi/common/include -I/usr/src/sys/contrib/ck/include -DHAVE_KERNEL_OPTION_HEADERS -include /usr/src/sys/amd64/compile/PHO/opt_global.h -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common -g -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include -fdebug-prefix-map=./x86=/usr/src/sys/x86/include -I/usr/src/sys/amd64/compile/PHO     -MD  -MF.depend.linux_compat.o -MTlinux_compat.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-address-of-packed-member -Wno-format-zero-length   -mno-aes -mno-avx  -std=iso9899:1999 -c /usr/src/sys/compat/linuxkpi/common/src/linux_compat.c -o linux_compat.o
In file included from /usr/src/sys/compat/linuxkpi/common/src/linux_compat.c:103:
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:85:2: error: implicit declaration of function 'RB_COLOR' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        rb_set_color(node, RB_RED);
        ^
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:64:28: note: expanded from macro 'rb_set_color'
#define rb_set_color(r, c)      rb_color((r)) = (c)
                                ^
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:60:21: note: expanded from macro 'rb_color'
#define rb_color(r)     RB_COLOR(r, __entry)
                        ^
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:85:2: error: use of undeclared identifier '__entry'
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:64:28: note: expanded from macro 'rb_set_color'
#define rb_set_color(r, c)      rb_color((r)) = (c)
                                ^
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:60:33: note: expanded from macro 'rb_color'
#define rb_color(r)     RB_COLOR(r, __entry)
                                    ^
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:85:21: error: use of undeclared identifier 'RB_RED'
        rb_set_color(node, RB_RED);
                           ^
3 errors generated.
*** Error code 1

Jun 3 2020, 4:21 AM

Jun 2 2020

pho added a comment to D25105: Replace the rb_color field in an rb_node with a tag in the parent's pointer to the rb_node.

I booted with your patch after fixing a few obvious errors and got:

Jun 2 2020, 7:29 PM

pho added a comment to D25105: Replace the rb_color field in an rb_node with a tag in the parent's pointer to the rb_node.

This is the first problem I ran into:

cc -c -O2 -pipe -fno-strict-aliasing  -g -nostdinc  -I. -I../../.. -I../../../contrib/ck/include -I../../../contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common    -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -MD  -MF.depend.if_an.o -MTif_an.o -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include -fdebug-prefix-map=./x86=/usr/src/sys/x86/include -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-address-of-packed-member -Wno-format-zero-length   -mno-aes -mno-avx  -std=iso9899:1999 -Werror  ../../../dev/an/if_an.c
In file included from ../../../dev/an/if_an.c:129:
In file included from ../../../netinet/in_var.h:53:
../../../sys/tree.h:323:10: error: 'stdint.h' file not found with <angled> include; use "quotes" instead
#include <stdint.h>
         ^~~~~~~~~~
         "stdint.h"
1 error generated.
*** Error code 1

Jun 2 2020, 7:21 PM

pho added a comment to D25089: Drop unneeded null tests from RB_REMOVE_COLOR.

I ran stress2 tests for 12 hours followed by a buildworld.
D25089.72543.diff LGTM.

Jun 2 2020, 9:00 AM

Jun 1 2020

pho added a comment to D25089: Drop unneeded null tests from RB_REMOVE_COLOR.

In D25089#552731, @dougm wrote:

I apologize for failing to test for successful compilation.

Jun 1 2020, 8:16 PM

pho added a comment to D25089: Drop unneeded null tests from RB_REMOVE_COLOR.

cc  -O2 -pipe -fno-strict-aliasing  -g -nostdinc  -I. -I../../.. -I../../../contrib/ck/include -I../../../contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common    -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer  -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include -fdebug-prefix-map=./x86=/usr/src/sys/x86/include -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-address-of-packed-member -Wno-format-zero-length   -mno-aes -mno-avx  -std=iso9899:1999 -c /usr/src/sys/vm/vm_phys.c -o /usr/src/sys/vm/vm_phys.o
/usr/src/sys/vm/vm_phys.c:103:1: error: called object type 'int' is not a function or function pointer
RB_GENERATE_STATIC(fict_tree, vm_phys_fictitious_seg, node,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../../sys/tree.h:424:2: note: expanded from macro 'RB_GENERATE_STATIC'
        RB_GENERATE_INTERNAL(name, type, field, cmp, __unused static)
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../../sys/tree.h:427:2: note: expanded from macro 'RB_GENERATE_INTERNAL'
        RB_GENERATE_REMOVE_COLOR(name, type, field, attr)               \
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../../sys/tree.h:510:5: note: expanded from macro 'RB_GENERATE_REMOVE_COLOR'
                                RB_COLOR(RB_RIGHT(tmp, field), field) = RB_BLACK; \
                                ^
../../../sys/tree.h:323:31: note: expanded from macro 'RB_COLOR'
#define RB_COLOR(elm, field)            (elm)->field.rbe_color
                                        ^
/usr/src/sys/vm/vm_phys.c:103:1: error: too few arguments provided to function-like macro invocation
../../../sys/tree.h:424:2: note: expanded from macro 'RB_GENERATE_STATIC'
        RB_GENERATE_INTERNAL(name, type, field, cmp, __unused static)
        ^
../../../sys/tree.h:427:2: note: expanded from macro 'RB_GENERATE_INTERNAL'
        RB_GENERATE_REMOVE_COLOR(name, type, field, attr)               \
        ^
../../../sys/tree.h:536:36: note: expanded from macro 'RB_GENERATE_REMOVE_COLOR'
                        if (RB_ISRED(RB_LEFT(tmp, field)))              \
                                                        ^
../../../sys/tree.h:324:9: note: macro 'RB_ISRED' defined here
#define RB_ISRED(elm, field)            ((elm) != NULL && RB_COLOR(elm, field) == RB_RED)
        ^
/usr/src/sys/vm/vm_phys.c:103:1: error: use of undeclared identifier 'RB_ISRED'
RB_GENERATE_STATIC(fict_tree, vm_phys_fictitious_seg, node,
^
../../../sys/tree.h:424:2: note: expanded from macro 'RB_GENERATE_STATIC'
        RB_GENERATE_INTERNAL(name, type, field, cmp, __unused static)
        ^
../../../sys/tree.h:427:2: note: expanded from macro 'RB_GENERATE_INTERNAL'
        RB_GENERATE_REMOVE_COLOR(name, type, field, attr)               \
        ^
../../../sys/tree.h:536:8: note: expanded from macro 'RB_GENERATE_REMOVE_COLOR'
                        if (RB_ISRED(RB_LEFT(tmp, field)))              \
                            ^
3 errors generated.
*** Error code 1

Jun 1 2020, 7:06 PM

pho added a comment to D25089: Drop unneeded null tests from RB_REMOVE_COLOR.

Uptime with D25089.72515.diff is three hours.

Jun 1 2020, 12:50 PM

pho added a comment to D25089: Drop unneeded null tests from RB_REMOVE_COLOR.

I got this page fault with D25089.72507.diff:

Jun 1 2020, 8:18 AM

May 29 2020

pho added a comment to D25032: Simpilfy RB_REMOVE.

I ran stress2 tests for 39 hours with D25032.72341.diff, without seeing any problems

May 29 2020, 7:08 PM

May 21 2020

pho added a comment to D24845: Reorder manipulations in RB_REMOVE.

I completed a full stress2 test of D24845.71955.diff. No problems seen except for this known iflib problem: https://people.freebsd.org/~pho/stress/log/dougm070.txt

May 21 2020, 5:30 AM

May 20 2020

pho added a comment to D24839: Don't block on the range lock in zfs_getpages()..

I ran the few stress2 test cases that uses zfs in a loop for 3 hours. No problems seen.

May 20 2020, 11:13 AM

May 19 2020

pho added a comment to D24845: Reorder manipulations in RB_REMOVE.

I ran all but the last 7 stress2 tests on D24845.71808.diff without seeing any problems.
I'm now switching to D24845.71955.diff

May 19 2020, 4:36 AM

May 17 2020

pho added a comment to D24088: handle disk I/O errors in FFS with softdep enabled..

In D24088#547321, @mckusick wrote:

Peter,
Can you run one more test run over this code just to be sure that it patches cleanly and that none of our final changes broke anything?

May 17 2020, 2:07 PM

May 13 2020

pho committed rS361005: Added two syzkaller reproducers..

Added two syzkaller reproducers.

May 13 2020, 6:48 AM

pho committed rS361004: Added a syzkaller reproducer..

Added a syzkaller reproducer.

May 13 2020, 6:45 AM

pho committed rS361003: Added a regression test..

Added a regression test.

May 13 2020, 6:42 AM

May 2 2020

pho added a comment to D24088: handle disk I/O errors in FFS with softdep enabled..

In D24088#542747, @chs wrote:

Are there any more comments on this diff?

May 2 2020, 2:11 PM

Apr 27 2020

pho committed rS360367: Added cleanup after test..

Added cleanup after test.

Apr 27 2020, 5:27 AM

pho committed rS360366: Tune test a bit to avoid false positives..

Tune test a bit to avoid false positives.

Apr 27 2020, 5:25 AM

pho committed rS360365: Added a socketpair(2) test scenario..

Added a socketpair(2) test scenario.

Apr 27 2020, 5:24 AM

pho committed rS360364: Added more sendfile(2) tests..

Added more sendfile(2) tests.

Apr 27 2020, 5:23 AM

Apr 13 2020

pho committed rS359852: Fix the mmap() argument type. The test now works as expected..

Fix the mmap() argument type. The test now works as expected.

Apr 13 2020, 8:56 AM

Apr 12 2020

pho committed rS359821: Fix cleanup..

Fix cleanup.

Apr 12 2020, 6:01 AM

pho committed rS359820: Added more syzkaller reproducers..

Added more syzkaller reproducers.

Apr 12 2020, 5:59 AM

pho committed rS359819: Added more sendfile() regression tests..

Added more sendfile() regression tests.

Apr 12 2020, 5:57 AM

Apr 9 2020

pho committed rS359744: Update the exclude list..

Update the exclude list.

Apr 9 2020, 8:34 AM

pho committed rS359743: Limit runtime..

Limit runtime.

Apr 9 2020, 8:33 AM

pho committed rS359742: Fix false positive warnings seen..

Fix false positive warnings seen.

Apr 9 2020, 8:28 AM

pho committed rS359741: Fix indent warnings from cc..

Fix indent warnings from cc.

Apr 9 2020, 8:26 AM

Mar 11 2020

pho added a comment to D23965: x86: Support IO APICs on newer big Intel machines and hypervisors..

I booted with this on:

CPU: Intel(R) Xeon(R) CPU E5-2620 0 @ 2.00GHz (1995.24-MHz K8-class CPU)
CPU: Intel(R) Xeon(R) CPU E5-1650 v3 @ 3.50GHz (3500.07-MHz K8-class CPU)
CPU: AMD Phenom(tm) 9150e Quad-Core Processor (1800.02-MHz 686-class CPU)

No ioapic warnings seen.

Mar 11 2020, 7:08 AM