Page MenuHomeFreeBSD

pho (Peter Holm)
User

Projects

User Details

User Since
Aug 6 2014, 5:32 AM (337 w, 5 d)

Recent Activity

Sat, Jan 23

pho added a comment to D28306: nfs client: block vnode_pager_setsize() calls from nfscl_loadattrcache in nfs_write.

I ran the 29 NFS tests I have with D28306.82766.diff. This was a 2 1/2 hour test.
No problems seen.

Sat, Jan 23, 2:09 PM

Thu, Jan 21

pho added a comment to D28219: Restrict supported alignment for malloc_domainset_aligned(9) to PAGE_SIZE..

I ran tests with D28219.82645.diff for 6 hours. No problems seen.

Thu, Jan 21, 12:36 AM

Wed, Jan 20

pho added a comment to D28219: Restrict supported alignment for malloc_domainset_aligned(9) to PAGE_SIZE..

I ran tests with D28219.82616.diff on amd64 for two hours. No problems seen.

Wed, Jan 20, 5:13 PM

Sun, Jan 17

pho added a comment to D28147: Add malloc_domainset_aligned(9) and use it in x86 busdma bounce..

I tested D28147.82306.diff on i386 for 8 hours and on amd64 for 47 hours. No problems seen.

Sun, Jan 17, 12:27 PM

Mon, Jan 11

pho added a comment to D27956: amd64 pmap: do not sleep in _pmap_allocpte() with zero referenced page table page..

I ran a two-hour test on two different hosts with D27956.81970.diff added.
No problems seen.

Mon, Jan 11, 8:41 PM

Fri, Jan 8

pho added a comment to D27986: x86 tsc: use RDTSCP in preference of fence + RDTSC.

I ran stress tests on two different hosts for an hour. No problems seen.

Fri, Jan 8, 11:43 AM

Tue, Jan 5

pho added a comment to D27956: amd64 pmap: do not sleep in _pmap_allocpte() with zero referenced page table page..

I ran a full stress2 test on mercat1.

Tue, Jan 5, 9:46 PM

Fri, Jan 1

pho added a comment to D27871: Rework jobc handling..
20210101 07:17:42 all (6/740): machipc2.sh
panic: Lock (sx) proctree not locked @ kern/kern_proc.c:1172.
cpuid = 17
time = 1609481864
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe01c7c16ab0
vpanic() at vpanic+0x181/frame 0xfffffe01c7c16b00
panic() at panic+0x43/frame 0xfffffe01c7c16b60
witness_assert() at witness_assert+0x23a/frame 0xfffffe01c7c16b90
fill_kinfo_proc() at fill_kinfo_proc+0x4e/frame 0xfffffe01c7c16be0
kern_proc_out() at kern_proc_out+0x62/frame 0xfffffe01c7c17370
sysctl_out_proc() at sysctl_out_proc+0x68/frame 0xfffffe01c7c17840
sysctl_kern_proc() at sysctl_kern_proc+0x87/frame 0xfffffe01c7c17890
sysctl_root_handler_locked() at sysctl_root_handler_locked+0x9c/frame 0xfffffe01c7c178e0
sysctl_root() at sysctl_root+0x20d/frame 0xfffffe01c7c17960
userland_sysctl() at userland_sysctl+0x180/frame 0xfffffe01c7c17a10
sys___sysctl() at sys___sysctl+0x5f/frame 0xfffffe01c7c17ac0
amd64_syscall() at amd64_syscall+0x147/frame 0xfffffe01c7c17bf0
fast_syscall_common() at fast_syscall_common+0xf8/frame 0xfffffe01c7c17bf0
--- syscall (202, FreeBSD ELF64, sys___sysctl), rip = 0x8003fb9ea, rsp = 0x7fffffffd258, rbp = 0x7fffffffd290 ---
KDB: enter: panic
[ thread pid 78475 tid 792240 ]
Stopped at      kdb_enter+0x37: movq    $0,0x10960c6(%rip)
db>

https://people.freebsd.org/~pho/stress/log/log0014.txt

Fri, Jan 1, 6:48 AM

Thu, Dec 31

pho added a comment to D27871: Rework jobc handling..

I got a watchdog timeout with this patch: https://people.freebsd.org/~pho/stress/log/log0013.txt

Thu, Dec 31, 10:09 PM

Dec 15 2020

pho committed rS368655: Added more swapoff test scenarios..
Added more swapoff test scenarios.
Dec 15 2020, 7:31 AM

Dec 13 2020

pho committed R9:017f035cdd64: Added my name to the list. (authored by pho).
Added my name to the list.
Dec 13 2020, 7:50 PM
pho committed R9:d6a31437cdb2: Added myself (authored by pho).
Added myself
Dec 13 2020, 5:44 PM
pho committed R9:b2ad56bd3cd7: Added myself (authored by pho).
Added myself
Dec 13 2020, 5:44 PM

Dec 10 2020

pho committed rS368499: Limit overall runtime by giving all threads a chance to start before.
Limit overall runtime by giving all threads a chance to start before
Dec 10 2020, 5:51 AM
pho committed rS368498: Updated the exclude list. Improved script argument validation..
Updated the exclude list. Improved script argument validation.
Dec 10 2020, 5:48 AM
pho committed rS368497: Added two more syzkaller reproducers..
Added two more syzkaller reproducers.
Dec 10 2020, 5:46 AM
pho committed rS368496: Added more syzkaller reproducers..
Added more syzkaller reproducers.
Dec 10 2020, 5:45 AM

Dec 9 2020

pho committed rS368484: Added a syzkaller reproducer..
Added a syzkaller reproducer.
Dec 9 2020, 9:53 AM

Dec 6 2020

pho added a comment to D27457: ufs: handle two more cases of possible VNON vnode returned from VFS_VGET()..
In D27457#614233, @pho wrote:

I have added D27457.80263.diff to another test I'm running on mercat1. Uptime is 16 hours.

Dec 6 2020, 5:44 PM

Dec 5 2020

pho added a comment to D27457: ufs: handle two more cases of possible VNON vnode returned from VFS_VGET()..

I have added D27457.80263.diff to another test I'm running on mercat1. Uptime is 16 hours.

Dec 5 2020, 8:14 AM

Nov 28 2020

pho committed rS368120: Add a syzkaller reproducer..
Add a syzkaller reproducer.
Nov 28 2020, 8:08 AM

Nov 27 2020

pho committed rS368099: Ignore expected error message from umount(8)..
Ignore expected error message from umount(8).
Nov 27 2020, 9:08 AM
pho committed rS368098: Limit runtime..
Limit runtime.
Nov 27 2020, 9:05 AM
pho committed rS368096: Lower the overall runtime by ensuring that all tests start before the.
Lower the overall runtime by ensuring that all tests start before the
Nov 27 2020, 8:54 AM
pho committed rS368094: Dial down VM pressure a bit to avoid "CAM taskq" being stuck in vmwait..
Dial down VM pressure a bit to avoid "CAM taskq" being stuck in vmwait.
Nov 27 2020, 8:41 AM

Nov 20 2020

pho committed rS367864: Added two syzkaller reproducers..
Added two syzkaller reproducers.
Nov 20 2020, 8:07 AM

Nov 15 2020

pho committed rS367703: Load sctp.ko if needed..
Load sctp.ko if needed.
Nov 15 2020, 7:57 AM

Nov 5 2020

pho committed rS367363: Add a helper tool for file system tests..
Add a helper tool for file system tests.
Nov 5 2020, 7:59 AM

Oct 31 2020

pho added a comment to D26964: ufs: end-of-life truncate should depend on dirent write.

I have started a test of D26964.78800.diff.

Oct 31 2020, 3:02 AM

Oct 30 2020

pho committed rS367156: Added an old fsck_ffs(8) test scenario..
Added an old fsck_ffs(8) test scenario.
Oct 30 2020, 6:30 AM

Oct 29 2020

pho committed rS367133: Added when problem was fixed..
Added when problem was fixed.
Oct 29 2020, 2:28 PM

Oct 27 2020

pho committed rS367092: Added an old test, which just triggered a panic..
Added an old test, which just triggered a panic.
Oct 27 2020, 8:13 PM

Oct 22 2020

pho committed rS366928: Limit run time. Style fix while here..
Limit run time. Style fix while here.
Oct 22 2020, 6:51 AM
pho committed rS366927: Ensure the test terminates at timeout..
Ensure the test terminates at timeout.
Oct 22 2020, 6:50 AM
pho committed rS366926: Fix list issue with an interrupted test run..
Fix list issue with an interrupted test run.
Oct 22 2020, 6:48 AM
pho committed rS366925: Update test to reflect change in r366549..
Update test to reflect change in r366549.
Oct 22 2020, 6:44 AM

Oct 10 2020

pho committed rS366601: Handle sysctl name change from 'vm.max_wired' to 'vm.max_user_wired'..
Handle sysctl name change from 'vm.max_wired' to 'vm.max_user_wired'.
Oct 10 2020, 8:02 AM

Oct 4 2020

pho added a comment to D26628: Add sig_intr()..

I ran all of the stress2 tests with D26628.77727.
No problems seen.

Oct 4 2020, 2:59 PM

Oct 2 2020

pho added a comment to D26590: Implement sparse core dumps.

I ran all of the stress2 tests without observing any problems.

Oct 2 2020, 12:02 PM

Sep 25 2020

pho added a comment to D26511: Do not leak B_BARRIER..

I completed a test of D26511.77362.diff without seeing any problems.

Sep 25 2020, 4:29 AM

Sep 16 2020

pho added a comment to D26416: Fix fixjobc+orhpanage..

I have completed a full stress2 test.
I have not observed any problems with this patch.

Sep 16 2020, 6:40 PM

Aug 26 2020

pho committed rS364804: Removed unused include files..
Removed unused include files.
Aug 26 2020, 6:42 AM
pho committed rS364803: Fix a compiler warning..
Fix a compiler warning.
Aug 26 2020, 6:41 AM

Aug 25 2020

pho committed rS364752: Added a syzkaller reproducer..
Added a syzkaller reproducer.
Aug 25 2020, 5:16 AM

Aug 23 2020

pho committed rS364498: Added a new regression test..
Added a new regression test.
Aug 23 2020, 6:56 AM

Aug 20 2020

pho added a comment to D26136: Handle LoR in flush_pagedep_deps()..

I ran the syzkaller test scenario with this patch, but still still see the hang:

Aug 20 2020, 6:38 PM

Aug 16 2020

pho added a comment to D25968: VMIO read.

I ran a full stress2 test with this.

Aug 16 2020, 5:38 AM

Aug 15 2020

pho committed rS364243: Added comment about fixed revision..
Added comment about fixed revision.
Aug 15 2020, 6:24 AM
pho committed rS364242: Added missing cleanup..
Added missing cleanup.
Aug 15 2020, 6:22 AM

Aug 6 2020

pho added a comment to D21629: Add support for multithreading the inactive queue pageout within a domain..
In D21629#576019, @cem wrote:

FWIW, since yesterday we've run this under some Isilon workloads and it does seem to (1) function correctly and (2) alleviate load on the pagedaemon thread(s) (which were previously a bottleneck on some workloads, running at 100% CPU constantly).

Aug 6 2020, 3:52 PM
pho committed rS363943: Added comment about problem found..
Added comment about problem found.
Aug 6 2020, 7:27 AM
pho committed rS363942: Added a simple ext4 test scenario..
Added a simple ext4 test scenario.
Aug 6 2020, 6:57 AM

Aug 5 2020

pho committed rS363902: Update the no-run list..
Update the no-run list.
Aug 5 2020, 11:11 AM
pho committed rS363901: Added a new syzkaller reproducer..
Added a new syzkaller reproducer.
Aug 5 2020, 11:10 AM

Aug 4 2020

pho added a comment to D25952: UMA: Avoid polling for an invalid read sequence number..

@pho can you see if the buf_vlist_add() panic is still reproducible with this patch?

Aug 4 2020, 10:17 PM
pho added a comment to D25950: buf_trie_alloc: Spin on alloc failure.

No, UMA: https://people.freebsd.org/~pho/stress/log/mjguzik036.txt

Aug 4 2020, 7:03 PM
pho committed rS363828: Updated the test exclude list..
Updated the test exclude list.
Aug 4 2020, 6:40 AM
pho committed rS363827: Added a new syzkaller reproducer..
Added a new syzkaller reproducer.
Aug 4 2020, 6:38 AM
pho committed rS363826: Added a new syzkaller reproducer..
Added a new syzkaller reproducer.
Aug 4 2020, 6:37 AM
pho committed rS363825: Tests with SUJ shows a know deadlock issue..
Tests with SUJ shows a know deadlock issue.
Aug 4 2020, 6:34 AM

Aug 2 2020

pho added a comment to D25914: Unlocked getblk: Fix new false-positive assertion.
In D25914#574158, @pho wrote:

I am running tests with the scenario that triggered the panic multiple times.

Aug 2 2020, 5:51 AM

Aug 1 2020

pho added a comment to D25914: Unlocked getblk: Fix new false-positive assertion.

I am running tests with the scenario that triggered the panic multiple times.

Aug 1 2020, 8:28 PM

Jul 23 2020

pho added a comment to D25782: Add unlocked/SMR fast path to getblk().
In D25782#571014, @cem wrote:

Quite surprisingly to me, it doesn't seem to immediately panic. So I'm probably missing something.

Perhaps @pho would be willing to try and test this together with D25781?

I'd certainly appreciate it.

Jul 23 2020, 5:17 PM
pho added a comment to D25736: Avoid overflow in blist_create, remove swap pager checks before blist_create.
In D25736#570929, @kib wrote:

Sorry I did not stated that explicitly, the large swap should be a single volume. Blists are allocatd per swap device.

Jul 23 2020, 1:42 PM
pho added a comment to D25736: Avoid overflow in blist_create, remove swap pager checks before blist_create.
In D25736#570900, @kib wrote:
In D25736#570896, @pho wrote:
In D25736#570891, @kib wrote:
In D25736#570868, @pho wrote:

I completed a full stress2 test with D25736.74719.diff on r363390.
No problems seen.

How large the configured swap size was ? And how much of it was used (approximately) ?

$ ./swapused.sh 
FreeBSD t2.osted.lan 13.0-CURRENT FreeBSD 13.0-CURRENT #0 r363443M: Thu Jul 23 13:01:56 CEST 2020     pho@t2.osted.lan:/usr/src/sys/amd64/compile/PHO  amd64
swapinfo -h
Device              Size     Used    Avail Capacity
/dev/da0p4           67G       0B      67G     0%

swap disk
  1027604514   140509184    4  freebsd-swap  (67G)
13:08:48 0%
13:10:02 1%
13:10:09 2%
:
13:18:33 32%
13:18:55 33%

I think this patch mostly needs Marius' test sort /dev/zero.

This test is included in stress2 as sort.sh

67G is on the edge of the previous max 64G. Could you try only the Marius' test with much larger swap, say 128G or even 512G ?

Jul 23 2020, 12:51 PM
pho added a comment to D25736: Avoid overflow in blist_create, remove swap pager checks before blist_create.
In D25736#570891, @kib wrote:
In D25736#570868, @pho wrote:

I completed a full stress2 test with D25736.74719.diff on r363390.
No problems seen.

How large the configured swap size was ? And how much of it was used (approximately) ?

Jul 23 2020, 11:22 AM
pho added a comment to D25736: Avoid overflow in blist_create, remove swap pager checks before blist_create.

I completed a full stress2 test with D25736.74719.diff on r363390.
No problems seen.

Jul 23 2020, 6:52 AM

Jul 21 2020

pho added a comment to D25736: Avoid overflow in blist_create, remove swap pager checks before blist_create.

I have started a full stress2 test, which will take two days to complete.

Jul 21 2020, 5:26 AM

Jul 20 2020

pho added a comment to D25736: Avoid overflow in blist_create, remove swap pager checks before blist_create.

I ran a preliminary 2 hour test with D25736.74672.diff.

Jul 20 2020, 8:39 AM

Jul 1 2020

pho added a comment to D25480: Change from red-black to wavl balancing for RB trees.

I ran tests on D25480.73926.diff for 12 hours without seeing any problems.

Jul 1 2020, 4:37 PM

Jun 30 2020

pho committed rS362793: Updated the exclude list..
Updated the exclude list.
Jun 30 2020, 7:37 AM
pho committed rS362792: Added two syzkaller reproducers..
Added two syzkaller reproducers.
Jun 30 2020, 7:37 AM

Jun 29 2020

pho added a comment to D25480: Change from red-black to wavl balancing for RB trees.

I have started a full test of D25480.73797.diff.

Jun 29 2020, 7:44 AM
pho added a comment to D23913: vfs: introduce basic smr-protected path lookup.

I ran all of the stress2 tests on r362642 with D23913.73738.diff.
No problems seen.

Jun 29 2020, 4:51 AM

Jun 27 2020

pho added a comment to D25480: Change from red-black to wavl balancing for RB trees.

Yes, this compiles nicely.

Jun 27 2020, 12:38 PM
pho added a comment to D25480: Change from red-black to wavl balancing for RB trees.

Diff 73750 seems to only contain the man changes?

Jun 27 2020, 6:29 AM
pho added a comment to D25480: Change from red-black to wavl balancing for RB trees.

A r362642 kernel with D25480.73723.diff applied does not compile.

Jun 27 2020, 5:44 AM

Jun 25 2020

pho added a comment to D25418: Replace RB color field with tag bits in the parent pointer.

I ran tests with this patch for 21 hours (633 tests out of 718) without seeing any issues.

Jun 25 2020, 5:40 PM

Jun 24 2020

pho added a comment to D25418: Replace RB color field with tag bits in the parent pointer.

I ran a preliminary two hour test followed by a buildworld. No problems seen.

Jun 24 2020, 12:57 PM
pho added a comment to D25418: Replace RB color field with tag bits in the parent pointer.

https://people.freebsd.org/~pho/stress/log/dougm072.txt

Jun 24 2020, 7:30 AM
pho added a comment to D25418: Replace RB color field with tag bits in the parent pointer.
20200624 09:12:49 all (32/724): seekdir.sh
Jun 24 2020, 7:22 AM
pho added a comment to D25418: Replace RB color field with tag bits in the parent pointer.

Unfortunately a kernel with D25418.73541.diff applied does not compile.

Jun 24 2020, 5:42 AM

Jun 22 2020

pho committed rS362486: Style fix..
Style fix.
Jun 22 2020, 7:00 AM
pho committed rS362485: Added a syzkaller reproducer..
Added a syzkaller reproducer.
Jun 22 2020, 6:58 AM

Jun 18 2020

pho committed rS362266: Added a syzkaller reproducer..
Added a syzkaller reproducer.
Jun 18 2020, 9:25 AM
pho committed rS362267: Updated the exclude list..
Updated the exclude list.
Jun 18 2020, 9:20 AM
pho committed rS362268: Fix indent..
Fix indent.
Jun 18 2020, 9:20 AM
pho committed rS362269: Added a "fixed by"..
Added a "fixed by".
Jun 18 2020, 9:20 AM
pho added a comment to D25264: Define RB parent assignment macros.

I completed a full stress2 test with D25264.73113.diff.
No problems seen.

Jun 18 2020, 9:18 AM

Jun 14 2020

pho added a comment to D25264: Define RB parent assignment macros.

https://people.freebsd.org/~pho/stress/log/dougm071.txt

Jun 14 2020, 5:26 PM
pho added a comment to D25264: Define RB parent assignment macros.
===> linuxkpi (all)
cc  -O2 -pipe -fno-common  -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -DKLD_TIED -nostdinc  -I/usr/src/sys/compat/linuxkpi/common/include -I/usr/src/sys/contrib/ck/include -DHAVE_KERNEL_OPTION_HEADERS -include /usr/src/sys/amd64/compile/PHO/opt_global.h -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common -g -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include -fdebug-prefix-map=./x86=/usr/src/sys/x86/include -I/usr/src/sys/amd64/compile/PHO     -MD  -MF.depend.linux_compat.o -MTlinux_compat.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-address-of-packed-member -Wno-format-zero-length   -mno-aes -mno-avx  -std=iso9899:1999 -c /usr/src/sys/compat/linuxkpi/common/src/linux_compat.c -o linux_compat.o
In file included from /usr/src/sys/compat/linuxkpi/common/src/linux_compat.c:103:
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:87:2: error: no member named 'rbh_root' in 'struct rb_root'
        RB_SWAP_CHILD(root, victim, new, __entry);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/src/sys/sys/tree.h:354:3: note: expanded from macro 'RB_SWAP_CHILD'
                RB_ROOT(head) = (in);                                   \
                ^~~~~~~~~~~~~
/usr/src/sys/sys/tree.h:325:33: note: expanded from macro 'RB_ROOT'
#define RB_ROOT(head)                   (head)->rbh_root
                                        ~~~~~~  ^
1 error generated.
*** Error code 1
Jun 14 2020, 8:29 AM

Jun 9 2020

pho added a comment to D25105: Replace the rb_color field in an rb_node with a tag in the parent's pointer to the rb_node.

I completed a full stress2 test with D25105.72798.diff.

Jun 9 2020, 8:05 PM
pho committed rS361961: Added a syzkaller reproducer..
Added a syzkaller reproducer.
Jun 9 2020, 6:48 AM

Jun 7 2020

pho committed rS361890: Added a syzkaller reproducer..
Added a syzkaller reproducer.
Jun 7 2020, 12:15 PM

Jun 5 2020

pho committed rS361836: Fix a copy/paste error in multiple files..
Fix a copy/paste error in multiple files.
Jun 5 2020, 3:09 PM
pho added a comment to D25105: Replace the rb_color field in an rb_node with a tag in the parent's pointer to the rb_node.

D25105.72656.diff builds without any issues.
I ran stress2 tests for 12 hours followed by a buildkernel and a buildworld.
No problems seen.

Jun 5 2020, 6:34 AM

Jun 4 2020

pho added a comment to D25105: Replace the rb_color field in an rb_node with a tag in the parent's pointer to the rb_node.

Your patch still doesn't compile:

===> linuxkpi (all)
cc  -O2 -pipe -fno-common  -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -DKLD_TIED -nostdinc  -I/usr/src/sys/compat/linuxkpi/common/include -I/usr/src/sys/contrib/ck/include -DHAVE_KERNEL_OPTION_HEADERS -include /usr/src/sys/amd64/compile/PHO/opt_global.h -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common -g -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include -fdebug-prefix-map=./x86=/usr/src/sys/x86/include -I/usr/src/sys/amd64/compile/PHO     -MD  -MF.depend.linux_compat.o -MTlinux_compat.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-address-of-packed-member -Wno-format-zero-length   -mno-aes -mno-avx  -std=iso9899:1999 -c /usr/src/sys/compat/linuxkpi/common/src/linux_compat.c -o linux_compat.o
In file included from /usr/src/sys/compat/linuxkpi/common/src/linux_compat.c:103:
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:85:21: error: expected identifier
        rb_set_color(node, RB_RED);
                           ^
/usr/src/sys/sys/tree.h:344:17: note: expanded from macro 'RB_RED'
#define RB_RED          1
                        ^
In file included from /usr/src/sys/compat/linuxkpi/common/src/linux_compat.c:103:
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:85:21: error: expected identifier
/usr/src/sys/sys/tree.h:344:17: note: expanded from macro 'RB_RED'
#define RB_RED          1
                        ^
In file included from /usr/src/sys/compat/linuxkpi/common/src/linux_compat.c:103:
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:85:21: error: expected identifier
/usr/src/sys/sys/tree.h:344:17: note: expanded from macro 'RB_RED'
#define RB_RED          1
                        ^
In file included from /usr/src/sys/compat/linuxkpi/common/src/linux_compat.c:103:
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:85:21: error: expected identifier
/usr/src/sys/sys/tree.h:344:17: note: expanded from macro 'RB_RED'
#define RB_RED          1
                        ^
In file included from /usr/src/sys/compat/linuxkpi/common/src/linux_compat.c:103:
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:85:21: error: expected identifier
/usr/src/sys/sys/tree.h:344:17: note: expanded from macro 'RB_RED'
#define RB_RED          1
                        ^
In file included from /usr/src/sys/compat/linuxkpi/common/src/linux_compat.c:103:
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:85:2: error: use of undeclared identifier '__entry'
        rb_set_color(node, RB_RED);
        ^
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:64:47: note: expanded from macro 'rb_set_color'
#define rb_set_color(r, c)      RB_SET_COLOR(r, c, __entry)
                                                   ^

I installed the kernel and ran tests for 17 hours. Looks OK, except for this (probably) unrelated panic:
https://people.freebsd.org/~pho/stress/log/mjguzik027.txt
I have not been able to reproduce this one.

Jun 4 2020, 7:05 AM

Jun 3 2020

pho added a comment to D25105: Replace the rb_color field in an rb_node with a tag in the parent's pointer to the rb_node.
===> linuxkpi (all)
cc  -O2 -pipe -fno-common  -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -DKLD_TIED -nostdinc  -I/usr/src/sys/compat/linuxkpi/common/include -I/usr/src/sys/contrib/ck/include -DHAVE_KERNEL_OPTION_HEADERS -include /usr/src/sys/amd64/compile/PHO/opt_global.h -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common -g -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include -fdebug-prefix-map=./x86=/usr/src/sys/x86/include -I/usr/src/sys/amd64/compile/PHO     -MD  -MF.depend.linux_compat.o -MTlinux_compat.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-address-of-packed-member -Wno-format-zero-length   -mno-aes -mno-avx  -std=iso9899:1999 -c /usr/src/sys/compat/linuxkpi/common/src/linux_compat.c -o linux_compat.o
In file included from /usr/src/sys/compat/linuxkpi/common/src/linux_compat.c:103:
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:85:2: error: implicit declaration of function 'RB_COLOR' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        rb_set_color(node, RB_RED);
        ^
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:64:28: note: expanded from macro 'rb_set_color'
#define rb_set_color(r, c)      rb_color((r)) = (c)
                                ^
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:60:21: note: expanded from macro 'rb_color'
#define rb_color(r)     RB_COLOR(r, __entry)
                        ^
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:85:2: error: use of undeclared identifier '__entry'
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:64:28: note: expanded from macro 'rb_set_color'
#define rb_set_color(r, c)      rb_color((r)) = (c)
                                ^
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:60:33: note: expanded from macro 'rb_color'
#define rb_color(r)     RB_COLOR(r, __entry)
                                    ^
/usr/src/sys/compat/linuxkpi/common/include/linux/rbtree.h:85:21: error: use of undeclared identifier 'RB_RED'
        rb_set_color(node, RB_RED);
                           ^
3 errors generated.
*** Error code 1
Jun 3 2020, 4:21 AM

Jun 2 2020

pho added a comment to D25105: Replace the rb_color field in an rb_node with a tag in the parent's pointer to the rb_node.

I booted with your patch after fixing a few obvious errors and got:

Jun 2 2020, 7:29 PM
pho added a comment to D25105: Replace the rb_color field in an rb_node with a tag in the parent's pointer to the rb_node.

This is the first problem I ran into:

cc -c -O2 -pipe -fno-strict-aliasing  -g -nostdinc  -I. -I../../.. -I../../../contrib/ck/include -I../../../contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common    -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -MD  -MF.depend.if_an.o -MTif_an.o -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include -fdebug-prefix-map=./x86=/usr/src/sys/x86/include -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-address-of-packed-member -Wno-format-zero-length   -mno-aes -mno-avx  -std=iso9899:1999 -Werror  ../../../dev/an/if_an.c
In file included from ../../../dev/an/if_an.c:129:
In file included from ../../../netinet/in_var.h:53:
../../../sys/tree.h:323:10: error: 'stdint.h' file not found with <angled> include; use "quotes" instead
#include <stdint.h>
         ^~~~~~~~~~
         "stdint.h"
1 error generated.
*** Error code 1
Jun 2 2020, 7:21 PM