Page MenuHomeFreeBSD

pho (Peter Holm)
User

Projects

User Details

User Since
Aug 6 2014, 5:32 AM (383 w, 5 h)

Recent Activity

Today

pho added a comment to D33312: Use bitstrings for reservation popmaps.

I ran stress test for 24 hours with D33312.99617.diff without seeing any problems.

Wed, Dec 8, 8:46 AM

Yesterday

pho added a comment to D33312: Use bitstrings for reservation popmaps.

Which revision did you create the diff from?

I hope this is the kind of answer you're looking for:
commit e3044071dec1d752a7103b5ae55fe3cff2f5b957 (HEAD -> main, freebsd/main, freebsd/HEAD)

Tue, Dec 7, 8:42 AM
pho added a comment to D33312: Use bitstrings for reservation popmaps.

Which revision did you create the diff from?

Tue, Dec 7, 7:21 AM

Sun, Dec 5

pho committed R10:e86b5a623420: stress2: This test runs for hours with ASLR enabled (authored by pho).
stress2: This test runs for hours with ASLR enabled
Sun, Dec 5, 5:47 AM

Sat, Nov 27

pho committed R10:7184e8c21107: Keep running fsck_ffs as long as "WAS MODIFIED" is reported (authored by pho).
Keep running fsck_ffs as long as "WAS MODIFIED" is reported
Sat, Nov 27, 10:58 AM

Thu, Nov 25

pho committed R10:171e56c19a11: stress2: Added an option to set the file size. Added missing error checks (authored by pho).
stress2: Added an option to set the file size. Added missing error checks
Thu, Nov 25, 11:46 AM

Wed, Nov 24

pho added a comment to D33008: Clean up unionfs thread arguments and implement VOP_VPUT_PAIR.

All of the unions tests in stress2 runs without any issues when D33008.98931.diff is added.

Wed, Nov 24, 7:12 PM

Mon, Nov 15

pho committed R10:fb4114332463: Added a new unionfs test scenario. Removed a few old unionfs tests from (authored by pho).
Added a new unionfs test scenario. Removed a few old unionfs tests from
Mon, Nov 15, 9:43 AM

Thu, Nov 11

pho committed R10:7e3c4b09a09e: stress2: Added two test scenarios for future gunion(8) (authored by pho).
stress2: Added two test scenarios for future gunion(8)
Thu, Nov 11, 9:13 AM

Wed, Nov 10

pho committed R10:6ffad483ff66: stress2: Added a new zfs test scenario (authored by pho).
stress2: Added a new zfs test scenario
Wed, Nov 10, 9:29 AM

Tue, Nov 9

pho committed R10:7b83aad3ffab: stress2: Exclude the files in .git. Simplify test by using timeout(1) (authored by pho).
stress2: Exclude the files in .git. Simplify test by using timeout(1)
Tue, Nov 9, 8:30 AM

Oct 29 2021

pho committed R10:97a74bbe38eb: stress2: Added a regression test (authored by pho).
stress2: Added a regression test
Oct 29 2021, 9:05 AM

Oct 26 2021

pho committed R10:cbc3ecb7ef08: stress2: Added two syzkaller reproducers (authored by pho).
stress2: Added two syzkaller reproducers
Oct 26 2021, 10:00 AM

Oct 23 2021

pho committed R10:50b8e3efaf9e: stress2: Fix typo (authored by pho).
stress2: Fix typo
Oct 23 2021, 6:40 AM

Oct 20 2021

pho committed R10:8d7fe65348a2: stress2: Added a "mdconfig -o force" test scenario (authored by pho).
stress2: Added a "mdconfig -o force" test scenario
Oct 20 2021, 6:04 AM

Oct 18 2021

pho committed R10:6deacc1b3b7a: stress2: Move test added by mistake (authored by pho).
stress2: Move test added by mistake
Oct 18 2021, 1:33 PM
pho committed R10:26c1772071f7: stress2: Added a syzkaller reproducer (authored by pho).
stress2: Added a syzkaller reproducer
Oct 18 2021, 7:41 AM
pho added a comment to D32533: unionfs: implement vnode-based cache lookup.

I no longer see the message "mkdir.c:120: No such file or directory" with D32533.96980.diff applied.

Oct 18 2021, 7:37 AM

Oct 12 2021

pho committed R10:fc22fe5c7405: stress2: Use two memory disks for this test (authored by pho).
stress2: Use two memory disks for this test
Oct 12 2021, 6:46 AM

Oct 8 2021

pho committed R10:89ec6dcce03b: stress2: Added a regression test (authored by pho).
stress2: Added a regression test
Oct 8 2021, 6:39 AM
pho committed R10:e6c28c2465d8: stress2: exclude known problem test (authored by pho).
stress2: exclude known problem test
Oct 8 2021, 6:36 AM

Sep 27 2021

pho added a comment to D32148: unionfs: Ensure SAVENAME is set for unionfs vnode operations.

I got this panic while testing with D32148.95756.diff:

Sep 27 2021, 8:38 AM

Sep 20 2021

pho added a comment to D31917: unionfs: lock newly-created vnodes before calling insmntque().

I got this with a NON-DIAGNOSTIC build:

Sep 20 2021, 8:23 AM
pho committed R10:9ac518adf03e: stress2: Update test to ensure propper cleanup of fifo files (authored by pho).
stress2: Update test to ensure propper cleanup of fifo files
Sep 20 2021, 7:39 AM

Sep 16 2021

pho committed R10:bab406830ab6: stress2: Added more unionfs tests (authored by pho).
stress2: Added more unionfs tests
Sep 16 2021, 6:30 AM

Sep 15 2021

pho accepted D31963: stress2: replace fuse.ko with fusefs.ko.

Looks good to me.

Sep 15 2021, 7:48 AM

Sep 14 2021

pho committed R10:94c678cf19ca: stress2: A two second timeout is too short (authored by pho).
stress2: A two second timeout is too short
Sep 14 2021, 7:52 AM

Sep 13 2021

pho committed R10:89379af43f11: stress2: Update test to the sysctl 'vfs.lookup_shared' being removed (authored by pho).
stress2: Update test to the sysctl 'vfs.lookup_shared' being removed
Sep 13 2021, 8:58 AM
pho committed R10:ddd74e40e27d: stress2: Added missing unmount (authored by pho).
stress2: Added missing unmount
Sep 13 2021, 8:58 AM

Sep 9 2021

pho committed R10:f2c9a8b9d95d: stress2: Add a syzkaller reproducer (authored by pho).
stress2: Add a syzkaller reproducer
Sep 9 2021, 7:31 AM

Sep 6 2021

pho committed R10:c86a43f1c7db: stress2: Added a syzkaller reproducer (authored by pho).
stress2: Added a syzkaller reproducer
Sep 6 2021, 1:33 PM

Sep 5 2021

pho committed R10:bb61ccd530b7: stress2: Added missing ktrace() cleanup (authored by pho).
stress2: Added missing ktrace() cleanup
Sep 5 2021, 7:03 AM

Sep 2 2021

pho committed R10:dbb0cb19ec7f: stress2: Update test to new working of option nomtime (authored by pho).
stress2: Update test to new working of option nomtime
Sep 2 2021, 7:17 AM
pho committed R10:78f718e2c835: stress2: Added timeout for looping mdnsd (authored by pho).
stress2: Added timeout for looping mdnsd
Sep 2 2021, 7:17 AM
pho committed R10:2a58b9c5db8a: stress2: Fix cleanup (authored by pho).
stress2: Fix cleanup
Sep 2 2021, 7:16 AM
pho committed R10:d57bfbce7c99: stress2: Fix cleanup (authored by pho).
stress2: Fix cleanup
Sep 2 2021, 7:16 AM
pho committed R10:9d1eb47fa113: stress2: Fix cleanup (authored by pho).
stress2: Fix cleanup
Sep 2 2021, 7:16 AM
pho committed R10:d5c541c2678b: stress2: Make test less verbose (authored by pho).
stress2: Make test less verbose
Sep 2 2021, 7:15 AM

Aug 29 2021

pho committed R10:22f5f4a14e97: stress2: Added new msdosfs rename() tests (authored by pho).
stress2: Added new msdosfs rename() tests
Aug 29 2021, 6:39 AM

Jul 25 2021

pho committed R10:0d60235ecd6c: stress2: Add another "mdconfig -d -o force" test scenario (authored by pho).
stress2: Add another "mdconfig -d -o force" test scenario
Jul 25 2021, 7:02 AM

Jul 24 2021

pho added a comment to D31016: Allow stacked filesystems to be recursively unmounted.

Peter, thank you for testing this out!

Do you think there's any value in committing gnop11.sh as-is? I know you said the I/O completed too quickly on your faster machine; would you prefer a shorter sleep, say 0.1s? Or would you rather have a different test altogether?

You should commit gnop11.sh as is. The stacked use of nullfs is definetly in the spirit of stress2.

Jul 24 2021, 4:48 AM

Jul 23 2021

pho added a comment to D31016: Allow stacked filesystems to be recursively unmounted.
In D31016#704507, @kib wrote:
In D31016#704447, @pho wrote:

All done. No problems seen.

20210722 19:00:47 all.sh done, elapsed 2 day(s), 04:40.10

And no nullfs issues observed? I am confused.

Jul 23 2021, 7:05 AM

Jul 22 2021

pho added a comment to D31016: Allow stacked filesystems to be recursively unmounted.
In D31016#703154, @pho wrote:

I am fine with the structure of this patch. I do ask that you await passing Peter Holm's tests before committing.

I have started a full test with D31016.92436.diff.

Jul 22 2021, 5:15 PM

Jul 20 2021

pho added a comment to D31016: Allow stacked filesystems to be recursively unmounted.

I am fine with the structure of this patch. I do ask that you await passing Peter Holm's tests before committing.

Jul 20 2021, 5:33 AM

Jul 19 2021

pho added a comment to D31016: Allow stacked filesystems to be recursively unmounted.

I still see this: https://people.freebsd.org/~pho/stress/log/log0139.txt

Jul 19 2021, 5:05 AM

Jul 16 2021

pho added a comment to D31016: Allow stacked filesystems to be recursively unmounted.
In D31016#702230, @jah wrote:

@jah - are you ready to have Peter Holm test these changes? If so, I will enlist his help.

Yes, in fact I've been using the unionfs/nullfs stress2 tests as the basis for crude manual testing of this code, but it would be nice to have something automated.
It'd be nice to have an automated that exercises recursive unmounts concurrently with both other recursive and non-recursive unmounts within the same stacked filesystem hierarchy.

I've added Peter here. I gladly help write any needed tests, but I could use some guidance on what we might already have that could be a starting point.

Jul 16 2021, 5:00 AM

Jul 14 2021

pho committed R10:8616f8aff1f0: stress2: Pass program exit code to shell script exit. Do not loop forever in… (authored by pho).
stress2: Pass program exit code to shell script exit. Do not loop forever in…
Jul 14 2021, 6:01 AM

Jul 5 2021

pho committed R10:c5d6dd80b54b: stress2: Wait for the "swap" program to terminate (authored by pho).
stress2: Wait for the "swap" program to terminate
Jul 5 2021, 7:18 AM
pho committed R10:7ebe83ddb788: stress2: Limit scope of rm(1) wildcard in cleanup. (authored by pho).
stress2: Limit scope of rm(1) wildcard in cleanup.
Jul 5 2021, 7:16 AM

Jul 2 2021

pho committed R10:fe5d22f8f487: stress2: Added a test scenario from Bug 227041 (authored by pho).
stress2: Added a test scenario from Bug 227041
Jul 2 2021, 5:27 AM
pho committed R10:e02046f74728: stress2: Update the list of test not to run (authored by pho).
stress2: Update the list of test not to run
Jul 2 2021, 5:26 AM
pho committed R10:5bd70f050072: stress2: Improve cleanup code (authored by pho).
stress2: Improve cleanup code
Jul 2 2021, 5:26 AM

Jun 19 2021

pho committed R10:3f770843d55c: stress2: Add snap8.sh back on the exclude list (authored by pho).
stress2: Add snap8.sh back on the exclude list
Jun 19 2021, 5:05 AM

Jun 15 2021

pho committed R10:afce58357164: stress2: Added a new verified syzkaller reproducer, update the exclude list and… (authored by pho).
stress2: Added a new verified syzkaller reproducer, update the exclude list and…
Jun 15 2021, 5:37 AM

Jun 10 2021

pho committed R10:4ab5c88da287: stress2: Exclude new syzkaller tests (authored by pho).
stress2: Exclude new syzkaller tests
Jun 10 2021, 2:31 AM

Jun 7 2021

pho committed R10:201434ecaca7: stress2: Added two test scenarios based on Bug 256205 (authored by pho).
stress2: Added two test scenarios based on Bug 256205
Jun 7 2021, 5:37 AM
pho committed R10:b3b695604de3: stress2: Added a few syzkaller reproducers (authored by pho).
stress2: Added a few syzkaller reproducers
Jun 7 2021, 5:36 AM

Jun 3 2021

pho committed R10:8682abbf7bff: stress2: Remove thr_new() from the ignore list after 6cda62755612 (authored by pho).
stress2: Remove thr_new() from the ignore list after 6cda62755612
Jun 3 2021, 5:24 AM

May 27 2021

pho committed R10:0a9e7899e270: stress2: Removed three mksnap_ffs(8) tests from the exclude list (authored by pho).
stress2: Removed three mksnap_ffs(8) tests from the exclude list
May 27 2021, 6:55 AM

May 26 2021

pho committed R10:0b5d6b8173d9: stress2: Added a new ptrace() test scenario (authored by pho).
stress2: Added a new ptrace() test scenario
May 26 2021, 6:10 AM
pho committed R10:bad9303974fc: stress2: Update the exclude list (authored by pho).
stress2: Update the exclude list
May 26 2021, 6:10 AM
pho committed R10:79f27053e4e0: stress2: Fix cleanup on exit (authored by pho).
stress2: Fix cleanup on exit
May 26 2021, 6:10 AM

May 19 2021

pho committed R10:7de0aa01350e: stress2: Added a new "mdconfig -o force" test scenario (authored by pho).
stress2: Added a new "mdconfig -o force" test scenario
May 19 2021, 6:23 AM

May 14 2021

pho committed R10:2a60dec0919c: stress2: Added a regression test. Fixed a type on an old test (authored by pho).
stress2: Added a regression test. Fixed a type on an old test
May 14 2021, 7:20 AM

May 13 2021

pho committed R10:1025baec7b78: stress2: Added two new syzkaller reproducers. Update the exclude list (authored by pho).
stress2: Added two new syzkaller reproducers. Update the exclude list
May 13 2021, 5:59 AM

May 8 2021

pho committed R10:2018d4886281: stress2: Added two new syzkaller reproducers. Update the exclude list (authored by pho).
stress2: Added two new syzkaller reproducers. Update the exclude list
May 8 2021, 6:26 AM

May 4 2021

pho committed R10:c85b57ac0130: stress2: New test scenario added (authored by pho).
stress2: New test scenario added
May 4 2021, 10:58 AM

May 3 2021

pho committed R10:cff133b05ba1: stress2: Added a regression test (authored by pho).
stress2: Added a regression test
May 3 2021, 7:09 AM
pho committed R10:a7d46ad08709: stress2: Added a syzkaller reproducer (authored by pho).
stress2: Added a syzkaller reproducer
May 3 2021, 7:06 AM
pho committed R10:573bd33a33b6: stress2: Fix a typo. (authored by pho).
stress2: Fix a typo.
May 3 2021, 6:47 AM

Apr 27 2021

pho added a comment to D29970: tcp: stop spurious rescue retransmissions.

I ran all of the tcp tests I have followed by the problem test in a loop for 24 hours.
No problems seen.

Apr 27 2021, 3:53 AM

Apr 21 2021

pho added a comment to D29830: vn_open_vnode(): handle error when fp == NULL.
In D29830#669416, @pho wrote:

This fixes the issue for me. I have started a full test on mercat1.

Apr 21 2021, 2:53 PM

Apr 20 2021

pho added a comment to D29835: tcp: Deal with DSACKs, and adjust rescue hole on success..

I ran tests with D29835.87758.diff for 8 hours without seeing any issues.

Apr 20 2021, 12:10 PM

Apr 19 2021

pho added a comment to D29830: vn_open_vnode(): handle error when fp == NULL.

This fixes the issue for me. I have started a full test on mercat1.

Apr 19 2021, 10:51 AM
pho added a comment to D29825: tcp: keep SACK scoreboard sorted when doing rescue retransmission.

With main-n246162-b87cf2bc841 I now get:

Apr 19 2021, 5:22 AM

Apr 18 2021

pho added a comment to D29825: tcp: keep SACK scoreboard sorted when doing rescue retransmission.

db> x/s version
version: FreeBSD 14.0-CURRENT #1 main-n246155-b6a572d03f6-dirty: Sun Apr 18 22:20:42 CEST 2021\012 pho@mercat1.netperf.freebsd.org:/usr/src/sys/amd64/compile/PHO\012
db>

Is this with or without the patch in this review?

Apr 18 2021, 9:58 PM
pho added a comment to D29825: tcp: keep SACK scoreboard sorted when doing rescue retransmission.
20210418 22:25:18 all (1/1): jumbo.sh
stress2: pts leak: 1/2
20210418 22:26:21 all (1/1): jumbo.sh
20210418 22:27:20 all (1/1): jumbo.sh
20210418 22:28:20 all (1/1): jumbo.sh
20210418 22:29:20 all (1/1): jumbo.sh
20210418 22:30:20 all.sh done, elapsed 0 day(s), 00:05.03
Apr 18 2021, 8:47 PM
pho committed R10:7f014be5eace: stress2: Added a syzkaller reproducer. A variation of syzkaller32.sh (authored by pho).
stress2: Added a syzkaller reproducer. A variation of syzkaller32.sh
Apr 18 2021, 5:24 AM

Apr 14 2021

pho added a comment to D29752: sbuf_uionew(): sbuf_new() takes int as length.

D29752.87397.diff looks good to me. Tested with syscall fuzzing of:

Apr 14 2021, 7:09 AM

Apr 13 2021

pho added a comment to D29747: preadv(2), pwrite(2): validate uio_resid.

This patch does not fix the issue for me using this test scenario:


https://people.freebsd.org/~pho/stress/log/log0091.txt

Apr 13 2021, 5:24 PM

Apr 4 2021

pho committed R10:6f646494e1a8: stress2: Added a new regression test (authored by pho).
stress2: Added a new regression test
Apr 4 2021, 8:37 AM
pho committed R10:a17a9c931a65: stress2: update the list of test not to run (authored by pho).
stress2: update the list of test not to run
Apr 4 2021, 8:37 AM
pho committed R10:332a6001389f: stress2: Add note about problems found. (authored by pho).
stress2: Add note about problems found.
Apr 4 2021, 8:37 AM

Mar 22 2021

pho committed R10:e54257d92a7a: stress2: Updated the exclude list (authored by pho).
stress2: Updated the exclude list
Mar 22 2021, 10:33 AM
pho committed R10:6d5586da633b: stress2: Added two syzkaller reproducers. (authored by pho).
stress2: Added two syzkaller reproducers.
Mar 22 2021, 10:28 AM

Mar 15 2021

pho committed R10:cefb959e18ef: stress2: Update expetced errno (authored by pho).
stress2: Update expetced errno
Mar 15 2021, 11:18 AM
pho committed R10:f619b21d0f42: stress2: Fix usage of unitializer data (authored by pho).
stress2: Fix usage of unitializer data
Mar 15 2021, 11:02 AM

Mar 8 2021

pho committed R10:e0fd837a30bd: stress2: open(2) tests with BENEATH flags. (authored by pho).
stress2: open(2) tests with BENEATH flags.
Mar 8 2021, 8:20 AM

Mar 3 2021

pho committed R10:8a272653d9fb: stress2: Initial import (authored by pho).
stress2: Initial import
Mar 3 2021, 2:13 PM

Mar 1 2021

pho added a comment to D28999: FFS extattr: fix handling of the tail.

I ran your test scenario plus the five other extattr scenarios I already had. LGTM.

Mar 1 2021, 8:28 PM

Feb 20 2021

pho added a comment to D28679: vnode: move write cluster support data to inodes..

I ran the 13 msdosfs tests I have two times followed by one write-intensive test in a loop for one hour.
No problems seen.

Feb 20 2021, 5:40 PM

Feb 15 2021

pho added a comment to D28677: Merge OpenZFS 436ab35a5.

I ran the few zfs tests I have on openzfs_gc1c31a835-n244815-1f4c076e9e38 without observing any problems.

Feb 15 2021, 3:06 PM

Feb 8 2021

pho added a comment to D24217: amd64 pmap: fine-grained pv list locking.

I ran 675 out of 723 stress tests with D24217.83480.diff without observing any problems,

Feb 8 2021, 8:19 AM

Jan 23 2021

pho added a comment to D28306: nfs client: block vnode_pager_setsize() calls from nfscl_loadattrcache in nfs_write.

I ran the 29 NFS tests I have with D28306.82766.diff. This was a 2 1/2 hour test.
No problems seen.

Jan 23 2021, 2:09 PM

Jan 21 2021

pho added a comment to D28219: Restrict supported alignment for malloc_domainset_aligned(9) to PAGE_SIZE..

I ran tests with D28219.82645.diff for 6 hours. No problems seen.

Jan 21 2021, 12:36 AM

Jan 20 2021

pho added a comment to D28219: Restrict supported alignment for malloc_domainset_aligned(9) to PAGE_SIZE..

I ran tests with D28219.82616.diff on amd64 for two hours. No problems seen.

Jan 20 2021, 5:13 PM

Jan 17 2021

pho added a comment to D28147: Add malloc_domainset_aligned(9) and use it in x86 busdma bounce..

I tested D28147.82306.diff on i386 for 8 hours and on amd64 for 47 hours. No problems seen.

Jan 17 2021, 12:27 PM

Jan 11 2021

pho added a comment to D27956: amd64 pmap: do not sleep in _pmap_allocpte() with zero referenced page table page..

I ran a two-hour test on two different hosts with D27956.81970.diff added.
No problems seen.

Jan 11 2021, 8:41 PM

Jan 8 2021

pho added a comment to D27986: x86 tsc: use RDTSCP in preference of fence + RDTSC.

I ran stress tests on two different hosts for an hour. No problems seen.

Jan 8 2021, 11:43 AM

Jan 5 2021

pho added a comment to D27956: amd64 pmap: do not sleep in _pmap_allocpte() with zero referenced page table page..

I ran a full stress2 test on mercat1.

Jan 5 2021, 9:46 PM