pho (Peter Holm)
User

Projects

committers
Organization

User Details

User Since: Aug 6 2014, 5:32 AM (294 w, 6 d)

Recent Activity
View All

Wed, Mar 11

pho added a comment to D23965: x86: Support IO APICs on newer big Intel machines and hypervisors..

I booted with this on:

CPU: Intel(R) Xeon(R) CPU E5-2620 0 @ 2.00GHz (1995.24-MHz K8-class CPU)
CPU: Intel(R) Xeon(R) CPU E5-1650 v3 @ 3.50GHz (3500.07-MHz K8-class CPU)
CPU: AMD Phenom(tm) 9150e Quad-Core Processor (1800.02-MHz 686-class CPU)

No ioapic warnings seen.

Wed, Mar 11, 7:08 AM

Sun, Mar 8

pho committed rS358737: Added comment about problem found..

Added comment about problem found.

Sun, Mar 8, 6:10 AM

pho committed rS358736: Mark all sctp tests as "no run" again..

Mark all sctp tests as "no run" again.

Sun, Mar 8, 6:08 AM

pho committed rS358735: This tests would sometimes run for more than an hour. Fix that..

This tests would sometimes run for more than an hour. Fix that.

Sun, Mar 8, 6:06 AM

Fri, Mar 6

pho committed rS358692: Added a regression test..

Added a regression test.

Fri, Mar 6, 7:07 AM

Thu, Mar 5

pho committed rS358668: Added an old NUMA test scenario..

Added an old NUMA test scenario.

Thu, Mar 5, 9:20 AM

pho committed rS358667: Added an old test scenario..

Added an old test scenario.

Thu, Mar 5, 9:19 AM

Tue, Mar 3

pho committed rS358571: Added new tests all marked as "no run" for now..

Added new tests all marked as "no run" for now.

Tue, Mar 3, 10:03 AM

Mon, Mar 2

pho committed rS358531: Added a regression test..

Added a regression test.

Mon, Mar 2, 7:40 AM

pho committed rS358530: Addd a timeout..

Addd a timeout.

Mon, Mar 2, 7:34 AM

pho committed rS358529: Fix compiler warnings. Added environment variable MAXSWAPPCT to controll.

Fix compiler warnings. Added environment variable MAXSWAPPCT to controll

Mon, Mar 2, 7:33 AM

pho committed rS358526: Added an old regression test..

Added an old regression test.

Mon, Mar 2, 6:35 AM

pho committed rS358525: Added an old regression test..

Added an old regression test.

Mon, Mar 2, 6:32 AM

pho committed rS358524: Added an old regression test..

Added an old regression test.

Mon, Mar 2, 6:31 AM

pho committed rS358523: Added a regression test..

Added a regression test.

Mon, Mar 2, 6:30 AM

pho committed rS358522: Added a regression test..

Added a regression test.

Mon, Mar 2, 6:29 AM

pho committed rS358521: Added a regression test..

Added a regression test.

Mon, Mar 2, 6:29 AM

pho committed rS358520: Added a regression test..

Added a regression test.

Mon, Mar 2, 6:27 AM

pho committed rS358519: Added a syzkaller "C reproducer"..

Added a syzkaller "C reproducer".

Mon, Mar 2, 6:26 AM

Mar 1 2020

pho committed rS358481: Added an old swap test scenario..

Added an old swap test scenario.

Mar 1 2020, 8:54 AM

pho committed rS358480: Added an old test fcntl(2) fuzz scenario..

Added an old test fcntl(2) fuzz scenario.

Mar 1 2020, 8:45 AM

Feb 29 2020

pho committed rS358458: Added a timeout and an error exit to this test..

Added a timeout and an error exit to this test.

Feb 29 2020, 9:22 AM

pho committed rS358457: Update the list of tests with known problems..

Update the list of tests with known problems.

Feb 29 2020, 9:20 AM

pho committed rS358456: Added regressions tests for dtrace/systrace..

Added regressions tests for dtrace/systrace.

Feb 29 2020, 9:19 AM

Feb 28 2020

pho committed rS358425: Added comment about problem found. Return fsck exit code..

Added comment about problem found. Return fsck exit code.

Feb 28 2020, 7:50 AM

pho committed rS358424: Return fsck error code. Added kill(2) error handling..

Return fsck error code. Added kill(2) error handling.

Feb 28 2020, 7:48 AM

pho committed rS358423: Return fsck error status..

Return fsck error status.

Feb 28 2020, 7:46 AM

pho committed rS358422: Return fsck error code..

Return fsck error code.

Feb 28 2020, 7:45 AM

pho committed rS358421: Added missing error handling..

Added missing error handling.

Feb 28 2020, 7:45 AM

pho committed rS358420: Added a new rename() test..

Added a new rename() test.

Feb 28 2020, 7:44 AM

Feb 27 2020

pho committed rS358376: Fixed long line, fixed typo and remove now unneeded workaround..

Fixed long line, fixed typo and remove now unneeded workaround.

Feb 27 2020, 7:02 AM

pho committed rS358375: Added note about problem found. Improve error handling..

Added note about problem found. Improve error handling.

Feb 27 2020, 6:58 AM

pho committed rS358374: Added exit on fatal errors..

Added exit on fatal errors.

Feb 27 2020, 6:57 AM

pho committed rS358373: Fixed typo..

Fixed typo.

Feb 27 2020, 6:56 AM

pho committed rS358372: Added what error message to expect..

Added what error message to expect.

Feb 27 2020, 6:55 AM

pho committed rS358371: Limit runtime..

Limit runtime.

Feb 27 2020, 6:53 AM

pho committed rS358370: Added missing include file..

Added missing include file.

Feb 27 2020, 6:40 AM

pho committed rS358369: Added note about problem found and fixed..

Added note about problem found and fixed.

Feb 27 2020, 6:38 AM

pho committed rS358368: Limit runtime..

Limit runtime.

Feb 27 2020, 6:36 AM

pho committed rS358367: Fix broken unmount..

Fix broken unmount.

Feb 27 2020, 6:33 AM

Feb 20 2020

pho added a comment to D23622: Do not read sigfastblock word on syscall entry..

I ran all of the stress2 tests without seeing any problems.

Feb 20 2020, 9:11 AM

pho committed rS358161: Added a submitted test scenario..

Added a submitted test scenario.

Feb 20 2020, 8:58 AM

Feb 18 2020

pho committed rS358063: Added a regression test..

Added a regression test.

Feb 18 2020, 10:28 AM

Feb 10 2020

pho committed rS357725: Fix naming of helper file..

Fix naming of helper file.

Feb 10 2020, 9:11 AM

pho committed rS357724: Added timeout(1) to this test..

Added timeout(1) to this test.

Feb 10 2020, 9:10 AM

pho committed rS357723: Cap run time. Fix parameter type for getdirentries()..

Cap run time. Fix parameter type for getdirentries().

Feb 10 2020, 9:02 AM

pho committed rS357722: Added comment about problem found. Cap run time..

Added comment about problem found. Cap run time.

Feb 10 2020, 8:56 AM

pho committed rS357721: Limit run time..

Limit run time.

Feb 10 2020, 8:55 AM

pho committed rS357720: Added a regression test..

Added a regression test.

Feb 10 2020, 8:55 AM

pho committed rS357719: Added comment about problem found. If umount fails, do not loop forever..

Added comment about problem found. If umount fails, do not loop forever.

Feb 10 2020, 8:50 AM

pho committed rS357718: Added missing "umount". Fix mistake of using run.sh instead of run..

Added missing "umount". Fix mistake of using run.sh instead of run.

Feb 10 2020, 8:49 AM

pho committed rS357717: Added a regression test..

Added a regression test.

Feb 10 2020, 8:47 AM

Feb 9 2020

pho committed rS357699: Added a tmpfs test scenario..

Added a tmpfs test scenario.

Feb 9 2020, 12:29 PM

pho committed rS357692: Added some syzkaller "C reproducer" tests..

Added some syzkaller "C reproducer" tests.

Feb 9 2020, 10:42 AM

pho committed rS357691: Run test from /tmp. Fix cleanup..

Run test from /tmp. Fix cleanup.

Feb 9 2020, 8:45 AM

pho committed rS357690: Added a regression test..

Added a regression test.

Feb 9 2020, 8:39 AM

pho committed rS357689: Added a regression test.

Added a regression test

Feb 9 2020, 8:26 AM

Feb 3 2020

pho added a comment to D23474: Limit memory usage in xz(1)..

I tested this patch on i386 with 8 GB RAM and hw.physmem: 4294963200
LGTM.

Feb 3 2020, 7:38 PM

Feb 2 2020

pho added a comment to D23391: shortcuts in dmar_gas matching.

I have now managed to trigger the problem in r357172, so this IMHO definitely exonerates r357273.

(da0:isci0:0:0:0): SCSI status: Check Condition
(da0:isci0:0:0:0): SCSI sense: UNIT ATTENTION asc:29,2 (SCSI bus reset occurred)
(da0:isci0:0:0:0): Field Replaceable Unit: 2
(da0:isci0:0:0:0): Retrying command (per sense data)
Feb  2 18:06:37 t2 kernel: pid 7384 (swap), jid 0, uid 1004, was killed: out of swap space

Feb 2 2020, 5:24 PM

Feb 1 2020

pho added a comment to D23391: shortcuts in dmar_gas matching.

In D23391#514739, @kib wrote:

In D23391#514734, @dougm wrote:

Subsequent testing by Peter appears to have absolved r357173 of blame, so I'm going ahead with this commit.

Do you mean that isci(4) was broken anyway ? Are any other drivers were reported as broken ?

Feb 1 2020, 10:39 PM

pho added a comment to D23435: search for bug in r357173.

I have now seen the problem with r357173 reverted.
So this explains nicely, I think, how your r357173 is not at fault.

Feb 1 2020, 9:34 PM

pho added a comment to D23435: search for bug in r357173.

I don't know. This also seems strange to me.
The latest patch also fails:

Feb 1 2020, 8:42 PM

pho added a comment to D23435: search for bug in r357173.

20200201 19:26:43 all (1/1): udp.sh
(da0:isci0:0:0:0): WRITE(10). CDB: 2a 00 07 7d 6b 62 00 00 40 00 
(da0:isci0:0:0:0): CAM status: CCB request completed with an error
(da0:isci0:0:0:0): Retrying command, 3 more tries remain
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 155318, size: 4096
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 2494907, size: 4096
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 6079959, size: 4096
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 5729445, size: 53248
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 5696154, size: 4096
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 5696113, size: 16384
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 6321657, size: 24576
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 6251096, size: 16384
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 155318, size: 4096
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 2494907, size: 4096
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 6079959, size: 4096
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 5729445, size: 53248
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 5696154, size: 4096
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 5696113, size: 16384
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 6321657, size: 24576
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 6251096, size: 16384
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 2279816, size: 4096
isci: 1580582150:626672 ISCI Sending reset to device on controller 0 domain 0 CAM index 0
isci: 1580582150:635403 ISCI isci: bus=0 target=0 lun=0 cdb[0]=5c2c9f0 terminated
isci: 1580582150:643415 ISCI isci: bus=0 target=0 lun=0 cdb[0]=5c389f0 terminated
isci: 1580582150:651442 ISCI isci: bus=0 target=0 lun=0 cdb[0]=615969f0 terminated
isci: 1580582150:659605 ISCI isci: bus=0 target=0 lun=0 cdb[0]=f89e01f0 terminated
isci: 1580582150:667731 ISCI isci: bus=0 target=0 lun=0 cdb[0]=5c191f0 terminated
(da0:isci0:0:0:0): WRITE(10). CDB: 2a 00 40 44 2a f2 00 00 80 00 
(da0:isci0:0:0:0): CAM status: CCB request terminated by the host

Feb 1 2020, 6:47 PM

pho added a comment to D23435: search for bug in r357173.

With D23435.67608.diff I see

20200201 11:32:32 all (1/1): udp.sh
Expensive timeout(9) function: 0xffffffff80c5c1f0(0) 0.029046322 s
(da0:isci0:0:0:0): WRITE(10). CDB: 2a 00 07 7d 6b 62 00 00 40 00 
(da0:isci0:0:0:0): CAM status: CCB request completed with an error
(da0:isci0:0:0:0): Retrying command, 3 more tries remain
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 763617, size: 4096
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 774266, size: 4096
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 775798, size: 61440
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 763579, size: 16384
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 774832, size: 4096
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 763617, size: 4096
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 774266, size: 4096
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 775798, size: 61440
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 763579, size: 16384
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 774832, size: 4096
isci: 1580553435:446627 ISCI Sending reset to device on controller 0 domain 0 CAM index 0
isci: 1580553435:455345 ISCI isci: bus=0 target=0 lun=0 cdb[0]=af91c1f0 terminated
isci: 1580553435:463481 ISCI isci: bus=0 target=0 lun=0 cdb[0]=af9ba1f0 terminated
(da0:isci0:0:0:0): WRITE(10). CDB: 2a 00 3d f6 12 4a 00 00 80 00 
(da0:isci0:0:0:0): CAM status: CCB request terminated by the host
(da0:isci0:0:0:0): Retrying command, 3 more tries remain

Feb 1 2020, 11:03 AM

pho added a comment to D23435: search for bug in r357173.

With D23435.67605.diff I see

20200201 09:35:36 all (1/1): udp.sh
Feb  1 09:35:58 t2 ntpd[2421]: error resolving pool 0.freebsd.pool.ntp.org: Name does not resolve (8)
Feb  1 09:37:12 t2 syslogd: last message repeated 1 times
(da0:isci0:0:0:0): WRITE(10). CDB: 2a 00 3d 98 6e e2 00 01 00 00 
(da0:isci0:0:0:0): CAM status: CCB request completed with an error
(da0:isci0:0:0:0): Retrying command, 3 more tries remain

Feb 1 2020, 8:42 AM

pho added a comment to D23435: search for bug in r357173.

Just to be extra sure, I ran a 2 hour test with r357318 and r357171 reverted. No problems seen there.

Feb 1 2020, 8:23 AM

pho added a comment to D23435: search for bug in r357173.

More tests of D23435.67555.diff also show:

Feb 1 2020, 5:50 AM

pho added a comment to D23435: search for bug in r357173.

D23435.67596.diff fails straight away with

Feb 1 2020, 4:56 AM

Jan 31 2020

pho added a comment to D23435: search for bug in r357173.

I ran a one hour test without seeing any problems.

Jan 31 2020, 5:46 PM

pho added a comment to D23435: search for bug in r357173.

20200131 09:22:31 all (1/1): udp.sh
Expensive timeout(9) function: 0xffffffff80c5c1c0(0) 0.011447899 s
Expensive timeout(9) function: 0xffffffff80c5c1c0(0) 0.035223522 s
(da0:isci0:0:0:0): WRITE(10). CDB: 2a 00 3e 04 18 6a 00 01 00 00 
(da0:isci0:0:0:0): CAM status: CCB request completed with an error
(da0:isci0:0:0:0): Retrying command, 3 more tries remain
KDB: enter: Break to debugger
[ thread pid 11 tid 100003 ]
Stopped at      kdb_alt_break_internal+0x101:   movq    $0,0x1084d5c(%rip)
db> x/s version
version:        FreeBSD 13.0-CURRENT #0 r357318M: Fri Jan 31 09:01:40 CET 2020\012    pho@t2.osted.lan:/usr/src/sys/amd64/compile/PHO\012
db>

Jan 31 2020, 8:39 AM

Jan 30 2020

pho added a comment to D23391: shortcuts in dmar_gas matching.

I only have one UDP test that have triggered this.
On r357172 this test ran for 5 hours without any problems.
On r357173 I saw the problem after running the test for 30 minutes.

Jan 30 2020, 8:57 AM

Jan 29 2020

pho added a comment to D23391: shortcuts in dmar_gas matching.

After trying a bit harder with r357254 I see the same problem, so it is unrelated to this patch.

Jan 29 2020, 5:44 PM

pho added a comment to D23391: shortcuts in dmar_gas matching.

With "hw.dmar.enable=1" I see:

20200129 15:36:54 all (1/1): udp.sh
Expensive timeout(9) function: 0xffffffff80c5bbb0(0) 0.016073906 s
Expensive timeout(9) function: 0xffffffff80be2300(0xfffff80846234530) 0.024061505 s
Expensive timeout(9) function: 0xffffffff80c5bc80(0) 0.081290860 s
Expensive timeout(9) function: 0xffffffff80c5bc80(0) 0.231948206 s
(da0:isci0:0:0:0): WRITE(10). CDB: 2a 00 07 7d 6b 62 00 00 40 00 
(da0:isci0:0:0:0): CAM status: CCB request completed with an error
(da0:isci0:0:0:0): Retrying command, 3 more tries remain
swap_pager: indefinite wait buffer: bufobj: 0, blkno: 1580935, size: 16384
isci: 1580309000:401318 ISCI Sending reset to device on controller 0 domain 0 CAM index 0
isci: 1580309000:410015 ISCI isci: bus=0 target=0 lun=0 cdb[0]=615539f0 terminated
isci: 1580309000:418124 ISCI isci: bus=0 target=0 lun=0 cdb[0]=5c5e9f0 terminated
isci: 1580309000:426163 ISCI isci: bus=0 target=0 lun=0 cdb[0]=3eae1f0 terminated
isci: 1580309000:434210 ISCI isci: bus=0 target=0 lun=0 cdb[0]=615671f0 terminated
isci: 1580309000:442363 ISCI isci: bus=0 target=0 lun=0 cdb[0]=5c461f0 terminated
isci: 1580309000:450402 ISCI isci: bus=0 target=0 lun=0 cdb[0]=41c0a9f0 terminated
isci: 1580309000:458552 ISCI isci: bus=0 target=0 lun=0 cdb[0]=5c471f0 terminated
isci: 1580309000:466601 ISCI isci: bus=0 target=0 lun=0 cdb[0]=6d50b1f0 terminated
isci: 1580309000:474741 ISCI isci: bus=0 target=0 lun=0 cdb[0]=6d50b9f0 terminated
(da0:isci0:0:0:0): WRITE(10). CDB: 2a 00 3e 25 fc aa 00 01 00 00 
(da0:isci0:0:0:0): CAM status: CCB request terminated by the host
(da0:isci0:0:0:0): Retrying command, 3 more tries remain

Jan 29 2020, 3:16 PM

Jan 28 2020

pho added a comment to D23391: shortcuts in dmar_gas matching.

I probably won't be able to test this before tomorrow.

Jan 28 2020, 5:19 PM

Jan 27 2020

pho added a comment to D23189: Fix definition and use of RB_AUGMENT.

I ran tests with dmar enabled for the most of a day.
No problems seen.

Jan 27 2020, 1:38 PM

Jan 26 2020

pho added a comment to D23189: Fix definition and use of RB_AUGMENT.

I'll run some more test.

Jan 26 2020, 5:15 PM

pho added a comment to D23189: Fix definition and use of RB_AUGMENT.

I ran a brief 2 hour test with D23189.67306.diff. No problems seen.

Jan 26 2020, 3:35 PM

Jan 24 2020

pho added a comment to D23331: Handle a race of collapse with a retrying fault..

I completed a full stress2 test and ran the original problem test for 3 hours.
LGTM.

Jan 24 2020, 1:14 PM

Jan 18 2020

pho added a comment to D23189: Fix definition and use of RB_AUGMENT.

I ran a 30 minutest udp test with D23189.66959.diff and hw.dmar.enable=1.
I ran 100 tests in two hours followed by at buildworld / installworld.
No problems seen.

Jan 18 2020, 1:07 PM

Jan 17 2020

pho added a comment to D23189: Fix definition and use of RB_AUGMENT.

isci0: <Intel(R) C600 Series Chipset SAS Controller> port 0x2000-0x20ff mem 0xd7c00000-0xd7c03fff,0xd7800000-0xd7bfffff irq 16 at device 0.0 numa-domain 0 on pci4
unknown: dmar1 pci0:0:29:0 rid e8 domain 0 mgaw 48 agaw 48 re-mapped
unknown: dmar1 pci0:0:26:0 rid d0 domain 1 mgaw 48 agaw 48 re-mapped
isci0: dmar1 pci0:4:0:0 rid 400 domain 2 mgaw 48 agaw 48 re-mapped
Kernel page fault with the following non-sleepable locks held:
exclusive sleep mutex dmardom (dmardom) r = 0 (0xfffff80003d26c30) locked @ x86/iommu/intel_gas.c:616
stack backtrace:
#0 0xffffffff80c354b1 at witness_debugger+0x71
#1 0xffffffff80c364d0 at witness_warn+0x430
#2 0xffffffff8106dee0 at trap_pfault+0x80
#3 0xffffffff8106d500 at trap+0x2c0
#4 0xffffffff81043f5c at calltrap+0x8
#5 0xffffffff81021462 at dmar_gas_lowermatch+0x282
#6 0xffffffff81021242 at dmar_gas_lowermatch+0x62
#7 0xffffffff810209f5 at dmar_gas_map+0xf5
#8 0xffffffff810191a3 at dmar_bus_dmamap_load_something+0x153
#9 0xffffffff81018905 at dmar_bus_dmamap_load_buffer+0x1d5
#10 0xffffffff80c07cc6 at bus_dmamap_load+0x86
#11 0xffffffff80fec6fb at isci_allocate_dma_buffer+0xdb
#12 0xffffffff80fed9bf at isci_controller_allocate_memory+0xaf
#13 0xffffffff80fec54b at isci_initialize+0x18b
#14 0xffffffff80feca7f at isci_attach+0x14f
#15 0xffffffff80c01ffa at device_attach+0x3ca
#16 0xffffffff80c01ba0 at device_probe_and_attach+0x70
#17 0xffffffff80c03228 at bus_generic_attach+0x18

Jan 17 2020, 4:18 PM

pho added a comment to D23189: Fix definition and use of RB_AUGMENT.

This didn't compile

cc -c -O2 -pipe -fno-strict-aliasing  -g -nostdinc  -I. -I../../.. -I../../../contrib/ck/include -I../../../contrib/libfdt -D_KERNEL -Dc                                                                                                                                    
../../../x86/iommu/intel_gas.c:178:17: error: no member named 'free_after' in 'struct dmar_map_entry'                                                                                                                                                                       
                        MPASS(entry->free_after == domain->end - entry->end);

Jan 17 2020, 9:48 AM

Jan 16 2020

pho added a comment to D23189: Fix definition and use of RB_AUGMENT.

With dmar enable I get:

Jan 16 2020, 5:34 PM

pho added a comment to D23189: Fix definition and use of RB_AUGMENT.

Here's a panic with dmar enabled:

Jan 16 2020, 4:41 PM

Jan 14 2020

pho committed rS356726: Update the no-run list. Change the trim of the runtime log file..

Update the no-run list. Change the trim of the runtime log file.

Jan 14 2020, 10:13 AM

pho committed rS356721: Added a SUJ rename(2) regression test..

Added a SUJ rename(2) regression test.

Jan 14 2020, 6:16 AM

Jan 13 2020

pho added a comment to D23142: Implement cycle-detecting garbage collector for AF_UNIX sockets.

In D23142#507610, @markj wrote:

In D23142#507529, @jah wrote:

In D23142#507493, @markj wrote:

This mostly looks right to me. Would you be willing to add some basic regression tests for the garbage collector to tests/sys/kern/unix_passfd_test.c?

Of course. I think @pho already integrated Jan's test program from PR 227285 (which does exercise the gc) into his stress-test branch. It seems like that should just go into tests/ now. Anything else you'd like to see?

If there's already a test case in Peter's stress2, then that seems sufficient to me. IMO stress2 is already the right place for test cases which attempt to load the system and provoke race conditions. tests/ is used for component testing in practice and its tests should aim to run quickly. That said, it would be nice to have a simple tests/ test case that validates the scenario described in the review description, where a socket is closed after it is sent as part of an SCM_RIGHTS message but before it is externalized into the receiving process.

Jan 13 2020, 8:12 PM

Jan 5 2020

pho added a comment to D22987: Define a function combining vm entry lookup and clip-start.

I ran a full stress2 test on r356314 + D22987.66269.diff. No problems seen.

Jan 5 2020, 5:18 AM

Jan 1 2020

pho added a comment to D22987: Define a function combining vm entry lookup and clip-start.

I ran a preliminary 5 hour tests + a buildworld with D22987.66203.diff on r356250. No problems seen.

Jan 1 2020, 8:27 PM

Dec 30 2019

pho added a comment to D22897: clip without corrupting map.

I ran a partial test with this patch and r356153 for 16 hours / 577 tests. No problems seen.

Dec 30 2019, 8:45 PM

pho added a comment to D22897: clip without corrupting map.

In D22897#503110, @dougm wrote:

Yes I think it should be fixed by r355985. At least, the bug fixed in r355985 could cause this panic. This is a VMIO buffer and so should contain managed pages.

Peter, could you retest this please?

Dec 30 2019, 3:23 AM

Dec 29 2019

pho committed rS356167: Added a new zfs test..

Added a new zfs test.

Dec 29 2019, 4:58 AM

Dec 23 2019

pho added a comment to D22890: Apply r355883 to i386.

I completed testing D22890.65867.diff without seeing any problems. The test included a buildworld.

Dec 23 2019, 12:25 PM

Dec 22 2019

pho added a comment to D22897: clip without corrupting map.

In D22897#501467, @dougm wrote:

In D22897#501357, @pho wrote:

With D22897.65888.diff I got this after 5 hours:

Is this problem addressed by r355985?