Page MenuHomeFreeBSD
People pho

pho (Peter Holm)
User

Projects

User Details

User Since
Aug 6 2014, 5:32 AM (250 w, 4 d)

Recent Activity
View All

Today

pho added a comment to D20266: Simplify flow of pmap_demote_pde_locked() and add more comprehensive debugging checks..

I ran tests on D20266.57868.diff for 24 hours without seeing any problems.

Sun, May 26, 5:49 AM

Wed, May 22

pho committed rS348097: Added a regression test..
Added a regression test.
Wed, May 22, 6:03 AM

Tue, May 21

pho added a comment to D20304: NDFREE(): Fix unlocking for LOCKPARENT|LOCKLEAF and ndp->ni_dvp == ndp->ni_vp.

I reproduced the problem and verified that the patch fixes it.
I ran all of the stress2 tests on both amd64 and i386.
No problems seen.

Tue, May 21, 11:54 AM

Mon, May 20

pho committed rS347988: Added a regression test..
Added a regression test.
Mon, May 20, 8:52 AM

Sat, May 18

pho added a comment to D20299: Test and set ranges of reservation population bits at once.

I ran tests on D20299.57522.diff for five hours without seeing any problems.

Sat, May 18, 12:48 PM
pho added a comment to D20299: Test and set ranges of reservation population bits at once.

With D20299.57518.diff I see

Sat, May 18, 6:09 AM

Fri, May 17

pho added a comment to D20299: Test and set ranges of reservation population bits at once.
$ cc -c -O0 -pipe -fno-strict-aliasing  -g -nostdinc  -I. -I../../.. -I../../../contrib/ck/include -I../../../contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h    -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -MD  -MF.depend.vm_reserv.o -MTvm_reserv.o -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include -fdebug-prefix-map=./x86=/usr/src/sys/x86/include -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-address-of-packed-member  -mno-aes -mno-avx  -std=iso9899:1999 -Werror  ../../../vm/vm_reserv.c
../../../vm/vm_reserv.c:181:34: error: & has lower precedence than ==; == will be evaluated first [-Werror,-Wparentheses]
             i < end / NBPOPMAP && mask & popmap[i] == 0;
                                        ^~~~~~~~~~~~~~~~
../../../vm/vm_reserv.c:181:34: note: place parentheses around the '==' expression to silence this warning
             i < end / NBPOPMAP && mask & popmap[i] == 0;
                                        ^
                                          (             )
../../../vm/vm_reserv.c:181:34: note: place parentheses around the & expression to evaluate it first
             i < end / NBPOPMAP && mask & popmap[i] == 0;
                                        ^
                                   (               )
../../../vm/vm_reserv.c:188:15: error: & has lower precedence than ==; == will be evaluated first [-Werror,-Wparentheses]
        return (mask & popmap[i] == 0);
                     ^~~~~~~~~~~~~~~~
../../../vm/vm_reserv.c:188:15: note: place parentheses around the '==' expression to silence this warning
        return (mask & popmap[i] == 0);
                     ^
                       (             )
../../../vm/vm_reserv.c:188:15: note: place parentheses around the & expression to evaluate it first
        return (mask & popmap[i] == 0);
                     ^
                (               )
2 errors generated.
$
Fri, May 17, 9:01 PM
pho added a comment to D20256: Simplify vm_reserv_break.

Here's a buildworld from a single user mode boot:

# /usr/bin/time -h ./zzbuildworld.sh 
FreeBSD t2.osted.lan 13.0-CURRENT FreeBSD 13.0-CURRENT #2 r347793: Thu May 16 19:17:57 CEST 2019     pho@t2.osted.lan:/usr/src/sys/amd64/compile/PHO  amd64
vm.pmap.pde.promotions: 302
vm.pmap.pde.p_failures: 111
vm.pmap.pde.mappings: 0
vm.pmap.pde.demotions: 27
vm.reserv.reclaimed: 0
vm.reserv.partpopq: 
DOMAIN    LEVEL     SIZE  NUMBER
Fri, May 17, 7:35 AM

Thu, May 16

pho added a comment to D20256: Simplify vm_reserv_break.

I ran tests for 18 hours, including a buildworld.
Last vm.reserv.broken value was 247091.
No problems seen.

Thu, May 16, 12:34 PM
pho added a comment to D20256: Simplify vm_reserv_break.

OK.
vm.reserv.broken: 164537
Uptime is 12 hours on amd64

Thu, May 16, 8:21 AM

Wed, May 15

pho added a comment to D20256: Simplify vm_reserv_break.

I ran into another problem, so now I'm switching from i386 to amd64.

Wed, May 15, 8:14 PM
pho added a comment to D20256: Simplify vm_reserv_break.

I have not been able to reproduce the page fault with or without your patch.
I have resumed testing with Diff 57406.

Wed, May 15, 7:52 AM
pho committed rS347609: Added new sendfile(2) test scenarios..
Added new sendfile(2) test scenarios.
Wed, May 15, 7:46 AM
pho added a comment to D20256: Simplify vm_reserv_break.

I'm a bit low on test H/W, so I ran D20256.57402.diff on an i386 test host and got this:

Wed, May 15, 5:38 AM

Tue, May 14

pho added a comment to D20256: Simplify vm_reserv_break.
In D20256#436596, @dougm wrote:
In D20256#436594, @pho wrote:

Sure happy to. Will I get credit for doing so?

I regret failing to acknowledge you in some, or all, recent commits. If you want me to make some sort of public statement about it, I will.
I'll try to do better.

Tue, May 14, 6:14 AM
pho added a comment to D20256: Simplify vm_reserv_break.

Sure happy to. Will I get credit for doing so?

Tue, May 14, 5:26 AM

Thu, May 9

pho added a comment to D19630: amd64 pmap: rework di removing global mutex.

I ran the full stress2 test using two hosts. No problems seen.

Thu, May 9, 5:29 AM

Sat, May 4

pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.

With D20001.57040.diff I got:

Sat, May 4, 6:20 PM

Fri, May 3

pho added a comment to D20080: Convert all IPv4 and IPv6 multicast memberships into using a STAILQ() instead of an array.

I ran the two multicast tests I have repeatedly with D20080.56996.diff and D20109.56998.diff.
No problems seen.

Fri, May 3, 5:36 PM
pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.
In D20001#433848, @dougm wrote:

The patch that adds debug_counter statistics is written to be applied to the unmodified code. The patch under review here changes the type of the parameter 'count' from a value type to a pointer type, so the line
count_err += count - avg_count;
should be modified to
count_err += *count - avg_count;
to apply compute the statistics properly for the modified code. I apologize for not making this clear before.

Fri, May 3, 2:03 PM
pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.

Here's the i386 stats:

Fri, May 3, 1:15 PM
pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.

While waiting for free H/W I tried to run the tests on a box running i386:

Fri, May 3, 12:47 PM
pho added a comment to D20080: Convert all IPv4 and IPv6 multicast memberships into using a STAILQ() instead of an array.

I'm a bit low on free test H/W. I'll see what I can do tomorrow.

Fri, May 3, 11:18 AM

Thu, May 2

pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.

I'll redo the test with 56965 once I free up my test box.

Thu, May 2, 3:38 PM
pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.

The summary:

Thu, May 2, 8:34 AM
pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.

This looks promising. I'll add the counters and get some stats.

Thu, May 2, 6:42 AM

Wed, May 1

pho added a comment to D20080: Convert all IPv4 and IPv6 multicast memberships into using a STAILQ() instead of an array.

https://people.freebsd.org/~pho/stress/log/hselasky005.txt

Wed, May 1, 1:18 PM
pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.
swp_pager_getswapspace(32): failed
panic: freeing free block: fffc0, size 22, mask 1
cpuid = 21
time = 1556698660
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2c/frame 0xfffffe00cc3493b0
kdb_backtrace() at kdb_backtrace+0x53/frame 0xfffffe00cc349460
vpanic() at vpanic+0x19d/frame 0xfffffe00cc3494b0
panic() at panic+0x43/frame 0xfffffe00cc349510
blst_leaf_free() at blst_leaf_free+0x69/frame 0xfffffe00cc349540
blst_meta_free() at blst_meta_free+0x44/frame 0xfffffe00cc3495a0
blst_meta_free() at blst_meta_free+0x158/frame 0xfffffe00cc349600
blst_meta_free() at blst_meta_free+0x158/frame 0xfffffe00cc349660
blst_meta_free() at blst_meta_free+0x158/frame 0xfffffe00cc3496c0
blist_free() at blist_free+0x7e/frame 0xfffffe00cc3496f0
swp_pager_freeswapspace() at swp_pager_freeswapspace+0xb0/frame 0xfffffe00cc349720
swp_pager_meta_free_all() at swp_pager_meta_free_all+0x129/frame 0xfffffe00cc349760
swap_pager_dealloc() at swap_pager_dealloc+0x20d/frame 0xfffffe00cc349790
vm_object_terminate() at vm_object_terminate+0x27b/frame 0xfffffe00cc3497e0
vm_object_deallocate() at vm_object_deallocate+0x412/frame 0xfffffe00cc349840
vm_map_process_deferred() at vm_map_process_deferred+0x79/frame 0xfffffe00cc349860
vm_map_remove() at vm_map_remove+0xc6/frame 0xfffffe00cc349890
vmspace_exit() at vmspace_exit+0xd3/frame 0xfffffe00cc3498d0
exit1() at exit1+0x5ad/frame 0xfffffe00cc349940
sys_sys_exit() at sys_sys_exit+0xd/frame 0xfffffe00cc349950
syscallenter() at syscallenter+0x496/frame 0xfffffe00cc349a00
amd64_syscall() at amd64_syscall+0x4d/frame 0xfffffe00cc349ab0
fast_syscall_common() at fast_syscall_common+0x101/frame 0xfffffe00cc349ab0
--- syscall (1, FreeBSD ELF64, sys_sys_exit), rip = 0x8003ab8da, rsp = 0x7fffffffe4d8, rbp = 0x7fffffffe500 ---
KDB: enter: panic
[ thread pid 4575 tid 100639 ]
Stopped at      breakpoint+0x5: popq    %rbp
db> x/s version
version:        FreeBSD 13.0-CURRENT #2 r346986M: Wed May  1 09:39:42 CEST 2019\012    pho@t1.osted.lan:/usr/src/sys/amd64/compile/PHO\012
db>
Wed, May 1, 8:19 AM

Tue, Apr 30

pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.

While working on a new test scenario, which ran fine on HEAD:

Tue, Apr 30, 6:40 PM
pho added a comment to D19923: Switch to use shared vnode locks for text files during image activation..

Testing of r346804+db5a624a416(cpuctl) is complete and no problems seen.

Tue, Apr 30, 2:07 PM
pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.

Here's the difference:

Tue, Apr 30, 12:57 PM
pho added a comment to D20080: Convert all IPv4 and IPv6 multicast memberships into using a STAILQ() instead of an array.

I got this page fault using the test scenario from D19886:

Tue, Apr 30, 9:37 AM
pho committed rS346953: Added two multicast test cases..
Added two multicast test cases.
Tue, Apr 30, 8:09 AM

Mon, Apr 29

pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.

I'll see what I can do tomorrow. Could you possibly upload the diff?

Mon, Apr 29, 8:55 PM
pho added a comment to D19886: Fix numerous refcount bugs in multicast ....

I'm just using your test case:

service mdnsd onestart
ifconfig vtnet0 delete 2>/dev/null
ifconfig epair create
ifconfig epair0a 0/24 up
ifconfig epair0a destroy
service mdnsd onestop

You may need to add some VM pressure.

Mon, Apr 29, 6:47 PM
pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.

D20001.56794.diff survived a 6 hour test. Note that a full test will take about 48 hours.

Mon, Apr 29, 12:55 PM

Sun, Apr 28

pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.
FreeBSD 13.0-CURRENT (PHO) #14 r346790M: Sun Apr 28 21:12:11 CEST 2019
root@t2:~ # sh
# /tmp/swp.sh 
Device          1K-blocks     Used    Avail Capacity
/dev/da0p4       67108864        0 67108864     0%
/dev/da0p4       67108864  1292524 65816340     2%
/dev/da0p4       67108864  3709428 63399436     6%
/dev/da0p4       67108864  7375256 59733608    11%
/dev/da0p4       67108864  9751136 57357728    15%
:

I'll run some more tests ...

Sun, Apr 28, 7:20 PM
pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.
FreeBSD 13.0-CURRENT (PHO) #13 r346790M: Sun Apr 28 20:34:43 CEST 2019
root@t2:~ # sh
# /tmp/swp.sh 
Apr 28 20:38:22 t2 su[1043]: pho to root on /dev/pts/0
Device          1K-blocks     Used    Avail Capacity
/dev/da0p4       67108864        0 67108864     0%
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
:
Sun, Apr 28, 6:42 PM
pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.
FreeBSD 13.0-CURRENT (PHO) #12 r346790M: Sun Apr 28 20:01:25 CEST 2019
root@t2:~ # sh
# /tmp/swp.sh
Device          1K-blocks     Used    Avail Capacity
/dev/da0p4       67108864        0 67108864     0%
swp_pager_getswapspace(2): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
:
Sun, Apr 28, 6:07 PM
pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.
FreeBSD 13.0-CURRENT (PHO) #11 r346790M: Sun Apr 28 19:16:35 CEST 2019
root@t2:~ # sh
# /tmp/swp.sh
Device          1K-blocks     Used    Avail Capacity
/dev/da0p4       67108864        0 67108864     0%
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(2): failed
swp_pager_getswapspace(1): failed
:
Sun, Apr 28, 5:21 PM
pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.
FreeBSD 13.0-CURRENT (PHO) #10 r346790M: Sun Apr 28 18:51:09 CEST 2019
root@t2:~ # sh
# /tmp/swp.sh 
Device          1K-blocks     Used    Avail Capacity
/dev/da0p4       67108864        0 67108864     0%
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
:
Sun, Apr 28, 4:56 PM
pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.
FreeBSD 13.0-CURRENT (PHO) #9 r346790M: Sun Apr 28 16:30:09 CEST 2019
root@t2:~ # sh
# /tmp/swp.sh
Device          1K-blocks     Used    Avail Capacity
/dev/da0p4       67108864        0 67108864     0%
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
Sun, Apr 28, 2:38 PM
pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.
FreeBSD 13.0-CURRENT (PHO) #7 r346790M: Sun Apr 28 11:00:47 CEST 2019
root@t2:~ # sh
# /tmp/swp.sh 
Device          1K-blocks     Used    Avail Capacity
/dev/da0p4       67108864        0 67108864     0%
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(2): failed
swp_pager_getswapspace(1): failed
Sun, Apr 28, 9:13 AM
pho added a comment to D20080: Convert all IPv4 and IPv6 multicast memberships into using a STAILQ() instead of an array.

56762 fixed the problem seen by my one and only multicast test scenario.

Sun, Apr 28, 9:09 AM
pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.
FreeBSD 13.0-CURRENT (PHO) #5 r346790M: Sun Apr 28 10:08:35 CEST 2019
You have new mail.
root@t2:~ # sh
# /tmp/swp.sh 
Device          1K-blocks     Used    Avail Capacity
/dev/da0p4       67108864        0 67108864     0%
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(2): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(2): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(1): failed
swp_pager_getswapspace(2): failed
swp_pager_getswapspace(3): failed
:
Sun, Apr 28, 8:15 AM
pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.

D20001.56768.diff also looks fine.

Sun, Apr 28, 7:25 AM
pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.

D20001.56757.diff looks good:

Sun, Apr 28, 6:49 AM

Sat, Apr 27

pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.

D20001.56752.diff looks good:

Sat, Apr 27, 7:58 PM
pho added a comment to D20080: Convert all IPv4 and IPv6 multicast memberships into using a STAILQ() instead of an array.

With 56747 I got

Sat, Apr 27, 7:36 PM
pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.

With 56746 I see:

Sat, Apr 27, 6:18 PM
pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.
In D20001#431919, @dougm_rice.edu wrote:

Back up to a patch that I understood to have led to a successful 6-hour test, but my confidence about that is a little shaky at the moment.

Sat, Apr 27, 6:02 PM
pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.
In D20001#431916, @dougm_rice.edu wrote:

I see no change with Diff 56745.

No change from the bad test results produced by Diff 56733? Or no change from a working build without these changes?

Sat, Apr 27, 5:48 PM
pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.

I see no change with Diff 56745.

Sat, Apr 27, 5:10 PM
pho added a comment to D19923: Switch to use shared vnode locks for text files during image activation..

I have run the full stress2 test set on amd64 using r346698+3cb8bc20f88(cpuctl).
No problems seen.

Sat, Apr 27, 5:08 PM
pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.
In D20001#431837, @dougm_rice.edu wrote:

I see a lot of "swp_pager_getswapspace(1): failed" on the console. This with 56730.

I hope that 56727 worked, and 56733 fixed what 56730 broke. Thanks for the feedback.

Sat, Apr 27, 11:05 AM
pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.

I see a lot of "swp_pager_getswapspace(1): failed" on the console. This with 56730.

Sat, Apr 27, 8:42 AM

Fri, Apr 26

pho added a comment to D19886: Fix numerous refcount bugs in multicast ....
In D19886#431585, @hselasky wrote:

Hi,
Can you add:
options DEBUG_MEMGUARD
To the kernel and then reproduce this test and you'll see the bug happens much earlier using this script:

ifconfig epair create
ifconfig epair0a 0/24 up
ifconfig epair0a destroy
Fri, Apr 26, 2:17 PM

Apr 26 2019

pho added a comment to D19886: Fix numerous refcount bugs in multicast ....
20190426 12:09:07 all (1/1): multicast2.sh
Apr 26 12:09:09 t2 mDNSResponder[14951]: mDNSResponder (Engineering Build) (Jan  5 2019 05:09:39) starting
Apr 26 12:09:09 t2 mDNSResponder[14951]: mDNS_AddDNSServer: Lock not held! mDNS_busy (0) mDNS_reentrancy (0)
panic: Assertion ifma->ifma_ifp == NULL || ifma->ifma_ifp == ifp failed at ../../../net/if.c:3777
cpuid = 8
time = 1556273349
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00004ec870
vpanic() at vpanic+0x19d/frame 0xfffffe00004ec8c0
panic() at panic+0x43/frame 0xfffffe00004ec920
if_delmulti_locked() at if_delmulti_locked+0x1e7/frame 0xfffffe00004ec940
if_delmulti_ifma_flags() at if_delmulti_ifma_flags+0xbb/frame 0xfffffe00004ec990
inm_release_task() at inm_release_task+0x1ac/frame 0xfffffe00004ec9f0
gtaskqueue_run_locked() at gtaskqueue_run_locked+0xf9/frame 0xfffffe00004eca40
gtaskqueue_thread_loop() at gtaskqueue_thread_loop+0x88/frame 0xfffffe00004eca70
fork_exit() at fork_exit+0x84/frame 0xfffffe00004ecab0
fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe00004ecab0
--- trap 0, rip = 0, rsp = 0, rbp = 0 ---

Details @ https://people.freebsd.org/~pho/stress/log/mmacy035.txt

Apr 26 2019, 10:49 AM

Apr 25 2019

pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.

Typo:

../../../kern/subr_blist.c:751:14: error: use of undeclared identifier 'BLIST_MAP_RADIX'
                        *count += BLIST_MAP_RADIX - lo;
Apr 25 2019, 4:54 AM

Apr 24 2019

pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.

D20001.56595.diff got a panic: https://people.freebsd.org/~pho/stress/log/dougm025.txt

Apr 24 2019, 7:20 PM

Apr 23 2019

pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.

I tested D20001.56521.diff for 6 hours without seeing any problems.

Apr 23 2019, 7:35 PM

Apr 22 2019

pho added a comment to D20001: Let swp_pager_getswapspace allocate bigger blocks.

Tested D20001.56467.diff and got this watchdog timeout (30 minutes) : https://people.freebsd.org/~pho/stress/log/dougm024.txt

Apr 22 2019, 12:20 PM

Apr 18 2019

pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.

This is what I got after a three hour test. Let me know if you need more.

Apr 18 2019, 7:22 AM

Apr 13 2019

pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.

D19826.56173.diff boot + a buildworld/installworld.

Apr 13 2019, 6:50 PM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.

D19826.56169.diff also boots.

Apr 13 2019, 3:40 PM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.

D19826.56148.diff boots.

Apr 13 2019, 4:27 AM

Apr 12 2019

pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.
Trying to mount root from ufs:/dev/da0p2 [rw]...
WARNING: WITNESS option enabled, expect reduced performance.
WARNING: DIAGNOSTIC option enabled, expect reduced performance.
Expensive timeout(9) function: 0xffffffff80a50fb0(0xffffffff81af3de0) 0.006690654 s
uhub2: 4 ports with 4 removable, self powered
panic: map 0xfffff80840102000 max = 7ff7dfd56000, max_left = 7ffffc000, max_right = 0
cpuid = 4
time = 1555096341
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00bd3f84f0
vpanic() at vpanic+0x19d/frame 0xfffffe00bd3f8540
panic() at panic+0x43/frame 0xfffffe00bd3f85a0
_vm_map_assert_consistent() at _vm_map_assert_consistent+0x34e/frame 0xfffffe00bd3f8600
vm_map_entry_link() at vm_map_entry_link+0x49a/frame 0xfffffe00bd3f8680
_vm_map_clip_end() at _vm_map_clip_end+0x2be/frame 0xfffffe00bd3f86d0
vm_map_delete() at vm_map_delete+0x201/frame 0xfffffe00bd3f8750
vm_map_fixed() at vm_map_fixed+0x12e/frame 0xfffffe00bd3f87d0
vm_mmap_object() at vm_mmap_object+0x2dd/frame 0xfffffe00bd3f8840
vn_mmap() at vn_mmap+0x157/frame 0xfffffe00bd3f88c0
kern_mmap() at kern_mmap+0x454/frame 0xfffffe00bd3f8970
sys_mmap() at sys_mmap+0x2a/frame 0xfffffe00bd3f8990
amd64_syscall() at amd64_syscall+0x291/frame 0xfffffe00bd3f8ab0
fast_syscall_common() at fast_syscall_common+0x101/frame 0xfffffe00bd3f8ab0
--- syscall (477, FreeBSD ELF64, sys_mmap), rip = 0x800241fba, rsp = 0x7fffffffd268, rbp = 0x7fffffffd3c0 ---
KDB: enter: panic
[ thread pid 46 tid 100221 ]
Stopped at      kdb_enter+0x3b: movq    $0,kdb_why
db> x/s version
version:        FreeBSD 13.0-CURRENT #20 r346115M: Fri Apr 12 21:09:17 CEST 2019\012    pho@t2.osted.lan:/usr/src/sys/amd64/compile/PHO\012
db>
Apr 12 2019, 7:17 PM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.
Trying to mount root from ufs:/dev/da0p2 [rw]...
WARNING: WITNESS option enabled, expect reduced performance.
WARNING: DIAGNOSTIC option enabled, expect reduced performance.
Expensive timeout(9) function: 0xffffffff80a50fb0(0xffffffff81af3de0) 0.006686423 s
uhub2: 4 ports with 4 removable, self powered
panic: map 0xfffff80840102000 max = 7ff7dfd56000, max_left = 7ffffc000, max_right = 0
cpuid = 4
time = 1555094516
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00c0df34f0
vpanic() at vpanic+0x19d/frame 0xfffffe00c0df3540
panic() at panic+0x43/frame 0xfffffe00c0df35a0
_vm_map_assert_consistent() at _vm_map_assert_consistent+0x34e/frame 0xfffffe00c0df3600
vm_map_entry_link() at vm_map_entry_link+0x49a/frame 0xfffffe00c0df3680
_vm_map_clip_end() at _vm_map_clip_end+0x2be/frame 0xfffffe00c0df36d0
vm_map_delete() at vm_map_delete+0x201/frame 0xfffffe00c0df3750
vm_map_fixed() at vm_map_fixed+0x12e/frame 0xfffffe00c0df37d0
vm_mmap_object() at vm_mmap_object+0x2dd/frame 0xfffffe00c0df3840
vn_mmap() at vn_mmap+0x157/frame 0xfffffe00c0df38c0
kern_mmap() at kern_mmap+0x454/frame 0xfffffe00c0df3970
sys_mmap() at sys_mmap+0x2a/frame 0xfffffe00c0df3990
amd64_syscall() at amd64_syscall+0x291/frame 0xfffffe00c0df3ab0
fast_syscall_common() at fast_syscall_common+0x101/frame 0xfffffe00c0df3ab0
--- syscall (477, FreeBSD ELF64, sys_mmap), rip = 0x800241fba, rsp = 0x7fffffffd268, rbp = 0x7fffffffd3c0 ---
KDB: enter: panic
[ thread pid 46 tid 100221 ]
Stopped at      kdb_enter+0x3b: movq    $0,kdb_why
db> x/s version
version:        FreeBSD 13.0-CURRENT #19 r346115M: Fri Apr 12 20:38:48 CEST 2019\012    pho@t2.osted.lan:/usr/src/sys/amd64/compile/PHO\012
db>
Apr 12 2019, 6:47 PM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.

You're welcome. :) I'll give D19826.56128.diff a longer test.
I just finished an 8 hour test without any problems seen.

Apr 12 2019, 8:16 AM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.

D19826.56127.diff boots OK.

Apr 12 2019, 7:38 AM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.

D19826.56126.diff boots OK.

Apr 12 2019, 6:59 AM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.
Trying to mount root from ufs:/dev/da0p2 [rw]...
WARNING: WITNESS option enabled, expect reduced performance.
WARNING: DIAGNOSTIC option enabled, expect reduced performance.
Expensive timeout(9) function: 0xffffffff80a50fb0(0xffffffff81af3de0) 0.006686616 s
uhub2: 4 ports with 4 removable, self powered
panic: map 0xfffff80840002000 max = ca000, max_left = 0, max_right = 1feb8400000
cpuid = 1
time = 1555049681
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe007676d390
vpanic() at vpanic+0x19d/frame 0xfffffe007676d3e0
panic() at panic+0x43/frame 0xfffffe007676d440
_vm_map_assert_consistent() at _vm_map_assert_consistent+0x34e/frame 0xfffffe007676d4a0
vm_map_entry_splay() at vm_map_entry_splay+0x12f/frame 0xfffffe007676d4f0
vm_map_lookup_entry() at vm_map_lookup_entry+0xc7/frame 0xfffffe007676d540
vm_map_lookup() at vm_map_lookup+0x6b/frame 0xfffffe007676d5f0
vm_fault_hold() at vm_fault_hold+0x80/frame 0xfffffe007676d740
vm_fault() at vm_fault+0x60/frame 0xfffffe007676d780
trap_pfault() at trap_pfault+0x188/frame 0xfffffe007676d7d0
trap() at trap+0x2b4/frame 0xfffffe007676d8e0
calltrap() at calltrap+0x8/frame 0xfffffe007676d8e0
--- trap 0xc, rip = 0xffffffff810b6d31, rsp = 0xfffffe007676d9b0, rbp = 0xfffffe007676d9b0 ---
copystr() at copystr+0x11/frame 0xfffffe007676d9b0
exec_args_add_fname() at exec_args_add_fname+0x44/frame 0xfffffe007676d9d0
start_init() at start_init+0x12f/frame 0xfffffe007676da70
fork_exit() at fork_exit+0x84/frame 0xfffffe007676dab0
fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe007676dab0
--- trap 0, rip = 0, rsp = 0, rbp = 0 ---
KDB: enter: panic
[ thread pid 1 tid 100002 ]
Stopped at      kdb_enter+0x3b: movq    $0,kdb_why
db> x/s version
version:        FreeBSD 13.0-CURRENT #15 r346115M: Fri Apr 12 08:11:41 CEST 2019\012    pho@t2.osted.lan:/usr/src/sys/amd64/compile/PHO\012
db>
Apr 12 2019, 6:18 AM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.
Trying to mount root from ufs:/dev/da0p2 [rw]...
WARNING: WITNESS option enabled, expect reduced performance.
WARNING: DIAGNOSTIC option enabled, expect reduced performance.
Expensive timeout(9) function: 0xffffffff80a50fb0(0xffffffff81af3de0) 0.006689451 s
uhub0: 4 ports with 4 removable, self powered
panic: right max_free constraint violation
cpuid = 9
time = 1555044089
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00c07fd520
vpanic() at vpanic+0x19d/frame 0xfffffe00c07fd570
panic() at panic+0x43/frame 0xfffffe00c07fd5d0
vm_map_entry_link() at vm_map_entry_link+0x4a9/frame 0xfffffe00c07fd680
_vm_map_clip_end() at _vm_map_clip_end+0x2be/frame 0xfffffe00c07fd6d0
vm_map_delete() at vm_map_delete+0x201/frame 0xfffffe00c07fd750
vm_map_fixed() at vm_map_fixed+0x12e/frame 0xfffffe00c07fd7d0
vm_mmap_object() at vm_mmap_object+0x2dd/frame 0xfffffe00c07fd840
vn_mmap() at vn_mmap+0x157/frame 0xfffffe00c07fd8c0
kern_mmap() at kern_mmap+0x454/frame 0xfffffe00c07fd970
sys_mmap() at sys_mmap+0x2a/frame 0xfffffe00c07fd990
amd64_syscall() at amd64_syscall+0x291/frame 0xfffffe00c07fdab0
fast_syscall_common() at fast_syscall_common+0x101/frame 0xfffffe00c07fdab0
--- syscall (477, FreeBSD ELF64, sys_mmap), rip = 0x800241fba, rsp = 0x7fffffffd268, rbp = 0x7fffffffd3c0 ---
KDB: enter: panic
[ thread pid 46 tid 100221 ]
Stopped at      kdb_enter+0x3b: movq    $0,kdb_why
db> x/s version
version:        FreeBSD 13.0-CURRENT #14 r346115M: Fri Apr 12 06:38:35 CEST 2019\012    pho@t2.osted.lan:/usr/src/sys/amd64/compile/PHO\012
db>
Apr 12 2019, 4:42 AM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.
Trying to mount root from ufs:/dev/da0p2 [rw]...
WARNING: WITNESS option enabled, expect reduced performance.
WARNING: DIAGNOSTIC option enabled, expect reduced performance.
Expensive timeout(9) function: 0xffffffff80a50fb0(0xffffffff81af3de0) 0.006685464 s
uhub2: 4 ports with 4 removable, self powered
panic: left max_free constraint violation
cpuid = 0
time = 1555040644
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe007676d330
vpanic() at vpanic+0x19d/frame 0xfffffe007676d380
panic() at panic+0x43/frame 0xfffffe007676d3e0
vm_map_splay_split() at vm_map_splay_split+0x202/frame 0xfffffe007676d4a0
vm_map_entry_splay() at vm_map_entry_splay+0x56/frame 0xfffffe007676d4f0
vm_map_lookup_entry() at vm_map_lookup_entry+0xc7/frame 0xfffffe007676d540
vm_map_lookup() at vm_map_lookup+0x6b/frame 0xfffffe007676d5f0
vm_fault_hold() at vm_fault_hold+0x80/frame 0xfffffe007676d740
vm_fault() at vm_fault+0x60/frame 0xfffffe007676d780
trap_pfault() at trap_pfault+0x188/frame 0xfffffe007676d7d0
trap() at trap+0x2b4/frame 0xfffffe007676d8e0
calltrap() at calltrap+0x8/frame 0xfffffe007676d8e0
--- trap 0xc, rip = 0xffffffff810b7d31, rsp = 0xfffffe007676d9b0, rbp = 0xfffffe007676d9b0 ---
copystr() at copystr+0x11/frame 0xfffffe007676d9b0
exec_args_add_fname() at exec_args_add_fname+0x44/frame 0xfffffe007676d9d0
start_init() at start_init+0x12f/frame 0xfffffe007676da70
fork_exit() at fork_exit+0x84/frame 0xfffffe007676dab0
fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe007676dab0
--- trap 0, rip = 0, rsp = 0, rbp = 0 ---
KDB: enter: panic
[ thread pid 1 tid 100002 ]
Stopped at      kdb_enter+0x3b: movq    $0,kdb_why
db> x/s version
version:        FreeBSD 13.0-CURRENT #13 r346115M: Fri Apr 12 05:41:01 CEST 2019\012    pho@t2.osted.lan:/usr/src/sys/amd64/compile/PHO\012
db>
Apr 12 2019, 3:44 AM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.

D19826.56118.diff boots OK.

Apr 12 2019, 3:04 AM

Apr 11 2019

pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.
../../../vm/vm_map.c:1133:42: error: too many arguments provided to function-like macro invocation
                SPLAY_LEFT_STEP(root, y, llist, rlist, false);
                                                       ^
../../../vm/vm_map.c:921:9: note: macro 'SPLAY_LEFT_STEP' defined here
#define SPLAY_LEFT_STEP(root, y, rlist, test) do {      \
        ^
../../../vm/vm_map.c:1133:3: error: use of undeclared identifier 'SPLAY_LEFT_STEP'
                SPLAY_LEFT_STEP(root, y, llist, rlist, false);
                ^
../../../vm/vm_map.c:1139:43: error: too many arguments provided to function-like macro invocation
                SPLAY_RIGHT_STEP(root, y, llist, rlist, false);
                                                        ^
../../../vm/vm_map.c:941:9: note: macro 'SPLAY_RIGHT_STEP' defined here
#define SPLAY_RIGHT_STEP(root, y, llist, test) do {     \
        ^
../../../vm/vm_map.c:1139:3: error: use of undeclared identifier 'SPLAY_RIGHT_STEP'
                SPLAY_RIGHT_STEP(root, y, llist, rlist, false);
                ^
4 errors generated.
Apr 11 2019, 7:57 PM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.
Starting cron.
Local package initialization:panic: map 0xfffff8084ee85000 max = 14d2000, max_left = 7ffff4000, max_right = 38e000
cpuid = 1
time = 1555007102
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00cc4bb6c0
vpanic() at vpanic+0x19d/frame 0xfffffe00cc4bb710
panic() at panic+0x43/frame 0xfffffe00cc4bb770
_vm_map_assert_consistent() at _vm_map_assert_consistent+0x34e/frame 0xfffffe00cc4bb7d0
vm_map_entry_link() at vm_map_entry_link+0x47c/frame 0xfffffe00cc4bb850
_vm_map_clip_start() at _vm_map_clip_start+0x2b3/frame 0xfffffe00cc4bb8a0
vm_map_delete() at vm_map_delete+0x99/frame 0xfffffe00cc4bb920
kern_munmap() at kern_munmap+0x8e/frame 0xfffffe00cc4bb990
amd64_syscall() at amd64_syscall+0x291/frame 0xfffffe00cc4bbab0
fast_syscall_common() at fast_syscall_common+0x101/frame 0xfffffe00cc4bbab0
--- syscall (73, FreeBSD ELF64, sys_munmap), rip = 0x80058774a, rsp = 0x7fffffffbb08, rbp = 0x7fffffffbb70 ---
KDB: enter: panic
[ thread pid 888 tid 100516 ]
Stopped at      kdb_enter+0x3b: movq    $0,kdb_why
db> x/s version
version:        FreeBSD 13.0-CURRENT #10 r346115M: Thu Apr 11 20:21:29 CEST 2019\012    pho@t2.osted.lan:/usr/src/sys/amd64/compile/PHO\012
db>
Apr 11 2019, 6:36 PM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.
Trying to mount root from ufs:/dev/da0p2 [rw]...
WARNING: WITNESS option enabled, expect reduced performance.
WARNING: DIAGNOSTIC option enabled, expect reduced performance.
Expensive timeout(9) function: 0xffffffff80a50fb0(0xffffffff81af3de0) 0.005878327 s
uhub2: 4 ports with 4 removable, self powered
panic: map 0xfffff80840002000 max = ca000, max_left = 0, max_right = 1feb9c00000
cpuid = 1
time = 1555003396
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe007676d3e0
vpanic() at vpanic+0x19d/frame 0xfffffe007676d430
panic() at panic+0x43/frame 0xfffffe007676d490
_vm_map_assert_consistent() at _vm_map_assert_consistent+0x34e/frame 0xfffffe007676d4f0
vm_map_lookup_entry() at vm_map_lookup_entry+0xe8/frame 0xfffffe007676d540
vm_map_lookup() at vm_map_lookup+0x6b/frame 0xfffffe007676d5f0
vm_fault_hold() at vm_fault_hold+0x80/frame 0xfffffe007676d740
vm_fault() at vm_fault+0x60/frame 0xfffffe007676d780
trap_pfault() at trap_pfault+0x188/frame 0xfffffe007676d7d0
trap() at trap+0x2b4/frame 0xfffffe007676d8e0
calltrap() at calltrap+0x8/frame 0xfffffe007676d8e0
--- trap 0xc, rip = 0xffffffff810b6d31, rsp = 0xfffffe007676d9b0, rbp = 0xfffffe007676d9b0 ---
copystr() at copystr+0x11/frame 0xfffffe007676d9b0
exec_args_add_fname() at exec_args_add_fname+0x44/frame 0xfffffe007676d9d0
start_init() at start_init+0x12f/frame 0xfffffe007676da70
fork_exit() at fork_exit+0x84/frame 0xfffffe007676dab0
fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe007676dab0
--- trap 0, rip = 0, rsp = 0, rbp = 0 ---
KDB: enter: panic
[ thread pid 1 tid 100002 ]
Stopped at      kdb_enter+0x3b: movq    $0,kdb_why
db> x/s version
version:        FreeBSD 13.0-CURRENT #9 r346115M: Thu Apr 11 19:20:23 CEST 2019\012    pho@t2.osted.lan:/usr/src/sys/amd64/compile/PHO\012
db>
Apr 11 2019, 5:24 PM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.
Trying to mount root from ufs:/dev/da0p2 [rw]...
WARNING: WITNESS option enabled, expect reduced performance.
WARNING: DIAGNOSTIC option enabled, expect reduced performance.
Expensive timeout(9) function: 0xffffffff80a50fb0(0xffffffff81af3de0) 0.006687795 s
uhub2: 4 ports with 4 removable, self powered
panic: map 0xfffff80840002000 max = ca000, max_left = 0, max_right = 1feb9c00000
cpuid = 3
time = 1554999697
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe007676d3e0
vpanic() at vpanic+0x19d/frame 0xfffffe007676d430
panic() at panic+0x43/frame 0xfffffe007676d490
_vm_map_assert_consistent() at _vm_map_assert_consistent+0x34e/frame 0xfffffe007676d4f0
vm_map_lookup_entry() at vm_map_lookup_entry+0xe8/frame 0xfffffe007676d540
vm_map_lookup() at vm_map_lookup+0x6b/frame 0xfffffe007676d5f0
vm_fault_hold() at vm_fault_hold+0x80/frame 0xfffffe007676d740
vm_fault() at vm_fault+0x60/frame 0xfffffe007676d780
trap_pfault() at trap_pfault+0x188/frame 0xfffffe007676d7d0
trap() at trap+0x2b4/frame 0xfffffe007676d8e0
calltrap() at calltrap+0x8/frame 0xfffffe007676d8e0
--- trap 0xc, rip = 0xffffffff810b6d31, rsp = 0xfffffe007676d9b0, rbp = 0xfffffe007676d9b0 ---
copystr() at copystr+0x11/frame 0xfffffe007676d9b0
exec_args_add_fname() at exec_args_add_fname+0x44/frame 0xfffffe007676d9d0
start_init() at start_init+0x12f/frame 0xfffffe007676da70
fork_exit() at fork_exit+0x84/frame 0xfffffe007676dab0
fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe007676dab0
--- trap 0, rip = 0, rsp = 0, rbp = 0 ---
KDB: enter: panic
[ thread pid 1 tid 100002 ]
Stopped at      kdb_enter+0x3b: movq    $0,kdb_why
db> x/s version
version:        FreeBSD 13.0-CURRENT #8 r346115M: Thu Apr 11 18:18:31 CEST 2019\012    pho@t2.osted.lan:/usr/src/sys/amd64/compile/PHO\012
db>
Apr 11 2019, 4:22 PM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.
../../../vm/vm_map.c:1007:3: error: use of undeclared identifier 'llist'; did you mean 'rlist'?
                SPLAY_LEFT_STEP(root, y, rlist, true);
                ^
../../../vm/vm_map.c:936:25: note: expanded from macro 'SPLAY_LEFT_STEP'
            maxfree_left(root, llist))                  \
                               ^
../../../vm/vm_map.c:1002:17: note: 'rlist' declared here
        vm_map_entry_t rlist, y;
                       ^
../../../vm/vm_map.c:1019:3: error: use of undeclared identifier 'rlist'; did you mean 'llist'?
                SPLAY_RIGHT_STEP(root, y, llist, true);
                ^
../../../vm/vm_map.c:959:26: note: expanded from macro 'SPLAY_RIGHT_STEP'
            maxfree_right(root, rlist))                 \
                                ^
../../../vm/vm_map.c:1014:17: note: 'llist' declared here
        vm_map_entry_t llist, y;
                       ^
2 errors generated.
Apr 11 2019, 3:49 PM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.

D19826.56095.diff boots.

Apr 11 2019, 3:40 PM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.
Trying to mount root from ufs:/dev/da0p2 [rw]...
WARNING: WITNESS option enabled, expect reduced performance.
WARNING: DIAGNOSTIC option enabled, expect reduced performance.
Expensive timeout(9) function: 0xffffffff80a50fb0(0xffffffff81af3de0) 0.006696013 s
uhub0: 4 ports with 4 removable, self powered
Apr 11 2019, 3:01 PM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.

D19826.56086.diff boots OK.

Apr 11 2019, 7:04 AM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.

D19826.56085.diff boots OK.

Apr 11 2019, 6:05 AM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.
Trying to mount root from ufs:/dev/da0p2 [rw]...
WARNING: WITNESS option enabled, expect reduced performance.
WARNING: DIAGNOSTIC option enabled, expect reduced performance.
Expensive timeout(9) function: 0xffffffff80a50fb0(0xffffffff81af3de0) 0.006689247 s
uhub1: 4 ports with 4 removable, self powered
panic: map 0xfffff80840102000 nentries == 2 on free.
cpuid = 8
time = 1554957942
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00c6ae9340
vpanic() at vpanic+0x19d/frame 0xfffffe00c6ae9390
panic() at panic+0x43/frame 0xfffffe00c6ae93f0
vm_map_zdtor() at vm_map_zdtor+0x61/frame 0xfffffe00c6ae9420
vmspace_zdtor() at vmspace_zdtor+0x38/frame 0xfffffe00c6ae9460
uma_zfree_arg() at uma_zfree_arg+0x13d/frame 0xfffffe00c6ae94c0
uma_zfree() at uma_zfree+0x29/frame 0xfffffe00c6ae94f0
vmspace_dofree() at vmspace_dofree+0x76/frame 0xfffffe00c6ae9520
vmspace_exit() at vmspace_exit+0x154/frame 0xfffffe00c6ae9560
exit1() at exit1+0x5ad/frame 0xfffffe00c6ae95d0
kern_execve() at kern_execve+0xaaf/frame 0xfffffe00c6ae9910
sys_execve() at sys_execve+0x4c/frame 0xfffffe00c6ae9990
amd64_syscall() at amd64_syscall+0x291/frame 0xfffffe00c6ae9ab0
fast_syscall_common() at fast_syscall_common+0x101/frame 0xfffffe00c6ae9ab0
--- syscall (59, FreeBSD ELF64, sys_execve), rip = 0x2afc8a, rsp = 0x7fffffffe6e8, rbp = 0x7fffffffe6f0 ---
KDB: enter: panic
[ thread pid 46 tid 100221 ]
Stopped at      kdb_enter+0x3b: movq    $0,kdb_why
db> x/s version
version:        FreeBSD 13.0-CURRENT #2 r346115M: Thu Apr 11 06:42:33 CEST 2019\012    pho@t2.osted.lan:/usr/src/sys/amd64/compile/PHO\012
db>
Apr 11 2019, 4:46 AM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.

Did an update and a full build with 56081.diff. No change seen.

Apr 11 2019, 4:30 AM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.
Trying to mount root from ufs:/dev/da0p2 [rw]...
WARNING: WITNESS option enabled, expect reduced performance.
WARNING: DIAGNOSTIC option enabled, expect reduced performance.
Expensive timeout(9) function: 0xffffffff80a50ea0(0xffffffff81af3de0) 0.005951708 s
uhub2: 4 ports with 4 removable, self powered
panic: map 0xfffff80840102000 max = 0, max_left = 7fffff7fe000, max_right = 0
cpuid = 1
time = 1554952749
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00c7a7c5b0
vpanic() at vpanic+0x19d/frame 0xfffffe00c7a7c600
panic() at panic+0x43/frame 0xfffffe00c7a7c660
_vm_map_assert_consistent() at _vm_map_assert_consistent+0x34e/frame 0xfffffe00c7a7c6c0
vm_map_lookup_entry() at vm_map_lookup_entry+0xe8/frame 0xfffffe00c7a7c710
vm_map_lookup() at vm_map_lookup+0x6b/frame 0xfffffe00c7a7c7c0
vm_fault_hold() at vm_fault_hold+0x80/frame 0xfffffe00c7a7c910
vm_fault() at vm_fault+0x60/frame 0xfffffe00c7a7c950
trap_pfault() at trap_pfault+0x188/frame 0xfffffe00c7a7c9a0
trap() at trap+0x46b/frame 0xfffffe00c7a7cab0
calltrap() at calltrap+0x8/frame 0xfffffe00c7a7cab0
--- trap 0xc, rip = 0x251481, rsp = 0x7fffffffe6f8, rbp = 0x7fffffffe750 ---
KDB: enter: panic
[ thread pid 46 tid 100221 ]
Stopped at      kdb_enter+0x3b: movq    $0,kdb_why
db> x/s version
version:        FreeBSD 13.0-CURRENT #27 r346046M: Thu Apr 11 05:16:12 CEST 2019\012    pho@t2.osted.lan:/usr/src/sys/amd64/compile/PHO\012
db>
Apr 11 2019, 3:20 AM

Apr 10 2019

pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.
Trying to mount root from ufs:/dev/da0p2 [rw]...
WARNING: WITNESS option enabled, expect reduced performance.
WARNING: DIAGNOSTIC option enabled, expect reduced performance.
Expensive timeout(9) function: 0xffffffff80a50ea0(0xffffffff81af3de0) 0.006686247 s
uhub2: 4 ports with 4 removable, self powered
panic: map 0xfffff80840102000 nentries == 2 on free.
cpuid = 11
time = 1554928799
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00c7a90340
vpanic() at vpanic+0x19d/frame 0xfffffe00c7a90390
panic() at panic+0x43/frame 0xfffffe00c7a903f0
vm_map_zdtor() at vm_map_zdtor+0x61/frame 0xfffffe00c7a90420
vmspace_zdtor() at vmspace_zdtor+0x38/frame 0xfffffe00c7a90460
uma_zfree_arg() at uma_zfree_arg+0x13d/frame 0xfffffe00c7a904c0
uma_zfree() at uma_zfree+0x29/frame 0xfffffe00c7a904f0
vmspace_dofree() at vmspace_dofree+0x76/frame 0xfffffe00c7a90520
vmspace_exit() at vmspace_exit+0x154/frame 0xfffffe00c7a90560
exit1() at exit1+0x5ad/frame 0xfffffe00c7a905d0
kern_execve() at kern_execve+0xaaf/frame 0xfffffe00c7a90910
sys_execve() at sys_execve+0x4c/frame 0xfffffe00c7a90990
amd64_syscall() at amd64_syscall+0x291/frame 0xfffffe00c7a90ab0
fast_syscall_common() at fast_syscall_common+0x101/frame 0xfffffe00c7a90ab0
--- syscall (59, FreeBSD ELF64, sys_execve), rip = 0x2afc8a, rsp = 0x7fffffffe6e8, rbp = 0x7fffffffe6f0 ---
KDB: enter: panic
[ thread pid 46 tid 100221 ]
Stopped at      kdb_enter+0x3b: movq    $0,kdb_why
db> x/s version
version:        FreeBSD 13.0-CURRENT #25 r346046M: Wed Apr 10 22:37:06 CEST 2019\012    pho@t2.osted.lan:/usr/src/sys/amd64/compile/PHO\012
db>
Apr 10 2019, 8:40 PM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.
Trying to mount root from ufs:/dev/da0p2 [rw]...
WARNING: WITNESS option enabled, expect reduced performance.
WARNING: DIAGNOSTIC option enabled, expect reduced performance.
Expensive timeout(9) function: 0xffffffff80a50ea0(0xffffffff81af3de0) 0.006688356 s
uhub2: 4 ports with 4 removable, self powered
panic: map 0xfffff80840102000 nentries == 2 on free.
cpuid = 1
time = 1554921898
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00c07f8340
vpanic() at vpanic+0x19d/frame 0xfffffe00c07f8390
panic() at panic+0x43/frame 0xfffffe00c07f83f0
vm_map_zdtor() at vm_map_zdtor+0x61/frame 0xfffffe00c07f8420
vmspace_zdtor() at vmspace_zdtor+0x38/frame 0xfffffe00c07f8460
uma_zfree_arg() at uma_zfree_arg+0x13d/frame 0xfffffe00c07f84c0
uma_zfree() at uma_zfree+0x29/frame 0xfffffe00c07f84f0
vmspace_dofree() at vmspace_dofree+0x76/frame 0xfffffe00c07f8520
vmspace_exit() at vmspace_exit+0x154/frame 0xfffffe00c07f8560
exit1() at exit1+0x5ad/frame 0xfffffe00c07f85d0
kern_execve() at kern_execve+0xaaf/frame 0xfffffe00c07f8910
sys_execve() at sys_execve+0x4c/frame 0xfffffe00c07f8990
amd64_syscall() at amd64_syscall+0x291/frame 0xfffffe00c07f8ab0
fast_syscall_common() at fast_syscall_common+0x101/frame 0xfffffe00c07f8ab0
--- syscall (59, FreeBSD ELF64, sys_execve), rip = 0x2afc8a, rsp = 0x7fffffffe6e8, rbp = 0x7fffffffe6f0 ---
KDB: enter: panic
[ thread pid 46 tid 100221 ]
Stopped at      kdb_enter+0x3b: movq    $0,kdb_why
db> x/s version
version:        FreeBSD 13.0-CURRENT #24 r346046M: Wed Apr 10 20:42:04 CEST 2019\012    pho@t2.osted.lan:/usr/src/sys/amd64/compile/PHO\012
db>
Apr 10 2019, 6:45 PM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.

D19826.56057.diff same as my fix:

Apr 10 2019, 4:57 PM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.
../../../vm/vm_map.c:3873:29: error: use of undeclared identifier 'map'; did you mean 'max'?
                        VM_MAP_ASSERT_CONSISTENT(map);
                                                 ^~~
                                                 max
../../../vm/vm_map.c:713:31: note: expanded from macro 'VM_MAP_ASSERT_CONSISTENT'
    _vm_map_assert_consistent(map)
                              ^
../../../sys/libkern.h:96:23: note: 'max' declared here
static __inline u_int max(u_int a, u_int b) { return (a > b ? a : b); }
                      ^
../../../vm/vm_map.c:3901:29: error: use of undeclared identifier 'map'; did you mean 'max'?
                        VM_MAP_ASSERT_CONSISTENT(map);
                                                 ^~~
                                                 max
../../../vm/vm_map.c:713:31: note: expanded from macro 'VM_MAP_ASSERT_CONSISTENT'
    _vm_map_assert_consistent(map)
                              ^
../../../sys/libkern.h:96:23: note: 'max' declared here
static __inline u_int max(u_int a, u_int b) { return (a > b ? a : b); }
                      ^
../../../vm/vm_map.c:3925:29: error: use of undeclared identifier 'map'; did you mean 'max'?
                        VM_MAP_ASSERT_CONSISTENT(map);
                                                 ^~~
                                                 max
../../../vm/vm_map.c:713:31: note: expanded from macro 'VM_MAP_ASSERT_CONSISTENT'
    _vm_map_assert_consistent(map)
                              ^
../../../sys/libkern.h:96:23: note: 'max' declared here
static __inline u_int max(u_int a, u_int b) { return (a > b ? a : b); }
                      ^
3 errors generated.
Apr 10 2019, 4:36 PM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.
Trying to mount root from ufs:/dev/da0p2 [rw]...
WARNING: WITNESS option enabled, expect reduced performance.
WARNING: DIAGNOSTIC option enabled, expect reduced performance.
Expensive timeout(9) function: 0xffffffff80a50ea0(0xffffffff81af3de0) 0.005872898 s
uhub0: 4 ports with 4 removable, self powered
panic: map 0xfffff80840102000 max = 0, max_left = 7e0000, max_right = 0
cpuid = 11
time = 1554911814
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00c6ace670
vpanic() at vpanic+0x19d/frame 0xfffffe00c6ace6c0
panic() at panic+0x43/frame 0xfffffe00c6ace720
_vm_map_assert_consistent() at _vm_map_assert_consistent+0x34e/frame 0xfffffe00c6ace780
vm_map_entry_link() at vm_map_entry_link+0x462/frame 0xfffffe00c6ace7f0
_vm_map_clip_end() at _vm_map_clip_end+0x2be/frame 0xfffffe00c6ace840
vm_map_protect() at vm_map_protect+0x209/frame 0xfffffe00c6ace8d0
kern_proc_setrlimit() at kern_proc_setrlimit+0x43e/frame 0xfffffe00c6ace960
sys_setrlimit() at sys_setrlimit+0x39/frame 0xfffffe00c6ace990
amd64_syscall() at amd64_syscall+0x291/frame 0xfffffe00c6aceab0
fast_syscall_common() at fast_syscall_common+0x101/frame 0xfffffe00c6aceab0
--- syscall (195, FreeBSD ELF64, sys_setrlimit), rip = 0x24fffa, rsp = 0x7fffffffe588, rbp = 0x7fffffffe630 ---
KDB: enter: panic
[ thread pid 46 tid 100221 ]
Stopped at      kdb_enter+0x3b: movq    $0,kdb_why
db> x/s version
version:        FreeBSD 13.0-CURRENT #20 r346046M: Wed Apr 10 17:53:45 CEST 2019\012    pho@t2.osted.lan:/usr/src/sys/amd64/compile/PHO\012
db>
Apr 10 2019, 3:58 PM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.

D19826.56052.diff boots OK.

Apr 10 2019, 3:10 PM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.
Trying to mount root from ufs:/dev/da0p2 [rw]...
WARNING: WITNESS option enabled, expect reduced performance.
WARNING: DIAGNOSTIC option enabled, expect reduced performance.
Expensive timeout(9) function: 0xffffffff80a50ea0(0xffffffff81af3de0) 0.006870839 s
uhub2: 4 ports with 4 removable, self powered
panic: map 0xfffff80840102000 nentries == 2 on free.
cpuid = 3
time = 1554881233
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00c6ab6340
vpanic() at vpanic+0x19d/frame 0xfffffe00c6ab6390
panic() at panic+0x43/frame 0xfffffe00c6ab63f0
vm_map_zdtor() at vm_map_zdtor+0x61/frame 0xfffffe00c6ab6420
vmspace_zdtor() at vmspace_zdtor+0x38/frame 0xfffffe00c6ab6460
uma_zfree_arg() at uma_zfree_arg+0x13d/frame 0xfffffe00c6ab64c0
uma_zfree() at uma_zfree+0x29/frame 0xfffffe00c6ab64f0
vmspace_dofree() at vmspace_dofree+0x76/frame 0xfffffe00c6ab6520
vmspace_exit() at vmspace_exit+0x154/frame 0xfffffe00c6ab6560
exit1() at exit1+0x5ad/frame 0xfffffe00c6ab65d0
kern_execve() at kern_execve+0xaaf/frame 0xfffffe00c6ab6910
sys_execve() at sys_execve+0x4c/frame 0xfffffe00c6ab6990
amd64_syscall() at amd64_syscall+0x291/frame 0xfffffe00c6ab6ab0
fast_syscall_common() at fast_syscall_common+0x101/frame 0xfffffe00c6ab6ab0
--- syscall (59, FreeBSD ELF64, sys_execve), rip = 0x2afc8a, rsp = 0x7fffffffe6e8, rbp = 0x7fffffffe6f0 ---
KDB: enter: panic
[ thread pid 46 tid 100221 ]
Stopped at      kdb_enter+0x3b: movq    $0,kdb_why
db> x/s version
version:        FreeBSD 13.0-CURRENT #17 r346046M: Wed Apr 10 09:23:35 CEST 2019\012    pho@t2.osted.lan:/usr/src/sys/amd64/compile/PHO\012
db>
Apr 10 2019, 7:29 AM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.

D19826.56037.diff boots OK.

Apr 10 2019, 6:53 AM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.

D19826.56034.diff boots.

Apr 10 2019, 5:54 AM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.

D19826.56033.diff boots OK.

Apr 10 2019, 5:26 AM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.
../../../vm/vm_map.c:906:1: warning: unused function 'vm_map_entry_set_max_free' [-Wunused-function]
vm_map_entry_set_max_free(vm_map_entry_t entry)
Apr 10 2019, 4:57 AM

Apr 9 2019

pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.
Trying to mount root from ufs:/dev/da0p2 [rw]...
WARNING: WITNESS option enabled, expect reduced performance.
WARNING: DIAGNOSTIC option enabled, expect reduced performance.
Expensive timeout(9) function: 0xffffffff80a50ea0(0xffffffff81af3de0) 0.006685907 s
uhub0: 4 ports with 4 removable, self powered
panic: map 0xfffff80031233000 max = 7ff7ff9df000, max_left = 0, max_right = 0
cpuid = 10
time = 1554835744
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe007676d4a0
vpanic() at vpanic+0x19d/frame 0xfffffe007676d4f0
panic() at panic+0x43/frame 0xfffffe007676d550
_vm_map_assert_consistent() at _vm_map_assert_consistent+0x34e/frame 0xfffffe007676d5b0
vm_map_findspace() at vm_map_findspace+0x890/frame 0xfffffe007676d6c0
vm_map_find() at vm_map_find+0x60e/frame 0xfffffe007676d7a0
vm_map_find_min() at vm_map_find_min+0x97/frame 0xfffffe007676d830
vm_mmap_object() at vm_mmap_object+0x39b/frame 0xfffffe007676d8c0
kern_mmap() at kern_mmap+0x477/frame 0xfffffe007676d970
sys_mmap() at sys_mmap+0x2a/frame 0xfffffe007676d990
amd64_syscall() at amd64_syscall+0x291/frame 0xfffffe007676dab0
fast_syscall_common() at fast_syscall_common+0x101/frame 0xfffffe007676dab0
--- syscall (477, FreeBSD ELF64, sys_mmap), rip = 0x332e4a, rsp = 0x7fffffffe208, rbp = 0x7fffffffe220 ---
KDB: enter: panic
[ thread pid 1 tid 100002 ]
Stopped at      kdb_enter+0x3b: movq    $0,kdb_why
db> x/s version
version:        FreeBSD 13.0-CURRENT #12 r346046M: Tue Apr  9 20:45:33 CEST 2019\012    pho@t2.osted.lan:/usr/src/sys/amd64/compile/PHO\012
db>
Apr 9 2019, 6:50 PM
pho added a comment to D19826: reduce accesses to vm_map entries off the search path in updating max_free.

D19826.56017.diff also boots.

Apr 9 2019, 5:52 PM