Page MenuHomeFreeBSD

pho (Peter Holm)
User

Projects

User Details

User Since
Aug 6 2014, 5:32 AM (434 w, 2 d)

Recent Activity

Wed, Nov 23

pho added a comment to D37458: Various fixes related to VV_CROSSLOCK handling.

D37458.113418.patch LGTM

Wed, Nov 23, 3:24 PM

Mon, Nov 21

pho added a comment to D37452: vmm: do not call mtx_lock in icr_low write handler.

D37452.id113378.diff fixed the issue for me.

Mon, Nov 21, 7:12 PM

Mon, Nov 14

pho committed rG9e16087e361f: stress2: Added a new SU+J + snapshot test scenario (authored by pho).
stress2: Added a new SU+J + snapshot test scenario
Mon, Nov 14, 11:05 AM
pho committed rG1541ac2120eb: stress2: Exclude two "forced detach" tests and two SUJ + snapshot tests (authored by pho).
stress2: Exclude two "forced detach" tests and two SUJ + snapshot tests
Mon, Nov 14, 11:05 AM

Sun, Nov 13

pho committed rGd941ffdc4f98: stress2: Added a tmpfs regression test for Bug 223015 (authored by pho).
stress2: Added a tmpfs regression test for Bug 223015
Sun, Nov 13, 9:17 AM
pho committed rG7c455ce26fbf: stress2: Added more "mdconfig -o force" tests (authored by pho).
stress2: Added more "mdconfig -o force" tests
Sun, Nov 13, 9:06 AM
pho committed rGd7655675eb09: stress2: Snapshots of SU+J has been enabled (authored by pho).
stress2: Snapshots of SU+J has been enabled
Sun, Nov 13, 9:01 AM

Thu, Nov 10

pho committed rGf31ca922cb06: stress2: Add SU+J as a test. Save fsck_ffs core dump, if any (authored by pho).
stress2: Add SU+J as a test. Save fsck_ffs core dump, if any
Thu, Nov 10, 9:14 AM

Oct 27 2022

pho committed rG9349fc283b58: stress2: Added a newfs(8) test scenario (authored by pho).
stress2: Added a newfs(8) test scenario
Oct 27 2022, 8:01 AM
pho committed rGe23445275ab0: stress2: Added a regression test for a ffs validate_sblock() fix (authored by pho).
stress2: Added a regression test for a ffs validate_sblock() fix
Oct 27 2022, 8:01 AM

Oct 24 2022

pho committed rGee920bc903d2: stress2: Added a regression test for D37024 (authored by pho).
stress2: Added a regression test for D37024
Oct 24 2022, 7:50 AM
pho committed rG799db59e9a5e: stress2: Update tool to list both DATA and HOLES in a file. (authored by pho).
stress2: Update tool to list both DATA and HOLES in a file.
Oct 24 2022, 7:50 AM

Oct 21 2022

pho added a comment to D35054: Add VV_CROSSLOCK vnode flag to avoid cross-mount lookup LOR.

D35054.112068.patch LGTM

Oct 21 2022, 1:26 PM

Oct 13 2022

pho added a comment to D36491: Add support for managing UFS/FFS snapshots to fsck_ffs(8).
In D36491#839750, @pho wrote:

I have not observed any new problems while testing D36491.id111589.diff

Oct 13 2022, 6:20 PM
pho added a comment to D36491: Add support for managing UFS/FFS snapshots to fsck_ffs(8).

I have not observed any new problems while testing D36491.id111589.diff

Oct 13 2022, 4:24 PM

Oct 11 2022

pho committed rGbab2efd47be8: stress2: Temporarily removed the rename(2) tests as these seem to trigger a (authored by pho).
stress2: Temporarily removed the rename(2) tests as these seem to trigger a
Oct 11 2022, 8:22 AM

Sep 27 2022

pho committed rG8dcc207de5b3: stress2: Fixed double word in comment (authored by pho).
stress2: Fixed double word in comment
Sep 27 2022, 6:54 AM

Sep 26 2022

pho committed rG977d8fb9adfa: stress2: Added regression tests (authored by pho).
stress2: Added regression tests
Sep 26 2022, 7:51 AM

Sep 21 2022

pho committed rG5b42ac2914b5: stress2: Added two syzkaller reproducers (authored by pho).
stress2: Added two syzkaller reproducers
Sep 21 2022, 5:43 AM

Aug 25 2022

pho committed rG2aba6e7aaf2f: stress2: Added a regression test (authored by pho).
stress2: Added a regression test
Aug 25 2022, 7:49 AM

Aug 24 2022

pho committed rG4e4f49fd4af2: stress2: Added another sigreturn(2) fuzzer test (authored by pho).
stress2: Added another sigreturn(2) fuzzer test
Aug 24 2022, 11:23 AM

Aug 19 2022

pho committed rGdd894897691f: stress2: Updated tests as a result of the latest updates to fsck_ffs(8) (authored by pho).
stress2: Updated tests as a result of the latest updates to fsck_ffs(8)
Aug 19 2022, 9:43 AM
pho committed rG98b13e25fd9c: stress2: Handle different spelling of "superblock" (authored by pho).
stress2: Handle different spelling of "superblock"
Aug 19 2022, 9:43 AM

Aug 11 2022

pho committed rG64f923959a8a: stress2: Added a regression test (authored by pho).
stress2: Added a regression test
Aug 11 2022, 7:43 AM

Aug 7 2022

pho committed rGc9254546682c: stress2: Added another fsck_ffs test scenario (authored by pho).
stress2: Added another fsck_ffs test scenario
Aug 7 2022, 8:39 AM
pho committed rGac79b5f32794: stress2: Do not run a fuzz test as root. (authored by pho).
stress2: Do not run a fuzz test as root.
Aug 7 2022, 8:39 AM

Aug 6 2022

pho added a comment to D35054: Add VV_CROSSLOCK vnode flag to avoid cross-mount lookup LOR.

D35054.108900.patch looks good to me.

Aug 6 2022, 4:08 PM

Jul 25 2022

pho added a comment to D35054: Add VV_CROSSLOCK vnode flag to avoid cross-mount lookup LOR.

I have not observed any problems with D35054.108486.patch

Jul 25 2022, 2:04 PM

Jul 17 2022

pho committed rG6226f8f25427: stress2: Update the exclude list (authored by pho).
stress2: Update the exclude list
Jul 17 2022, 7:17 AM

Jul 15 2022

pho committed rGac19e54390a0: stress2: Enable more swap disk usage (authored by pho).
stress2: Enable more swap disk usage
Jul 15 2022, 8:21 AM
pho committed rGb4a666180180: stress2: Handle "gunion create" error exit (authored by pho).
stress2: Handle "gunion create" error exit
Jul 15 2022, 8:21 AM

Jul 12 2022

pho committed rG7f3383d29baa: stress2: Added a fsck_ffs(8) test scenario (authored by pho).
stress2: Added a fsck_ffs(8) test scenario
Jul 12 2022, 4:44 AM

Jul 7 2022

pho committed rGa526ec4351a0: stress2: Added a mount(8) test scenario (authored by pho).
stress2: Added a mount(8) test scenario
Jul 7 2022, 7:46 AM

Jun 30 2022

pho committed rGec8c9e7ac3fd: stress2: Rework test to improve error reporting (authored by pho).
stress2: Rework test to improve error reporting
Jun 30 2022, 7:48 AM

Jun 29 2022

pho committed rGbc49526a561c: stress2: Fix broken random number generation (authored by pho).
stress2: Fix broken random number generation
Jun 29 2022, 10:29 AM

Jun 28 2022

pho committed rGa25818eb2869: stress2: Added comment about problem found (authored by pho).
stress2: Added comment about problem found
Jun 28 2022, 9:31 AM
pho committed rG8e6465887373: stress2: Update the exclude list (authored by pho).
stress2: Update the exclude list
Jun 28 2022, 9:31 AM

Jun 25 2022

pho committed rGe3b31e23ffdf: stress2: Added two syzkaller reproducers (authored by pho).
stress2: Added two syzkaller reproducers
Jun 25 2022, 6:41 AM
pho committed rG25a1b1f30c85: stress2: Added reagression tests (authored by pho).
stress2: Added reagression tests
Jun 25 2022, 6:23 AM

Jun 21 2022

pho committed rGf2deb5e40c92: stress2: Added a timeout (authored by pho).
stress2: Added a timeout
Jun 21 2022, 8:21 AM

Jun 20 2022

pho committed rGf2c88ed6ba92: stress2: Added a timeout to the test (authored by pho).
stress2: Added a timeout to the test
Jun 20 2022, 12:37 PM
pho committed rGe2c59d8dff4b: stress2: Fix process handling error (authored by pho).
stress2: Fix process handling error
Jun 20 2022, 12:37 PM

Jun 17 2022

pho committed rG608c97bff921: stress2: Remove bsdlabel(8) from tests (authored by pho).
stress2: Remove bsdlabel(8) from tests
Jun 17 2022, 3:50 AM

Jun 14 2022

pho committed rG2d4b1f4b8cf0: stress2: Added a syzkaller reproducer. Enable all reaper tests (authored by pho).
stress2: Added a syzkaller reproducer. Enable all reaper tests
Jun 14 2022, 5:00 AM

Jun 12 2022

pho committed rGf71b232f319d: stress2: Added an explanation to failure mode (authored by pho).
stress2: Added an explanation to failure mode
Jun 12 2022, 9:57 AM

Jun 10 2022

pho added a comment to D35424: iommu_gas: pass size without page alignment.

No problems seen with a short test on amd64.

Jun 10 2022, 1:01 PM

Jun 1 2022

pho committed rG368852d6723f: stress2: Updated the exclude list and sorted it (authored by pho).
stress2: Updated the exclude list and sorted it
Jun 1 2022, 8:05 AM
pho committed rGe14e0a163225: stress2: Added syzkaller reproducers (authored by pho).
stress2: Added syzkaller reproducers
Jun 1 2022, 8:05 AM
pho committed rG4d0adee4e678: stress2: Added procctl(2) PROC_REAP_KILL regression tests (authored by pho).
stress2: Added procctl(2) PROC_REAP_KILL regression tests
Jun 1 2022, 8:04 AM

May 27 2022

pho committed rG4581e8e9a263: stress2: Added a syzkaler reproducer (authored by pho).
stress2: Added a syzkaler reproducer
May 27 2022, 1:07 PM

May 25 2022

pho added a comment to D35219: Comprehensive UFS/FFS superblock integrity checks made when a superblock is read.

The disk image fuzzer test no longer triggers a panic with this patch.
I have not detected any side effects with D35219.id106252.diff.
LGTM.

May 25 2022, 1:47 PM

May 18 2022

pho added a comment to D35232: busdma_iommu: map without extra offset bytes.
Kernel page fault with the following non-sleepable locks held:
exclusive rw vm object (vm object) r = 0 (0xfffff80004837b58) locked @ x86/iommu/intel_idpgtbl.c:550
exclusive sleep mutex AHCI channel lock (AHCI channel lock) r = 0 (0xfffffe003ce28400) locked @ kern/kern_mutex.c:211
stack backtrace:
#0 0xffffffff80c85445 at witness_debugger+0x65
#1 0xffffffff80c8659a at witness_warn+0x3ea
#2 0xffffffff810fcce6 at trap_pfault+0x86
#3 0xffffffff810cdc18 at calltrap+0x8
#4 0xffffffff81078e7e at iommu_gas_map+0x15e
#5 0xffffffff81077339 at iommu_bus_dmamap_load_something+0x119
#6 0xffffffff81076995 at iommu_bus_dmamap_load_buffer+0x1c5
#7 0xffffffff80c55a3e at _bus_dmamap_load_ccb+0x20e
#8 0xffffffff80c557cc at bus_dmamap_load_ccb+0x8c
#9 0xffffffff803929d9 at xpt_run_devq+0x2f9
#10 0xffffffff80395de7 at xpt_release_simq+0x67
#11 0xffffffff80c3027a at softclock_call_cc+0x15a
#12 0xffffffff80c31b96 at softclock_thread+0xc6
#13 0xffffffff80bc9850 at fork_exit+0x80
#14 0xffffffff810cec8e at fork_trampoline+0xe

https://people.freebsd.org/~pho/stress/log/log0317.txt

May 18 2022, 8:47 PM
pho added a comment to D35232: busdma_iommu: map without extra offset bytes.
panic: segment too large: ctx 0xfffff800041ca180 start 0xfef01000 end 0xfef24000 buflen1 0x23000 maxsegsz 0x22400

https://people.freebsd.org/~pho/stress/log/log0316.txt

May 18 2022, 8:09 PM
pho added a comment to D35232: busdma_iommu: map without extra offset bytes.

https://people.freebsd.org/~pho/stress/log/log0314.txt

May 18 2022, 10:20 AM

May 16 2022

pho added a comment to D35219: Comprehensive UFS/FFS superblock integrity checks made when a superblock is read.

I have uploaded a minimal test scenario, where the second mount fails with your patch:

May 16 2022, 1:05 PM

May 8 2022

pho committed rG13aacd0c0cb6: stress2: Added a test scenario (authored by pho).
stress2: Added a test scenario
May 8 2022, 7:58 AM

Apr 29 2022

pho committed rG014a2b1a1125: stress2: Fixed cleanup path error (authored by pho).
stress2: Fixed cleanup path error
Apr 29 2022, 8:56 AM

Apr 28 2022

pho committed rG8a5c1f58dd0e: stress2: Added a regression test (authored by pho).
stress2: Added a regression test
Apr 28 2022, 7:42 AM

Apr 22 2022

pho committed rG29acff870b5f: stress2: Added a syzkaller reproducer (authored by pho).
stress2: Added a syzkaller reproducer
Apr 22 2022, 4:21 AM

Apr 16 2022

pho committed rGeaa3e829f0e3: stress2: Added a regression test (authored by pho).
stress2: Added a regression test
Apr 16 2022, 7:16 AM
pho committed rGaf333da5063c: Added a test to the exclude list (authored by pho).
Added a test to the exclude list
Apr 16 2022, 7:16 AM

Apr 15 2022

pho added a comment to D34815: For multipage allocation, start block scan at start of free range.

D34815.104986.patch also looks good to me.

Apr 15 2022, 7:17 PM
pho added a comment to D34906: Revert rest of a5970a529c2d95271: use vrefact() when working on fp->f_vnode.

OTOH it would be useful if you provide Peter with your test program and instructions how to reproduce, so that this case does not regress more.

Apr 15 2022, 8:33 AM

Apr 14 2022

pho committed rG1346766f60ad: stress2: Permanently disable disruptive tests (authored by pho).
stress2: Permanently disable disruptive tests
Apr 14 2022, 5:00 AM

Apr 13 2022

pho committed rG2f0baec1ecb2: stress2: Fix cleanup after test run (authored by pho).
stress2: Fix cleanup after test run
Apr 13 2022, 9:09 AM
pho committed rGb06e3f990d94: stress2: Added comment (authored by pho).
stress2: Added comment
Apr 13 2022, 9:09 AM
pho committed rG4523edbeae50: stress2: Remove working tests from the exclude list (authored by pho).
stress2: Remove working tests from the exclude list
Apr 13 2022, 9:09 AM

Apr 11 2022

pho added a comment to D34815: For multipage allocation, start block scan at start of free range.

D34815.104865.patch LGTM

Apr 11 2022, 2:15 PM

Apr 10 2022

pho added a comment to D34815: For multipage allocation, start block scan at start of free range.
../../../vm/vm_phys.c:1360:6: error: unused variable 'order' [-Werror,-Wunused-variable]
        int order;
            ^
1 error generated.
Apr 10 2022, 1:30 PM
pho added a comment to D34815: For multipage allocation, start block scan at start of free range.

I got a panic with this: https://people.freebsd.org/~pho/stress/log/log0278.txt

Apr 10 2022, 9:35 AM

Apr 9 2022

pho added a comment to D34729: For multipage allocation, try assembling smaller blocks when big-enough free lists are empty.

I ran tests for 16 hours without seeing any problems with D34729.104761.patch

Apr 9 2022, 10:30 AM

Apr 6 2022

pho committed rG40b97c41bc77: stress2: Add new write(2) test. Remove sctp.sh after problem fixed (authored by pho).
stress2: Add new write(2) test. Remove sctp.sh after problem fixed
Apr 6 2022, 5:27 AM
pho committed rGb5c60bb85bf3: stress2: Added a write(2) fuzz test scenario (authored by pho).
stress2: Added a write(2) fuzz test scenario
Apr 6 2022, 5:27 AM

Apr 5 2022

pho committed rG7c1baa8ab3f5: stress2: Added a syzkaller reproducer (authored by pho).
stress2: Added a syzkaller reproducer
Apr 5 2022, 8:48 AM

Apr 3 2022

pho committed rG88b3e65fcff2: stress2: Added a test to the exclude file (authored by pho).
stress2: Added a test to the exclude file
Apr 3 2022, 9:13 AM

Apr 1 2022

pho added a comment to D34729: For multipage allocation, try assembling smaller blocks when big-enough free lists are empty.

I ran a four hour test with the contigmalloc() tests in a loop. This followed by random stress2 tests for 4 hours. No problems seen.

Apr 1 2022, 12:54 PM

Mar 31 2022

pho added a comment to D34724: Allow allocation of pages from beyond the last max order block of a range.

I'm not sure how much testing is required for this patch.
I ran the three contigmalloc(9) tests I have in a loop for four hours. I followed up with a few hours of random stress2 tests.
No problems seen.

Mar 31 2022, 7:55 PM
pho added a comment to D33947: Change free space search to avoid duplicate search.

The stress2 test suite completed with any issues.

Mar 31 2022, 5:28 AM

Mar 30 2022

pho added a comment to D33947: Change free space search to avoid duplicate search.

I'm almost done with testing the D33947.104303.patch. No problems seen so far. A full stress2 test takes two days to complete.

Mar 30 2022, 10:29 PM

Mar 28 2022

pho added a comment to D33947: Change free space search to avoid duplicate search.
In D33947#786068, @alc wrote:

Peter, can you please test this?

Mar 28 2022, 5:44 PM
pho committed rG7afec5182a63: stress2: Enable four quota tests, which now seems to run without issues (authored by pho).
stress2: Enable four quota tests, which now seems to run without issues
Mar 28 2022, 8:46 AM

Mar 24 2022

pho added a comment to D33947: Change free space search to avoid duplicate search.

I got this panic from a contigmalloc() test:

Mar 24 2022, 5:59 AM

Mar 18 2022

pho committed rG314ebfa2e9c5: stress2: Limit console warnings (authored by pho).
stress2: Limit console warnings
Mar 18 2022, 6:35 AM
pho committed rGbfdcd042bc8c: stress2: Remove the memory disk after the fsck, not before (authored by pho).
stress2: Remove the memory disk after the fsck, not before
Mar 18 2022, 6:30 AM

Mar 16 2022

pho added a comment to D34562: ffs: fix mksnap_ffs.

I have been running tests with this patch for 18 hours, without seeing any problems.

Mar 16 2022, 6:13 AM

Mar 15 2022

pho committed rG0977ebb07152: stress2: A unmount of a unionfs file system may return EBUSY. (authored by pho).
stress2: A unmount of a unionfs file system may return EBUSY.
Mar 15 2022, 9:25 AM
pho committed rG9e8fbb95b36f: stress2: A unmount of a unionfs file system may return EBUSY. (authored by pho).
stress2: A unmount of a unionfs file system may return EBUSY.
Mar 15 2022, 8:37 AM

Mar 8 2022

pho committed rGfa99b3cf871a: stress2: Fix typo in exclude names (authored by pho).
stress2: Fix typo in exclude names
Mar 8 2022, 10:31 AM
pho committed rG221c6f86f0e7: stress2: Exclude a few test. (authored by pho).
stress2: Exclude a few test.
Mar 8 2022, 10:22 AM

Mar 4 2022

pho committed rG205117128771: stress2: Added a new test scenario checing for a long fsck_ffs runtime (authored by pho).
stress2: Added a new test scenario checing for a long fsck_ffs runtime
Mar 4 2022, 11:08 AM

Mar 3 2022

pho committed rG70cb626635fa: stress2: Reworked and cleaned up this test scenaio. (authored by pho).
stress2: Reworked and cleaned up this test scenaio.
Mar 3 2022, 1:31 PM

Feb 22 2022

pho committed rG14086729650b: stress2: Added cleanup on error (authored by pho).
stress2: Added cleanup on error
Feb 22 2022, 11:09 AM

Feb 19 2022

pho accepted D34282: unionfs: rework unionfs_getwritemount().

I ran tests with D34282.102922.patch for 5 hours. No problems seen.

Feb 19 2022, 2:08 AM

Feb 18 2022

pho accepted D34309: sendto: don't clear transient errors for atomic protocols.

The patch fixed the issue I had observed.

Feb 18 2022, 6:27 AM

Feb 16 2022

pho committed rG87000c893c24: stress2: Finish work on two gunion(8) test scenarios (authored by pho).
stress2: Finish work on two gunion(8) test scenarios
Feb 16 2022, 9:22 AM

Feb 13 2022

pho committed rG6fbbb4806322: stress2: Added a tool to zero out a superblock check hash. (authored by mckusick).
stress2: Added a tool to zero out a superblock check hash.
Feb 13 2022, 9:52 AM
pho committed rG91f821f8e429: stress2: Add a fsck_ffs regression test scenario (authored by pho).
stress2: Add a fsck_ffs regression test scenario
Feb 13 2022, 9:51 AM

Feb 11 2022

pho committed rGf0000eb41d30: stress2: Added a regression test (authored by pho).
stress2: Added a regression test
Feb 11 2022, 8:50 AM

Feb 8 2022

pho committed rG675758f7c269: stress2: Updated test with problem found and mark it as a "no run" (authored by pho).
stress2: Updated test with problem found and mark it as a "no run"
Feb 8 2022, 6:52 AM

Feb 5 2022

pho committed rG28e0b888fe52: stress2: Fix compiler warnings (authored by pho).
stress2: Fix compiler warnings
Feb 5 2022, 8:52 AM