stress2: exlock2.sh: Preserve behavior after ps(1)'s '-U' change
ClosedPublic
Actions

Authored by olce on May 6 2025, 4:59 PM.

Details

Reviewers

Commits

rG10e6bac460af: stress2: exlock2.sh: Preserve behavior after ps(1)'s '-U' change
rG5af18707c155: stress2: exlock2.sh: Preserve behavior after ps(1)'s '-U' change
rG1265d3b07eaa: stress2: exlock2.sh: Preserve behavior after ps(1)'s '-U' change

Summary

Remove '-Uroot', as now '-U' selects processes based on their real user
IDs, and since the program using them was launched as 'root', the
equivalent now is just to remove it, as now ps(1) by default selects
processes based on its effective UID (root) and their effective UIDs.

It seems that matching on effective or real UID does not really matter
in this test, but at least this change simplifies the command-line.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olce created this revision.May 6 2025, 4:59 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 6 2025, 4:59 PM

olce requested review of this revision.May 6 2025, 4:59 PM

Harbormaster completed remote builds in B63949: Diff 154961.May 6 2025, 4:59 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 7 2025, 9:16 AM

Closed by commit rG1265d3b07eaa: stress2: exlock2.sh: Preserve behavior after ps(1)'s '-U' change (authored by olce). · Explain Why

This revision was automatically updated to reflect the committed changes.

olce added a commit: rG1265d3b07eaa: stress2: exlock2.sh: Preserve behavior after ps(1)'s '-U' change.

Looks good to me.

In D50200#1145643, @pho wrote:

Looks good to me.

Great. Sorry, I committed this quite quickly as it's a very small change that I'd like to be MFCed soon and put into 14.3, else I would have waited more for you.

In D50200#1145706, @olce wrote:

In D50200#1145643, @pho wrote:

Looks good to me.

Great. Sorry, I committed this quite quickly as it's a very small change that I'd like to be MFCed soon and put into 14.3, else I would have waited more for you.