The change looks good to me.
I'm always a bit hesitant to change a test scenario which has proven to trigger multiple panics, but this looks fine to me.

Oct 11 2023, 8:56 PM

pho added a comment to D42160: test: iterate both reader and writer threads starting at the actual pagesize.

In my opinion, any (broken) test scenario that can crash the kernel is a good stress test. :)

Oct 11 2023, 8:22 PM

Sep 27 2023

pho committed rG2b716e00cf3b: stress2: Extent timeout limit to avoid false positive errors (authored by pho).

stress2: Extent timeout limit to avoid false positive errors

Sep 27 2023, 11:03 AM

pho committed rG0f35fd33479c: stress2: Remove tests from the exclude list (authored by pho).

stress2: Remove tests from the exclude list

Sep 27 2023, 11:03 AM

pho committed rG0ec1bbe579fa: stress2: Cap total runtime (authored by pho).

stress2: Cap total runtime

Sep 27 2023, 11:02 AM

Sep 10 2023

pho added a comment to D41344: radix_trie: have vm_radix use pctrie code.

I ran tests for 24 hours with D41344.id126971.diff. This on amd64 with a DEBUG kernel.
No problems seen.

Sep 10 2023, 4:46 PM

Aug 19 2023

pho committed rGf322816aafa7: stress2: Added a syzkaller reproducer (authored by pho).

stress2: Added a syzkaller reproducer

Aug 19 2023, 7:30 AM

pho committed rG0d30f3afa62b: stress2: No need to write to the console. Add revision to log string (authored by pho).

stress2: No need to write to the console. Add revision to log string

Aug 19 2023, 7:30 AM

Aug 13 2023

pho committed rGa953ac19dbc8: stress2: Added a 'fsck_ffs -B' regression test (authored by pho).

stress2: Added a 'fsck_ffs -B' regression test

Aug 13 2023, 9:11 AM

Aug 6 2023

pho added a comment to D41335: vm_phys: speed up unfree_page search.

No unfortunately I don't have any tests that involve the 'ram_blacklist' module.

Aug 6 2023, 1:07 PM

Aug 3 2023

pho added a comment to D41289: vm_phys: tune vm_phys_enqueue_contig loop.

I ran tests for an hour with D41289.125507.patch on

FreeBSD mercat1.netperf.freebsd.org 14.0-CURRENT FreeBSD 14.0-CURRENT #0 main-n264491-8a5c836b51ce2-dirty: Thu Aug  3 18:20:47 CEST 2023     pho@mercat1.netperf.freebsd.org:/usr/src/sys/amd64/compile/PHO amd64

I also did a buildkernel. I did not observe any issues.

Aug 3 2023, 6:31 PM

pho added a comment to D41154: vm_phys_enqueue_contig: handle zero pages.

I ran a buildkernel and a few other test with D41154.125493.patch.
I did not observe any issues.

Aug 3 2023, 7:13 AM

pho added a comment to D41154: vm_phys_enqueue_contig: handle zero pages.

With D41154.125484.patch I now see:

igb0: <Intel(R) I350 (Copper)> port 0xd020-0xd03f mem 0xfb320000-0xfb33ffff,0xfb344000-0xfb347fff irq 16 at device 0.0 on pci8
igb0: EEPROM V1.63-0 eTrack 0x800009fa
igb0: Using 1024 TX descriptors and 1024 RX descriptors
igb0: queue equality override not set, capping rx_queues at 6 and tx_queues at 6
igb0: Usin
db> show panic
panic: vm_phys_enq_range: page 0xfffffe0002fd4c18 and npages 0 are misaligned
db> x/s version
version:        FreeBSD 14.0-CURRENT #0 main-n264491-8a5c836b51ce2-dirty: Thu Aug  3 06:23:37 CEST 2023\012    pho@mercat1.netperf.freebsd.org:/usr/sr
db> bt
Tracing pid 37 tid 100210 td 0xfffffe010e620900  
kdb_enter() at kdb_enter+0x32/frame 0xfffffe010db821f0
vpanic() at vpanic+0x17a/frame 0xfffffe010db82240
panic() at panic+0x43/frame 0xfffffe010db822a0
vm_phys_enq_range() at vm_phys_enq_range+0x11d/frame 0xfffffe010db822b0
vm_phys_alloc_npages() at vm_phys_alloc_npages+0x5a6/frame 0xfffffe010db82320
vm_page_zone_import() at vm_page_zone_import+0xa7/frame 0xfffffe010db82370
zone_alloc_item() at zone_alloc_item+0x78/frame 0xfffffe010db823c0
vm_page_alloc_domain_after() at vm_page_alloc_domain_after+0x151/frame 0xfffffe010db82450
vm_page_alloc() at vm_page_alloc+0x64/frame 0xfffffe010db824b0
vm_fault_allocate() at vm_fault_allocate+0x1a5/frame 0xfffffe010db82520
vm_fault() at vm_fault+0x448/frame 0xfffffe010db82650
vm_fault_trap() at vm_fault_trap+0x6f/frame 0xfffffe010db82690
trap_pfault() at trap_pfault+0x24a/frame 0xfffffe010db82700
calltrap() at calltrap+0x8/frame 0xfffffe010db82700
--- trap 0xc, rip = 0xffffffff8104db36, rsp = 0xfffffe010db827d0, rbp = 0xfffffe010db827d0 ---
copyout_nosmap_erms() at copyout_nosmap_erms+0x156/frame 0xfffffe010db827d0
elf64_load_sections() at elf64_load_sections+0x283/frame 0xfffffe010db82860
elf64_load_file() at elf64_load_file+0x280/frame 0xfffffe010db828c0
elf64_load_interp() at elf64_load_interp+0x67/frame 0xfffffe010db82900
exec_elf64_imgact() at exec_elf64_imgact+0xe01/frame 0xfffffe010db829f0
kern_execve() at kern_execve+0x772/frame 0xfffffe010db82d80
sys_execve() at sys_execve+0x58/frame 0xfffffe010db82e00
amd64_syscall() at amd64_syscall+0x14f/frame 0xfffffe010db82f30
fast_syscall_common() at fast_syscall_common+0xf8/frame 0xfffffe010db82f30
--- syscall (59, FreeBSD ELF64, execve), rip = 0x254589a5b30a, rsp = 0x2545874dfdf8, rbp = 0x2545874dff40 ---
db> 
db> show proc
Process 37 (sh) at 0xfffffe010e96b000:
 state: NORMAL
 uid: 0  gids: 0
 parent: pid 20 at 0xfffffe003ce595c0
 ABI: FreeBSD ELF64
 flag: 0x14000002  flag2: 0
 arguments: /bin/sh -o verify /etc/rc autoboot
 reaper: 0xfffffe00e4c65040 reapsubtree: 1
 sigparent: 20
 vmspace: 0xfffffe010e95a860
   (map 0xfffffe010e95a860)
   (map.pmap 0xfffffe010e95a920)
   (pmap 0xfffffe010e95a990)
 threads: 1
100210                   Run     CPU 0                       sh
db> 
``

Aug 3 2023, 4:46 AM

Jul 31 2023

pho committed rG896809e29675: stress2: Added killpg(2) scenarios (authored by pho).

stress2: Added killpg(2) scenarios

Jul 31 2023, 7:09 AM

Jul 24 2023

pho added a comment to D40979: radix_trie: speed up search loops.

I ran tests with D40979.id124949.diff on both amd64 and i386. 8 hours on i386 and some 20 hours on amd64.

FreeBSD 14.0-CURRENT i386 1400093 #0 main-n264276-22dca7acf7756-dirty
FreeBSD 14.0-CURRENT #0 main-n264276-22dca7acf7756-dirty (amd64)

No problems observed.

Jul 24 2023, 6:18 PM

Jul 21 2023

pho added a comment to D40979: radix_trie: speed up search loops.

In D40979#936356, @dougm wrote:

Peter, can you test this? It requires testing on multiple platforms.

Jul 21 2023, 6:20 PM

Jul 19 2023

pho added a comment to D41092: libthr: Use a small cache to greatly reduce pshared lock latency..

A buildworld with D41092.id124866.diff added to 239597e0309d4 doesn't compile for me:

===> lib/libthr (obj,all,install)
cc -march=i686 -mmmx -msse -msse2 -target x86_64-unknown-freebsd14.0 -m32  -DCOMPAT_LIBCOMPAT=\"32\"  -DCOMPAT_libcompat=\"32\"  -DCOMPAT_LIB32  --sysroot=/usr/obj/usr/src/amd64.amd64/tmp  -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin -B/usr/obj/usr/src/amd64.amd64/tmp/usr/lib32  -O2 -pipe -fno-common  -DPTHREAD_KERNEL -I/usr/src/lib/libc/include -I/usr/src/lib/libc/i386 -I/usr/src/lib/libthr/thread -I/usr/src/lib/libthr/arch/i386/include -I/usr/src/lib/libthr/sys -I/usr/src/libexec/rtld-elf -I/usr/src/libexec/rtld-elf/i386 -I/usr/src/lib/libthread_db -fexceptions -D_PTHREAD_FORCED_UNWIND -D_PTHREAD_PSC_SIZE=11 -D_PTHREADS_INVARIANTS -mno-mmx -mno-sse -mno-avx -mno-avx2 -MD  -MF.depend.thr_pshared.o -MTthr_pshared.o -std=gnu99 -Wno-format-zero-length -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Wnested-externs -Wold-style-definition -Wno-pointer-sign -Wdate-time -Wmissing-variable-declarations -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Wno-error=unused-but-set-parameter  -Qunused-arguments    -c /usr/src/lib/libthr/thread/thr_pshared.c -o thr_pshared.o
/usr/src/lib/libthr/thread/thr_pshared.c:137:4: error: call to undeclared function 'atomic_add_rel_64'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
                        PSHARED_HTGEN_INVALIDATE();
                        ^
/usr/src/lib/libthr/thread/thr_pshared.c:68:36: note: expanded from macro 'PSHARED_HTGEN_INVALIDATE'
#define PSHARED_HTGEN_INVALIDATE()      atomic_add_rel_64(&pshared_htgen, 1)
                                        ^
/usr/src/lib/libthr/thread/thr_pshared.c:137:4: note: did you mean 'atomic_add_long'?
/usr/src/lib/libthr/thread/thr_pshared.c:68:36: note: expanded from macro 'PSHARED_HTGEN_INVALIDATE'
#define PSHARED_HTGEN_INVALIDATE()      atomic_add_rel_64(&pshared_htgen, 1)
                                        ^
/usr/obj/usr/src/amd64.amd64/tmp/usr/include/i386/atomic.h:602:1: note: 'atomic_add_long' declared here
ATOMIC_ASM(add,      long,  "addl %1,%0",  "ir",  v);
^
/usr/obj/usr/src/amd64.amd64/tmp/usr/include/i386/atomic.h:105:26: note: expanded from macro 'ATOMIC_ASM'
static __inline void                                    \
                                                        ^
<scratch space>:208:1: note: expanded from here
atomic_add_long
^
/usr/src/lib/libthr/thread/thr_pshared.c:158:10: error: call to undeclared function 'atomic_load_acq_64'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
        htgen = atomic_load_acq_64(&pshared_htgen);
                ^
/usr/src/lib/libthr/thread/thr_pshared.c:158:10: note: did you mean 'atomic_load_acq_int'?
/usr/obj/usr/src/amd64.amd64/tmp/usr/include/i386/atomic.h:611:1: note: 'atomic_load_acq_int' declared here
ATOMIC_LOADSTORE(int);
^
/usr/obj/usr/src/amd64.amd64/tmp/usr/include/i386/atomic.h:606:2: note: expanded from macro 'ATOMIC_LOADSTORE'
        ATOMIC_LOAD(TYPE);                              \
        ^
/usr/obj/usr/src/amd64.amd64/tmp/usr/include/i386/atomic.h:253:30: note: expanded from macro 'ATOMIC_LOAD'
static __inline u_##TYPE                                        \
                                                                ^
<scratch space>:241:1: note: expanded from here
atomic_load_acq_int
^
/usr/src/lib/libthr/thread/thr_pshared.c:243:4: error: call to undeclared function 'atomic_add_rel_64'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
                        PSHARED_HTGEN_INVALIDATE();
                        ^
/usr/src/lib/libthr/thread/thr_pshared.c:68:36: note: expanded from macro 'PSHARED_HTGEN_INVALIDATE'
#define PSHARED_HTGEN_INVALIDATE()      atomic_add_rel_64(&pshared_htgen, 1)
                                        ^
/usr/src/lib/libthr/thread/thr_pshared.c:322:2: error: call to undeclared function 'atomic_add_rel_64'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
        PSHARED_HTGEN_INVALIDATE();
        ^
/usr/src/lib/libthr/thread/thr_pshared.c:68:36: note: expanded from macro 'PSHARED_HTGEN_INVALIDATE'
#define PSHARED_HTGEN_INVALIDATE()      atomic_add_rel_64(&pshared_htgen, 1)
                                        ^
4 errors generated.
*** Error code 1

Jul 19 2023, 6:15 PM · Src Committers

Jul 14 2023

pho added a comment to D40936: radix_trie: simplify ge, le lookups.

I ran tests for 16 hours with D40936.id124419.diff on

[pho@mercat1 /usr/src/sys/amd64/compile/PHO]$ uname -a
FreeBSD mercat1.netperf.freebsd.org 14.0-CURRENT FreeBSD 14.0-CURRENT #0 main-n264144-1cd9788408aa9-dirty: Thu Jul 13 21:09:42 CEST 2023     pho@mercat1.netperf.freebsd.org:/usr/src/sys/amd64/compile/PHO amd64
[pho@mercat1 /usr/src/sys/amd64/compile/PHO]$

No issues observed.

Jul 14 2023, 11:33 AM

Jul 11 2023

pho committed rG972e60da74aa: stress2: Added two syzkaller reproducers (authored by pho).

stress2: Added two syzkaller reproducers

Jul 11 2023, 8:25 AM

Jul 9 2023

pho added a comment to D40807: radix_trie: avoid code duplication in insert.

I ran test with D40807.id124308.diff for 15 hours without seeing any issues. This on:

FreeBSD mercat1.netperf.freebsd.org 14.0-CURRENT FreeBSD 14.0-CURRENT #0 main-n264058-5fee12e18967d-dirty: Sat Jul  8 16:35:55 CEST 2023     pho@mercat1.netperf.freebsd.org:/usr/src/sys/amd64/compile/PHO amd64

Jul 9 2023, 5:50 AM

Jul 6 2023

pho added a comment to D40775: radix_trie: replace node count with popmap.

I ran tests with D40775.124202.patch on both i386 and amd64 for 8 hours.

Jul 6 2023, 2:30 PM

pho committed rG4631191c8a5f: stress2: Added a regression test (authored by pho).

stress2: Added a regression test

Jul 6 2023, 9:16 AM

pho added a comment to D40775: radix_trie: replace node count with popmap.

I ran tests with D40775.123968.patch for a day without observing any issues.

Jul 6 2023, 4:01 AM

Jun 30 2023

pho added a comment to D40775: radix_trie: replace node count with popmap.

I ran tests with D40775.123968.patch for a day without observing any issues.

Jun 30 2023, 7:26 AM

Jun 27 2023

pho added a comment to D40746: radix_trie: skip needless compare in lookup_le, lookup_ge.

I ran tests with D40746.id123750.diff for 10 hours without seeing any issues.

Jun 27 2023, 4:57 AM

Jun 21 2023

pho committed rG83c701af5340: stress2: Added two syzkaller reproducers (authored by pho).

stress2: Added two syzkaller reproducers

Jun 21 2023, 9:11 AM

Jun 13 2023

pho committed rGfa273fa15422: stress2: Added a regression test for mksnap_ffs(8) (authored by pho).

stress2: Added a regression test for mksnap_ffs(8)

Jun 13 2023, 9:03 AM

Jun 8 2023

pho committed rG6b7a06c3bdbc: stress2: Avoid using "__unused" (authored by pho).

stress2: Avoid using "__unused"

Jun 8 2023, 7:51 AM

May 27 2023

pho committed rG750ae32b9e60: stress2: Initialize variable (authored by pho).

stress2: Initialize variable

May 27 2023, 8:37 AM

pho committed rG273a89bb14f3: stress2: Tune to get more slightly broken file systems (authored by pho).

stress2: Tune to get more slightly broken file systems

May 27 2023, 8:36 AM

pho committed rGacfb06062a68: stress2: Fix warnings (authored by pho).

stress2: Fix warnings

May 27 2023, 8:36 AM

May 22 2023

pho committed rGbe8d01b51516: stress2: Added a faster test of fsck_ffs by omitting mount(8) and umount(8) (authored by pho).

stress2: Added a faster test of fsck_ffs by omitting mount(8) and umount(8)

May 22 2023, 8:10 AM

pho committed rGca0088ae27a5: stress2: Occasionally modify 8 bits (authored by pho).

stress2: Occasionally modify 8 bits

May 22 2023, 8:10 AM

May 1 2023

pho committed rGb274854dd943: stress2: Added a temporary fix for the UFS+SU "out of inodes" issue (authored by pho).

stress2: Added a temporary fix for the UFS+SU "out of inodes" issue

May 1 2023, 10:55 AM

Apr 25 2023

pho committed rG883a49e5a1f3: stress2: Update the exclude list (authored by pho).

stress2: Update the exclude list

Apr 25 2023, 9:43 AM

Apr 24 2023

pho added a comment to D39767: Various fixes to unionfs error handling logic.

I ran the unionfs tests for a day and a half with the D39767.120881.patch. I did not see any problems.

Apr 24 2023, 4:35 PM

Apr 22 2023

pho committed rG7f658f99f7ed: stress2: Mark set but unused variables as unused (authored by pho).

stress2: Mark set but unused variables as unused

Apr 22 2023, 11:17 AM

Apr 19 2023

pho committed rG9c9dfbf25698: stress2: Added comment of fixed problem. Enable test (authored by pho).

stress2: Added comment of fixed problem. Enable test

Apr 19 2023, 7:27 AM

Apr 14 2023

pho committed rG0ece3355f63f: stress2: Added comment about a new panic found. Test both SU and SU+J. (authored by pho).

stress2: Added comment about a new panic found. Test both SU and SU+J.

Apr 14 2023, 7:56 AM

Apr 10 2023

pho committed rGaf67f36a9288: stress2: Update the exclude list (authored by pho).

stress2: Update the exclude list

Apr 10 2023, 8:05 AM

Apr 8 2023

pho committed rGa02c2856906f: stress2: Tune MAXVNODES to avoid excessive run time (authored by pho).

stress2: Tune MAXVNODES to avoid excessive run time

Apr 8 2023, 7:21 AM

Apr 3 2023

pho committed rG74901941fc86: stress2: Add comment about problem found. Disable run of this test (authored by pho).

stress2: Add comment about problem found. Disable run of this test

Apr 3 2023, 7:34 AM

Apr 1 2023

pho added a comment to D39272: unionfs: remove LK_UPGRADE if falling back to the standard lock.

I added a counter to the fix in vfs_lookup.c The problem test triggered this three time in a three hour test.
This was followed by all of the unions tests for seven hours.
I ran a mix of stress2 tests for two days without seeing any (related) problems.

Apr 1 2023, 4:00 PM

Mar 28 2023

pho added a comment to D39272: unionfs: remove LK_UPGRADE if falling back to the standard lock.

I've been trying to recreate the issue for the last 8 hours. I'll let the test run for a day or two.

Mar 28 2023, 6:10 PM

pho added a comment to D39272: unionfs: remove LK_UPGRADE if falling back to the standard lock.

I ran into this problem:

Mar 28 2023, 7:48 AM

Mar 22 2023

pho committed rGbb1f64b200b5: stress2: Fix syntax error. Remove redundant backup (authored by pho).

stress2: Fix syntax error. Remove redundant backup

Mar 22 2023, 9:07 AM

pho committed rGe689e7facd8d: stress2: Fix compiler warning (authored by pho).

stress2: Fix compiler warning

Mar 22 2023, 9:07 AM

Mar 19 2023

pho committed rGce7b20e5129c: stress2: Added more FFS tests (authored by pho).

stress2: Added more FFS tests

Mar 19 2023, 8:56 AM

Mar 18 2023

pho committed rGbce30c896db6: stress2: Added two syzkaller reproducers (authored by pho).

stress2: Added two syzkaller reproducers

Mar 18 2023, 9:32 AM

Mar 17 2023

pho committed rG7861fce32b4d: stress2: Fix compiler warning (authored by pho).

stress2: Fix compiler warning

Mar 17 2023, 11:07 AM

Mar 16 2023

pho committed rG79f5d67caa69: stress2: New problem found was added (authored by pho).

stress2: New problem found was added

Mar 16 2023, 1:00 PM

Mar 6 2023

pho committed rGee10c61d7a0a: stress2: Fix a off-by-one error. Added check for argument file type (authored by pho).

stress2: Fix a off-by-one error. Added check for argument file type

Mar 6 2023, 9:05 AM

pho accepted D38668: Further updates to UFS/FFS superblock integrity checks when reading a superblock.

OK. LGTM.

Mar 6 2023, 7:59 AM

Feb 28 2023

pho added a comment to D38668: Further updates to UFS/FFS superblock integrity checks when reading a superblock.

I found a disk image to reproduce this panic:

Feb 28 2023, 8:47 AM

Feb 27 2023

pho added a comment to D38668: Further updates to UFS/FFS superblock integrity checks when reading a superblock.

Yes, thank you. That fixed the issue for me. I ran some more tests and uploaded some images you may find interesting:
https://people.freebsd.org/~pho/diskimages.20230227.txz

Feb 27 2023, 7:16 PM