Page MenuHomeFreeBSD

pci: propagate vpd read error
ClosedPublic

Authored by rlibby on Jul 6 2024, 1:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 1, 4:47 AM
Unknown Object (File)
Mon, Feb 17, 2:15 PM
Unknown Object (File)
Feb 9 2025, 12:17 AM
Unknown Object (File)
Feb 7 2025, 11:30 PM
Unknown Object (File)
Feb 5 2025, 5:24 AM
Unknown Object (File)
Jan 26 2025, 5:30 PM
Unknown Object (File)
Jan 25 2025, 2:20 PM
Unknown Object (File)
Jan 23 2025, 9:24 PM
Subscribers

Details

Summary

gcc -Wstringop-overflow diagnosed this. On read error, we would return
-1, but not handle it, causing a zero size malloc of value, and then
we'd unconditionally write value[-1 + 1] = '\0'. This should be
harmless in terms of buffer overflow because we should get a minimum
non-zero size allocation from malloc, but it also effectively swallowed
the error.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable