Page MenuHomeFreeBSD

pci: propagate vpd read error
ClosedPublic

Authored by rlibby on Jul 6 2024, 1:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 1, 6:12 AM
Unknown Object (File)
Jul 12 2024, 12:14 PM
Unknown Object (File)
Jul 9 2024, 3:03 AM
Unknown Object (File)
Jul 8 2024, 2:34 AM
Unknown Object (File)
Jul 7 2024, 12:16 AM
Unknown Object (File)
Jul 6 2024, 9:38 PM
Unknown Object (File)
Jul 6 2024, 8:24 PM
Subscribers

Details

Summary

gcc -Wstringop-overflow diagnosed this. On read error, we would return
-1, but not handle it, causing a zero size malloc of value, and then
we'd unconditionally write value[-1 + 1] = '\0'. This should be
harmless in terms of buffer overflow because we should get a minimum
non-zero size allocation from malloc, but it also effectively swallowed
the error.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58534
Build 55422: arc lint + arc unit