- User Since
- Nov 12 2015, 8:14 PM (196 w, 4 d)
Tue, Aug 6
I like that this also moves the logging code text out of line.
Tue, Jul 23
Looks good to me.
Mon, Jul 22
Logic looks good but I think the terminology is a little misleading. What the flag actually tracks is the last drained byte (mostly, see below). Including "drain" in the name somehow might make it more clear.
Jul 2 2019
Jul 1 2019
Fix up for conflict with r349369.
Jun 30 2019
Jun 28 2019
Friendly ping. There's no particular rush, but I believe that the functionality here is useful. I have uncovered around a dozen bugs with it.
Jun 25 2019
Jun 24 2019
Jun 22 2019
Here's an example of how I have been applying this. This one looks like a locking bug in an error path in in6_joingroup_locked. I'll submit a separate review for it.
Jun 20 2019
Jun 7 2019
May 16 2019
May 15 2019
I'm not qualified to review, but LGTM besides a couple nit picks.
@cem got this pushed upstream  and we pulled it back down with v1.3.8 in r342598.
Equivalent patch was done in r343672 by @vangyzen .
May 8 2019
Dec 13 2018
Silence warnings in code instead of disabling the warning.
@cem is direct commit to sys/contrib/zstd okay for this?
Jun 13 2018
Jun 11 2018
Jun 9 2018
dim feedback: use CWARNFLAGS.gcc for warning suppression
Nov 1 2017
Always nice to have minus diffs, assuming it still compiles :)
Most of these changes look to be in the right direction. I don't think evaluating if a bool == true or == false is necessary. In some places parentheses have been added which are not strictly needed, I don't feel strongly about those either way. I did not evaluate for completeness.
My opinion is generally that branch predictions should be sparse. Is it really going to make any difference in setup/teardown functions, which many of the functions edited here appear to be?
Oct 22 2017
Review feedback: avoid touching "superfluous" macro parens for now
mjoras feedback: parenthesization fixes
Oct 21 2017
Oct 18 2017
Oct 17 2017
Oct 16 2017
Oct 14 2017
hselasky feedback: replace const vars with enum constants