Page MenuHomeFreeBSD

rlibby (Ryan Libby)
User

Projects

User Details

User Since
Nov 12 2015, 8:14 PM (270 w, 1 d)

Recent Activity

Tue, Jan 12

rlibby updated the diff for D28043: pms: handle maximum size IO with any alignment.

imp feedback: keep the limit

Tue, Jan 12, 8:38 AM

Mon, Jan 11

rlibby committed R10:16079c7233be: hid: quiet -Wswitch (authored by rlibby).
hid: quiet -Wswitch
Mon, Jan 11, 5:56 AM
rlibby closed D28082: hid: quiet -Wswitch.
Mon, Jan 11, 5:56 AM
rlibby closed D28081: pf: quiet -Wredundant-decls for pf_get_ruleset_number.
Mon, Jan 11, 5:55 AM
rlibby committed R10:c86fa3b8d72f: pf: quiet -Wredundant-decls for pf_get_ruleset_number (authored by rlibby).
pf: quiet -Wredundant-decls for pf_get_ruleset_number
Mon, Jan 11, 5:55 AM
rlibby closed D28036: dtrace tests: fix prototypes for gcc build.
Mon, Jan 11, 5:55 AM
rlibby committed R10:c14e17a49cdd: dtrace tests: fix prototypes for gcc build (authored by rlibby).
dtrace tests: fix prototypes for gcc build
Mon, Jan 11, 5:55 AM

Sun, Jan 10

rlibby updated the diff for D28082: hid: quiet -Wswitch.

Feedback: use default instead of listing cases

Sun, Jan 10, 7:58 PM
rlibby added a comment to D28082: hid: quiet -Wswitch.

The advantage of listing cases instead of using default would be that if another enum value ever gets added, then the compiler's warning about unhandled cases won't have been suppressed. But I agree it's uglier. I'll change it to default.

Sun, Jan 10, 7:33 PM
rlibby requested review of D28082: hid: quiet -Wswitch.
Sun, Jan 10, 7:59 AM
rlibby requested review of D28081: pf: quiet -Wredundant-decls for pf_get_ruleset_number.
Sun, Jan 10, 7:55 AM

Fri, Jan 8

rlibby added inline comments to D28043: pms: handle maximum size IO with any alignment.
Fri, Jan 8, 7:55 PM
rlibby requested review of D28043: pms: handle maximum size IO with any alignment.
Fri, Jan 8, 7:31 PM
rlibby requested review of D28036: dtrace tests: fix prototypes for gcc build.
Fri, Jan 8, 7:33 AM

Wed, Jan 6

rlibby requested review of D27994: pms: quiet -Wunused-variable.
Wed, Jan 6, 1:14 AM

Tue, Jan 5

rlibby committed R10:f1007ba88d47: ixl: quiet -Wunused-function (authored by rlibby).
ixl: quiet -Wunused-function
Tue, Jan 5, 9:56 PM
rlibby closed D27817: ixl: quiet -Wunused-function.
Tue, Jan 5, 9:56 PM

Sun, Jan 3

rlibby closed D27944: bitset.9: add missing MLINKS.
Sun, Jan 3, 8:53 PM
rlibby committed R10:1c55eab10464: bitset.9: add missing MLINKS (authored by rlibby).
bitset.9: add missing MLINKS
Sun, Jan 3, 8:53 PM
rlibby requested review of D27944: bitset.9: add missing MLINKS.
Sun, Jan 3, 6:01 PM
rlibby closed D27897: arm: fix atomic_testand{set,clear}_64 for ops on high bits.
Sun, Jan 3, 2:11 AM
rlibby committed R10:486580c44ce2: arm: fix atomic_testand{set,clear}_64 for ops on high bits (authored by rlibby).
arm: fix atomic_testand{set,clear}_64 for ops on high bits
Sun, Jan 3, 2:11 AM

Sat, Jan 2

rlibby added inline comments to D27895: arm: atomic_testand{set,clear} didn't follow atomic(9) API.
Sat, Jan 2, 10:50 PM
rlibby abandoned D27895: arm: atomic_testand{set,clear} didn't follow atomic(9) API.

Closing this one as overcome-by-events. Opened D27897.

Sat, Jan 2, 8:30 PM
rlibby requested review of D27897: arm: fix atomic_testand{set,clear}_64 for ops on high bits.
Sat, Jan 2, 8:29 PM
rlibby closed D27886: arm64: fix mask in atomic_testand{set,clear}_64.
Sat, Jan 2, 8:14 PM
rlibby committed R10:82661227eddf: arm64: fix mask in atomic_testand{set,clear}_64 (authored by rlibby).
arm64: fix mask in atomic_testand{set,clear}_64
Sat, Jan 2, 8:14 PM
rlibby added inline comments to D27895: arm: atomic_testand{set,clear} didn't follow atomic(9) API.
Sat, Jan 2, 7:30 PM
rlibby requested review of D27895: arm: atomic_testand{set,clear} didn't follow atomic(9) API.
Sat, Jan 2, 7:25 PM
rlibby added a comment to D27886: arm64: fix mask in atomic_testand{set,clear}_64.
In D27886#623424, @mmel wrote:
In D27886#623242, @mmel wrote:

Good catch. It never occurred to me that we could have a bug in atomics on two architectures at the same time, so I wasn't looking for a problem in my own garden :) I will try to fix arm by myself.

Are you saying 32-bit ARM is also broken? Those are a little weirder, I think it uses sys/sys/_atomic_subword.h.

Yes, it is also broken. ARM uses its own implementation, which does not do modulo for the bit position.
See https://cgit.freebsd.org/src/tree/sys/arm/include/atomic-v6.h#n862.
I will commit proper fix in next hour or so...

Sat, Jan 2, 7:13 PM
rlibby added a comment to D27891: bitset: Fix BIT_TEST_SET_ATOMIC and BIT_TEST_CLR_ATOMIC..

You're right that 32-bit arm also has a bug though and needs more follow up.

Sat, Jan 2, 7:12 PM
rlibby added a comment to D27886: arm64: fix mask in atomic_testand{set,clear}_64.
In D27886#623242, @mmel wrote:

Good catch. It never occurred to me that we could have a bug in atomics on two architectures at the same time, so I wasn't looking for a problem in my own garden :) I will try to fix arm by myself.

Are you saying 32-bit ARM is also broken? Those are a little weirder, I think it uses sys/sys/_atomic_subword.h.

Sat, Jan 2, 6:26 PM
rlibby added a comment to D27886: arm64: fix mask in atomic_testand{set,clear}_64.
In D27886#623242, @mmel wrote:

Good catch. It never occurred to me that we could have a bug in atomics on two architectures at the same time, so I wasn't looking for a problem in my own garden :) I will try to fix arm by myself.

Sat, Jan 2, 5:43 PM
rlibby added a comment to D27891: bitset: Fix BIT_TEST_SET_ATOMIC and BIT_TEST_CLR_ATOMIC..

Actually atomic(9) says that it will do the mod:

atomic_testandset(p, v)
        bit = 1 << (v % (sizeof(*p) * NBBY));
        tmp = (*p & bit) != 0;
        *p |= bit;
        return (tmp);
Sat, Jan 2, 5:35 PM
rlibby requested review of D27886: arm64: fix mask in atomic_testand{set,clear}_64.
Sat, Jan 2, 5:09 AM

Thu, Dec 31

rlibby closed D22703: uma dbg: catch more corruption with atomics.
Thu, Dec 31, 9:04 PM
rlibby committed R10:942951ba46ec: uma dbg: catch more corruption with atomics (authored by rlibby).
uma dbg: catch more corruption with atomics
Thu, Dec 31, 9:04 PM
rlibby closed D22702: bitset: implement BIT_TEST_CLR_ATOMIC & BIT_TEST_SET_ATOMIC.
Thu, Dec 31, 9:04 PM
rlibby committed R10:ae4a8e52072a: bitset: implement BIT_TEST_CLR_ATOMIC & BIT_TEST_SET_ATOMIC (authored by rlibby).
bitset: implement BIT_TEST_CLR_ATOMIC & BIT_TEST_SET_ATOMIC
Thu, Dec 31, 9:04 PM
rlibby committed R10:939430f23771: Fix the build of scandir_b with GCC. (authored by jhb).
Fix the build of scandir_b with GCC.
Thu, Dec 31, 8:48 PM
rlibby committed R10:24236af8d5eb: libc: hide alphasort_thunk behind I_AM_SCANDIR_B (authored by mjg).
libc: hide alphasort_thunk behind I_AM_SCANDIR_B
Thu, Dec 31, 8:48 PM
rlibby requested review of D27861: infiniband: fix LINT-NOIP kernel build.
Thu, Dec 31, 3:21 AM
rlibby updated the diff for D22703: uma dbg: catch more corruption with atomics.

Rebase, over

Thu, Dec 31, 12:49 AM
rlibby added a comment to D22702: bitset: implement BIT_TEST_CLR_ATOMIC & BIT_TEST_SET_ATOMIC.

I think r359311 / git ca0ec73c11a7bb9ed409466e514fa5c34b6c84b5 / D22963 (generic atomic_testand{set,clear}_long) satisfied the dependency I was worried about here so I'm going to go ahead with this. The only conflict in the rebase was the man doc date.

Thu, Dec 31, 12:37 AM

Wed, Dec 30

rlibby committed R10:be3bbda216c5: Don't add -Wno-class-memaccess with older gcc. (authored by brooks).
Don't add -Wno-class-memaccess with older gcc.
Wed, Dec 30, 11:18 PM
rlibby updated subscribers of D27817: ixl: quiet -Wunused-function.
Wed, Dec 30, 4:56 AM
rlibby accepted D27814: [vale] Fix valectl to compile on a 32-bit platform.

LGTM. The same construct is seen in other assignments to pointers from nr_body.

Wed, Dec 30, 3:42 AM

Tue, Dec 29

rlibby committed R10:f728bcf204ee: [nvmecontrol] Fix type signedness warning-to-error on gcc-6.4 (authored by adrian).
[nvmecontrol] Fix type signedness warning-to-error on gcc-6.4
Tue, Dec 29, 11:08 PM
rlibby committed R10:0286ee71041c: [libnetmap] Fix 32 bit compilation under gcc-6.4 (authored by adrian).
[libnetmap] Fix 32 bit compilation under gcc-6.4
Tue, Dec 29, 11:08 PM
rlibby committed R10:62a77bb7edb2: [libsa] Fix typecast of pointer for st_dev (authored by adrian).
[libsa] Fix typecast of pointer for st_dev
Tue, Dec 29, 11:08 PM
rlibby committed R10:269b7d8ac1e5: tftpd: tests: raise targeted cstd to c11 (authored by kevans).
tftpd: tests: raise targeted cstd to c11
Tue, Dec 29, 11:08 PM
rlibby requested review of D27817: ixl: quiet -Wunused-function.
Tue, Dec 29, 8:15 PM

Mon, Dec 28

rlibby closed D27768: kern.mk: drop flag only patched in-tree gcc understood.
Mon, Dec 28, 10:05 PM
rlibby committed R10:629c4aeacefe: kern.mk: drop flag only patched in-tree gcc understood (authored by rlibby).
kern.mk: drop flag only patched in-tree gcc understood
Mon, Dec 28, 10:04 PM
rlibby committed R10:63f93c7e11e3: rtld-elf: link libcompiler_rt on all architectures (authored by rlibby).
rtld-elf: link libcompiler_rt on all architectures
Mon, Dec 28, 8:49 AM
rlibby added a reverting change for R10:bce2cff0bc0e: rtld-elf: link udivmoddi4 from compiler_rt: R10:85b8932d0a9a: Revert "rtld-elf: link udivmoddi4 from compiler_rt".
Mon, Dec 28, 8:48 AM
rlibby committed R10:85b8932d0a9a: Revert "rtld-elf: link udivmoddi4 from compiler_rt" (authored by rlibby).
Revert "rtld-elf: link udivmoddi4 from compiler_rt"
Mon, Dec 28, 8:48 AM
rlibby committed R10:a723bb667e48: libcompiler_rt: stop building with stack smashing protection (authored by rlibby).
libcompiler_rt: stop building with stack smashing protection
Mon, Dec 28, 8:48 AM
rlibby closed D27736: rtld-elf: link libcompiler_rt on all architectures.
Mon, Dec 28, 8:48 AM
rlibby added a reverting change for D27665: rtld-elf: link udivmoddi4 from compiler_rt: R10:85b8932d0a9a: Revert "rtld-elf: link udivmoddi4 from compiler_rt".
Mon, Dec 28, 8:48 AM
rlibby closed D27786: libcompiler_rt: stop building with stack smashing protection.
Mon, Dec 28, 8:48 AM
rlibby committed R10:833dbf1e2288: route: quiet -Wredundant-decls (authored by rlibby).
route: quiet -Wredundant-decls
Mon, Dec 28, 1:57 AM
rlibby closed D27790: route: quiet -Wredundant-decls.
Mon, Dec 28, 1:57 AM
rlibby added a reviewer for D27768: kern.mk: drop flag only patched in-tree gcc understood: kib.
Mon, Dec 28, 12:34 AM
rlibby closed D27562: bc: use __has_attribute to test attribute presence.

Resolved by @se's import of bc 3.2.4.

Mon, Dec 28, 12:07 AM

Sun, Dec 27

rlibby requested review of D27790: route: quiet -Wredundant-decls.
Sun, Dec 27, 11:15 PM
rlibby committed R10:f2d48b5e2c3b: Merge commit d8a09b3a0 from openzfs git (by Ryan Libby): (authored by rlibby).
Merge commit d8a09b3a0 from openzfs git (by Ryan Libby):
Sun, Dec 27, 11:09 PM
rlibby committed R10:21ce674e3c7e: Merge commit 956f94010 from openzfs git (by Ryan Libby): (authored by rlibby).
Merge commit 956f94010 from openzfs git (by Ryan Libby):
Sun, Dec 27, 11:08 PM
rlibby committed R10:48184e76619d: Merge commit c7500ded3 from openzfs git (by Ryan Libby): (authored by rlibby).
Merge commit c7500ded3 from openzfs git (by Ryan Libby):
Sun, Dec 27, 11:07 PM
rlibby closed D27685: openzfs: fix gcc kernel module builds.
Sun, Dec 27, 11:06 PM
rlibby committed R10:e67d933d9c06: Merge commit 3fcd73747 from openzfs git (by Adrian Chadd): (authored by rlibby).
Merge commit 3fcd73747 from openzfs git (by Adrian Chadd):
Sun, Dec 27, 11:06 PM
rlibby committed R10:d021434a7960: openzfs: fix gcc kernel module builds (authored by rlibby).
openzfs: fix gcc kernel module builds
Sun, Dec 27, 11:06 PM
rlibby committed R10:913f2d2e0cd3: Merge commit 79a357c2a from openzfs git (by Adrian Chadd): (authored by rlibby).
Merge commit 79a357c2a from openzfs git (by Adrian Chadd):
Sun, Dec 27, 11:06 PM
rlibby added inline comments to D27736: rtld-elf: link libcompiler_rt on all architectures.
Sun, Dec 27, 8:25 PM
rlibby retitled D27736: rtld-elf: link libcompiler_rt on all architectures from rtld-elf: link static no-SSP libcompiler_rt to rtld-elf: link libcompiler_rt on all architectures.
Sun, Dec 27, 8:18 PM
rlibby requested review of D27786: libcompiler_rt: stop building with stack smashing protection.
Sun, Dec 27, 8:17 PM
rlibby updated the diff for D27736: rtld-elf: link libcompiler_rt on all architectures.

feedback: just link libcompiler_rt, which will now be no-SSP

Sun, Dec 27, 8:14 PM
rlibby added a comment to D27562: bc: use __has_attribute to test attribute presence.

Yep, just a friendly ping. I'm eager to finish the gcc work, but it is definitely not urgent. Thank you!

Sun, Dec 27, 12:40 AM
rlibby added a comment to D27736: rtld-elf: link libcompiler_rt on all architectures.
In D27736#620834, @kib wrote:

I think we should change compiler-rt to not compile with -fstack-protector, and then link it into rtld.

I realized that there is a (strong) argument to make the library not compiled with the flag. It is linked statically into binaries, because compiler support functions are not port of the OS ABI. So if compiler-rt is compiled with SSP, it is impossible to build a binary without SSP.

Sun, Dec 27, 12:39 AM

Sat, Dec 26

rlibby added a comment to D27562: bc: use __has_attribute to test attribute presence.

@se Now that vendor workflows are open for git, can we get upstream's fix in? Or do you prefer I just do a direct commit of upstream's fix as discussed above?

Sat, Dec 26, 9:05 PM
rlibby added a comment to D27736: rtld-elf: link libcompiler_rt on all architectures.

Here's the alternate where we just cross our fingers and link libcompiler_rt (no surprises):
https://github.com/rlibby/freebsd/commit/f61af4c21d62280d2b6e9c360606cae781d8f316

Sat, Dec 26, 9:04 PM

Fri, Dec 25

rlibby added a reviewer for D18539: powl: avoid referring to broken LDBL_MAX: jhb.
Fri, Dec 25, 2:01 AM

Thu, Dec 24

rlibby closed D27767: wmt: quiet gcc -Wparentheses.
Thu, Dec 24, 8:51 PM
rlibby committed R10:322a188d45f1: wmt: quiet gcc -Wparentheses (authored by rlibby).
wmt: quiet gcc -Wparentheses
Thu, Dec 24, 8:51 PM
rlibby committed R10:2fb4a03d55a9: rtsock: quiet -Wunused-variable in LINT-NOIP kernels (authored by rlibby).
rtsock: quiet -Wunused-variable in LINT-NOIP kernels
Thu, Dec 24, 8:37 PM
rlibby committed R10:1ee339e257b3: openzfs: fix gcc in-kernel builds (authored by rlibby).
openzfs: fix gcc in-kernel builds
Thu, Dec 24, 8:37 PM
rlibby closed D27730: rtsock: quiet -Wunused-variable in LINT-NOIP kernels.
Thu, Dec 24, 8:37 PM
rlibby closed D27684: openzfs: fix gcc in-kernel builds.
Thu, Dec 24, 8:37 PM
rlibby added a comment to D27767: wmt: quiet gcc -Wparentheses.

@wulf (sorry forgot to ask) Is it okay if I push this straight to current or would you prefer to route it through the upstream first?

Thu, Dec 24, 8:32 PM
rlibby requested review of D27768: kern.mk: drop flag only patched in-tree gcc understood.
Thu, Dec 24, 7:33 PM
rlibby requested review of D27767: wmt: quiet gcc -Wparentheses.
Thu, Dec 24, 7:17 PM
rlibby added a comment to D27685: openzfs: fix gcc kernel module builds.

@gnn did you want to take a look at this patch before it goes in? It is just turning down nuisance warnings for gcc compatibility.

Thu, Dec 24, 2:46 AM

Wed, Dec 23

rlibby added a comment to D27736: rtld-elf: link libcompiler_rt on all architectures.

I'm not particularly keen on building all of compiler-rt again without SSP just for the 2-3 files that rtld needs. I'd be surprised if those functions even use SSP with -fstack-protector-strong. Are there any functions in compiler-rt that would benefit from SSP?

Wed, Dec 23, 8:17 PM
rlibby added inline comments to D27684: openzfs: fix gcc in-kernel builds.
Wed, Dec 23, 8:21 AM
rlibby updated the diff for D27736: rtld-elf: link libcompiler_rt on all architectures.

Actually include all the changes

Wed, Dec 23, 8:04 AM
rlibby requested review of D27736: rtld-elf: link libcompiler_rt on all architectures.
Wed, Dec 23, 7:58 AM

Tue, Dec 22

rlibby updated subscribers of D27730: rtsock: quiet -Wunused-variable in LINT-NOIP kernels.
Tue, Dec 22, 8:45 PM
rlibby added a comment to D27730: rtsock: quiet -Wunused-variable in LINT-NOIP kernels.

Ty for fixing this!

Tue, Dec 22, 8:40 PM
rlibby requested review of D27730: rtsock: quiet -Wunused-variable in LINT-NOIP kernels.
Tue, Dec 22, 7:05 PM
rlibby added a comment to D26201: Disabling -Woverflow errors for i386 for GCC 9..

Is this specifically for LDBL_MAX?

Tue, Dec 22, 2:15 AM