User Details
- User Since
- Nov 12 2015, 8:14 PM (469 w, 4 d)
Aug 14 2024
I'm okay with the idea but I'm a little worried that it changes the semantics of vm_page_insert / vm_page_insert_after, which I just preserved with the insert_lookup patch. Those two procedures have several callers. However, several of the callers appear to be broken (lacking error checks), so maybe we should audit them all anyway.
Jul 20 2024
Jul 19 2024
After some experiments, I think that [[noreturn]] is not a solution that either clang or g++ will accept.
Jul 17 2024
Hmm, I've been avoiding addressing warnings in contrib...
I guess you can also consider if you want to make the malloc spelling more conventional. Don't need the casts, and can now do sizeof(*asyreq). I'm ambivalent, but in case you hadn't considered it.
I don't know this code but I'm assuming that we don't really care about
the overhead here or performance generally for this ioctl. In other
words, we don't need a longer term fix to do a saner amount of copying,
correct? It seems that we never actually use asyreq->data in the ioctl,
so we're now allocating and passing around an extra 2k because of a
weird definition?
Jul 14 2024
I haven't looked at swap_pager.c yet. I'll get back to that hopefully tonight.
Jul 9 2024
Any more input on this one?
Jul 8 2024
kib: style fixup
Jul 7 2024
Jul 6 2024
kib: comment the cflag
kib: just disable all builtins
Jul 5 2024
Yeah, we should use the value from sx_try_lock, and we'd like to enforce that it's checked too I guess.
imp: sx_xlock too
Jul 3 2024
Jul 2 2024
By the way, I thought about also making these strict-aliasing safe with a union. It's straightforward and also gets rid of the casts. However, since we explicitly build with -fno-strict-aliasing, there's not much motivation. But in case you'd prefer that, I can tweak these patches.
Jul 1 2024
diff -u1000 sys/{i386,amd64}/include/pcpu.h for comparison to D45826. Ignore the #if 0 for testing.
Test patch used to examine codegen: