- User Since
- Nov 12 2015, 8:14 PM (292 w, 1 d)
Apr 15 2021
Will work on a providing a better semaphore first.
Apr 7 2021
Apr 1 2021
Mar 23 2021
LGTM, and I checked $work's tree for other references.
Mar 22 2021
Mar 14 2021
Mar 11 2021
Mar 5 2021
Change looks fine once the i386 hack is restored.
Feb 25 2021
This can be done without introducing another object pointer (nobj) by resetting lobj and following the pattern elsewhere, but I found the approach with nobj to be more readable.
Feb 24 2021
I guess this case is intended for when a single-ish writer is outpacing the buf daemon?
Feb 21 2021
I have a couple questions, but the change itself looks fine.
Feb 20 2021
Feb 18 2021
Dropping, alternate solution committed as 0a4f851074a3ca74cd4859c20e7d9807b2aeca65.
Feb 17 2021
I'm obviously not the maintainer but:
Patch itself looks fine.
markj feedback: man style
markj feedback: ANSI-fy while here
- Rename the sysctl and make it tunable
- output a warning when input is dropped
- man page blurb
Feb 16 2021
Feb 15 2021
imp feedback: provide a chicken switch
Feb 14 2021
Feb 10 2021
Jan 28 2021
Jan 27 2021
This approach seems safe but obviously makes the lookup twice as slow when the buffer doesn't exist. I'm not sure we could do better easily...
Jan 20 2021
Jan 12 2021
imp feedback: keep the limit
Jan 11 2021
Jan 10 2021
Feedback: use default instead of listing cases
The advantage of listing cases instead of using default would be that if another enum value ever gets added, then the compiler's warning about unhandled cases won't have been suppressed. But I agree it's uglier. I'll change it to default.
Jan 8 2021
Jan 6 2021
Jan 5 2021
Jan 3 2021
Jan 2 2021
Closing this one as overcome-by-events. Opened D27897.