Page MenuHomeFreeBSD

rlibby (Ryan Libby)
User

Projects

User Details

User Since
Nov 12 2015, 8:14 PM (205 w, 1 d)

Recent Activity

Aug 6 2019

rlibby added inline comments to D21165: GEOM: Reduce unnecessary log interleaving with sbufs.
Aug 6 2019, 6:01 PM
rlibby added a comment to D21165: GEOM: Reduce unnecessary log interleaving with sbufs.

I like that this also moves the logging code text out of line.

Aug 6 2019, 6:28 AM

Jul 23 2019

D21030: sbuf(9): Add sbuf_nl_terminate() API is now accepted and ready to land.

Looks good to me.

Jul 23 2019, 8:59 PM

Jul 22 2019

rlibby added a comment to D21030: sbuf(9): Add sbuf_nl_terminate() API.
In D21030#456361, @cem wrote:

Logic looks good but I think the terminology is a little misleading. What the flag actually tracks is the last drained byte (mostly, see below). Including "drain" in the name somehow might make it more clear.

Well, it's a little more complicated than that; it's a yes/no bit for "if the buffer is currently empty, did we drain a non-newline character last?" Unfortunately, the usual pattern for documenting flags only leaves a handful of characters, so I did what I could in the space. If you'd prefer a longer flag comment, I can wrap the line and elaborate.

Jul 22 2019, 11:21 PM
rlibby added a comment to D21030: sbuf(9): Add sbuf_nl_terminate() API.

Logic looks good but I think the terminology is a little misleading. What the flag actually tracks is the last drained byte (mostly, see below). Including "drain" in the name somehow might make it more clear.

Jul 22 2019, 8:28 PM

Jul 2 2019

rlibby added a comment to D20739: in6_joingroup_locked: need if_addr_lock around in6m_disconnect_locked.

Patch looks good to me. Did you run this patch, I.E. force the error case somehow?

General background is that this patch and others are fallout from applying the error injection in D20714 (in this case, injecting errors for M_NOWAIT allocs of mbufs). They have mostly been tested with "it used to panic and now it doesn't," but I will see if I can confirm having tickled the specific error paths with dtrace.

Jul 2 2019, 4:20 PM
rlibby added a comment to D20739: in6_joingroup_locked: need if_addr_lock around in6m_disconnect_locked.

Patch looks good to me. Did you run this patch, I.E. force the error case somehow?

Jul 2 2019, 2:50 PM

Jul 1 2019

rlibby closed D20744: g_mirror_taste: avoid deadlock, always clear tasting flag.
Jul 1 2019, 10:08 PM
rlibby committed rS349587: g_mirror_taste: avoid deadlock, always clear tasting flag.
g_mirror_taste: avoid deadlock, always clear tasting flag
Jul 1 2019, 10:08 PM
rlibby committed rS349586: g_eli_create: only dec g_access acw if we inc'd it.
g_eli_create: only dec g_access acw if we inc'd it
Jul 1 2019, 10:06 PM
rlibby closed D20743: g_eli_create: only dec g_access acw if we inc'd it.
Jul 1 2019, 10:06 PM
rlibby updated subscribers of D20740: in_mcast.c: need if_addr_lock around inm_release_deferred.
Jul 1 2019, 4:08 PM
rlibby updated subscribers of D20739: in6_joingroup_locked: need if_addr_lock around in6m_disconnect_locked.
Jul 1 2019, 4:08 PM
rlibby added a comment to D20740: in_mcast.c: need if_addr_lock around inm_release_deferred.

Fix up for conflict with r349369.

Jul 1 2019, 4:04 PM
rlibby added inline comments to D20714: malloc/zalloc M_NOWAIT failure injection.
Jul 1 2019, 12:22 AM

Jun 30 2019

rlibby added a comment to D20722: uma: trash memory when ctor/dtor supplied too.

I don't quite understand how this can work in all cases. Consider vm_radix_node_zone for instance. When a radix node is freed, we expect all of its child pointers to have been cleared, and INVARIANTS kernels we define a dtor which verifies that. Then, when allocating a radix node we do not pass M_ZERO because we expect that the child pointers are already zeroed. With this change I think we will return trashed nodes, which violates the assumptions of the vm radix code.

Jun 30 2019, 6:18 PM

Jun 28 2019

rlibby added a comment to D20714: malloc/zalloc M_NOWAIT failure injection.

Friendly ping. There's no particular rush, but I believe that the functionality here is useful. I have uncovered around a dozen bugs with it.

Jun 28 2019, 11:20 PM

Jun 25 2019

rlibby committed rS349373: netipsec key_register: check for M_NOWAIT alloc failure.
netipsec key_register: check for M_NOWAIT alloc failure
Jun 25 2019, 3:44 PM
rlibby closed D20742: netipsec key_register: check for M_NOWAIT alloc failure.
Jun 25 2019, 3:44 PM

Jun 24 2019

rlibby added a comment to D20744: g_mirror_taste: avoid deadlock, always clear tasting flag.

As a precaution I'd suggest running the tests under /usr/tests/sys/geom/class/mirror.

Jun 24 2019, 6:21 PM
rlibby created D20744: g_mirror_taste: avoid deadlock, always clear tasting flag.
Jun 24 2019, 4:33 PM
rlibby created D20743: g_eli_create: only dec g_access acw if we inc'd it.
Jun 24 2019, 4:32 PM
rlibby created D20742: netipsec key_register: check for M_NOWAIT alloc failure.
Jun 24 2019, 4:31 PM
rlibby created D20740: in_mcast.c: need if_addr_lock around inm_release_deferred.
Jun 24 2019, 4:28 PM
rlibby created D20739: in6_joingroup_locked: need if_addr_lock around in6m_disconnect_locked.
Jun 24 2019, 4:27 PM
rlibby created D20738: mld6: solve M_NOWAIT softc allocation failure.
Jun 24 2019, 4:26 PM
rlibby created D20737: igmp: solve M_NOWAIT softc allocation failure.
Jun 24 2019, 4:25 PM

Jun 22 2019

rlibby added a comment to D20714: malloc/zalloc M_NOWAIT failure injection.

Here's an example of how I have been applying this. This one looks like a locking bug in an error path in in6_joingroup_locked. I'll submit a separate review for it.

Jun 22 2019, 6:16 PM
rlibby committed rS349288: ddb show proc typo.
ddb show proc typo
Jun 22 2019, 5:35 AM
rlibby created D20722: uma: trash memory when ctor/dtor supplied too.
Jun 22 2019, 3:31 AM

Jun 20 2019

rlibby created D20714: malloc/zalloc M_NOWAIT failure injection.
Jun 20 2019, 11:10 PM

Jun 7 2019

rlibby committed rS348770: Allow fail points to have separate declarations, definitions, and evals.
Allow fail points to have separate declarations, definitions, and evals
Jun 7 2019, 4:09 AM
rlibby closed D20546: Allow fail points to have separate declarations, definitions, and evals.
Jun 7 2019, 4:09 AM
rlibby updated subscribers of D20546: Allow fail points to have separate declarations, definitions, and evals.
Jun 7 2019, 1:10 AM
rlibby created D20546: Allow fail points to have separate declarations, definitions, and evals.
Jun 7 2019, 1:09 AM

May 16 2019

rlibby committed rS347646: db show thread: avoid overflow in tick conversion.
db show thread: avoid overflow in tick conversion
May 16 2019, 5:30 AM
rlibby closed D20273: db show thread: avoid overlow in tick conversion.
May 16 2019, 5:30 AM
rlibby created D20273: db show thread: avoid overlow in tick conversion.
May 16 2019, 5:04 AM
rlibby committed rS347645: iommu static analysis cleanup.
iommu static analysis cleanup
May 16 2019, 4:24 AM
rlibby closed D20263: iommu static analysis cleanup.
May 16 2019, 4:24 AM

May 15 2019

rlibby added a comment to D20181: For the LinuxKPI allow loading the same DMA address multiple times without any prior unload.

I'm not qualified to review, but LGTM besides a couple nit picks.

May 15 2019, 11:33 PM
rlibby closed D20264: x86: spell vpxor %zmm0 as vpxord.
May 15 2019, 6:14 PM
rlibby committed rS347628: x86: spell vpxor %zmm0 as vpxord.
x86: spell vpxor %zmm0 as vpxord
May 15 2019, 6:14 PM
rlibby added inline comments to D20263: iommu static analysis cleanup.
May 15 2019, 5:06 PM
rlibby added inline comments to D20263: iommu static analysis cleanup.
May 15 2019, 3:14 PM
rlibby created D20264: x86: spell vpxor %zmm0 as vpxord.
May 15 2019, 6:43 AM
rlibby created D20263: iommu static analysis cleanup.
May 15 2019, 5:59 AM
rlibby abandoned D18537: zstd: ifdef out visibility of floats in kernel for gcc.

@cem got this pushed upstream [1] and we pulled it back down with v1.3.8 in r342598.

May 15 2019, 5:05 AM
rlibby abandoned D18538: rtld-elf/i386: silence gcc warnings.

Equivalent patch was done in r343672 by @vangyzen .

May 15 2019, 5:00 AM

May 8 2019

rlibby added inline comments to D20181: For the LinuxKPI allow loading the same DMA address multiple times without any prior unload.
May 8 2019, 10:30 PM

Dec 13 2018

rlibby updated the diff for D18538: rtld-elf/i386: silence gcc warnings.

Silence warnings in code instead of disabling the warning.

Dec 13 2018, 10:42 PM
rlibby retitled D18538: rtld-elf/i386: silence gcc warnings from rtld-elf: -Wno-error=maybe-uninitialized for gcc to rtld-elf/i386: silence gcc warnings.
Dec 13 2018, 10:42 PM
rlibby added inline comments to D18537: zstd: ifdef out visibility of floats in kernel for gcc.
Dec 13 2018, 9:57 PM
rlibby added inline comments to D18537: zstd: ifdef out visibility of floats in kernel for gcc.
Dec 13 2018, 5:56 PM
rlibby updated subscribers of D18538: rtld-elf/i386: silence gcc warnings.

@cem pointed out to me r340842 & r340843. @kib would you prefer we just
did the same to i386 as was done to amd64?

Dec 13 2018, 7:58 AM
rlibby created D18539: powl: avoid referring to broken LDBL_MAX.
Dec 13 2018, 7:16 AM
rlibby created D18538: rtld-elf/i386: silence gcc warnings.
Dec 13 2018, 7:13 AM
rlibby added a comment to D18537: zstd: ifdef out visibility of floats in kernel for gcc.

@cem is direct commit to sys/contrib/zstd okay for this?

Dec 13 2018, 7:09 AM
rlibby created D18537: zstd: ifdef out visibility of floats in kernel for gcc.
Dec 13 2018, 7:09 AM

Jun 13 2018

rlibby committed rS335076: i386: copyin/copyout error is EFAULT.
i386: copyin/copyout error is EFAULT
Jun 13 2018, 7:57 PM

Jun 11 2018

rlibby committed rS334957: pmc gcc fixups.
pmc gcc fixups
Jun 11 2018, 4:10 PM
rlibby closed D15723: pmc gcc fixups.
Jun 11 2018, 4:10 PM

Jun 9 2018

rlibby added inline comments to D15723: pmc gcc fixups.
Jun 9 2018, 10:35 PM
rlibby updated the diff for D15723: pmc gcc fixups.

dim feedback: use CWARNFLAGS.gcc for warning suppression

Jun 9 2018, 10:28 PM
rlibby added inline comments to D15723: pmc gcc fixups.
Jun 9 2018, 9:40 PM
rlibby added inline comments to D15723: pmc gcc fixups.
Jun 9 2018, 8:59 PM
rlibby created D15723: pmc gcc fixups.
Jun 9 2018, 8:49 PM

Nov 1 2017

rlibby accepted D12862: Remove deprecated and unused counters in ENA driver.
Nov 1 2017, 7:51 AM
rlibby added a comment to D12864: Cleanup of the ENA driver header file.

Always nice to have minus diffs, assuming it still compiles :)

Nov 1 2017, 7:31 AM
rlibby added a comment to D12860: Refactor style of the ENA driver.

Most of these changes look to be in the right direction. I don't think evaluating if a bool == true or == false is necessary. In some places parentheses have been added which are not strictly needed, I don't feel strongly about those either way. I did not evaluate for completeness.

Nov 1 2017, 7:23 AM
rlibby accepted D12861: Cover ENA driver code with branch predictioning statements.

My opinion is generally that branch predictions should be sparse. Is it really going to make any difference in setup/teardown functions, which many of the functions edited here appear to be?

Nov 1 2017, 7:01 AM
rlibby accepted D12854: Change function validate_tx_req_id() to inline in ENA driver.
Nov 1 2017, 6:35 AM
rlibby accepted D12866: Fix compilation warnings when building ENA driver with gcc compiler.
Nov 1 2017, 6:33 AM

Oct 22 2017

rlibby updated the diff for D12753: kernel macro cleanliness, first pass.

Review feedback: avoid touching "superfluous" macro parens for now

Oct 22 2017, 11:39 PM
rlibby planned changes to D12753: kernel macro cleanliness, first pass.
Oct 22 2017, 9:54 PM
rlibby added inline comments to D12753: kernel macro cleanliness, first pass.
Oct 22 2017, 7:44 PM
rlibby updated the diff for D12753: kernel macro cleanliness, first pass.

mjoras feedback: parenthesization fixes

Oct 22 2017, 4:09 AM
rlibby added a comment to D12753: kernel macro cleanliness, first pass.

The superfluous parentheses stuff is sort of nitpicky, but I do feel that at least in the case where the expansion is surrounded by commas then it should be dropped since comma operators / separators have the lowest possible precedence.

Oct 22 2017, 4:02 AM

Oct 21 2017

rlibby created D12753: kernel macro cleanliness, first pass.
Oct 21 2017, 10:44 PM
rlibby committed rS324811: pms/freebsd: fix compiler warnings.
pms/freebsd: fix compiler warnings
Oct 21 2017, 7:23 AM
rlibby closed D12683: pms/freebsd: fix compiler warnings.
Oct 21 2017, 7:23 AM

Oct 18 2017

rlibby committed rS324728: ql*_def.h: fix QL_ALIGN parenthesization.
ql*_def.h: fix QL_ALIGN parenthesization
Oct 18 2017, 7:28 PM
rlibby closed D12673: ql*_def.h: fix QL_ALIGN parenthesization.
Oct 18 2017, 7:28 PM
rlibby committed rS324713: ext2: delete redundant decl of ext2_fserr.
ext2: delete redundant decl of ext2_fserr
Oct 18 2017, 12:41 AM
rlibby closed D12709: ext2: delete redundant decl of ext2_fserr.
Oct 18 2017, 12:41 AM

Oct 17 2017

rlibby created D12709: ext2: delete redundant decl of ext2_fserr.
Oct 17 2017, 11:03 PM
rlibby updated the summary of D12673: ql*_def.h: fix QL_ALIGN parenthesization.
Oct 17 2017, 9:01 PM
rlibby committed rS324705: cxgbe: delete now-redundant vnet decls.
cxgbe: delete now-redundant vnet decls
Oct 17 2017, 8:37 PM
rlibby closed D12674: cxgbe: delete now-redundant vnet decls.
Oct 17 2017, 8:37 PM
rlibby updated subscribers of D12683: pms/freebsd: fix compiler warnings.
Oct 17 2017, 7:22 PM
rlibby added a comment to D12683: pms/freebsd: fix compiler warnings.
In D12683#263679, @pfg wrote:

Upstream indeed seems to have disappeared but Benno Rice may know better.

Oct 17 2017, 7:20 PM
rlibby committed rS324680: gdb kernel server: fixup Search:memory style.
gdb kernel server: fixup Search:memory style
Oct 17 2017, 1:12 AM
rlibby closed D12684: gdb kernel server: fixup Search:memory style.
Oct 17 2017, 1:12 AM

Oct 16 2017

rlibby created D12684: gdb kernel server: fixup Search:memory style.
Oct 16 2017, 7:26 AM
rlibby created D12683: pms/freebsd: fix compiler warnings.
Oct 16 2017, 6:34 AM

Oct 14 2017

rlibby committed rS324621: mlx4: use enum constants instead of const vars for case exprs.
mlx4: use enum constants instead of const vars for case exprs
Oct 14 2017, 11:26 PM
rlibby closed D12675: mlx4: use enum constants instead of const vars for case exprs.
Oct 14 2017, 11:26 PM
rlibby added a comment to D12675: mlx4: use enum constants instead of const vars for case exprs.

Just give this patch a spin with clang aswell before committing. I'll handle this issue towards Mellanox.
Thank you!
--HPS

Oct 14 2017, 10:25 PM
rlibby retitled D12675: mlx4: use enum constants instead of const vars for case exprs from mlx4: make case labels ICE to please gcc to mlx4: use enum constants instead of const vars for case exprs.
Oct 14 2017, 10:22 PM
rlibby updated the diff for D12675: mlx4: use enum constants instead of const vars for case exprs.

hselasky feedback: replace const vars with enum constants

Oct 14 2017, 10:11 PM