- User Since
- Nov 12 2015, 8:14 PM (218 w, 1 d)
Yes, that's right. In fact, the smaller mbufs are actually still okay with multipage slabs due to their power-of-2 size, but I thought it was better to make the constraint explicit.
Tue, Jan 14
Mon, Jan 13
markj feedback: style(9)
missed one, and messed one up
markj feedback, don't print threads
Sun, Jan 12
Thu, Jan 9
I only looked at _atomic_subword.h.
Wed, Jan 8
Looks good. Did this fix the bus-sc accounting?
jeff feedback, s/ipers_nohdr/ipers_offpage/ too
forgot jeff feedback s/eff_nohdr/eff_offpage/
jeff & markj feedback
Code looks good.
Mon, Jan 6
@jeff Will do for the rest of the comments. A couple clarifying questions.
Jeff asked that the old code be left in place for posting the diff, for readability of the diff. The #ifdef 0 code will be deleted before commit.
Sat, Jan 4
Latest revision LGTM.
Fri, Jan 3
Mon, Dec 30
This one blames to 1998, so I guess it was legit :)
Wed, Dec 25
Here's what changing it to no-error for the clang build does (amd64):
Tue, Dec 24
Looks good, after fixing up the keg_alloc_slab comment and the keg_dtor printf format.
Looks good but I do have a question about how uma_zone_reserve() is supposed to work now.
Looks good. Recommend building at least INVARIANTS and non-INVARIANTS kernels before commit.
Mon, Dec 23
Fixups look good. I agree with leaving an XXX and coming back later to the problem of transitioning between no-limit and limit.
Generally looking good, but I do have a few more comments.
Sun, Dec 22
Fixups look good.
Fixups look good.
Sat, Dec 21
I can prepare a follow up. What I did here was exactly what we already do for clang. I will change both. And then I assume you'd have the same comment for the user build?
Fri, Dec 20
Ah. Yes. I'll check if that builds. Thanks.
A non-intrusive Makefile solution could be to lower camcontrol's WARNS to 3, either unconditionally or conditional on gcc.
Thu, Dec 19
Dec 19 2019
Dec 17 2019
Dec 16 2019
Looks good, just some nitpicks.
Dec 14 2019
I went ahead and committed this in r355746 along with re-application of D22759.
Dec 13 2019
The problem I was originally trying to solve was allowing embedded slabs on the bucket zones for D22768. This means the slab memory for the bucket zones must come from uma_small_alloc. It can't come from the startup pages because PHYS_TO_VM_PAGE doesn't work on the startup pages since they aren't in the page array (although, we could possibly change that, with some potential other cost, see the vm_page.c bit in D11784). So I added a check at keg creation time that only enables embedded slabs if the keg was created after BOOT_PAGEALLOC. That disabled embedding for bucket zones, which were being created before then.