rlibby (Ryan Libby)
User

Projects

User Details

User Since
Nov 12 2015, 8:14 PM (106 w, 18 h)

Recent Activity

Wed, Nov 1

rlibby accepted D12862: Remove deprecated and unused counters in ENA driver.
Wed, Nov 1, 7:51 AM
rlibby added a comment to D12864: Cleanup of the ENA driver header file.

Always nice to have minus diffs, assuming it still compiles :)

Wed, Nov 1, 7:31 AM
rlibby added a comment to D12860: Refactor style of the ENA driver.

Most of these changes look to be in the right direction. I don't think evaluating if a bool == true or == false is necessary. In some places parentheses have been added which are not strictly needed, I don't feel strongly about those either way. I did not evaluate for completeness.

Wed, Nov 1, 7:23 AM
rlibby accepted D12861: Cover ENA driver code with branch predictioning statements.

My opinion is generally that branch predictions should be sparse. Is it really going to make any difference in setup/teardown functions, which many of the functions edited here appear to be?

Wed, Nov 1, 7:01 AM
rlibby accepted D12854: Change function validate_tx_req_id() to inline in ENA driver.
Wed, Nov 1, 6:35 AM
rlibby accepted D12866: Fix compilation warnings when building ENA driver with gcc compiler.
Wed, Nov 1, 6:33 AM

Oct 22 2017

rlibby updated the diff for D12753: kernel macro cleanliness, first pass.

Review feedback: avoid touching "superfluous" macro parens for now

Oct 22 2017, 11:39 PM
rlibby planned changes to D12753: kernel macro cleanliness, first pass.
Oct 22 2017, 9:54 PM
rlibby added inline comments to D12753: kernel macro cleanliness, first pass.
Oct 22 2017, 7:44 PM
rlibby updated the diff for D12753: kernel macro cleanliness, first pass.

mjoras feedback: parenthesization fixes

Oct 22 2017, 4:09 AM
rlibby added a comment to D12753: kernel macro cleanliness, first pass.

The superfluous parentheses stuff is sort of nitpicky, but I do feel that at least in the case where the expansion is surrounded by commas then it should be dropped since comma operators / separators have the lowest possible precedence.

Oct 22 2017, 4:02 AM

Oct 21 2017

rlibby created D12753: kernel macro cleanliness, first pass.
Oct 21 2017, 10:44 PM
rlibby committed rS324811: pms/freebsd: fix compiler warnings.
pms/freebsd: fix compiler warnings
Oct 21 2017, 7:23 AM
rlibby closed D12683: pms/freebsd: fix compiler warnings.
Oct 21 2017, 7:23 AM

Oct 18 2017

rlibby committed rS324728: ql*_def.h: fix QL_ALIGN parenthesization.
ql*_def.h: fix QL_ALIGN parenthesization
Oct 18 2017, 7:28 PM
rlibby closed D12673: ql*_def.h: fix QL_ALIGN parenthesization.
Oct 18 2017, 7:28 PM
rlibby committed rS324713: ext2: delete redundant decl of ext2_fserr.
ext2: delete redundant decl of ext2_fserr
Oct 18 2017, 12:41 AM
rlibby closed D12709: ext2: delete redundant decl of ext2_fserr.
Oct 18 2017, 12:41 AM

Oct 17 2017

rlibby created D12709: ext2: delete redundant decl of ext2_fserr.
Oct 17 2017, 11:03 PM
rlibby updated the summary of D12673: ql*_def.h: fix QL_ALIGN parenthesization.
Oct 17 2017, 9:01 PM
rlibby committed rS324705: cxgbe: delete now-redundant vnet decls.
cxgbe: delete now-redundant vnet decls
Oct 17 2017, 8:37 PM
rlibby closed D12674: cxgbe: delete now-redundant vnet decls.
Oct 17 2017, 8:37 PM
rlibby updated subscribers of D12683: pms/freebsd: fix compiler warnings.
Oct 17 2017, 7:22 PM
rlibby added a comment to D12683: pms/freebsd: fix compiler warnings.
In D12683#263679, @pfg wrote:

Upstream indeed seems to have disappeared but Benno Rice may know better.

Oct 17 2017, 7:20 PM
rlibby committed rS324680: gdb kernel server: fixup Search:memory style.
gdb kernel server: fixup Search:memory style
Oct 17 2017, 1:12 AM
rlibby closed D12684: gdb kernel server: fixup Search:memory style.
Oct 17 2017, 1:12 AM

Oct 16 2017

rlibby created D12684: gdb kernel server: fixup Search:memory style.
Oct 16 2017, 7:26 AM
rlibby created D12683: pms/freebsd: fix compiler warnings.
Oct 16 2017, 6:34 AM

Oct 14 2017

rlibby committed rS324621: mlx4: use enum constants instead of const vars for case exprs.
mlx4: use enum constants instead of const vars for case exprs
Oct 14 2017, 11:26 PM
rlibby closed D12675: mlx4: use enum constants instead of const vars for case exprs.
Oct 14 2017, 11:26 PM
rlibby added a comment to D12675: mlx4: use enum constants instead of const vars for case exprs.

Just give this patch a spin with clang aswell before committing. I'll handle this issue towards Mellanox.

Thank you!

--HPS

Oct 14 2017, 10:25 PM
rlibby retitled D12675: mlx4: use enum constants instead of const vars for case exprs from mlx4: make case labels ICE to please gcc to mlx4: use enum constants instead of const vars for case exprs.
Oct 14 2017, 10:22 PM
rlibby updated the diff for D12675: mlx4: use enum constants instead of const vars for case exprs.

hselasky feedback: replace const vars with enum constants

Oct 14 2017, 10:11 PM
rlibby added inline comments to D12675: mlx4: use enum constants instead of const vars for case exprs.
Oct 14 2017, 10:05 PM
rlibby added a comment to D12675: mlx4: use enum constants instead of const vars for case exprs.

What is the purpose of this change?

Oct 14 2017, 9:53 PM
rlibby created D12675: mlx4: use enum constants instead of const vars for case exprs.
Oct 14 2017, 8:01 PM
rlibby created D12674: cxgbe: delete now-redundant vnet decls.
Oct 14 2017, 7:54 PM
rlibby created D12673: ql*_def.h: fix QL_ALIGN parenthesization.
Oct 14 2017, 7:52 PM

Sep 26 2017

rlibby added a comment to D12437: opencrypto: Loosen restriction on HMAC key sizes.

Padlock fix-up LGTM.

Sep 26 2017, 4:22 PM
rlibby accepted D12437: opencrypto: Loosen restriction on HMAC key sizes.

The change looks fine to me.

Sep 26 2017, 6:42 AM

Sep 25 2017

rlibby added a comment to D12452: aesni(4): Add support for x86 SHA intrinsics.

Just dropping some nitpicks, I haven't reached a deep enough understanding for a real review yet.

Sep 25 2017, 10:59 PM
rlibby accepted D12451: crypto(9): Use a more specific error code when a capable driver is not found.

The change itself seems fine to me. I'll defer to others with respect to whether this is the right direction and whether the documentation needs to be in this revision.

Sep 25 2017, 9:34 PM

Sep 22 2017

rlibby added inline comments to D12452: aesni(4): Add support for x86 SHA intrinsics.
Sep 22 2017, 4:14 PM

Sep 18 2017

rlibby committed rS323720: MFC r323574:.
MFC r323574:
Sep 18 2017, 8:09 PM
rlibby committed rS323719: MFC r304877,r323573:.
MFC r304877,r323573:
Sep 18 2017, 8:08 PM
rlibby committed rS323718: MFC r323572:.
MFC r323572:
Sep 18 2017, 8:01 PM
rlibby committed rS323714: linsysfs: quiet gcc -Wformat after r323692.
linsysfs: quiet gcc -Wformat after r323692
Sep 18 2017, 7:10 PM

Sep 14 2017

rlibby closed D12284: gcc builds: reenable -Wstrict-overflow.
Sep 14 2017, 3:43 AM
rlibby committed rS323574: gcc builds: reenable -Wstrict-overflow for kern.mk.
gcc builds: reenable -Wstrict-overflow for kern.mk
Sep 14 2017, 3:43 AM
rlibby committed rS323573: gcc builds: reenable -Wstrict-overflow for bsd.sys.mk.
gcc builds: reenable -Wstrict-overflow for bsd.sys.mk
Sep 14 2017, 3:42 AM
rlibby committed rS323572: zic: -Wno-error=strict-overflow.
zic: -Wno-error=strict-overflow
Sep 14 2017, 3:40 AM

Sep 13 2017

rlibby added a comment to D12284: gcc builds: reenable -Wstrict-overflow.

@emaste suggested out of band to verify with a universe build. I did a make tinderbox and it succeeded.

Sep 13 2017, 7:08 PM
rlibby updated the test plan for D12284: gcc builds: reenable -Wstrict-overflow.
Sep 13 2017, 7:06 PM
rlibby committed rS323515: MFC r321483 (by ngie):.
MFC r321483 (by ngie):
Sep 13 2017, 12:52 AM

Sep 12 2017

rlibby committed rS323489: MFC r323192:.
MFC r323192:
Sep 12 2017, 6:34 AM
rlibby committed rS323488: MFC r322940:.
MFC r322940:
Sep 12 2017, 6:32 AM
rlibby committed rS323487: MFC r323155:.
MFC r323155:
Sep 12 2017, 6:27 AM
rlibby committed rS323486: MFC r321284:.
MFC r321284:
Sep 12 2017, 6:24 AM
rlibby committed rS323485: MFC r316119 (by ngie):.
MFC r316119 (by ngie):
Sep 12 2017, 6:21 AM
rlibby committed rS323484: MFC r303723 (by markj):.
MFC r303723 (by markj):
Sep 12 2017, 6:19 AM
rlibby committed rS323475: MFC r323003,r323004:.
MFC r323003,r323004:
Sep 12 2017, 12:27 AM

Sep 11 2017

rlibby closed D12212: bhyve: actually call bhyve_caph_cache_catpages.
Sep 11 2017, 7:25 AM
rlibby committed rS323427: bhyve: actually call bhyve_caph_cache_catpages.
bhyve: actually call bhyve_caph_cache_catpages
Sep 11 2017, 7:25 AM
rlibby committed rS323426: MFC r321669:.
MFC r321669:
Sep 11 2017, 7:23 AM
rlibby committed rS323425: MFC r321668:.
MFC r321668:
Sep 11 2017, 7:21 AM

Sep 9 2017

rlibby added a comment to D12284: gcc builds: reenable -Wstrict-overflow.

It appears to have been in upstream: ftp://ftp.iana.org/tz/code/zic.c (see oadd).

As for when we might sync with upstream next, I have no idea. Last sync appears to have been in 2010.

We could also bring in that fix independently, in advance of a full update.

Sep 9 2017, 6:12 PM
rlibby added a comment to D12284: gcc builds: reenable -Wstrict-overflow.
In D12284#254856, @ngie wrote:

When will zic(8) be fixed?

Sep 9 2017, 7:13 AM
rlibby created D12284: gcc builds: reenable -Wstrict-overflow.
Sep 9 2017, 12:34 AM

Sep 7 2017

rlibby committed rS323276: crunchgen: quiet -Wmissing-prototypes.
crunchgen: quiet -Wmissing-prototypes
Sep 7 2017, 5:21 PM
rlibby closed D12107: crunchgen: quiet -Wmissing-prototypes.
Sep 7 2017, 5:21 PM
rlibby committed rS323256: MFC r322329:.
MFC r322329:
Sep 7 2017, 5:41 AM
rlibby committed rS323255: MFC r321864 (by mw):.
MFC r321864 (by mw):
Sep 7 2017, 5:01 AM

Sep 6 2017

rlibby committed rS323214: MFC r321376:.
MFC r321376:
Sep 6 2017, 7:19 AM
rlibby committed rS323213: MFC r321106:.
MFC r321106:
Sep 6 2017, 7:15 AM
rlibby committed rS323211: MFC r320977:.
MFC r320977:
Sep 6 2017, 7:09 AM
rlibby committed rS323208: MFC r320714:.
MFC r320714:
Sep 6 2017, 6:57 AM
rlibby committed rS323207: MFC r320517:.
MFC r320517:
Sep 6 2017, 6:52 AM
rlibby committed rS323200: Makefile.inc1: bump elf tool chain version check after PR 215350 fix.
Makefile.inc1: bump elf tool chain version check after PR 215350 fix
Sep 6 2017, 1:55 AM
rlibby closed D12239: Makefile.inc1: bump elf tool chain version check after PR 215350 fix.
Sep 6 2017, 1:55 AM
rlibby updated the diff for D12239: Makefile.inc1: bump elf tool chain version check after PR 215350 fix.

bdrewery feedback: restore old comment

Sep 6 2017, 1:21 AM
rlibby created D12239: Makefile.inc1: bump elf tool chain version check after PR 215350 fix.
Sep 6 2017, 1:10 AM

Sep 5 2017

rlibby committed rS323192: gnu binutils: FSGSBASE assembly/disassembly.
gnu binutils: FSGSBASE assembly/disassembly
Sep 5 2017, 7:04 PM
rlibby closed D12222: gnu binutils: FSGSBASE assembly/disassembly.
Sep 5 2017, 7:04 PM
rlibby committed rS323186: MFC r316397 (by bde):.
MFC r316397 (by bde):
Sep 5 2017, 3:21 PM

Sep 4 2017

rlibby committed rS323164: MFC r303188,r303190,r303271,r303438,r303453: Warn flags for gcc 6.1.
MFC r303188,r303190,r303271,r303438,r303453: Warn flags for gcc 6.1
Sep 4 2017, 9:58 PM
rlibby committed rS323155: libefivar: -fno-strict-aliasing.
libefivar: -fno-strict-aliasing
Sep 4 2017, 7:00 PM
rlibby closed D12219: libefivar: -fno-strict-aliasing.
Sep 4 2017, 7:00 PM
rlibby updated the diff for D12222: gnu binutils: FSGSBASE assembly/disassembly.

Typo, s/modrm.rm/modrm.reg/

Sep 4 2017, 2:17 AM

Sep 3 2017

rlibby created D12222: gnu binutils: FSGSBASE assembly/disassembly.
Sep 3 2017, 11:09 PM
rlibby created D12219: libefivar: -fno-strict-aliasing.
Sep 3 2017, 5:11 AM
rlibby abandoned D12210: libefivar: avoid type punning in Strtoi64.
Sep 3 2017, 4:38 AM
rlibby abandoned D12211: libefivar: avoid type-punning in DevPathFromTextFibreEx.
Sep 3 2017, 4:38 AM
rlibby added a comment to D12211: libefivar: avoid type-punning in DevPathFromTextFibreEx.

So, @imp, what's your preference in terms of direction here?

Sep 3 2017, 2:43 AM

Sep 2 2017

rlibby added a comment to D12211: libefivar: avoid type-punning in DevPathFromTextFibreEx.

I can check if just -fno-strict-aliasing quiets the warnings.

Sep 2 2017, 1:45 AM
rlibby added a comment to D12211: libefivar: avoid type-punning in DevPathFromTextFibreEx.
In D12211#253285, @imp wrote:
In D12211#253281, @imp wrote:

This is upstream code.
The warning should be disabled instead.

Whoops, didn't realize. I see lib/libefivar/FreeBSD-update now. So, am I reading it right then to understand that efivar-dp-parse.c is from an upstream, but uefi-dplib.h (modified in D12210) is just in FreeBSD?

I'll check if there's anything else to be done with the flags when building this.

That's correct. I'd like to understand why your version works, since I seem to recall needing the cast to make it work due to some instances of y being char * or some other pointer and your proposed fixed may just silently break things.

Sep 2 2017, 12:41 AM
rlibby added a comment to D12211: libefivar: avoid type-punning in DevPathFromTextFibreEx.
In D12211#253281, @imp wrote:

This is upstream code.
The warning should be disabled instead.

Sep 2 2017, 12:21 AM

Sep 1 2017

rlibby created D12212: bhyve: actually call bhyve_caph_cache_catpages.
Sep 1 2017, 11:44 PM
rlibby created D12211: libefivar: avoid type-punning in DevPathFromTextFibreEx.
Sep 1 2017, 11:22 PM
rlibby created D12210: libefivar: avoid type punning in Strtoi64.
Sep 1 2017, 11:20 PM

Aug 30 2017

rlibby added a comment to D12143: Update ena-com HAL to newest version and update driver accordingly.

By the way the files in this review still have the wrong mode bits (100755 instead of 100644, need chmod a-x).

Aug 30 2017, 5:21 PM