Page MenuHomeFreeBSD

rlibby (Ryan Libby)
User

Projects

User Details

User Since
Nov 12 2015, 8:14 PM (469 w, 4 d)

Recent Activity

Aug 14 2024

rlibby added a comment to D46289: ttm_bo_vm: avoid lookup before insert.

I'm okay with the idea but I'm a little worried that it changes the semantics of vm_page_insert / vm_page_insert_after, which I just preserved with the insert_lookup patch. Those two procedures have several callers. However, several of the callers appear to be broken (lacking error checks), so maybe we should audit them all anyway.

Aug 14 2024, 7:01 AM

Jul 20 2024

rlibby committed rG90818083d795: ipf: correct size limit in snprintf (authored by rlibby).
ipf: correct size limit in snprintf
Jul 20 2024, 4:15 PM
rlibby closed D45899: ipf: correct size limit in snprintf.
Jul 20 2024, 4:15 PM

Jul 19 2024

rlibby added a comment to D46041: kyua: fix gcc13 builds.

After some experiments, I think that [[noreturn]] is not a solution that either clang or g++ will accept.

Jul 19 2024, 11:01 PM
rlibby added a comment to D46014: fwcontrol: Allocate full fw_asyreq structures passed to the kernel.
In D46014#1049503, @jhb wrote:

Also, I think this kind of pattern is behind many of our -Warray-bounds
violations too, where we allocate a part of a structure and then rely on
code referring to only those parts. Especially in areas like cam. This
one is a little different in that we apparently also actually access
beyond the short allocation.

Well, some of those are due to using [0] arrays instead of the more modern syntax for variable length arrays.

Jul 19 2024, 4:02 PM

Jul 17 2024

rlibby accepted D46005: libcasper: Consistently use item count as the first argument to calloc.
Jul 17 2024, 8:29 PM
rlibby accepted D46007: elftoolchain: Consistently use item count as the first argument to calloc.

Hmm, I've been avoiding addressing warnings in contrib...

Jul 17 2024, 8:28 PM
rlibby accepted D46013: ctld: Consistently use item count as the first argument to calloc.
Jul 17 2024, 8:25 PM
rlibby accepted D46012: bsdinstall: Consistently use item count as the first argument to calloc.
Jul 17 2024, 8:24 PM
rlibby added a comment to D46014: fwcontrol: Allocate full fw_asyreq structures passed to the kernel.

I guess you can also consider if you want to make the malloc spelling more conventional. Don't need the casts, and can now do sizeof(*asyreq). I'm ambivalent, but in case you hadn't considered it.

Jul 17 2024, 8:23 PM
rlibby accepted D46014: fwcontrol: Allocate full fw_asyreq structures passed to the kernel.

I don't know this code but I'm assuming that we don't really care about
the overhead here or performance generally for this ioctl. In other
words, we don't need a longer term fix to do a saner amount of copying,
correct? It seems that we never actually use asyreq->data in the ioctl,
so we're now allocating and passing around an extra 2k because of a
weird definition?

Jul 17 2024, 8:19 PM
rlibby accepted D46011: ministat: Consistently use item count as the first argument to calloc.
Jul 17 2024, 7:55 PM
rlibby accepted D46010: recoverdisk: Consistently use item count as the first argument to calloc.
Jul 17 2024, 7:54 PM
rlibby accepted D46009: md5: Consistently use item count as the first argument to calloc.
Jul 17 2024, 7:54 PM
rlibby accepted D46008: lib80211: Consistently use item count as the first argument to calloc.
Jul 17 2024, 7:54 PM
rlibby accepted D46006: libgeom: Consistently use item count as the first argument to calloc.
Jul 17 2024, 7:54 PM

Jul 14 2024

rlibby updated subscribers of D45627: pctrie: create iterator.

I haven't looked at swap_pager.c yet. I'll get back to that hopefully tonight.

Jul 14 2024, 9:26 PM

Jul 9 2024

rlibby committed rG430be7e1ee71: sx: avoid gcc -Wunused-value (authored by rlibby).
sx: avoid gcc -Wunused-value
Jul 9 2024, 6:46 PM
rlibby committed rG6bd85498ec2d: bthidd: declare appropriate size bitstring (authored by rlibby).
bthidd: declare appropriate size bitstring
Jul 9 2024, 6:46 PM
rlibby committed rGf0a7df4a6cc9: ddb: make db_error reliably no-return (authored by rlibby).
ddb: make db_error reliably no-return
Jul 9 2024, 6:46 PM
rlibby committed rGff1c63671b73: kdb_sysctl_trap: suppress gcc -Warray-bounds (authored by rlibby).
kdb_sysctl_trap: suppress gcc -Warray-bounds
Jul 9 2024, 6:46 PM
rlibby closed D45875: sx: avoid gcc -Wunused-value.
Jul 9 2024, 6:46 PM
rlibby committed rG2207aaba8977: kern_exec.c: quiet gcc -Wmaybe-uninitialized (authored by rlibby).
kern_exec.c: quiet gcc -Wmaybe-uninitialized
Jul 9 2024, 6:46 PM
rlibby closed D45900: bthidd: declare appropriate size bitstring.
Jul 9 2024, 6:46 PM
rlibby closed D45918: ddb: make db_error reliably no-return.
Jul 9 2024, 6:46 PM
rlibby closed D45917: kdb_sysctl_trap: suppress gcc -Warray-bounds.
Jul 9 2024, 6:46 PM
rlibby closed D45916: kern_exec.c: quiet gcc -Wmaybe-uninitialized.
Jul 9 2024, 6:46 PM
rlibby added a comment to D45875: sx: avoid gcc -Wunused-value.

Any more input on this one?

Jul 9 2024, 5:54 PM

Jul 8 2024

rlibby updated the diff for D45917: kdb_sysctl_trap: suppress gcc -Warray-bounds.

kib: style fixup

Jul 8 2024, 8:34 PM
rlibby added inline comments to D45917: kdb_sysctl_trap: suppress gcc -Warray-bounds.
Jul 8 2024, 7:56 PM
rlibby added a comment to D45918: ddb: make db_error reliably no-return.
In D45918#1046830, @kib wrote:

It seems that db_error() is the only caller of kdb_reenter_silent(). And then it might be better to panic in kdb_reenter_silent() instead, I am not sure. [To make kdb_reenter_silent() more strict]

Jul 8 2024, 7:49 PM
rlibby added a comment to D45891: rtld: actually resolve memcpy plt.

No sure how much the builtins optimization matters here but if it does the other workaround would be:

void* memcpy_for_plt(void*, const void*, size_t) asm("memcpy")

And then call that.

Jul 8 2024, 5:58 PM
rlibby updated the summary of D45919: mv88e151x: fix potential attach and autonegotiation issues.
Jul 8 2024, 4:07 PM
rlibby added a reviewer for D45918: ddb: make db_error reliably no-return: rgrimes.
Jul 8 2024, 4:05 PM
rlibby requested review of D45919: mv88e151x: fix potential attach and autonegotiation issues.
Jul 8 2024, 4:04 PM
rlibby requested review of D45918: ddb: make db_error reliably no-return.
Jul 8 2024, 3:59 PM
rlibby requested review of D45917: kdb_sysctl_trap: suppress gcc -Warray-bounds.
Jul 8 2024, 3:58 PM
rlibby requested review of D45916: kern_exec.c: quiet gcc -Wmaybe-uninitialized.
Jul 8 2024, 3:57 PM

Jul 7 2024

rlibby committed rG39bda097c037: pci: propagate vpd read error (authored by rlibby).
pci: propagate vpd read error
Jul 7 2024, 11:48 PM
rlibby committed rGf7f9a033f3ec: rtld: quiet gcc -Wrestrict (authored by rlibby).
rtld: quiet gcc -Wrestrict
Jul 7 2024, 11:48 PM
rlibby committed rG39733922edc4: rtld: actually resolve memcpy plt (authored by rlibby).
rtld: actually resolve memcpy plt
Jul 7 2024, 11:48 PM
rlibby closed D45895: pci: propagate vpd read error.
Jul 7 2024, 11:47 PM
rlibby closed D45892: rtld: quiet gcc -Wrestrict.
Jul 7 2024, 11:47 PM
rlibby closed D45891: rtld: actually resolve memcpy plt.
Jul 7 2024, 11:47 PM

Jul 6 2024

rlibby requested review of D45900: bthidd: declare appropriate size bitstring.
Jul 6 2024, 5:11 PM
rlibby requested review of D45899: ipf: correct size limit in snprintf.
Jul 6 2024, 5:00 PM
rlibby updated the diff for D45891: rtld: actually resolve memcpy plt.

kib: comment the cflag

Jul 6 2024, 4:54 AM
rlibby requested review of D45895: pci: propagate vpd read error.
Jul 6 2024, 1:19 AM
rlibby updated the diff for D45891: rtld: actually resolve memcpy plt.

kib: just disable all builtins

Jul 6 2024, 1:10 AM
rlibby added a comment to D45891: rtld: actually resolve memcpy plt.
In D45891#1046235, @kib wrote:

Should we disable all built-ins for the file, for the same reasoning?

Jul 6 2024, 1:07 AM

Jul 5 2024

rlibby requested review of D45893: bitstring_test: fix bit_nclear/bit_nset tests for last iteration.
Jul 5 2024, 10:25 PM
rlibby requested review of D45892: rtld: quiet gcc -Wrestrict.
Jul 5 2024, 10:23 PM
rlibby requested review of D45891: rtld: actually resolve memcpy plt.
Jul 5 2024, 10:22 PM
rlibby added a comment to D45875: sx: avoid gcc -Wunused-value.

Yeah, we should use the value from sx_try_lock, and we'd like to enforce that it's checked too I guess.

Jul 5 2024, 4:55 AM
rlibby updated the diff for D45875: sx: avoid gcc -Wunused-value.

imp: sx_xlock too

Jul 5 2024, 4:24 AM
rlibby added a comment to D45875: sx: avoid gcc -Wunused-value.
In D45875#1045918, @imp wrote:

Why didn't sx_lock() complain?

Jul 5 2024, 3:59 AM
rlibby requested review of D45875: sx: avoid gcc -Wunused-value.
Jul 5 2024, 2:08 AM

Jul 3 2024

rlibby committed rG07d359787f0d: libthr: avoid gcc -Wcast-function-type (authored by rlibby).
libthr: avoid gcc -Wcast-function-type
Jul 3 2024, 4:16 PM
rlibby closed D45830: libthr: avoid gcc -Wcast-function-type.
Jul 3 2024, 4:15 PM
rlibby committed rG7b1c770341fe: libthr _get_curthread i386: quiet gcc -Warray-bounds (authored by rlibby).
libthr _get_curthread i386: quiet gcc -Warray-bounds
Jul 3 2024, 4:15 PM
rlibby closed D45829: libthr _get_curthread i386: quiet gcc -Warray-bounds.
Jul 3 2024, 4:15 PM
rlibby committed rG657b1276ad4c: libthr _get_curthread amd64: quiet gcc -Warray-bounds (authored by rlibby).
libthr _get_curthread amd64: quiet gcc -Warray-bounds
Jul 3 2024, 4:15 PM
rlibby closed D45828: libthr _get_curthread amd64: quiet gcc -Warray-bounds.
Jul 3 2024, 4:15 PM
rlibby committed rG2730f4291411: amd64 pcpu: fix clobbers, suppress warnings, and clean up (authored by rlibby).
amd64 pcpu: fix clobbers, suppress warnings, and clean up
Jul 3 2024, 4:15 PM
rlibby closed D45827: amd64 pcpu: fix clobbers, suppress warnings, and clean up.
Jul 3 2024, 4:15 PM
rlibby committed rGab92c99aa56f: i386 pcpu: fix clobbers, suppress warnings, and clean up (authored by rlibby).
i386 pcpu: fix clobbers, suppress warnings, and clean up
Jul 3 2024, 4:15 PM
rlibby closed D45826: i386 pcpu: fix clobbers, suppress warnings, and clean up.
Jul 3 2024, 4:15 PM

Jul 2 2024

rlibby added a comment to D45826: i386 pcpu: fix clobbers, suppress warnings, and clean up.
In D45826#1045245, @kib wrote:

By the way, I thought about also making these strict-aliasing safe with a union. It's straightforward and also gets rid of the casts. However, since we explicitly build with -fno-strict-aliasing, there's not much motivation. But in case you'd prefer that, I can tweak these patches.

Why would a special treat for aliasing needed? There is the "memory" clobber.

Jul 2 2024, 11:36 PM
rlibby committed rG3cfcbbfaf83a: cdefs.h __generic: avoid gcc -Wunused-value (authored by rlibby).
cdefs.h __generic: avoid gcc -Wunused-value
Jul 2 2024, 7:15 PM
rlibby committed rG19008cdf7bef: gsb_crc32.c: avoid gcc -Wunused-const-variable in user build (authored by rlibby).
gsb_crc32.c: avoid gcc -Wunused-const-variable in user build
Jul 2 2024, 7:15 PM
rlibby closed D45825: cdefs.h __generic: avoid gcc -Wunused-value.
Jul 2 2024, 7:15 PM
rlibby closed D45824: gsb_crc32.c: avoid gcc -Wunused-const-variable in user build.
Jul 2 2024, 7:15 PM
rlibby added a comment to D45826: i386 pcpu: fix clobbers, suppress warnings, and clean up.

By the way, I thought about also making these strict-aliasing safe with a union. It's straightforward and also gets rid of the casts. However, since we explicitly build with -fno-strict-aliasing, there's not much motivation. But in case you'd prefer that, I can tweak these patches.

Jul 2 2024, 4:10 AM

Jul 1 2024

rlibby attached a referenced file: F87317146: pcpu.h.i386-amd64.diff.
Jul 1 2024, 8:06 PM
rlibby attached a referenced file: F87316204: pcpu_demo.before-after.diff.
Jul 1 2024, 8:06 PM
rlibby attached a referenced file: F87316157: pcpu_demo.after-all.disas.
Jul 1 2024, 8:06 PM
rlibby attached a referenced file: F87316134: pcpu_demo.before-all.disas.
Jul 1 2024, 8:05 PM
rlibby attached a referenced file: F87316088: 0001-XXX-pcpu-demo-functions.patch.
Jul 1 2024, 8:05 PM
rlibby added a comment to D45825: cdefs.h __generic: avoid gcc -Wunused-value.
In D45825#1044906, @imp wrote:

Ok. So non c11 env?

Jul 1 2024, 6:50 PM
rlibby added a comment to D45825: cdefs.h __generic: avoid gcc -Wunused-value.
In D45825#1044894, @imp wrote:

Seems fine... what compilers / build env hits this?

Jul 1 2024, 5:26 PM
rlibby added a comment to D45827: amd64 pcpu: fix clobbers, suppress warnings, and clean up.

diff -u1000 sys/{i386,amd64}/include/pcpu.h for comparison to D45826. Ignore the #if 0 for testing.

Jul 1 2024, 5:09 PM
rlibby added a comment to D45826: i386 pcpu: fix clobbers, suppress warnings, and clean up.

Test patch used to examine codegen:

Jul 1 2024, 5:01 PM
rlibby added a reviewer for D45825: cdefs.h __generic: avoid gcc -Wunused-value: jrtc27.
Jul 1 2024, 4:51 PM
rlibby requested review of D45830: libthr: avoid gcc -Wcast-function-type.
Jul 1 2024, 4:49 PM
rlibby requested review of D45829: libthr _get_curthread i386: quiet gcc -Warray-bounds.
Jul 1 2024, 4:49 PM
rlibby requested review of D45828: libthr _get_curthread amd64: quiet gcc -Warray-bounds.
Jul 1 2024, 4:49 PM
rlibby requested review of D45827: amd64 pcpu: fix clobbers, suppress warnings, and clean up.
Jul 1 2024, 4:48 PM
rlibby requested review of D45826: i386 pcpu: fix clobbers, suppress warnings, and clean up.
Jul 1 2024, 4:48 PM
rlibby requested review of D45825: cdefs.h __generic: avoid gcc -Wunused-value.
Jul 1 2024, 4:48 PM
rlibby requested review of D45824: gsb_crc32.c: avoid gcc -Wunused-const-variable in user build.
Jul 1 2024, 4:47 PM
rlibby closed D45707: bluetooth socket sysinit: correct memset initialization.
Jul 1 2024, 3:25 PM
rlibby committed rGf8a46de2dd48: bluetooth socket sysinit: correct memset initialization (authored by rlibby).
bluetooth socket sysinit: correct memset initialization
Jul 1 2024, 3:25 PM

Jun 28 2024

rlibby added a comment to D45707: bluetooth socket sysinit: correct memset initialization.

Filed https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280039

Jun 28 2024, 5:05 PM
rlibby committed rG0d8da0df4150: tcp_rack: avoid gcc -Werror=pointer-to-int-cast on 32-bit arch (authored by rlibby).
tcp_rack: avoid gcc -Werror=pointer-to-int-cast on 32-bit arch
Jun 28 2024, 3:41 AM
rlibby committed rGc02a8caf50bb: tcp_bbr: avoid gcc -Werror=pointer-to-int-cast on 32-bit arch (authored by rlibby).
tcp_bbr: avoid gcc -Werror=pointer-to-int-cast on 32-bit arch
Jun 28 2024, 3:41 AM
rlibby closed D45752: tcp_rack: avoid gcc -Werror=pointer-to-int-cast on 32-bit arch.
Jun 28 2024, 3:41 AM
rlibby closed D45751: tcp_bbr: avoid gcc -Werror=pointer-to-int-cast on 32-bit arch.
Jun 28 2024, 3:41 AM

Jun 27 2024

rlibby committed rGb195d7498b91: nvme: avoid gcc -Werror=int-to-pointer-cast on 32-bit arch (authored by rlibby).
nvme: avoid gcc -Werror=int-to-pointer-cast on 32-bit arch
Jun 27 2024, 3:51 AM
rlibby closed D45750: nvme: avoid gcc -Werror=int-to-pointer-cast on 32-bit arch.
Jun 27 2024, 3:51 AM
rlibby accepted D45588: vm_object: use reclaim callback to free pages.
Jun 27 2024, 3:36 AM