rlibby (Ryan Libby)
User

Projects

User Details

User Since
Nov 12 2015, 8:14 PM (97 w, 3 d)

Recent Activity

Fri, Sep 22

rlibby added inline comments to D12452: aesni(4): Add support for x86 SHA intrinsics.
Fri, Sep 22, 4:14 PM

Mon, Sep 18

rlibby committed rS323720: MFC r323574:.
MFC r323574:
Mon, Sep 18, 8:09 PM
rlibby committed rS323719: MFC r304877,r323573:.
MFC r304877,r323573:
Mon, Sep 18, 8:08 PM
rlibby committed rS323718: MFC r323572:.
MFC r323572:
Mon, Sep 18, 8:01 PM
rlibby committed rS323714: linsysfs: quiet gcc -Wformat after r323692.
linsysfs: quiet gcc -Wformat after r323692
Mon, Sep 18, 7:10 PM

Thu, Sep 14

rlibby closed D12284: gcc builds: reenable -Wstrict-overflow.
Thu, Sep 14, 3:43 AM
rlibby committed rS323574: gcc builds: reenable -Wstrict-overflow for kern.mk.
gcc builds: reenable -Wstrict-overflow for kern.mk
Thu, Sep 14, 3:43 AM
rlibby committed rS323573: gcc builds: reenable -Wstrict-overflow for bsd.sys.mk.
gcc builds: reenable -Wstrict-overflow for bsd.sys.mk
Thu, Sep 14, 3:42 AM
rlibby committed rS323572: zic: -Wno-error=strict-overflow.
zic: -Wno-error=strict-overflow
Thu, Sep 14, 3:40 AM

Wed, Sep 13

rlibby added a comment to D12284: gcc builds: reenable -Wstrict-overflow.

@emaste suggested out of band to verify with a universe build. I did a make tinderbox and it succeeded.

Wed, Sep 13, 7:08 PM
rlibby updated the test plan for D12284: gcc builds: reenable -Wstrict-overflow.
Wed, Sep 13, 7:06 PM
rlibby committed rS323515: MFC r321483 (by ngie):.
MFC r321483 (by ngie):
Wed, Sep 13, 12:52 AM

Tue, Sep 12

rlibby committed rS323489: MFC r323192:.
MFC r323192:
Tue, Sep 12, 6:34 AM
rlibby committed rS323488: MFC r322940:.
MFC r322940:
Tue, Sep 12, 6:32 AM
rlibby committed rS323487: MFC r323155:.
MFC r323155:
Tue, Sep 12, 6:27 AM
rlibby committed rS323486: MFC r321284:.
MFC r321284:
Tue, Sep 12, 6:24 AM
rlibby committed rS323485: MFC r316119 (by ngie):.
MFC r316119 (by ngie):
Tue, Sep 12, 6:21 AM
rlibby committed rS323484: MFC r303723 (by markj):.
MFC r303723 (by markj):
Tue, Sep 12, 6:19 AM
rlibby committed rS323475: MFC r323003,r323004:.
MFC r323003,r323004:
Tue, Sep 12, 12:27 AM

Mon, Sep 11

rlibby closed D12212: bhyve: actually call bhyve_caph_cache_catpages.
Mon, Sep 11, 7:25 AM
rlibby committed rS323427: bhyve: actually call bhyve_caph_cache_catpages.
bhyve: actually call bhyve_caph_cache_catpages
Mon, Sep 11, 7:25 AM
rlibby committed rS323426: MFC r321669:.
MFC r321669:
Mon, Sep 11, 7:23 AM
rlibby committed rS323425: MFC r321668:.
MFC r321668:
Mon, Sep 11, 7:21 AM

Sat, Sep 9

rlibby added a comment to D12284: gcc builds: reenable -Wstrict-overflow.

It appears to have been in upstream: ftp://ftp.iana.org/tz/code/zic.c (see oadd).

As for when we might sync with upstream next, I have no idea. Last sync appears to have been in 2010.

We could also bring in that fix independently, in advance of a full update.

Sat, Sep 9, 6:12 PM
rlibby added a comment to D12284: gcc builds: reenable -Wstrict-overflow.
In D12284#254856, @ngie wrote:

When will zic(8) be fixed?

Sat, Sep 9, 7:13 AM
rlibby created D12284: gcc builds: reenable -Wstrict-overflow.
Sat, Sep 9, 12:34 AM

Thu, Sep 7

rlibby committed rS323276: crunchgen: quiet -Wmissing-prototypes.
crunchgen: quiet -Wmissing-prototypes
Thu, Sep 7, 5:21 PM
rlibby closed D12107: crunchgen: quiet -Wmissing-prototypes.
Thu, Sep 7, 5:21 PM
rlibby committed rS323256: MFC r322329:.
MFC r322329:
Thu, Sep 7, 5:41 AM
rlibby committed rS323255: MFC r321864 (by mw):.
MFC r321864 (by mw):
Thu, Sep 7, 5:01 AM

Wed, Sep 6

rlibby committed rS323214: MFC r321376:.
MFC r321376:
Wed, Sep 6, 7:19 AM
rlibby committed rS323213: MFC r321106:.
MFC r321106:
Wed, Sep 6, 7:15 AM
rlibby committed rS323211: MFC r320977:.
MFC r320977:
Wed, Sep 6, 7:09 AM
rlibby committed rS323208: MFC r320714:.
MFC r320714:
Wed, Sep 6, 6:57 AM
rlibby committed rS323207: MFC r320517:.
MFC r320517:
Wed, Sep 6, 6:52 AM
rlibby committed rS323200: Makefile.inc1: bump elf tool chain version check after PR 215350 fix.
Makefile.inc1: bump elf tool chain version check after PR 215350 fix
Wed, Sep 6, 1:55 AM
rlibby closed D12239: Makefile.inc1: bump elf tool chain version check after PR 215350 fix.
Wed, Sep 6, 1:55 AM
rlibby updated the diff for D12239: Makefile.inc1: bump elf tool chain version check after PR 215350 fix.

bdrewery feedback: restore old comment

Wed, Sep 6, 1:21 AM
rlibby created D12239: Makefile.inc1: bump elf tool chain version check after PR 215350 fix.
Wed, Sep 6, 1:10 AM

Tue, Sep 5

rlibby committed rS323192: gnu binutils: FSGSBASE assembly/disassembly.
gnu binutils: FSGSBASE assembly/disassembly
Tue, Sep 5, 7:04 PM
rlibby closed D12222: gnu binutils: FSGSBASE assembly/disassembly.
Tue, Sep 5, 7:04 PM
rlibby committed rS323186: MFC r316397 (by bde):.
MFC r316397 (by bde):
Tue, Sep 5, 3:21 PM

Mon, Sep 4

rlibby committed rS323164: MFC r303188,r303190,r303271,r303438,r303453: Warn flags for gcc 6.1.
MFC r303188,r303190,r303271,r303438,r303453: Warn flags for gcc 6.1
Mon, Sep 4, 9:58 PM
rlibby committed rS323155: libefivar: -fno-strict-aliasing.
libefivar: -fno-strict-aliasing
Mon, Sep 4, 7:00 PM
rlibby closed D12219: libefivar: -fno-strict-aliasing.
Mon, Sep 4, 7:00 PM
rlibby updated the diff for D12222: gnu binutils: FSGSBASE assembly/disassembly.

Typo, s/modrm.rm/modrm.reg/

Mon, Sep 4, 2:17 AM

Sun, Sep 3

rlibby created D12222: gnu binutils: FSGSBASE assembly/disassembly.
Sun, Sep 3, 11:09 PM
rlibby created D12219: libefivar: -fno-strict-aliasing.
Sun, Sep 3, 5:11 AM
rlibby abandoned D12210: libefivar: avoid type punning in Strtoi64.
Sun, Sep 3, 4:38 AM
rlibby abandoned D12211: libefivar: avoid type-punning in DevPathFromTextFibreEx.
Sun, Sep 3, 4:38 AM
rlibby added a comment to D12211: libefivar: avoid type-punning in DevPathFromTextFibreEx.

So, @imp, what's your preference in terms of direction here?

Sun, Sep 3, 2:43 AM

Sat, Sep 2

rlibby added a comment to D12211: libefivar: avoid type-punning in DevPathFromTextFibreEx.

I can check if just -fno-strict-aliasing quiets the warnings.

Sat, Sep 2, 1:45 AM
rlibby added a comment to D12211: libefivar: avoid type-punning in DevPathFromTextFibreEx.
In D12211#253285, @imp wrote:
In D12211#253281, @imp wrote:

This is upstream code.
The warning should be disabled instead.

Whoops, didn't realize. I see lib/libefivar/FreeBSD-update now. So, am I reading it right then to understand that efivar-dp-parse.c is from an upstream, but uefi-dplib.h (modified in D12210) is just in FreeBSD?

I'll check if there's anything else to be done with the flags when building this.

That's correct. I'd like to understand why your version works, since I seem to recall needing the cast to make it work due to some instances of y being char * or some other pointer and your proposed fixed may just silently break things.

Sat, Sep 2, 12:41 AM
rlibby added a comment to D12211: libefivar: avoid type-punning in DevPathFromTextFibreEx.
In D12211#253281, @imp wrote:

This is upstream code.
The warning should be disabled instead.

Sat, Sep 2, 12:21 AM

Fri, Sep 1

rlibby created D12212: bhyve: actually call bhyve_caph_cache_catpages.
Fri, Sep 1, 11:44 PM
rlibby created D12211: libefivar: avoid type-punning in DevPathFromTextFibreEx.
Fri, Sep 1, 11:22 PM
rlibby created D12210: libefivar: avoid type punning in Strtoi64.
Fri, Sep 1, 11:20 PM

Wed, Aug 30

rlibby added a comment to D12143: Update ena-com HAL to newest version and update driver accordingly.

By the way the files in this review still have the wrong mode bits (100755 instead of 100644, need chmod a-x).

Wed, Aug 30, 5:21 PM
rlibby added inline comments to D12143: Update ena-com HAL to newest version and update driver accordingly.
Wed, Aug 30, 9:05 AM

Tue, Aug 29

rlibby committed rS323004: lib/msun: add more csqrt unit tests for precision and overflow.
lib/msun: add more csqrt unit tests for precision and overflow
Tue, Aug 29, 10:37 PM
rlibby committed rS323003: lib/msun: avoid referring to broken LDBL_MAX.
lib/msun: avoid referring to broken LDBL_MAX
Tue, Aug 29, 10:32 PM
rlibby added inline comments to D12143: Update ena-com HAL to newest version and update driver accordingly.
Tue, Aug 29, 4:49 PM

Mon, Aug 28

rlibby added a comment to D12143: Update ena-com HAL to newest version and update driver accordingly.

I'm not familiar enough with this code to give it a proper review, but I suppose I am on the list for gcc compatibility? I checked and a GENERIC kernel does build with this patch applied to head r322969 and

Mon, Aug 28, 5:26 PM

Sat, Aug 26

rlibby updated the diff for D12107: crunchgen: quiet -Wmissing-prototypes.

Keep generated stub on one line.

Sat, Aug 26, 11:24 PM
rlibby added inline comments to D12107: crunchgen: quiet -Wmissing-prototypes.
Sat, Aug 26, 11:21 PM
rlibby committed rS322940: amd64: drop q suffix from rd[fg]sbase for gas compatibility.
amd64: drop q suffix from rd[fg]sbase for gas compatibility
Sat, Aug 26, 11:13 PM
rlibby closed D12133: amd64: drop q suffix from rd[fg]sbase for gas compatibility by committing rS322940: amd64: drop q suffix from rd[fg]sbase for gas compatibility.
Sat, Aug 26, 11:13 PM
rlibby created D12133: amd64: drop q suffix from rd[fg]sbase for gas compatibility.
Sat, Aug 26, 8:58 PM

Aug 23 2017

rlibby created D12107: crunchgen: quiet -Wmissing-prototypes.
Aug 23 2017, 7:54 AM

Aug 18 2017

rlibby committed rS322650: safe: quiet -Wtautological-compare.
safe: quiet -Wtautological-compare
Aug 18 2017, 8:05 AM

Aug 16 2017

rlibby committed rS322600: aesni: quiet -Wcast-qual.
aesni: quiet -Wcast-qual
Aug 16 2017, 10:54 PM
rlibby closed D12021: aesni: quiet -Wcast-qual by committing rS322600: aesni: quiet -Wcast-qual.
Aug 16 2017, 10:54 PM

Aug 15 2017

rlibby added a reviewer for D12021: aesni: quiet -Wcast-qual: delphij.
Aug 15 2017, 7:58 PM

Aug 14 2017

rlibby added inline comments to D12020: LibAliasSetMode error was not detected correctly.
Aug 14 2017, 7:58 PM
rlibby added inline comments to D12020: LibAliasSetMode error was not detected correctly.
Aug 14 2017, 7:03 PM
rlibby added inline comments to D12020: LibAliasSetMode error was not detected correctly.
Aug 14 2017, 6:44 PM
rlibby updated the diff for D12020: LibAliasSetMode error was not detected correctly.

LibAliasSetMode: mav feedback, indicate error via return flags

Aug 14 2017, 6:08 PM
rlibby added a comment to D12020: LibAliasSetMode error was not detected correctly.
In D12020#249291, @mav wrote:

I have another idea. Since this function returns resulted flags, it may be possible to make it return as disabled function which has failed to enable. In such case it would both stay compatible with old code and fixed the compilation errors like that, but slightly complicated check for enable error (if somebody really want it).

Aug 14 2017, 5:43 PM
rlibby added a comment to D12020: LibAliasSetMode error was not detected correctly.

Hmm. This procedure is exported in userspace libalias, is it okay to change its signature like that? Would you want the flags and mask arguments also changed from unsigned int to int for consistency?

Aug 14 2017, 4:28 PM
rlibby created D12022: ar9300_xmit.c: quiet -Wtautological-compare.
Aug 14 2017, 11:10 AM
rlibby created D12021: aesni: quiet -Wcast-qual.
Aug 14 2017, 10:59 AM
rlibby created D12020: LibAliasSetMode error was not detected correctly.
Aug 14 2017, 10:54 AM

Aug 12 2017

rlibby committed rS322435: Revert r322418, LDBL_MAX_EXP unsuitable for macro pasting on some arches.
Revert r322418, LDBL_MAX_EXP unsuitable for macro pasting on some arches
Aug 12 2017, 6:28 PM

Aug 11 2017

rlibby committed rS322418: lib/msun: avoid referring to broken LDBL_MAX.
lib/msun: avoid referring to broken LDBL_MAX
Aug 11 2017, 10:41 PM
rlibby committed rS322407: x86/crc32_sse42.c: quiet unused function warning.
x86/crc32_sse42.c: quiet unused function warning
Aug 11 2017, 5:05 PM
rlibby closed D11980: x86/crc32_sse42.c: quiet unused function warning by committing rS322407: x86/crc32_sse42.c: quiet unused function warning.
Aug 11 2017, 5:05 PM
rlibby created D11980: x86/crc32_sse42.c: quiet unused function warning.
Aug 11 2017, 7:33 AM

Aug 10 2017

rlibby closed D11947: Add myself (rlibby) to calendar.freebsd by committing rS322335: Add myself (rlibby) to calendar.freebsd.
Aug 10 2017, 2:16 AM
rlibby committed rS322335: Add myself (rlibby) to calendar.freebsd.
Add myself (rlibby) to calendar.freebsd
Aug 10 2017, 2:16 AM
rlibby created D11947: Add myself (rlibby) to calendar.freebsd.
Aug 10 2017, 2:05 AM

Aug 9 2017

rlibby committed rS322332: Pick 'Remove external linkage for spin_adaptive' from upstream jemalloc.
Pick 'Remove external linkage for spin_adaptive' from upstream jemalloc
Aug 9 2017, 10:59 PM
rlibby committed rS322329: i386/boot2: -fno-asynchronous-unwind-tables for gcc.
i386/boot2: -fno-asynchronous-unwind-tables for gcc
Aug 9 2017, 8:14 PM
rlibby closed D11928: i386/boot2: -fno-asynchronous-unwind-tables for gcc by committing rS322329: i386/boot2: -fno-asynchronous-unwind-tables for gcc.
Aug 9 2017, 8:14 PM
rlibby created D11928: i386/boot2: -fno-asynchronous-unwind-tables for gcc.
Aug 9 2017, 12:17 AM

Jul 28 2017

rlibby committed rS321669: bhyve/vga.c: fix atc_color_select_67 bit shift.
bhyve/vga.c: fix atc_color_select_67 bit shift
Jul 28 2017, 9:47 PM
rlibby closed D11775: bhyve/vga.c: fix atc_color_select_67 bit shift by committing rS321669: bhyve/vga.c: fix atc_color_select_67 bit shift.
Jul 28 2017, 9:47 PM
rlibby closed D11774: bhyve/pci_e82545.c: squelch gcc warning for noreturn procedure by committing rS321668: bhyve/pci_e82545.c: squelch gcc warning for noreturn procedure.
Jul 28 2017, 9:43 PM
rlibby committed rS321668: bhyve/pci_e82545.c: squelch gcc warning for noreturn procedure.
bhyve/pci_e82545.c: squelch gcc warning for noreturn procedure
Jul 28 2017, 9:43 PM
rlibby created D11775: bhyve/vga.c: fix atc_color_select_67 bit shift.
Jul 28 2017, 6:04 PM
rlibby created D11774: bhyve/pci_e82545.c: squelch gcc warning for noreturn procedure.
Jul 28 2017, 5:53 PM