- User Since
- Nov 12 2015, 8:14 PM (187 w, 5 d)
Fri, Jun 7
May 16 2019
May 15 2019
I'm not qualified to review, but LGTM besides a couple nit picks.
@cem got this pushed upstream  and we pulled it back down with v1.3.8 in r342598.
Equivalent patch was done in r343672 by @vangyzen .
May 8 2019
Dec 13 2018
Silence warnings in code instead of disabling the warning.
@cem is direct commit to sys/contrib/zstd okay for this?
Jun 13 2018
Jun 11 2018
Jun 9 2018
dim feedback: use CWARNFLAGS.gcc for warning suppression
Nov 1 2017
Always nice to have minus diffs, assuming it still compiles :)
Most of these changes look to be in the right direction. I don't think evaluating if a bool == true or == false is necessary. In some places parentheses have been added which are not strictly needed, I don't feel strongly about those either way. I did not evaluate for completeness.
My opinion is generally that branch predictions should be sparse. Is it really going to make any difference in setup/teardown functions, which many of the functions edited here appear to be?
Oct 22 2017
Review feedback: avoid touching "superfluous" macro parens for now
mjoras feedback: parenthesization fixes
Oct 21 2017
Oct 18 2017
Oct 17 2017
Oct 16 2017
Oct 14 2017
hselasky feedback: replace const vars with enum constants
Sep 26 2017
Padlock fix-up LGTM.
The change looks fine to me.
Sep 25 2017
Just dropping some nitpicks, I haven't reached a deep enough understanding for a real review yet.
The change itself seems fine to me. I'll defer to others with respect to whether this is the right direction and whether the documentation needs to be in this revision.
Sep 22 2017
Sep 18 2017
Sep 14 2017
Sep 13 2017
@emaste suggested out of band to verify with a universe build. I did a make tinderbox and it succeeded.