nvme_ctrlr_linux_passthru_cmd: correct size of upages_small array
ClosedPublic
Actions

Authored by rlibby on Sun, Apr 12, 8:14 PM.

Tags

None

Referenced Files

	F153280952: D56368.diff
	Mon, Apr 20, 5:35 AM

	Unknown Object (File)
	Sun, Apr 19, 5:52 AM

	Unknown Object (File)
	Sat, Apr 18, 5:21 AM

	Unknown Object (File)
	Sat, Apr 18, 5:13 AM

	Unknown Object (File)
	Sat, Apr 18, 5:13 AM

	Unknown Object (File)
	Sat, Apr 18, 4:38 AM

	Unknown Object (File)
	Sat, Apr 18, 4:37 AM

	Unknown Object (File)
	Thu, Apr 16, 7:15 AM

View All 13 Files

Subscribers

dab

imp

Details

Reviewers

imp

Commits

rG8085c5a5c1e5: nvme_ctrlr_linux_passthru_cmd: correct size of upages_small array

Summary

The size broke when upages was converted from array to double pointer.

Reported-by: gcc -Wsizeof-pointer-div
Fixes: 82ff1c334b97 ("nvme: Allow larger user request sizes")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby created this revision.Sun, Apr 12, 8:14 PM

Herald added subscribers: dab, imp. · View Herald TranscriptSun, Apr 12, 8:14 PM

rlibby requested review of this revision.Sun, Apr 12, 8:14 PM

Harbormaster completed remote builds in B72158: Diff 175378.Sun, Apr 12, 8:15 PM

rlibby added a reviewer: imp.Sun, Apr 12, 8:28 PM

<doh!>
Thanks!

This revision is now accepted and ready to land.Sun, Apr 12, 8:46 PM

Closed by commit rG8085c5a5c1e5: nvme_ctrlr_linux_passthru_cmd: correct size of upages_small array (authored by rlibby). · Explain WhyMon, Apr 13, 12:21 AM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rG8085c5a5c1e5: nvme_ctrlr_linux_passthru_cmd: correct size of upages_small array.

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

nvme_ctrlr.c

4 lines

Diff 175390

View Options

nvme_ctrlr_linux_passthru_cmd: correct size of upages_small arrayClosedPublicActions