nvme_ctrlr_linux_passthru_cmd: correct size of upages_small array
ClosedPublic
Actions

Authored by rlibby on Apr 12 2026, 8:14 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Aug 20, 7:03 AM

	Unknown Object (File)
	Tue, Aug 18, 6:21 AM

	Unknown Object (File)
	Mon, Aug 17, 5:16 PM

	Unknown Object (File)
	Thu, Aug 13, 8:39 PM

	Unknown Object (File)
	Thu, Aug 13, 3:19 AM

	Unknown Object (File)
	Thu, Aug 13, 1:42 AM

	Unknown Object (File)
	Wed, Aug 12, 7:04 AM

	Unknown Object (File)
	Wed, Aug 12, 1:20 AM

View All 69 Files

Subscribers

dab

imp

Details

Reviewers

imp

Commits

rG8085c5a5c1e5: nvme_ctrlr_linux_passthru_cmd: correct size of upages_small array

Summary

The size broke when upages was converted from array to double pointer.

Reported-by: gcc -Wsizeof-pointer-div
Fixes: 82ff1c334b97 ("nvme: Allow larger user request sizes")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby created this revision.Apr 12 2026, 8:14 PM

Herald added subscribers: dab, imp. · View Herald TranscriptApr 12 2026, 8:14 PM

rlibby requested review of this revision.Apr 12 2026, 8:14 PM

Harbormaster completed remote builds in B72158: Diff 175378.Apr 12 2026, 8:15 PM

rlibby added a reviewer: imp.Apr 12 2026, 8:28 PM

<doh!>
Thanks!

This revision is now accepted and ready to land.Apr 12 2026, 8:46 PM

Closed by commit rG8085c5a5c1e5: nvme_ctrlr_linux_passthru_cmd: correct size of upages_small array (authored by rlibby). · Explain WhyApr 13 2026, 12:21 AM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rG8085c5a5c1e5: nvme_ctrlr_linux_passthru_cmd: correct size of upages_small array.

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

nvme_ctrlr.c

4 lines

Diff 175390

View Options

nvme_ctrlr_linux_passthru_cmd: correct size of upages_small arrayClosedPublicActions