Fix validation added into rev.360967 to handle fragmented UDP packets correctly
ClosedPublic
Actions

Authored by sobomax on Oct 8 2021, 5:29 AM.

Details

Reviewers

ae
emaste
markj
donner

Commits

rG7910632fbd46: Fix fragmented UDP packets handling since rev.360967.
rG4378aee9f82f: Fix fragmented UDP packets handling since rev.360967.
rG73c5a2566dbb: Fix fragmented UDP packets handling since rev.360967.
rGec746e619578: Fix fragmented UDP packets handling since rev.360967.
rG461e6f23db3b: Fix fragmented UDP packets handling since rev.360967.

Summary

Some extra validation added into rev.360967 does not properly handle fragmented UDP packets, resulted in both first fragment and all subsequent ones to not being aliased.

Test Plan

Setup network using kernel NAT, test fragmented UDP packets going in and out.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sobomax created this revision.Oct 8 2021, 5:29 AM

Herald added subscribers: donner, melifaro, imp. · View Herald TranscriptOct 8 2021, 5:29 AM

sobomax requested review of this revision.Oct 8 2021, 5:29 AM

donner added a reviewer: donner.Oct 8 2021, 11:31 AM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 15 2021, 11:50 PM

Closed by commit rG461e6f23db3b: Fix fragmented UDP packets handling since rev.360967. (authored by sobomax). · Explain Why

This revision was automatically updated to reflect the committed changes.

sobomax added a commit: rG461e6f23db3b: Fix fragmented UDP packets handling since rev.360967..

emaste added a commit: rGec746e619578: Fix fragmented UDP packets handling since rev.360967..Jan 9 2022, 11:05 PM

Herald added a subscriber: glebius. · View Herald TranscriptJan 9 2022, 11:05 PM

emaste added a commit: rG73c5a2566dbb: Fix fragmented UDP packets handling since rev.360967..Jan 9 2022, 11:06 PM

emaste added a commit: rG4378aee9f82f: Fix fragmented UDP packets handling since rev.360967..Jan 11 2022, 6:15 PM

emaste added a commit: rG7910632fbd46: Fix fragmented UDP packets handling since rev.360967..Jan 11 2022, 6:19 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

libalias/

alias.c

225 lines

Diff 96939

View Options

sys/netinet/libalias/alias.c

Fix validation added into rev.360967 to handle fragmented UDP packets correctlyClosedPublicActions