Page MenuHomeFreeBSD
Differential D32363

Fix validation added into rev.360967 to handle fragmented UDP packets correctly
ClosedPublic
Actions

Authored by sobomax on Oct 8 2021, 5:29 AM.

Details

Reviewers
ae
emaste
markj
donner
Commits
R10:461e6f23db3b: Fix fragmented UDP packets handling since rev.360967.
Summary

Some extra validation added into rev.360967 does not properly handle fragmented UDP packets, resulted in both first fragment and all subsequent ones to not being aliased.

Test Plan

Setup network using kernel NAT, test fragmented UDP packets going in and out.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sobomax created this revision.Oct 8 2021, 5:29 AM
Herald added subscribers: donner, melifaro, imp. · View Herald TranscriptOct 8 2021, 5:29 AM
sobomax requested review of this revision.Oct 8 2021, 5:29 AM
donner added a reviewer: donner.Oct 8 2021, 11:31 AM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 15 2021, 11:50 PM
Closed by commit R10:461e6f23db3b: Fix fragmented UDP packets handling since rev.360967. (authored by sobomax). · Explain Why
This revision was automatically updated to reflect the committed changes.
sobomax added a commit: R10:461e6f23db3b: Fix fragmented UDP packets handling since rev.360967..

Revision Contents
Changeset List

PathSize
sys/
netinet/
libalias/
225 lines

Diff 96939

View Options

sys/netinet/libalias/alias.c

Loading...