ng pppoe(4): Add the required NET_EPOCH section to the hook disconnection function.

[afedorov]

Summary

Disconnecting hooks are called outside of NET_EPOCH, but ng_pppoe_disconnect() calls NG_SEND_DATA_ONLY() which should be called in NET_EPOCH.

PR: 257067

[donner]

LGTM

[vmaffione]

Question: there are three more locations in that source file where NG_SEND_DATA_ONLY() is called and it is not apparent that we are inside NET_EPOCH.
Should we enter NET_EPOCH also there, or we are already in?

[afedorov]

In D34185#773670, @vmaffione wrote:

Question: there are three more locations in that source file where NG_SEND_DATA_ONLY() is called and it is not apparent that we are inside NET_EPOCH.
Should we enter NET_EPOCH also there, or we are already in?

Other places where NG_SEND_DATA_ONLY() is called:

• pppoe_broadcast_padi() which called from ng_pppoe_rcvdata_ether() - datapath already in NET_EPOCH.
• ng_pppoe_rcvmsg() - already set NET_EPOCH manually.
• pppoe_start() called from ng_pppoe_rcvmsg() - already set NET_EPOCH manually.
• pppoe_start() called from ng_pppoe_ticker(). ng_pppoe_ticker() called from ng_callout() which enter NET_EPOCH.

So, I think other places where NG_SEND_DATA_ONLY() is called, are already in NET_EPOCH.

[vmaffione]

I see, thanks.