Indeed. I had put the changes to igb in a separate review: https://reviews.freebsd.org/D33156

Use iri_ifp rather than iflib_get_ifp().

Thanks. I think we may get there (getting rid of ifp) at a later step, since some reworking would actually needed within iflib.
This change is meant to simply align em(4) to the other drivers.

Use ri->iri_ifp

Added diff context.

LGTM, thanks

Good idea, thanks! I added just a little comment.

LGTM!

Sounds good. I had not noticed that *if_input returns void.

Merged

Thanks!

LGTM

Good catch, thanks!

Thank you!

Looks good, thanks! However, we should add the same control for the DEV_TAP at line 1860.

Thanks, but the commit looks a bit strange: we are treating the pdev as a bus_dma_tag_t when it's really a pointer to a netmap adapter. It is not used at all on FreeBSD so it doesn't really matter, but maybe I'm missing something.

Usage of "struct device *" was just wrong. Thanks spotting the issue.
Commit 70275a6735df8a514f48be77418491f2f8dba817 should have the same effect.

Now that libnetmap has been merged and valectl updated, we can apply part of this change (documentation, usage, error checking).

Not relevant anymore.

Forgot to link the commit to this review.

Il giorno ven 19 mar 2021 alle ore 18:24 markj (Mark Johnston) <
phabric-noreply@freebsd.org> ha scritto:

Addressed reviewer comments

It may also help to use these commands (available on freefall) to look for style issues