Page MenuHomeFreeBSD

vmaffione (V Maffione)
User

Projects

User Details

User Since
Mar 10 2018, 1:54 AM (195 w, 4 d)

Recent Activity

Today

vmaffione added inline comments to D33156: igb: align rx offload processing to the other Intel drivers.
Wed, Dec 8, 9:28 AM
vmaffione committed R10:e0f4cdba5336: e1000: fix interface capabilities management (authored by vmaffione).
e1000: fix interface capabilities management
Wed, Dec 8, 9:00 AM
vmaffione closed D33154: e1000: fix interface capabilities management.
Wed, Dec 8, 9:00 AM
vmaffione added inline comments to D33154: e1000: fix interface capabilities management.
Wed, Dec 8, 8:33 AM

Thu, Dec 2

vmaffione added a comment to D33154: e1000: fix interface capabilities management.

Indeed. I had put the changes to igb in a separate review: https://reviews.freebsd.org/D33156

Thu, Dec 2, 10:26 PM
vmaffione added a reviewer for D33156: igb: align rx offload processing to the other Intel drivers: markj.
Thu, Dec 2, 10:20 PM
vmaffione updated the diff for D33156: igb: align rx offload processing to the other Intel drivers.

Use iri_ifp rather than iflib_get_ifp().

Thu, Dec 2, 10:20 PM

Wed, Dec 1

vmaffione committed R10:d0633af7658f: em: skip rxcsum offload processing when disabled (authored by vmaffione).
em: skip rxcsum offload processing when disabled
Wed, Dec 1, 9:13 PM
vmaffione closed D33155: em: skip rxcsum offload processing when disabled.
Wed, Dec 1, 9:13 PM
vmaffione added a reviewer for D33154: e1000: fix interface capabilities management: erj.
Wed, Dec 1, 9:09 PM
vmaffione committed R10:d91559564dc6: e1000: remove unused ifp backpointer (authored by vmaffione).
e1000: remove unused ifp backpointer
Wed, Dec 1, 9:09 PM
vmaffione closed D33157: e1000: remove unused ifp backpointer.
Wed, Dec 1, 9:09 PM

Tue, Nov 30

vmaffione added a comment to D33155: em: skip rxcsum offload processing when disabled.

Thanks. I think we may get there (getting rid of ifp) at a later step, since some reworking would actually needed within iflib.
This change is meant to simply align em(4) to the other drivers.

Tue, Nov 30, 9:12 PM
vmaffione updated the diff for D33155: em: skip rxcsum offload processing when disabled.

Use ri->iri_ifp

Tue, Nov 30, 9:10 PM

Mon, Nov 29

vmaffione updated the diff for D33154: e1000: fix interface capabilities management.

Added diff context.

Mon, Nov 29, 9:20 PM

Sun, Nov 28

vmaffione requested review of D33157: e1000: remove unused ifp backpointer.
Sun, Nov 28, 10:18 PM
vmaffione requested review of D33156: igb: align rx offload processing to the other Intel drivers.
Sun, Nov 28, 10:17 PM
vmaffione requested review of D33155: em: skip rxcsum offload processing when disabled.
Sun, Nov 28, 10:15 PM
vmaffione requested review of D33154: e1000: fix interface capabilities management.
Sun, Nov 28, 10:12 PM

Oct 9 2021

vmaffione committed R10:fdbbd118faab: nemtap: lb app: Validate ihl field when hashing packet (authored by vmaffione).
nemtap: lb app: Validate ihl field when hashing packet
Oct 9 2021, 9:20 PM

Sep 26 2021

vmaffione committed R10:5faf08808d63: libnetmap: reset errno in nmreq_register_decode() (authored by vmaffione).
libnetmap: reset errno in nmreq_register_decode()
Sep 26 2021, 2:13 PM
vmaffione committed R10:d61f95996174: netmap: monitor: add a flag to distinguish packet direction (authored by vmaffione).
netmap: monitor: add a flag to distinguish packet direction
Sep 26 2021, 2:11 PM
vmaffione committed R10:6127ce9d91c8: netmap: monitor: support offsets in copy mode (authored by vmaffione).
netmap: monitor: support offsets in copy mode
Sep 26 2021, 2:09 PM
vmaffione committed R10:3e3314a8b7e3: netmap: fix uint32_t overflow in pool size calculation (authored by vmaffione).
netmap: fix uint32_t overflow in pool size calculation
Sep 26 2021, 2:09 PM
vmaffione committed R10:f7cef43aa9a3: nemtap: lb app: Validate ihl field when hashing packet (authored by vmaffione).
nemtap: lb app: Validate ihl field when hashing packet
Sep 26 2021, 1:49 PM

Aug 22 2021

vmaffione committed R10:98399ab06f6c: netmap: import changes from upstream (authored by vmaffione).
netmap: import changes from upstream
Aug 22 2021, 9:40 AM

Aug 17 2021

vmaffione accepted D31550: iflib: emulate counters in netmap mode.

LGTM, thanks

Aug 17 2021, 11:49 AM
vmaffione requested changes to D31550: iflib: emulate counters in netmap mode.

Good idea, thanks! I added just a little comment.

Aug 17 2021, 11:23 AM

Jul 8 2021

vmaffione accepted D31104: Fix to call callout_init with correct inputs from axp driver.

LGTM!

Jul 8 2021, 8:33 PM

Jun 16 2021

vmaffione accepted D30638: if_vxlan(4): Allow netmap_generic to intercept RX packets..

Sounds good. I had not noticed that *if_input returns void.

Jun 16 2021, 9:28 PM
vmaffione closed D30776: pkt-gen: Fix code compilation.

Merged

Jun 16 2021, 9:00 PM

Jun 15 2021

vmaffione committed R10:950cf4a29a8e: netmap: pkt-gen: fix compilation issue (authored by vmaffione).
netmap: pkt-gen: fix compilation issue
Jun 15 2021, 9:37 PM
vmaffione accepted D30776: pkt-gen: Fix code compilation.

Thanks!

Jun 15 2021, 9:36 PM

Jun 6 2021

vmaffione requested changes to D30638: if_vxlan(4): Allow netmap_generic to intercept RX packets..
Jun 6 2021, 4:16 PM
vmaffione updated subscribers of D30638: if_vxlan(4): Allow netmap_generic to intercept RX packets..
Jun 6 2021, 9:07 AM
vmaffione accepted D30639: if_vtnet(4): Restore the ability to set promisc mode..

LGTM

Jun 6 2021, 9:06 AM

May 18 2021

vmaffione accepted D30324: Netmap: fix documentation for NR_REG_NIC_SW mode.

Good catch, thanks!

May 18 2021, 7:53 PM
vmaffione accepted D30266: pkt-gen: Allow limiting received packets.

Thank you!

May 18 2021, 7:52 PM

May 15 2021

vmaffione requested changes to D30266: pkt-gen: Allow limiting received packets.

Looks good, thanks! However, we should add the same control for the DEV_TAP at line 1860.

May 15 2021, 7:58 AM

Apr 18 2021

vmaffione committed R10:f4a54f4333c5: netmap: use safer defaults for hwbuf_len (authored by vmaffione).
netmap: use safer defaults for hwbuf_len
Apr 18 2021, 1:40 PM

Apr 17 2021

vmaffione committed R10:13c4641188d4: netmap: make sure rings are disabled during resets (authored by vmaffione).
netmap: make sure rings are disabled during resets
Apr 17 2021, 2:03 PM

Apr 12 2021

vmaffione added a comment to D29677: netmap: Use device_t in preference to struct device *.

Thanks, but the commit looks a bit strange: we are treating the pdev as a bus_dma_tag_t when it's really a pointer to a netmap adapter. It is not used at all on FreeBSD so it doesn't really matter, but maybe I'm missing something.

Apr 12 2021, 9:27 PM
vmaffione committed R10:70275a6735df: netmap: don't use linux type struct device * (authored by vmaffione).
netmap: don't use linux type struct device *
Apr 12 2021, 3:49 AM
vmaffione closed D29677: netmap: Use device_t in preference to struct device *.
Apr 12 2021, 3:49 AM

Apr 11 2021

vmaffione added a comment to D29677: netmap: Use device_t in preference to struct device *.

Usage of "struct device *" was just wrong. Thanks spotting the issue.
Commit 70275a6735df8a514f48be77418491f2f8dba817 should have the same effect.

Apr 11 2021, 9:15 PM

Apr 10 2021

vmaffione retitled D29697: remove IFNET_RLOCK() that collides CTX_LOCK() in iflib_netmap_register from remove no ifnet_lock that collides CTX_LOCK in iflib_netmap_register to remove IFNET_RLOCK() that collides CTX_LOCK() in iflib_netmap_register.
Apr 10 2021, 7:59 PM
vmaffione requested review of D29697: remove IFNET_RLOCK() that collides CTX_LOCK() in iflib_netmap_register.
Apr 10 2021, 7:50 PM

Apr 9 2021

vmaffione committed R10:172c5eb272df: netmap: vtnet: remove unused variable (authored by vmaffione).
netmap: vtnet: remove unused variable
Apr 9 2021, 7:35 PM

Apr 7 2021

vmaffione committed R10:15dc713ceb57: netmap: vtnet: add support for netmap offsets (authored by vmaffione).
netmap: vtnet: add support for netmap offsets
Apr 7 2021, 9:44 PM
vmaffione committed R10:b5cf839053fe: netmap: pkt-gen: allow -Z and -z to be used together (authored by vmaffione).
netmap: pkt-gen: allow -Z and -z to be used together
Apr 7 2021, 9:07 PM
vmaffione committed R10:588b2e6dd2f6: netmap: pkt-gen: allow -Z and -z to be used together (authored by vmaffione).
netmap: pkt-gen: allow -Z and -z to be used together
Apr 7 2021, 9:07 PM
vmaffione committed R10:3f70c3d58f93: netmap: bridge: fix transmission in busy-wait mode (authored by vmaffione).
netmap: bridge: fix transmission in busy-wait mode
Apr 7 2021, 9:06 PM
vmaffione committed R10:894b3a1a32cc: netmap: bridge: fix transmission in busy-wait mode (authored by vmaffione).
netmap: bridge: fix transmission in busy-wait mode
Apr 7 2021, 9:05 PM

Apr 5 2021

vmaffione committed R10:8d415b19409b: netmap: iflib: add nm_config callback (authored by vmaffione).
netmap: iflib: add nm_config callback
Apr 5 2021, 8:10 AM
vmaffione committed R10:75b13b151c9e: netmap: iflib: add nm_config callback (authored by vmaffione).
netmap: iflib: add nm_config callback
Apr 5 2021, 8:04 AM
vmaffione committed R10:361e95018002: iflib: add support for netmap offsets (authored by vmaffione).
iflib: add support for netmap offsets
Apr 5 2021, 8:03 AM

Apr 2 2021

vmaffione committed R10:36d6e65722ea: netmap: update unit tests with libnetmap tests (authored by vmaffione).
netmap: update unit tests with libnetmap tests
Apr 2 2021, 2:40 PM
vmaffione committed R10:ab639bb28730: libnetmap: reset errno in nmreq_register_decode() (authored by vmaffione).
libnetmap: reset errno in nmreq_register_decode()
Apr 2 2021, 2:39 PM
vmaffione committed R10:9bad2638cc18: netmap: restore commit a56e6334d1b7ed6e6faaa8b4612d948005ba74f5 (authored by vmaffione).
netmap: restore commit a56e6334d1b7ed6e6faaa8b4612d948005ba74f5
Apr 2 2021, 10:46 AM
vmaffione committed R10:45c67e8f6b56: netmap: several typo fixes (authored by vmaffione).
netmap: several typo fixes
Apr 2 2021, 7:02 AM
vmaffione committed R10:66671ae589c3: netmap: fix typo bug in netmap_compute_buf_len (authored by vmaffione).
netmap: fix typo bug in netmap_compute_buf_len
Apr 2 2021, 6:48 AM

Mar 30 2021

vmaffione committed R10:88024c4a520b: libnetmap: restore changes in 26c29e743bbdbb82762540f72d4bc449bae2e092 (authored by vmaffione).
libnetmap: restore changes in 26c29e743bbdbb82762540f72d4bc449bae2e092
Mar 30 2021, 9:54 AM
vmaffione committed R10:51cc31088bf4: netmap: bridge: fix transmission in busy-wait mode (authored by vmaffione).
netmap: bridge: fix transmission in busy-wait mode
Mar 30 2021, 6:30 AM
vmaffione committed R10:27bf5dd3d403: netmap: pkt-gen: allow -Z and -z to be used together (authored by vmaffione).
netmap: pkt-gen: allow -Z and -z to be used together
Mar 30 2021, 6:20 AM
vmaffione added a comment to D26161: valectl(8) patch to use the new netmap API.

Now that libnetmap has been merged and valectl updated, we can apply part of this change (documentation, usage, error checking).

Mar 30 2021, 6:10 AM
vmaffione abandoned D18402: netmap: ixgbe: add support for jumbo frames.

Not relevant anymore.

Mar 30 2021, 6:02 AM

Mar 29 2021

vmaffione committed R10:f8113f0a65ad: libnetmap: add support for the offset features (authored by vmaffione).
libnetmap: add support for the offset features
Mar 29 2021, 4:42 PM
vmaffione committed R10:660a47cb991d: netmap: monitor: add a flag to distinguish packet direction (authored by vmaffione).
netmap: monitor: add a flag to distinguish packet direction
Mar 29 2021, 4:36 PM
vmaffione committed R10:a6d768d845c1: netmap: add kernel support for the "offsets" feature (authored by vmaffione).
netmap: add kernel support for the "offsets" feature
Mar 29 2021, 4:30 PM
vmaffione committed R10:21d0c01226eb: netmap: iflib: add nm_config callback (authored by you@x <you@x>).
netmap: iflib: add nm_config callback
Mar 29 2021, 10:00 AM

Mar 23 2021

vmaffione committed R10:4ec92bce4ece: netmap: fix issues in nm_os_extmem_create() (authored by vmaffione).
netmap: fix issues in nm_os_extmem_create()
Mar 23 2021, 10:06 PM
vmaffione committed R10:f7e3976ed033: netmap: fix memory leak in NETMAP_REQ_PORT_INFO_GET (authored by vmaffione).
netmap: fix memory leak in NETMAP_REQ_PORT_INFO_GET
Mar 23 2021, 10:05 PM
vmaffione committed R10:e36c2f704635: netmap: fix issues in nm_os_extmem_create() (authored by vmaffione).
netmap: fix issues in nm_os_extmem_create()
Mar 23 2021, 9:20 PM
vmaffione committed R10:610706f5e71a: netmap: fix issues in nm_os_extmem_create() (authored by vmaffione).
netmap: fix issues in nm_os_extmem_create()
Mar 23 2021, 9:19 PM
vmaffione committed R10:3e4127f8f293: netmap: fix issues in nm_os_extmem_create() (authored by vmaffione).
netmap: fix issues in nm_os_extmem_create()
Mar 23 2021, 9:18 PM

Mar 20 2021

vmaffione closed D29318: Fix a couple of issues in nm_os_extmem_create.

Forgot to link the commit to this review.

Mar 20 2021, 5:32 PM
vmaffione committed R10:ee7ffaa2e6e0: netmap: fix issues in nm_os_extmem_create() (authored by vmaffione).
netmap: fix issues in nm_os_extmem_create()
Mar 20 2021, 5:28 PM

Mar 19 2021

vmaffione updated subscribers of D29318: Fix a couple of issues in nm_os_extmem_create.

Il giorno ven 19 mar 2021 alle ore 18:24 markj (Mark Johnston) <
phabric-noreply@freebsd.org> ha scritto:

Mar 19 2021, 5:43 PM
vmaffione added inline comments to D29318: Fix a couple of issues in nm_os_extmem_create.
Mar 19 2021, 5:18 PM
vmaffione updated the diff for D29318: Fix a couple of issues in nm_os_extmem_create.

Addressed reviewer comments

Mar 19 2021, 5:15 PM

Mar 18 2021

vmaffione committed R10:4019787f50a2: netmap: fix memory leak in NETMAP_REQ_PORT_INFO_GET (authored by vmaffione).
netmap: fix memory leak in NETMAP_REQ_PORT_INFO_GET
Mar 18 2021, 5:03 PM
vmaffione committed R10:09b2bde74654: netmap: fix memory leak in NETMAP_REQ_PORT_INFO_GET (authored by vmaffione).
netmap: fix memory leak in NETMAP_REQ_PORT_INFO_GET
Mar 18 2021, 4:58 PM
vmaffione committed R10:120a4bd4e9d0: netmap: fix memory leak in NETMAP_REQ_PORT_INFO_GET (authored by vmaffione).
netmap: fix memory leak in NETMAP_REQ_PORT_INFO_GET
Mar 18 2021, 4:51 PM

Mar 17 2021

vmaffione requested review of D29318: Fix a couple of issues in nm_os_extmem_create.
Mar 17 2021, 9:23 PM

Mar 15 2021

vmaffione committed R10:0ab5902e8ad9: netmap: fix memory leak in NETMAP_REQ_PORT_INFO_GET (authored by vmaffione).
netmap: fix memory leak in NETMAP_REQ_PORT_INFO_GET
Mar 15 2021, 5:48 PM

Mar 5 2021

vmaffione accepted D29099: netmap: Stop printing a line to the dmesg in netmap_init().
Mar 5 2021, 9:37 PM

Feb 19 2021

vmaffione accepted D28724: Update manpage for AMD 10GbE driver.
Feb 19 2021, 7:03 AM

Feb 18 2021

vmaffione added a comment to D28724: Update manpage for AMD 10GbE driver.

It may also help to use these commands (available on freefall) to look for style issues

Feb 18 2021, 6:55 AM
vmaffione accepted D28598: iflib: Cast the result of iflib_netmap_txq_init() to void..
Feb 18 2021, 6:52 AM

Feb 16 2021

vmaffione accepted D28587: Documentation repo changes for adding new committer Rajesh Kumar.
Feb 16 2021, 6:59 PM

Feb 13 2021

vmaffione added inline comments to D28598: iflib: Cast the result of iflib_netmap_txq_init() to void..
Feb 13 2021, 7:21 AM

Feb 12 2021

vmaffione accepted D28587: Documentation repo changes for adding new committer Rajesh Kumar.
Feb 12 2021, 7:32 AM

Feb 11 2021

vmaffione accepted D28586: Source repo changes for adding new committer Rajesh Kumar.
Feb 11 2021, 8:33 PM

Feb 1 2021

vmaffione committed R9:bdb56d32ce67: Update my PGP key (using addkey.sh) (authored by vmaffione).
Update my PGP key (using addkey.sh)
Feb 1 2021, 7:55 AM

Jan 31 2021

vmaffione committed R10:e4c81e46acc0: netmap: simplify parameter passing (authored by vmaffione).
netmap: simplify parameter passing
Jan 31 2021, 8:53 AM
vmaffione committed R10:a8ca736bb4ed: iflib: netmap: move per-packet operation out of fragments loop (authored by vmaffione).
iflib: netmap: move per-packet operation out of fragments loop
Jan 31 2021, 8:53 AM
vmaffione committed R10:e0e00874a3c3: iflib: netmap: add support for NS_MOREFRAG (authored by vmaffione).
iflib: netmap: add support for NS_MOREFRAG
Jan 31 2021, 8:53 AM
vmaffione committed R10:e817c8f77fe8: netmap: simplify parameter passing (authored by vmaffione).
netmap: simplify parameter passing
Jan 31 2021, 8:53 AM
vmaffione committed R10:31c2349742a9: iflib: netmap: move per-packet operation out of fragments loop (authored by vmaffione).
iflib: netmap: move per-packet operation out of fragments loop
Jan 31 2021, 8:52 AM
vmaffione committed R10:9c5418f00836: iflib: netmap: add support for NS_MOREFRAG (authored by vmaffione).
iflib: netmap: add support for NS_MOREFRAG
Jan 31 2021, 8:52 AM