- User Since
- Mar 10 2018, 1:54 AM (246 w, 5 d)
Sep 10 2022
Not familiar with the code.
If it's safe to leave temporarily the epoch without worrying about things changing while we were out of the epoch, then I'm ok.
The other option would be to enter/exit the epoch from within ng_apply_item (conditionally), but it would require to enter/exit the epoch for each data msg.
Sep 6 2022
Aug 24 2022
Jun 30 2022
If there are no objections, I would go ahead and commit this, incorporating the style fixes by @jhb
Jun 8 2022
Mar 30 2022
Mar 20 2022
Mar 19 2022
Mar 16 2022
Mar 6 2022
Feb 15 2022
Feb 13 2022
Feb 8 2022
I see, thanks.
Feb 7 2022
Question: there are three more locations in that source file where NG_SEND_DATA_ONLY() is called and it is not apparent that we are inside NET_EPOCH.
Should we enter NET_EPOCH also there, or we are already in?
Jan 27 2022
Jan 14 2022
Jan 6 2022
Dec 28 2021
Dec 25 2021
Dec 22 2021
Dec 19 2021
...or we can also switch to isc_capenable in the same changeset.
The last diff tweaks iflib's ioctl handler to synchronize isc_capenable to if_capenable.
use iri_ifp rather than iflib_get_ifp() in ice and ixgbe.
Note that this patch contains a number of changes that fix separate issues:
- fix VLAN offload processing handling the case of vtag == 0.
- use if_getcapenable() rather the isc_capenable because the latter is not synchronized.
- use iri_ifp rather than iflib_get_ifp() to avoid an additional indirection.
Dec 18 2021
Also fix scctx->isc_capenable and isc_capabilities usage in igc.
Fix the iri_vtag setting logic for all the iflib drivers.
That's right, thanks. The same issue is there for at least em and ixgbe.
I can fix those if you like.
Dec 8 2021
Dec 2 2021
Indeed. I had put the changes to igb in a separate review: https://reviews.freebsd.org/D33156
Use iri_ifp rather than iflib_get_ifp().
Dec 1 2021
Nov 30 2021
Thanks. I think we may get there (getting rid of ifp) at a later step, since some reworking would actually needed within iflib.
This change is meant to simply align em(4) to the other drivers.
Nov 29 2021
Added diff context.
Nov 28 2021
Oct 9 2021
Sep 26 2021
Aug 22 2021
Aug 17 2021
Good idea, thanks! I added just a little comment.
Jul 8 2021
Jun 16 2021
Sounds good. I had not noticed that *if_input returns void.
Jun 15 2021
Jun 6 2021
May 18 2021
Good catch, thanks!
May 15 2021
Looks good, thanks! However, we should add the same control for the DEV_TAP at line 1860.
Apr 18 2021
Apr 17 2021
Apr 12 2021
Thanks, but the commit looks a bit strange: we are treating the pdev as a bus_dma_tag_t when it's really a pointer to a netmap adapter. It is not used at all on FreeBSD so it doesn't really matter, but maybe I'm missing something.
Apr 11 2021
Usage of "struct device *" was just wrong. Thanks spotting the issue.
Commit 70275a6735df8a514f48be77418491f2f8dba817 should have the same effect.