Page MenuHomeFreeBSD

vmaffione (V Maffione)
User

Projects

User Details

User Since
Mar 10 2018, 1:54 AM (246 w, 5 d)

Recent Activity

Sep 10 2022

vmaffione accepted D36496: netgraph(4): Don't process NGQF_MESG items in NET_EPOCH context..

Not familiar with the code.
If it's safe to leave temporarily the epoch without worrying about things changing while we were out of the epoch, then I'm ok.
The other option would be to enter/exit the epoch from within ng_apply_item (conditionally), but it would require to enter/exit the epoch for each data msg.

Sep 10 2022, 7:25 AM

Sep 6 2022

vmaffione committed rG21848f12be8b: pkt-gen: flip IPv4 address in ping-pong mode (authored by vmaffione).
pkt-gen: flip IPv4 address in ping-pong mode
Sep 6 2022, 8:16 PM

Aug 24 2022

vmaffione committed rG9a7abd932727: pkt-gen: flip IPv4 address in ping-pong mode (authored by vmaffione).
pkt-gen: flip IPv4 address in ping-pong mode
Aug 24 2022, 8:23 AM

Jun 30 2022

vmaffione added a comment to D35143: Bhyve virtio-net: Allow backend type to be explicitly specified..

If there are no objections, I would go ahead and commit this, incorporating the style fixes by @jhb

Jun 30 2022, 3:59 PM

Jun 8 2022

vmaffione accepted D35143: Bhyve virtio-net: Allow backend type to be explicitly specified..
Jun 8 2022, 9:42 PM

Mar 30 2022

vmaffione committed rG725c70d8153f: netmap: Fix TOCTOU vulnerability in nmreq_copyin (authored by vmaffione).
netmap: Fix TOCTOU vulnerability in nmreq_copyin
Mar 30 2022, 10:09 PM

Mar 20 2022

vmaffione committed rG931c75bf01d6: netmap: add a tunable for the maximum number of VALE switches (authored by vmaffione).
netmap: add a tunable for the maximum number of VALE switches
Mar 20 2022, 9:10 AM
vmaffione committed rG6e142610cef3: netmap: add a tunable for the maximum number of VALE switches (authored by vmaffione).
netmap: add a tunable for the maximum number of VALE switches
Mar 20 2022, 9:08 AM
vmaffione committed rGddb842e2ad63: netmap: add a tunable for the maximum number of VALE switches (authored by vmaffione).
netmap: add a tunable for the maximum number of VALE switches
Mar 20 2022, 9:05 AM
vmaffione committed rG606f528decc3: netmap: Fix integer overflow in nmreq_copyin (authored by vmaffione).
netmap: Fix integer overflow in nmreq_copyin
Mar 20 2022, 9:03 AM

Mar 19 2022

vmaffione committed rG6fa8af618475: netmap: Fix TOCTOU vulnerability in nmreq_copyin (authored by vmaffione).
netmap: Fix TOCTOU vulnerability in nmreq_copyin
Mar 19 2022, 5:55 PM
vmaffione committed rG95602165e33a: netmap: Fix integer overflow in nmreq_copyin (authored by vmaffione).
netmap: Fix integer overflow in nmreq_copyin
Mar 19 2022, 5:55 PM
vmaffione committed rG9df8dd3ea36c: netmap: Fix integer overflow in nmreq_copyin (authored by vmaffione).
netmap: Fix integer overflow in nmreq_copyin
Mar 19 2022, 5:54 PM
vmaffione committed rG9f600a260a73: netmap: Fix TOCTOU vulnerability in nmreq_copyin (authored by vmaffione).
netmap: Fix TOCTOU vulnerability in nmreq_copyin
Mar 19 2022, 5:54 PM

Mar 16 2022

vmaffione committed rG393729916564: netmap: Fix TOCTOU vulnerability in nmreq_copyin (authored by vmaffione).
netmap: Fix TOCTOU vulnerability in nmreq_copyin
Mar 16 2022, 7:09 AM
vmaffione committed rG694ea59c7021: netmap: Fix integer overflow in nmreq_copyin (authored by vmaffione).
netmap: Fix integer overflow in nmreq_copyin
Mar 16 2022, 7:09 AM

Mar 6 2022

vmaffione committed rGdd6ab49a9aeb: netmap: add a tunable for the maximum number of VALE switches (authored by vmaffione).
netmap: add a tunable for the maximum number of VALE switches
Mar 6 2022, 5:37 PM
vmaffione committed rG09a1893398fd: netmap: fix refcount bug in netmap allocator (authored by vmaffione).
netmap: fix refcount bug in netmap allocator
Mar 6 2022, 4:40 PM

Feb 15 2022

vmaffione accepted D34260: md(4): Add dummy support of the BIO_FLUSH command for malloc and swap backend..
Feb 15 2022, 9:24 PM

Feb 13 2022

vmaffione committed rGea25a6af57e0: netmap: fix LOR in iflib_netmap_register (authored by vmaffione).
netmap: fix LOR in iflib_netmap_register
Feb 13 2022, 10:49 AM
vmaffione committed rGb425101ab6d5: netmap: fix LOR in iflib_netmap_register (authored by vmaffione).
netmap: fix LOR in iflib_netmap_register
Feb 13 2022, 10:48 AM

Feb 8 2022

vmaffione accepted D34185: ng pppoe(4): Add the required NET_EPOCH section to the hook disconnection function. .
Feb 8 2022, 9:09 PM
vmaffione requested changes to D34185: ng pppoe(4): Add the required NET_EPOCH section to the hook disconnection function. .

I see, thanks.

Feb 8 2022, 9:09 PM

Feb 7 2022

vmaffione added a comment to D34185: ng pppoe(4): Add the required NET_EPOCH section to the hook disconnection function. .

Question: there are three more locations in that source file where NG_SEND_DATA_ONLY() is called and it is not apparent that we are inside NET_EPOCH.
Should we enter NET_EPOCH also there, or we are already in?

Feb 7 2022, 9:06 PM

Jan 27 2022

vmaffione committed rGcf101bd5ceeb: net: iflib: fix vlan processing in the drivers (authored by vmaffione).
net: iflib: fix vlan processing in the drivers
Jan 27 2022, 10:40 PM
vmaffione committed rGa61341bf6e51: net: iflib: let the drivers use isc_capenable (authored by vmaffione).
net: iflib: let the drivers use isc_capenable
Jan 27 2022, 10:40 PM
vmaffione committed rG05c9fb008763: net: iflib: fix vlan processing in the drivers (authored by vmaffione).
net: iflib: fix vlan processing in the drivers
Jan 27 2022, 10:40 PM
vmaffione committed rGe99828dfbdd7: net: iflib: let the drivers use isc_capenable (authored by vmaffione).
net: iflib: let the drivers use isc_capenable
Jan 27 2022, 10:40 PM

Jan 14 2022

vmaffione committed rGe0e12405285b: netmap: fix LOR in iflib_netmap_register (authored by vmaffione).
netmap: fix LOR in iflib_netmap_register
Jan 14 2022, 9:09 PM

Jan 6 2022

vmaffione committed rG5df59718ed52: net: iflib: sync isc_capenable to if_capenable (authored by vmaffione).
net: iflib: sync isc_capenable to if_capenable
Jan 6 2022, 10:24 AM
vmaffione committed rG6000a417d32a: net: iflib: sync isc_capenable to if_capenable (authored by vmaffione).
net: iflib: sync isc_capenable to if_capenable
Jan 6 2022, 10:13 AM

Dec 28 2021

vmaffione committed rGf7926a6d0c10: net: iflib: fix vlan processing in the drivers (authored by vmaffione).
net: iflib: fix vlan processing in the drivers
Dec 28 2021, 11:13 AM
vmaffione committed rG52f45d8acee9: net: iflib: let the drivers use isc_capenable (authored by vmaffione).
net: iflib: let the drivers use isc_capenable
Dec 28 2021, 11:05 AM
vmaffione committed rG4561c4f0ca59: net: iflib: sync isc_capenable to if_capenable (authored by vmaffione).
net: iflib: sync isc_capenable to if_capenable
Dec 28 2021, 10:56 AM
vmaffione closed D33156: iflib: fix vlan offload processing across multiple drivers..
Dec 28 2021, 10:56 AM

Dec 25 2021

vmaffione added a comment to D33156: iflib: fix vlan offload processing across multiple drivers..

Any comments from @erj or @gallatin ?

Dec 25 2021, 11:01 AM

Dec 22 2021

vmaffione committed rG677d9b1694e0: e1000: fix interface capabilities management (authored by vmaffione).
e1000: fix interface capabilities management
Dec 22 2021, 1:45 PM
vmaffione committed rG5a26132b28b6: em: skip rxcsum offload processing when disabled (authored by vmaffione).
em: skip rxcsum offload processing when disabled
Dec 22 2021, 1:45 PM
vmaffione committed rGd10ea34d1128: e1000: remove unused ifp backpointer (authored by vmaffione).
e1000: remove unused ifp backpointer
Dec 22 2021, 1:45 PM
vmaffione committed rGecb7f44be901: e1000: fix interface capabilities management (authored by vmaffione).
e1000: fix interface capabilities management
Dec 22 2021, 9:04 AM

Dec 19 2021

vmaffione updated the diff for D33156: iflib: fix vlan offload processing across multiple drivers..

...or we can also switch to isc_capenable in the same changeset.
The last diff tweaks iflib's ioctl handler to synchronize isc_capenable to if_capenable.

Dec 19 2021, 1:51 PM
vmaffione updated the diff for D33156: iflib: fix vlan offload processing across multiple drivers..

use iri_ifp rather than iflib_get_ifp() in ice and ixgbe.

Dec 19 2021, 8:45 AM
vmaffione added a comment to D33156: iflib: fix vlan offload processing across multiple drivers..

Note that this patch contains a number of changes that fix separate issues:

  1. fix VLAN offload processing handling the case of vtag == 0.
  2. use if_getcapenable() rather the isc_capenable because the latter is not synchronized.
  3. use iri_ifp rather than iflib_get_ifp() to avoid an additional indirection.
Dec 19 2021, 8:37 AM

Dec 18 2021

vmaffione added inline comments to D33156: iflib: fix vlan offload processing across multiple drivers..
Dec 18 2021, 4:53 PM
vmaffione updated the summary of D33156: iflib: fix vlan offload processing across multiple drivers..
Dec 18 2021, 4:52 PM
vmaffione updated the diff for D33156: iflib: fix vlan offload processing across multiple drivers..

Also fix scctx->isc_capenable and isc_capabilities usage in igc.

Dec 18 2021, 4:51 PM
vmaffione updated the diff for D33156: iflib: fix vlan offload processing across multiple drivers..

Fix the iri_vtag setting logic for all the iflib drivers.

Dec 18 2021, 4:40 PM
vmaffione committed rG56eeb84f1093: em: skip rxcsum offload processing when disabled (authored by vmaffione).
em: skip rxcsum offload processing when disabled
Dec 18 2021, 12:08 PM
vmaffione committed rGa00d9c7f8cd9: e1000: remove unused ifp backpointer (authored by vmaffione).
e1000: remove unused ifp backpointer
Dec 18 2021, 11:59 AM
vmaffione added inline comments to D33156: iflib: fix vlan offload processing across multiple drivers..
Dec 18 2021, 11:56 AM
vmaffione updated the diff for D33156: iflib: fix vlan offload processing across multiple drivers..

That's right, thanks. The same issue is there for at least em and ixgbe.
I can fix those if you like.

Dec 18 2021, 11:54 AM

Dec 8 2021

vmaffione added inline comments to D33156: iflib: fix vlan offload processing across multiple drivers..
Dec 8 2021, 9:28 AM
vmaffione committed rGe0f4cdba5336: e1000: fix interface capabilities management (authored by vmaffione).
e1000: fix interface capabilities management
Dec 8 2021, 9:00 AM
vmaffione closed D33154: e1000: fix interface capabilities management.
Dec 8 2021, 9:00 AM
vmaffione added inline comments to D33154: e1000: fix interface capabilities management.
Dec 8 2021, 8:33 AM

Dec 2 2021

vmaffione added a comment to D33154: e1000: fix interface capabilities management.

Indeed. I had put the changes to igb in a separate review: https://reviews.freebsd.org/D33156

Dec 2 2021, 10:26 PM
vmaffione added a reviewer for D33156: iflib: fix vlan offload processing across multiple drivers.: markj.
Dec 2 2021, 10:20 PM
vmaffione updated the diff for D33156: iflib: fix vlan offload processing across multiple drivers..

Use iri_ifp rather than iflib_get_ifp().

Dec 2 2021, 10:20 PM

Dec 1 2021

vmaffione committed rGd0633af7658f: em: skip rxcsum offload processing when disabled (authored by vmaffione).
em: skip rxcsum offload processing when disabled
Dec 1 2021, 9:13 PM
vmaffione closed D33155: em: skip rxcsum offload processing when disabled.
Dec 1 2021, 9:13 PM
vmaffione added a reviewer for D33154: e1000: fix interface capabilities management: erj.
Dec 1 2021, 9:09 PM
vmaffione committed rGd91559564dc6: e1000: remove unused ifp backpointer (authored by vmaffione).
e1000: remove unused ifp backpointer
Dec 1 2021, 9:09 PM
vmaffione closed D33157: e1000: remove unused ifp backpointer.
Dec 1 2021, 9:09 PM

Nov 30 2021

vmaffione added a comment to D33155: em: skip rxcsum offload processing when disabled.

Thanks. I think we may get there (getting rid of ifp) at a later step, since some reworking would actually needed within iflib.
This change is meant to simply align em(4) to the other drivers.

Nov 30 2021, 9:12 PM
vmaffione updated the diff for D33155: em: skip rxcsum offload processing when disabled.

Use ri->iri_ifp

Nov 30 2021, 9:10 PM

Nov 29 2021

vmaffione updated the diff for D33154: e1000: fix interface capabilities management.

Added diff context.

Nov 29 2021, 9:20 PM

Nov 28 2021

vmaffione requested review of D33157: e1000: remove unused ifp backpointer.
Nov 28 2021, 10:18 PM
vmaffione requested review of D33156: iflib: fix vlan offload processing across multiple drivers..
Nov 28 2021, 10:17 PM
vmaffione requested review of D33155: em: skip rxcsum offload processing when disabled.
Nov 28 2021, 10:15 PM
vmaffione requested review of D33154: e1000: fix interface capabilities management.
Nov 28 2021, 10:12 PM

Oct 9 2021

vmaffione committed rGfdbbd118faab: nemtap: lb app: Validate ihl field when hashing packet (authored by vmaffione).
nemtap: lb app: Validate ihl field when hashing packet
Oct 9 2021, 9:20 PM

Sep 26 2021

vmaffione committed rG5faf08808d63: libnetmap: reset errno in nmreq_register_decode() (authored by vmaffione).
libnetmap: reset errno in nmreq_register_decode()
Sep 26 2021, 2:13 PM
vmaffione committed rGd61f95996174: netmap: monitor: add a flag to distinguish packet direction (authored by vmaffione).
netmap: monitor: add a flag to distinguish packet direction
Sep 26 2021, 2:11 PM
vmaffione committed rG6127ce9d91c8: netmap: monitor: support offsets in copy mode (authored by vmaffione).
netmap: monitor: support offsets in copy mode
Sep 26 2021, 2:09 PM
vmaffione committed rG3e3314a8b7e3: netmap: fix uint32_t overflow in pool size calculation (authored by vmaffione).
netmap: fix uint32_t overflow in pool size calculation
Sep 26 2021, 2:09 PM
vmaffione committed rGf7cef43aa9a3: nemtap: lb app: Validate ihl field when hashing packet (authored by vmaffione).
nemtap: lb app: Validate ihl field when hashing packet
Sep 26 2021, 1:49 PM

Aug 22 2021

vmaffione committed rG98399ab06f6c: netmap: import changes from upstream (authored by vmaffione).
netmap: import changes from upstream
Aug 22 2021, 9:40 AM

Aug 17 2021

vmaffione accepted D31550: iflib: emulate counters in netmap mode.

LGTM, thanks

Aug 17 2021, 11:49 AM
vmaffione requested changes to D31550: iflib: emulate counters in netmap mode.

Good idea, thanks! I added just a little comment.

Aug 17 2021, 11:23 AM

Jul 8 2021

vmaffione accepted D31104: Fix to call callout_init with correct inputs from axp driver.

LGTM!

Jul 8 2021, 8:33 PM

Jun 16 2021

vmaffione accepted D30638: if_vxlan(4): Allow netmap_generic to intercept RX packets..

Sounds good. I had not noticed that *if_input returns void.

Jun 16 2021, 9:28 PM
vmaffione closed D30776: pkt-gen: Fix code compilation.

Merged

Jun 16 2021, 9:00 PM

Jun 15 2021

vmaffione committed rG950cf4a29a8e: netmap: pkt-gen: fix compilation issue (authored by vmaffione).
netmap: pkt-gen: fix compilation issue
Jun 15 2021, 9:37 PM
vmaffione accepted D30776: pkt-gen: Fix code compilation.

Thanks!

Jun 15 2021, 9:36 PM

Jun 6 2021

vmaffione requested changes to D30638: if_vxlan(4): Allow netmap_generic to intercept RX packets..
Jun 6 2021, 4:16 PM
vmaffione updated subscribers of D30638: if_vxlan(4): Allow netmap_generic to intercept RX packets..
Jun 6 2021, 9:07 AM
vmaffione accepted D30639: if_vtnet(4): Restore the ability to set promisc mode..

LGTM

Jun 6 2021, 9:06 AM

May 18 2021

vmaffione accepted D30324: Netmap: fix documentation for NR_REG_NIC_SW mode.

Good catch, thanks!

May 18 2021, 7:53 PM
vmaffione accepted D30266: pkt-gen: Allow limiting received packets.

Thank you!

May 18 2021, 7:52 PM

May 15 2021

vmaffione requested changes to D30266: pkt-gen: Allow limiting received packets.

Looks good, thanks! However, we should add the same control for the DEV_TAP at line 1860.

May 15 2021, 7:58 AM

Apr 18 2021

vmaffione committed rGf4a54f4333c5: netmap: use safer defaults for hwbuf_len (authored by vmaffione).
netmap: use safer defaults for hwbuf_len
Apr 18 2021, 1:40 PM

Apr 17 2021

vmaffione committed rG13c4641188d4: netmap: make sure rings are disabled during resets (authored by vmaffione).
netmap: make sure rings are disabled during resets
Apr 17 2021, 2:03 PM

Apr 12 2021

vmaffione added a comment to D29677: netmap: Use device_t in preference to struct device *.

Thanks, but the commit looks a bit strange: we are treating the pdev as a bus_dma_tag_t when it's really a pointer to a netmap adapter. It is not used at all on FreeBSD so it doesn't really matter, but maybe I'm missing something.

Apr 12 2021, 9:27 PM
vmaffione committed rG70275a6735df: netmap: don't use linux type struct device * (authored by vmaffione).
netmap: don't use linux type struct device *
Apr 12 2021, 3:49 AM
vmaffione closed D29677: netmap: Use device_t in preference to struct device *.
Apr 12 2021, 3:49 AM

Apr 11 2021

vmaffione added a comment to D29677: netmap: Use device_t in preference to struct device *.

Usage of "struct device *" was just wrong. Thanks spotting the issue.
Commit 70275a6735df8a514f48be77418491f2f8dba817 should have the same effect.

Apr 11 2021, 9:15 PM

Apr 10 2021

vmaffione retitled D29697: remove IFNET_RLOCK() that collides CTX_LOCK() in iflib_netmap_register from remove no ifnet_lock that collides CTX_LOCK in iflib_netmap_register to remove IFNET_RLOCK() that collides CTX_LOCK() in iflib_netmap_register.
Apr 10 2021, 7:59 PM
vmaffione requested review of D29697: remove IFNET_RLOCK() that collides CTX_LOCK() in iflib_netmap_register.
Apr 10 2021, 7:50 PM

Apr 9 2021

vmaffione committed rG172c5eb272df: netmap: vtnet: remove unused variable (authored by vmaffione).
netmap: vtnet: remove unused variable
Apr 9 2021, 7:35 PM

Apr 7 2021

vmaffione committed rG15dc713ceb57: netmap: vtnet: add support for netmap offsets (authored by vmaffione).
netmap: vtnet: add support for netmap offsets
Apr 7 2021, 9:44 PM