Differential D38062

netmap: Fix a queue length check in the generic port rx path
ClosedPublic
Actions

Authored by markj on Jan 15 2023, 5:03 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jun 12, 11:13 AM

	Unknown Object (File)
	Thu, Jun 11, 8:05 PM

	Unknown Object (File)
	Thu, May 28, 7:59 PM

	Unknown Object (File)
	Tue, May 19, 6:15 PM

	Unknown Object (File)
	Tue, May 19, 2:09 PM

	Unknown Object (File)
	Tue, May 19, 12:01 PM

	Unknown Object (File)
	May 17 2026, 4:24 PM

	Unknown Object (File)
	May 17 2026, 4:20 PM

Subscribers

Details

Reviewers

Commits

rG1a57779234d4: netmap: Fix a queue length check in the generic port rx path
rG539437c8281d: netmap: Fix a queue length check in the generic port rx path

Summary

The check is ok by default, since the default value of
netmap_generic_ringsize is 1024. But we should check against the
configured "ring" size.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jan 15 2023, 5:03 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 15 2023, 5:03 PM

markj requested review of this revision.Jan 15 2023, 5:03 PM

Harbormaster completed remote builds in B49114: Diff 115153.Jan 15 2023, 5:03 PM

markj added a parent revision: D38061: netmap: Tell the compiler to avoid reloading ring indices.Jan 15 2023, 5:03 PM

markj added a child revision: D38063: netmap: Correct a comment.

vmaffione accepted this revision.Jan 16 2023, 8:50 PM

This revision is now accepted and ready to land.Jan 16 2023, 8:50 PM

Closed by commit rG539437c8281d: netmap: Fix a queue length check in the generic port rx path (authored by markj). · Explain WhyJan 23 2023, 7:53 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG539437c8281d: netmap: Fix a queue length check in the generic port rx path.

markj added a commit: rG1a57779234d4: netmap: Fix a queue length check in the generic port rx path.Feb 1 2023, 5:32 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

netmap/

netmap_generic.c

2 lines

Diff 115466

sys/dev/netmap/netmap_generic.c

Loading...