Page MenuHomeFreeBSD

rmoeller (Ryan Moeller)
Systems Engineer II @ Klara, Inc.

Projects (1)

User Details

User Since
Jul 22 2016, 2:56 AM (539 w, 2 d)

Recent Activity

Yesterday

rmoeller accepted D61849: zfsbootcfg: fix some error handling bugs in setting/deleting keys.
Sat, Nov 21, 5:16 AM

Sat, Nov 14

rmoeller updated the diff for D61578: netmap: Check buf size before intercepting traffic.
  • Removed FreeBSD-specific comment; motivation for defining a max need not be prescribed
Sat, Nov 14, 6:46 PM
rmoeller added a comment to D61578: netmap: Check buf size before intercepting traffic.

In the previous change where I added this check, I was trying to avoid adding a FreeBSD ifdef in the generic code. But after adding the NM_GENERIC_MAX_BUF_SIZE definition, that works nicely as a platform-agnostic opt-in mechanism.

Sat, Nov 14, 6:43 PM
rmoeller requested review of D61579: netmap: Don't destroy uninitialized tx_event_lock.
Sat, Nov 14, 6:36 PM
rmoeller requested review of D61578: netmap: Check buf size before intercepting traffic.
Sat, Nov 14, 6:36 PM
rmoeller committed rG70046933082e: libutil: Introduce fhexdump(3).
Sat, Nov 14, 2:31 PM
rmoeller committed rG8bb34ce5c9f6: liblua: Accept + and e in io.popen mode.
Sat, Nov 14, 2:31 PM
rmoeller committed rG926a8baff0e1: netmap: Handle TX buffers larger than MCLBYTES.
Sat, Nov 14, 2:31 PM
rmoeller committed rG3e297e9e5532: libifconfig: Fix SFP table generators for Lua 5.5.
Sat, Nov 14, 2:31 PM
rmoeller closed D61177: libutil: Introduce fhexdump(3).
Sat, Nov 14, 2:31 PM
rmoeller closed D61281: netmap: Handle TX buffers larger than MCLBYTES.
Sat, Nov 14, 2:31 PM
rmoeller committed rGa6b57c401a61: lua: Prune unused luaconf.h copies.
Sat, Nov 14, 2:31 PM
rmoeller closed D61455: libifconfig: Fix SFP table generators for Lua 5.5.
Sat, Nov 14, 2:31 PM
rmoeller closed D61175: liblua: Accept + and e in io.popen mode.
Sat, Nov 14, 2:31 PM
rmoeller closed D61456: Prune unused luaconf.h copies.
Sat, Nov 14, 2:30 PM
rmoeller closed D61528: MFC: Fix direct reads of blocks pending free.
Sat, Nov 14, 4:47 AM
rmoeller committed rGafc7fc2abe80: Fix direct reads of blocks pending free (authored by Wale Zhang <wale.zhang.ftd@gmail.com>).
Sat, Nov 14, 4:47 AM
rmoeller closed D61527: MFC: dbuf: restore BP_IS_HOLE() recheck after dnode_block_freed().
Sat, Nov 14, 4:47 AM
rmoeller committed rG78ca640f79c5: dbuf: restore BP_IS_HOLE() recheck after dnode_block_freed() (authored by Cyrille C. <18537428+CrochetFeve0251@users.noreply.github.com>).
Sat, Nov 14, 4:47 AM
rmoeller committed rGfdd6b206a303: Fix double free when cloning a block with a pending free (authored by Patrick Domack <patrickdk@patrickdk.com>).
Sat, Nov 14, 4:47 AM
rmoeller closed D61526: MFC: Fix double free when cloning a block with a pending free.
Sat, Nov 14, 4:47 AM
rmoeller requested review of D61529: vmm: Fix double free with devmem_create_cdev error.
Sat, Nov 14, 3:23 AM
rmoeller retitled D61526: MFC: Fix double free when cloning a block with a pending free from Fix double free when cloning a block with a pending free
Sat, Nov 14, 3:19 AM
rmoeller retitled D61527: MFC: dbuf: restore BP_IS_HOLE() recheck after dnode_block_freed() from dbuf: restore BP_IS_HOLE() recheck after dnode_block_freed()
Sat, Nov 14, 3:19 AM
rmoeller retitled D61528: MFC: Fix direct reads of blocks pending free from Fix direct reads of blocks pending free
Sat, Nov 14, 3:18 AM
rmoeller added a comment to D61528: MFC: Fix direct reads of blocks pending free.

MFC 3/3 in stack of errata candidates.

Sat, Nov 14, 3:17 AM
rmoeller added a comment to D61527: MFC: dbuf: restore BP_IS_HOLE() recheck after dnode_block_freed().

This is 2/3 in a stack of errata candidates for stable/15.

Sat, Nov 14, 3:16 AM
rmoeller added a comment to D61527: MFC: dbuf: restore BP_IS_HOLE() recheck after dnode_block_freed().

Note: I've adjusted the Fixes: label from the original commit message to refer to the stable/15 commit here.

Sat, Nov 14, 3:15 AM
rmoeller added a comment to D61526: MFC: Fix double free when cloning a block with a pending free.

This is the first of three commits in the stack. These are errata candidates.

Sat, Nov 14, 3:14 AM
rmoeller requested review of D61528: MFC: Fix direct reads of blocks pending free.
Sat, Nov 14, 3:12 AM
rmoeller requested review of D61527: MFC: dbuf: restore BP_IS_HOLE() recheck after dnode_block_freed().
Sat, Nov 14, 3:12 AM
rmoeller requested review of D61526: MFC: Fix double free when cloning a block with a pending free.
Sat, Nov 14, 3:12 AM

Thu, Nov 12

rmoeller requested review of D61456: Prune unused luaconf.h copies.
Thu, Nov 12, 6:35 AM
rmoeller abandoned D61176: libifconfig: Make unpacked variables local.

I didn't look at quite enough context and missed that the variables are already declared above the loop and used further down below it. I created a new diff, since git-arc didn't want to update this one.
D61455

Thu, Nov 12, 6:21 AM
rmoeller requested review of D61455: libifconfig: Fix SFP table generators for Lua 5.5.
Thu, Nov 12, 6:16 AM

Wed, Nov 11

rmoeller updated the diff for D61177: libutil: Introduce fhexdump(3).
  • Dropped unneeded __restrict
Wed, Nov 11, 7:28 AM
rmoeller added inline comments to D61177: libutil: Introduce fhexdump(3).
Wed, Nov 11, 7:14 AM

Mon, Nov 9

rmoeller updated the diff for D61281: netmap: Handle TX buffers larger than MCLBYTES.

Addressed feedback:

  • Use a more specific macro name for the max mbuf size for emulation
Mon, Nov 9, 11:00 PM
rmoeller added a comment to D61281: netmap: Handle TX buffers larger than MCLBYTES.

I've used uint32_t to match the type of the ext_size and objsize fields the values come from.

Mon, Nov 9, 3:35 PM
rmoeller updated the diff for D61281: netmap: Handle TX buffers larger than MCLBYTES.

Incorporated feedback:

  • Make size unsigned in nm_os_mbuf_reinit()
Mon, Nov 9, 3:32 PM
rmoeller updated the diff for D61281: netmap: Handle TX buffers larger than MCLBYTES.

Incorporated feedback:

  • Make nm_os_get_mbuf() take a uint32_t size, matching the type of the field passed to it.
  • Define and use NETMAP_MAX_BUF_SIZE
Mon, Nov 9, 3:29 PM

Sat, Nov 7

rmoeller requested review of D61281: netmap: Handle TX buffers larger than MCLBYTES.
Sat, Nov 7, 5:53 AM

Wed, Nov 4

rmoeller accepted D60954: linux(4): compare xattr namespace names with strcmp().

Small nit: the code after looks to be easily simplified by using strlcpy() in place of strlen() + bcopy() while here.

Wed, Nov 4, 6:11 PM
rmoeller accepted D61145: loader: Handle unavailable VBE during mode lookup.
Wed, Nov 4, 4:46 PM
rmoeller added a comment to D61145: loader: Handle unavailable VBE during mode lookup.

The added null check is in very deep and we should probably not be getting so far into VBE code with no VBE support. This seems it should instead be guarded using vbe_check() early in vbe_default_mode() as is done in other public functions here.

Wed, Nov 4, 9:26 AM
rmoeller requested review of D61177: libutil: Introduce fhexdump(3).
Wed, Nov 4, 6:13 AM
rmoeller requested review of D61176: libifconfig: Make unpacked variables local.
Wed, Nov 4, 6:00 AM
rmoeller added a comment to D61175: liblua: Accept + and e in io.popen mode.

A question this brought up while looking into it: the lib/liblua/luaconf.h file seems stale and unused, and I wonder if it is similar for stand/liblua/luaconf.h? The build seems to be using contrib/lua/src/luaconf.h, which is the copy that actually includes this lib/liblua/luaconf.local.h file.

Wed, Nov 4, 5:53 AM
rmoeller added a comment to D61175: liblua: Accept + and e in io.popen mode.

As an example of where this can be useful, it enables io.popen() to invoke a command with a bidirectional pipe by passing "r+" or "r+e" as the mode. My use case is for wrapping "cxgbetool stdio" to

Wed, Nov 4, 5:44 AM
rmoeller requested review of D61175: liblua: Accept + and e in io.popen mode.
Wed, Nov 4, 5:33 AM

Oct 13 2026

rmoeller committed rGa3c57739ca07: lib/libifconfig: Fix pointer-sign warnings.
Oct 13 2026, 4:44 PM
rmoeller committed rG33d9fbf5f953: linuxulator: Accept 0 as signal in rt_sigqueueinfo.
Oct 13 2026, 4:44 PM
rmoeller closed D60573: lib/libifconfig: Fix pointer-sign warnings.
Oct 13 2026, 4:44 PM
rmoeller closed D60574: linuxulator: Accept 0 as signal in rt_sigqueueinfo.
Oct 13 2026, 4:44 PM
rmoeller committed rG8fdf03cd3613: committers-src: Add rmoeller mentored by kevans@.
Oct 13 2026, 4:34 PM
rmoeller committed rGe3d7a9b5ed5f: mailmap: Add mappings for rmoeller.
Oct 13 2026, 4:34 PM

Oct 10 2026

rmoeller added inline comments to D60574: linuxulator: Accept 0 as signal in rt_sigqueueinfo.
Oct 10 2026, 3:12 AM
rmoeller added a comment to D60574: linuxulator: Accept 0 as signal in rt_sigqueueinfo.

With this change I can run zdb (and other libzpool-based tooling) compiled for Linux under Linuxulator.

Oct 10 2026, 3:10 AM
rmoeller requested review of D60574: linuxulator: Accept 0 as signal in rt_sigqueueinfo.
Oct 10 2026, 3:07 AM
rmoeller added a comment to D60573: lib/libifconfig: Fix pointer-sign warnings.

The added commit is related, though Phabricator does not make that clear.

Oct 10 2026, 3:01 AM
rmoeller requested review of D60573: lib/libifconfig: Fix pointer-sign warnings.
Oct 10 2026, 2:55 AM

Oct 9 2026

rmoeller updated rmoeller.
Oct 9 2026, 1:35 PM
pi renamed rmoeller.
Oct 9 2026, 1:29 PM

Oct 7 2026

rmoeller added inline comments to D40274: flua: Add libfetch functionality.
Oct 7 2026, 3:18 PM
rmoeller added a comment to D40274: flua: Add libfetch functionality.

libfetch has fetchLastErrString and fetchLastErrCode you can use to return more specific error information than errno provides.

Oct 7 2026, 2:46 PM
rmoeller created P721 flua REST API client for PDU.
Oct 7 2026, 1:43 PM

Feb 8 2023

rmoeller committed R11:58702524d472: sysutils/openzfs: Fix zilstat installation.
Feb 8 2023, 12:12 AM

Feb 7 2023

rmoeller committed R11:723f83e80dd2: sysutils/openzfs*: Minor port housekeeping.
Feb 7 2023, 11:16 PM
rmoeller committed R11:119910278a16: devel/py-libzfs: Fix build on 12 and main.
Feb 7 2023, 10:23 PM

Feb 2 2023

rmoeller committed R11:33af83813501: devel/py-libzfs: Update to fix build.
Feb 2 2023, 3:41 PM
rmoeller committed R11:1ebc65476340: sysutils/openzfs*: Update to latest master.
Feb 2 2023, 3:35 PM

Sep 12 2022

rmoeller added a comment to P547 Remove local snapshots_changed property value.

If snapshots_changed property has local source for a filesystem or volume, this kernel patch will remove it after a snapshot is created or destroyed on that dataset. To list the affected datasets:

Sep 12 2022, 9:20 AM
rmoeller created P547 Remove local snapshots_changed property value.
Sep 12 2022, 9:12 AM

Aug 30 2022

rmoeller committed R11:177cee944033: sysutils/openzfs*: Update to latest master.
Aug 30 2022, 4:45 PM

Aug 20 2022

rmoeller added inline comments to D36270: bhyve virtio-scsi: Tidy warning and debug prints..
Aug 20 2022, 1:09 PM

Aug 17 2022

rmoeller accepted D36233: Drop support for FreeBSD 13.0 from the Ports Tree once it goes EOL in September..
Aug 17 2022, 1:10 AM

Aug 16 2022

rmoeller committed R11:ffdaee554e12: devel/py-libzfs: Unbreak FreeBSD <13.1.
Aug 16 2022, 4:23 PM
rmoeller committed R11:19c3e861b768: devel/py-libzfs: Unbreak FreeBSD <13.1.
Aug 16 2022, 11:11 AM

Jul 19 2022

rmoeller committed R11:51e0dba74499: devel/py-libzfs: Bump for recent changes.
Jul 19 2022, 2:33 PM

Jun 27 2022

rmoeller added a comment to D35610: zfs: only define B_FALSE/B_TRUE if NEED_SOLARIS_BOOLEAN is not set.

Would you mind opening a PR at https://github.com/openzfs/zfs for this?

Jun 27 2022, 3:20 PM
rmoeller accepted D35610: zfs: only define B_FALSE/B_TRUE if NEED_SOLARIS_BOOLEAN is not set.
Jun 27 2022, 3:02 PM

Jun 9 2022

rmoeller committed R11:5903d483038d: devel/py-libzfs: Bump to fix the build.
Jun 9 2022, 8:48 PM

Jun 1 2022

rmoeller committed R11:e9ff25cf63e7: sysutils/openzfs*: Bump to fix build.
Jun 1 2022, 1:15 PM

May 25 2022

rmoeller added a comment to D35241: sysutils/openzfs-kmod: Quiet -Wunused-but-set-variable warnings..

Thanks for the patch. The fse and zstd warnings have been fixed in OpenZFS master already and I have just opened a pull request to fix the dnode warning. That way we can avoid patching. I will update the port when that goes in.

May 25 2022, 3:56 PM

Apr 4 2022

rmoeller committed R11:cb431e11bc50: sysutils/openzfs*: Bump to fix build on main.
Apr 4 2022, 3:50 PM

Mar 9 2022

rmoeller committed rG2ea6414ed8bb: zfs: Fix typo in module Makefile.
Mar 9 2022, 6:21 PM

Feb 14 2022

rmoeller committed R11:f3f4f5e80565: sysutils/openzfs*: Bump to current upstream master.
Feb 14 2022, 5:59 PM
rmoeller committed R11:546ae71b9052: devel/py-libzfs: Fix various memory leaks.
Feb 14 2022, 4:36 PM

Jan 28 2022

rmoeller committed rG51ce77b26157: bhyve: ahci: Fix regression with no ports.
Jan 28 2022, 2:34 PM

Jan 26 2022

rmoeller committed rG47e46b1123b9: zfs: Fix zvol_cdev_open locking.
Jan 26 2022, 6:39 PM

Jan 21 2022

rmoeller committed rGb252fb24301c: bhyve: ahci: Fix regression with no ports.
Jan 21 2022, 1:01 PM
rmoeller closed D33969: bhyve: ahci: Fix regression with no ports.
Jan 21 2022, 1:00 PM

Jan 20 2022

rmoeller requested review of D33969: bhyve: ahci: Fix regression with no ports.
Jan 20 2022, 6:43 PM

Dec 30 2021

rmoeller accepted D33692: sysutils/openzfs: fix build errors.
Dec 30 2021, 6:53 PM
rmoeller added inline comments to D33692: sysutils/openzfs: fix build errors.
Dec 30 2021, 6:13 PM

Dec 15 2021

rmoeller committed R11:26e680dffa8a: sysutils/openzfs*: Sync up to fix the build.
Dec 15 2021, 7:13 PM

Nov 16 2021

rmoeller added a comment to D32993: Fix mountd parsing of user/group info in /etc/exports.

@rmacklem is it ok if we make parsecred return an int so we can fail to start when the creds are invalid? It feels wrong to merely log an error message and keep going when this is misconfigured.

Nov 16 2021, 6:47 PM
rmoeller added inline comments to D32993: Fix mountd parsing of user/group info in /etc/exports.
Nov 16 2021, 6:08 PM
rmoeller added inline comments to D32993: Fix mountd parsing of user/group info in /etc/exports.
Nov 16 2021, 5:28 PM
rmoeller added inline comments to D32993: Fix mountd parsing of user/group info in /etc/exports.
Nov 16 2021, 5:24 PM