bhyve: ahci: Fix regression with no ports
ClosedPublic
Actions

Authored by freqlabs on Jan 20 2022, 6:42 PM.

Details

Reviewers

jhb
khng

Group Reviewers

bhyve

Commits

rG51ce77b26157: bhyve: ahci: Fix regression with no ports
rGb252fb24301c: bhyve: ahci: Fix regression with no ports

Summary

An AHCI controller may be specified with no connected ports. Avoid
dumping core in this case for compatibility with existing VM configs.

Fixes: 621b5090487de Refactor configuration management in bhyve.
MFC after: 1 week
Sponsored by: iXsystems, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

freqlabs created this revision.Jan 20 2022, 6:42 PM

Herald added a reviewer: bhyve. · View Herald TranscriptJan 20 2022, 6:42 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

freqlabs requested review of this revision.Jan 20 2022, 6:42 PM

Harbormaster completed remote builds in B44015: Diff 101695.Jan 20 2022, 6:43 PM

khng accepted this revision.Jan 20 2022, 7:06 PM

This revision is now accepted and ready to land.Jan 20 2022, 7:06 PM

jhb accepted this revision.Jan 20 2022, 7:33 PM

Closed by commit rGb252fb24301c: bhyve: ahci: Fix regression with no ports (authored by freqlabs). · Explain WhyJan 21 2022, 1:00 PM

This revision was automatically updated to reflect the committed changes.

freqlabs added a commit: rGb252fb24301c: bhyve: ahci: Fix regression with no ports.

freqlabs added a commit: rG51ce77b26157: bhyve: ahci: Fix regression with no ports.Jan 28 2022, 2:33 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_ahci.c

2 lines

Diff 101742

View Options

bhyve: ahci: Fix regression with no portsClosedPublicActions