Page MenuHomeFreeBSD

khng (Ka Ho Ng)
User

Projects

User Details

User Since
Jun 12 2018, 3:15 AM (148 w, 4 d)

Recent Activity

Yesterday

khng updated the diff for D28833: Implement posix_fallocate(2) by fo_fspacectl..

Compilation fixes after rebase

Fri, Apr 16, 5:36 AM

Thu, Apr 15

khng updated the diff for D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..
  • A leftover manpage fix
Thu, Apr 15, 6:50 PM
khng updated the diff for D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..
  • Manpage clarifications and fixes
  • Code cosmetic fixes
  • Removed a stray #include "sys/fcntl.h"
Thu, Apr 15, 6:45 PM
khng added inline comments to D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..
Thu, Apr 15, 5:14 PM
khng added inline comments to D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..
Thu, Apr 15, 5:11 PM
khng added a reviewer for D29770: sndstat: nvlist schema and API definition changes: philip.
Thu, Apr 15, 9:47 AM
khng updated the diff for D28833: Implement posix_fallocate(2) by fo_fspacectl..

manpage fixes.

Thu, Apr 15, 9:32 AM
khng updated the diff for D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..

manpage fixes.

Thu, Apr 15, 9:32 AM
khng updated the diff for D29770: sndstat: nvlist schema and API definition changes.

manpage fixes.

Thu, Apr 15, 9:26 AM
khng added a reviewer for D29770: sndstat: nvlist schema and API definition changes: hselasky.
Thu, Apr 15, 9:11 AM
khng requested review of D29770: sndstat: nvlist schema and API definition changes.
Thu, Apr 15, 9:10 AM

Mon, Apr 12

khng closed D29601: devel/ccls: Update to 0.20210330.
Mon, Apr 12, 6:00 PM

Sun, Apr 11

khng requested review of D29708: bhyve: Add virtio modern support handling.
Sun, Apr 11, 5:03 PM
khng committed R10:b77f5f5553e8: vnode_pager_setsize.9: Some clarifications on the manpage (authored by khng).
vnode_pager_setsize.9: Some clarifications on the manpage
Sun, Apr 11, 6:48 AM
khng closed D29637: vnode_pager_setsize.9: Some clarifications on the manpage.
Sun, Apr 11, 6:48 AM

Thu, Apr 8

khng added a reviewer for D29637: vnode_pager_setsize.9: Some clarifications on the manpage: philip.
Thu, Apr 8, 11:54 PM
khng updated the diff for D29637: vnode_pager_setsize.9: Some clarifications on the manpage.

Wording.

Thu, Apr 8, 10:21 PM
khng updated the diff for D29637: vnode_pager_setsize.9: Some clarifications on the manpage.

Wording around page fault behavior.

Thu, Apr 8, 9:52 PM
khng updated the diff for D29637: vnode_pager_setsize.9: Some clarifications on the manpage.

Updated. Document the behavior around page faults as well.

Thu, Apr 8, 9:50 PM
khng updated the diff for D29637: vnode_pager_setsize.9: Some clarifications on the manpage.

Updates.

Thu, Apr 8, 7:23 PM
khng updated the diff for D29637: vnode_pager_setsize.9: Some clarifications on the manpage.

.Dd updates and add document the direction from old EOF to new EOF as well.

Thu, Apr 8, 7:44 AM
khng requested review of D29637: vnode_pager_setsize.9: Some clarifications on the manpage.
Thu, Apr 8, 7:38 AM

Wed, Apr 7

khng committed R10:86a52e262a6f: Document vnode_pager_setsize(9) (authored by khng).
Document vnode_pager_setsize(9)
Wed, Apr 7, 11:13 AM
khng closed D29408: Document vnode_pager_setsize(9).
Wed, Apr 7, 11:13 AM
khng committed R10:9d7eb557c157: AMD-vi: Mixed format IVHD block should replace fixed format IVHD block (authored by khng).
AMD-vi: Mixed format IVHD block should replace fixed format IVHD block
Wed, Apr 7, 10:57 AM
khng committed R10:1bbe0448e47f: AMD-vi: Fix mismatched NULL checking in amdiommu teardown path (authored by khng).
AMD-vi: Fix mismatched NULL checking in amdiommu teardown path
Wed, Apr 7, 10:57 AM
khng committed R10:d7ffa208d929: AMD-vi: Fix IOMMU device interrupts being overridden (authored by khng).
AMD-vi: Fix IOMMU device interrupts being overridden
Wed, Apr 7, 10:57 AM
khng committed R10:c5345a05ce7d: ivrs_drv: Fix IVHDs with duplicated BaseAddress (authored by khng).
ivrs_drv: Fix IVHDs with duplicated BaseAddress
Wed, Apr 7, 10:56 AM

Tue, Apr 6

khng added a reviewer for D29408: Document vnode_pager_setsize(9): lwhsu.
Tue, Apr 6, 1:07 PM
khng updated the diff for D29408: Document vnode_pager_setsize(9).

bcr@'s suggestion: rewording document description

Tue, Apr 6, 12:13 PM
khng added a comment to D29408: Document vnode_pager_setsize(9).
In D29408#663654, @bcr wrote:

OK, I only have one textual suggestion. Did you check the man page with "mandoc -Tlint" and textproc/igor?

Tue, Apr 6, 12:09 PM
khng added inline comments to D29601: devel/ccls: Update to 0.20210330.
Tue, Apr 6, 11:03 AM
khng updated the summary of D29601: devel/ccls: Update to 0.20210330.
Tue, Apr 6, 10:54 AM
khng requested review of D29601: devel/ccls: Update to 0.20210330.
Tue, Apr 6, 10:52 AM

Sat, Apr 3

khng committed R10:2e107638eac2: virtio_pci_legacy: Allow memory space for configuration (authored by khng).
virtio_pci_legacy: Allow memory space for configuration
Sat, Apr 3, 6:21 AM
khng committed R10:98740ead97c6: virtio_pci_legacy: Use the table BAR and PBA BAR from MSI-X cap (authored by khng).
virtio_pci_legacy: Use the table BAR and PBA BAR from MSI-X cap
Sat, Apr 3, 6:21 AM

Thu, Apr 1

khng committed R10:03efa462b2ab: AMD-vi: Mixed format IVHD block should replace fixed format IVHD block (authored by khng).
AMD-vi: Mixed format IVHD block should replace fixed format IVHD block
Thu, Apr 1, 7:32 AM
khng closed D29521: AMD-vi: Mixed format IVHD block should replace fixed format IVHD block.
Thu, Apr 1, 7:32 AM
khng added a reviewer for D29525: AMD-vi: Fortify IVHD device_identify process: philip.
Thu, Apr 1, 12:14 AM
khng requested review of D29525: AMD-vi: Fortify IVHD device_identify process.
Thu, Apr 1, 12:14 AM

Wed, Mar 31

khng added a reviewer for D29521: AMD-vi: Mixed format IVHD block should replace fixed format IVHD block: philip.
Wed, Mar 31, 10:25 PM
khng requested review of D29521: AMD-vi: Mixed format IVHD block should replace fixed format IVHD block.
Wed, Mar 31, 10:10 PM
khng committed R10:cf76495e0a30: AMD-vi: Fix mismatched NULL checking in amdiommu teardown path (authored by khng).
AMD-vi: Fix mismatched NULL checking in amdiommu teardown path
Wed, Mar 31, 7:41 PM

Tue, Mar 30

khng committed R10:b013912772ec: bhyve: change vq_getchain to return iovecs in both directions (authored by khng).
bhyve: change vq_getchain to return iovecs in both directions
Tue, Mar 30, 8:48 AM
khng closed D29433: bhyve: change vq_getchain to return iovecs in both directions.
Tue, Mar 30, 8:48 AM
khng updated the diff for D29433: bhyve: change vq_getchain to return iovecs in both directions.

Style.

Tue, Mar 30, 2:19 AM

Mon, Mar 29

khng added a comment to D29433: bhyve: change vq_getchain to return iovecs in both directions.

@afedorov I would like to have some comments on this again.

Mon, Mar 29, 6:02 PM
khng updated the diff for D29433: bhyve: change vq_getchain to return iovecs in both directions.

Refactor the prototype to match vq_ring_enqueue_segments in sys/dev/virtio/virtqueue.c.

Mon, Mar 29, 5:59 PM
khng retitled D29433: bhyve: change vq_getchain to return iovecs in both directions from bhyve: vq_getchain returns read iovecs and write iovecs to bhyve: change vq_getchain to return iovecs in both directions.
Mon, Mar 29, 5:58 PM

Sun, Mar 28

khng updated the summary of D29433: bhyve: change vq_getchain to return iovecs in both directions.
Sun, Mar 28, 3:58 PM
khng added a reviewer for D29433: bhyve: change vq_getchain to return iovecs in both directions: lwhsu.
Sun, Mar 28, 9:02 AM
khng added a reviewer for D29433: bhyve: change vq_getchain to return iovecs in both directions: philip.
Sun, Mar 28, 9:00 AM

Sat, Mar 27

khng updated the diff for D29433: bhyve: change vq_getchain to return iovecs in both directions.
  • Remove unused flags from pci_vt9p_notify
Sat, Mar 27, 8:33 AM

Fri, Mar 26

khng updated the diff for D29433: bhyve: change vq_getchain to return iovecs in both directions.
  • Fixed loopy check fallout out when num of descs are equal to maximum number
  • No need to use memset in vq_getchain
Fri, Mar 26, 5:45 PM
khng requested review of D29433: bhyve: change vq_getchain to return iovecs in both directions.
Fri, Mar 26, 5:25 PM
khng committed R10:7590d7800c44: bhyve: support relocating fbuf and passthru data BARs (authored by scottph).
bhyve: support relocating fbuf and passthru data BARs
Fri, Mar 26, 1:53 PM
khng committed R10:c4a34bb3f823: bhyve amd: Small cleanups in amdvi_dump_cmds (authored by khng).
bhyve amd: Small cleanups in amdvi_dump_cmds
Fri, Mar 26, 1:53 PM

Thu, Mar 25

khng added a comment to D29413: audio/virtual_oss: Add sndstat(4) support.

Approved by: philip (mentor)

But just wondering: how does this software behave when it is built on a system where sndstat.h is available but subsequently run on a system where it is not? i.e. what happens if we build a binary package on a new package builder and install the package on an older (but still supported) version of FreeBSD?

Thu, Mar 25, 4:53 AM

Wed, Mar 24

khng added a reviewer for D29413: audio/virtual_oss: Add sndstat(4) support: philip.
Wed, Mar 24, 4:44 PM
khng added a reviewer for D29413: audio/virtual_oss: Add sndstat(4) support: hselasky.
Wed, Mar 24, 3:58 PM
khng requested review of D29413: audio/virtual_oss: Add sndstat(4) support.
Wed, Mar 24, 3:58 PM
khng updated the diff for D29408: Document vnode_pager_setsize(9).

Xr VOP_SETATTR 9 -> .Xr VOP_SETATTR 9

Wed, Mar 24, 10:38 AM
khng planned changes to D29408: Document vnode_pager_setsize(9).
Wed, Mar 24, 10:37 AM
khng requested review of D29408: Document vnode_pager_setsize(9).
Wed, Mar 24, 10:33 AM
khng updated the diff for D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..

Fix copyright notices

Wed, Mar 24, 10:18 AM
khng updated the diff for D27194: Add vnode_pager_purge_range(9) KPI.

Manual: fix missing includes

Wed, Mar 24, 10:18 AM

Tue, Mar 23

khng updated the diff for D28899: md: Replace BIO_DELETE emulation with vn_deallocate(9).

Updated commit message.

Tue, Mar 23, 10:14 AM
khng updated the diff for D28880: bhyve: Use fspacectl(2) for BOP_DELETE on regular file images.

Updated commit message.

Tue, Mar 23, 10:13 AM
khng updated the diff for D28833: Implement posix_fallocate(2) by fo_fspacectl..

Moved the following into this revision:

	/* Translate to posix_fallocate(2) return value as needed. */
	if (error == ENOMEM)
		error = ENOSPC;
Tue, Mar 23, 10:13 AM
khng updated the diff for D28834: Wire up OpenZFS with VOP_DEALLOCATE(9).

Updated commit message.

Tue, Mar 23, 10:12 AM
khng updated the diff for D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..
  • Move them to D28833.
  • shm_deallocate: kill int error;. Just directly return (0).
Tue, Mar 23, 10:12 AM
khng updated the diff for D27194: Add vnode_pager_purge_range(9) KPI.

Updated commit message.

Tue, Mar 23, 10:11 AM
khng closed D28862: bhyve amd: Small cleanups in amdvi_dump_cmds.
Tue, Mar 23, 8:13 AM
khng committed R10:be97fc8dced0: bhyve amd: Small cleanups in amdvi_dump_cmds (authored by khng).
bhyve amd: Small cleanups in amdvi_dump_cmds
Tue, Mar 23, 8:13 AM

Mon, Mar 22

khng added a comment to D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..
In D28347#657998, @khng wrote:

For Linux's fallocate(), we currently do not have an equivalent of linux's fallocate(2)
either. In particular I do not quite like it putting FALLOC_FL_PUNCH_HOLE as a flag
despite it is actually one of the major function.

Mon, Mar 22, 7:51 PM
khng added a comment to D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..

Sorry I'm late to the party, but I have a few questions:

  1. Why a new syscall? There are already at least three APIs for hole-punching. Instead of adding a fourth, can we just reuse one of these existing APIs?
    • Solaris uses fcntl() with F_FREESP. AFAIK it was the first major operating system to support hole punching.
    • Linux uses fallocate() with FALLOC_FL_PUNCH_HOLE.
    • GEOM uses ioctl() with DIOCGDELETE.
Mon, Mar 22, 7:33 PM
khng added a reviewer for D28862: bhyve amd: Small cleanups in amdvi_dump_cmds: philip.
Mon, Mar 22, 6:56 PM
khng added inline comments to D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..
Mon, Mar 22, 6:18 PM
khng added inline comments to D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..
Mon, Mar 22, 6:15 PM
khng updated the summary of D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..
Mon, Mar 22, 6:12 PM
khng added a reviewer for D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9).: asomers.
Mon, Mar 22, 6:10 PM
khng committed R10:74ada297e897: AMD-vi: Fix IOMMU device interrupts being overridden (authored by khng).
AMD-vi: Fix IOMMU device interrupts being overridden
Mon, Mar 22, 9:35 AM
khng closed D28984: AMD-vi: Fix IOMMU device interrupts being overridden.
Mon, Mar 22, 9:34 AM
khng closed D28945: ivrs_drv: Fix IVHDs with duplicated BaseAddress.
Mon, Mar 22, 9:34 AM
khng committed R10:ede14736fd6d: ivrs_drv: Fix IVHDs with duplicated BaseAddress (authored by khng).
ivrs_drv: Fix IVHDs with duplicated BaseAddress
Mon, Mar 22, 9:34 AM
khng updated the diff for D28984: AMD-vi: Fix IOMMU device interrupts being overridden.

Nit

Mon, Mar 22, 7:34 AM
khng added inline comments to D28984: AMD-vi: Fix IOMMU device interrupts being overridden.
Mon, Mar 22, 7:32 AM

Sun, Mar 21

khng added a reviewer for D28984: AMD-vi: Fix IOMMU device interrupts being overridden: philip.
Sun, Mar 21, 6:30 PM
khng added a reviewer for D28945: ivrs_drv: Fix IVHDs with duplicated BaseAddress: philip.
Sun, Mar 21, 6:29 PM

Sat, Mar 20

khng committed R10:cf5d1112408d: virtio_pci_legacy: Allow memory space for configuration (authored by khng).
virtio_pci_legacy: Allow memory space for configuration
Sat, Mar 20, 7:47 AM
khng committed R10:faf9a4e9142a: virtio_pci_legacy: Use the table BAR and PBA BAR from MSI-X cap (authored by khng).
virtio_pci_legacy: Use the table BAR and PBA BAR from MSI-X cap
Sat, Mar 20, 7:47 AM
khng closed D28818: virtio_pci_legacy: Allow memory space for configuration.
Sat, Mar 20, 7:46 AM
khng closed D28817: virtio_pci_legacy: Use the table BAR and PBA BAR from MSI-X cap.
Sat, Mar 20, 7:46 AM

Fri, Mar 19

khng added a comment to D26209: GVT-d support for bhyve.

I'm going to rebase this patch soon.

Fri, Mar 19, 1:12 PM · bhyve
khng updated the diff for D28899: md: Replace BIO_DELETE emulation with vn_deallocate(9).

Rebased

Fri, Mar 19, 8:44 AM
khng updated the diff for D28880: bhyve: Use fspacectl(2) for BOP_DELETE on regular file images.

Rebased

Fri, Mar 19, 8:41 AM
khng updated the diff for D28834: Wire up OpenZFS with VOP_DEALLOCATE(9).

Rebased.

Fri, Mar 19, 8:40 AM
khng added a reviewer for D28818: virtio_pci_legacy: Allow memory space for configuration: philip.
Fri, Mar 19, 6:02 AM
khng added a reviewer for D28817: virtio_pci_legacy: Use the table BAR and PBA BAR from MSI-X cap: philip.
Fri, Mar 19, 6:02 AM
khng closed D24066: bhyve: support relocating fbuf and passthru data BARs.
Fri, Mar 19, 3:07 AM · bhyve