In D46537#1061028, @markj wrote:

In D46537#1060924, @khng wrote:

Or, I might just do it the way like how other debugger does - not using elf_file but doing adjustments with only ELF parsing libraries rather.

As discussed elsewhere, I'd prefer to have libkvm walk the linker_files list and locate the corresponding binaries, like kgdb does. This way we avoid growing the kernel ABI.

Addressed.

By the way, given that rpcbind and nfsd will install a default pidfile to /var/run even without specifying -P: shall we document that somewhere in RELNOTES and the commit message, or do we make the errno == EEXIST case a warn() call instead of errx()? I am thinking of that because some people might spin up multiple nfsd in their setup without using the rc.d/nfsd script, and with different bound IP for each nfsd spun.

In D50624#1158182, @rmacklem wrote:

I'll leave the minor nits up to you.
Are you a committer or do you need me
to do it?

Add comments.

Add more sysctls.

Changed commit message.

@phil for a confirmation as well.

Separate SHT_INIT_ARRAY/SHT_FINI_ARRAY/SHT_X86_64_UNWIND out.

Remove duplicated fsanitize flags during module build

In D47383#1081811, @jhb wrote:

We can probably just do this all the time without needing the flag? I think kldxref just doesn't care, or more likely ef_object.c in kldxref wasn't updated when the kernel linker changed.

Addresses jhb@'s comments

Updated to adapt to NOSAN's introduction

Comments update.

Oops.

Fix per markj@'s comment. ef_print_phdr related part now is left unchanged for now.

Bootstrap it everytime, and remove the __FreeBSD_version bump as well given this library is private.

Remove include headers installation

Update commit message. If it is not reflected on Phabricator I will do it one more time.

In D46719#1066156, @markj wrote:

This is missing some description of libkldelf's intended functionality, either in the commit message or in a man page (maybe a man page is not required for private libraries). It's hard to tell at a glance what this library does, at least for me who is not familiar with kldxref internals.

I don't have any objection to the change itself, it seems fine and will be useful for debuggers and related tools. libdtrace might be able to take advantage of it as well, replacing some existing code.

Update Makefile.depend as well.