Page MenuHomeFreeBSD

khng (Ka Ho Ng)
User

Projects

User Details

User Since
Jun 12 2018, 3:15 AM (170 w, 6 d)

Recent Activity

Thu, Sep 16

khng added a comment to D31983: bhyve: Support setting the disk serial number for VirtIO block devices..

Since the "serial" taken from the configuration is directly copied to become the virtio-blk device's ident, should we call this "ident" simply? Looks good to me otherwise.

Thu, Sep 16, 4:43 PM

Tue, Sep 14

khng committed R10:49050613ef1f: ctl(4): Do hole-punching for UNMAP to file-backed LUNs (authored by khng).
ctl(4): Do hole-punching for UNMAP to file-backed LUNs
Tue, Sep 14, 7:53 PM
khng closed D31922: ctl(4): Do hole-punching for UNMAP to file-backed LUNs.
Tue, Sep 14, 7:52 PM

Mon, Sep 13

khng accepted D31946: posixshmtest: Fix various warnings raised by GCC..
Mon, Sep 13, 7:31 PM
khng updated the diff for D31922: ctl(4): Do hole-punching for UNMAP to file-backed LUNs.

Thanks mav@ for pointing this mistake out.

Mon, Sep 13, 4:26 PM
khng added a reviewer for D31922: ctl(4): Do hole-punching for UNMAP to file-backed LUNs: mav.
Mon, Sep 13, 8:36 AM

Sun, Sep 12

khng committed R10:e31cc1d526dc: bhyve: Fix pci device node key in bhyve_config.5 (authored by khng).
bhyve: Fix pci device node key in bhyve_config.5
Sun, Sep 12, 8:36 PM
khng requested review of D31922: ctl(4): Do hole-punching for UNMAP to file-backed LUNs.
Sun, Sep 12, 7:17 PM

Sat, Sep 11

khng committed R10:3703c1888334: md: Add MD_MUSTDEALLOC support (authored by khng).
md: Add MD_MUSTDEALLOC support
Sat, Sep 11, 12:05 PM
khng closed D31883: md: Add MD_MUSTDEALLOC support.
Sat, Sep 11, 12:05 PM

Wed, Sep 8

khng updated the diff for D31883: md: Add MD_MUSTDEALLOC support.
  • MD_AUTOUNMAP -> MD_MUSTDEALLOC
  • Clarifications on behavior regarding with/without the flag
  • Sort the options over the code and manpage
Wed, Sep 8, 8:04 PM
khng retitled D31883: md: Add MD_MUSTDEALLOC support from md: Add MD_AUTOUNMAP support to md: Add MD_MUSTDEALLOC support.
Wed, Sep 8, 8:03 PM
khng added inline comments to D31883: md: Add MD_MUSTDEALLOC support.
Wed, Sep 8, 7:05 PM
khng updated the diff for D31883: md: Add MD_MUSTDEALLOC support.

markj@'s suggestion

Wed, Sep 8, 6:57 PM
khng requested review of D31883: md: Add MD_MUSTDEALLOC support.
Wed, Sep 8, 6:41 PM

Mon, Sep 6

khng accepted D31829: add a kernel flag for VOP_COPY_FILE_RANGE for return after 1second.
Mon, Sep 6, 6:37 AM

Sun, Sep 5

khng added a comment to D31829: add a kernel flag for VOP_COPY_FILE_RANGE for return after 1second.

Well, if you think there might be future uses of different
timeouts, the high order 8bits could be defined as the
timeout value (when non-zero) in 1/10seconds.
--> That would use up 8 of the 32bits, but since Linux

has not defined any flags yet, I think that's ok.

Even 1/10sec resolution isn't always going to be achieved.
I mentioned the case where the vn_rdwr() calls takes more than
one second.

Sun, Sep 5, 7:09 PM
khng added inline comments to D31829: add a kernel flag for VOP_COPY_FILE_RANGE for return after 1second.
Sun, Sep 5, 6:21 AM

Fri, Sep 3

khng requested review of D31828: man: Add vm_fault_quick_hold_pages(9) man page.
Fri, Sep 3, 8:11 PM
khng committed R10:0eb56e7496f6: vmm: Fix wrong assert in ivhd_dev_add_entry (authored by khng).
vmm: Fix wrong assert in ivhd_dev_add_entry
Fri, Sep 3, 7:08 PM
khng committed R10:db877a06ec41: vmm: Fix AMD-vi using wrong rid range (authored by khng).
vmm: Fix AMD-vi using wrong rid range
Fri, Sep 3, 7:08 PM
khng committed R10:da4e35def95a: vmm: Fix ivrs_drv device_printf usage (authored by khng).
vmm: Fix ivrs_drv device_printf usage
Fri, Sep 3, 7:08 PM
khng committed R10:f8b5f7426f0f: AMD-vi: Fortify IVHD device_identify process (authored by khng).
AMD-vi: Fortify IVHD device_identify process
Fri, Sep 3, 7:08 PM
khng committed R10:172cf62e0899: AMD-vi: Mixed format IVHD block should replace fixed format IVHD block (authored by khng).
AMD-vi: Mixed format IVHD block should replace fixed format IVHD block
Fri, Sep 3, 7:08 PM
khng committed R10:834f54457853: AMD-vi: Fix mismatched NULL checking in amdiommu teardown path (authored by khng).
AMD-vi: Fix mismatched NULL checking in amdiommu teardown path
Fri, Sep 3, 7:08 PM
khng committed R10:e6a1e05baf5d: bhyve amd: Small cleanups in amdvi_dump_cmds (authored by khng).
bhyve amd: Small cleanups in amdvi_dump_cmds
Fri, Sep 3, 7:07 PM
khng committed R10:32593b9f873b: Correct "Fondation" typo (missing "u") (authored by emaste).
Correct "Fondation" typo (missing "u")
Fri, Sep 3, 7:07 PM
khng committed R10:5ba7dc4c2176: AMD-vi: Fix IOMMU device interrupts being overridden (authored by khng).
AMD-vi: Fix IOMMU device interrupts being overridden
Fri, Sep 3, 7:06 PM
khng committed R10:17162a06159a: ivrs_drv: Fix IVHDs with duplicated BaseAddress (authored by khng).
ivrs_drv: Fix IVHDs with duplicated BaseAddress
Fri, Sep 3, 7:06 PM
khng committed R10:d91b79b54c55: __FreeBSD_version: update the references to the doc tree (authored by khng).
__FreeBSD_version: update the references to the doc tree
Fri, Sep 3, 6:48 PM
khng committed R10:75f7db7c11fe: vnode_pager_setsize.9: Some clarifications on the manpage (authored by khng).
vnode_pager_setsize.9: Some clarifications on the manpage
Fri, Sep 3, 6:48 PM
khng committed R10:83d2fee4193a: Document vnode_pager_setsize(9) (authored by khng).
Document vnode_pager_setsize(9)
Fri, Sep 3, 6:48 PM
khng committed R10:4116adc45531: pmap_extract.9: Fix pmap_extract_and_hold()'s function type (authored by khng).
pmap_extract.9: Fix pmap_extract_and_hold()'s function type
Fri, Sep 3, 6:47 PM
khng committed R10:8dc330532b9f: Correct "Fondation" typo (missing "u") (authored by emaste).
Correct "Fondation" typo (missing "u")
Fri, Sep 3, 5:30 PM
khng committed R10:dee751933363: vmm: Fix wrong assert in ivhd_dev_add_entry (authored by khng).
vmm: Fix wrong assert in ivhd_dev_add_entry
Fri, Sep 3, 5:26 PM
khng committed R10:24ef34a07856: bhyve: Nuke double-semicolons (authored by ehem_freebsd_m5p.com).
bhyve: Nuke double-semicolons
Fri, Sep 3, 5:26 PM
khng committed R10:b31e93bc8d11: tmpfs: Move partial page invalidation to a separate helper (authored by khng).
tmpfs: Move partial page invalidation to a separate helper
Fri, Sep 3, 5:25 PM

Thu, Sep 2

khng committed R10:483e3cda0c83: man: A trailing space cleanup in man9's Makefile (authored by khng).
man: A trailing space cleanup in man9's Makefile
Thu, Sep 2, 1:12 PM
khng committed R10:9bb8304c1012: Symbol.map: Remove an extra space before _Fork (authored by khng).
Symbol.map: Remove an extra space before _Fork
Thu, Sep 2, 1:12 PM

Wed, Sep 1

khng committed R10:92bb74fd4f01: vfs: Use file_cred for VOP_DEALLOCATE in vn_deallocate if non-NULL (authored by khng).
vfs: Use file_cred for VOP_DEALLOCATE in vn_deallocate if non-NULL
Wed, Sep 1, 12:20 PM
khng closed D31712: vfs: Use file_cred for VOP_DEALLOCATE in vn_deallocate if non-NULL.
Wed, Sep 1, 12:19 PM
khng updated the diff for D31712: vfs: Use file_cred for VOP_DEALLOCATE in vn_deallocate if non-NULL.
  • Comments
  • ternary instead.
Wed, Sep 1, 11:38 AM
khng updated the diff for D31712: vfs: Use file_cred for VOP_DEALLOCATE in vn_deallocate if non-NULL.

vn_deallocate_impl takes three kinds of cred so it's the caller to decide which cred to pass to the VOP call. Suggested by kib@.

Wed, Sep 1, 10:56 AM
khng added a comment to D31712: vfs: Use file_cred for VOP_DEALLOCATE in vn_deallocate if non-NULL.
In D31712#716746, @kib wrote:

Don't do this either.

Right now I see the only place which uses vn_deallocate(), it is md(4). Do you envision any more places which would do that?

My change to ctl(4) which translate UNMAP to VOP_DEALLOCATE for file-backed LUNS also calls vn_deallocate().

Wed, Sep 1, 10:49 AM
khng updated the diff for D31712: vfs: Use file_cred for VOP_DEALLOCATE in vn_deallocate if non-NULL.

The upper 16bit of ioflag is used to pass internal flag to vn_deallocate_impl.

Wed, Sep 1, 6:05 AM

Tue, Aug 31

khng committed R10:6f89edcd836e: pmap_extract.9: Fix pmap_extract_and_hold()'s function type (authored by khng).
pmap_extract.9: Fix pmap_extract_and_hold()'s function type
Tue, Aug 31, 6:48 AM

Mon, Aug 30

khng added inline comments to D31712: vfs: Use file_cred for VOP_DEALLOCATE in vn_deallocate if non-NULL.
Mon, Aug 30, 10:38 AM
khng closed D31718: usr.sbin: Nuke double-semicolons.
Mon, Aug 30, 7:36 AM
khng committed R10:e76c0e4f4563: bhyve: Nuke double-semicolons (authored by ehem_freebsd_m5p.com).
bhyve: Nuke double-semicolons
Mon, Aug 30, 7:32 AM
khng accepted D31718: usr.sbin: Nuke double-semicolons.

Thanks for your contribution!

Mon, Aug 30, 7:24 AM
khng updated the diff for D31712: vfs: Use file_cred for VOP_DEALLOCATE in vn_deallocate if non-NULL.
  • Use vn_deallocate_args to pass around most of the args to vn_deallocate_impl.
  • Comment vn_deallocate(9)'s active_cred/file_cred preference.
Mon, Aug 30, 6:12 AM
khng retitled D31712: vfs: Use file_cred for VOP_DEALLOCATE in vn_deallocate if non-NULL from vfs: Use file_cred for VOP_DEALLOCATE when available to vfs: Use file_cred for VOP_DEALLOCATE in vn_deallocate if non-NULL.
Mon, Aug 30, 6:05 AM

Sun, Aug 29

khng added inline comments to D31712: vfs: Use file_cred for VOP_DEALLOCATE in vn_deallocate if non-NULL.
Sun, Aug 29, 9:18 PM
khng updated the diff for D31712: vfs: Use file_cred for VOP_DEALLOCATE in vn_deallocate if non-NULL.

Oops.

Sun, Aug 29, 8:09 PM
khng updated the diff for D31712: vfs: Use file_cred for VOP_DEALLOCATE in vn_deallocate if non-NULL.

Make such change specific to vn_deallocate instead.

Sun, Aug 29, 8:08 PM
khng reclaimed D31712: vfs: Use file_cred for VOP_DEALLOCATE in vn_deallocate if non-NULL.
Sun, Aug 29, 8:07 PM
khng updated the summary of D31712: vfs: Use file_cred for VOP_DEALLOCATE in vn_deallocate if non-NULL.
Sun, Aug 29, 8:07 PM
khng abandoned D31712: vfs: Use file_cred for VOP_DEALLOCATE in vn_deallocate if non-NULL.

Just checked the behavior of .fo_read/.fo_write.

Sun, Aug 29, 7:53 PM
khng requested review of D31712: vfs: Use file_cred for VOP_DEALLOCATE in vn_deallocate if non-NULL.
Sun, Aug 29, 5:00 PM
khng closed D31705: vfs: yield in vn_deallocate_impl() loop.
Sun, Aug 29, 8:27 AM
khng committed R10:a58e222b3bcc: vfs: yield in vn_deallocate_impl() loop (authored by khng).
vfs: yield in vn_deallocate_impl() loop
Sun, Aug 29, 8:27 AM

Fri, Aug 27

khng updated the diff for D31705: vfs: yield in vn_deallocate_impl() loop.

Do not call maybe_yield if there is any error

Fri, Aug 27, 10:57 PM
khng requested review of D31705: vfs: yield in vn_deallocate_impl() loop.
Fri, Aug 27, 10:45 PM
khng committed R10:6e1df1d14c6d: pmap_extract.9: Fix pmap_extract_and_hold()'s function type (authored by khng).
pmap_extract.9: Fix pmap_extract_and_hold()'s function type
Fri, Aug 27, 1:45 PM
khng closed D31691: pmap_extract.9: Fix pmap_extract_and_hold()'s function type.
Fri, Aug 27, 1:44 PM
khng committed R10:6e2fc728d8da: AMD-vi: Fortify IVHD device_identify process (authored by khng).
AMD-vi: Fortify IVHD device_identify process
Fri, Aug 27, 1:09 PM
khng committed R10:45d1b7b34a5a: sound: Add an example of basic sound application (authored by meka_tilda.center).
sound: Add an example of basic sound application
Fri, Aug 27, 12:47 PM
khng committed R10:74ef8d180fb0: vmm: Bump vmname buffer in struct vm to VM_MAX_NAMELEN + 1 (authored by khng).
vmm: Bump vmname buffer in struct vm to VM_MAX_NAMELEN + 1
Fri, Aug 27, 12:47 PM
khng committed R10:9d2067ec4027: tmpfs: Fix error being cleared after commit c12118f6cec0 (authored by khng).
tmpfs: Fix error being cleared after commit c12118f6cec0
Fri, Aug 27, 12:47 PM
khng committed R10:2b567cd65f0d: tmpfs: Fix styles (authored by khng).
tmpfs: Fix styles
Fri, Aug 27, 12:47 PM
khng committed R10:e899971b817c: sound: Add an example of basic sound application (authored by meka_tilda.center).
sound: Add an example of basic sound application
Fri, Aug 27, 11:43 AM
khng committed R10:3bda6fa6a021: tmpfs: Fix error being cleared after commit c12118f6cec0 (authored by khng).
tmpfs: Fix error being cleared after commit c12118f6cec0
Fri, Aug 27, 11:43 AM
khng committed R10:877ba067c0fb: vmm: Bump vmname buffer in struct vm to VM_MAX_NAMELEN + 1 (authored by khng).
vmm: Bump vmname buffer in struct vm to VM_MAX_NAMELEN + 1
Fri, Aug 27, 11:43 AM
khng committed R10:e678b3ee8bf5: tmpfs: Fix styles (authored by khng).
tmpfs: Fix styles
Fri, Aug 27, 11:43 AM
khng committed R10:9a91689e414c: vfs: Add get_write_ioflag helper to calculate ioflag (authored by khng).
vfs: Add get_write_ioflag helper to calculate ioflag
Fri, Aug 27, 11:43 AM

Thu, Aug 26

khng requested review of D31691: pmap_extract.9: Fix pmap_extract_and_hold()'s function type.
Thu, Aug 26, 9:07 AM
khng accepted D31624: add the Deallocate operation to the NFSv4.2 server.
Thu, Aug 26, 6:58 AM

Wed, Aug 25

khng added inline comments to D31640: add a nfs_deallocate VOP.
Wed, Aug 25, 10:06 PM
khng committed R10:399be91098ad: tmpfs: Move partial page invalidation to a separate helper (authored by khng).
tmpfs: Move partial page invalidation to a separate helper
Wed, Aug 25, 9:35 PM
khng committed R10:8d7cd10ba633: tmpfs: Implement VOP_DEALLOCATE (authored by khng).
tmpfs: Implement VOP_DEALLOCATE
Wed, Aug 25, 9:35 PM
khng closed D31684: tmpfs: Implement VOP_DEALLOCATE.
Wed, Aug 25, 9:35 PM
khng closed D31683: tmpfs: Move partial page invalidation to a separate helper.
Wed, Aug 25, 9:35 PM
khng updated the diff for D31684: tmpfs: Implement VOP_DEALLOCATE.
  • Styles
  • KASSERT message changes
  • KASSERT node type be VREG in tmpfs_reg_punch_hole
  • Remove the MPASS(VOP_ISLOCKED(vp)) from tmpfs_deallocate. This is guarded by ASSERT_VOP_LOCKED already.
Wed, Aug 25, 9:00 PM
khng updated the diff for D31683: tmpfs: Move partial page invalidation to a separate helper.

Cleanups suggested by kib@

Wed, Aug 25, 8:44 PM
khng requested review of D31684: tmpfs: Implement VOP_DEALLOCATE.
Wed, Aug 25, 8:13 PM
khng requested review of D31683: tmpfs: Move partial page invalidation to a separate helper.
Wed, Aug 25, 8:13 PM
khng committed R9:c376eb73f5ac: Document __FreeBSD_version value 1400032. (authored by khng).
Document __FreeBSD_version value 1400032.
Wed, Aug 25, 4:29 PM
khng added inline comments to D31640: add a nfs_deallocate VOP.
Wed, Aug 25, 4:18 PM
khng committed R10:76321d2d432e: param: Bump __FreeBSD_version to 1400032 (authored by khng).
param: Bump __FreeBSD_version to 1400032
Wed, Aug 25, 4:05 PM
khng committed R10:9e202d036dd6: fspacectl(2): Changes on rmsr.r_offset's minimum value returned (authored by khng).
fspacectl(2): Changes on rmsr.r_offset's minimum value returned
Wed, Aug 25, 4:05 PM
khng closed D31677: fspacectl(2): Changes on rmsr.r_offset's minimum value returned.
Wed, Aug 25, 4:05 PM
khng added a comment to D31624: add the Deallocate operation to the NFSv4.2 server.

One thing to note, it might be good to periodically do maybe_yield when looping the call so that it won't early return when should_yield() in the default implementation is hit.

Wed, Aug 25, 3:53 PM
khng accepted D31624: add the Deallocate operation to the NFSv4.2 server.

The VOP_DEALLOCATE bits look good to me.

Wed, Aug 25, 3:51 PM
khng added a comment to D31677: fspacectl(2): Changes on rmsr.r_offset's minimum value returned.

This should play better with the nfs_deallocate implementation in NFS4.2 client module.

Wed, Aug 25, 12:10 PM
khng requested review of D31677: fspacectl(2): Changes on rmsr.r_offset's minimum value returned.
Wed, Aug 25, 12:08 PM
khng added inline comments to D31624: add the Deallocate operation to the NFSv4.2 server.
Wed, Aug 25, 8:14 AM

Tue, Aug 24

khng added a comment to D31640: add a nfs_deallocate VOP.

I could make r_offset >= maxfilesize a no-op.
The problem is that the client will only have a (possibly stale)
va.va_size for the file to use to set the reply r_offset.
--> To be honest, it is always a bit bogus, since another

client can change the file size at any time.

If just guessing at what va_size is to set r_offset to is fine with
you guys, I can do that.

Tue, Aug 24, 7:35 PM
khng committed R10:a48416f844e3: tmpfs: Fix error being cleared after commit c12118f6cec0 (authored by khng).
tmpfs: Fix error being cleared after commit c12118f6cec0
Tue, Aug 24, 4:38 PM
khng committed R10:5c1428d2c4a6: uipc_shm: Handle offset on shm_size as if it is beyond shm_size (authored by khng).
uipc_shm: Handle offset on shm_size as if it is beyond shm_size
Tue, Aug 24, 3:50 PM
khng committed R10:c12118f6cec0: tmpfs: Fix styles (authored by khng).
tmpfs: Fix styles
Tue, Aug 24, 3:50 PM