Page MenuHomeFreeBSD

khng (Ka Ho Ng)
User

Projects

User Details

User Since
Jun 12 2018, 3:15 AM (318 w, 5 d)

Recent Activity

Thu, Jul 11

khng committed rG8cd71a0e01d6: libfetch: parse IPv4address in IPv6address properly (authored by khng).
libfetch: parse IPv4address in IPv6address properly
Thu, Jul 11, 7:49 PM
khng closed D45896: libfetch: parse IPv4address in IPv6address properly.
Thu, Jul 11, 7:49 PM

Mon, Jul 8

khng added a reviewer for D45896: libfetch: parse IPv4address in IPv6address properly: stevek.
Mon, Jul 8, 3:40 PM

Sat, Jul 6

khng added a reviewer for D45896: libfetch: parse IPv4address in IPv6address properly: delphij.
Sat, Jul 6, 3:23 AM
khng requested review of D45896: libfetch: parse IPv4address in IPv6address properly.
Sat, Jul 6, 3:21 AM

Wed, Jul 3

khng committed rG25ef056f74e4: ofed: fix rwq buffer allocation (authored by khng).
ofed: fix rwq buffer allocation
Wed, Jul 3, 5:35 PM
khng closed D45833: ofed: fix rwq buffer allocation.
Wed, Jul 3, 5:35 PM

Tue, Jul 2

khng requested review of D45833: ofed: fix rwq buffer allocation.
Tue, Jul 2, 4:37 PM

Jun 19 2024

khng accepted D45498: sys/conf: Introduce NOSAN_CFLAGS and NOSAN_C.
Jun 19 2024, 4:38 PM

Jun 11 2024

khng requested review of D45564: sys: Emit KERN_OPTS_EXTRA options to opt_global.h.
Jun 11 2024, 10:23 PM
khng requested review of D45563: sys: move SAN and COVERAGE options handling to kern.mk.
Jun 11 2024, 10:23 PM

Jun 10 2024

khng abandoned D45541: devel/ccls: update to snapshot 20240202.
Jun 10 2024, 4:06 AM
khng committed R11:d8da769c2767: devel/ccls: update to snapshot 20240202 (authored by che_bein.link).
devel/ccls: update to snapshot 20240202
Jun 10 2024, 2:42 AM
khng closed D45540: devel/ccls: update to snapshot 20240202.
Jun 10 2024, 2:42 AM
khng requested review of D45541: devel/ccls: update to snapshot 20240202.
Jun 10 2024, 2:13 AM
khng updated the summary of D45540: devel/ccls: update to snapshot 20240202.
Jun 10 2024, 2:10 AM
khng requested review of D45540: devel/ccls: update to snapshot 20240202.
Jun 10 2024, 2:09 AM

Jun 3 2024

khng abandoned D45443: unix/dgram: dispose mbufs on uxdg_mb queue.

In favour of D45477 and D45478.

Jun 3 2024, 8:18 PM
khng accepted D45478: unix: use m_freemp() when disposing unix socket buffers.
Jun 3 2024, 8:15 PM
khng accepted D45477: mbuf: provide m_freemp().
Jun 3 2024, 8:15 PM
khng updated the diff for D45443: unix/dgram: dispose mbufs on uxdg_mb queue.

markj@: code should be idiomatic

Jun 3 2024, 7:45 PM
khng added a comment to D45443: unix/dgram: dispose mbufs on uxdg_mb queue.

Ah, I see the bug. It is just because m_freem() follows only m_next linkage and doesn't follow m_nextpkt linkage. I always assumed it does both.

Jun 3 2024, 7:42 PM
khng updated the diff for D45443: unix/dgram: dispose mbufs on uxdg_mb queue.

m_nextpkt and m_stailqnxt are the same.

Jun 3 2024, 6:45 PM
khng retitled D45443: unix/dgram: dispose mbufs on uxdg_mb queue from unix/dgram: dispose mbufs through m_stailqpkt chain to unix/dgram: dispose mbufs on uxdg_mb queue.
Jun 3 2024, 6:44 PM
khng added a comment to D45443: unix/dgram: dispose mbufs on uxdg_mb queue.

m_stailqpkt is an alias to m_nextpkt, so the code:

m0 = is_dgram ? STAILQ_NEXT(m0, m_stailqpkt) : m0->m_nextpkt;

doesn't change anything with is_dgram switching between true/false.

Do you really see a leak fixed with this patch? Is this the leak reported in bug 279467?

Jun 3 2024, 6:35 PM

Jun 1 2024

khng updated the diff for D45443: unix/dgram: dispose mbufs on uxdg_mb queue.

Oops.

Jun 1 2024, 6:44 PM
khng requested review of D45443: unix/dgram: dispose mbufs on uxdg_mb queue.
Jun 1 2024, 6:36 PM

May 7 2024

khng added a reviewer for D44531: mtree: Fix duplicated entries handling in spec(): imp.
May 7 2024, 6:55 PM

Apr 23 2024

khng added a reviewer for D44770: Setting rclk when used with FDT: imp.
Apr 23 2024, 8:55 PM
khng added a reviewer for D44771: Set SO_REUSEPORT socket option: rmacklem.
Apr 23 2024, 8:54 PM

Apr 22 2024

khng committed rG933490d3b6d4: kasan: fix false-positive kasan_report upon thread reuse (authored by khng).
kasan: fix false-positive kasan_report upon thread reuse
Apr 22 2024, 12:31 AM

Apr 21 2024

khng abandoned D44882: kasan: wrap kstack cleanup into a helper.
Apr 21 2024, 4:52 PM
khng accepted D44891: thread: Simplify sanitizer integration with thread creation.
Apr 21 2024, 4:51 PM

Apr 20 2024

khng updated the diff for D44882: kasan: wrap kstack cleanup into a helper.

Adapt markj@'s suggestions.

Apr 20 2024, 9:28 PM

Apr 19 2024

khng updated the diff for D44882: kasan: wrap kstack cleanup into a helper.

.

Apr 19 2024, 10:42 PM
khng requested review of D44882: kasan: wrap kstack cleanup into a helper.
Apr 19 2024, 10:29 PM
khng closed D44875: kasan: fix false-positive kasan_report upon thread reuse.
Apr 19 2024, 7:19 PM
khng committed rG68a3a7fc9483: kasan: fix false-positive kasan_report upon thread reuse (authored by khng).
kasan: fix false-positive kasan_report upon thread reuse
Apr 19 2024, 7:19 PM
khng requested review of D44875: kasan: fix false-positive kasan_report upon thread reuse.
Apr 19 2024, 7:17 PM

Apr 12 2024

khng added reviewers for D44765: maketab: Add build rules to use HOST_CC: sjg, stevek.
Apr 12 2024, 8:07 PM
khng requested review of D44765: maketab: Add build rules to use HOST_CC.
Apr 12 2024, 8:07 PM
khng requested review of D44764: arm64: bus: Add 36-bit address mask for use in bus space allocations.
Apr 12 2024, 7:55 PM
khng requested review of D44763: pmcstat: Fix compiler warnings when building pcmstat with -Werror.
Apr 12 2024, 7:55 PM
khng requested review of D44762: iicbus: Add IIC_M_CMD flag for command or offset for read/write.
Apr 12 2024, 7:54 PM
khng requested review of D44761: Use NO_SHARED instead of explicitly using -static flag.
Apr 12 2024, 7:53 PM
khng requested review of D44760: fbt: Fix compiler warnings in CDDL fbt sources..
Apr 12 2024, 7:51 PM
khng committed rGcb722b67796d: ibcore: Remove the use of NULL_IB_OBJECT (authored by khng).
ibcore: Remove the use of NULL_IB_OBJECT
Apr 12 2024, 5:22 PM
khng committed rG53b5393319dd: uart_snps: Register a device xref for UARTs (authored by khng).
uart_snps: Register a device xref for UARTs
Apr 12 2024, 5:22 PM
khng closed D44533: ibcore: Remove the use of NULL_IB_OBJECT.
Apr 12 2024, 5:22 PM
khng closed D44532: uart_snps: Register a device xref for UARTs.
Apr 12 2024, 5:21 PM

Apr 3 2024

khng committed rGc89889b9c342: libfetch: parse scheme://domain:/ correctly (authored by khng).
libfetch: parse scheme://domain:/ correctly
Apr 3 2024, 7:13 PM
khng committed rG72c3d91294c4: libfetch: parse scheme://domain:/ correctly (authored by khng).
libfetch: parse scheme://domain:/ correctly
Apr 3 2024, 7:12 PM

Mar 29 2024

khng committed rGd9d05e65c1f7: epoch(9): Remove the under-development note (authored by khng).
epoch(9): Remove the under-development note
Mar 29 2024, 7:55 PM

Mar 27 2024

khng requested review of D44534: mmc: Add hint.mmcsd.X.ignore_part tunable.
Mar 27 2024, 6:29 PM
khng requested review of D44533: ibcore: Remove the use of NULL_IB_OBJECT.
Mar 27 2024, 6:23 PM
khng requested review of D44532: uart_snps: Register a device xref for UARTs.
Mar 27 2024, 6:19 PM
khng requested review of D44531: mtree: Fix duplicated entries handling in spec().
Mar 27 2024, 6:15 PM

Mar 26 2024

khng committed rG04b90ac0f9e8: epoch(9): Remove the under-development note (authored by khng).
epoch(9): Remove the under-development note
Mar 26 2024, 2:42 PM
khng closed D44501: epoch(9): Remove the under-development note.
Mar 26 2024, 2:42 PM

Mar 25 2024

khng committed R9:effa515e549b: Document __FreeBSD_version 1500017 correctly. (authored by khng).
Document __FreeBSD_version 1500017 correctly.
Mar 25 2024, 11:14 PM
khng requested review of D44501: epoch(9): Remove the under-development note.
Mar 25 2024, 9:34 PM
khng committed rGfb860ed0c52c: libfetch: parse scheme://domain:/ correctly (authored by khng).
libfetch: parse scheme://domain:/ correctly
Mar 25 2024, 8:15 PM
khng closed D44493: libfetch: parse scheme://domain:/ correctly.
Mar 25 2024, 8:14 PM
khng added a comment to D44493: libfetch: parse scheme://domain:/ correctly.

@des something like https://example.com:/ used to work before https://reviews.freebsd.org/rG8d9de5b10a24bd2d79ed99f139c0ac28c09b15ca. Meanwhile, curl -L https://example.com:/ gives the HTML page just as curl -L https://example.com/, and is true for Firefox and Chromium-based browsers as well.

Mar 25 2024, 5:32 PM
khng requested review of D44493: libfetch: parse scheme://domain:/ correctly.
Mar 25 2024, 5:01 AM

Mar 18 2024

khng committed rG60bc9617e79e: kerneldump: add livedump_start_vnode(9) (authored by kvinupriya_gmail.com).
kerneldump: add livedump_start_vnode(9)
Mar 18 2024, 9:14 PM
khng closed D43471: Adapt the call to invoke a live minidump on the system using vnode.
Mar 18 2024, 9:14 PM

Feb 28 2024

khng accepted D44138: articles/lsp:Fix disposition and correct version.
Feb 28 2024, 3:40 AM

Feb 22 2024

khng accepted D43471: Adapt the call to invoke a live minidump on the system using vnode.

LGTM, with a nit.

Feb 22 2024, 11:16 PM

Feb 11 2024

khng committed R9:6238dec7ca3f: Add a asciidoc literal block for my key. (authored by khng).
Add a asciidoc literal block for my key.
Feb 11 2024, 10:15 AM
khng committed R9:ae17f9272315: Extend the expiry date of my pgp key. (authored by khng).
Extend the expiry date of my pgp key.
Feb 11 2024, 10:04 AM

Jan 8 2024

khng added a reviewer for D42920: Fix clock source in the API safe_pause_*() in e1000 driver: jhibbits.
Jan 8 2024, 6:44 PM

Dec 10 2023

khng committed rG1ed12844a186: termcap.small: Include xterm-256color (authored by khng).
termcap.small: Include xterm-256color
Dec 10 2023, 3:16 AM

Dec 2 2023

khng committed rGebb1e0f19332: libclang_rt: Update Makefile.depend (authored by khng).
libclang_rt: Update Makefile.depend
Dec 2 2023, 9:20 AM
khng committed rG1da7f3f6f72b: termcap.small: Include xterm-256color (authored by khng).
termcap.small: Include xterm-256color
Dec 2 2023, 5:57 AM
khng closed D42784: termcap.small: Include xterm-256color.
Dec 2 2023, 5:56 AM

Nov 28 2023

khng edited reviewers for D42784: termcap.small: Include xterm-256color, added: imp; removed: jhb.
Nov 28 2023, 5:01 PM
khng requested review of D42784: termcap.small: Include xterm-256color.
Nov 28 2023, 3:28 AM

Nov 27 2023

khng accepted D41516: fcitx5*: Update to 5.1.0.
Nov 27 2023, 9:42 AM
khng closed D42778: devel/ccls: update to snapshot 20231116.
Nov 27 2023, 9:26 AM
khng committed R11:683a3be4c573: devel/ccls: update to snapshot 20231116 (authored by khng).
devel/ccls: update to snapshot 20231116
Nov 27 2023, 9:26 AM
khng requested review of D42778: devel/ccls: update to snapshot 20231116.
Nov 27 2023, 8:38 AM
khng committed rGd030761168eb: dirdeps: Update/fix Makefile.depend* for toolchain (authored by khng).
dirdeps: Update/fix Makefile.depend* for toolchain
Nov 27 2023, 1:52 AM

Nov 26 2023

khng committed rG3244c9c673a9: dirdeps: Remove $FreeBSD$ (authored by khng).
dirdeps: Remove $FreeBSD$
Nov 26 2023, 8:49 PM

Nov 17 2023

khng committed rGb1538e8fc488: dirdeps: Fix libpcap Makefile.depend.options (authored by khng).
dirdeps: Fix libpcap Makefile.depend.options
Nov 17 2023, 4:36 PM
khng closed D42649: dirdeps: Fix libpcap Makefile.depend.options.
Nov 17 2023, 4:35 PM
khng updated the diff for D42649: dirdeps: Fix libpcap Makefile.depend.options.

Remove lib/ofed/include from Makefile.depend

Nov 17 2023, 3:30 PM
khng requested review of D42649: dirdeps: Fix libpcap Makefile.depend.options.
Nov 17 2023, 3:06 PM

Nov 9 2023

khng committed rGf5b3e686292b: dirdeps: Update clang-tblgen dependencies (authored by khng).
dirdeps: Update clang-tblgen dependencies
Nov 9 2023, 12:44 AM
khng committed rG5fb425aa00df: dirdeps: Update liblldb dependencies (authored by khng).
dirdeps: Update liblldb dependencies
Nov 9 2023, 12:44 AM
khng closed D42481: dirdeps: Update clang-tblgen dependencies.
Nov 9 2023, 12:44 AM
khng closed D42480: dirdeps: Update liblldb dependencies.
Nov 9 2023, 12:44 AM

Nov 6 2023

khng added a reviewer for D42480: dirdeps: Update liblldb dependencies: sjg.
Nov 6 2023, 6:17 PM
khng added a reviewer for D42481: dirdeps: Update clang-tblgen dependencies: sjg.
Nov 6 2023, 6:17 PM
khng requested review of D42481: dirdeps: Update clang-tblgen dependencies.
Nov 6 2023, 3:26 PM
khng requested review of D42480: dirdeps: Update liblldb dependencies.
Nov 6 2023, 3:26 PM

Nov 5 2023

khng closed D42469: share/mk: Fix .TARGET override documentation.
Nov 5 2023, 9:29 PM
khng committed rG475fa8980008: share/mk: Fix .TARGET override documentation (authored by khng).
share/mk: Fix .TARGET override documentation
Nov 5 2023, 9:29 PM
khng updated the diff for D42469: share/mk: Fix .TARGET override documentation.

should be .TARGET:T

Nov 5 2023, 4:00 AM
khng added a reviewer for D42469: share/mk: Fix .TARGET override documentation: brooks.
Nov 5 2023, 3:24 AM