Page MenuHomeFreeBSD

phil (Phil Shafer)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 10 2016, 6:59 PM (420 w, 5 d)

Recent Activity

Dec 28 2023

phil added a comment to D41745: dtrace: Add the 'oformat' libdtrace option..

If I compile usr.sbin/dtrace with this patch applied, I get:

In file included from /home/markj/src/freebsd/cddl/contrib/opensolaris/cmd/dtrace/dtrace.c:59:
/usr/include/libxo/xo.h:31:9: error: 'NORETURN' macro redefined [-Werror,-Wmacro-redefined]
   31 | #define NORETURN __dead2
      |         ^
/home/markj/src/freebsd/sys/contrib/openzfs/lib/libspl/include/assert.h:44:9: note: previous definition is here
   44 | #define NORETURN        __attribute__((__noreturn__))
      |         ^
1 error generated.
*** Error code 1

Stop.
make: stopped in /home/markj/src/freebsd/cddl/usr.sbin/dtrace

I tend to think that xo.h should undefine those symbols (NORETURN and PRINTFLIKE) at the end, or give them a XO_ namespace prefix. I'll fix it up locally and keep testing, but we need some solution for this before committing. (Or am I doing something wrong?)

Dec 28 2023, 5:39 PM · DTrace

Nov 1 2023

phil added a comment to D41745: dtrace: Add the 'oformat' libdtrace option..

$ sudo dtrace -n 'BEGIN { mod(0xffffffff8261a000); exit(0); }'
dtrace: description 'BEGIN ' matched 1 probe
CPU ID FUNCTION:NAME

6      1                           :BEGIN

opensolaris.ko
Nov 1 2023, 5:41 PM · DTrace

Oct 20 2023

phil added inline comments to D41745: dtrace: Add the 'oformat' libdtrace option..
Oct 20 2023, 8:53 PM · DTrace
phil added inline comments to D41745: dtrace: Add the 'oformat' libdtrace option..
Oct 20 2023, 4:59 PM · DTrace
phil added inline comments to D41745: dtrace: Add the 'oformat' libdtrace option..
Oct 20 2023, 12:18 AM · DTrace

Oct 18 2023

phil added inline comments to D41745: dtrace: Add the 'oformat' libdtrace option..
Oct 18 2023, 6:43 PM · DTrace
phil added a comment to D41745: dtrace: Add the 'oformat' libdtrace option..

I suggest to think about adding --libxo foo as an alias to -x oformat=foo to make things more inline with what is actually done for, e.g., netstat(1).

Thanks for the feedback! I don't take a strong view on whether or not xo_parse_args() should be called at the start, though it might require some finessing to make it work happily with libdtrace because xo_parse_args() sets a number of flags for libxo that I don't with -x oformat (such as colored output in some cases). Another thing worth pondering is that this is also an argument to libdtrace rather than dtrace(1), so one would inevitably need to still call dtrace_setopt(). Now, however libxo configuration would be performed twice: once in dtrace(1), and once in libdtrace. dtrace(1) itself would explicitly need to include libxo and link against it, but this isn't a big issue IMO, it just "feels" cleaner to me for it to only link against libdtrace and for libdtrace to provide all the libxo handling and configuration and for any consumer code (including dtrace(1)) to simply request it.

However I do agree with the general point that there is an inconsistency with the rest of the base system when it comes to libxo integration (though it's inconsistent in a fair bit of other ways too). One way to work around the issue without xo_parse_args() would be perhaps to add a - flag and manually parse out the -libxo ... that follows? I'm not sure what the best approach would be that doesn't get slightly messy.

Oct 18 2023, 4:50 AM · DTrace

Jun 27 2023

phil added a comment to D40668: xo: Disable -Wunused-but-set-variable..

Looks good. FWIW, the fix in the repo is in commit de776ab1a8985fbeb510af8e39777fa9db69d3d9:

Jun 27 2023, 6:13 PM

Feb 2 2023

phil accepted D30350: acpiconf(8): Add libxo(3) support.
Feb 2 2023, 5:47 PM
phil added inline comments to D30350: acpiconf(8): Add libxo(3) support.
Feb 2 2023, 5:46 PM

Jan 30 2023

phil committed rGef7d10fde4f6: Add missing check for xo_parse_args return code. (authored by phil).
Add missing check for xo_parse_args return code.
Jan 30 2023, 8:44 PM
phil added a comment to D30350: acpiconf(8): Add libxo(3) support.

Sorry for the delay.

Jan 30 2023, 8:00 PM
phil committed rGe1e2080fc1ce: Import Juniper libxo-1.6.0 (authored by phil).
Import Juniper libxo-1.6.0
Jan 30 2023, 6:39 PM
phil committed rG34b867ca3047: Merge commit '7087c8de43b0d5d27c52da6ba2ba4957b7e336ff' into new_merge (authored by phil).
Merge commit '7087c8de43b0d5d27c52da6ba2ba4957b7e336ff' into new_merge
Jan 30 2023, 5:11 AM
phil committed rG7087c8de43b0: Vendor import of Juniper libxo at 1.6.0 (authored by phil).
Vendor import of Juniper libxo at 1.6.0
Jan 30 2023, 4:13 AM

Jan 27 2023

phil committed rGb1cbac9ff49d: Vendor import of NetBSD's mtree at 2020-12-11 (authored by phil).
Vendor import of NetBSD's mtree at 2020-12-11
Jan 27 2023, 6:35 AM

Apr 4 2022

phil added a comment to R11:640149403944: lang/snobol4: Updates pkg-descr.

While I have fond memories of snobol, I'm thinking you've got the wrong "phil".

Apr 4 2022, 9:55 PM

Mar 25 2022

phil added a comment to D26157: Correctly escape some stray `\n`'s in libxo manpages.

These are in the libxo sources on github:

Mar 25 2022, 6:46 PM

Mar 1 2022

phil accepted D30350: acpiconf(8): Add libxo(3) support.

Looks good. I do see an error on this site that says some nameless file is missing a terminating newline.

Mar 1 2022, 3:34 AM

Sep 29 2021

phil added a comment to D30341: mount(8): Add libxo(3) support.

One more thing: Does libxo need an xo_exit() function? It would be just xo_finish + exit, like your EXIT macro, but might help minimize diffs like this.

Sep 29 2021, 7:35 PM
phil added a comment to D30341: mount(8): Add libxo(3) support.

xo_parse_args gives error messages for invalid arguments; no further error is needed.

Sep 29 2021, 7:33 PM

Aug 24 2021

phil added a comment to D30350: acpiconf(8): Add libxo(3) support.

Cameron,

You said "it seems that most check"; did you find ones that didn't?
Aug 24 2021, 6:18 PM
phil added a comment to D30350: acpiconf(8): Add libxo(3) support.

Yes, you need to check it. See xo_parse_args(3):

Aug 24 2021, 4:09 PM

Aug 4 2021

phil committed rGcd2401cdd550: add blank line between variables (testing git commit) (authored by phil).
add blank line between variables (testing git commit)
Aug 4 2021, 8:57 PM

Jun 2 2021

phil added a comment to D30350: acpiconf(8): Add libxo(3) support.

I could swear I tried this, I’ll update the patch shortly.

Jun 2 2021, 7:49 PM
phil added a comment to D30350: acpiconf(8): Add libxo(3) support.

Run xo_finish(3) after all instances of xo_errx(3)

Jun 2 2021, 5:20 PM
phil added a comment to D30350: acpiconf(8): Add libxo(3) support.

FYI: I've just added docs for this, so it will be in the next release, which I'll import shortly, but the functionality's already there.

Jun 2 2021, 5:16 PM
phil added a comment to D30350: acpiconf(8): Add libxo(3) support.

Looks good. You can use {L:} for strings that include slashes by escaping them with double backslashes (one for C, one for me):

Jun 2 2021, 4:52 PM

Apr 21 2021

phil added a comment to D25013: w: don't truncate argument list if --libxo was specified.

Correction: for your patch the test would be opposite:

Apr 21 2021, 5:15 PM
phil added a comment to D25013: w: don't truncate argument list if --libxo was specified.

Apologies, I missed your reply to my question, but it's still something I'm not following:

Apr 21 2021, 5:13 PM

Aug 25 2020

phil accepted D26157: Correctly escape some stray `\n`'s in libxo manpages.

Looks good. I'll mirror these fixes in github.

Aug 25 2020, 6:14 PM

Jun 8 2020

phil added a comment to D22160: PR241491: bin/ps: use locale-based string specifiers.

The "%hs" bits look good, but why do you add the call to xo_no_setlocale()?

Jun 8 2020, 3:41 PM

May 27 2020

phil added a comment to D25013: w: don't truncate argument list if --libxo was specified.

Just knowing that the "--libxo" was used is not sufficient, since there are options that should not affect output (e.g. color, no-humanize, warn).

May 27 2020, 6:02 AM

Jan 25 2020

phil committed rS357125: Import libxo-1.4.0:.
Import libxo-1.4.0:
Jan 25 2020, 9:17 PM
phil committed rS357124: Tag libxo 1.4.0.
Tag libxo 1.4.0
Jan 25 2020, 9:09 PM
phil committed rS357123: Import libxo 1.4.0.
Import libxo 1.4.0
Jan 25 2020, 9:09 PM

Dec 16 2019

phil committed rS355826: Allow proper builds of libxo's CSV encoder:.
Allow proper builds of libxo's CSV encoder:
Dec 16 2019, 10:05 PM

Nov 7 2019

phil committed rS354456: Remove oxtradoc version of documentation; move to RST/Sphinx.
Remove oxtradoc version of documentation; move to RST/Sphinx
Nov 7 2019, 6:07 PM
phil committed rS354455: Import libxo-1.3.1:.
Import libxo-1.3.1:
Nov 7 2019, 6:07 PM
phil committed rS354454: Tag libxo 1.3.1.
Tag libxo 1.3.1
Nov 7 2019, 6:06 PM
phil committed rS354453: Import libxo 1.3.1.
Import libxo 1.3.1
Nov 7 2019, 6:05 PM
phil committed rS354431: Back out encoder compilation to unbreak HEAD..
Back out encoder compilation to unbreak HEAD.
Nov 7 2019, 7:09 AM
phil committed rS354427: Import libxo-1.3.0:.
Import libxo-1.3.0:
Nov 7 2019, 3:57 AM
phil committed rS354426: Tag libxo 1.3.0.
Tag libxo 1.3.0
Nov 7 2019, 3:47 AM
phil committed rS354425: Import libxo 1.3.0.
Import libxo 1.3.0
Nov 7 2019, 3:46 AM

Oct 29 2019

phil accepted D22160: PR241491: bin/ps: use locale-based string specifiers.

Looks great! Thanks....

Oct 29 2019, 12:12 AM

May 7 2019

phil accepted D20188: Fix tests after rS347207.

Strange error; libtool related. On some platforms it seems to remove the ".test" extension. I'll add a fix to libxo to force removal of the extension (using xo_program() to set it to the basename), but for now, the fix here will be fine.

May 7 2019, 9:09 PM

May 6 2019

phil committed rS347207: Import libxo-1.0.4:.
Import libxo-1.0.4:
May 6 2019, 8:20 PM
phil committed rS347206: Tag libxo 1.0.4.
Tag libxo 1.0.4
May 6 2019, 8:15 PM
phil committed rS347205: Import libxo 1.0.4.
Import libxo 1.0.4
May 6 2019, 8:15 PM

Apr 5 2019

phil committed rS345967: Emergency fix for NULL deref in xo_xml_leader_len.
Emergency fix for NULL deref in xo_xml_leader_len
Apr 5 2019, 7:43 PM

Apr 3 2019

phil committed rS345860: Add "MAKE=gmake" to "configure" invocations in libxo import script.
Add "MAKE=gmake" to "configure" invocations in libxo import script
Apr 3 2019, 10:30 PM
phil committed rS345859: Import libxo-1.0.2.
Import libxo-1.0.2
Apr 3 2019, 9:56 PM
phil committed rS345857: Tag libxo 1.0.2.
Tag libxo 1.0.2
Apr 3 2019, 9:48 PM
phil committed rS345856: Import libxo 1.0.2.
Import libxo 1.0.2
Apr 3 2019, 9:47 PM

Jan 1 2019

phil added a comment to D18679: libxo: Fix XML output if a container name is a number.

The responsibility for valid tags should rest with the caller, but under the "never do the wrong thing", I'll pick up this fix, along with a "warning" call to help coders notice the breakage.

Jan 1 2019, 6:50 PM

May 23 2018

phil committed rS334068: Import libxo-0.9.0:.
Import libxo-0.9.0:
May 23 2018, 1:20 AM
phil committed rS334067: Tag libxo 0.9.0.
Tag libxo 0.9.0
May 23 2018, 1:13 AM
phil committed rS334066: Import libxo 0.9.0.
Import libxo 0.9.0
May 23 2018, 1:12 AM

May 14 2018

phil committed rS333600: Handle thread-local storage (TLS) segments correctly when.
Handle thread-local storage (TLS) segments correctly when
May 14 2018, 5:21 AM

Sep 25 2017

phil accepted D12395: vmstat: Fix duplicate key in libxo output.

Looks good. Thanks....

Sep 25 2017, 1:51 PM

Sep 24 2017

phil added a comment to D12395: vmstat: Fix duplicate key in libxo output.

FWIW, this bug is mine, from the original patch sets:

Sep 24 2017, 1:04 AM

Aug 7 2017

phil committed rS322172: Import libxo-0.8.4 from HEAD into stable/11.
Import libxo-0.8.4 from HEAD into stable/11
Aug 7 2017, 5:24 PM

Aug 3 2017

phil committed rS322019: Update from libxo-0.8.1 to 0.8.4:.
Update from libxo-0.8.1 to 0.8.4:
Aug 3 2017, 3:47 PM
phil committed rS322018: Tag libxo 0.8.4.
Tag libxo 0.8.4
Aug 3 2017, 3:43 PM
phil committed rS322017: Import libxo 0.8.4.
Import libxo 0.8.4
Aug 3 2017, 3:43 PM

Jun 30 2017

phil committed rS320521: Fix functional_test.sh to use --libxo options instead of the deprecated.
Fix functional_test.sh to use --libxo options instead of the deprecated
Jun 30 2017, 11:53 PM

Jun 16 2017

phil committed rS320000: Update libxo's import shell for xohtml.
Update libxo's import shell for xohtml
Jun 16 2017, 6:34 AM
phil committed rS319999: Merge libxo-0.8.2:.
Merge libxo-0.8.2:
Jun 16 2017, 6:29 AM
phil committed rS319998: Tag libxo 0.8.2.
Tag libxo 0.8.2
Jun 16 2017, 6:15 AM
phil committed rS319997: Import libxo 0.8.2.
Import libxo 0.8.2
Jun 16 2017, 6:12 AM

Jun 13 2017

phil committed rS319892: Use {T:Capacity} for header so html output looks tidy.
Use {T:Capacity} for header so html output looks tidy
Jun 13 2017, 5:39 AM

Jun 9 2017

phil committed rS319732: Fix import.sh w/ new $BUILDWORLD.
Fix import.sh w/ new $BUILDWORLD
Jun 9 2017, 3:34 AM
phil committed rS319731: Import libxo-0.8.1 with official fix to today's build break..
Import libxo-0.8.1 with official fix to today's build break.
Jun 9 2017, 3:33 AM
phil committed rS319730: Tag libxo 0.8.1.
Tag libxo 0.8.1
Jun 9 2017, 3:31 AM
phil committed rS319729: Import libxo 0.8.1.
Import libxo 0.8.1
Jun 9 2017, 3:30 AM

Jun 8 2017

phil committed rS319709: remove xo_color_t dup typedef.
remove xo_color_t dup typedef
Jun 8 2017, 5:00 PM
phil committed rS319694: Import libxo-0.8.0:.
Import libxo-0.8.0:
Jun 8 2017, 1:04 PM
phil committed rS319693: Tag libxo 0.8.0.
Tag libxo 0.8.0
Jun 8 2017, 12:59 PM
phil committed rS319692: Import libxo 0.8.0.
Import libxo 0.8.0
Jun 8 2017, 12:58 PM

May 16 2017

phil committed rS318364: Import libxo-0.7.2; add xo_options.7..
Import libxo-0.7.2; add xo_options.7.
May 16 2017, 6:47 PM
phil committed rS318362: Tag libxo 0.7.2.
Tag libxo 0.7.2
May 16 2017, 6:42 PM
phil committed rS318361: Import libxo 0.7.2.
Import libxo 0.7.2
May 16 2017, 6:42 PM

Jul 26 2016

phil committed rS303341: Fix start date to not be in the future..
Fix start date to not be in the future.
Jul 26 2016, 6:28 PM

Jul 2 2016

phil accepted D7052: Update libxo to 0.6.3.

Thanks!!

Jul 2 2016, 11:31 PM

May 29 2016

phil committed rS300930: Update libxo's .svnignore.
Update libxo's .svnignore
May 29 2016, 2:25 AM
phil committed rS300929: Update import script.
Update import script
May 29 2016, 2:22 AM
phil committed rS300925: Submitted by: phil.
Submitted by: phil
May 29 2016, 1:43 AM
phil committed rS300924: Tag libxo 0.6.2.
Tag libxo 0.6.2
May 29 2016, 1:41 AM
phil committed rS300923: Import libxo 0.6.2.
Import libxo 0.6.2
May 29 2016, 1:40 AM

May 28 2016

phil committed rS300912: Undo meaningless local changes to libxo so we're in sync with the github repo..
Undo meaningless local changes to libxo so we're in sync with the github repo.
May 28 2016, 7:39 PM

Apr 15 2016

phil committed rS298083: Import to 0.6.1.
Import to 0.6.1
Apr 15 2016, 6:46 PM
phil committed rS298081: Tag libxo 0.6.1.
Tag libxo 0.6.1
Apr 15 2016, 6:42 PM
phil committed rS298080: Import libxo 0.6.1.
Import libxo 0.6.1
Apr 15 2016, 6:41 PM
phil committed rS298078: Tag libxo 0.6.0.
Tag libxo 0.6.0
Apr 15 2016, 6:04 PM
phil committed rS298077: Import libxo 0.6.0.
Import libxo 0.6.0
Apr 15 2016, 6:03 PM
phil committed rS298067: import libxo-0.4.7.
import libxo-0.4.7
Apr 15 2016, 3:50 PM
phil committed rS298064: Tag libxo 0.4.7.
Tag libxo 0.4.7
Apr 15 2016, 3:42 PM
phil committed rS298063: Import libxo 0.4.7.
Import libxo 0.4.7
Apr 15 2016, 3:42 PM

Apr 12 2016

phil committed rS297895: add FreeBSD header to copied files.
add FreeBSD header to copied files
Apr 12 2016, 11:38 PM