Page MenuHomeFreeBSD

vmstat: Fix duplicate key in libxo output
ClosedPublic

Authored by allanjude on Sep 16 2017, 4:17 PM.

Details

Summary

In the libxo output from vmstat, the number of pages that have been paged out uses the same key name as the number of time
pages have been paged. Appears to have been a typo or copy-pasto.

Submitted By: Yavuz Tanriverdi <stemix@gmail.com>
PR: 222198

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Sep 18 2017, 4:40 PM
In D12395#258660, @phil wrote:

FWIW, this bug is mine, from the original patch sets:

https://github.com/Juniper/libxo/blob/master/patches/vmstat.patch#L532

Thanks,
Phil

Hi @phil

i discovered this when executing go vet command

https://github.com/sternix/gobsdinfo/blob/master/mem/sum.go#L24

" sum.go:25: struct field VnodePageOutPages repeats json tag "vnode-page-outs" also at sum.go:23 "

FYI

Looks good. Thanks....

This revision was automatically updated to reflect the committed changes.