Page MenuHomeFreeBSD

rodrigc (Craig Rodrigues)
User

Projects

User Details

User Since
May 16 2014, 3:06 PM (227 w, 10 h)

Recent Activity

Jan 3 2018

rodrigc added a reviewer for D13745: Update to buildbot 0.9.15: Python.
Jan 3 2018, 8:06 AM
rodrigc created D13745: Update to buildbot 0.9.15.
Jan 3 2018, 8:06 AM

Dec 15 2017

rodrigc committed rP455028: devel/buildbot*: Rename all buildbot ports.
devel/buildbot*: Rename all buildbot ports
Dec 15 2017, 12:07 AM
rodrigc closed D12499: devel/buildbot*: Rename all buildbot ports.
Dec 15 2017, 12:06 AM

Nov 28 2017

rodrigc updated the diff for D12499: devel/buildbot*: Rename all buildbot ports.

Updating

Nov 28 2017, 10:12 AM

Nov 14 2017

rodrigc added a comment to D12499: devel/buildbot*: Rename all buildbot ports.

Hey @grembo can I proceed with this commit?

Nov 14 2017, 8:31 AM
rodrigc updated the diff for D12499: devel/buildbot*: Rename all buildbot ports.

Bump up py-mock dependency

Nov 14 2017, 8:30 AM

Oct 10 2017

rodrigc closed D12479: devel/buildbot*: Update to 0.9.11, Add.

Landed in rP450642

Oct 10 2017, 8:41 AM

Oct 4 2017

rodrigc added a comment to D12499: devel/buildbot*: Rename all buildbot ports.

@koobs I removed concurrent from these Makefiles. We aren't ready to do that yet, since there are conflicts.
The port works on Python 3 though, so removing 2.7 as a restriction is OK.

Oct 4 2017, 9:44 AM
rodrigc updated the diff for D12499: devel/buildbot*: Rename all buildbot ports.

We are not ready to make these ports as concurrent yet.
There are still some conflicts.

Oct 4 2017, 9:42 AM
rodrigc updated the diff for D12499: devel/buildbot*: Rename all buildbot ports.

Sort some things.

Oct 4 2017, 9:39 AM

Sep 27 2017

rodrigc added inline comments to D12499: devel/buildbot*: Rename all buildbot ports.
Sep 27 2017, 7:01 PM
rodrigc added inline comments to D12499: devel/buildbot*: Rename all buildbot ports.
Sep 27 2017, 7:00 PM
rodrigc updated the diff for D12499: devel/buildbot*: Rename all buildbot ports.

Update patch

Sep 27 2017, 7:00 PM
rodrigc updated the diff for D12499: devel/buildbot*: Rename all buildbot ports.

Update patch

Sep 27 2017, 6:51 PM
rodrigc added a comment to D12479: devel/buildbot*: Update to 0.9.11, Add.

@koobs why wasn't this review updated after I committed rP450642 ?

Sep 27 2017, 6:49 PM

Sep 26 2017

rodrigc added a reviewer for D12499: devel/buildbot*: Rename all buildbot ports: sunpoet.
Sep 26 2017, 5:29 AM
rodrigc created D12499: devel/buildbot*: Rename all buildbot ports.
Sep 26 2017, 5:28 AM
rodrigc committed rP450642: devel/buildbot*: Update to 0.9.11, Add buildbot-grid-view.
devel/buildbot*: Update to 0.9.11, Add buildbot-grid-view
Sep 26 2017, 4:56 AM

Sep 24 2017

rodrigc added a comment to D12479: devel/buildbot*: Update to 0.9.11, Add.

The 4 failing tests looks pretty minor and not worth blocking progress on this.

Sep 24 2017, 4:08 AM
rodrigc updated the diff for D12479: devel/buildbot*: Update to 0.9.11, Add.

Fix test targets. Cannot run inside WRKSRC, must run against installed versions.
Put trial temporary files in a separate tmp directory.

Sep 24 2017, 4:08 AM
rodrigc updated the test plan for D12479: devel/buildbot*: Update to 0.9.11, Add.
Sep 24 2017, 3:46 AM
rodrigc added a comment to D12479: devel/buildbot*: Update to 0.9.11, Add.

portlint complained about the patch file, so I regenerated it.

Sep 24 2017, 3:41 AM
rodrigc added a comment to D12479: devel/buildbot*: Update to 0.9.11, Add.

This looks OK to land, unless the gridview port addition can be made in a separate commit (preferred), either before this commit if it supports the current port version, or after if it requires 0.9.11.

If this change requires gridview to be added (a new compulsory module, etc), then looks good to go (pending maintainer approval)

Sep 24 2017, 2:51 AM
rodrigc updated the summary of D12479: devel/buildbot*: Update to 0.9.11, Add.
Sep 24 2017, 2:39 AM
rodrigc updated the test plan for D12479: devel/buildbot*: Update to 0.9.11, Add.
Sep 24 2017, 2:37 AM
rodrigc updated the diff for D12479: devel/buildbot*: Update to 0.9.11, Add.
  • Remove concurrent
  • Add back python:-2.7
Sep 24 2017, 2:30 AM
rodrigc updated the diff for D12479: devel/buildbot*: Update to 0.9.11, Add.
  • Use https://
  • Use ${PYTHON_CMD} -m twisted.trial to invoke test utility
Sep 24 2017, 1:15 AM
rodrigc updated the diff for D12479: devel/buildbot*: Update to 0.9.11, Add.
  • Add missing periods.
  • Remove patch which is no longer needed.
  • Remove MY_DEPENDS
Sep 24 2017, 12:51 AM
rodrigc added a comment to D12479: devel/buildbot*: Update to 0.9.11, Add.

It looks like devel/buildbot/files/patch-buildbot-secrets is out of date. It still applies, but the result is that buildbot/secrets/providers/{base.py, file.py, vault.py} get duped, and there may be similar errors in other files too. Running "make test" in devel/buildbot detects that error. You should investigate. We can probably delete the entire patch.

Sep 24 2017, 12:48 AM
rodrigc added inline comments to D12479: devel/buildbot*: Update to 0.9.11, Add.
Sep 24 2017, 12:35 AM

Sep 23 2017

rodrigc updated the test plan for D12479: devel/buildbot*: Update to 0.9.11, Add.
Sep 23 2017, 7:59 PM
rodrigc updated the test plan for D12479: devel/buildbot*: Update to 0.9.11, Add.
Sep 23 2017, 7:58 PM
rodrigc updated the summary of D12479: devel/buildbot*: Update to 0.9.11, Add.
Sep 23 2017, 7:56 PM
rodrigc created D12479: devel/buildbot*: Update to 0.9.11, Add.
Sep 23 2017, 7:51 PM
rodrigc committed rP450460: Update to 17.9.0.
Update to 17.9.0
Sep 23 2017, 5:00 PM
rodrigc closed D12478: Update to Twisted 17.9.0.
Sep 23 2017, 5:00 PM
rodrigc updated the diff for D12478: Update to Twisted 17.9.0.

Remove PORTREVISION

Sep 23 2017, 4:45 PM
rodrigc added a reviewer for D12478: Update to Twisted 17.9.0: Python.
Sep 23 2017, 4:07 PM
rodrigc created D12478: Update to Twisted 17.9.0.
Sep 23 2017, 4:06 PM

Mar 28 2017

rodrigc added a reviewer for D10162: Summary: Change to buildbot 0.9.5: freebsd-python-list.
Mar 28 2017, 9:45 AM
rodrigc created D10162: Summary: Change to buildbot 0.9.5.
Mar 28 2017, 9:44 AM
rodrigc committed rP437099: Move from google code to github.
Move from google code to github
Mar 28 2017, 8:06 AM
rodrigc closed D10159: Update dns/hostdb to use GitHub by committing rP437099: Move from google code to github.
Mar 28 2017, 8:06 AM
rodrigc updated the diff for D10159: Update dns/hostdb to use GitHub.

Remove code.google.com URL

Mar 28 2017, 7:14 AM
rodrigc updated the diff for D10159: Update dns/hostdb to use GitHub.

Remove GH_PROJECT

Mar 28 2017, 6:50 AM
rodrigc added a comment to D10159: Update dns/hostdb to use GitHub.

Tested with:
poudriere testport -j 10 -p development -o dns/hostdb

Mar 28 2017, 6:18 AM
rodrigc added a reviewer for D10159: Update dns/hostdb to use GitHub: Ports Committers.
Mar 28 2017, 6:16 AM
rodrigc updated the diff for D10159: Update dns/hostdb to use GitHub.

Fix whitespace

Mar 28 2017, 6:13 AM
rodrigc created D10159: Update dns/hostdb to use GitHub.
Mar 28 2017, 6:11 AM

Sep 1 2016

rodrigc added a comment to D7732: Don't bake all of CC/CPP/CXX into CFLAGS; filter out cross-compiler arguments.

Wow, this just is just NASTY.
Thanks for fixing this, please commit the fix ASAP.

Sep 1 2016, 1:58 AM
rodrigc accepted D7732: Don't bake all of CC/CPP/CXX into CFLAGS; filter out cross-compiler arguments.

I say, let's try this out and give it a shot to shut up the test failures.
Nice investigatory work!

Sep 1 2016, 1:43 AM

Jun 7 2016

rodrigc added a comment to D4744: Fix ypldap(8) and turn it a feature ready..

Thanks for this. Have you tested ypldap authentication on FreeBSD against a real LDAP server?
Has anyone tried ypldap against Active Directory?

Jun 7 2016, 7:48 AM
rodrigc added inline comments to rS301536: Add an entry on rc.conf(5) explaining the new options.
Jun 7 2016, 7:00 AM

Jun 6 2016

rodrigc added a comment to D4744: Fix ypldap(8) and turn it a feature ready..

@araujo Thanks for the rc.d script in rS301480 . Can you modify the ypldap.8 man page and in the HISTORY section, add a sentence to mention that ypldap first appeared in FreeBSD 11?

Jun 6 2016, 9:40 PM

May 31 2016

rodrigc added a comment to D4744: Fix ypldap(8) and turn it a feature ready..

@araujo Thanks. code freeze is June 10, so try to finish it before that.

May 31 2016, 8:29 AM

May 28 2016

rodrigc added a comment to D4744: Fix ypldap(8) and turn it a feature ready..

@araujo There is no rc.d script for ypldap. Do you think you have time to write one up before the FreeBSD 11 code freeze?
OpenBSD has a script: http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/etc/rc.d/ypldap
but their startup script system is different from FreeBSD.

May 28 2016, 5:21 AM

May 26 2016

rodrigc committed rP415908: - Update to 2.0.0.
- Update to 2.0.0
May 26 2016, 7:24 PM
rodrigc closed D6551: Update security/py-paramiko to 2.0.0 by committing rP415908: - Update to 2.0.0.
May 26 2016, 7:24 PM

May 25 2016

rodrigc added a comment to D6551: Update security/py-paramiko to 2.0.0.

poudriere build log:

May 25 2016, 1:47 AM
rodrigc added a reviewer for D6551: Update security/py-paramiko to 2.0.0: Python.
May 25 2016, 1:42 AM
rodrigc retitled D6551: Update security/py-paramiko to 2.0.0 from to Update security/py-paramiko to 2.0.0.
May 25 2016, 1:41 AM

Apr 7 2016

rodrigc accepted D5851: Fix printing out binary/UTF-8 characters in kyua 0.11 by backporting fix for issue # 136.

Thanks for fixing this.

Apr 7 2016, 9:41 PM

Feb 8 2016

rodrigc added a comment to rS293801: ypldap(8) is a feature ready to be used to translate nis(8) database to ldap(3)..

@araujo Can you add an rc.d script for ypldap? OpenBSD has this: http://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/src/etc/rc.d/ypldap
but FreeBSD's rc.d system is slightly different so we cannot use it directly.

Feb 8 2016, 8:31 AM

Jan 29 2016

rodrigc accepted D5110: Clean up Warning:unused-but-set-variable spotted by gcc-4.9..

OK, but get approval from mps experts.

Jan 29 2016, 4:34 AM
rodrigc added a reviewer for D5110: Clean up Warning:unused-but-set-variable spotted by gcc-4.9.: mav.
Jan 29 2016, 4:32 AM
rodrigc accepted D5109: Clean up Warning:unused-but-set-variable spotted by gcc-4.9..

OK, but get approval from cam expert.

Jan 29 2016, 4:29 AM
rodrigc added a reviewer for D5109: Clean up Warning:unused-but-set-variable spotted by gcc-4.9.: mav.
Jan 29 2016, 4:28 AM

Jan 26 2016

rodrigc accepted D5042: Cleanup unused-but-set-variable spotted by gcc-4.9.

Looks OK, but get approval from bhyve maintainers before committing.

Jan 26 2016, 3:30 AM
rodrigc added a comment to D4973: syslogd(8) add a protection against OOM killer..

I don't really like this patch at all.
This is a big behavioral change to syslogd.
Even though there is some special case because this is logging,
at some point you could ask, why not have this option in every daemon running on FreeBSD?

Jan 26 2016, 3:29 AM

Jan 22 2016

rodrigc accepted D4970: Switch from FD_SETSIZE to getdtablesize()..
Jan 22 2016, 2:33 AM

Jan 14 2016

rodrigc added inline comments to D4744: Fix ypldap(8) and turn it a feature ready..
Jan 14 2016, 1:09 AM

Jan 7 2016

rodrigc added inline comments to D4744: Fix ypldap(8) and turn it a feature ready..
Jan 7 2016, 3:11 AM
rodrigc accepted D4778: MFC: 292969.
Jan 7 2016, 3:07 AM
rodrigc accepted D4777: MFC: 292970.
Jan 7 2016, 3:07 AM
rodrigc accepted D4776: MFC: 292971.
Jan 7 2016, 3:06 AM
rodrigc accepted D4775: MFC 292972.
Jan 7 2016, 3:05 AM
rodrigc accepted D4774: MFC 292980.
Jan 7 2016, 3:03 AM
rodrigc accepted D4773: MFC 292982 and 292981.
Jan 7 2016, 3:02 AM
rodrigc added inline comments to D4744: Fix ypldap(8) and turn it a feature ready..
Jan 7 2016, 3:00 AM

Dec 31 2015

rodrigc accepted D4734: Clean up unused-but-set-variable spotted by gcc-4.9..
Dec 31 2015, 6:57 AM
rodrigc accepted D4719: Clean up Warning: unused-but-set-variable gcc4.9..
Dec 31 2015, 6:56 AM

Dec 30 2015

rodrigc accepted D4733: Clean up unused-but-set-variable spotted by gcc-4.9..
Dec 30 2015, 2:09 PM

Dec 23 2015

rodrigc committed rS292646: Remove extraneous characters.
Remove extraneous characters
Dec 23 2015, 7:29 AM

Dec 22 2015

rodrigc committed rS292612: Refer to creating Phabricator Herald notifications.
Refer to creating Phabricator Herald notifications
Dec 22 2015, 5:46 PM
rodrigc closed D4623: MAINTAINERS: refer to creating Phabricator Herald notifications by committing rS292612: Refer to creating Phabricator Herald notifications.
Dec 22 2015, 5:46 PM
rodrigc committed rS292580: Add libxo support to jls.
Add libxo support to jls
Dec 22 2015, 12:59 AM
rodrigc closed D4452: Convert jls to use libxo by committing rS292580: Add libxo support to jls.
Dec 22 2015, 12:58 AM
rodrigc commandeered D4452: Convert jls to use libxo.
Dec 22 2015, 12:34 AM
rodrigc accepted D4452: Convert jls to use libxo.

Macro shipit:

Dec 22 2015, 12:31 AM

Dec 19 2015

rodrigc updated the diff for D4623: MAINTAINERS: refer to creating Phabricator Herald notifications.

Take @allanjude's update.

Dec 19 2015, 5:50 AM
rodrigc updated subscribers of D4623: MAINTAINERS: refer to creating Phabricator Herald notifications.
Dec 19 2015, 5:39 AM
rodrigc retitled D4623: MAINTAINERS: refer to creating Phabricator Herald notifications from to MAINTAINERS: refer to creating Phabricator Herald notifications.
Dec 19 2015, 5:38 AM

Dec 18 2015

rodrigc requested changes to D2692: Silence several set but not used variables, spotted by CLANG..

I agree with @kib. I don't like this patch in its current form.

Dec 18 2015, 8:07 PM

Dec 11 2015

rodrigc accepted D4495: Fix minor typos introduced on r292084.
Dec 11 2015, 7:18 AM

Dec 9 2015

rodrigc committed rS292024: Remove NO_WERROR, after fix from r292023..
Remove NO_WERROR, after fix from r292023.
Dec 9 2015, 7:25 PM
rodrigc committed rS292023: Merge from OpenBSD:.
Merge from OpenBSD:
Dec 9 2015, 7:22 PM
rodrigc committed rS292022: Merge from OpenBSD:.
Merge from OpenBSD:
Dec 9 2015, 7:21 PM
rodrigc committed rS292021: Merge from OpenBSD:.
Merge from OpenBSD:
Dec 9 2015, 7:19 PM
rodrigc updated the diff for D4452: Convert jls to use libxo.

Remove stdout

Dec 9 2015, 4:13 AM