Updating

Hey @grembo can I proceed with this commit?

Bump up py-mock dependency

Landed in rP450642

@koobs I removed concurrent from these Makefiles. We aren't ready to do that yet, since there are conflicts.
The port works on Python 3 though, so removing 2.7 as a restriction is OK.

We are not ready to make these ports as concurrent yet.
There are still some conflicts.

Sort some things.

Update patch

Update patch

@koobs why wasn't this review updated after I committed rP450642 ?

The 4 failing tests looks pretty minor and not worth blocking progress on this.

Fix test targets. Cannot run inside WRKSRC, must run against installed versions.
Put trial temporary files in a separate tmp directory.

portlint complained about the patch file, so I regenerated it.

In D12479#258670, @koobs wrote:

This looks OK to land, unless the gridview port addition can be made in a separate commit (preferred), either before this commit if it supports the current port version, or after if it requires 0.9.11.

If this change requires gridview to be added (a new compulsory module, etc), then looks good to go (pending maintainer approval)

• Remove concurrent
• Add back python:-2.7

• Use https://
• Use ${PYTHON_CMD} -m twisted.trial to invoke test utility

• Add missing periods.
• Remove patch which is no longer needed.
• Remove MY_DEPENDS

In D12479#258626, @asomers wrote:

It looks like devel/buildbot/files/patch-buildbot-secrets is out of date. It still applies, but the result is that buildbot/secrets/providers/{base.py, file.py, vault.py} get duped, and there may be similar errors in other files too. Running "make test" in devel/buildbot detects that error. You should investigate. We can probably delete the entire patch.

Remove PORTREVISION

Remove code.google.com URL

Remove GH_PROJECT

Tested with:
poudriere testport -j 10 -p development -o dns/hostdb

Fix whitespace

Wow, this just is just NASTY.
Thanks for fixing this, please commit the fix ASAP.

I say, let's try this out and give it a shot to shut up the test failures.
Nice investigatory work!

Thanks for this. Have you tested ypldap authentication on FreeBSD against a real LDAP server?
Has anyone tried ypldap against Active Directory?

@araujo Thanks for the rc.d script in rS301480 . Can you modify the ypldap.8 man page and in the HISTORY section, add a sentence to mention that ypldap first appeared in FreeBSD 11?

@araujo Thanks. code freeze is June 10, so try to finish it before that.

@araujo There is no rc.d script for ypldap. Do you think you have time to write one up before the FreeBSD 11 code freeze?
OpenBSD has a script: http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/etc/rc.d/ypldap
but their startup script system is different from FreeBSD.

poudriere build log:

Thanks for fixing this.

@araujo Can you add an rc.d script for ypldap? OpenBSD has this: http://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/src/etc/rc.d/ypldap
but FreeBSD's rc.d system is slightly different so we cannot use it directly.

OK, but get approval from mps experts.

OK, but get approval from cam expert.

Looks OK, but get approval from bhyve maintainers before committing.

I don't really like this patch at all.
This is a big behavioral change to syslogd.
Even though there is some special case because this is logging,
at some point you could ask, why not have this option in every daemon running on FreeBSD?

Take @allanjude's update.