Clean up Warning:unused-but-set-variable spotted by gcc-4.9.
ClosedPublic
Actions

Authored by araujo on Jan 29 2016, 3:54 AM.

Tags

None

Referenced Files

	F174256539: D5110.diff
	Thu, Oct 1, 7:03 PM

	Unknown Object (File)
	Tue, Sep 29, 12:54 PM

	Unknown Object (File)
	Sat, Sep 26, 7:41 AM

	Unknown Object (File)
	Sat, Sep 26, 7:29 AM

	Unknown Object (File)
	Tue, Sep 22, 2:48 PM

	Unknown Object (File)
	Fri, Sep 11, 6:26 PM

	Unknown Object (File)
	Tue, Sep 8, 5:28 PM

	Unknown Object (File)
	Tue, Sep 8, 10:30 AM

View All Files

Subscribers

imp

Details

Reviewers

• rodrigc
slm
bapt
mav

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2305
Build 2314: arc lint + arc unit

Event Timeline

araujo updated this revision to Diff 12807.Jan 29 2016, 3:54 AM

araujo retitled this revision from to Clean up Warning:unused-but-set-variable spotted by gcc-4.9..

araujo updated this object.

araujo edited the test plan for this revision. (Show Details)

araujo added reviewers: • rodrigc, bapt, slm.

Herald added a subscriber: imp. · View Herald TranscriptJan 29 2016, 3:54 AM

OK, but get approval from mps experts.

This revision is now accepted and ready to land.Jan 29 2016, 4:34 AM

It looks fine to me, but it would be good to get comments from LSI/Avago (slm@).

Looks fine. I modified the mapping_get_dev_info function and neglected to remove the unused variable. The 'sg' variable has been there from the beginning it looks like, but ken@ made the changes to the SMP part.

slm accepted this revision.Jan 29 2016, 5:18 PM

slm edited edge metadata.

Committed: https://svnweb.freebsd.org/changeset/base/295113

Revision Contents
Changeset List

Path

Size

sys/

dev/

mps/

mps_mapping.c

4 lines

mps_sas.c

2 lines

Diff 12807

View Options

sys/dev/mps/mps_mapping.c