Page MenuHomeFreeBSD

slm (Stephen McConnell)
User

Projects

User Details

User Since
Mar 25 2015, 8:52 PM (220 w, 4 d)

Recent Activity

Apr 16 2018

slm accepted D15073: Invalidate reply descriptors earlier.
Apr 16 2018, 4:36 PM

Mar 14 2018

slm accepted D12776: Fix mps deadlock when handling panic.
Mar 14 2018, 9:08 PM

Feb 20 2018

slm added inline comments to D14403: Fix mpr device mapper fallback logic for busses with multiple expanders..
Feb 20 2018, 6:26 PM
slm added inline comments to D14403: Fix mpr device mapper fallback logic for busses with multiple expanders..
Feb 20 2018, 6:05 PM
slm requested changes to D14403: Fix mpr device mapper fallback logic for busses with multiple expanders..
Feb 20 2018, 5:24 PM

Feb 13 2018

slm accepted D14344: Fix non-64-bit platform build by printing bus_addr_t values using %#jx.
Feb 13 2018, 3:59 PM

Nov 13 2017

slm added a comment to D12776: Fix mps deadlock when handling panic.

Also, if this works for mps it should go into mpr as well.

Nov 13 2017, 5:00 PM
slm requested changes to D12776: Fix mps deadlock when handling panic.
Nov 13 2017, 4:56 PM

Nov 2 2017

slm accepted D12901: Fix mpr(4) panics caused by bad drive mapping tables.
Nov 2 2017, 2:55 PM

Nov 1 2017

slm requested changes to D12901: Fix mpr(4) panics caused by bad drive mapping tables.
Nov 1 2017, 10:26 PM

Jun 2 2017

slm added a comment to D11018: Use polling for SSU command during shutdown.

Yes, I saw Harry's emails. So, I'll need to do some of my own testing here to make sure things work at shutdown without a panic. I also saw that the lock changes did not work for Harry, so I'll need to look into that some more.

Jun 2 2017, 4:59 PM

Jun 1 2017

slm created D11018: Use polling for SSU command during shutdown.
Jun 1 2017, 7:39 PM
slm committed rS319446: MFC r318895: Fix several problems with mapping code in mps(4)..
MFC r318895: Fix several problems with mapping code in mps(4).
Jun 1 2017, 4:55 PM
slm committed rS319445: MFC r318895: Fix several problems with mapping code in mps(4)..
MFC r318895: Fix several problems with mapping code in mps(4).
Jun 1 2017, 4:54 PM
slm committed rS319436: MFC r286567, r286568, r289426, r289429, r295113, r295286, r299367, r299369,.
MFC r286567, r286568, r289426, r289429, r295113, r295286, r299367, r299369,
Jun 1 2017, 3:43 PM
slm committed rS319435: MFC r308217, r308301, r311958, r312437, r318188, r318427, r318679.
MFC r308217, r308301, r311958, r312437, r318188, r318427, r318679
Jun 1 2017, 3:39 PM

May 25 2017

slm committed rS318896: Fix several problems with mapping code..
Fix several problems with mapping code.
May 25 2017, 7:20 PM
slm closed D10861: Fix several problems with mapping code in the mpr(4) driver by committing rS318896: Fix several problems with mapping code..
May 25 2017, 7:20 PM
slm committed rS318895: Fix several problems with mapping code..
Fix several problems with mapping code.
May 25 2017, 7:14 PM
slm closed D10878: Fix several problems with mapping code in the mps(4) driver by committing rS318895: Fix several problems with mapping code..
May 25 2017, 7:14 PM

May 24 2017

slm added inline comments to D10861: Fix several problems with mapping code in the mpr(4) driver.
May 24 2017, 8:39 PM
slm added inline comments to D10861: Fix several problems with mapping code in the mpr(4) driver.
May 24 2017, 8:08 PM
slm added inline comments to D10861: Fix several problems with mapping code in the mpr(4) driver.
May 24 2017, 6:13 PM
slm added inline comments to D10861: Fix several problems with mapping code in the mpr(4) driver.
May 24 2017, 3:16 PM

May 23 2017

slm added inline comments to D10861: Fix several problems with mapping code in the mpr(4) driver.
May 23 2017, 10:27 PM
slm added inline comments to D10861: Fix several problems with mapping code in the mpr(4) driver.
May 23 2017, 10:02 PM
slm added inline comments to D10861: Fix several problems with mapping code in the mpr(4) driver.
May 23 2017, 9:27 PM
slm created D10878: Fix several problems with mapping code in the mps(4) driver.
May 23 2017, 8:42 PM

May 22 2017

slm committed rS318679: Fix powerpc compiler error..
Fix powerpc compiler error.
May 22 2017, 8:27 PM
slm created D10861: Fix several problems with mapping code in the mpr(4) driver.
May 22 2017, 6:59 PM

May 18 2017

slm committed rS318427: Add tri-mode support (SAS/SATA/PCIe)..
Add tri-mode support (SAS/SATA/PCIe).
May 18 2017, 9:16 AM
slm closed D10095: Add tri-mode support to mpr by committing rS318427: Add tri-mode support (SAS/SATA/PCIe)..
May 18 2017, 9:16 AM

Mar 31 2017

slm updated the diff for D10095: Add tri-mode support to mpr.

I'm not sure there is a better way to update my changes without checking them in first, which I didn't do. So, the changes I made from the original review are:

Mar 31 2017, 10:32 PM

Mar 23 2017

slm added inline comments to D10095: Add tri-mode support to mpr.
Mar 23 2017, 4:42 PM
slm added inline comments to D10095: Add tri-mode support to mpr.
Mar 23 2017, 4:17 PM

Mar 22 2017

slm added inline comments to D10095: Add tri-mode support to mpr.
Mar 22 2017, 9:38 PM
slm added inline comments to D10095: Add tri-mode support to mpr.
Mar 22 2017, 8:56 PM
slm added inline comments to D10095: Add tri-mode support to mpr.
Mar 22 2017, 7:08 PM
slm created D10095: Add tri-mode support to mpr.
Mar 22 2017, 3:54 PM

Jan 30 2017

slm accepted D9364: Initialize a stack variable in mprsas_get_sas_address_for_sata_disk.
Jan 30 2017, 7:05 PM
slm added inline comments to D9364: Initialize a stack variable in mprsas_get_sas_address_for_sata_disk.
Jan 30 2017, 6:49 PM
slm added inline comments to D9364: Initialize a stack variable in mprsas_get_sas_address_for_sata_disk.
Jan 30 2017, 6:40 PM

Jan 19 2017

slm accepted D9243: Refactor MPR/MPS interrupt setup code..
Jan 19 2017, 9:49 PM
slm added inline comments to D9243: Refactor MPR/MPS interrupt setup code..
Jan 19 2017, 6:23 PM
slm accepted D9238: Rework the MPR/MPS debug print API..

Looks good Scott. I like it.

Jan 19 2017, 6:07 PM

Jan 4 2017

slm added inline comments to D9038: Always null-terminate ccb_pathinq.(sim_vid|hba_vid|dev_name) (part 2).
Jan 4 2017, 5:29 PM
slm accepted D9038: Always null-terminate ccb_pathinq.(sim_vid|hba_vid|dev_name) (part 2).
Jan 4 2017, 5:09 PM

Jan 3 2017

slm accepted D8880: misc minor fixes in mpr(4).

Looks good to me. Thanks!

Jan 3 2017, 5:28 PM

Jul 20 2016

slm committed rS303089: MFC r302673.
MFC r302673
Jul 20 2016, 2:38 PM

Jul 19 2016

slm committed rS303029: MFC r302673.
MFC r302673
Jul 19 2016, 4:46 PM

Jul 12 2016

slm committed rS302673: Use real values to calculate Max I/O size instead of guessing..
Use real values to calculate Max I/O size instead of guessing.
Jul 12 2016, 7:34 PM
slm closed D7043: Use real values to calculate Max I/O size instead of guessing. by committing rS302673: Use real values to calculate Max I/O size instead of guessing..
Jul 12 2016, 7:34 PM

Jul 6 2016

slm updated the diff for D7043: Use real values to calculate Max I/O size instead of guessing..

Went ahead and added mpr changes for this to the same review. There are only slight differences between how the mps and mpr drivers handle the max I/O calculation.

Jul 6 2016, 6:27 PM

Jul 5 2016

slm updated the diff for D7043: Use real values to calculate Max I/O size instead of guessing..

Adding mps.4 man page changes to the review.

Jul 5 2016, 9:37 PM
slm updated the diff for D7043: Use real values to calculate Max I/O size instead of guessing..

Rewrote a little to use a new sysctl variable (max_io_pages). This is the max number of pages that a user wants to use per I/O. The driver will use the lesser of this new value and the calculated value from IOCFacts. The default for max_io_pages is -1, meaning the driver will use IOCFacts.

Jul 5 2016, 6:44 PM

Jul 1 2016

slm added a comment to D7043: Use real values to calculate Max I/O size instead of guessing..

I could default the user value to 0, which would force the driver to use the calculated value. If not 0, then use the user value. Otherwise, we don't really know what to default the value to and we're back to using a guess. Sound OK?

Jul 1 2016, 7:12 PM
slm added a comment to D7043: Use real values to calculate Max I/O size instead of guessing..

OK. Sure, that sounds easy enough.

Jul 1 2016, 7:10 PM
slm added a comment to D7043: Use real values to calculate Max I/O size instead of guessing..

Scott, do you mean to make it larger than the calculated value? If larger, there is a danger that the I/O will fail because the number of chains in the I/O could exceed the MaxChainDepth of the controller. But, the calculated value is also based on the smallest SG element allowed for every SG element (PAGE_SIZE), so the max I/O can actually be much larger than the calculated max I/O. Maybe a warning message could be printed if the user's max I/O size is larger than the calculated size. Would that work?

Jul 1 2016, 6:45 PM

Jun 30 2016

slm added a comment to D7043: Use real values to calculate Max I/O size instead of guessing..

Yes, I can do it for mpr too, but it will be a little different due to the changes with Chain Segment Size. I just need to look at it and do the right thing.

Jun 30 2016, 8:36 PM
slm retitled D7043: Use real values to calculate Max I/O size instead of guessing. from to Use real values to calculate Max I/O size instead of guessing..
Jun 30 2016, 8:22 PM

Jun 27 2016

slm committed rS302225: MFC r302031.
MFC r302031
Jun 27 2016, 5:01 PM

Jun 20 2016

slm committed rS302031: - No log bit in IOCStatus and endian-safe changes..
- No log bit in IOCStatus and endian-safe changes.
Jun 20 2016, 6:15 PM
slm closed D6872: Port some changes from mpr to the mps driver. by committing rS302031: - No log bit in IOCStatus and endian-safe changes..
Jun 20 2016, 6:15 PM

Jun 16 2016

slm added inline comments to D6872: Port some changes from mpr to the mps driver..
Jun 16 2016, 7:27 PM
slm retitled D6872: Port some changes from mpr to the mps driver. from to Port some changes from mpr to the mps driver..
Jun 16 2016, 7:11 PM

May 16 2016

slm committed rS299967: MFC r299276.
MFC r299276
May 16 2016, 7:33 PM
slm committed rS299962: MFC r299263, r299265, r299266, r299267, r299268, r299269, r299270, r299271,.
MFC r299263, r299265, r299266, r299267, r299268, r299269, r299270, r299271,
May 16 2016, 6:48 PM

May 9 2016

slm committed rS299276: Updates to mpr driver man page..
Updates to mpr driver man page.
May 9 2016, 4:43 PM
slm closed D6104: Updates to mpr.4 man page by committing rS299276: Updates to mpr driver man page..
May 9 2016, 4:43 PM
slm committed rS299275: Bump version of mpr driver to 13.00.00.00-fbsd.
Bump version of mpr driver to 13.00.00.00-fbsd
May 9 2016, 4:39 PM
slm committed rS299274: Disks can go missing until a reboot is done in some cases..
Disks can go missing until a reboot is done in some cases.
May 9 2016, 4:37 PM
slm closed D6102: Disks can go missing and not return until a reboot. by committing rS299274: Disks can go missing until a reboot is done in some cases..
May 9 2016, 4:37 PM
slm closed D6099: Move check for (done_ccb == NULL) by committing rS299272: done_ccb pointer can be used if it is NULL..
May 9 2016, 4:34 PM
slm committed rS299272: done_ccb pointer can be used if it is NULL..
done_ccb pointer can be used if it is NULL.
May 9 2016, 4:34 PM
slm committed rS299271: Use callout_reset_sbt() instead of callout_reset() if FreeBSD ver is >= 1000029.
Use callout_reset_sbt() instead of callout_reset() if FreeBSD ver is >= 1000029
May 9 2016, 4:32 PM
slm closed D6101: Use callout_reset_sbt() instead of callout_reset() only if FreeBSD version is at least 1100048. by committing rS299271: Use callout_reset_sbt() instead of callout_reset() if FreeBSD ver is >= 1000029.
May 9 2016, 4:32 PM
slm committed rS299270: No need to set the MPRSAS_SHUTDOWN flag because it's never used..
No need to set the MPRSAS_SHUTDOWN flag because it's never used.
May 9 2016, 4:29 PM
slm committed rS299269: Fix possible use of invalid pointer..
Fix possible use of invalid pointer.
May 9 2016, 4:26 PM
slm closed D6100: Prevent use of invalid pointer when getting target ID by committing rS299269: Fix possible use of invalid pointer..
May 9 2016, 4:26 PM
slm committed rS299268: Change logging level for a debug string to use MPR_LOG instead of MPR_INFO..
Change logging level for a debug string to use MPR_LOG instead of MPR_INFO.
May 9 2016, 4:24 PM
slm committed rS299267: No log bit in IOCStatus and endian-safe changes..
No log bit in IOCStatus and endian-safe changes.
May 9 2016, 4:21 PM
slm closed D6097: IOCSatatus Mask and Endian fixes by committing rS299267: No log bit in IOCStatus and endian-safe changes..
May 9 2016, 4:21 PM
slm committed rS299266: Add support for the Broadcom (Avago/LSI) 9305 16 and 24 port HBA's..
Add support for the Broadcom (Avago/LSI) 9305 16 and 24 port HBA's.
May 9 2016, 4:19 PM
slm closed D6098: Add support for the Avago 9305 16 and 24 port HBA's. by committing rS299266: Add support for the Broadcom (Avago/LSI) 9305 16 and 24 port HBA's..
May 9 2016, 4:19 PM
slm committed rS299265: Several style changes and add copyrights for 2016..
Several style changes and add copyrights for 2016.
May 9 2016, 4:16 PM
slm closed D6103: Several style changes and add copyrights for 2016. by committing rS299265: Several style changes and add copyrights for 2016..
May 9 2016, 4:16 PM
slm closed D6096: Update MPI headers to version 42. by committing rS299263: Update MPI headers to version 42..
May 9 2016, 4:12 PM
slm committed rS299263: Update MPI headers to version 42..
Update MPI headers to version 42.
May 9 2016, 4:12 PM
slm added inline comments to D6104: Updates to mpr.4 man page.
May 9 2016, 3:43 PM

May 5 2016

slm accepted D6210: mpr(4) and mps(4) shouldn't indefinitely retry for "terminated ioc" errors.
May 5 2016, 3:21 PM

Apr 29 2016

slm updated the diff for D6103: Several style changes and add copyrights for 2016..

Add back blank lines at the top of the requested functions.

Apr 29 2016, 9:38 PM
slm updated the diff for D6098: Add support for the Avago 9305 16 and 24 port HBA's..

Fix typo in comment.

Apr 29 2016, 9:37 PM
slm updated the diff for D6101: Use callout_reset_sbt() instead of callout_reset() only if FreeBSD version is at least 1100048..

Use FreeBSD version 1000029 instead of 1100048.

Apr 29 2016, 9:35 PM
slm updated the diff for D6096: Update MPI headers to version 42..

Removed duplicated define.

Apr 29 2016, 9:34 PM
slm updated the diff for D6104: Updates to mpr.4 man page.

Updated with Warren's initial comments.

Apr 29 2016, 9:32 PM

Apr 28 2016

slm added a comment to D6104: Updates to mpr.4 man page.

Wow. That's a lot of stuff. Who knew there could be so much wrong in such a little document :) I appreciate the feedback. I'll make the changes as suggested and put up a patch within a couple of days.

Apr 28 2016, 5:20 PM

Apr 26 2016

slm added inline comments to D6098: Add support for the Avago 9305 16 and 24 port HBA's..
Apr 26 2016, 7:51 PM
slm added a comment to D6101: Use callout_reset_sbt() instead of callout_reset() only if FreeBSD version is at least 1100048..

Hmmm. That's interesting. I'm not sure why I used 1100048. I made this change so that the driver would compile under 9.x as well as 10.x. I must have done some experiments and found that 1100048 was the magic number, but I'm not sure. I'll have to do some tests to see if I can use 1000029 instead. That is, I can do that if you think it's important. It's working with this change as is. Would you like me to try to figure out a version that makes more sense?

Apr 26 2016, 5:37 PM
slm added inline comments to D6096: Update MPI headers to version 42..
Apr 26 2016, 5:12 PM
slm added inline comments to D6103: Several style changes and add copyrights for 2016..
Apr 26 2016, 5:02 PM