Initialize a stack variable in mprsas_get_sas_address_for_sata_disk

[asomers]

Summary

Initialize a stack variable in mprsas_get_sas_address_for_sata_disk

Thought it's difficult to reproduce, I think this variable was responsible
for a use-after-free panic when a SATA disk times out responding to a SATA
identify command during boot.

Submitted by: slm

[asomers]

sys/dev/mpr/mpr_sas_lsi.c

930 ↗

(On Diff #24514)

@slm Is this debug message to your liking? I don't want to commit it if it isn't exactly what you want.

[slm]

sys/dev/mpr/mpr_sas_lsi.c

930 ↗

(On Diff #24514)

You shouldn't really need to print this message because mprsas_get_sata_identify will print a message already if there is a problem. You can see this message in your issue, "... request for page completed with error...". And, in fact, ioc_status and sas_status will not show anything useful if there is no reply.

[asomers]

sys/dev/mpr/mpr_sas_lsi.c

930 ↗

(On Diff #24514)

I only added this because you asked for something like it in your email dated Jan-24. Do you want something different? Or should I just remove it?

[slm]

sys/dev/mpr/mpr_sas_lsi.c

930 ↗

(On Diff #24514)

Oh, sorry. I only meant for you to add that for your own debugging purposes so that we could narrow down where the problem was. Now that we know that mpi_reply is not 0'd out, I think that's all we need and you can remove the print.

[asomers]

Remove debugging printf