Refactor MPR/MPS interrupt setup code.
ClosedPublic
Actions

Authored by scottl on Jan 19 2017, 10:57 AM.

Details

Reviewers

ken
slm
imp

Commits

rS321714: Split the interrupt setup code into two parts: allocation and configuration.

Summary

Split the interrupt setup code into two parts: allocation and
configuration. Do the allocation before requesting the IOCFacts message.
This triggers the LSI firmware to recognize the multiqueue should be
enabled if available. As a side-effect, fetch the driver tunables as
early as possible.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

scottl updated this revision to Diff 24192.Jan 19 2017, 10:57 AM

scottl retitled this revision from to Refactor MPR/MPS interrupt setup code..

scottl updated this object.

scottl edited the test plan for this revision. (Show Details)

scottl added reviewers: slm, ken, imp.

Herald edited edge metadata. · View Herald TranscriptJan 19 2017, 10:57 AM

slm added inline comments.Jan 19 2017, 6:23 PM

sys/dev/mpr/mpr_pci.c
237 ↗	(On Diff #24192)	Setting sc->msi_msgs to 0 in the 'else' part may not do anything since you set it again before exiting. 'msgs' may or may not be initialized above, so it actually looks like it's possible to set msi_msgs to an unknown value before exit.