Page MenuHomeFreeBSD

Refactor MPR/MPS interrupt setup code.
ClosedPublic

Authored by scottl on Jan 19 2017, 10:57 AM.

Details

Summary

Split the interrupt setup code into two parts: allocation and
configuration. Do the allocation before requesting the IOCFacts message.
This triggers the LSI firmware to recognize the multiqueue should be
enabled if available. As a side-effect, fetch the driver tunables as
early as possible.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

scottl updated this revision to Diff 24192.Jan 19 2017, 10:57 AM
scottl retitled this revision from to Refactor MPR/MPS interrupt setup code..
scottl updated this object.
scottl edited the test plan for this revision. (Show Details)
scottl added reviewers: slm, ken, imp.
slm added inline comments.Jan 19 2017, 6:23 PM
sys/dev/mpr/mpr_pci.c
237 ↗(On Diff #24192)

Setting sc->msi_msgs to 0 in the 'else' part may not do anything since you set it again before exiting. 'msgs' may or may not be initialized above, so it actually looks like it's possible to set msi_msgs to an unknown value before exit.

scottl updated this revision to Diff 24215.Jan 19 2017, 9:23 PM
scottl edited edge metadata.

Fix an uninitialized use of msi_msgs.

slm accepted this revision.Jan 19 2017, 9:49 PM
slm edited edge metadata.
This revision is now accepted and ready to land.Jan 19 2017, 9:49 PM