Update MPI headers to version 42.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/dev/mpr/mpi/mpi2.h | ||
|---|---|---|
| 651 ↗ | (On Diff #15592) | Since this is common platform header code, I don't think that we should be too concerned about style compliance, especially since the existing style is established and the additions do not alter it. |
| sys/dev/mpr/mpi/mpi2.h | ||
|---|---|---|
| 651 ↗ | (On Diff #15592) | I agree with Scott on this. These headers are used in all of our drivers, apps, FW, etc. I'd like to keep them as close as possible to our actual released headers that we keep internally. The FreeBSD driver headers are modified a little bit from the released versions. Some licensing stuff is added and some newer items are removed to keep them from getting out into the public too soon. Other than that, these are the actual header files. I can remove that dup'ed line however. |
Comment Actions
I agree with Steve and Scott. The MPI headers need to be largely the same between platforms. Doing otherwise will just lead to unnecessary effort.
| sys/dev/mpr/mpi/mpi2_cnfg.h | ||
|---|---|---|
| 1437 ↗ | (On Diff #15592) | I agree, this will probably cause a compile error. |
Comment Actions
I'll accept this revision even with the long lines. But they should still be fixed in Avago's source version. Some of them reach 160 characters.