Page MenuHomeFreeBSD

ambrisko (Doug A.)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 29 2016, 8:32 PM (278 w, 5 d)

Recent Activity

Fri, Jul 16

ambrisko added a comment to D31071: vmd: Rename vmd_bus class to pci.

It would be good to note, that to find out if a child is attached to vmd, that they will have to look for the vmd device and not the bus. I have some uncommitted code that had to skip a check in the PCI hot plug code when in VMD mode. So I added code to walk the chain to see how it was attached. It would be good to have a comment here why this was done.

Fri, Jul 16, 2:53 PM

Mar 16 2021

ambrisko added a comment to D29276: smbios: support getting address from EFI.

Has this been testing on systems without UEFI BIOS? I'm not sure what happens if efirt is loaded on a non-UEFI system? Please include testing on non UEFI system and UEFI system. QEMU can be used to test in legacy BIOS mode. Please include testing results from both environments. FYI, the loader should set hint.smbios.0.mem in UEFI mode so that can be used a quick check on the address. It is good to verify the address is not in the BIOS range when testing. Some UEFI systems have a combined legacy and UEFI env.

Mar 16 2021, 5:11 PM

Feb 4 2021

ambrisko committed R10:1fb5b2860444: VMD support for new devices. (authored by ambrisko).
VMD support for new devices.
Feb 4 2021, 6:05 PM

Jan 28 2021

ambrisko committed R10:0c852bb9b928: Add support for some more Intel VMD controllers. Some of the (authored by ambrisko).
Add support for some more Intel VMD controllers. Some of the
Jan 28 2021, 11:14 PM

Dec 13 2020

ambrisko committed R9:dba647178321: Announce my presence as a new committer. (authored by ambrisko).
Announce my presence as a new committer.
Dec 13 2020, 7:28 PM
ambrisko committed R9:cb4d61ee2fca: Remove myself from additional contributors section, add to developers section. (authored by ambrisko).
Remove myself from additional contributors section, add to developers section.
Dec 13 2020, 7:28 PM
ambrisko committed R9:15e6c7bff132: Add Matt Peterson for making and being the maintainer for the Linux (authored by ambrisko).
Add Matt Peterson for making and being the maintainer for the Linux
Dec 13 2020, 7:21 PM

Dec 8 2020

ambrisko accepted D27515: dev/mfi: Make a seemingly bogus conditional unconditional.

Looks good to me :-) We should never hit this code and I had never hit it before. Per the bug report this came from LSI/Avago/Broadcom via their Thunderbolt driver update before mrsas. I never understood what the issue was and never implemented the else part. This is to deal with physical disks attached to the RAID versus a volume. I put the DJA XXX so if we ever hit it we might be able to figure it out. Never hit it in real use but rarely used syspd mode.

Dec 8 2020, 7:17 PM

Oct 10 2019

ambrisko committed rS353380: This driver attaches to the Intel VMD drive and connects a new PCI domain.
This driver attaches to the Intel VMD drive and connects a new PCI domain
Oct 10 2019, 3:12 AM
ambrisko closed D21383: Add VMD support to FreeBSD.
Oct 10 2019, 3:12 AM

Sep 17 2019

ambrisko added inline comments to D21383: Add VMD support to FreeBSD.
Sep 17 2019, 10:02 PM
ambrisko updated the diff for D21383: Add VMD support to FreeBSD.

Add new line after sentence.

Sep 17 2019, 9:59 PM

Sep 7 2019

ambrisko updated the diff for D21383: Add VMD support to FreeBSD.

Accidentally removed the part that chnaged the resources for the
bus. Adding it back in the attachment.

Sep 7 2019, 11:50 PM

Sep 6 2019

ambrisko updated the diff for D21383: Add VMD support to FreeBSD.

Need to add bus_generic_attach, to probe children when not
loaded by devd.

Sep 6 2019, 11:56 PM
ambrisko updated the diff for D21383: Add VMD support to FreeBSD.

Add VMD support to FreeBSD - updated

Sep 6 2019, 10:04 PM

Sep 3 2019

ambrisko added a comment to D21383: Add VMD support to FreeBSD.

Thanks for spotting the dup. from old work.

Sep 3 2019, 11:14 PM

Aug 23 2019

ambrisko added a comment to D21383: Add VMD support to FreeBSD.

Thanks for the feed back. If's kind of a strange driver.

Aug 23 2019, 9:19 PM
ambrisko created D21383: Add VMD support to FreeBSD.
Aug 23 2019, 5:48 PM

Aug 16 2018

ambrisko committed rS337913: Fix a module Makefile error on amd64 so the IPMI HW interfaces are built..
Fix a module Makefile error on amd64 so the IPMI HW interfaces are built.
Aug 16 2018, 3:59 PM

Aug 3 2018

ambrisko updated the diff for D15683: Change image activator to check length of interpreter is less then MAXPATHLEN..

Remove NULL check since free does that.

Aug 3 2018, 6:05 PM
ambrisko added inline comments to D15683: Change image activator to check length of interpreter is less then MAXPATHLEN..
Aug 3 2018, 4:17 PM
ambrisko updated the diff for D15683: Change image activator to check length of interpreter is less then MAXPATHLEN..

Get rid of the malloc check and spurious ';'.

Aug 3 2018, 4:10 PM

Jul 25 2018

ambrisko added inline comments to D16432: Use ACPI to probe serial devices & workaround limitations in acpi support.
Jul 25 2018, 4:06 PM

Jul 23 2018

ambrisko updated the diff for D15683: Change image activator to check length of interpreter is less then MAXPATHLEN..
  1. Updating D15683: Change image activator to check length of interpreter is less then MAXPATHLEN. #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create
Jul 23 2018, 10:49 PM

Jun 6 2018

ambrisko created D15683: Change image activator to check length of interpreter is less then MAXPATHLEN..
Jun 6 2018, 10:56 PM

Feb 22 2017

ambrisko updated the diff for D8278: Make append and write work more like Linux.

Update to address comments so that writing a new variable works.
Use the sane attribute default and if the default is being used,
check for the old attribute file and use that. This could cause
an issue if the user tried to over ride the attribute but it matched
the sane default. This is probably low risk.

Feb 22 2017, 11:21 PM

Oct 18 2016

ambrisko retitled D8278: Make append and write work more like Linux from to Make append and write work more like Linux.
Oct 18 2016, 8:38 PM

Oct 14 2016

ambrisko committed rS307326: In UEFI mode expose the SMBIOS anchor base address via kenv so the kernel.
In UEFI mode expose the SMBIOS anchor base address via kenv so the kernel
Oct 14 2016, 5:11 PM

Oct 13 2016

ambrisko added a comment to D8244: KCS thread hogs the CPU.

Getting scheduled after 100µs should not be a problem, It won't
make any I/O fail. If it was less then 100µs then it would be a
problem. Taking longer on a busy machine should be a good
thing since then it working better with with other things. The
watchdog resets could take longer but I doubt this will be a
problem with that.

Oct 13 2016, 10:48 PM
ambrisko added a comment to D8244: KCS thread hogs the CPU.

That test is exactly what I wanted. So it looks good to me. I assume the CPU
load also goes way down since DELAY is a CPU hog!

Oct 13 2016, 10:35 PM
ambrisko added a comment to D8244: KCS thread hogs the CPU.

Is the performance the same versus DELAY? Yielding is something that I wanted to do and locally we
use pause in the kcs_loop which makes IPMI take a long time. We also have code to dump kernel back
traces into the SEL. In that mode things have to work in polled mode. I haven't tried to integrate that with
recent changes.

Oct 13 2016, 9:43 PM

May 27 2016

ambrisko committed rS300866: If the I/O offset and length is multiple of the media size then.
If the I/O offset and length is multiple of the media size then
May 27 2016, 7:23 PM

Apr 6 2016

ambrisko retitled D5848: Add support of 4Kn kernel dumps. from to Add support of 4Kn kernel dumps..
Apr 6 2016, 3:38 AM